#include "dirs.h"
#include "dynamic-string.h"
#include "fatal-signal.h"
+#include "json.h"
#include "leak-checker.h"
#include "netdev.h"
#include "netlink.h"
#include "timeval.h"
#include "unixctl.h"
#include "util.h"
+#include "vlog.h"
#include "vswitchd/vswitch-idl.h"
-#include "vlog.h"
-#define THIS_MODULE VLM_brcompatd
+VLOG_DEFINE_THIS_MODULE(brcompatd)
/* xxx Just hangs if datapath is rmmod/insmod. Learn to reconnect? */
return retval;
}
ofpbuf_init(&request, 0);
- nl_msg_put_genlmsghdr(&request, sock, 0, brc_family,
+ nl_msg_put_genlmsghdr(&request, 0, brc_family,
NLM_F_REQUEST, BRC_GENL_C_QUERY_MC, 1);
retval = nl_sock_transact(sock, &request, &reply);
ofpbuf_uninit(&request);
do_get_bridge_parts(br, ports, vlan, false);
}
-#if 0
-/* Go through the configuration file and remove any ports that no longer
- * exist associated with a bridge. */
-static void
-prune_ports(void)
-{
- int i, j;
- struct svec bridges, delete;
-
- if (cfg_lock(NULL, 0)) {
- /* Couldn't lock config file. */
- return;
- }
-
- svec_init(&bridges);
- svec_init(&delete);
- cfg_get_subsections(&bridges, "bridge");
- for (i=0; i<bridges.n; i++) {
- const char *br_name = bridges.names[i];
- struct svec ifaces;
-
- /* Check that each bridge interface exists. */
- svec_init(&ifaces);
- get_bridge_ifaces(br_name, &ifaces, -1);
- for (j = 0; j < ifaces.n; j++) {
- const char *iface_name = ifaces.names[j];
-
- /* The local port and internal ports are created and destroyed by
- * ovs-vswitchd itself, so don't bother checking for them at all.
- * In practice, they might not exist if ovs-vswitchd hasn't
- * finished reloading since the configuration file was updated. */
- if (!strcmp(iface_name, br_name)
- || cfg_get_bool(0, "iface.%s.internal", iface_name)) {
- continue;
- }
-
- if (!netdev_exists(iface_name)) {
- VLOG_INFO_RL(&rl, "removing dead interface %s from %s",
- iface_name, br_name);
- svec_add(&delete, iface_name);
- }
- }
- svec_destroy(&ifaces);
- }
- svec_destroy(&bridges);
-
- if (delete.n) {
- size_t i;
-
- for (i = 0; i < delete.n; i++) {
- cfg_del_match("bridge.*.port=%s", delete.names[i]);
- cfg_del_match("bonding.*.slave=%s", delete.names[i]);
- }
- reload_config();
- cfg_unlock();
- } else {
- cfg_unlock();
- }
- svec_destroy(&delete);
-}
-#endif
-
static struct ovsdb_idl_txn *
txn_from_openvswitch(const struct ovsrec_open_vswitch *ovs)
{
free(bridges);
}
+static struct json *
+where_uuid_equals(const struct uuid *uuid)
+{
+ return
+ json_array_create_1(
+ json_array_create_3(
+ json_string_create("_uuid"),
+ json_string_create("=="),
+ json_array_create_2(
+ json_string_create("uuid"),
+ json_string_create_nocopy(
+ xasprintf(UUID_FMT, UUID_ARGS(uuid))))));
+}
+
+/* Commits 'txn'. If 'wait_for_reload' is true, also waits for Open vSwitch to
+ reload the configuration before returning.
+
+ Returns EAGAIN if the caller should try the operation again, 0 on success,
+ otherwise a positive errno value. */
+static int
+commit_txn(struct ovsdb_idl_txn *txn, bool wait_for_reload)
+{
+ struct ovsdb_idl *idl = ovsdb_idl_txn_get_idl (txn);
+ enum ovsdb_idl_txn_status status;
+ int64_t next_cfg = 0;
+
+ if (wait_for_reload) {
+ const struct ovsrec_open_vswitch *ovs = ovsrec_open_vswitch_first(idl);
+ struct json *where = where_uuid_equals(&ovs->header_.uuid);
+ ovsdb_idl_txn_increment(txn, "Open_vSwitch", "next_cfg", where);
+ json_destroy(where);
+ }
+ status = ovsdb_idl_txn_commit_block(txn);
+ if (wait_for_reload && status == TXN_SUCCESS) {
+ next_cfg = ovsdb_idl_txn_get_increment_new_value(txn);
+ }
+ ovsdb_idl_txn_destroy(txn);
+
+ switch (status) {
+ case TXN_INCOMPLETE:
+ NOT_REACHED();
+
+ case TXN_ABORTED:
+ VLOG_ERR_RL(&rl, "OVSDB transaction unexpectedly aborted");
+ return ECONNABORTED;
+
+ case TXN_UNCHANGED:
+ return 0;
+
+ case TXN_SUCCESS:
+ if (wait_for_reload) {
+ for (;;) {
+ /* We can't use 'ovs' any longer because ovsdb_idl_run() can
+ * destroy it. */
+ const struct ovsrec_open_vswitch *ovs2;
+
+ ovsdb_idl_run(idl);
+ OVSREC_OPEN_VSWITCH_FOR_EACH (ovs2, idl) {
+ if (ovs2->cur_cfg >= next_cfg) {
+ goto done;
+ }
+ }
+ ovsdb_idl_wait(idl);
+ poll_block();
+ }
+ done: ;
+ }
+ return 0;
+
+ case TXN_TRY_AGAIN:
+ VLOG_ERR_RL(&rl, "OVSDB transaction needs retry");
+ return EAGAIN;
+
+ case TXN_ERROR:
+ VLOG_ERR_RL(&rl, "OVSDB transaction failed: %s",
+ ovsdb_idl_txn_get_error(txn));
+ return EBUSY;
+
+ default:
+ NOT_REACHED();
+ }
+}
+
static int
-add_bridge(const struct ovsrec_open_vswitch *ovs, const char *br_name)
+add_bridge(struct ovsdb_idl *idl, const struct ovsrec_open_vswitch *ovs,
+ const char *br_name)
{
struct ovsrec_bridge *br;
struct ovsrec_port *port;
struct ovsrec_interface *iface;
+ struct ovsdb_idl_txn *txn;
if (find_bridge(ovs, br_name)) {
VLOG_WARN("addbr %s: bridge %s exists", br_name, br_name);
return EEXIST;
}
+ txn = ovsdb_idl_txn_create(idl);
+
+ ovsdb_idl_txn_add_comment(txn, "ovs-brcompatd: addbr %s", br_name);
+
iface = ovsrec_interface_insert(txn_from_openvswitch(ovs));
ovsrec_interface_set_name(iface, br_name);
ovs_insert_bridge(ovs, br);
- VLOG_INFO("addbr %s: success", br_name);
-
- return 0;
+ return commit_txn(txn, true);
}
static void
free(ports);
}
+/* Deletes 'port' from 'br'.
+ *
+ * After calling this function, 'port' must not be referenced again. */
static void
-del_port(const struct ovsrec_bridge *br, const char *port_name)
+del_port(const struct ovsrec_bridge *br, const struct ovsrec_port *port)
{
- size_t i, j;
- struct ovsrec_port *port_rec = NULL;
+ struct ovsrec_port **ports;
+ size_t i, n;
+
+ /* Remove 'port' from the bridge's list of ports. */
+ ports = xmalloc(sizeof *br->ports * br->n_ports);
+ for (i = n = 0; i < br->n_ports; i++) {
+ if (br->ports[i] != port) {
+ ports[n++] = br->ports[i];
+ }
+ }
+ ovsrec_bridge_set_ports(br, ports, n);
+ free(ports);
+
+ /* Delete all of the port's interfaces. */
+ for (i = 0; i < port->n_interfaces; i++) {
+ ovsrec_interface_delete(port->interfaces[i]);
+ }
+
+ /* Delete the port itself. */
+ ovsrec_port_delete(port);
+}
+
+/* Delete 'iface' from 'port' (which must be within 'br'). If 'iface' was
+ * 'port''s only interface, delete 'port' from 'br' also.
+ *
+ * After calling this function, 'iface' must not be referenced again. */
+static void
+del_interface(const struct ovsrec_bridge *br,
+ const struct ovsrec_port *port,
+ const struct ovsrec_interface *iface)
+{
+ if (port->n_interfaces == 1) {
+ del_port(br, port);
+ } else {
+ struct ovsrec_interface **ifaces;
+ size_t i, n;
+
+ ifaces = xmalloc(sizeof *port->interfaces * port->n_interfaces);
+ for (i = n = 0; i < port->n_interfaces; i++) {
+ if (port->interfaces[i] != iface) {
+ ifaces[n++] = port->interfaces[i];
+ }
+ }
+ ovsrec_port_set_interfaces(port, ifaces, n);
+ free(ifaces);
+ ovsrec_interface_delete(iface);
+ }
+}
+
+/* Find and return a port within 'br' named 'port_name'. */
+static const struct ovsrec_port *
+find_port(const struct ovsrec_bridge *br, const char *port_name)
+{
+ size_t i;
for (i = 0; i < br->n_ports; i++) {
struct ovsrec_port *port = br->ports[i];
if (!strcmp(port_name, port->name)) {
- port_rec = port;
- }
- for (j = 0; j < port->n_interfaces; j++) {
- struct ovsrec_interface *iface = port->interfaces[j];
- if (!strcmp(port_name, iface->name)) {
- ovsrec_interface_delete(iface);
- }
+ return port;
}
}
+ return NULL;
+}
- /* xxx Probably can move this into the "for" loop. */
- if (port_rec) {
- struct ovsrec_port **ports;
- size_t n;
+/* Find and return an interface within 'br' named 'iface_name'. */
+static const struct ovsrec_interface *
+find_interface(const struct ovsrec_bridge *br, const char *iface_name,
+ struct ovsrec_port **portp)
+{
+ size_t i;
- ports = xmalloc(sizeof *br->ports * br->n_ports);
- for (i = n = 0; i < br->n_ports; i++) {
- if (br->ports[i] != port_rec) {
- ports[n++] = br->ports[i];
+ for (i = 0; i < br->n_ports; i++) {
+ struct ovsrec_port *port = br->ports[i];
+ size_t j;
+
+ for (j = 0; j < port->n_interfaces; j++) {
+ struct ovsrec_interface *iface = port->interfaces[j];
+ if (!strcmp(iface->name, iface_name)) {
+ *portp = port;
+ return iface;
}
}
- ovsrec_bridge_set_ports(br, ports, n);
- free(ports);
}
+
+ *portp = NULL;
+ return NULL;
}
-static int
-del_bridge(const struct ovsrec_open_vswitch *ovs, const char *br_name)
+static int
+del_bridge(struct ovsdb_idl *idl,
+ const struct ovsrec_open_vswitch *ovs, const char *br_name)
{
struct ovsrec_bridge *br = find_bridge(ovs, br_name);
struct ovsrec_bridge **bridges;
+ struct ovsdb_idl_txn *txn;
size_t i, n;
if (!br) {
return ENXIO;
}
- del_port(br, br_name);
+ txn = ovsdb_idl_txn_create(idl);
- ovsrec_bridge_delete(br);
+ ovsdb_idl_txn_add_comment(txn, "ovs-brcompatd: delbr %s", br_name);
+
+ /* Delete everything that the bridge points to, then delete the bridge
+ * itself. */
+ while (br->n_ports > 0) {
+ del_port(br, br->ports[0]);
+ }
+ for (i = 0; i < br->n_mirrors; i++) {
+ ovsrec_mirror_delete(br->mirrors[i]);
+ }
+ if (br->netflow) {
+ ovsrec_netflow_delete(br->netflow);
+ }
+ if (br->sflow) {
+ ovsrec_sflow_delete(br->sflow);
+ }
+ for (i = 0; i < br->n_controller; i++) {
+ ovsrec_controller_delete(br->controller[i]);
+ }
+ /* Remove 'br' from the vswitch's list of bridges. */
bridges = xmalloc(sizeof *ovs->bridges * ovs->n_bridges);
for (i = n = 0; i < ovs->n_bridges; i++) {
if (ovs->bridges[i] != br) {
ovsrec_open_vswitch_set_bridges(ovs, bridges, n);
free(bridges);
- VLOG_INFO("delbr %s: success", br_name);
+ /* Delete the bridge itself. */
+ ovsrec_bridge_delete(br);
- return 0;
+ return commit_txn(txn, true);
}
static int
compose_reply(uint32_t seq, int error)
{
struct ofpbuf *reply = ofpbuf_new(4096);
- nl_msg_put_genlmsghdr(reply, brc_sock, 32, brc_family, NLM_F_REQUEST,
+ nl_msg_put_genlmsghdr(reply, 32, brc_family, NLM_F_REQUEST,
BRC_GENL_C_DP_RESULT, 1);
((struct nlmsghdr *) reply->data)->nlmsg_seq = seq;
nl_msg_put_u32(reply, BRC_GENL_A_ERR_CODE, error);
}
static int
-handle_bridge_cmd(const struct ovsrec_open_vswitch *ovs,
+handle_bridge_cmd(struct ovsdb_idl *idl,
+ const struct ovsrec_open_vswitch *ovs,
struct ofpbuf *buffer, bool add)
{
const char *br_name;
error = parse_command(buffer, &seq, &br_name, NULL, NULL, NULL);
if (!error) {
- error = add ? add_bridge(ovs, br_name) : del_bridge(ovs, br_name);
+ int retval;
+
+ do {
+ retval = (add ? add_bridge : del_bridge)(idl, ovs, br_name);
+ VLOG_INFO_RL(&rl, "%sbr %s: %s",
+ add ? "add" : "del", br_name, strerror(retval));
+ } while (retval == EAGAIN);
+
send_simple_reply(seq, error);
}
return error;
};
static int
-handle_port_cmd(const struct ovsrec_open_vswitch *ovs,
+handle_port_cmd(struct ovsdb_idl *idl,
+ const struct ovsrec_open_vswitch *ovs,
struct ofpbuf *buffer, bool add)
{
const char *cmd_name = add ? "add-if" : "del-if";
cmd_name, br_name, port_name, port_name);
error = EINVAL;
} else {
- if (add) {
- add_port(ovs, br, port_name);
- } else {
- del_port(br, port_name);
- }
- VLOG_INFO("%s %s %s: success", cmd_name, br_name, port_name);
+ do {
+ struct ovsdb_idl_txn *txn = ovsdb_idl_txn_create(idl);
+
+ if (add) {
+ ovsdb_idl_txn_add_comment(txn, "ovs-brcompatd: add-if %s",
+ port_name);
+ add_port(ovs, br, port_name);
+ } else {
+ const struct ovsrec_port *port = find_port(br, port_name);
+ if (port) {
+ ovsdb_idl_txn_add_comment(txn,
+ "ovs-brcompatd: del-if %s",
+ port_name);
+ del_port(br, port);
+ }
+ }
+
+ error = commit_txn(txn, true);
+ VLOG_INFO_RL(&rl, "%s %s %s: %s",
+ cmd_name, br_name, port_name, strerror(error));
+ } while (error == EAGAIN);
}
send_simple_reply(seq, error);
}
struct netdev *netdev;
error = netdev_open_default(iface_name, &netdev);
- if (netdev) {
+ if (!error) {
if (!netdev_get_etheraddr(netdev, mac->addr)) {
n_local_macs++;
}
}
static void
-brc_recv_update(const struct ovsrec_open_vswitch *ovs)
+brc_recv_update(struct ovsdb_idl *idl)
{
int retval;
struct ofpbuf *buffer;
struct genlmsghdr *genlmsghdr;
-
+ const struct ovsrec_open_vswitch *ovs;
buffer = NULL;
do {
goto error;
}
- /* Just drop the request on the floor if a valid configuration
- * doesn't exist. We don't immediately do this check, because we
- * want to drain pending netlink messages. */
+ /* Get the Open vSwitch configuration. Just drop the request on the floor
+ * if a valid configuration doesn't exist. (We could check this earlier,
+ * but we want to drain pending Netlink messages even when there is no Open
+ * vSwitch configuration.) */
+ ovs = ovsrec_open_vswitch_first(idl);
if (!ovs) {
VLOG_WARN_RL(&rl, "could not find valid configuration to update");
goto error;
switch (genlmsghdr->cmd) {
case BRC_GENL_C_DP_ADD:
- handle_bridge_cmd(ovs, buffer, true);
+ handle_bridge_cmd(idl, ovs, buffer, true);
break;
case BRC_GENL_C_DP_DEL:
- handle_bridge_cmd(ovs, buffer, false);
+ handle_bridge_cmd(idl, ovs, buffer, false);
break;
case BRC_GENL_C_PORT_ADD:
- handle_port_cmd(ovs, buffer, true);
+ handle_port_cmd(idl, ovs, buffer, true);
break;
case BRC_GENL_C_PORT_DEL:
- handle_port_cmd(ovs, buffer, false);
+ handle_port_cmd(idl, ovs, buffer, false);
break;
case BRC_GENL_C_FDB_QUERY:
default:
VLOG_WARN_RL(&rl, "received unknown brc netlink command: %d\n",
- genlmsghdr->cmd);
+ genlmsghdr->cmd);
break;
}
/* Check for interface configuration changes announced through RTNL. */
static void
-rtnl_recv_update(const struct ovsrec_open_vswitch *ovs)
+rtnl_recv_update(struct ovsdb_idl *idl,
+ const struct ovsrec_open_vswitch *ovs)
{
struct ofpbuf *buf;
if (!netdev_exists(port_name)) {
/* Network device is really gone. */
- struct ovsrec_bridge *br = find_bridge(ovs, br_name);
+ struct ovsdb_idl_txn *txn;
+ const struct ovsrec_interface *iface;
+ struct ovsrec_port *port;
+ struct ovsrec_bridge *br;
VLOG_INFO("network device %s destroyed, "
"removing from bridge %s", port_name, br_name);
+ br = find_bridge(ovs, br_name);
if (!br) {
VLOG_WARN("no bridge named %s from which to remove %s",
br_name, port_name);
return;
}
- del_port(br, port_name);
+ txn = ovsdb_idl_txn_create(idl);
+
+ iface = find_interface(br, port_name, &port);
+ if (iface) {
+ del_interface(br, port, iface);
+ ovsdb_idl_txn_add_comment(txn,
+ "ovs-brcompatd: destroy port %s",
+ port_name);
+ }
+
+ commit_txn(txn, false);
} else {
/* A network device by that name exists even though the kernel
* told us it had disappeared. Probably, what happened was
proctitle_init(argc, argv);
set_program_name(argv[0]);
- time_init();
- vlog_init();
vlog_set_levels(VLM_ANY_MODULE, VLF_CONSOLE, VLL_WARN);
vlog_set_levels(VLM_reconnect, VLF_ANY_FACILITY, VLL_WARN);
for (;;) {
const struct ovsrec_open_vswitch *ovs;
- struct ovsdb_idl_txn *txn;
- enum ovsdb_idl_txn_status status;
ovsdb_idl_run(idl);
- txn = ovsdb_idl_txn_create(idl);
-
unixctl_server_run(unixctl);
- ovs = ovsrec_open_vswitch_first(idl);
- brc_recv_update(ovs);
+ brc_recv_update(idl);
+ ovs = ovsrec_open_vswitch_first(idl);
if (!ovs && ovsdb_idl_has_ever_connected(idl)) {
static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(1, 1);
VLOG_WARN_RL(&rl, "%s: database does not contain any Open vSwitch "
* to see if they no longer exist.
*/
if (ovs && prune_timeout) {
- rtnl_recv_update(ovs);
-#if 0
- prune_ports();
-#endif
-
+ rtnl_recv_update(idl, ovs);
nl_sock_wait(rtnl_sock, POLLIN);
poll_timer_wait(prune_timeout);
}
- while ((status = ovsdb_idl_txn_commit(txn)) == TXN_INCOMPLETE) {
- ovsdb_idl_run(idl);
- ovsdb_idl_wait(idl);
- ovsdb_idl_txn_wait(txn);
- poll_block();
- }
-
- switch (status) {
- case TXN_INCOMPLETE:
- NOT_REACHED();
-
- case TXN_ABORTED:
- /* Should not happen--we never call ovsdb_idl_txn_abort(). */
- ovs_fatal(0, "transaction aborted");
-
- case TXN_SUCCESS:
- case TXN_UNCHANGED:
- break;
-
- case TXN_TRY_AGAIN:
- /* xxx Handle this better! */
- VLOG_ERR("OVSDB transaction needs retry");
- break;
-
- case TXN_ERROR:
- /* xxx Handle this better! */
- VLOG_ERR("OVSDB transaction failed: %s",
- ovsdb_idl_txn_get_error(txn));
- break;
-
- default:
- NOT_REACHED();
- }
- ovsdb_idl_txn_destroy(txn);
nl_sock_wait(brc_sock, POLLIN);
ovsdb_idl_wait(idl);