#!/usr/bin/python
-# Copyright (c) 2009, 2010, 2011 Nicira Networks
+# Copyright (c) 2009, 2010, 2011, 2012 Nicira Networks
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# - Set the "iface-id" key in the Interface table.
# - Set the fail-mode on internal bridges.
-import getopt
-import logging
-import logging.handlers
+import argparse
import os
import signal
-import subprocess
import sys
import time
import ovs.dirs
from ovs.db import error
from ovs.db import types
-import ovs.util
import ovs.daemon
import ovs.db.idl
root_prefix = '' # Prefix for absolute file names, for testing.
-s_log = logging.getLogger("ovs-xapi-sync")
-vsctl = "/usr/bin/ovs-vsctl"
+vlog = ovs.vlog.Vlog("ovs-xapi-sync")
session = None
force_run = False
session.xenapi.login_with_password("", "")
except XenAPI.Failure, e:
session = None
- s_log.warning("Couldn't login to XAPI (%s)" % e)
+ vlog.warn("Couldn't login to XAPI (%s)" % e)
return False
return True
def get_network_by_bridge(br_name):
if not init_session():
- s_log.warning("Failed to get bridge id %s because"
+ vlog.warn("Failed to get bridge id %s because"
" XAPI session could not be initialized" % br_name)
return None
return xs_vif_uuid
if not init_session():
- s_log.warning("Failed to get interface id %s because"
+ vlog.warn("Failed to get interface id %s because"
" XAPI session could not be initialized" % if_name)
return xs_vif_uuid
rec = session.xenapi.VIF.get_record(vif)
return rec['other_config'].get('nicira-iface-id', xs_vif_uuid)
except XenAPI.Failure:
- s_log.warning("Could not find XAPI entry for VIF %s" % if_name)
+ vlog.warn("Could not find XAPI entry for VIF %s" % if_name)
return xs_vif_uuid
-def call_vsctl(args):
- cmd = [vsctl, "--timeout=30", "-vANY:console:off"] + args
- exitcode = subprocess.call(cmd)
- if exitcode != 0:
- s_log.warning("Couldn't call ovs-vsctl")
-
-
def set_or_delete(d, key, value):
if value is None:
if key in d:
other_config = row.other_config
if dib and dib not in ['true', 'false']:
- s_log.warning('"%s" isn\'t a valid setting for '
- "other_config:disable-in-band on %s" % (dib, row.name))
+ vlog.warn('"%s" isn\'t a valid setting for '
+ "other_config:disable-in-band on %s" % (dib, row.name))
elif set_or_delete(other_config, 'disable-in-band', dib):
row.other_config = other_config
schema.tables = new_tables
-def usage():
- print "usage: %s [OPTIONS] DATABASE" % sys.argv[0]
- print "where DATABASE is a socket on which ovsdb-server is listening."
- ovs.daemon.usage()
- print """\
-Other options:
- --root-prefix=DIR Use DIR as alternate root directory (for testing).
- -h, --help display this help message"""
- sys.exit(0)
-
-
def handler(signum, _):
global force_run
if (signum == signal.SIGHUP):
force_run = True
-def main(argv):
+def main():
global force_run
- s_log.addHandler(logging.StreamHandler())
- try:
- l_handler = logging.handlers.RotatingFileHandler(
- "/var/log/openvswitch/ovs-xapi-sync.log")
- l_formatter = logging.Formatter('%(filename)s: %(levelname)s: %(message)s')
- l_handler.setFormatter(l_formatter)
- s_log.addHandler(l_handler)
- except IOError, e:
- logging.basicConfig()
- s_log.warn("failed to open logfile (%s)" % e)
- s_log.setLevel(logging.INFO)
+ parser = argparse.ArgumentParser()
+ parser.add_argument("database", metavar="DATABASE",
+ help="A socket on which ovsdb-server is listening.")
+ parser.add_argument("--root-prefix", metavar="DIR",
+ help="Use DIR as alternate root directory"
+ " (for testing).")
- try:
- options, args = getopt.gnu_getopt(
- argv[1:], 'h', ['help', 'root-prefix='] + ovs.daemon.LONG_OPTIONS)
- except getopt.GetoptError, geo:
- sys.stderr.write("%s: %s\n" % (ovs.util.PROGRAM_NAME, geo.msg))
- sys.exit(1)
-
- for key, value in options:
- if key in ['-h', '--help']:
- usage()
- elif key == '--root-prefix':
- global root_prefix
- root_prefix = value
- elif not ovs.daemon.parse_opt(key, value):
- sys.stderr.write("%s: unhandled option %s\n"
- % (ovs.util.PROGRAM_NAME, key))
- sys.exit(1)
-
- if len(args) != 1:
- sys.stderr.write("%s: exactly one nonoption argument is required "
- "(use --help for help)\n" % ovs.util.PROGRAM_NAME)
- sys.exit(1)
-
- remote = args[0]
+ ovs.vlog.add_args(parser)
+ ovs.daemon.add_args(parser)
+ args = parser.parse_args()
+ ovs.vlog.handle_args(args)
+ ovs.daemon.handle_args(args)
+
+ global root_prefix
+ if args.root_prefix:
+ root_prefix = args.root_prefix
+
+ remote = args.database
schema_file = "%s/vswitch.ovsschema" % ovs.dirs.PKGDATADIR
schema = ovs.db.schema.DbSchema.from_json(ovs.json.from_file(schema_file))
prune_schema(schema)
signal.signal(signal.SIGHUP, handler)
bridges = {} # Map from bridge name to xs_network_uuids
- interfaces = {} # Map from interface name to xs-vif-uuid
+ iface_ids = {} # Map from xs-vif-uuid to iface-id
while True:
if not force_run and not idl.run():
poller = ovs.poller.Poller()
continue
if force_run:
- s_log.info("Forced to re-run as the result of a SIGHUP")
+ vlog.info("Forced to re-run as the result of a SIGHUP")
bridges = {}
- interfaces = {}
+ iface_ids = {}
force_run = False
txn = ovs.db.idl.Transaction(idl)
for row in idl.tables["Interface"].rows.itervalues():
iface_by_name[row.name] = row
- new_interfaces = {}
+ new_iface_ids = {}
for row in idl.tables["Interface"].rows.itervalues():
# Match up paired vif and tap devices.
if row.name.startswith("vif"):
for k in keys:
set_external_id(row, k, vif.external_ids.get(k))
- # If it's a new interface or its xs-vif-uuid has changed, then
- # obtain the iface-id from XAPI.
+ # Map from xs-vif-uuid to iface-id.
#
# (A tap's xs-vif-uuid comes from its vif. That falls out
# naturally from the copy loop above.)
- new_xvu = row.external_ids.get("xs-vif-uuid", "")
- old_xvu = interfaces.get(row.name)
- if old_xvu != new_xvu:
- iface_id = get_iface_id(row.name, new_xvu)
- if iface_id and row.external_ids.get("iface-id") != iface_id:
- set_external_id(row, "iface-id", iface_id)
+ xvu = row.external_ids.get("xs-vif-uuid")
+ if xvu:
+ iface_id = (new_iface_ids.get(xvu)
+ or iface_ids.get(xvu)
+ or get_iface_id(row.name, xvu))
+ new_iface_ids[xvu] = iface_id
+ else:
+ # No xs-vif-uuid therefore no iface-id.
+ iface_id = None
+ set_external_id(row, "iface-id", iface_id)
# When there's a vif and a tap, the tap is active (used for
# traffic). When there's just a vif, the vif is active.
set_external_id(vif, "iface-status", "active")
else:
set_external_id(row, "iface-status", None)
-
- new_interfaces[row.name] = new_xvu
- interfaces = new_interfaces
+ iface_ids = new_iface_ids
txn.commit_block()
if __name__ == '__main__':
try:
- main(sys.argv)
+ main()
except SystemExit:
# Let system.exit() calls complete normally
raise
except:
- s_log.exception("traceback")
+ vlog.exception("traceback")
sys.exit(ovs.daemon.RESTART_EXIT_CODE)