convert port to an int before passing it to httplib.HTTPSConnection(). It

fails otherwise.

Also, rename a local variable from 'int' to 'inter' to make available the
conversion function for the above.

diff --git a/source/steps/WriteNetworkConfig.py b/source/steps/WriteNetworkConfig.py
index a58cc87..9d5fd81 100644 (file)
--- a/source/steps/WriteNetworkConfig.py
+++ b/source/steps/WriteNetworkConfig.py
@@ -108,7 +108,7 @@ def Run( vars, log ):
         port = '80'
     try:
         log.write("getting via https://%s/PlanetLabConf/get_plc_config.php" % host)
-        bootserver = httplib.HTTPSConnection(host, port)
+        bootserver = httplib.HTTPSConnection(host, int(port))
         bootserver.connect()
         bootserver.request("GET","https://%s/PlanetLabConf/get_plc_config.php" % host)
         plc_config.write("%s" % bootserver.getresponse().read())
@@ -164,23 +164,23 @@ def Run( vars, log ):
                 ifnum = interface
                 interface += 1
 
-            int = {}
+            inter = {}
             if network['mac']:
-                int['HWADDR'] = network['mac']
+                inter['HWADDR'] = network['mac']
 
             if network['method'] == "static":
-                int['BOOTPROTO'] = "static"
-                int['IPADDR'] = network['ip']
-                int['NETMASK'] = network['netmask']
+                inter['BOOTPROTO'] = "static"
+                inter['IPADDR'] = network['ip']
+                inter['NETMASK'] = network['netmask']
 
             elif network['method'] == "dhcp":
-                int['BOOTPROTO'] = "dhcp"
+                inter['BOOTPROTO'] = "dhcp"
                 if network['hostname']:
-                    int['DHCP_HOSTNAME'] = network['hostname']
+                    inter['DHCP_HOSTNAME'] = network['hostname']
                 else:
-                    int['DHCP_HOSTNAME'] = hostname
+                    inter['DHCP_HOSTNAME'] = hostname
                 if not network['is_primary']:
-                    int['DHCLIENTARGS'] = "-R subnet-mask"
+                    inter['DHCLIENTARGS'] = "-R subnet-mask"
 
             alias = ""
             ifname=None
@@ -201,32 +201,32 @@ def Run( vars, log ):
                     # use the backdoor setting and put as a value 'var=value'
                     elif setting['name'].upper() == "BACKDOOR":
                         [var,value]=setting['value'].split('=',1)
-                        int[var]=value
+                        inter[var]=value
 
                     elif setting['name'].lower() in \
                             [  "mode", "essid", "nw", "freq", "channel", "sens", "rate",
                                "key", "key1", "key2", "key3", "key4", "securitymode", 
                                "iwconfig", "iwpriv" ] :
-                        int [setting['name'].upper()] = setting['value']
-                        int ['TYPE']='Wireless'
+                        inter [setting['name'].upper()] = setting['value']
+                        inter ['TYPE']='Wireless'
                     else:
                         log.write("Warning - ignored setting named %s\n"%setting['name'])
 
-            if alias and 'HWADDR' in int:
+            if alias and 'HWADDR' in inter:
                 for (dev, i) in interfaces.iteritems():
-                    if i['HWADDR'] == int['HWADDR']:
+                    if i['HWADDR'] == inter['HWADDR']:
                         break
-                del int['HWADDR']
-                interfaces[dev + alias] = int
+                del inter['HWADDR']
+                interfaces[dev + alias] =inter 
                 interface -= 1
             else:
                 if not ifname:
                     ifname="eth%d" % ifnum
                 else:
                     interface -= 1
-                interfaces[ifname] = int
+                interfaces[ifname] =inter 
 
-    for (dev, int) in interfaces.iteritems():
+    for (dev, inter) in interfaces.iteritems():
         path = "%s/etc/sysconfig/network-scripts/ifcfg-%s" % (
                SYSIMG_PATH, dev)
         f = file(path, "w")
@@ -235,7 +235,7 @@ def Run( vars, log ):
         f.write("DEVICE=%s\n" % dev)
         f.write("ONBOOT=yes\n")
         f.write("USERCTL=no\n")
-        for (key, val) in int.iteritems():
+        for (key, val) in inter.iteritems():
             f.write('%s="%s"\n' % (key, val))
 
         f.close()