comments about how noderepo is done

diff --git a/onelab.mk b/onelab.mk
index 7bdebd7..d7d8eae 100644 (file)
--- a/onelab.mk
+++ b/onelab.mk
@@ -341,7 +341,7 @@ IN_MYPLC += bootstrapfs
 #
 # all rpms resulting from packages marked as being in bootstrapfs and vserver
 NODEREPO_RPMS = $(foreach package,$(IN_BOOTSTRAPFS) $(IN_VSERVER),$($(package).rpms))
-# replace space with +++
+# replace space with +++ (specvars cannot deal with spaces)
 SPACE=$(subst x, ,x)
 NODEREPO_RPMS_3PLUS = $(subst $(SPACE),+++,$(NODEREPO_RPMS))
 
@@ -351,6 +351,7 @@ noderepo-RPMBUILD := sudo bash ./rpmbuild.sh
 # package requires all regular packages
 noderepo-DEPEND-PACKAGES := $(IN_BOOTSTRAPFS) $(IN_VSERVER)
 noderepo-DEPEND-FILES := RPMS/yumgroups.xml
+#export rpm list to the specfile
 noderepo-SPECVARS = node_rpms_plus=$(NODEREPO_RPMS_3PLUS)
 # not yet
 ALL += noderepo