fedora core 6 1.2949 + vserver 2.2.0
[linux-2.6.git] / arch / powerpc / mm / numa.c
index 2863a91..2627909 100644 (file)
@@ -39,100 +39,12 @@ static bootmem_data_t __initdata plat_node_bdata[MAX_NUMNODES];
 static int min_common_depth;
 static int n_mem_addr_cells, n_mem_size_cells;
 
-/*
- * We need somewhere to store start/end/node for each region until we have
- * allocated the real node_data structures.
- */
-#define MAX_REGIONS    (MAX_LMB_REGIONS*2)
-static struct {
-       unsigned long start_pfn;
-       unsigned long end_pfn;
-       int nid;
-} init_node_data[MAX_REGIONS] __initdata;
-
-int __init early_pfn_to_nid(unsigned long pfn)
-{
-       unsigned int i;
-
-       for (i = 0; init_node_data[i].end_pfn; i++) {
-               unsigned long start_pfn = init_node_data[i].start_pfn;
-               unsigned long end_pfn = init_node_data[i].end_pfn;
-
-               if ((start_pfn <= pfn) && (pfn < end_pfn))
-                       return init_node_data[i].nid;
-       }
-
-       return -1;
-}
-
-void __init add_region(unsigned int nid, unsigned long start_pfn,
-                      unsigned long pages)
-{
-       unsigned int i;
-
-       dbg("add_region nid %d start_pfn 0x%lx pages 0x%lx\n",
-               nid, start_pfn, pages);
-
-       for (i = 0; init_node_data[i].end_pfn; i++) {
-               if (init_node_data[i].nid != nid)
-                       continue;
-               if (init_node_data[i].end_pfn == start_pfn) {
-                       init_node_data[i].end_pfn += pages;
-                       return;
-               }
-               if (init_node_data[i].start_pfn == (start_pfn + pages)) {
-                       init_node_data[i].start_pfn -= pages;
-                       return;
-               }
-       }
-
-       /*
-        * Leave last entry NULL so we dont iterate off the end (we use
-        * entry.end_pfn to terminate the walk).
-        */
-       if (i >= (MAX_REGIONS - 1)) {
-               printk(KERN_ERR "WARNING: too many memory regions in "
-                               "numa code, truncating\n");
-               return;
-       }
-
-       init_node_data[i].start_pfn = start_pfn;
-       init_node_data[i].end_pfn = start_pfn + pages;
-       init_node_data[i].nid = nid;
-}
-
-/* We assume init_node_data has no overlapping regions */
-void __init get_region(unsigned int nid, unsigned long *start_pfn,
-                      unsigned long *end_pfn, unsigned long *pages_present)
-{
-       unsigned int i;
-
-       *start_pfn = -1UL;
-       *end_pfn = *pages_present = 0;
-
-       for (i = 0; init_node_data[i].end_pfn; i++) {
-               if (init_node_data[i].nid != nid)
-                       continue;
-
-               *pages_present += init_node_data[i].end_pfn -
-                       init_node_data[i].start_pfn;
-
-               if (init_node_data[i].start_pfn < *start_pfn)
-                       *start_pfn = init_node_data[i].start_pfn;
-
-               if (init_node_data[i].end_pfn > *end_pfn)
-                       *end_pfn = init_node_data[i].end_pfn;
-       }
-
-       /* We didnt find a matching region, return start/end as 0 */
-       if (*start_pfn == -1UL)
-               *start_pfn = 0;
-}
-
-static inline void map_cpu_to_node(int cpu, int node)
+static void __cpuinit map_cpu_to_node(int cpu, int node)
 {
        numa_cpu_lookup_table[cpu] = node;
 
+       dbg("adding cpu %d to node %d\n", cpu, node);
+
        if (!(cpu_isset(cpu, numa_cpumask_lookup_table[node])))
                cpu_set(cpu, numa_cpumask_lookup_table[node]);
 }
@@ -153,16 +65,16 @@ static void unmap_cpu_from_node(unsigned long cpu)
 }
 #endif /* CONFIG_HOTPLUG_CPU */
 
-static struct device_node *find_cpu_node(unsigned int cpu)
+static struct device_node * __cpuinit find_cpu_node(unsigned int cpu)
 {
        unsigned int hw_cpuid = get_hard_smp_processor_id(cpu);
        struct device_node *cpu_node = NULL;
-       unsigned int *interrupt_server, *reg;
+       const unsigned int *interrupt_server, *reg;
        int len;
 
        while ((cpu_node = of_find_node_by_type(cpu_node, "cpu")) != NULL) {
                /* Try interrupt server first */
-               interrupt_server = (unsigned int *)get_property(cpu_node,
+               interrupt_server = get_property(cpu_node,
                                        "ibm,ppc-interrupt-server#s", &len);
 
                len = len / sizeof(u32);
@@ -173,8 +85,7 @@ static struct device_node *find_cpu_node(unsigned int cpu)
                                        return cpu_node;
                        }
                } else {
-                       reg = (unsigned int *)get_property(cpu_node,
-                                                          "reg", &len);
+                       reg = get_property(cpu_node, "reg", &len);
                        if (reg && (len > 0) && (reg[0] == hw_cpuid))
                                return cpu_node;
                }
@@ -184,29 +95,57 @@ static struct device_node *find_cpu_node(unsigned int cpu)
 }
 
 /* must hold reference to node during call */
-static int *of_get_associativity(struct device_node *dev)
+static const int *of_get_associativity(struct device_node *dev)
 {
-       return (unsigned int *)get_property(dev, "ibm,associativity", NULL);
+       return get_property(dev, "ibm,associativity", NULL);
 }
 
-static int of_node_numa_domain(struct device_node *device)
+/* Returns nid in the range [0..MAX_NUMNODES-1], or -1 if no useful numa
+ * info is found.
+ */
+static int of_node_to_nid_single(struct device_node *device)
 {
-       int numa_domain;
-       unsigned int *tmp;
+       int nid = -1;
+       const unsigned int *tmp;
 
        if (min_common_depth == -1)
-               return 0;
+               goto out;
 
        tmp = of_get_associativity(device);
-       if (tmp && (tmp[0] >= min_common_depth)) {
-               numa_domain = tmp[min_common_depth];
-       } else {
-               dbg("WARNING: no NUMA information for %s\n",
-                   device->full_name);
-               numa_domain = 0;
+       if (!tmp)
+               goto out;
+
+       if (tmp[0] >= min_common_depth)
+               nid = tmp[min_common_depth];
+
+       /* POWER4 LPAR uses 0xffff as invalid node */
+       if (nid == 0xffff || nid >= MAX_NUMNODES)
+               nid = -1;
+out:
+       return nid;
+}
+
+/* Walk the device tree upwards, looking for an associativity id */
+int of_node_to_nid(struct device_node *device)
+{
+       struct device_node *tmp;
+       int nid = -1;
+
+       of_node_get(device);
+       while (device) {
+               nid = of_node_to_nid_single(device);
+               if (nid != -1)
+                       break;
+
+               tmp = device;
+               device = of_get_parent(tmp);
+               of_node_put(tmp);
        }
-       return numa_domain;
+       of_node_put(device);
+
+       return nid;
 }
+EXPORT_SYMBOL_GPL(of_node_to_nid);
 
 /*
  * In theory, the "ibm,associativity" property may contain multiple
@@ -225,7 +164,7 @@ static int of_node_numa_domain(struct device_node *device)
 static int __init find_min_common_depth(void)
 {
        int depth;
-       unsigned int *ref_points;
+       const unsigned int *ref_points;
        struct device_node *rtas_root;
        unsigned int len;
 
@@ -240,14 +179,13 @@ static int __init find_min_common_depth(void)
         * configuration (should be all 0's) and the second is for a normal
         * NUMA configuration.
         */
-       ref_points = (unsigned int *)get_property(rtas_root,
+       ref_points = get_property(rtas_root,
                        "ibm,associativity-reference-points", &len);
 
        if ((len >= 1) && ref_points) {
                depth = ref_points[1];
        } else {
-               dbg("WARNING: could not find NUMA "
-                   "associativity reference point\n");
+               dbg("NUMA: ibm,associativity-reference-points not found.\n");
                depth = -1;
        }
        of_node_put(rtas_root);
@@ -268,7 +206,7 @@ static void __init get_n_mem_cells(int *n_addr_cells, int *n_size_cells)
        of_node_put(memory);
 }
 
-static unsigned long __devinit read_n_cells(int n, unsigned int **buf)
+static unsigned long __devinit read_n_cells(int n, const unsigned int **buf)
 {
        unsigned long result = 0;
 
@@ -283,9 +221,9 @@ static unsigned long __devinit read_n_cells(int n, unsigned int **buf)
  * Figure out to which domain a cpu belongs and stick it there.
  * Return the id of the domain used.
  */
-static int numa_setup_cpu(unsigned long lcpu)
+static int __cpuinit numa_setup_cpu(unsigned long lcpu)
 {
-       int numa_domain = 0;
+       int nid = 0;
        struct device_node *cpu = find_cpu_node(lcpu);
 
        if (!cpu) {
@@ -293,30 +231,19 @@ static int numa_setup_cpu(unsigned long lcpu)
                goto out;
        }
 
-       numa_domain = of_node_numa_domain(cpu);
+       nid = of_node_to_nid_single(cpu);
 
-       if (numa_domain >= num_online_nodes()) {
-               /*
-                * POWER4 LPAR uses 0xffff as invalid node,
-                * dont warn in this case.
-                */
-               if (numa_domain != 0xffff)
-                       printk(KERN_ERR "WARNING: cpu %ld "
-                              "maps to invalid NUMA node %d\n",
-                              lcpu, numa_domain);
-               numa_domain = 0;
-       }
+       if (nid < 0 || !node_online(nid))
+               nid = any_online_node(NODE_MASK_ALL);
 out:
-       node_set_online(numa_domain);
-
-       map_cpu_to_node(lcpu, numa_domain);
+       map_cpu_to_node(lcpu, nid);
 
        of_node_put(cpu);
 
-       return numa_domain;
+       return nid;
 }
 
-static int cpu_numa_callback(struct notifier_block *nfb,
+static int __cpuinit cpu_numa_callback(struct notifier_block *nfb,
                             unsigned long action,
                             void *hcpu)
 {
@@ -325,10 +252,7 @@ static int cpu_numa_callback(struct notifier_block *nfb,
 
        switch (action) {
        case CPU_UP_PREPARE:
-               if (min_common_depth == -1 || !numa_enabled)
-                       map_cpu_to_node(lcpu, 0);
-               else
-                       numa_setup_cpu(lcpu);
+               numa_setup_cpu(lcpu);
                ret = NOTIFY_OK;
                break;
 #ifdef CONFIG_HOTPLUG_CPU
@@ -371,11 +295,68 @@ static unsigned long __init numa_enforce_memory_limit(unsigned long start,
        return lmb_end_of_DRAM() - start;
 }
 
+/*
+ * Extract NUMA information from the ibm,dynamic-reconfiguration-memory
+ * node.  This assumes n_mem_{addr,size}_cells have been set.
+ */
+static void __init parse_drconf_memory(struct device_node *memory)
+{
+       const unsigned int *lm, *dm, *aa;
+       unsigned int ls, ld, la;
+       unsigned int n, aam, aalen;
+       unsigned long lmb_size, size;
+       int nid, default_nid = 0;
+       unsigned int start, ai, flags;
+
+       lm = get_property(memory, "ibm,lmb-size", &ls);
+       dm = get_property(memory, "ibm,dynamic-memory", &ld);
+       aa = get_property(memory, "ibm,associativity-lookup-arrays", &la);
+       if (!lm || !dm || !aa ||
+           ls < sizeof(unsigned int) || ld < sizeof(unsigned int) ||
+           la < 2 * sizeof(unsigned int))
+               return;
+
+       lmb_size = read_n_cells(n_mem_size_cells, &lm);
+       n = *dm++;              /* number of LMBs */
+       aam = *aa++;            /* number of associativity lists */
+       aalen = *aa++;          /* length of each associativity list */
+       if (ld < (n * (n_mem_addr_cells + 4) + 1) * sizeof(unsigned int) ||
+           la < (aam * aalen + 2) * sizeof(unsigned int))
+               return;
+
+       for (; n != 0; --n) {
+               start = read_n_cells(n_mem_addr_cells, &dm);
+               ai = dm[2];
+               flags = dm[3];
+               dm += 4;
+               /* 0x80 == reserved, 0x8 = assigned to us */
+               if ((flags & 0x80) || !(flags & 0x8))
+                       continue;
+               nid = default_nid;
+               /* flags & 0x40 means associativity index is invalid */
+               if (min_common_depth > 0 && min_common_depth <= aalen &&
+                   (flags & 0x40) == 0 && ai < aam) {
+                       /* this is like of_node_to_nid_single */
+                       nid = aa[ai * aalen + min_common_depth - 1];
+                       if (nid == 0xffff || nid >= MAX_NUMNODES)
+                               nid = default_nid;
+               }
+               node_set_online(nid);
+
+               size = numa_enforce_memory_limit(start, lmb_size);
+               if (!size)
+                       continue;
+
+               add_active_range(nid, start >> PAGE_SHIFT,
+                                (start >> PAGE_SHIFT) + (size >> PAGE_SHIFT));
+       }
+}
+
 static int __init parse_numa_properties(void)
 {
        struct device_node *cpu = NULL;
        struct device_node *memory = NULL;
-       int max_domain;
+       int default_nid = 0;
        unsigned long i;
 
        if (numa_enabled == 0) {
@@ -385,32 +366,32 @@ static int __init parse_numa_properties(void)
 
        min_common_depth = find_min_common_depth();
 
-       dbg("NUMA associativity depth for CPU/Memory: %d\n", min_common_depth);
        if (min_common_depth < 0)
                return min_common_depth;
 
-       max_domain = numa_setup_cpu(boot_cpuid);
+       dbg("NUMA associativity depth for CPU/Memory: %d\n", min_common_depth);
 
        /*
-        * Even though we connect cpus to numa domains later in SMP init,
-        * we need to know the maximum node id now. This is because each
-        * node id must have NODE_DATA etc backing it.
-        * As a result of hotplug we could still have cpus appear later on
-        * with larger node ids. In that case we force the cpu into node 0.
+        * Even though we connect cpus to numa domains later in SMP
+        * init, we need to know the node ids now. This is because
+        * each node to be onlined must have NODE_DATA etc backing it.
         */
-       for_each_cpu(i) {
-               int numa_domain;
+       for_each_present_cpu(i) {
+               int nid;
 
                cpu = find_cpu_node(i);
+               BUG_ON(!cpu);
+               nid = of_node_to_nid_single(cpu);
+               of_node_put(cpu);
 
-               if (cpu) {
-                       numa_domain = of_node_numa_domain(cpu);
-                       of_node_put(cpu);
-
-                       if (numa_domain < MAX_NUMNODES &&
-                           max_domain < numa_domain)
-                               max_domain = numa_domain;
-               }
+               /*
+                * Don't fall back to default_nid yet -- we will plug
+                * cpus into nodes once the memory scan has discovered
+                * the topology.
+                */
+               if (nid < 0)
+                       continue;
+               node_set_online(nid);
        }
 
        get_n_mem_cells(&n_mem_addr_cells, &n_mem_size_cells);
@@ -418,17 +399,15 @@ static int __init parse_numa_properties(void)
        while ((memory = of_find_node_by_type(memory, "memory")) != NULL) {
                unsigned long start;
                unsigned long size;
-               int numa_domain;
+               int nid;
                int ranges;
-               unsigned int *memcell_buf;
+               const unsigned int *memcell_buf;
                unsigned int len;
 
-               memcell_buf = (unsigned int *)get_property(memory,
+               memcell_buf = get_property(memory,
                        "linux,usable-memory", &len);
                if (!memcell_buf || len <= 0)
-                       memcell_buf =
-                               (unsigned int *)get_property(memory, "reg",
-                                       &len);
+                       memcell_buf = get_property(memory, "reg", &len);
                if (!memcell_buf || len <= 0)
                        continue;
 
@@ -439,18 +418,15 @@ new_range:
                start = read_n_cells(n_mem_addr_cells, &memcell_buf);
                size = read_n_cells(n_mem_size_cells, &memcell_buf);
 
-               numa_domain = of_node_numa_domain(memory);
-
-               if (numa_domain >= MAX_NUMNODES) {
-                       if (numa_domain != 0xffff)
-                               printk(KERN_ERR "WARNING: memory at %lx maps "
-                                      "to invalid NUMA node %d\n", start,
-                                      numa_domain);
-                       numa_domain = 0;
-               }
-
-               if (max_domain < numa_domain)
-                       max_domain = numa_domain;
+               /*
+                * Assumption: either all memory nodes or none will
+                * have associativity properties.  If none, then
+                * everything goes to default_nid.
+                */
+               nid = of_node_to_nid_single(memory);
+               if (nid < 0)
+                       nid = default_nid;
+               node_set_online(nid);
 
                if (!(size = numa_enforce_memory_limit(start, size))) {
                        if (--ranges)
@@ -459,15 +435,20 @@ new_range:
                                continue;
                }
 
-               add_region(numa_domain, start >> PAGE_SHIFT,
-                          size >> PAGE_SHIFT);
+               add_active_range(nid, start >> PAGE_SHIFT,
+                               (start >> PAGE_SHIFT) + (size >> PAGE_SHIFT));
 
                if (--ranges)
                        goto new_range;
        }
 
-       for (i = 0; i <= max_domain; i++)
-               node_set_online(i);
+       /*
+        * Now do the same thing for each LMB listed in the ibm,dynamic-memory
+        * property in the ibm,dynamic-reconfiguration-memory node.
+        */
+       memory = of_find_node_by_path("/ibm,dynamic-reconfiguration-memory");
+       if (memory)
+               parse_drconf_memory(memory);
 
        return 0;
 }
@@ -476,17 +457,19 @@ static void __init setup_nonnuma(void)
 {
        unsigned long top_of_ram = lmb_end_of_DRAM();
        unsigned long total_ram = lmb_phys_mem_size();
+       unsigned long start_pfn, end_pfn;
        unsigned int i;
 
-       printk(KERN_INFO "Top of RAM: 0x%lx, Total RAM: 0x%lx\n",
+       printk(KERN_DEBUG "Top of RAM: 0x%lx, Total RAM: 0x%lx\n",
               top_of_ram, total_ram);
-       printk(KERN_INFO "Memory hole size: %ldMB\n",
+       printk(KERN_DEBUG "Memory hole size: %ldMB\n",
               (top_of_ram - total_ram) >> 20);
 
-       map_cpu_to_node(boot_cpuid, 0);
-       for (i = 0; i < lmb.memory.cnt; ++i)
-               add_region(0, lmb.memory.region[i].base >> PAGE_SHIFT,
-                          lmb_size_pages(&lmb.memory, i));
+       for (i = 0; i < lmb.memory.cnt; ++i) {
+               start_pfn = lmb.memory.region[i].base >> PAGE_SHIFT;
+               end_pfn = start_pfn + lmb_size_pages(&lmb.memory, i);
+               add_active_range(0, start_pfn, end_pfn);
+       }
        node_set_online(0);
 }
 
@@ -499,7 +482,7 @@ void __init dump_numa_cpu_topology(void)
                return;
 
        for_each_online_node(node) {
-               printk(KERN_INFO "Node %d CPUs:", node);
+               printk(KERN_DEBUG "Node %d CPUs:", node);
 
                count = 0;
                /*
@@ -535,7 +518,7 @@ static void __init dump_numa_memory_topology(void)
        for_each_online_node(node) {
                unsigned long i;
 
-               printk(KERN_INFO "Node %d Memory:", node);
+               printk(KERN_DEBUG "Node %d Memory:", node);
 
                count = 0;
 
@@ -570,11 +553,11 @@ static void __init *careful_allocation(int nid, unsigned long size,
                                       unsigned long end_pfn)
 {
        int new_nid;
-       unsigned long ret = lmb_alloc_base(size, align, end_pfn << PAGE_SHIFT);
+       unsigned long ret = __lmb_alloc_base(size, align, end_pfn << PAGE_SHIFT);
 
        /* retry over all memory */
        if (!ret)
-               ret = lmb_alloc_base(size, align, lmb_end_of_DRAM());
+               ret = __lmb_alloc_base(size, align, lmb_end_of_DRAM());
 
        if (!ret)
                panic("numa.c: cannot allocate %lu bytes on node %d",
@@ -601,14 +584,15 @@ static void __init *careful_allocation(int nid, unsigned long size,
        return (void *)ret;
 }
 
+static struct notifier_block __cpuinitdata ppc64_numa_nb = {
+       .notifier_call = cpu_numa_callback,
+       .priority = 1 /* Must run before sched domains notifier. */
+};
+
 void __init do_init_bootmem(void)
 {
        int nid;
        unsigned int i;
-       static struct notifier_block ppc64_numa_nb = {
-               .notifier_call = cpu_numa_callback,
-               .priority = 1 /* Must run before sched domains notifier. */
-       };
 
        min_low_pfn = 0;
        max_low_pfn = lmb_end_of_DRAM() >> PAGE_SHIFT;
@@ -620,13 +604,15 @@ void __init do_init_bootmem(void)
                dump_numa_memory_topology();
 
        register_cpu_notifier(&ppc64_numa_nb);
+       cpu_numa_callback(&ppc64_numa_nb, CPU_UP_PREPARE,
+                         (void *)(unsigned long)boot_cpuid);
 
        for_each_online_node(nid) {
-               unsigned long start_pfn, end_pfn, pages_present;
+               unsigned long start_pfn, end_pfn;
                unsigned long bootmem_paddr;
                unsigned long bootmap_pages;
 
-               get_region(nid, &start_pfn, &end_pfn, &pages_present);
+               get_pfn_range_for_nid(nid, &start_pfn, &end_pfn);
 
                /* Allocate the node structure node local if possible */
                NODE_DATA(nid) = careful_allocation(nid,
@@ -659,19 +645,7 @@ void __init do_init_bootmem(void)
                init_bootmem_node(NODE_DATA(nid), bootmem_paddr >> PAGE_SHIFT,
                                  start_pfn, end_pfn);
 
-               /* Add free regions on this node */
-               for (i = 0; init_node_data[i].end_pfn; i++) {
-                       unsigned long start, end;
-
-                       if (init_node_data[i].nid != nid)
-                               continue;
-
-                       start = init_node_data[i].start_pfn << PAGE_SHIFT;
-                       end = init_node_data[i].end_pfn << PAGE_SHIFT;
-
-                       dbg("free_bootmem %lx %lx\n", start, end - start);
-                       free_bootmem_node(NODE_DATA(nid), start, end - start);
-               }
+               free_bootmem_with_active_regions(nid, end_pfn);
 
                /* Mark reserved regions on this node */
                for (i = 0; i < lmb.reserved.cnt; i++) {
@@ -702,44 +676,16 @@ void __init do_init_bootmem(void)
                        }
                }
 
-               /* Add regions into sparsemem */
-               for (i = 0; init_node_data[i].end_pfn; i++) {
-                       unsigned long start, end;
-
-                       if (init_node_data[i].nid != nid)
-                               continue;
-
-                       start = init_node_data[i].start_pfn;
-                       end = init_node_data[i].end_pfn;
-
-                       memory_present(nid, start, end);
-               }
+               sparse_memory_present_with_active_regions(nid);
        }
 }
 
 void __init paging_init(void)
 {
-       unsigned long zones_size[MAX_NR_ZONES];
-       unsigned long zholes_size[MAX_NR_ZONES];
-       int nid;
-
-       memset(zones_size, 0, sizeof(zones_size));
-       memset(zholes_size, 0, sizeof(zholes_size));
-
-       for_each_online_node(nid) {
-               unsigned long start_pfn, end_pfn, pages_present;
-
-               get_region(nid, &start_pfn, &end_pfn, &pages_present);
-
-               zones_size[ZONE_DMA] = end_pfn - start_pfn;
-               zholes_size[ZONE_DMA] = zones_size[ZONE_DMA] - pages_present;
-
-               dbg("free_area_init node %d %lx %lx (hole: %lx)\n", nid,
-                   zones_size[ZONE_DMA], start_pfn, zholes_size[ZONE_DMA]);
-
-               free_area_init_node(nid, NODE_DATA(nid), zones_size, start_pfn,
-                                   zholes_size);
-       }
+       unsigned long max_zone_pfns[MAX_NR_ZONES];
+       memset(max_zone_pfns, 0, sizeof(max_zone_pfns));
+       max_zone_pfns[ZONE_DMA] = lmb_end_of_DRAM() >> PAGE_SHIFT;
+       free_area_init_nodes(max_zone_pfns);
 }
 
 static int __init early_numa(char *p)
@@ -767,18 +713,19 @@ int hot_add_scn_to_nid(unsigned long scn_addr)
 {
        struct device_node *memory = NULL;
        nodemask_t nodes;
-       int numa_domain = 0;
+       int default_nid = any_online_node(NODE_MASK_ALL);
+       int nid;
 
        if (!numa_enabled || (min_common_depth < 0))
-               return numa_domain;
+               return default_nid;
 
        while ((memory = of_find_node_by_type(memory, "memory")) != NULL) {
                unsigned long start, size;
                int ranges;
-               unsigned int *memcell_buf;
+               const unsigned int *memcell_buf;
                unsigned int len;
 
-               memcell_buf = (unsigned int *)get_property(memory, "reg", &len);
+               memcell_buf = get_property(memory, "reg", &len);
                if (!memcell_buf || len <= 0)
                        continue;
 
@@ -787,29 +734,30 @@ int hot_add_scn_to_nid(unsigned long scn_addr)
 ha_new_range:
                start = read_n_cells(n_mem_addr_cells, &memcell_buf);
                size = read_n_cells(n_mem_size_cells, &memcell_buf);
-               numa_domain = of_node_numa_domain(memory);
+               nid = of_node_to_nid_single(memory);
 
                /* Domains not present at boot default to 0 */
-               if (!node_online(numa_domain))
-                       numa_domain = any_online_node(NODE_MASK_ALL);
+               if (nid < 0 || !node_online(nid))
+                       nid = default_nid;
 
                if ((scn_addr >= start) && (scn_addr < (start + size))) {
                        of_node_put(memory);
-                       goto got_numa_domain;
+                       goto got_nid;
                }
 
                if (--ranges)           /* process all ranges in cell */
                        goto ha_new_range;
        }
        BUG();  /* section address should be found above */
+       return 0;
 
        /* Temporary code to ensure that returned node is not empty */
-got_numa_domain:
+got_nid:
        nodes_setall(nodes);
-       while (NODE_DATA(numa_domain)->node_spanned_pages == 0) {
-               node_clear(numa_domain, nodes);
-               numa_domain = any_online_node(nodes);
+       while (NODE_DATA(nid)->node_spanned_pages == 0) {
+               node_clear(nid, nodes);
+               nid = any_online_node(nodes);
        }
-       return numa_domain;
+       return nid;
 }
 #endif /* CONFIG_MEMORY_HOTPLUG */