Fedora kernel-2.6.17-1.2142_FC4 patched with stable patch-2.6.17.4-vs2.0.2-rc26.diff
[linux-2.6.git] / drivers / char / drm / radeon_state.c
index 1f79e24..c5b8f77 100644 (file)
@@ -1,5 +1,5 @@
-/* radeon_state.c -- State support for Radeon -*- linux-c -*-
- *
+/* radeon_state.c -- State support for Radeon -*- linux-c -*- */
+/*
  * Copyright 2000 VA Linux Systems, Inc., Fremont, California.
  * All Rights Reserved.
  *
  * Helper functions for client state checking and fixup
  */
 
-static __inline__ int radeon_check_and_fixup_offset( drm_radeon_private_t *dev_priv,
-                                                    drm_file_t *filp_priv,
-                                                    u32 *offset ) {
+static __inline__ int radeon_check_and_fixup_offset(drm_radeon_private_t *
+                                                   dev_priv,
+                                                   drm_file_t * filp_priv,
+                                                   u32 *offset)
+{
        u32 off = *offset;
        struct drm_radeon_driver_file_fields *radeon_priv;
 
-       if ( off >= dev_priv->fb_location &&
-            off < ( dev_priv->gart_vm_start + dev_priv->gart_size ) )
-               return 0;
-
-       radeon_priv = filp_priv->driver_priv;
-       off += radeon_priv->radeon_fb_delta;
+       /* Hrm ... the story of the offset ... So this function converts
+        * the various ideas of what userland clients might have for an
+        * offset in the card address space into an offset into the card
+        * address space :) So with a sane client, it should just keep
+        * the value intact and just do some boundary checking. However,
+        * not all clients are sane. Some older clients pass us 0 based
+        * offsets relative to the start of the framebuffer and some may
+        * assume the AGP aperture it appended to the framebuffer, so we
+        * try to detect those cases and fix them up.
+        *
+        * Note: It might be a good idea here to make sure the offset lands
+        * in some "allowed" area to protect things like the PCIE GART...
+        */
 
-       DRM_DEBUG( "offset fixed up to 0x%x\n", off );
+       /* First, the best case, the offset already lands in either the
+        * framebuffer or the GART mapped space
+        */
+       if ((off >= dev_priv->fb_location &&
+            off < (dev_priv->fb_location + dev_priv->fb_size)) ||
+           (off >= dev_priv->gart_vm_start &&
+            off < (dev_priv->gart_vm_start + dev_priv->gart_size)))
+               return 0;
 
-       if ( off < dev_priv->fb_location ||
-            off >= ( dev_priv->gart_vm_start + dev_priv->gart_size ) )
-               return DRM_ERR( EINVAL );
+       /* Ok, that didn't happen... now check if we have a zero based
+        * offset that fits in the framebuffer + gart space, apply the
+        * magic offset we get from SETPARAM or calculated from fb_location
+        */
+       if (off < (dev_priv->fb_size + dev_priv->gart_size)) {
+               radeon_priv = filp_priv->driver_priv;
+               off += radeon_priv->radeon_fb_delta;
+       }
 
-       *offset = off;
+       /* Finally, assume we aimed at a GART offset if beyond the fb */
+       if (off > (dev_priv->fb_location + dev_priv->fb_size))
+               off = off - (dev_priv->fb_location + dev_priv->fb_size) +
+                       dev_priv->gart_vm_start;
 
-       return 0;
+       /* Now recheck and fail if out of bounds */
+       if ((off >= dev_priv->fb_location &&
+            off < (dev_priv->fb_location + dev_priv->fb_size)) ||
+           (off >= dev_priv->gart_vm_start &&
+            off < (dev_priv->gart_vm_start + dev_priv->gart_size))) {
+               DRM_DEBUG("offset fixed up to 0x%x\n", off);
+               *offset = off;
+               return 0;
+       }
+       return DRM_ERR(EINVAL);
 }
 
-static __inline__ int radeon_check_and_fixup_packets( drm_radeon_private_t *dev_priv,
-                                                     drm_file_t *filp_priv,
-                                                     int id,
-                                                     u32 __user *data ) {
-       switch ( id ) {
+static __inline__ int radeon_check_and_fixup_packets(drm_radeon_private_t *
+                                                    dev_priv,
+                                                    drm_file_t * filp_priv,
+                                                    int id, u32 *data)
+{
+       switch (id) {
 
        case RADEON_EMIT_PP_MISC:
-               if ( radeon_check_and_fixup_offset( dev_priv, filp_priv,
-                                                   &data[( RADEON_RB3D_DEPTHOFFSET
-                                                           - RADEON_PP_MISC ) / 4] ) ) {
-                       DRM_ERROR( "Invalid depth buffer offset\n" );
-                       return DRM_ERR( EINVAL );
+               if (radeon_check_and_fixup_offset(dev_priv, filp_priv,
+                   &data[(RADEON_RB3D_DEPTHOFFSET - RADEON_PP_MISC) / 4])) {
+                       DRM_ERROR("Invalid depth buffer offset\n");
+                       return DRM_ERR(EINVAL);
                }
                break;
 
        case RADEON_EMIT_PP_CNTL:
-               if ( radeon_check_and_fixup_offset( dev_priv, filp_priv,
-                                                   &data[( RADEON_RB3D_COLOROFFSET
-                                                           - RADEON_PP_CNTL ) / 4] ) ) {
-                       DRM_ERROR( "Invalid colour buffer offset\n" );
-                       return DRM_ERR( EINVAL );
+               if (radeon_check_and_fixup_offset(dev_priv, filp_priv,
+                   &data[(RADEON_RB3D_COLOROFFSET - RADEON_PP_CNTL) / 4])) {
+                       DRM_ERROR("Invalid colour buffer offset\n");
+                       return DRM_ERR(EINVAL);
                }
                break;
 
@@ -91,21 +123,20 @@ static __inline__ int radeon_check_and_fixup_packets( drm_radeon_private_t *dev_
        case R200_EMIT_PP_TXOFFSET_3:
        case R200_EMIT_PP_TXOFFSET_4:
        case R200_EMIT_PP_TXOFFSET_5:
-               if ( radeon_check_and_fixup_offset( dev_priv, filp_priv,
-                                                   &data[0] ) ) {
-                       DRM_ERROR( "Invalid R200 texture offset\n" );
-                       return DRM_ERR( EINVAL );
+               if (radeon_check_and_fixup_offset(dev_priv, filp_priv,
+                                                 &data[0])) {
+                       DRM_ERROR("Invalid R200 texture offset\n");
+                       return DRM_ERR(EINVAL);
                }
                break;
 
        case RADEON_EMIT_PP_TXFILTER_0:
        case RADEON_EMIT_PP_TXFILTER_1:
        case RADEON_EMIT_PP_TXFILTER_2:
-               if ( radeon_check_and_fixup_offset( dev_priv, filp_priv,
-                                                   &data[( RADEON_PP_TXOFFSET_0
-                                                           - RADEON_PP_TXFILTER_0 ) / 4] ) ) {
-                       DRM_ERROR( "Invalid R100 texture offset\n" );
-                       return DRM_ERR( EINVAL );
+               if (radeon_check_and_fixup_offset(dev_priv, filp_priv,
+                   &data[(RADEON_PP_TXOFFSET_0 - RADEON_PP_TXFILTER_0) / 4])) {
+                       DRM_ERROR("Invalid R100 texture offset\n");
+                       return DRM_ERR(EINVAL);
                }
                break;
 
@@ -114,17 +145,19 @@ static __inline__ int radeon_check_and_fixup_packets( drm_radeon_private_t *dev_
        case R200_EMIT_PP_CUBIC_OFFSETS_2:
        case R200_EMIT_PP_CUBIC_OFFSETS_3:
        case R200_EMIT_PP_CUBIC_OFFSETS_4:
-       case R200_EMIT_PP_CUBIC_OFFSETS_5: {
-               int i;
-               for ( i = 0; i < 5; i++ ) {
-                       if ( radeon_check_and_fixup_offset( dev_priv, filp_priv,
-                                                           &data[i] ) ) {
-                               DRM_ERROR( "Invalid R200 cubic texture offset\n" );
-                               return DRM_ERR( EINVAL );
+       case R200_EMIT_PP_CUBIC_OFFSETS_5:{
+                       int i;
+                       for (i = 0; i < 5; i++) {
+                               if (radeon_check_and_fixup_offset(dev_priv,
+                                                                 filp_priv,
+                                                                 &data[i])) {
+                                       DRM_ERROR
+                                           ("Invalid R200 cubic texture offset\n");
+                                       return DRM_ERR(EINVAL);
+                               }
                        }
+                       break;
                }
-               break;
-       }
 
        case RADEON_EMIT_PP_CUBIC_OFFSETS_T0:
        case RADEON_EMIT_PP_CUBIC_OFFSETS_T1:
@@ -207,247 +240,260 @@ static __inline__ int radeon_check_and_fixup_packets( drm_radeon_private_t *dev_
        case RADEON_EMIT_PP_CUBIC_FACES_1:
        case RADEON_EMIT_PP_CUBIC_FACES_2:
        case R200_EMIT_PP_TRI_PERF_CNTL:
+       case R200_EMIT_PP_AFS_0:
+       case R200_EMIT_PP_AFS_1:
+       case R200_EMIT_ATF_TFACTOR:
+       case R200_EMIT_PP_TXCTLALL_0:
+       case R200_EMIT_PP_TXCTLALL_1:
+       case R200_EMIT_PP_TXCTLALL_2:
+       case R200_EMIT_PP_TXCTLALL_3:
+       case R200_EMIT_PP_TXCTLALL_4:
+       case R200_EMIT_PP_TXCTLALL_5:
                /* These packets don't contain memory offsets */
                break;
 
        default:
-               DRM_ERROR( "Unknown state packet ID %d\n", id );
-               return DRM_ERR( EINVAL );
+               DRM_ERROR("Unknown state packet ID %d\n", id);
+               return DRM_ERR(EINVAL);
        }
 
        return 0;
 }
 
-static __inline__ int radeon_check_and_fixup_packet3( drm_radeon_private_t *dev_priv,
-                                                     drm_file_t *filp_priv,
-                                                     drm_radeon_cmd_buffer_t *cmdbuf,
-                                                     unsigned int *cmdsz ) {
+static __inline__ int radeon_check_and_fixup_packet3(drm_radeon_private_t *
+                                                    dev_priv,
+                                                    drm_file_t *filp_priv,
+                                                    drm_radeon_kcmd_buffer_t *
+                                                    cmdbuf,
+                                                    unsigned int *cmdsz)
+{
        u32 *cmd = (u32 *) cmdbuf->buf;
 
-       *cmdsz = 2 + ( ( cmd[0] & RADEON_CP_PACKET_COUNT_MASK ) >> 16 );
+       *cmdsz = 2 + ((cmd[0] & RADEON_CP_PACKET_COUNT_MASK) >> 16);
 
-       if ( ( cmd[0] & 0xc0000000 ) != RADEON_CP_PACKET3 ) {
-               DRM_ERROR( "Not a type 3 packet\n" );
-               return DRM_ERR( EINVAL );
+       if ((cmd[0] & 0xc0000000) != RADEON_CP_PACKET3) {
+               DRM_ERROR("Not a type 3 packet\n");
+               return DRM_ERR(EINVAL);
        }
 
-       if ( 4 * *cmdsz > cmdbuf->bufsz ) {
-               DRM_ERROR( "Packet size larger than size of data provided\n" );
-               return DRM_ERR( EINVAL );
+       if (4 * *cmdsz > cmdbuf->bufsz) {
+               DRM_ERROR("Packet size larger than size of data provided\n");
+               return DRM_ERR(EINVAL);
        }
 
        /* Check client state and fix it up if necessary */
-       if ( cmd[0] & 0x8000 ) { /* MSB of opcode: next DWORD GUI_CNTL */
+       if (cmd[0] & 0x8000) {  /* MSB of opcode: next DWORD GUI_CNTL */
                u32 offset;
 
-               if ( cmd[1] & ( RADEON_GMC_SRC_PITCH_OFFSET_CNTL
-                             | RADEON_GMC_DST_PITCH_OFFSET_CNTL ) ) {
+               if (cmd[1] & (RADEON_GMC_SRC_PITCH_OFFSET_CNTL
+                             | RADEON_GMC_DST_PITCH_OFFSET_CNTL)) {
                        offset = cmd[2] << 10;
-                       if ( radeon_check_and_fixup_offset( dev_priv, filp_priv, &offset ) ) {
-                               DRM_ERROR( "Invalid first packet offset\n" );
-                               return DRM_ERR( EINVAL );
+                       if (radeon_check_and_fixup_offset
+                           (dev_priv, filp_priv, &offset)) {
+                               DRM_ERROR("Invalid first packet offset\n");
+                               return DRM_ERR(EINVAL);
                        }
-                       cmd[2] = ( cmd[2] & 0xffc00000 ) | offset >> 10;
+                       cmd[2] = (cmd[2] & 0xffc00000) | offset >> 10;
                }
 
-               if ( ( cmd[1] & RADEON_GMC_SRC_PITCH_OFFSET_CNTL ) &&
-                    ( cmd[1] & RADEON_GMC_DST_PITCH_OFFSET_CNTL ) ) {
+               if ((cmd[1] & RADEON_GMC_SRC_PITCH_OFFSET_CNTL) &&
+                   (cmd[1] & RADEON_GMC_DST_PITCH_OFFSET_CNTL)) {
                        offset = cmd[3] << 10;
-                       if ( radeon_check_and_fixup_offset( dev_priv, filp_priv, &offset ) ) {
-                               DRM_ERROR( "Invalid second packet offset\n" );
-                               return DRM_ERR( EINVAL );
+                       if (radeon_check_and_fixup_offset
+                           (dev_priv, filp_priv, &offset)) {
+                               DRM_ERROR("Invalid second packet offset\n");
+                               return DRM_ERR(EINVAL);
                        }
-                       cmd[3] = ( cmd[3] & 0xffc00000 ) | offset >> 10;
+                       cmd[3] = (cmd[3] & 0xffc00000) | offset >> 10;
                }
        }
 
        return 0;
 }
 
-
 /* ================================================================
  * CP hardware state programming functions
  */
 
-static __inline__ void radeon_emit_clip_rect( drm_radeon_private_t *dev_priv,
-                                         drm_clip_rect_t *box )
+static __inline__ void radeon_emit_clip_rect(drm_radeon_private_t * dev_priv,
+                                            drm_clip_rect_t * box)
 {
        RING_LOCALS;
 
-       DRM_DEBUG( "   box:  x1=%d y1=%d  x2=%d y2=%d\n",
-                  box->x1, box->y1, box->x2, box->y2 );
+       DRM_DEBUG("   box:  x1=%d y1=%d  x2=%d y2=%d\n",
+                 box->x1, box->y1, box->x2, box->y2);
 
-       BEGIN_RING( 4 );
-       OUT_RING( CP_PACKET0( RADEON_RE_TOP_LEFT, 0 ) );
-       OUT_RING( (box->y1 << 16) | box->x1 );
-       OUT_RING( CP_PACKET0( RADEON_RE_WIDTH_HEIGHT, 0 ) );
-       OUT_RING( ((box->y2 - 1) << 16) | (box->x2 - 1) );
+       BEGIN_RING(4);
+       OUT_RING(CP_PACKET0(RADEON_RE_TOP_LEFT, 0));
+       OUT_RING((box->y1 << 16) | box->x1);
+       OUT_RING(CP_PACKET0(RADEON_RE_WIDTH_HEIGHT, 0));
+       OUT_RING(((box->y2 - 1) << 16) | (box->x2 - 1));
        ADVANCE_RING();
 }
 
 /* Emit 1.1 state
  */
-static int radeon_emit_state( drm_radeon_private_t *dev_priv,
-                             drm_file_t *filp_priv,
-                             drm_radeon_context_regs_t *ctx,
-                             drm_radeon_texture_regs_t *tex,
-                             unsigned int dirty )
+static int radeon_emit_state(drm_radeon_private_t * dev_priv,
+                            drm_file_t * filp_priv,
+                            drm_radeon_context_regs_t * ctx,
+                            drm_radeon_texture_regs_t * tex,
+                            unsigned int dirty)
 {
        RING_LOCALS;
-       DRM_DEBUG( "dirty=0x%08x\n", dirty );
+       DRM_DEBUG("dirty=0x%08x\n", dirty);
 
-       if ( dirty & RADEON_UPLOAD_CONTEXT ) {
-               if ( radeon_check_and_fixup_offset( dev_priv, filp_priv,
-                                                   &ctx->rb3d_depthoffset ) ) {
-                       DRM_ERROR( "Invalid depth buffer offset\n" );
-                       return DRM_ERR( EINVAL );
+       if (dirty & RADEON_UPLOAD_CONTEXT) {
+               if (radeon_check_and_fixup_offset(dev_priv, filp_priv,
+                                                 &ctx->rb3d_depthoffset)) {
+                       DRM_ERROR("Invalid depth buffer offset\n");
+                       return DRM_ERR(EINVAL);
                }
 
-               if ( radeon_check_and_fixup_offset( dev_priv, filp_priv,
-                                                   &ctx->rb3d_coloroffset ) ) {
-                       DRM_ERROR( "Invalid depth buffer offset\n" );
-                       return DRM_ERR( EINVAL );
+               if (radeon_check_and_fixup_offset(dev_priv, filp_priv,
+                                                 &ctx->rb3d_coloroffset)) {
+                       DRM_ERROR("Invalid depth buffer offset\n");
+                       return DRM_ERR(EINVAL);
                }
 
-               BEGIN_RING( 14 );
-               OUT_RING( CP_PACKET0( RADEON_PP_MISC, 6 ) );
-               OUT_RING( ctx->pp_misc );
-               OUT_RING( ctx->pp_fog_color );
-               OUT_RING( ctx->re_solid_color );
-               OUT_RING( ctx->rb3d_blendcntl );
-               OUT_RING( ctx->rb3d_depthoffset );
-               OUT_RING( ctx->rb3d_depthpitch );
-               OUT_RING( ctx->rb3d_zstencilcntl );
-               OUT_RING( CP_PACKET0( RADEON_PP_CNTL, 2 ) );
-               OUT_RING( ctx->pp_cntl );
-               OUT_RING( ctx->rb3d_cntl );
-               OUT_RING( ctx->rb3d_coloroffset );
-               OUT_RING( CP_PACKET0( RADEON_RB3D_COLORPITCH, 0 ) );
-               OUT_RING( ctx->rb3d_colorpitch );
+               BEGIN_RING(14);
+               OUT_RING(CP_PACKET0(RADEON_PP_MISC, 6));
+               OUT_RING(ctx->pp_misc);
+               OUT_RING(ctx->pp_fog_color);
+               OUT_RING(ctx->re_solid_color);
+               OUT_RING(ctx->rb3d_blendcntl);
+               OUT_RING(ctx->rb3d_depthoffset);
+               OUT_RING(ctx->rb3d_depthpitch);
+               OUT_RING(ctx->rb3d_zstencilcntl);
+               OUT_RING(CP_PACKET0(RADEON_PP_CNTL, 2));
+               OUT_RING(ctx->pp_cntl);
+               OUT_RING(ctx->rb3d_cntl);
+               OUT_RING(ctx->rb3d_coloroffset);
+               OUT_RING(CP_PACKET0(RADEON_RB3D_COLORPITCH, 0));
+               OUT_RING(ctx->rb3d_colorpitch);
                ADVANCE_RING();
        }
 
-       if ( dirty & RADEON_UPLOAD_VERTFMT ) {
-               BEGIN_RING( 2 );
-               OUT_RING( CP_PACKET0( RADEON_SE_COORD_FMT, 0 ) );
-               OUT_RING( ctx->se_coord_fmt );
+       if (dirty & RADEON_UPLOAD_VERTFMT) {
+               BEGIN_RING(2);
+               OUT_RING(CP_PACKET0(RADEON_SE_COORD_FMT, 0));
+               OUT_RING(ctx->se_coord_fmt);
                ADVANCE_RING();
        }
 
-       if ( dirty & RADEON_UPLOAD_LINE ) {
-               BEGIN_RING( 5 );
-               OUT_RING( CP_PACKET0( RADEON_RE_LINE_PATTERN, 1 ) );
-               OUT_RING( ctx->re_line_pattern );
-               OUT_RING( ctx->re_line_state );
-               OUT_RING( CP_PACKET0( RADEON_SE_LINE_WIDTH, 0 ) );
-               OUT_RING( ctx->se_line_width );
+       if (dirty & RADEON_UPLOAD_LINE) {
+               BEGIN_RING(5);
+               OUT_RING(CP_PACKET0(RADEON_RE_LINE_PATTERN, 1));
+               OUT_RING(ctx->re_line_pattern);
+               OUT_RING(ctx->re_line_state);
+               OUT_RING(CP_PACKET0(RADEON_SE_LINE_WIDTH, 0));
+               OUT_RING(ctx->se_line_width);
                ADVANCE_RING();
        }
 
-       if ( dirty & RADEON_UPLOAD_BUMPMAP ) {
-               BEGIN_RING( 5 );
-               OUT_RING( CP_PACKET0( RADEON_PP_LUM_MATRIX, 0 ) );
-               OUT_RING( ctx->pp_lum_matrix );
-               OUT_RING( CP_PACKET0( RADEON_PP_ROT_MATRIX_0, 1 ) );
-               OUT_RING( ctx->pp_rot_matrix_0 );
-               OUT_RING( ctx->pp_rot_matrix_1 );
+       if (dirty & RADEON_UPLOAD_BUMPMAP) {
+               BEGIN_RING(5);
+               OUT_RING(CP_PACKET0(RADEON_PP_LUM_MATRIX, 0));
+               OUT_RING(ctx->pp_lum_matrix);
+               OUT_RING(CP_PACKET0(RADEON_PP_ROT_MATRIX_0, 1));
+               OUT_RING(ctx->pp_rot_matrix_0);
+               OUT_RING(ctx->pp_rot_matrix_1);
                ADVANCE_RING();
        }
 
-       if ( dirty & RADEON_UPLOAD_MASKS ) {
-               BEGIN_RING( 4 );
-               OUT_RING( CP_PACKET0( RADEON_RB3D_STENCILREFMASK, 2 ) );
-               OUT_RING( ctx->rb3d_stencilrefmask );
-               OUT_RING( ctx->rb3d_ropcntl );
-               OUT_RING( ctx->rb3d_planemask );
+       if (dirty & RADEON_UPLOAD_MASKS) {
+               BEGIN_RING(4);
+               OUT_RING(CP_PACKET0(RADEON_RB3D_STENCILREFMASK, 2));
+               OUT_RING(ctx->rb3d_stencilrefmask);
+               OUT_RING(ctx->rb3d_ropcntl);
+               OUT_RING(ctx->rb3d_planemask);
                ADVANCE_RING();
        }
 
-       if ( dirty & RADEON_UPLOAD_VIEWPORT ) {
-               BEGIN_RING( 7 );
-               OUT_RING( CP_PACKET0( RADEON_SE_VPORT_XSCALE, 5 ) );
-               OUT_RING( ctx->se_vport_xscale );
-               OUT_RING( ctx->se_vport_xoffset );
-               OUT_RING( ctx->se_vport_yscale );
-               OUT_RING( ctx->se_vport_yoffset );
-               OUT_RING( ctx->se_vport_zscale );
-               OUT_RING( ctx->se_vport_zoffset );
+       if (dirty & RADEON_UPLOAD_VIEWPORT) {
+               BEGIN_RING(7);
+               OUT_RING(CP_PACKET0(RADEON_SE_VPORT_XSCALE, 5));
+               OUT_RING(ctx->se_vport_xscale);
+               OUT_RING(ctx->se_vport_xoffset);
+               OUT_RING(ctx->se_vport_yscale);
+               OUT_RING(ctx->se_vport_yoffset);
+               OUT_RING(ctx->se_vport_zscale);
+               OUT_RING(ctx->se_vport_zoffset);
                ADVANCE_RING();
        }
 
-       if ( dirty & RADEON_UPLOAD_SETUP ) {
-               BEGIN_RING( 4 );
-               OUT_RING( CP_PACKET0( RADEON_SE_CNTL, 0 ) );
-               OUT_RING( ctx->se_cntl );
-               OUT_RING( CP_PACKET0( RADEON_SE_CNTL_STATUS, 0 ) );
-               OUT_RING( ctx->se_cntl_status );
+       if (dirty & RADEON_UPLOAD_SETUP) {
+               BEGIN_RING(4);
+               OUT_RING(CP_PACKET0(RADEON_SE_CNTL, 0));
+               OUT_RING(ctx->se_cntl);
+               OUT_RING(CP_PACKET0(RADEON_SE_CNTL_STATUS, 0));
+               OUT_RING(ctx->se_cntl_status);
                ADVANCE_RING();
        }
 
-       if ( dirty & RADEON_UPLOAD_MISC ) {
-               BEGIN_RING( 2 );
-               OUT_RING( CP_PACKET0( RADEON_RE_MISC, 0 ) );
-               OUT_RING( ctx->re_misc );
+       if (dirty & RADEON_UPLOAD_MISC) {
+               BEGIN_RING(2);
+               OUT_RING(CP_PACKET0(RADEON_RE_MISC, 0));
+               OUT_RING(ctx->re_misc);
                ADVANCE_RING();
        }
 
-       if ( dirty & RADEON_UPLOAD_TEX0 ) {
-               if ( radeon_check_and_fixup_offset( dev_priv, filp_priv,
-                                                   &tex[0].pp_txoffset ) ) {
-                       DRM_ERROR( "Invalid texture offset for unit 0\n" );
-                       return DRM_ERR( EINVAL );
+       if (dirty & RADEON_UPLOAD_TEX0) {
+               if (radeon_check_and_fixup_offset(dev_priv, filp_priv,
+                                                 &tex[0].pp_txoffset)) {
+                       DRM_ERROR("Invalid texture offset for unit 0\n");
+                       return DRM_ERR(EINVAL);
                }
 
-               BEGIN_RING( 9 );
-               OUT_RING( CP_PACKET0( RADEON_PP_TXFILTER_0, 5 ) );
-               OUT_RING( tex[0].pp_txfilter );
-               OUT_RING( tex[0].pp_txformat );
-               OUT_RING( tex[0].pp_txoffset );
-               OUT_RING( tex[0].pp_txcblend );
-               OUT_RING( tex[0].pp_txablend );
-               OUT_RING( tex[0].pp_tfactor );
-               OUT_RING( CP_PACKET0( RADEON_PP_BORDER_COLOR_0, 0 ) );
-               OUT_RING( tex[0].pp_border_color );
+               BEGIN_RING(9);
+               OUT_RING(CP_PACKET0(RADEON_PP_TXFILTER_0, 5));
+               OUT_RING(tex[0].pp_txfilter);
+               OUT_RING(tex[0].pp_txformat);
+               OUT_RING(tex[0].pp_txoffset);
+               OUT_RING(tex[0].pp_txcblend);
+               OUT_RING(tex[0].pp_txablend);
+               OUT_RING(tex[0].pp_tfactor);
+               OUT_RING(CP_PACKET0(RADEON_PP_BORDER_COLOR_0, 0));
+               OUT_RING(tex[0].pp_border_color);
                ADVANCE_RING();
        }
 
-       if ( dirty & RADEON_UPLOAD_TEX1 ) {
-               if ( radeon_check_and_fixup_offset( dev_priv, filp_priv,
-                                                   &tex[1].pp_txoffset ) ) {
-                       DRM_ERROR( "Invalid texture offset for unit 1\n" );
-                       return DRM_ERR( EINVAL );
+       if (dirty & RADEON_UPLOAD_TEX1) {
+               if (radeon_check_and_fixup_offset(dev_priv, filp_priv,
+                                                 &tex[1].pp_txoffset)) {
+                       DRM_ERROR("Invalid texture offset for unit 1\n");
+                       return DRM_ERR(EINVAL);
                }
 
-               BEGIN_RING( 9 );
-               OUT_RING( CP_PACKET0( RADEON_PP_TXFILTER_1, 5 ) );
-               OUT_RING( tex[1].pp_txfilter );
-               OUT_RING( tex[1].pp_txformat );
-               OUT_RING( tex[1].pp_txoffset );
-               OUT_RING( tex[1].pp_txcblend );
-               OUT_RING( tex[1].pp_txablend );
-               OUT_RING( tex[1].pp_tfactor );
-               OUT_RING( CP_PACKET0( RADEON_PP_BORDER_COLOR_1, 0 ) );
-               OUT_RING( tex[1].pp_border_color );
+               BEGIN_RING(9);
+               OUT_RING(CP_PACKET0(RADEON_PP_TXFILTER_1, 5));
+               OUT_RING(tex[1].pp_txfilter);
+               OUT_RING(tex[1].pp_txformat);
+               OUT_RING(tex[1].pp_txoffset);
+               OUT_RING(tex[1].pp_txcblend);
+               OUT_RING(tex[1].pp_txablend);
+               OUT_RING(tex[1].pp_tfactor);
+               OUT_RING(CP_PACKET0(RADEON_PP_BORDER_COLOR_1, 0));
+               OUT_RING(tex[1].pp_border_color);
                ADVANCE_RING();
        }
 
-       if ( dirty & RADEON_UPLOAD_TEX2 ) {
-               if ( radeon_check_and_fixup_offset( dev_priv, filp_priv,
-                                                   &tex[2].pp_txoffset ) ) {
-                       DRM_ERROR( "Invalid texture offset for unit 2\n" );
-                       return DRM_ERR( EINVAL );
+       if (dirty & RADEON_UPLOAD_TEX2) {
+               if (radeon_check_and_fixup_offset(dev_priv, filp_priv,
+                                                 &tex[2].pp_txoffset)) {
+                       DRM_ERROR("Invalid texture offset for unit 2\n");
+                       return DRM_ERR(EINVAL);
                }
 
-               BEGIN_RING( 9 );
-               OUT_RING( CP_PACKET0( RADEON_PP_TXFILTER_2, 5 ) );
-               OUT_RING( tex[2].pp_txfilter );
-               OUT_RING( tex[2].pp_txformat );
-               OUT_RING( tex[2].pp_txoffset );
-               OUT_RING( tex[2].pp_txcblend );
-               OUT_RING( tex[2].pp_txablend );
-               OUT_RING( tex[2].pp_tfactor );
-               OUT_RING( CP_PACKET0( RADEON_PP_BORDER_COLOR_2, 0 ) );
-               OUT_RING( tex[2].pp_border_color );
+               BEGIN_RING(9);
+               OUT_RING(CP_PACKET0(RADEON_PP_TXFILTER_2, 5));
+               OUT_RING(tex[2].pp_txfilter);
+               OUT_RING(tex[2].pp_txformat);
+               OUT_RING(tex[2].pp_txoffset);
+               OUT_RING(tex[2].pp_txcblend);
+               OUT_RING(tex[2].pp_txablend);
+               OUT_RING(tex[2].pp_tfactor);
+               OUT_RING(CP_PACKET0(RADEON_PP_BORDER_COLOR_2, 0));
+               OUT_RING(tex[2].pp_border_color);
                ADVANCE_RING();
        }
 
@@ -456,129 +502,138 @@ static int radeon_emit_state( drm_radeon_private_t *dev_priv,
 
 /* Emit 1.2 state
  */
-static int radeon_emit_state2( drm_radeon_private_t *dev_priv,
-                              drm_file_t *filp_priv,
-                              drm_radeon_state_t *state )
+static int radeon_emit_state2(drm_radeon_private_t * dev_priv,
+                             drm_file_t * filp_priv,
+                             drm_radeon_state_t * state)
 {
        RING_LOCALS;
 
        if (state->dirty & RADEON_UPLOAD_ZBIAS) {
-               BEGIN_RING( 3 );
-               OUT_RING( CP_PACKET0( RADEON_SE_ZBIAS_FACTOR, 1 ) );
-               OUT_RING( state->context2.se_zbias_factor ); 
-               OUT_RING( state->context2.se_zbias_constant ); 
+               BEGIN_RING(3);
+               OUT_RING(CP_PACKET0(RADEON_SE_ZBIAS_FACTOR, 1));
+               OUT_RING(state->context2.se_zbias_factor);
+               OUT_RING(state->context2.se_zbias_constant);
                ADVANCE_RING();
        }
 
-       return radeon_emit_state( dev_priv, filp_priv, &state->context,
-                          state->tex, state->dirty );
+       return radeon_emit_state(dev_priv, filp_priv, &state->context,
+                                state->tex, state->dirty);
 }
 
 /* New (1.3) state mechanism.  3 commands (packet, scalar, vector) in
  * 1.3 cmdbuffers allow all previous state to be updated as well as
- * the tcl scalar and vector areas.  
+ * the tcl scalar and vector areas.
  */
-static struct { 
-       int start; 
-       int len; 
+static struct {
+       int start;
+       int len;
        const char *name;
 } packet[RADEON_MAX_STATE_PACKETS] = {
-       { RADEON_PP_MISC,7,"RADEON_PP_MISC" },
-       { RADEON_PP_CNTL,3,"RADEON_PP_CNTL" },
-       { RADEON_RB3D_COLORPITCH,1,"RADEON_RB3D_COLORPITCH" },
-       { RADEON_RE_LINE_PATTERN,2,"RADEON_RE_LINE_PATTERN" },
-       { RADEON_SE_LINE_WIDTH,1,"RADEON_SE_LINE_WIDTH" },
-       { RADEON_PP_LUM_MATRIX,1,"RADEON_PP_LUM_MATRIX" },
-       { RADEON_PP_ROT_MATRIX_0,2,"RADEON_PP_ROT_MATRIX_0" },
-       { RADEON_RB3D_STENCILREFMASK,3,"RADEON_RB3D_STENCILREFMASK" },
-       { RADEON_SE_VPORT_XSCALE,6,"RADEON_SE_VPORT_XSCALE" },
-       { RADEON_SE_CNTL,2,"RADEON_SE_CNTL" },
-       { RADEON_SE_CNTL_STATUS,1,"RADEON_SE_CNTL_STATUS" },
-       { RADEON_RE_MISC,1,"RADEON_RE_MISC" },
-       { RADEON_PP_TXFILTER_0,6,"RADEON_PP_TXFILTER_0" },
-       { RADEON_PP_BORDER_COLOR_0,1,"RADEON_PP_BORDER_COLOR_0" },
-       { RADEON_PP_TXFILTER_1,6,"RADEON_PP_TXFILTER_1" },
-       { RADEON_PP_BORDER_COLOR_1,1,"RADEON_PP_BORDER_COLOR_1" },
-       { RADEON_PP_TXFILTER_2,6,"RADEON_PP_TXFILTER_2" },
-       { RADEON_PP_BORDER_COLOR_2,1,"RADEON_PP_BORDER_COLOR_2" },
-       { RADEON_SE_ZBIAS_FACTOR,2,"RADEON_SE_ZBIAS_FACTOR" },
-       { RADEON_SE_TCL_OUTPUT_VTX_FMT,11,"RADEON_SE_TCL_OUTPUT_VTX_FMT" },
-       { RADEON_SE_TCL_MATERIAL_EMMISSIVE_RED,17,"RADEON_SE_TCL_MATERIAL_EMMISSIVE_RED" },
-       { R200_PP_TXCBLEND_0, 4, "R200_PP_TXCBLEND_0" },
-       { R200_PP_TXCBLEND_1, 4, "R200_PP_TXCBLEND_1" },
-       { R200_PP_TXCBLEND_2, 4, "R200_PP_TXCBLEND_2" },
-       { R200_PP_TXCBLEND_3, 4, "R200_PP_TXCBLEND_3" },
-       { R200_PP_TXCBLEND_4, 4, "R200_PP_TXCBLEND_4" },
-       { R200_PP_TXCBLEND_5, 4, "R200_PP_TXCBLEND_5" },
-       { R200_PP_TXCBLEND_6, 4, "R200_PP_TXCBLEND_6" },
-       { R200_PP_TXCBLEND_7, 4, "R200_PP_TXCBLEND_7" },
-       { R200_SE_TCL_LIGHT_MODEL_CTL_0, 6, "R200_SE_TCL_LIGHT_MODEL_CTL_0" },
-       { R200_PP_TFACTOR_0, 6, "R200_PP_TFACTOR_0" },
-       { R200_SE_VTX_FMT_0, 4, "R200_SE_VTX_FMT_0" },
-       { R200_SE_VAP_CNTL, 1, "R200_SE_VAP_CNTL" },
-       { R200_SE_TCL_MATRIX_SEL_0, 5, "R200_SE_TCL_MATRIX_SEL_0" },
-       { R200_SE_TCL_TEX_PROC_CTL_2, 5, "R200_SE_TCL_TEX_PROC_CTL_2" },
-       { R200_SE_TCL_UCP_VERT_BLEND_CTL, 1, "R200_SE_TCL_UCP_VERT_BLEND_CTL" },
-       { R200_PP_TXFILTER_0, 6, "R200_PP_TXFILTER_0" },
-       { R200_PP_TXFILTER_1, 6, "R200_PP_TXFILTER_1" },
-       { R200_PP_TXFILTER_2, 6, "R200_PP_TXFILTER_2" },
-       { R200_PP_TXFILTER_3, 6, "R200_PP_TXFILTER_3" },
-       { R200_PP_TXFILTER_4, 6, "R200_PP_TXFILTER_4" },
-       { R200_PP_TXFILTER_5, 6, "R200_PP_TXFILTER_5" },
-       { R200_PP_TXOFFSET_0, 1, "R200_PP_TXOFFSET_0" },
-       { R200_PP_TXOFFSET_1, 1, "R200_PP_TXOFFSET_1" },
-       { R200_PP_TXOFFSET_2, 1, "R200_PP_TXOFFSET_2" },
-       { R200_PP_TXOFFSET_3, 1, "R200_PP_TXOFFSET_3" },
-       { R200_PP_TXOFFSET_4, 1, "R200_PP_TXOFFSET_4" },
-       { R200_PP_TXOFFSET_5, 1, "R200_PP_TXOFFSET_5" },
-       { R200_SE_VTE_CNTL, 1, "R200_SE_VTE_CNTL" },
-       { R200_SE_TCL_OUTPUT_VTX_COMP_SEL, 1, "R200_SE_TCL_OUTPUT_VTX_COMP_SEL" },
-       { R200_PP_TAM_DEBUG3, 1, "R200_PP_TAM_DEBUG3" },
-       { R200_PP_CNTL_X, 1, "R200_PP_CNTL_X" }, 
-       { R200_RB3D_DEPTHXY_OFFSET, 1, "R200_RB3D_DEPTHXY_OFFSET" }, 
-       { R200_RE_AUX_SCISSOR_CNTL, 1, "R200_RE_AUX_SCISSOR_CNTL" }, 
-       { R200_RE_SCISSOR_TL_0, 2, "R200_RE_SCISSOR_TL_0" }, 
-       { R200_RE_SCISSOR_TL_1, 2, "R200_RE_SCISSOR_TL_1" }, 
-       { R200_RE_SCISSOR_TL_2, 2, "R200_RE_SCISSOR_TL_2" }, 
-       { R200_SE_VAP_CNTL_STATUS, 1, "R200_SE_VAP_CNTL_STATUS" }, 
-       { R200_SE_VTX_STATE_CNTL, 1, "R200_SE_VTX_STATE_CNTL" }, 
-       { R200_RE_POINTSIZE, 1, "R200_RE_POINTSIZE" }, 
-       { R200_SE_TCL_INPUT_VTX_VECTOR_ADDR_0, 4, "R200_SE_TCL_INPUT_VTX_VECTOR_ADDR_0" },
-       { R200_PP_CUBIC_FACES_0, 1, "R200_PP_CUBIC_FACES_0" }, /* 61 */
-       { R200_PP_CUBIC_OFFSET_F1_0, 5, "R200_PP_CUBIC_OFFSET_F1_0" }, /* 62 */
-       { R200_PP_CUBIC_FACES_1, 1, "R200_PP_CUBIC_FACES_1" },
-       { R200_PP_CUBIC_OFFSET_F1_1, 5, "R200_PP_CUBIC_OFFSET_F1_1" },
-       { R200_PP_CUBIC_FACES_2, 1, "R200_PP_CUBIC_FACES_2" },
-       { R200_PP_CUBIC_OFFSET_F1_2, 5, "R200_PP_CUBIC_OFFSET_F1_2" },
-       { R200_PP_CUBIC_FACES_3, 1, "R200_PP_CUBIC_FACES_3" },
-       { R200_PP_CUBIC_OFFSET_F1_3, 5, "R200_PP_CUBIC_OFFSET_F1_3" },
-       { R200_PP_CUBIC_FACES_4, 1, "R200_PP_CUBIC_FACES_4" },
-       { R200_PP_CUBIC_OFFSET_F1_4, 5, "R200_PP_CUBIC_OFFSET_F1_4" },
-       { R200_PP_CUBIC_FACES_5, 1, "R200_PP_CUBIC_FACES_5" },
-       { R200_PP_CUBIC_OFFSET_F1_5, 5, "R200_PP_CUBIC_OFFSET_F1_5" },
-       { RADEON_PP_TEX_SIZE_0, 2, "RADEON_PP_TEX_SIZE_0" },
-       { RADEON_PP_TEX_SIZE_1, 2, "RADEON_PP_TEX_SIZE_1" },
-       { RADEON_PP_TEX_SIZE_2, 2, "RADEON_PP_TEX_SIZE_2" },
-       { R200_RB3D_BLENDCOLOR, 3, "R200_RB3D_BLENDCOLOR" },
-       { R200_SE_TCL_POINT_SPRITE_CNTL, 1, "R200_SE_TCL_POINT_SPRITE_CNTL" },
-       { RADEON_PP_CUBIC_FACES_0, 1, "RADEON_PP_CUBIC_FACES_0"},
-       { RADEON_PP_CUBIC_OFFSET_T0_0, 5, "RADEON_PP_CUBIC_OFFSET_T0_0"},
-       { RADEON_PP_CUBIC_FACES_1, 1, "RADEON_PP_CUBIC_FACES_1"},
-       { RADEON_PP_CUBIC_OFFSET_T1_0, 5, "RADEON_PP_CUBIC_OFFSET_T1_0"},
-       { RADEON_PP_CUBIC_FACES_2, 1, "RADEON_PP_CUBIC_FACES_2"},
-       { RADEON_PP_CUBIC_OFFSET_T2_0, 5, "RADEON_PP_CUBIC_OFFSET_T2_0"},
-       { R200_PP_TRI_PERF, 2, "R200_PP_TRI_PERF"},
+       {RADEON_PP_MISC, 7, "RADEON_PP_MISC"},
+       {RADEON_PP_CNTL, 3, "RADEON_PP_CNTL"},
+       {RADEON_RB3D_COLORPITCH, 1, "RADEON_RB3D_COLORPITCH"},
+       {RADEON_RE_LINE_PATTERN, 2, "RADEON_RE_LINE_PATTERN"},
+       {RADEON_SE_LINE_WIDTH, 1, "RADEON_SE_LINE_WIDTH"},
+       {RADEON_PP_LUM_MATRIX, 1, "RADEON_PP_LUM_MATRIX"},
+       {RADEON_PP_ROT_MATRIX_0, 2, "RADEON_PP_ROT_MATRIX_0"},
+       {RADEON_RB3D_STENCILREFMASK, 3, "RADEON_RB3D_STENCILREFMASK"},
+       {RADEON_SE_VPORT_XSCALE, 6, "RADEON_SE_VPORT_XSCALE"},
+       {RADEON_SE_CNTL, 2, "RADEON_SE_CNTL"},
+       {RADEON_SE_CNTL_STATUS, 1, "RADEON_SE_CNTL_STATUS"},
+       {RADEON_RE_MISC, 1, "RADEON_RE_MISC"},
+       {RADEON_PP_TXFILTER_0, 6, "RADEON_PP_TXFILTER_0"},
+       {RADEON_PP_BORDER_COLOR_0, 1, "RADEON_PP_BORDER_COLOR_0"},
+       {RADEON_PP_TXFILTER_1, 6, "RADEON_PP_TXFILTER_1"},
+       {RADEON_PP_BORDER_COLOR_1, 1, "RADEON_PP_BORDER_COLOR_1"},
+       {RADEON_PP_TXFILTER_2, 6, "RADEON_PP_TXFILTER_2"},
+       {RADEON_PP_BORDER_COLOR_2, 1, "RADEON_PP_BORDER_COLOR_2"},
+       {RADEON_SE_ZBIAS_FACTOR, 2, "RADEON_SE_ZBIAS_FACTOR"},
+       {RADEON_SE_TCL_OUTPUT_VTX_FMT, 11, "RADEON_SE_TCL_OUTPUT_VTX_FMT"},
+       {RADEON_SE_TCL_MATERIAL_EMMISSIVE_RED, 17,
+                   "RADEON_SE_TCL_MATERIAL_EMMISSIVE_RED"},
+       {R200_PP_TXCBLEND_0, 4, "R200_PP_TXCBLEND_0"},
+       {R200_PP_TXCBLEND_1, 4, "R200_PP_TXCBLEND_1"},
+       {R200_PP_TXCBLEND_2, 4, "R200_PP_TXCBLEND_2"},
+       {R200_PP_TXCBLEND_3, 4, "R200_PP_TXCBLEND_3"},
+       {R200_PP_TXCBLEND_4, 4, "R200_PP_TXCBLEND_4"},
+       {R200_PP_TXCBLEND_5, 4, "R200_PP_TXCBLEND_5"},
+       {R200_PP_TXCBLEND_6, 4, "R200_PP_TXCBLEND_6"},
+       {R200_PP_TXCBLEND_7, 4, "R200_PP_TXCBLEND_7"},
+       {R200_SE_TCL_LIGHT_MODEL_CTL_0, 6, "R200_SE_TCL_LIGHT_MODEL_CTL_0"},
+       {R200_PP_TFACTOR_0, 6, "R200_PP_TFACTOR_0"},
+       {R200_SE_VTX_FMT_0, 4, "R200_SE_VTX_FMT_0"},
+       {R200_SE_VAP_CNTL, 1, "R200_SE_VAP_CNTL"},
+       {R200_SE_TCL_MATRIX_SEL_0, 5, "R200_SE_TCL_MATRIX_SEL_0"},
+       {R200_SE_TCL_TEX_PROC_CTL_2, 5, "R200_SE_TCL_TEX_PROC_CTL_2"},
+       {R200_SE_TCL_UCP_VERT_BLEND_CTL, 1, "R200_SE_TCL_UCP_VERT_BLEND_CTL"},
+       {R200_PP_TXFILTER_0, 6, "R200_PP_TXFILTER_0"},
+       {R200_PP_TXFILTER_1, 6, "R200_PP_TXFILTER_1"},
+       {R200_PP_TXFILTER_2, 6, "R200_PP_TXFILTER_2"},
+       {R200_PP_TXFILTER_3, 6, "R200_PP_TXFILTER_3"},
+       {R200_PP_TXFILTER_4, 6, "R200_PP_TXFILTER_4"},
+       {R200_PP_TXFILTER_5, 6, "R200_PP_TXFILTER_5"},
+       {R200_PP_TXOFFSET_0, 1, "R200_PP_TXOFFSET_0"},
+       {R200_PP_TXOFFSET_1, 1, "R200_PP_TXOFFSET_1"},
+       {R200_PP_TXOFFSET_2, 1, "R200_PP_TXOFFSET_2"},
+       {R200_PP_TXOFFSET_3, 1, "R200_PP_TXOFFSET_3"},
+       {R200_PP_TXOFFSET_4, 1, "R200_PP_TXOFFSET_4"},
+       {R200_PP_TXOFFSET_5, 1, "R200_PP_TXOFFSET_5"},
+       {R200_SE_VTE_CNTL, 1, "R200_SE_VTE_CNTL"},
+       {R200_SE_TCL_OUTPUT_VTX_COMP_SEL, 1,
+        "R200_SE_TCL_OUTPUT_VTX_COMP_SEL"},
+       {R200_PP_TAM_DEBUG3, 1, "R200_PP_TAM_DEBUG3"},
+       {R200_PP_CNTL_X, 1, "R200_PP_CNTL_X"},
+       {R200_RB3D_DEPTHXY_OFFSET, 1, "R200_RB3D_DEPTHXY_OFFSET"},
+       {R200_RE_AUX_SCISSOR_CNTL, 1, "R200_RE_AUX_SCISSOR_CNTL"},
+       {R200_RE_SCISSOR_TL_0, 2, "R200_RE_SCISSOR_TL_0"},
+       {R200_RE_SCISSOR_TL_1, 2, "R200_RE_SCISSOR_TL_1"},
+       {R200_RE_SCISSOR_TL_2, 2, "R200_RE_SCISSOR_TL_2"},
+       {R200_SE_VAP_CNTL_STATUS, 1, "R200_SE_VAP_CNTL_STATUS"},
+       {R200_SE_VTX_STATE_CNTL, 1, "R200_SE_VTX_STATE_CNTL"},
+       {R200_RE_POINTSIZE, 1, "R200_RE_POINTSIZE"},
+       {R200_SE_TCL_INPUT_VTX_VECTOR_ADDR_0, 4,
+                   "R200_SE_TCL_INPUT_VTX_VECTOR_ADDR_0"},
+       {R200_PP_CUBIC_FACES_0, 1, "R200_PP_CUBIC_FACES_0"},    /* 61 */
+       {R200_PP_CUBIC_OFFSET_F1_0, 5, "R200_PP_CUBIC_OFFSET_F1_0"}, /* 62 */
+       {R200_PP_CUBIC_FACES_1, 1, "R200_PP_CUBIC_FACES_1"},
+       {R200_PP_CUBIC_OFFSET_F1_1, 5, "R200_PP_CUBIC_OFFSET_F1_1"},
+       {R200_PP_CUBIC_FACES_2, 1, "R200_PP_CUBIC_FACES_2"},
+       {R200_PP_CUBIC_OFFSET_F1_2, 5, "R200_PP_CUBIC_OFFSET_F1_2"},
+       {R200_PP_CUBIC_FACES_3, 1, "R200_PP_CUBIC_FACES_3"},
+       {R200_PP_CUBIC_OFFSET_F1_3, 5, "R200_PP_CUBIC_OFFSET_F1_3"},
+       {R200_PP_CUBIC_FACES_4, 1, "R200_PP_CUBIC_FACES_4"},
+       {R200_PP_CUBIC_OFFSET_F1_4, 5, "R200_PP_CUBIC_OFFSET_F1_4"},
+       {R200_PP_CUBIC_FACES_5, 1, "R200_PP_CUBIC_FACES_5"},
+       {R200_PP_CUBIC_OFFSET_F1_5, 5, "R200_PP_CUBIC_OFFSET_F1_5"},
+       {RADEON_PP_TEX_SIZE_0, 2, "RADEON_PP_TEX_SIZE_0"},
+       {RADEON_PP_TEX_SIZE_1, 2, "RADEON_PP_TEX_SIZE_1"},
+       {RADEON_PP_TEX_SIZE_2, 2, "RADEON_PP_TEX_SIZE_2"},
+       {R200_RB3D_BLENDCOLOR, 3, "R200_RB3D_BLENDCOLOR"},
+       {R200_SE_TCL_POINT_SPRITE_CNTL, 1, "R200_SE_TCL_POINT_SPRITE_CNTL"},
+       {RADEON_PP_CUBIC_FACES_0, 1, "RADEON_PP_CUBIC_FACES_0"},
+       {RADEON_PP_CUBIC_OFFSET_T0_0, 5, "RADEON_PP_CUBIC_OFFSET_T0_0"},
+       {RADEON_PP_CUBIC_FACES_1, 1, "RADEON_PP_CUBIC_FACES_1"},
+       {RADEON_PP_CUBIC_OFFSET_T1_0, 5, "RADEON_PP_CUBIC_OFFSET_T1_0"},
+       {RADEON_PP_CUBIC_FACES_2, 1, "RADEON_PP_CUBIC_FACES_2"},
+       {RADEON_PP_CUBIC_OFFSET_T2_0, 5, "RADEON_PP_CUBIC_OFFSET_T2_0"},
+       {R200_PP_TRI_PERF, 2, "R200_PP_TRI_PERF"},
+       {R200_PP_AFS_0, 32, "R200_PP_AFS_0"},     /* 85 */
+       {R200_PP_AFS_1, 32, "R200_PP_AFS_1"},
+       {R200_PP_TFACTOR_0, 8, "R200_ATF_TFACTOR"},
+       {R200_PP_TXFILTER_0, 8, "R200_PP_TXCTLALL_0"},
+       {R200_PP_TXFILTER_1, 8, "R200_PP_TXCTLALL_1"},
+       {R200_PP_TXFILTER_2, 8, "R200_PP_TXCTLALL_2"},
+       {R200_PP_TXFILTER_3, 8, "R200_PP_TXCTLALL_3"},
+       {R200_PP_TXFILTER_4, 8, "R200_PP_TXCTLALL_4"},
+       {R200_PP_TXFILTER_5, 8, "R200_PP_TXCTLALL_5"},
 };
 
-
-
 /* ================================================================
  * Performance monitoring functions
  */
 
-static void radeon_clear_box( drm_radeon_private_t *dev_priv,
-                             int x, int y, int w, int h,
-                             int r, int g, int b )
+static void radeon_clear_box(drm_radeon_private_t * dev_priv,
+                            int x, int y, int w, int h, int r, int g, int b)
 {
        u32 color;
        RING_LOCALS;
@@ -586,49 +641,47 @@ static void radeon_clear_box( drm_radeon_private_t *dev_priv,
        x += dev_priv->sarea_priv->boxes[0].x1;
        y += dev_priv->sarea_priv->boxes[0].y1;
 
-       switch ( dev_priv->color_fmt ) {
+       switch (dev_priv->color_fmt) {
        case RADEON_COLOR_FORMAT_RGB565:
                color = (((r & 0xf8) << 8) |
-                        ((g & 0xfc) << 3) |
-                        ((b & 0xf8) >> 3));
+                        ((g & 0xfc) << 3) | ((b & 0xf8) >> 3));
                break;
        case RADEON_COLOR_FORMAT_ARGB8888:
        default:
-               color = (((0xff) << 24) | (r << 16) | (g <<  8) | b);
+               color = (((0xff) << 24) | (r << 16) | (g << 8) | b);
                break;
        }
 
-       BEGIN_RING( 4 );
-       RADEON_WAIT_UNTIL_3D_IDLE();            
-       OUT_RING( CP_PACKET0( RADEON_DP_WRITE_MASK, 0 ) );
-       OUT_RING( 0xffffffff );
+       BEGIN_RING(4);
+       RADEON_WAIT_UNTIL_3D_IDLE();
+       OUT_RING(CP_PACKET0(RADEON_DP_WRITE_MASK, 0));
+       OUT_RING(0xffffffff);
        ADVANCE_RING();
 
-       BEGIN_RING( 6 );
+       BEGIN_RING(6);
 
-       OUT_RING( CP_PACKET3( RADEON_CNTL_PAINT_MULTI, 4 ) );
-       OUT_RING( RADEON_GMC_DST_PITCH_OFFSET_CNTL |
-                 RADEON_GMC_BRUSH_SOLID_COLOR |
-                 (dev_priv->color_fmt << 8) |
-                 RADEON_GMC_SRC_DATATYPE_COLOR |
-                 RADEON_ROP3_P |
-                 RADEON_GMC_CLR_CMP_CNTL_DIS );
+       OUT_RING(CP_PACKET3(RADEON_CNTL_PAINT_MULTI, 4));
+       OUT_RING(RADEON_GMC_DST_PITCH_OFFSET_CNTL |
+                RADEON_GMC_BRUSH_SOLID_COLOR |
+                (dev_priv->color_fmt << 8) |
+                RADEON_GMC_SRC_DATATYPE_COLOR |
+                RADEON_ROP3_P | RADEON_GMC_CLR_CMP_CNTL_DIS);
 
-       if ( dev_priv->page_flipping && dev_priv->current_page == 1 ) { 
-               OUT_RING( dev_priv->front_pitch_offset );
-       } else {         
-               OUT_RING( dev_priv->back_pitch_offset );
-       } 
+       if (dev_priv->page_flipping && dev_priv->current_page == 1) {
+               OUT_RING(dev_priv->front_pitch_offset);
+       } else {
+               OUT_RING(dev_priv->back_pitch_offset);
+       }
 
-       OUT_RING( color );
+       OUT_RING(color);
 
-       OUT_RING( (x << 16) | y );
-       OUT_RING( (w << 16) | h );
+       OUT_RING((x << 16) | y);
+       OUT_RING((w << 16) | h);
 
        ADVANCE_RING();
 }
 
-static void radeon_cp_performance_boxes( drm_radeon_private_t *dev_priv )
+static void radeon_cp_performance_boxes(drm_radeon_private_t * dev_priv)
 {
        /* Collapse various things into a wait flag -- trying to
         * guess if userspase slept -- better just to have them tell us.
@@ -644,50 +697,50 @@ static void radeon_cp_performance_boxes( drm_radeon_private_t *dev_priv )
 
        /* Purple box for page flipping
         */
-       if ( dev_priv->stats.boxes & RADEON_BOX_FLIP ) 
-               radeon_clear_box( dev_priv, 4, 4, 8, 8, 255, 0, 255 );
+       if (dev_priv->stats.boxes & RADEON_BOX_FLIP)
+               radeon_clear_box(dev_priv, 4, 4, 8, 8, 255, 0, 255);
 
        /* Red box if we have to wait for idle at any point
         */
-       if ( dev_priv->stats.boxes & RADEON_BOX_WAIT_IDLE ) 
-               radeon_clear_box( dev_priv, 16, 4, 8, 8, 255, 0, 0 );
+       if (dev_priv->stats.boxes & RADEON_BOX_WAIT_IDLE)
+               radeon_clear_box(dev_priv, 16, 4, 8, 8, 255, 0, 0);
 
        /* Blue box: lost context?
         */
 
        /* Yellow box for texture swaps
         */
-       if ( dev_priv->stats.boxes & RADEON_BOX_TEXTURE_LOAD ) 
-               radeon_clear_box( dev_priv, 40, 4, 8, 8, 255, 255, 0 );
+       if (dev_priv->stats.boxes & RADEON_BOX_TEXTURE_LOAD)
+               radeon_clear_box(dev_priv, 40, 4, 8, 8, 255, 255, 0);
 
        /* Green box if hardware never idles (as far as we can tell)
         */
-       if ( !(dev_priv->stats.boxes & RADEON_BOX_DMA_IDLE) ) 
-               radeon_clear_box( dev_priv, 64, 4, 8, 8, 0, 255, 0 );
-
+       if (!(dev_priv->stats.boxes & RADEON_BOX_DMA_IDLE))
+               radeon_clear_box(dev_priv, 64, 4, 8, 8, 0, 255, 0);
 
-       /* Draw bars indicating number of buffers allocated 
+       /* Draw bars indicating number of buffers allocated
         * (not a great measure, easily confused)
         */
        if (dev_priv->stats.requested_bufs) {
                if (dev_priv->stats.requested_bufs > 100)
                        dev_priv->stats.requested_bufs = 100;
 
-               radeon_clear_box( dev_priv, 4, 16,  
-                                 dev_priv->stats.requested_bufs, 4,
-                                 196, 128, 128 );
+               radeon_clear_box(dev_priv, 4, 16,
+                                dev_priv->stats.requested_bufs, 4,
+                                196, 128, 128);
        }
 
-       memset( &dev_priv->stats, 0, sizeof(dev_priv->stats) );
+       memset(&dev_priv->stats, 0, sizeof(dev_priv->stats));
 
 }
+
 /* ================================================================
  * CP command dispatch functions
  */
 
-static void radeon_cp_dispatch_clear( drm_device_t *dev,
-                                     drm_radeon_clear_t *clear,
-                                     drm_radeon_clear_rect_t *depth_boxes )
+static void radeon_cp_dispatch_clear(drm_device_t * dev,
+                                    drm_radeon_clear_t * clear,
+                                    drm_radeon_clear_rect_t * depth_boxes)
 {
        drm_radeon_private_t *dev_priv = dev->dev_private;
        drm_radeon_sarea_t *sarea_priv = dev_priv->sarea_priv;
@@ -695,32 +748,34 @@ static void radeon_cp_dispatch_clear( drm_device_t *dev,
        int nbox = sarea_priv->nbox;
        drm_clip_rect_t *pbox = sarea_priv->boxes;
        unsigned int flags = clear->flags;
-       u32 rb3d_cntl = 0, rb3d_stencilrefmask= 0;
+       u32 rb3d_cntl = 0, rb3d_stencilrefmask = 0;
        int i;
        RING_LOCALS;
-       DRM_DEBUG( "flags = 0x%x\n", flags );
+       DRM_DEBUG("flags = 0x%x\n", flags);
 
        dev_priv->stats.clears++;
 
-       if ( dev_priv->page_flipping && dev_priv->current_page == 1 ) {
+       if (dev_priv->page_flipping && dev_priv->current_page == 1) {
                unsigned int tmp = flags;
 
                flags &= ~(RADEON_FRONT | RADEON_BACK);
-               if ( tmp & RADEON_FRONT ) flags |= RADEON_BACK;
-               if ( tmp & RADEON_BACK )  flags |= RADEON_FRONT;
+               if (tmp & RADEON_FRONT)
+                       flags |= RADEON_BACK;
+               if (tmp & RADEON_BACK)
+                       flags |= RADEON_FRONT;
        }
 
-       if ( flags & (RADEON_FRONT | RADEON_BACK) ) {
+       if (flags & (RADEON_FRONT | RADEON_BACK)) {
 
-               BEGIN_RING( 4 );
+               BEGIN_RING(4);
 
                /* Ensure the 3D stream is idle before doing a
                 * 2D fill to clear the front or back buffer.
                 */
                RADEON_WAIT_UNTIL_3D_IDLE();
-               
-               OUT_RING( CP_PACKET0( RADEON_DP_WRITE_MASK, 0 ) );
-               OUT_RING( clear->color_mask );
+
+               OUT_RING(CP_PACKET0(RADEON_DP_WRITE_MASK, 0));
+               OUT_RING(clear->color_mask);
 
                ADVANCE_RING();
 
@@ -728,121 +783,130 @@ static void radeon_cp_dispatch_clear( drm_device_t *dev,
                 */
                dev_priv->sarea_priv->ctx_owner = 0;
 
-               for ( i = 0 ; i < nbox ; i++ ) {
+               for (i = 0; i < nbox; i++) {
                        int x = pbox[i].x1;
                        int y = pbox[i].y1;
                        int w = pbox[i].x2 - x;
                        int h = pbox[i].y2 - y;
 
-                       DRM_DEBUG( "dispatch clear %d,%d-%d,%d flags 0x%x\n",
-                                  x, y, w, h, flags );
-
-                       if ( flags & RADEON_FRONT ) {
-                               BEGIN_RING( 6 );
-                               
-                               OUT_RING( CP_PACKET3( RADEON_CNTL_PAINT_MULTI, 4 ) );
-                               OUT_RING( RADEON_GMC_DST_PITCH_OFFSET_CNTL |
-                                         RADEON_GMC_BRUSH_SOLID_COLOR |
-                                         (dev_priv->color_fmt << 8) |
-                                         RADEON_GMC_SRC_DATATYPE_COLOR |
-                                         RADEON_ROP3_P |
-                                         RADEON_GMC_CLR_CMP_CNTL_DIS );
-
-                               OUT_RING( dev_priv->front_pitch_offset );
-                               OUT_RING( clear->clear_color );
-                               
-                               OUT_RING( (x << 16) | y );
-                               OUT_RING( (w << 16) | h );
-                               
+                       DRM_DEBUG("dispatch clear %d,%d-%d,%d flags 0x%x\n",
+                                 x, y, w, h, flags);
+
+                       if (flags & RADEON_FRONT) {
+                               BEGIN_RING(6);
+
+                               OUT_RING(CP_PACKET3
+                                        (RADEON_CNTL_PAINT_MULTI, 4));
+                               OUT_RING(RADEON_GMC_DST_PITCH_OFFSET_CNTL |
+                                        RADEON_GMC_BRUSH_SOLID_COLOR |
+                                        (dev_priv->
+                                         color_fmt << 8) |
+                                        RADEON_GMC_SRC_DATATYPE_COLOR |
+                                        RADEON_ROP3_P |
+                                        RADEON_GMC_CLR_CMP_CNTL_DIS);
+
+                               OUT_RING(dev_priv->front_pitch_offset);
+                               OUT_RING(clear->clear_color);
+
+                               OUT_RING((x << 16) | y);
+                               OUT_RING((w << 16) | h);
+
                                ADVANCE_RING();
                        }
-                       
-                       if ( flags & RADEON_BACK ) {
-                               BEGIN_RING( 6 );
-                               
-                               OUT_RING( CP_PACKET3( RADEON_CNTL_PAINT_MULTI, 4 ) );
-                               OUT_RING( RADEON_GMC_DST_PITCH_OFFSET_CNTL |
-                                         RADEON_GMC_BRUSH_SOLID_COLOR |
-                                         (dev_priv->color_fmt << 8) |
-                                         RADEON_GMC_SRC_DATATYPE_COLOR |
-                                         RADEON_ROP3_P |
-                                         RADEON_GMC_CLR_CMP_CNTL_DIS );
-                               
-                               OUT_RING( dev_priv->back_pitch_offset );
-                               OUT_RING( clear->clear_color );
-
-                               OUT_RING( (x << 16) | y );
-                               OUT_RING( (w << 16) | h );
+
+                       if (flags & RADEON_BACK) {
+                               BEGIN_RING(6);
+
+                               OUT_RING(CP_PACKET3
+                                        (RADEON_CNTL_PAINT_MULTI, 4));
+                               OUT_RING(RADEON_GMC_DST_PITCH_OFFSET_CNTL |
+                                        RADEON_GMC_BRUSH_SOLID_COLOR |
+                                        (dev_priv->
+                                         color_fmt << 8) |
+                                        RADEON_GMC_SRC_DATATYPE_COLOR |
+                                        RADEON_ROP3_P |
+                                        RADEON_GMC_CLR_CMP_CNTL_DIS);
+
+                               OUT_RING(dev_priv->back_pitch_offset);
+                               OUT_RING(clear->clear_color);
+
+                               OUT_RING((x << 16) | y);
+                               OUT_RING((w << 16) | h);
 
                                ADVANCE_RING();
                        }
                }
        }
-       
+
        /* hyper z clear */
        /* no docs available, based on reverse engeneering by Stephane Marchesin */
-       if ((flags & (RADEON_DEPTH | RADEON_STENCIL)) && (flags & RADEON_CLEAR_FASTZ)) {
+       if ((flags & (RADEON_DEPTH | RADEON_STENCIL))
+           && (flags & RADEON_CLEAR_FASTZ)) {
 
                int i;
-               int depthpixperline = dev_priv->depth_fmt==RADEON_DEPTH_FORMAT_16BIT_INT_Z? 
-                       (dev_priv->depth_pitch / 2): (dev_priv->depth_pitch / 4);
-               
+               int depthpixperline =
+                   dev_priv->depth_fmt ==
+                   RADEON_DEPTH_FORMAT_16BIT_INT_Z ? (dev_priv->depth_pitch /
+                                                      2) : (dev_priv->
+                                                            depth_pitch / 4);
+
                u32 clearmask;
 
                u32 tempRB3D_DEPTHCLEARVALUE = clear->clear_depth |
-                       ((clear->depth_mask & 0xff) << 24);
-       
-               
+                   ((clear->depth_mask & 0xff) << 24);
+
                /* Make sure we restore the 3D state next time.
                 * we haven't touched any "normal" state - still need this?
                 */
                dev_priv->sarea_priv->ctx_owner = 0;
 
-               if ((dev_priv->flags & CHIP_HAS_HIERZ) && (flags & RADEON_USE_HIERZ)) {
-               /* FIXME : reverse engineer that for Rx00 cards */
-               /* FIXME : the mask supposedly contains low-res z values. So can't set
-                  just to the max (0xff? or actually 0x3fff?), need to take z clear
-                  value into account? */
-               /* pattern seems to work for r100, though get slight
-                  rendering errors with glxgears. If hierz is not enabled for r100,
-                  only 4 bits which indicate clear (15,16,31,32, all zero) matter, the
-                  other ones are ignored, and the same clear mask can be used. That's
-                  very different behaviour than R200 which needs different clear mask
-                  and different number of tiles to clear if hierz is enabled or not !?!
-               */
-                       clearmask = (0xff<<22)|(0xff<<6)| 0x003f003f;
-               }
-               else {
-               /* clear mask : chooses the clearing pattern.
-                  rv250: could be used to clear only parts of macrotiles
-                  (but that would get really complicated...)?
-                  bit 0 and 1 (either or both of them ?!?!) are used to
-                  not clear tile (or maybe one of the bits indicates if the tile is
-                  compressed or not), bit 2 and 3 to not clear tile 1,...,.
-                  Pattern is as follows:
-                       | 0,1 | 4,5 | 8,9 |12,13|16,17|20,21|24,25|28,29|
-                  bits -------------------------------------------------
-                       | 2,3 | 6,7 |10,11|14,15|18,19|22,23|26,27|30,31|
-                  rv100: clearmask covers 2x8 4x1 tiles, but one clear still
-                  covers 256 pixels ?!?
-               */
+               if ((dev_priv->flags & CHIP_HAS_HIERZ)
+                   && (flags & RADEON_USE_HIERZ)) {
+                       /* FIXME : reverse engineer that for Rx00 cards */
+                       /* FIXME : the mask supposedly contains low-res z values. So can't set
+                          just to the max (0xff? or actually 0x3fff?), need to take z clear
+                          value into account? */
+                       /* pattern seems to work for r100, though get slight
+                          rendering errors with glxgears. If hierz is not enabled for r100,
+                          only 4 bits which indicate clear (15,16,31,32, all zero) matter, the
+                          other ones are ignored, and the same clear mask can be used. That's
+                          very different behaviour than R200 which needs different clear mask
+                          and different number of tiles to clear if hierz is enabled or not !?!
+                        */
+                       clearmask = (0xff << 22) | (0xff << 6) | 0x003f003f;
+               else {
+                       /* clear mask : chooses the clearing pattern.
+                          rv250: could be used to clear only parts of macrotiles
+                          (but that would get really complicated...)?
+                          bit 0 and 1 (either or both of them ?!?!) are used to
+                          not clear tile (or maybe one of the bits indicates if the tile is
+                          compressed or not), bit 2 and 3 to not clear tile 1,...,.
+                          Pattern is as follows:
+                          | 0,1 | 4,5 | 8,9 |12,13|16,17|20,21|24,25|28,29|
+                          bits -------------------------------------------------
+                          | 2,3 | 6,7 |10,11|14,15|18,19|22,23|26,27|30,31|
+                          rv100: clearmask covers 2x8 4x1 tiles, but one clear still
+                          covers 256 pixels ?!?
+                        */
                        clearmask = 0x0;
                }
 
-               BEGIN_RING( 8 );
+               BEGIN_RING(8);
                RADEON_WAIT_UNTIL_2D_IDLE();
-               OUT_RING_REG( RADEON_RB3D_DEPTHCLEARVALUE,
-                       tempRB3D_DEPTHCLEARVALUE);
+               OUT_RING_REG(RADEON_RB3D_DEPTHCLEARVALUE,
+                            tempRB3D_DEPTHCLEARVALUE);
                /* what offset is this exactly ? */
-               OUT_RING_REG( RADEON_RB3D_ZMASKOFFSET, 0 );
+               OUT_RING_REG(RADEON_RB3D_ZMASKOFFSET, 0);
                /* need ctlstat, otherwise get some strange black flickering */
-               OUT_RING_REG( RADEON_RB3D_ZCACHE_CTLSTAT, RADEON_RB3D_ZC_FLUSH_ALL );
+               OUT_RING_REG(RADEON_RB3D_ZCACHE_CTLSTAT,
+                            RADEON_RB3D_ZC_FLUSH_ALL);
                ADVANCE_RING();
 
                for (i = 0; i < nbox; i++) {
                        int tileoffset, nrtilesx, nrtilesy, j;
                        /* it looks like r200 needs rv-style clears, at least if hierz is not enabled? */
-                       if ((dev_priv->flags&CHIP_HAS_HIERZ) && !(dev_priv->microcode_version==UCODE_R200)) {
+                       if ((dev_priv->flags & CHIP_HAS_HIERZ)
+                           && !(dev_priv->microcode_version == UCODE_R200)) {
                                /* FIXME : figure this out for r200 (when hierz is enabled). Or
                                   maybe r200 actually doesn't need to put the low-res z value into
                                   the tile cache like r100, but just needs to clear the hi-level z-buffer?
@@ -850,59 +914,74 @@ static void radeon_cp_dispatch_clear( drm_device_t *dev,
                                   R100 seems to operate on 2x1 8x8 tiles, but...
                                   odd: offset/nrtiles need to be 64 pix (4 block) aligned? Potentially
                                   problematic with resolutions which are not 64 pix aligned? */
-                               tileoffset = ((pbox[i].y1 >> 3) * depthpixperline + pbox[i].x1) >> 6;
-                               nrtilesx = ((pbox[i].x2 & ~63) - (pbox[i].x1 & ~63)) >> 4;
-                               nrtilesy = (pbox[i].y2 >> 3) - (pbox[i].y1 >> 3);
+                               tileoffset =
+                                   ((pbox[i].y1 >> 3) * depthpixperline +
+                                    pbox[i].x1) >> 6;
+                               nrtilesx =
+                                   ((pbox[i].x2 & ~63) -
+                                    (pbox[i].x1 & ~63)) >> 4;
+                               nrtilesy =
+                                   (pbox[i].y2 >> 3) - (pbox[i].y1 >> 3);
                                for (j = 0; j <= nrtilesy; j++) {
-                                       BEGIN_RING( 4 );
-                                       OUT_RING( CP_PACKET3( RADEON_3D_CLEAR_ZMASK, 2 ) );
+                                       BEGIN_RING(4);
+                                       OUT_RING(CP_PACKET3
+                                                (RADEON_3D_CLEAR_ZMASK, 2));
                                        /* first tile */
-                                       OUT_RING( tileoffset * 8 );
+                                       OUT_RING(tileoffset * 8);
                                        /* the number of tiles to clear */
-                                       OUT_RING( nrtilesx + 4 );
+                                       OUT_RING(nrtilesx + 4);
                                        /* clear mask : chooses the clearing pattern. */
-                                       OUT_RING( clearmask );
+                                       OUT_RING(clearmask);
                                        ADVANCE_RING();
                                        tileoffset += depthpixperline >> 6;
                                }
-                       }
-                       else if (dev_priv->microcode_version==UCODE_R200) {
+                       } else if (dev_priv->microcode_version == UCODE_R200) {
                                /* works for rv250. */
                                /* find first macro tile (8x2 4x4 z-pixels on rv250) */
-                               tileoffset = ((pbox[i].y1 >> 3) * depthpixperline + pbox[i].x1) >> 5;
-                               nrtilesx = (pbox[i].x2 >> 5) - (pbox[i].x1 >> 5);
-                               nrtilesy = (pbox[i].y2 >> 3) - (pbox[i].y1 >> 3);
+                               tileoffset =
+                                   ((pbox[i].y1 >> 3) * depthpixperline +
+                                    pbox[i].x1) >> 5;
+                               nrtilesx =
+                                   (pbox[i].x2 >> 5) - (pbox[i].x1 >> 5);
+                               nrtilesy =
+                                   (pbox[i].y2 >> 3) - (pbox[i].y1 >> 3);
                                for (j = 0; j <= nrtilesy; j++) {
-                                       BEGIN_RING( 4 );
-                                       OUT_RING( CP_PACKET3( RADEON_3D_CLEAR_ZMASK, 2 ) );
+                                       BEGIN_RING(4);
+                                       OUT_RING(CP_PACKET3
+                                                (RADEON_3D_CLEAR_ZMASK, 2));
                                        /* first tile */
                                        /* judging by the first tile offset needed, could possibly
                                           directly address/clear 4x4 tiles instead of 8x2 * 4x4
                                           macro tiles, though would still need clear mask for
                                           right/bottom if truely 4x4 granularity is desired ? */
-                                       OUT_RING( tileoffset * 16 );
+                                       OUT_RING(tileoffset * 16);
                                        /* the number of tiles to clear */
-                                       OUT_RING( nrtilesx + 1 );
+                                       OUT_RING(nrtilesx + 1);
                                        /* clear mask : chooses the clearing pattern. */
-                                       OUT_RING( clearmask );
+                                       OUT_RING(clearmask);
                                        ADVANCE_RING();
                                        tileoffset += depthpixperline >> 5;
                                }
-                       }
-                       else { /* rv 100 */
+                       } else {        /* rv 100 */
                                /* rv100 might not need 64 pix alignment, who knows */
                                /* offsets are, hmm, weird */
-                               tileoffset = ((pbox[i].y1 >> 4) * depthpixperline + pbox[i].x1) >> 6;
-                               nrtilesx = ((pbox[i].x2 & ~63) - (pbox[i].x1 & ~63)) >> 4;
-                               nrtilesy = (pbox[i].y2 >> 4) - (pbox[i].y1 >> 4);
+                               tileoffset =
+                                   ((pbox[i].y1 >> 4) * depthpixperline +
+                                    pbox[i].x1) >> 6;
+                               nrtilesx =
+                                   ((pbox[i].x2 & ~63) -
+                                    (pbox[i].x1 & ~63)) >> 4;
+                               nrtilesy =
+                                   (pbox[i].y2 >> 4) - (pbox[i].y1 >> 4);
                                for (j = 0; j <= nrtilesy; j++) {
-                                       BEGIN_RING( 4 );
-                                       OUT_RING( CP_PACKET3( RADEON_3D_CLEAR_ZMASK, 2 ) );
-                                       OUT_RING( tileoffset * 128 );
+                                       BEGIN_RING(4);
+                                       OUT_RING(CP_PACKET3
+                                                (RADEON_3D_CLEAR_ZMASK, 2));
+                                       OUT_RING(tileoffset * 128);
                                        /* the number of tiles to clear */
-                                       OUT_RING( nrtilesx + 4 );
+                                       OUT_RING(nrtilesx + 4);
                                        /* clear mask : chooses the clearing pattern. */
-                                       OUT_RING( clearmask );
+                                       OUT_RING(clearmask);
                                        ADVANCE_RING();
                                        tileoffset += depthpixperline >> 6;
                                }
@@ -910,18 +989,19 @@ static void radeon_cp_dispatch_clear( drm_device_t *dev,
                }
 
                /* TODO don't always clear all hi-level z tiles */
-               if ((dev_priv->flags & CHIP_HAS_HIERZ) && (dev_priv->microcode_version==UCODE_R200)
-                       && (flags & RADEON_USE_HIERZ))
-               /* r100 and cards without hierarchical z-buffer have no high-level z-buffer */
-               /* FIXME : the mask supposedly contains low-res z values. So can't set
-                  just to the max (0xff? or actually 0x3fff?), need to take z clear
-                  value into account? */
+               if ((dev_priv->flags & CHIP_HAS_HIERZ)
+                   && (dev_priv->microcode_version == UCODE_R200)
+                   && (flags & RADEON_USE_HIERZ))
+                       /* r100 and cards without hierarchical z-buffer have no high-level z-buffer */
+                       /* FIXME : the mask supposedly contains low-res z values. So can't set
+                          just to the max (0xff? or actually 0x3fff?), need to take z clear
+                          value into account? */
                {
-                       BEGIN_RING( 4 );
-                       OUT_RING( CP_PACKET3( RADEON_3D_CLEAR_HIZ, 2 ) );
-                       OUT_RING( 0x0 ); /* First tile */
-                       OUT_RING( 0x3cc0 );
-                       OUT_RING( (0xff<<22)|(0xff<<6)| 0x003f003f);
+                       BEGIN_RING(4);
+                       OUT_RING(CP_PACKET3(RADEON_3D_CLEAR_HIZ, 2));
+                       OUT_RING(0x0);  /* First tile */
+                       OUT_RING(0x3cc0);
+                       OUT_RING((0xff << 22) | (0xff << 6) | 0x003f003f);
                        ADVANCE_RING();
                }
        }
@@ -930,8 +1010,8 @@ static void radeon_cp_dispatch_clear( drm_device_t *dev,
         * rendering a quad into just those buffers.  Thus, we have to
         * make sure the 3D engine is configured correctly.
         */
-       if ((dev_priv->microcode_version == UCODE_R200) &&
-           (flags & (RADEON_DEPTH | RADEON_STENCIL))) {
+       else if ((dev_priv->microcode_version == UCODE_R200) &&
+               (flags & (RADEON_DEPTH | RADEON_STENCIL))) {
 
                int tempPP_CNTL;
                int tempRE_CNTL;
@@ -956,30 +1036,27 @@ static void radeon_cp_dispatch_clear( drm_device_t *dev,
 
                tempSE_CNTL = depth_clear->se_cntl;
 
-
-
                /* Disable TCL */
 
-               tempSE_VAP_CNTL = (/* SE_VAP_CNTL__FORCE_W_TO_ONE_MASK |  */
-                                  (0x9 << SE_VAP_CNTL__VF_MAX_VTX_NUM__SHIFT));
+               tempSE_VAP_CNTL = (     /* SE_VAP_CNTL__FORCE_W_TO_ONE_MASK |  */
+                                         (0x9 <<
+                                          SE_VAP_CNTL__VF_MAX_VTX_NUM__SHIFT));
 
                tempRB3D_PLANEMASK = 0x0;
 
                tempRE_AUX_SCISSOR_CNTL = 0x0;
 
                tempSE_VTE_CNTL =
-                       SE_VTE_CNTL__VTX_XY_FMT_MASK |
-                       SE_VTE_CNTL__VTX_Z_FMT_MASK;
+                   SE_VTE_CNTL__VTX_XY_FMT_MASK | SE_VTE_CNTL__VTX_Z_FMT_MASK;
 
-               /* Vertex format (X, Y, Z, W)*/
+               /* Vertex format (X, Y, Z, W) */
                tempSE_VTX_FMT_0 =
-                       SE_VTX_FMT_0__VTX_Z0_PRESENT_MASK |
-                       SE_VTX_FMT_0__VTX_W0_PRESENT_MASK;
+                   SE_VTX_FMT_0__VTX_Z0_PRESENT_MASK |
+                   SE_VTX_FMT_0__VTX_W0_PRESENT_MASK;
                tempSE_VTX_FMT_1 = 0x0;
 
-
-               /* 
-                * Depth buffer specific enables 
+               /*
+                * Depth buffer specific enables
                 */
                if (flags & RADEON_DEPTH) {
                        /* Enable depth buffer */
@@ -989,12 +1066,12 @@ static void radeon_cp_dispatch_clear( drm_device_t *dev,
                        tempRB3D_CNTL &= ~RADEON_Z_ENABLE;
                }
 
-               /* 
+               /*
                 * Stencil buffer specific enables
                 */
-               if ( flags & RADEON_STENCIL ) {
-                       tempRB3D_CNTL |=  RADEON_STENCIL_ENABLE;
-                       tempRB3D_STENCILREFMASK = clear->depth_mask; 
+               if (flags & RADEON_STENCIL) {
+                       tempRB3D_CNTL |= RADEON_STENCIL_ENABLE;
+                       tempRB3D_STENCILREFMASK = clear->depth_mask;
                } else {
                        tempRB3D_CNTL &= ~RADEON_STENCIL_ENABLE;
                        tempRB3D_STENCILREFMASK = 0x00000000;
@@ -1002,79 +1079,75 @@ static void radeon_cp_dispatch_clear( drm_device_t *dev,
 
                if (flags & RADEON_USE_COMP_ZBUF) {
                        tempRB3D_ZSTENCILCNTL |= RADEON_Z_COMPRESSION_ENABLE |
-                               RADEON_Z_DECOMPRESSION_ENABLE;
+                           RADEON_Z_DECOMPRESSION_ENABLE;
                }
                if (flags & RADEON_USE_HIERZ) {
                        tempRB3D_ZSTENCILCNTL |= RADEON_Z_HIERARCHY_ENABLE;
                }
 
-               BEGIN_RING( 26 );
+               BEGIN_RING(26);
                RADEON_WAIT_UNTIL_2D_IDLE();
 
-               OUT_RING_REG( RADEON_PP_CNTL, tempPP_CNTL );
-               OUT_RING_REG( R200_RE_CNTL, tempRE_CNTL );
-               OUT_RING_REG( RADEON_RB3D_CNTL, tempRB3D_CNTL );
-               OUT_RING_REG( RADEON_RB3D_ZSTENCILCNTL,
-                             tempRB3D_ZSTENCILCNTL );
-               OUT_RING_REG( RADEON_RB3D_STENCILREFMASK, 
-                             tempRB3D_STENCILREFMASK );
-               OUT_RING_REG( RADEON_RB3D_PLANEMASK, tempRB3D_PLANEMASK );
-               OUT_RING_REG( RADEON_SE_CNTL, tempSE_CNTL );
-               OUT_RING_REG( R200_SE_VTE_CNTL, tempSE_VTE_CNTL );
-               OUT_RING_REG( R200_SE_VTX_FMT_0, tempSE_VTX_FMT_0 );
-               OUT_RING_REG( R200_SE_VTX_FMT_1, tempSE_VTX_FMT_1 );
-               OUT_RING_REG( R200_SE_VAP_CNTL, tempSE_VAP_CNTL );
-               OUT_RING_REG( R200_RE_AUX_SCISSOR_CNTL, 
-                             tempRE_AUX_SCISSOR_CNTL );
+               OUT_RING_REG(RADEON_PP_CNTL, tempPP_CNTL);
+               OUT_RING_REG(R200_RE_CNTL, tempRE_CNTL);
+               OUT_RING_REG(RADEON_RB3D_CNTL, tempRB3D_CNTL);
+               OUT_RING_REG(RADEON_RB3D_ZSTENCILCNTL, tempRB3D_ZSTENCILCNTL);
+               OUT_RING_REG(RADEON_RB3D_STENCILREFMASK,
+                            tempRB3D_STENCILREFMASK);
+               OUT_RING_REG(RADEON_RB3D_PLANEMASK, tempRB3D_PLANEMASK);
+               OUT_RING_REG(RADEON_SE_CNTL, tempSE_CNTL);
+               OUT_RING_REG(R200_SE_VTE_CNTL, tempSE_VTE_CNTL);
+               OUT_RING_REG(R200_SE_VTX_FMT_0, tempSE_VTX_FMT_0);
+               OUT_RING_REG(R200_SE_VTX_FMT_1, tempSE_VTX_FMT_1);
+               OUT_RING_REG(R200_SE_VAP_CNTL, tempSE_VAP_CNTL);
+               OUT_RING_REG(R200_RE_AUX_SCISSOR_CNTL, tempRE_AUX_SCISSOR_CNTL);
                ADVANCE_RING();
 
                /* Make sure we restore the 3D state next time.
                 */
                dev_priv->sarea_priv->ctx_owner = 0;
 
-               for ( i = 0 ; i < nbox ; i++ ) {
-                       
-                       /* Funny that this should be required -- 
+               for (i = 0; i < nbox; i++) {
+
+                       /* Funny that this should be required --
                         *  sets top-left?
                         */
-                       radeon_emit_clip_rect( dev_priv,
-                                              &sarea_priv->boxes[i] );
-
-                       BEGIN_RING( 14 );
-                       OUT_RING( CP_PACKET3( R200_3D_DRAW_IMMD_2, 12 ) );
-                       OUT_RING( (RADEON_PRIM_TYPE_RECT_LIST |
-                                  RADEON_PRIM_WALK_RING |
-                                  (3 << RADEON_NUM_VERTICES_SHIFT)) );
-                       OUT_RING( depth_boxes[i].ui[CLEAR_X1] );
-                       OUT_RING( depth_boxes[i].ui[CLEAR_Y1] );
-                       OUT_RING( depth_boxes[i].ui[CLEAR_DEPTH] );
-                       OUT_RING( 0x3f800000 );
-                       OUT_RING( depth_boxes[i].ui[CLEAR_X1] );
-                       OUT_RING( depth_boxes[i].ui[CLEAR_Y2] );
-                       OUT_RING( depth_boxes[i].ui[CLEAR_DEPTH] );
-                       OUT_RING( 0x3f800000 );
-                       OUT_RING( depth_boxes[i].ui[CLEAR_X2] );
-                       OUT_RING( depth_boxes[i].ui[CLEAR_Y2] );
-                       OUT_RING( depth_boxes[i].ui[CLEAR_DEPTH] );
-                       OUT_RING( 0x3f800000 );
+                       radeon_emit_clip_rect(dev_priv, &sarea_priv->boxes[i]);
+
+                       BEGIN_RING(14);
+                       OUT_RING(CP_PACKET3(R200_3D_DRAW_IMMD_2, 12));
+                       OUT_RING((RADEON_PRIM_TYPE_RECT_LIST |
+                                 RADEON_PRIM_WALK_RING |
+                                 (3 << RADEON_NUM_VERTICES_SHIFT)));
+                       OUT_RING(depth_boxes[i].ui[CLEAR_X1]);
+                       OUT_RING(depth_boxes[i].ui[CLEAR_Y1]);
+                       OUT_RING(depth_boxes[i].ui[CLEAR_DEPTH]);
+                       OUT_RING(0x3f800000);
+                       OUT_RING(depth_boxes[i].ui[CLEAR_X1]);
+                       OUT_RING(depth_boxes[i].ui[CLEAR_Y2]);
+                       OUT_RING(depth_boxes[i].ui[CLEAR_DEPTH]);
+                       OUT_RING(0x3f800000);
+                       OUT_RING(depth_boxes[i].ui[CLEAR_X2]);
+                       OUT_RING(depth_boxes[i].ui[CLEAR_Y2]);
+                       OUT_RING(depth_boxes[i].ui[CLEAR_DEPTH]);
+                       OUT_RING(0x3f800000);
                        ADVANCE_RING();
                }
-       } 
-       else if ( (flags & (RADEON_DEPTH | RADEON_STENCIL)) ) {
+       } else if ((flags & (RADEON_DEPTH | RADEON_STENCIL))) {
 
                int tempRB3D_ZSTENCILCNTL = depth_clear->rb3d_zstencilcntl;
 
                rb3d_cntl = depth_clear->rb3d_cntl;
 
-               if ( flags & RADEON_DEPTH ) {
-                       rb3d_cntl |=  RADEON_Z_ENABLE;
+               if (flags & RADEON_DEPTH) {
+                       rb3d_cntl |= RADEON_Z_ENABLE;
                } else {
                        rb3d_cntl &= ~RADEON_Z_ENABLE;
                }
 
-               if ( flags & RADEON_STENCIL ) {
-                       rb3d_cntl |=  RADEON_STENCIL_ENABLE;
-                       rb3d_stencilrefmask = clear->depth_mask; /* misnamed field */
+               if (flags & RADEON_STENCIL) {
+                       rb3d_cntl |= RADEON_STENCIL_ENABLE;
+                       rb3d_stencilrefmask = clear->depth_mask;        /* misnamed field */
                } else {
                        rb3d_cntl &= ~RADEON_STENCIL_ENABLE;
                        rb3d_stencilrefmask = 0x00000000;
@@ -1082,66 +1155,61 @@ static void radeon_cp_dispatch_clear( drm_device_t *dev,
 
                if (flags & RADEON_USE_COMP_ZBUF) {
                        tempRB3D_ZSTENCILCNTL |= RADEON_Z_COMPRESSION_ENABLE |
-                               RADEON_Z_DECOMPRESSION_ENABLE;
+                           RADEON_Z_DECOMPRESSION_ENABLE;
                }
                if (flags & RADEON_USE_HIERZ) {
                        tempRB3D_ZSTENCILCNTL |= RADEON_Z_HIERARCHY_ENABLE;
                }
 
-               BEGIN_RING( 13 );
+               BEGIN_RING(13);
                RADEON_WAIT_UNTIL_2D_IDLE();
 
-               OUT_RING( CP_PACKET0( RADEON_PP_CNTL, 1 ) );
-               OUT_RING( 0x00000000 );
-               OUT_RING( rb3d_cntl );
-               
-               OUT_RING_REG( RADEON_RB3D_ZSTENCILCNTL, tempRB3D_ZSTENCILCNTL );
-               OUT_RING_REG( RADEON_RB3D_STENCILREFMASK,
-                             rb3d_stencilrefmask );
-               OUT_RING_REG( RADEON_RB3D_PLANEMASK,
-                             0x00000000 );
-               OUT_RING_REG( RADEON_SE_CNTL,
-                             depth_clear->se_cntl );
+               OUT_RING(CP_PACKET0(RADEON_PP_CNTL, 1));
+               OUT_RING(0x00000000);
+               OUT_RING(rb3d_cntl);
+
+               OUT_RING_REG(RADEON_RB3D_ZSTENCILCNTL, tempRB3D_ZSTENCILCNTL);
+               OUT_RING_REG(RADEON_RB3D_STENCILREFMASK, rb3d_stencilrefmask);
+               OUT_RING_REG(RADEON_RB3D_PLANEMASK, 0x00000000);
+               OUT_RING_REG(RADEON_SE_CNTL, depth_clear->se_cntl);
                ADVANCE_RING();
 
                /* Make sure we restore the 3D state next time.
                 */
                dev_priv->sarea_priv->ctx_owner = 0;
 
-               for ( i = 0 ; i < nbox ; i++ ) {
-                       
-                       /* Funny that this should be required -- 
+               for (i = 0; i < nbox; i++) {
+
+                       /* Funny that this should be required --
                         *  sets top-left?
                         */
-                       radeon_emit_clip_rect( dev_priv,
-                                              &sarea_priv->boxes[i] );
-
-                       BEGIN_RING( 15 );
-
-                       OUT_RING( CP_PACKET3( RADEON_3D_DRAW_IMMD, 13 ) );
-                       OUT_RING( RADEON_VTX_Z_PRESENT |
-                                 RADEON_VTX_PKCOLOR_PRESENT);
-                       OUT_RING( (RADEON_PRIM_TYPE_RECT_LIST |
-                                  RADEON_PRIM_WALK_RING |
-                                  RADEON_MAOS_ENABLE |
-                                  RADEON_VTX_FMT_RADEON_MODE |
-                                  (3 << RADEON_NUM_VERTICES_SHIFT)) );
-
-
-                       OUT_RING( depth_boxes[i].ui[CLEAR_X1] );
-                       OUT_RING( depth_boxes[i].ui[CLEAR_Y1] );
-                       OUT_RING( depth_boxes[i].ui[CLEAR_DEPTH] );
-                       OUT_RING( 0x0 );
-
-                       OUT_RING( depth_boxes[i].ui[CLEAR_X1] );
-                       OUT_RING( depth_boxes[i].ui[CLEAR_Y2] );
-                       OUT_RING( depth_boxes[i].ui[CLEAR_DEPTH] );
-                       OUT_RING( 0x0 );
-
-                       OUT_RING( depth_boxes[i].ui[CLEAR_X2] );
-                       OUT_RING( depth_boxes[i].ui[CLEAR_Y2] );
-                       OUT_RING( depth_boxes[i].ui[CLEAR_DEPTH] );
-                       OUT_RING( 0x0 );
+                       radeon_emit_clip_rect(dev_priv, &sarea_priv->boxes[i]);
+
+                       BEGIN_RING(15);
+
+                       OUT_RING(CP_PACKET3(RADEON_3D_DRAW_IMMD, 13));
+                       OUT_RING(RADEON_VTX_Z_PRESENT |
+                                RADEON_VTX_PKCOLOR_PRESENT);
+                       OUT_RING((RADEON_PRIM_TYPE_RECT_LIST |
+                                 RADEON_PRIM_WALK_RING |
+                                 RADEON_MAOS_ENABLE |
+                                 RADEON_VTX_FMT_RADEON_MODE |
+                                 (3 << RADEON_NUM_VERTICES_SHIFT)));
+
+                       OUT_RING(depth_boxes[i].ui[CLEAR_X1]);
+                       OUT_RING(depth_boxes[i].ui[CLEAR_Y1]);
+                       OUT_RING(depth_boxes[i].ui[CLEAR_DEPTH]);
+                       OUT_RING(0x0);
+
+                       OUT_RING(depth_boxes[i].ui[CLEAR_X1]);
+                       OUT_RING(depth_boxes[i].ui[CLEAR_Y2]);
+                       OUT_RING(depth_boxes[i].ui[CLEAR_DEPTH]);
+                       OUT_RING(0x0);
+
+                       OUT_RING(depth_boxes[i].ui[CLEAR_X2]);
+                       OUT_RING(depth_boxes[i].ui[CLEAR_Y2]);
+                       OUT_RING(depth_boxes[i].ui[CLEAR_DEPTH]);
+                       OUT_RING(0x0);
 
                        ADVANCE_RING();
                }
@@ -1153,15 +1221,15 @@ static void radeon_cp_dispatch_clear( drm_device_t *dev,
         */
        dev_priv->sarea_priv->last_clear++;
 
-       BEGIN_RING( 4 );
+       BEGIN_RING(4);
 
-       RADEON_CLEAR_AGE( dev_priv->sarea_priv->last_clear );
+       RADEON_CLEAR_AGE(dev_priv->sarea_priv->last_clear);
        RADEON_WAIT_UNTIL_IDLE();
 
        ADVANCE_RING();
 }
 
-static void radeon_cp_dispatch_swap( drm_device_t *dev )
+static void radeon_cp_dispatch_swap(drm_device_t * dev)
 {
        drm_radeon_private_t *dev_priv = dev->dev_private;
        drm_radeon_sarea_t *sarea_priv = dev_priv->sarea_priv;
@@ -1169,59 +1237,55 @@ static void radeon_cp_dispatch_swap( drm_device_t *dev )
        drm_clip_rect_t *pbox = sarea_priv->boxes;
        int i;
        RING_LOCALS;
-       DRM_DEBUG( "\n" );
+       DRM_DEBUG("\n");
 
        /* Do some trivial performance monitoring...
         */
        if (dev_priv->do_boxes)
-               radeon_cp_performance_boxes( dev_priv );
-
+               radeon_cp_performance_boxes(dev_priv);
 
        /* Wait for the 3D stream to idle before dispatching the bitblt.
         * This will prevent data corruption between the two streams.
         */
-       BEGIN_RING( 2 );
+       BEGIN_RING(2);
 
        RADEON_WAIT_UNTIL_3D_IDLE();
 
        ADVANCE_RING();
 
-       for ( i = 0 ; i < nbox ; i++ ) {
+       for (i = 0; i < nbox; i++) {
                int x = pbox[i].x1;
                int y = pbox[i].y1;
                int w = pbox[i].x2 - x;
                int h = pbox[i].y2 - y;
 
-               DRM_DEBUG( "dispatch swap %d,%d-%d,%d\n",
-                          x, y, w, h );
-
-               BEGIN_RING( 7 );
-
-               OUT_RING( CP_PACKET3( RADEON_CNTL_BITBLT_MULTI, 5 ) );
-               OUT_RING( RADEON_GMC_SRC_PITCH_OFFSET_CNTL |
-                         RADEON_GMC_DST_PITCH_OFFSET_CNTL |
-                         RADEON_GMC_BRUSH_NONE |
-                         (dev_priv->color_fmt << 8) |
-                         RADEON_GMC_SRC_DATATYPE_COLOR |
-                         RADEON_ROP3_S |
-                         RADEON_DP_SRC_SOURCE_MEMORY |
-                         RADEON_GMC_CLR_CMP_CNTL_DIS |
-                         RADEON_GMC_WR_MSK_DIS );
-               
+               DRM_DEBUG("dispatch swap %d,%d-%d,%d\n", x, y, w, h);
+
+               BEGIN_RING(7);
+
+               OUT_RING(CP_PACKET3(RADEON_CNTL_BITBLT_MULTI, 5));
+               OUT_RING(RADEON_GMC_SRC_PITCH_OFFSET_CNTL |
+                        RADEON_GMC_DST_PITCH_OFFSET_CNTL |
+                        RADEON_GMC_BRUSH_NONE |
+                        (dev_priv->color_fmt << 8) |
+                        RADEON_GMC_SRC_DATATYPE_COLOR |
+                        RADEON_ROP3_S |
+                        RADEON_DP_SRC_SOURCE_MEMORY |
+                        RADEON_GMC_CLR_CMP_CNTL_DIS | RADEON_GMC_WR_MSK_DIS);
+
                /* Make this work even if front & back are flipped:
                 */
                if (dev_priv->current_page == 0) {
-                       OUT_RING( dev_priv->back_pitch_offset );
-                       OUT_RING( dev_priv->front_pitch_offset );
-               } 
-               else {
-                       OUT_RING( dev_priv->front_pitch_offset );
-                       OUT_RING( dev_priv->back_pitch_offset );
+                       OUT_RING(dev_priv->back_pitch_offset);
+                       OUT_RING(dev_priv->front_pitch_offset);
+               } else {
+                       OUT_RING(dev_priv->front_pitch_offset);
+                       OUT_RING(dev_priv->back_pitch_offset);
                }
 
-               OUT_RING( (x << 16) | y );
-               OUT_RING( (x << 16) | y );
-               OUT_RING( (w << 16) | h );
+               OUT_RING((x << 16) | y);
+               OUT_RING((x << 16) | y);
+               OUT_RING((w << 16) | h);
 
                ADVANCE_RING();
        }
@@ -1232,44 +1296,43 @@ static void radeon_cp_dispatch_swap( drm_device_t *dev )
         */
        dev_priv->sarea_priv->last_frame++;
 
-       BEGIN_RING( 4 );
+       BEGIN_RING(4);
 
-       RADEON_FRAME_AGE( dev_priv->sarea_priv->last_frame );
+       RADEON_FRAME_AGE(dev_priv->sarea_priv->last_frame);
        RADEON_WAIT_UNTIL_2D_IDLE();
 
        ADVANCE_RING();
 }
 
-static void radeon_cp_dispatch_flip( drm_device_t *dev )
+static void radeon_cp_dispatch_flip(drm_device_t * dev)
 {
        drm_radeon_private_t *dev_priv = dev->dev_private;
-       drm_sarea_t *sarea = (drm_sarea_t *)dev_priv->sarea->handle;
+       drm_sarea_t *sarea = (drm_sarea_t *) dev_priv->sarea->handle;
        int offset = (dev_priv->current_page == 1)
-                  ? dev_priv->front_offset : dev_priv->back_offset;
+           ? dev_priv->front_offset : dev_priv->back_offset;
        RING_LOCALS;
-       DRM_DEBUG( "%s: page=%d pfCurrentPage=%d\n", 
-               __FUNCTION__, 
-               dev_priv->current_page,
-               dev_priv->sarea_priv->pfCurrentPage);
+       DRM_DEBUG("%s: page=%d pfCurrentPage=%d\n",
+                 __FUNCTION__,
+                 dev_priv->current_page, dev_priv->sarea_priv->pfCurrentPage);
 
        /* Do some trivial performance monitoring...
         */
        if (dev_priv->do_boxes) {
                dev_priv->stats.boxes |= RADEON_BOX_FLIP;
-               radeon_cp_performance_boxes( dev_priv );
+               radeon_cp_performance_boxes(dev_priv);
        }
 
        /* Update the frame offsets for both CRTCs
         */
-       BEGIN_RING( 6 );
+       BEGIN_RING(6);
 
        RADEON_WAIT_UNTIL_3D_IDLE();
-       OUT_RING_REG( RADEON_CRTC_OFFSET, ( ( sarea->frame.y * dev_priv->front_pitch
-                                             + sarea->frame.x 
-                                             * ( dev_priv->color_fmt - 2 ) ) & ~7 )
-                                         + offset );
-       OUT_RING_REG( RADEON_CRTC2_OFFSET, dev_priv->sarea_priv->crtc2_base
-                                          + offset );
+       OUT_RING_REG(RADEON_CRTC_OFFSET,
+                    ((sarea->frame.y * dev_priv->front_pitch +
+                      sarea->frame.x * (dev_priv->color_fmt - 2)) & ~7)
+                    + offset);
+       OUT_RING_REG(RADEON_CRTC2_OFFSET, dev_priv->sarea_priv->crtc2_base
+                    + offset);
 
        ADVANCE_RING();
 
@@ -1279,16 +1342,16 @@ static void radeon_cp_dispatch_flip( drm_device_t *dev )
         */
        dev_priv->sarea_priv->last_frame++;
        dev_priv->sarea_priv->pfCurrentPage = dev_priv->current_page =
-                                             1 - dev_priv->current_page;
+           1 - dev_priv->current_page;
 
-       BEGIN_RING( 2 );
+       BEGIN_RING(2);
 
-       RADEON_FRAME_AGE( dev_priv->sarea_priv->last_frame );
+       RADEON_FRAME_AGE(dev_priv->sarea_priv->last_frame);
 
        ADVANCE_RING();
 }
 
-static int bad_prim_vertex_nr( int primitive, int nr )
+static int bad_prim_vertex_nr(int primitive, int nr)
 {
        switch (primitive & RADEON_PRIM_TYPE_MASK) {
        case RADEON_PRIM_TYPE_NONE:
@@ -1308,24 +1371,21 @@ static int bad_prim_vertex_nr( int primitive, int nr )
                return nr < 3;
        default:
                return 1;
-       }       
+       }
 }
 
-
-
 typedef struct {
        unsigned int start;
        unsigned int finish;
        unsigned int prim;
        unsigned int numverts;
-       unsigned int offset;   
-        unsigned int vc_format;
+       unsigned int offset;
+       unsigned int vc_format;
 } drm_radeon_tcl_prim_t;
 
-static void radeon_cp_dispatch_vertex( drm_device_t *dev,
-                                      drm_buf_t *buf,
-                                      drm_radeon_tcl_prim_t *prim )
-
+static void radeon_cp_dispatch_vertex(drm_device_t * dev,
+                                     drm_buf_t * buf,
+                                     drm_radeon_tcl_prim_t * prim)
 {
        drm_radeon_private_t *dev_priv = dev->dev_private;
        drm_radeon_sarea_t *sarea_priv = dev_priv->sarea_priv;
@@ -1337,45 +1397,39 @@ static void radeon_cp_dispatch_vertex( drm_device_t *dev,
 
        DRM_DEBUG("hwprim 0x%x vfmt 0x%x %d..%d %d verts\n",
                  prim->prim,
-                 prim->vc_format,
-                 prim->start,
-                 prim->finish,
-                 prim->numverts);
+                 prim->vc_format, prim->start, prim->finish, prim->numverts);
 
-       if (bad_prim_vertex_nr( prim->prim, prim->numverts )) {
-               DRM_ERROR( "bad prim %x numverts %d\n", 
-                          prim->prim, prim->numverts );
+       if (bad_prim_vertex_nr(prim->prim, prim->numverts)) {
+               DRM_ERROR("bad prim %x numverts %d\n",
+                         prim->prim, prim->numverts);
                return;
        }
 
        do {
                /* Emit the next cliprect */
-               if ( i < nbox ) {
-                       radeon_emit_clip_rect( dev_priv, 
-                                              &sarea_priv->boxes[i] );
+               if (i < nbox) {
+                       radeon_emit_clip_rect(dev_priv, &sarea_priv->boxes[i]);
                }
 
                /* Emit the vertex buffer rendering commands */
-               BEGIN_RING( 5 );
+               BEGIN_RING(5);
 
-               OUT_RING( CP_PACKET3( RADEON_3D_RNDR_GEN_INDX_PRIM, 3 ) );
-               OUT_RING( offset );
-               OUT_RING( numverts );
-               OUT_RING( prim->vc_format );
-               OUT_RING( prim->prim | RADEON_PRIM_WALK_LIST |
-                         RADEON_COLOR_ORDER_RGBA |
-                         RADEON_VTX_FMT_RADEON_MODE |
-                         (numverts << RADEON_NUM_VERTICES_SHIFT) );
+               OUT_RING(CP_PACKET3(RADEON_3D_RNDR_GEN_INDX_PRIM, 3));
+               OUT_RING(offset);
+               OUT_RING(numverts);
+               OUT_RING(prim->vc_format);
+               OUT_RING(prim->prim | RADEON_PRIM_WALK_LIST |
+                        RADEON_COLOR_ORDER_RGBA |
+                        RADEON_VTX_FMT_RADEON_MODE |
+                        (numverts << RADEON_NUM_VERTICES_SHIFT));
 
                ADVANCE_RING();
 
                i++;
-       } while ( i < nbox );
+       } while (i < nbox);
 }
 
-
-
-static void radeon_cp_discard_buffer( drm_device_t *dev, drm_buf_t *buf )
+static void radeon_cp_discard_buffer(drm_device_t * dev, drm_buf_t * buf)
 {
        drm_radeon_private_t *dev_priv = dev->dev_private;
        drm_radeon_buf_priv_t *buf_priv = buf->dev_private;
@@ -1384,24 +1438,22 @@ static void radeon_cp_discard_buffer( drm_device_t *dev, drm_buf_t *buf )
        buf_priv->age = ++dev_priv->sarea_priv->last_dispatch;
 
        /* Emit the vertex buffer age */
-       BEGIN_RING( 2 );
-       RADEON_DISPATCH_AGE( buf_priv->age );
+       BEGIN_RING(2);
+       RADEON_DISPATCH_AGE(buf_priv->age);
        ADVANCE_RING();
 
        buf->pending = 1;
        buf->used = 0;
 }
 
-static void radeon_cp_dispatch_indirect( drm_device_t *dev,
-                                        drm_buf_t *buf,
-                                        int start, int end )
+static void radeon_cp_dispatch_indirect(drm_device_t * dev,
+                                       drm_buf_t * buf, int start, int end)
 {
        drm_radeon_private_t *dev_priv = dev->dev_private;
        RING_LOCALS;
-       DRM_DEBUG( "indirect: buf=%d s=0x%x e=0x%x\n",
-                  buf->idx, start, end );
+       DRM_DEBUG("indirect: buf=%d s=0x%x e=0x%x\n", buf->idx, start, end);
 
-       if ( start != end ) {
+       if (start != end) {
                int offset = (dev_priv->gart_buffers_offset
                              + buf->offset + start);
                int dwords = (end - start + 3) / sizeof(u32);
@@ -1410,28 +1462,27 @@ static void radeon_cp_dispatch_indirect( drm_device_t *dev,
                 * dwords, so if we've been given an odd number we must
                 * pad the data with a Type-2 CP packet.
                 */
-               if ( dwords & 1 ) {
+               if (dwords & 1) {
                        u32 *data = (u32 *)
-                               ((char *)dev->agp_buffer_map->handle
-                                + buf->offset + start);
+                           ((char *)dev->agp_buffer_map->handle
+                            + buf->offset + start);
                        data[dwords++] = RADEON_CP_PACKET2;
                }
 
                /* Fire off the indirect buffer */
-               BEGIN_RING( 3 );
+               BEGIN_RING(3);
 
-               OUT_RING( CP_PACKET0( RADEON_CP_IB_BASE, 1 ) );
-               OUT_RING( offset );
-               OUT_RING( dwords );
+               OUT_RING(CP_PACKET0(RADEON_CP_IB_BASE, 1));
+               OUT_RING(offset);
+               OUT_RING(dwords);
 
                ADVANCE_RING();
        }
 }
 
-
-static void radeon_cp_dispatch_indices( drm_device_t *dev,
-                                       drm_buf_t *elt_buf,
-                                       drm_radeon_tcl_prim_t *prim )
+static void radeon_cp_dispatch_indices(drm_device_t * dev,
+                                      drm_buf_t * elt_buf,
+                                      drm_radeon_tcl_prim_t * prim)
 {
        drm_radeon_private_t *dev_priv = dev->dev_private;
        drm_radeon_sarea_t *sarea_priv = dev_priv->sarea_priv;
@@ -1446,30 +1497,24 @@ static void radeon_cp_dispatch_indices( drm_device_t *dev,
        DRM_DEBUG("hwprim 0x%x vfmt 0x%x %d..%d offset: %x nr %d\n",
                  prim->prim,
                  prim->vc_format,
-                 prim->start,
-                 prim->finish,
-                 prim->offset,
-                 prim->numverts);
-
-       if (bad_prim_vertex_nr( prim->prim, count )) {
-               DRM_ERROR( "bad prim %x count %d\n", 
-                          prim->prim, count );
+                 prim->start, prim->finish, prim->offset, prim->numverts);
+
+       if (bad_prim_vertex_nr(prim->prim, count)) {
+               DRM_ERROR("bad prim %x count %d\n", prim->prim, count);
                return;
        }
 
-
-       if ( start >= prim->finish ||
-            (prim->start & 0x7) ) {
-               DRM_ERROR( "buffer prim %d\n", prim->prim );
+       if (start >= prim->finish || (prim->start & 0x7)) {
+               DRM_ERROR("buffer prim %d\n", prim->prim);
                return;
        }
 
        dwords = (prim->finish - prim->start + 3) / sizeof(u32);
 
-       data = (u32 *)((char *)dev->agp_buffer_map->handle +
-                      elt_buf->offset + prim->start);
+       data = (u32 *) ((char *)dev->agp_buffer_map->handle +
+                       elt_buf->offset + prim->start);
 
-       data[0] = CP_PACKET3( RADEON_3D_RNDR_GEN_INDX_PRIM, dwords-2 );
+       data[0] = CP_PACKET3(RADEON_3D_RNDR_GEN_INDX_PRIM, dwords - 2);
        data[1] = offset;
        data[2] = prim->numverts;
        data[3] = prim->vc_format;
@@ -1477,28 +1522,26 @@ static void radeon_cp_dispatch_indices( drm_device_t *dev,
                   RADEON_PRIM_WALK_IND |
                   RADEON_COLOR_ORDER_RGBA |
                   RADEON_VTX_FMT_RADEON_MODE |
-                  (count << RADEON_NUM_VERTICES_SHIFT) );
+                  (count << RADEON_NUM_VERTICES_SHIFT));
 
        do {
-               if ( i < nbox ) 
-                       radeon_emit_clip_rect( dev_priv, 
-                                              &sarea_priv->boxes[i] );
+               if (i < nbox)
+                       radeon_emit_clip_rect(dev_priv, &sarea_priv->boxes[i]);
 
-               radeon_cp_dispatch_indirect( dev, elt_buf,
-                                            prim->start,
-                                            prim->finish );
+               radeon_cp_dispatch_indirect(dev, elt_buf,
+                                           prim->start, prim->finish);
 
                i++;
-       } while ( i < nbox );
+       } while (i < nbox);
 
 }
 
-#define RADEON_MAX_TEXTURE_SIZE (RADEON_BUFFER_SIZE - 8 * sizeof(u32))
+#define RADEON_MAX_TEXTURE_SIZE RADEON_BUFFER_SIZE
 
-static int radeon_cp_dispatch_texture( DRMFILE filp,
-                                      drm_device_t *dev,
-                                      drm_radeon_texture_t *tex,
-                                      drm_radeon_tex_image_t *image )
+static int radeon_cp_dispatch_texture(DRMFILE filp,
+                                     drm_device_t * dev,
+                                     drm_radeon_texture_t * tex,
+                                     drm_radeon_tex_image_t * image)
 {
        drm_radeon_private_t *dev_priv = dev->dev_private;
        drm_file_t *filp_priv;
@@ -1506,17 +1549,18 @@ static int radeon_cp_dispatch_texture( DRMFILE filp,
        u32 format;
        u32 *buffer;
        const u8 __user *data;
-       int size, dwords, tex_width, blit_width;
+       int size, dwords, tex_width, blit_width, spitch;
        u32 height;
        int i;
        u32 texpitch, microtile;
+       u32 offset;
        RING_LOCALS;
 
-       DRM_GET_PRIV_WITH_RETURN( filp_priv, filp );
+       DRM_GET_PRIV_WITH_RETURN(filp_priv, filp);
 
-       if ( radeon_check_and_fixup_offset( dev_priv, filp_priv, &tex->offset ) ) {
-               DRM_ERROR( "Invalid destination offset\n" );
-               return DRM_ERR( EINVAL );
+       if (radeon_check_and_fixup_offset(dev_priv, filp_priv, &tex->offset)) {
+               DRM_ERROR("Invalid destination offset\n");
+               return DRM_ERR(EINVAL);
        }
 
        dev_priv->stats.boxes |= RADEON_BOX_TEXTURE_LOAD;
@@ -1525,27 +1569,16 @@ static int radeon_cp_dispatch_texture( DRMFILE filp,
         * up with the texture data from the host data blit, otherwise
         * part of the texture image may be corrupted.
         */
-       BEGIN_RING( 4 );
+       BEGIN_RING(4);
        RADEON_FLUSH_CACHE();
        RADEON_WAIT_UNTIL_IDLE();
        ADVANCE_RING();
 
-#ifdef __BIG_ENDIAN
-       /* The Mesa texture functions provide the data in little endian as the
-        * chip wants it, but we need to compensate for the fact that the CP
-        * ring gets byte-swapped
-        */
-       BEGIN_RING( 2 );
-       OUT_RING_REG( RADEON_RBBM_GUICNTL, RADEON_HOST_DATA_SWAP_32BIT );
-       ADVANCE_RING();
-#endif
-
-
        /* The compiler won't optimize away a division by a variable,
         * even if the only legal values are powers of two.  Thus, we'll
         * use a shift instead.
         */
-       switch ( tex->format ) {
+       switch (tex->format) {
        case RADEON_TXFORMAT_ARGB8888:
        case RADEON_TXFORMAT_RGBA8888:
                format = RADEON_COLOR_FORMAT_ARGB8888;
@@ -1569,9 +1602,13 @@ static int radeon_cp_dispatch_texture( DRMFILE filp,
                blit_width = image->width * 1;
                break;
        default:
-               DRM_ERROR( "invalid texture format %d\n", tex->format );
+               DRM_ERROR("invalid texture format %d\n", tex->format);
                return DRM_ERR(EINVAL);
        }
+       spitch = blit_width >> 6;
+       if (spitch == 0 && image->height > 1)
+               return DRM_ERR(EINVAL);
+
        texpitch = tex->pitch;
        if ((texpitch << 22) & RADEON_DST_TILE_MICRO) {
                microtile = 1;
@@ -1580,69 +1617,58 @@ static int radeon_cp_dispatch_texture( DRMFILE filp,
                        /* we got tiled coordinates, untile them */
                        image->x *= 2;
                }
-       }
-       else microtile = 0;
+       } else
+               microtile = 0;
 
-       DRM_DEBUG("tex=%dx%d blit=%d\n", tex_width, tex->height, blit_width );
+       DRM_DEBUG("tex=%dx%d blit=%d\n", tex_width, tex->height, blit_width);
 
        do {
-               DRM_DEBUG( "tex: ofs=0x%x p=%d f=%d x=%hd y=%hd w=%hd h=%hd\n",
-                          tex->offset >> 10, tex->pitch, tex->format,
-                          image->x, image->y, image->width, image->height );
+               DRM_DEBUG("tex: ofs=0x%x p=%d f=%d x=%hd y=%hd w=%hd h=%hd\n",
+                         tex->offset >> 10, tex->pitch, tex->format,
+                         image->x, image->y, image->width, image->height);
 
                /* Make a copy of some parameters in case we have to
                 * update them for a multi-pass texture blit.
                 */
                height = image->height;
                data = (const u8 __user *)image->data;
-               
+
                size = height * blit_width;
 
-               if ( size > RADEON_MAX_TEXTURE_SIZE ) {
+               if (size > RADEON_MAX_TEXTURE_SIZE) {
                        height = RADEON_MAX_TEXTURE_SIZE / blit_width;
                        size = height * blit_width;
-               } else if ( size < 4 && size > 0 ) {
+               } else if (size < 4 && size > 0) {
                        size = 4;
-               } else if ( size == 0 ) {
+               } else if (size == 0) {
                        return 0;
                }
 
-               buf = radeon_freelist_get( dev );
-               if ( 0 && !buf ) {
-                       radeon_do_cp_idle( dev_priv );
-                       buf = radeon_freelist_get( dev );
+               buf = radeon_freelist_get(dev);
+               if (0 && !buf) {
+                       radeon_do_cp_idle(dev_priv);
+                       buf = radeon_freelist_get(dev);
                }
-               if ( !buf ) {
+               if (!buf) {
                        DRM_DEBUG("radeon_cp_dispatch_texture: EAGAIN\n");
-                       if (DRM_COPY_TO_USER( tex->image, image, sizeof(*image) ))
+                       if (DRM_COPY_TO_USER(tex->image, image, sizeof(*image)))
                                return DRM_ERR(EFAULT);
                        return DRM_ERR(EAGAIN);
                }
 
-
                /* Dispatch the indirect buffer.
                 */
-               buffer = (u32*)((char*)dev->agp_buffer_map->handle + buf->offset);
+               buffer =
+                   (u32 *) ((char *)dev->agp_buffer_map->handle + buf->offset);
                dwords = size / 4;
-               buffer[0] = CP_PACKET3( RADEON_CNTL_HOSTDATA_BLT, dwords + 6 );
-               buffer[1] = (RADEON_GMC_DST_PITCH_OFFSET_CNTL |
-                            RADEON_GMC_BRUSH_NONE |
-                            (format << 8) |
-                            RADEON_GMC_SRC_DATATYPE_COLOR |
-                            RADEON_ROP3_S |
-                            RADEON_DP_SRC_SOURCE_HOST_DATA |
-                            RADEON_GMC_CLR_CMP_CNTL_DIS |
-                            RADEON_GMC_WR_MSK_DIS);
-               
-               buffer[2] = (texpitch << 22) | (tex->offset >> 10);
-               buffer[3] = 0xffffffff;
-               buffer[4] = 0xffffffff;
-               buffer[5] = (image->y << 16) | image->x;
-               buffer[6] = (height << 16) | image->width;
-               buffer[7] = dwords;
-               buffer += 8;
-
-               
+
+#define RADEON_COPY_MT(_buf, _data, _width) \
+       do { \
+               if (DRM_COPY_FROM_USER(_buf, _data, (_width))) {\
+                       DRM_ERROR("EFAULT on pad, %d bytes\n", (_width)); \
+                       return DRM_ERR(EFAULT); \
+               } \
+       } while(0)
 
                if (microtile) {
                        /* texture micro tiling in use, minimum texture width is thus 16 bytes.
@@ -1655,38 +1681,19 @@ static int radeon_cp_dispatch_texture( DRMFILE filp,
                           from user space. */
                        if (tex->height == 1) {
                                if (tex_width >= 64 || tex_width <= 16) {
-                                       if (DRM_COPY_FROM_USER(buffer, data,
-                                                              tex_width * sizeof(u32))) {
-                                               DRM_ERROR("EFAULT on pad, %d bytes\n",
-                                                         tex_width);
-                                               return DRM_ERR(EFAULT);
-                                       }
+                                       RADEON_COPY_MT(buffer, data,
+                                               (int)(tex_width * sizeof(u32)));
                                } else if (tex_width == 32) {
-                                       if (DRM_COPY_FROM_USER(buffer, data, 16)) {
-                                               DRM_ERROR("EFAULT on pad, %d bytes\n",
-                                                         tex_width);
-                                               return DRM_ERR(EFAULT);
-                                       }
-                                       if (DRM_COPY_FROM_USER(buffer + 8, data + 16, 16)) {
-                                               DRM_ERROR("EFAULT on pad, %d bytes\n",
-                                                         tex_width);
-                                               return DRM_ERR(EFAULT);
-                                       }
+                                       RADEON_COPY_MT(buffer, data, 16);
+                                       RADEON_COPY_MT(buffer + 8,
+                                                      data + 16, 16);
                                }
                        } else if (tex_width >= 64 || tex_width == 16) {
-                               if (DRM_COPY_FROM_USER(buffer, data,
-                                                      dwords * sizeof(u32))) {
-                                       DRM_ERROR("EFAULT on data, %d dwords\n",
-                                                 dwords);
-                                       return DRM_ERR(EFAULT);
-                               }
+                               RADEON_COPY_MT(buffer, data,
+                                              (int)(dwords * sizeof(u32)));
                        } else if (tex_width < 16) {
                                for (i = 0; i < tex->height; i++) {
-                                       if (DRM_COPY_FROM_USER(buffer, data, tex_width)) {
-                                               DRM_ERROR("EFAULT on pad, %d bytes\n",
-                                                         tex_width);
-                                               return DRM_ERR(EFAULT);
-                                       }
+                                       RADEON_COPY_MT(buffer, data, tex_width);
                                        buffer += 4;
                                        data += tex_width;
                                }
@@ -1694,65 +1701,60 @@ static int radeon_cp_dispatch_texture( DRMFILE filp,
                                /* TODO: make sure this works when not fitting in one buffer
                                   (i.e. 32bytes x 2048...) */
                                for (i = 0; i < tex->height; i += 2) {
-                                       if (DRM_COPY_FROM_USER(buffer, data, 16)) {
-                                               DRM_ERROR("EFAULT on pad, %d bytes\n",
-                                                         tex_width);
-                                               return DRM_ERR(EFAULT);
-                                       }
+                                       RADEON_COPY_MT(buffer, data, 16);
                                        data += 16;
-                                       if (DRM_COPY_FROM_USER(buffer + 8, data, 16)) {
-                                               DRM_ERROR("EFAULT on pad, %d bytes\n",
-                                                         tex_width);
-                                               return DRM_ERR(EFAULT);
-                                       }
+                                       RADEON_COPY_MT(buffer + 8, data, 16);
                                        data += 16;
-                                       if (DRM_COPY_FROM_USER(buffer + 4, data, 16)) {
-                                               DRM_ERROR("EFAULT on pad, %d bytes\n",
-                                                         tex_width);
-                                               return DRM_ERR(EFAULT);
-                                       }
+                                       RADEON_COPY_MT(buffer + 4, data, 16);
                                        data += 16;
-                                       if (DRM_COPY_FROM_USER(buffer + 12, data, 16)) {
-                                               DRM_ERROR("EFAULT on pad, %d bytes\n",
-                                                         tex_width);
-                                               return DRM_ERR(EFAULT);
-                                       }
+                                       RADEON_COPY_MT(buffer + 12, data, 16);
                                        data += 16;
                                        buffer += 16;
                                }
                        }
-               }
-               else {
+               } else {
                        if (tex_width >= 32) {
                                /* Texture image width is larger than the minimum, so we
                                 * can upload it directly.
                                 */
-                               if (DRM_COPY_FROM_USER(buffer, data,
-                                                      dwords * sizeof(u32))) {
-                                       DRM_ERROR("EFAULT on data, %d dwords\n",
-                                                 dwords);
-                                       return DRM_ERR(EFAULT);
-                               }
+                               RADEON_COPY_MT(buffer, data,
+                                              (int)(dwords * sizeof(u32)));
                        } else {
                                /* Texture image width is less than the minimum, so we
                                 * need to pad out each image scanline to the minimum
                                 * width.
                                 */
-                               for (i = 0 ; i < tex->height ; i++) {
-                                       if (DRM_COPY_FROM_USER(buffer, data, tex_width )) {
-                                               DRM_ERROR("EFAULT on pad, %d bytes\n", tex_width);
-                                               return DRM_ERR(EFAULT);
-                                       }
+                               for (i = 0; i < tex->height; i++) {
+                                       RADEON_COPY_MT(buffer, data, tex_width);
                                        buffer += 8;
                                        data += tex_width;
                                }
                        }
                }
 
+#undef RADEON_COPY_MT
                buf->filp = filp;
-               buf->used = (dwords + 8) * sizeof(u32);
-               radeon_cp_dispatch_indirect( dev, buf, 0, buf->used );
-               radeon_cp_discard_buffer( dev, buf );
+               buf->used = size;
+               offset = dev_priv->gart_buffers_offset + buf->offset;
+               BEGIN_RING(9);
+               OUT_RING(CP_PACKET3(RADEON_CNTL_BITBLT_MULTI, 5));
+               OUT_RING(RADEON_GMC_SRC_PITCH_OFFSET_CNTL |
+                        RADEON_GMC_DST_PITCH_OFFSET_CNTL |
+                        RADEON_GMC_BRUSH_NONE |
+                        (format << 8) |
+                        RADEON_GMC_SRC_DATATYPE_COLOR |
+                        RADEON_ROP3_S |
+                        RADEON_DP_SRC_SOURCE_MEMORY |
+                        RADEON_GMC_CLR_CMP_CNTL_DIS | RADEON_GMC_WR_MSK_DIS);
+               OUT_RING((spitch << 22) | (offset >> 10));
+               OUT_RING((texpitch << 22) | (tex->offset >> 10));
+               OUT_RING(0);
+               OUT_RING((image->x << 16) | image->y);
+               OUT_RING((image->width << 16) | height);
+               RADEON_WAIT_UNTIL_2D_IDLE();
+               ADVANCE_RING();
+
+               radeon_cp_discard_buffer(dev, buf);
 
                /* Update the input parameters for next time */
                image->y += height;
@@ -1764,62 +1766,62 @@ static int radeon_cp_dispatch_texture( DRMFILE filp,
         * the texture data is written out to memory before rendering
         * continues.
         */
-       BEGIN_RING( 4 );
+       BEGIN_RING(4);
        RADEON_FLUSH_CACHE();
        RADEON_WAIT_UNTIL_2D_IDLE();
        ADVANCE_RING();
        return 0;
 }
 
-
-static void radeon_cp_dispatch_stipple( drm_device_t *dev, u32 *stipple )
+static void radeon_cp_dispatch_stipple(drm_device_t * dev, u32 * stipple)
 {
        drm_radeon_private_t *dev_priv = dev->dev_private;
        int i;
        RING_LOCALS;
-       DRM_DEBUG( "\n" );
+       DRM_DEBUG("\n");
 
-       BEGIN_RING( 35 );
+       BEGIN_RING(35);
 
-       OUT_RING( CP_PACKET0( RADEON_RE_STIPPLE_ADDR, 0 ) );
-       OUT_RING( 0x00000000 );
+       OUT_RING(CP_PACKET0(RADEON_RE_STIPPLE_ADDR, 0));
+       OUT_RING(0x00000000);
 
-       OUT_RING( CP_PACKET0_TABLE( RADEON_RE_STIPPLE_DATA, 31 ) );
-       for ( i = 0 ; i < 32 ; i++ ) {
-               OUT_RING( stipple[i] );
+       OUT_RING(CP_PACKET0_TABLE(RADEON_RE_STIPPLE_DATA, 31));
+       for (i = 0; i < 32; i++) {
+               OUT_RING(stipple[i]);
        }
 
        ADVANCE_RING();
 }
 
-static void radeon_apply_surface_regs(int surf_index, drm_radeon_private_t *dev_priv)
+static void radeon_apply_surface_regs(int surf_index,
+                                     drm_radeon_private_t *dev_priv)
 {
        if (!dev_priv->mmio)
                return;
 
        radeon_do_cp_idle(dev_priv);
 
-       RADEON_WRITE(RADEON_SURFACE0_INFO + 16*surf_index,
-               dev_priv->surfaces[surf_index].flags);
-       RADEON_WRITE(RADEON_SURFACE0_LOWER_BOUND + 16*surf_index,
-               dev_priv->surfaces[surf_index].lower);
-       RADEON_WRITE(RADEON_SURFACE0_UPPER_BOUND + 16*surf_index,
-               dev_priv->surfaces[surf_index].upper);
+       RADEON_WRITE(RADEON_SURFACE0_INFO + 16 * surf_index,
+                    dev_priv->surfaces[surf_index].flags);
+       RADEON_WRITE(RADEON_SURFACE0_LOWER_BOUND + 16 * surf_index,
+                    dev_priv->surfaces[surf_index].lower);
+       RADEON_WRITE(RADEON_SURFACE0_UPPER_BOUND + 16 * surf_index,
+                    dev_priv->surfaces[surf_index].upper);
 }
 
-
 /* Allocates a virtual surface
- * doesn't always allocate a real surface, will stretch an existing 
+ * doesn't always allocate a real surface, will stretch an existing
  * surface when possible.
  *
  * Note that refcount can be at most 2, since during a free refcount=3
  * might mean we have to allocate a new surface which might not always
  * be available.
- * For example : we allocate three contigous surfaces ABC. If B is 
+ * For example : we allocate three contigous surfaces ABC. If B is
  * freed, we suddenly need two surfaces to store A and C, which might
  * not always be available.
  */
-static int alloc_surface(drm_radeon_surface_alloc_t* new, drm_radeon_private_t *dev_priv, DRMFILE filp)
+static int alloc_surface(drm_radeon_surface_alloc_t *new,
+                        drm_radeon_private_t *dev_priv, DRMFILE filp)
 {
        struct radeon_virt_surface *s;
        int i;
@@ -1831,34 +1833,37 @@ static int alloc_surface(drm_radeon_surface_alloc_t* new, drm_radeon_private_t *
 
        /* sanity check */
        if ((new_lower >= new_upper) || (new->flags == 0) || (new->size == 0) ||
-               ((new_upper & RADEON_SURF_ADDRESS_FIXED_MASK) != RADEON_SURF_ADDRESS_FIXED_MASK) ||
-               ((new_lower & RADEON_SURF_ADDRESS_FIXED_MASK) != 0))
+           ((new_upper & RADEON_SURF_ADDRESS_FIXED_MASK) !=
+            RADEON_SURF_ADDRESS_FIXED_MASK)
+           || ((new_lower & RADEON_SURF_ADDRESS_FIXED_MASK) != 0))
                return -1;
 
        /* make sure there is no overlap with existing surfaces */
        for (i = 0; i < RADEON_MAX_SURFACES; i++) {
                if ((dev_priv->surfaces[i].refcount != 0) &&
-               (( (new_lower >= dev_priv->surfaces[i].lower) &&
-                       (new_lower < dev_priv->surfaces[i].upper) ) ||
-                ( (new_lower < dev_priv->surfaces[i].lower) &&
-                       (new_upper > dev_priv->surfaces[i].lower) )) ){
-               return -1;}
+                   (((new_lower >= dev_priv->surfaces[i].lower) &&
+                     (new_lower < dev_priv->surfaces[i].upper)) ||
+                    ((new_lower < dev_priv->surfaces[i].lower) &&
+                     (new_upper > dev_priv->surfaces[i].lower)))) {
+                       return -1;
+               }
        }
 
        /* find a virtual surface */
-       for (i = 0; i < 2*RADEON_MAX_SURFACES; i++)
+       for (i = 0; i < 2 * RADEON_MAX_SURFACES; i++)
                if (dev_priv->virt_surfaces[i].filp == 0)
                        break;
-       if (i == 2*RADEON_MAX_SURFACES) {
-               return -1;}
+       if (i == 2 * RADEON_MAX_SURFACES) {
+               return -1;
+       }
        virt_surface_index = i;
 
        /* try to reuse an existing surface */
        for (i = 0; i < RADEON_MAX_SURFACES; i++) {
                /* extend before */
                if ((dev_priv->surfaces[i].refcount == 1) &&
-                 (new->flags == dev_priv->surfaces[i].flags) &&
-                 (new_upper + 1 == dev_priv->surfaces[i].lower)) {
+                   (new->flags == dev_priv->surfaces[i].flags) &&
+                   (new_upper + 1 == dev_priv->surfaces[i].lower)) {
                        s = &(dev_priv->virt_surfaces[virt_surface_index]);
                        s->surface_index = i;
                        s->lower = new_lower;
@@ -1873,8 +1878,8 @@ static int alloc_surface(drm_radeon_surface_alloc_t* new, drm_radeon_private_t *
 
                /* extend after */
                if ((dev_priv->surfaces[i].refcount == 1) &&
-                 (new->flags == dev_priv->surfaces[i].flags) &&
-                 (new_lower == dev_priv->surfaces[i].upper + 1)) {
+                   (new->flags == dev_priv->surfaces[i].flags) &&
+                   (new_lower == dev_priv->surfaces[i].upper + 1)) {
                        s = &(dev_priv->virt_surfaces[virt_surface_index]);
                        s->surface_index = i;
                        s->lower = new_lower;
@@ -1910,26 +1915,34 @@ static int alloc_surface(drm_radeon_surface_alloc_t* new, drm_radeon_private_t *
        return -1;
 }
 
-static int free_surface(DRMFILE filp, drm_radeon_private_t *dev_priv, int lower)
+static int free_surface(DRMFILE filp, drm_radeon_private_t * dev_priv,
+                       int lower)
 {
        struct radeon_virt_surface *s;
        int i;
        /* find the virtual surface */
-       for(i = 0; i < 2*RADEON_MAX_SURFACES; i++) {
+       for (i = 0; i < 2 * RADEON_MAX_SURFACES; i++) {
                s = &(dev_priv->virt_surfaces[i]);
                if (s->filp) {
                        if ((lower == s->lower) && (filp == s->filp)) {
-                               if (dev_priv->surfaces[s->surface_index].lower == s->lower)
-                                       dev_priv->surfaces[s->surface_index].lower = s->upper;
+                               if (dev_priv->surfaces[s->surface_index].
+                                   lower == s->lower)
+                                       dev_priv->surfaces[s->surface_index].
+                                           lower = s->upper;
 
-                               if (dev_priv->surfaces[s->surface_index].upper == s->upper)
-                                       dev_priv->surfaces[s->surface_index].upper = s->lower;
+                               if (dev_priv->surfaces[s->surface_index].
+                                   upper == s->upper)
+                                       dev_priv->surfaces[s->surface_index].
+                                           upper = s->lower;
 
                                dev_priv->surfaces[s->surface_index].refcount--;
-                               if (dev_priv->surfaces[s->surface_index].refcount == 0)
-                                       dev_priv->surfaces[s->surface_index].flags = 0;
+                               if (dev_priv->surfaces[s->surface_index].
+                                   refcount == 0)
+                                       dev_priv->surfaces[s->surface_index].
+                                           flags = 0;
                                s->filp = NULL;
-                               radeon_apply_surface_regs(s->surface_index, dev_priv);
+                               radeon_apply_surface_regs(s->surface_index,
+                                                         dev_priv);
                                return 0;
                        }
                }
@@ -1937,13 +1950,14 @@ static int free_surface(DRMFILE filp, drm_radeon_private_t *dev_priv, int lower)
        return 1;
 }
 
-static void radeon_surfaces_release(DRMFILE filp, drm_radeon_private_t *dev_priv)
+static void radeon_surfaces_release(DRMFILE filp,
+                                   drm_radeon_private_t * dev_priv)
 {
        int i;
-       for( i = 0; i < 2*RADEON_MAX_SURFACES; i++)
-       {
+       for (i = 0; i < 2 * RADEON_MAX_SURFACES; i++) {
                if (dev_priv->virt_surfaces[i].filp == filp)
-                       free_surface(filp, dev_priv, dev_priv->virt_surfaces[i].lower);
+                       free_surface(filp, dev_priv,
+                                    dev_priv->virt_surfaces[i].lower);
        }
 }
 
@@ -1956,13 +1970,9 @@ static int radeon_surface_alloc(DRM_IOCTL_ARGS)
        drm_radeon_private_t *dev_priv = dev->dev_private;
        drm_radeon_surface_alloc_t alloc;
 
-       if (!dev_priv) {
-               DRM_ERROR( "%s called with no initialization\n", __FUNCTION__ );
-               return DRM_ERR(EINVAL);
-       }
-
-       DRM_COPY_FROM_USER_IOCTL(alloc, (drm_radeon_surface_alloc_t __user *)data,
-                                 sizeof(alloc));
+       DRM_COPY_FROM_USER_IOCTL(alloc,
+                                (drm_radeon_surface_alloc_t __user *) data,
+                                sizeof(alloc));
 
        if (alloc_surface(&alloc, dev_priv, filp) == -1)
                return DRM_ERR(EINVAL);
@@ -1976,13 +1986,8 @@ static int radeon_surface_free(DRM_IOCTL_ARGS)
        drm_radeon_private_t *dev_priv = dev->dev_private;
        drm_radeon_surface_free_t memfree;
 
-       if (!dev_priv) {
-               DRM_ERROR( "%s called with no initialization\n", __FUNCTION__ );
-               return DRM_ERR(EINVAL);
-       }
-
-       DRM_COPY_FROM_USER_IOCTL(memfree, (drm_radeon_mem_free_t __user *)data,
-                                 sizeof(memfree) );
+       DRM_COPY_FROM_USER_IOCTL(memfree, (drm_radeon_surface_free_t __user *) data,
+                                sizeof(memfree));
 
        if (free_surface(filp, dev_priv, memfree.address))
                return DRM_ERR(EINVAL);
@@ -1990,51 +1995,52 @@ static int radeon_surface_free(DRM_IOCTL_ARGS)
                return 0;
 }
 
-static int radeon_cp_clear( DRM_IOCTL_ARGS )
+static int radeon_cp_clear(DRM_IOCTL_ARGS)
 {
        DRM_DEVICE;
        drm_radeon_private_t *dev_priv = dev->dev_private;
        drm_radeon_sarea_t *sarea_priv = dev_priv->sarea_priv;
        drm_radeon_clear_t clear;
        drm_radeon_clear_rect_t depth_boxes[RADEON_NR_SAREA_CLIPRECTS];
-       DRM_DEBUG( "\n" );
+       DRM_DEBUG("\n");
 
-       LOCK_TEST_WITH_RETURN( dev, filp );
+       LOCK_TEST_WITH_RETURN(dev, filp);
 
-       DRM_COPY_FROM_USER_IOCTL( clear, (drm_radeon_clear_t __user *)data,
-                            sizeof(clear) );
+       DRM_COPY_FROM_USER_IOCTL(clear, (drm_radeon_clear_t __user *) data,
+                                sizeof(clear));
 
-       RING_SPACE_TEST_WITH_RETURN( dev_priv );
+       RING_SPACE_TEST_WITH_RETURN(dev_priv);
 
-       if ( sarea_priv->nbox > RADEON_NR_SAREA_CLIPRECTS )
+       if (sarea_priv->nbox > RADEON_NR_SAREA_CLIPRECTS)
                sarea_priv->nbox = RADEON_NR_SAREA_CLIPRECTS;
 
-       if ( DRM_COPY_FROM_USER( &depth_boxes, clear.depth_boxes,
-                            sarea_priv->nbox * sizeof(depth_boxes[0]) ) )
+       if (DRM_COPY_FROM_USER(&depth_boxes, clear.depth_boxes,
+                              sarea_priv->nbox * sizeof(depth_boxes[0])))
                return DRM_ERR(EFAULT);
 
-       radeon_cp_dispatch_clear( dev, &clear, depth_boxes );
+       radeon_cp_dispatch_clear(dev, &clear, depth_boxes);
 
        COMMIT_RING();
        return 0;
 }
 
-
 /* Not sure why this isn't set all the time:
- */ 
-static int radeon_do_init_pageflip( drm_device_t *dev )
+ */
+static int radeon_do_init_pageflip(drm_device_t * dev)
 {
        drm_radeon_private_t *dev_priv = dev->dev_private;
        RING_LOCALS;
 
-       DRM_DEBUG( "\n" );
+       DRM_DEBUG("\n");
 
-       BEGIN_RING( 6 );
+       BEGIN_RING(6);
        RADEON_WAIT_UNTIL_3D_IDLE();
-       OUT_RING( CP_PACKET0( RADEON_CRTC_OFFSET_CNTL, 0 ) );
-       OUT_RING( RADEON_READ( RADEON_CRTC_OFFSET_CNTL ) | RADEON_CRTC_OFFSET_FLIP_CNTL );
-       OUT_RING( CP_PACKET0( RADEON_CRTC2_OFFSET_CNTL, 0 ) );
-       OUT_RING( RADEON_READ( RADEON_CRTC2_OFFSET_CNTL ) | RADEON_CRTC_OFFSET_FLIP_CNTL );
+       OUT_RING(CP_PACKET0(RADEON_CRTC_OFFSET_CNTL, 0));
+       OUT_RING(RADEON_READ(RADEON_CRTC_OFFSET_CNTL) |
+                RADEON_CRTC_OFFSET_FLIP_CNTL);
+       OUT_RING(CP_PACKET0(RADEON_CRTC2_OFFSET_CNTL, 0));
+       OUT_RING(RADEON_READ(RADEON_CRTC2_OFFSET_CNTL) |
+                RADEON_CRTC_OFFSET_FLIP_CNTL);
        ADVANCE_RING();
 
        dev_priv->page_flipping = 1;
@@ -2047,62 +2053,62 @@ static int radeon_do_init_pageflip( drm_device_t *dev )
 /* Called whenever a client dies, from drm_release.
  * NOTE:  Lock isn't necessarily held when this is called!
  */
-static int radeon_do_cleanup_pageflip( drm_device_t *dev )
+static int radeon_do_cleanup_pageflip(drm_device_t * dev)
 {
        drm_radeon_private_t *dev_priv = dev->dev_private;
-       DRM_DEBUG( "\n" );
+       DRM_DEBUG("\n");
 
        if (dev_priv->current_page != 0)
-               radeon_cp_dispatch_flip( dev );
+               radeon_cp_dispatch_flip(dev);
 
        dev_priv->page_flipping = 0;
        return 0;
 }
 
 /* Swapping and flipping are different operations, need different ioctls.
- * They can & should be intermixed to support multiple 3d windows.  
+ * They can & should be intermixed to support multiple 3d windows.
  */
-static int radeon_cp_flip( DRM_IOCTL_ARGS )
+static int radeon_cp_flip(DRM_IOCTL_ARGS)
 {
        DRM_DEVICE;
        drm_radeon_private_t *dev_priv = dev->dev_private;
-       DRM_DEBUG( "\n" );
+       DRM_DEBUG("\n");
+
+       LOCK_TEST_WITH_RETURN(dev, filp);
 
-       LOCK_TEST_WITH_RETURN( dev, filp );
+       RING_SPACE_TEST_WITH_RETURN(dev_priv);
 
-       RING_SPACE_TEST_WITH_RETURN( dev_priv );
+       if (!dev_priv->page_flipping)
+               radeon_do_init_pageflip(dev);
 
-       if (!dev_priv->page_flipping) 
-               radeon_do_init_pageflip( dev );
-               
-       radeon_cp_dispatch_flip( dev );
+       radeon_cp_dispatch_flip(dev);
 
        COMMIT_RING();
        return 0;
 }
 
-static int radeon_cp_swap( DRM_IOCTL_ARGS )
+static int radeon_cp_swap(DRM_IOCTL_ARGS)
 {
        DRM_DEVICE;
        drm_radeon_private_t *dev_priv = dev->dev_private;
        drm_radeon_sarea_t *sarea_priv = dev_priv->sarea_priv;
-       DRM_DEBUG( "\n" );
+       DRM_DEBUG("\n");
 
-       LOCK_TEST_WITH_RETURN( dev, filp );
+       LOCK_TEST_WITH_RETURN(dev, filp);
 
-       RING_SPACE_TEST_WITH_RETURN( dev_priv );
+       RING_SPACE_TEST_WITH_RETURN(dev_priv);
 
-       if ( sarea_priv->nbox > RADEON_NR_SAREA_CLIPRECTS )
+       if (sarea_priv->nbox > RADEON_NR_SAREA_CLIPRECTS)
                sarea_priv->nbox = RADEON_NR_SAREA_CLIPRECTS;
 
-       radeon_cp_dispatch_swap( dev );
+       radeon_cp_dispatch_swap(dev);
        dev_priv->sarea_priv->ctx_owner = 0;
 
        COMMIT_RING();
        return 0;
 }
 
-static int radeon_cp_vertex( DRM_IOCTL_ARGS )
+static int radeon_cp_vertex(DRM_IOCTL_ARGS)
 {
        DRM_DEVICE;
        drm_radeon_private_t *dev_priv = dev->dev_private;
@@ -2113,55 +2119,53 @@ static int radeon_cp_vertex( DRM_IOCTL_ARGS )
        drm_radeon_vertex_t vertex;
        drm_radeon_tcl_prim_t prim;
 
-       LOCK_TEST_WITH_RETURN( dev, filp );
+       LOCK_TEST_WITH_RETURN(dev, filp);
 
-       DRM_GET_PRIV_WITH_RETURN( filp_priv, filp );
+       DRM_GET_PRIV_WITH_RETURN(filp_priv, filp);
 
-       DRM_COPY_FROM_USER_IOCTL( vertex, (drm_radeon_vertex_t __user *)data,
-                            sizeof(vertex) );
+       DRM_COPY_FROM_USER_IOCTL(vertex, (drm_radeon_vertex_t __user *) data,
+                                sizeof(vertex));
 
-       DRM_DEBUG( "pid=%d index=%d count=%d discard=%d\n",
-                  DRM_CURRENTPID,
-                  vertex.idx, vertex.count, vertex.discard );
+       DRM_DEBUG("pid=%d index=%d count=%d discard=%d\n",
+                 DRM_CURRENTPID, vertex.idx, vertex.count, vertex.discard);
 
-       if ( vertex.idx < 0 || vertex.idx >= dma->buf_count ) {
-               DRM_ERROR( "buffer index %d (of %d max)\n",
-                          vertex.idx, dma->buf_count - 1 );
+       if (vertex.idx < 0 || vertex.idx >= dma->buf_count) {
+               DRM_ERROR("buffer index %d (of %d max)\n",
+                         vertex.idx, dma->buf_count - 1);
                return DRM_ERR(EINVAL);
        }
-       if ( vertex.prim < 0 ||
-            vertex.prim > RADEON_PRIM_TYPE_3VRT_LINE_LIST ) {
-               DRM_ERROR( "buffer prim %d\n", vertex.prim );
+       if (vertex.prim < 0 || vertex.prim > RADEON_PRIM_TYPE_3VRT_LINE_LIST) {
+               DRM_ERROR("buffer prim %d\n", vertex.prim);
                return DRM_ERR(EINVAL);
        }
 
-       RING_SPACE_TEST_WITH_RETURN( dev_priv );
-       VB_AGE_TEST_WITH_RETURN( dev_priv );
+       RING_SPACE_TEST_WITH_RETURN(dev_priv);
+       VB_AGE_TEST_WITH_RETURN(dev_priv);
 
        buf = dma->buflist[vertex.idx];
 
-       if ( buf->filp != filp ) {
-               DRM_ERROR( "process %d using buffer owned by %p\n",
-                          DRM_CURRENTPID, buf->filp );
+       if (buf->filp != filp) {
+               DRM_ERROR("process %d using buffer owned by %p\n",
+                         DRM_CURRENTPID, buf->filp);
                return DRM_ERR(EINVAL);
        }
-       if ( buf->pending ) {
-               DRM_ERROR( "sending pending buffer %d\n", vertex.idx );
+       if (buf->pending) {
+               DRM_ERROR("sending pending buffer %d\n", vertex.idx);
                return DRM_ERR(EINVAL);
        }
 
        /* Build up a prim_t record:
         */
        if (vertex.count) {
-               buf->used = vertex.count; /* not used? */
-
-               if ( sarea_priv->dirty & ~RADEON_UPLOAD_CLIPRECTS ) {
-                       if ( radeon_emit_state( dev_priv, filp_priv,
-                                               &sarea_priv->context_state,
-                                               sarea_priv->tex_state,
-                                               sarea_priv->dirty ) ) {
-                               DRM_ERROR( "radeon_emit_state failed\n" );
-                               return DRM_ERR( EINVAL );
+               buf->used = vertex.count;       /* not used? */
+
+               if (sarea_priv->dirty & ~RADEON_UPLOAD_CLIPRECTS) {
+                       if (radeon_emit_state(dev_priv, filp_priv,
+                                             &sarea_priv->context_state,
+                                             sarea_priv->tex_state,
+                                             sarea_priv->dirty)) {
+                               DRM_ERROR("radeon_emit_state failed\n");
+                               return DRM_ERR(EINVAL);
                        }
 
                        sarea_priv->dirty &= ~(RADEON_UPLOAD_TEX0IMAGES |
@@ -2171,23 +2175,23 @@ static int radeon_cp_vertex( DRM_IOCTL_ARGS )
                }
 
                prim.start = 0;
-               prim.finish = vertex.count; /* unused */
+               prim.finish = vertex.count;     /* unused */
                prim.prim = vertex.prim;
                prim.numverts = vertex.count;
                prim.vc_format = dev_priv->sarea_priv->vc_format;
-               
-               radeon_cp_dispatch_vertex( dev, buf, &prim );
+
+               radeon_cp_dispatch_vertex(dev, buf, &prim);
        }
 
        if (vertex.discard) {
-               radeon_cp_discard_buffer( dev, buf );
+               radeon_cp_discard_buffer(dev, buf);
        }
 
        COMMIT_RING();
        return 0;
 }
 
-static int radeon_cp_indices( DRM_IOCTL_ARGS )
+static int radeon_cp_indices(DRM_IOCTL_ARGS)
 {
        DRM_DEVICE;
        drm_radeon_private_t *dev_priv = dev->dev_private;
@@ -2199,69 +2203,62 @@ static int radeon_cp_indices( DRM_IOCTL_ARGS )
        drm_radeon_tcl_prim_t prim;
        int count;
 
-       LOCK_TEST_WITH_RETURN( dev, filp );
-
-       if ( !dev_priv ) {
-               DRM_ERROR( "%s called with no initialization\n", __FUNCTION__ );
-               return DRM_ERR(EINVAL);
-       }
+       LOCK_TEST_WITH_RETURN(dev, filp);
 
-       DRM_GET_PRIV_WITH_RETURN( filp_priv, filp );
+       DRM_GET_PRIV_WITH_RETURN(filp_priv, filp);
 
-       DRM_COPY_FROM_USER_IOCTL( elts, (drm_radeon_indices_t __user *)data,
-                            sizeof(elts) );
+       DRM_COPY_FROM_USER_IOCTL(elts, (drm_radeon_indices_t __user *) data,
+                                sizeof(elts));
 
-       DRM_DEBUG( "pid=%d index=%d start=%d end=%d discard=%d\n",
-                  DRM_CURRENTPID,
-                  elts.idx, elts.start, elts.end, elts.discard );
+       DRM_DEBUG("pid=%d index=%d start=%d end=%d discard=%d\n",
+                 DRM_CURRENTPID, elts.idx, elts.start, elts.end, elts.discard);
 
-       if ( elts.idx < 0 || elts.idx >= dma->buf_count ) {
-               DRM_ERROR( "buffer index %d (of %d max)\n",
-                          elts.idx, dma->buf_count - 1 );
+       if (elts.idx < 0 || elts.idx >= dma->buf_count) {
+               DRM_ERROR("buffer index %d (of %d max)\n",
+                         elts.idx, dma->buf_count - 1);
                return DRM_ERR(EINVAL);
        }
-       if ( elts.prim < 0 ||
-            elts.prim > RADEON_PRIM_TYPE_3VRT_LINE_LIST ) {
-               DRM_ERROR( "buffer prim %d\n", elts.prim );
+       if (elts.prim < 0 || elts.prim > RADEON_PRIM_TYPE_3VRT_LINE_LIST) {
+               DRM_ERROR("buffer prim %d\n", elts.prim);
                return DRM_ERR(EINVAL);
        }
 
-       RING_SPACE_TEST_WITH_RETURN( dev_priv );
-       VB_AGE_TEST_WITH_RETURN( dev_priv );
+       RING_SPACE_TEST_WITH_RETURN(dev_priv);
+       VB_AGE_TEST_WITH_RETURN(dev_priv);
 
        buf = dma->buflist[elts.idx];
 
-       if ( buf->filp != filp ) {
-               DRM_ERROR( "process %d using buffer owned by %p\n",
-                          DRM_CURRENTPID, buf->filp );
+       if (buf->filp != filp) {
+               DRM_ERROR("process %d using buffer owned by %p\n",
+                         DRM_CURRENTPID, buf->filp);
                return DRM_ERR(EINVAL);
        }
-       if ( buf->pending ) {
-               DRM_ERROR( "sending pending buffer %d\n", elts.idx );
+       if (buf->pending) {
+               DRM_ERROR("sending pending buffer %d\n", elts.idx);
                return DRM_ERR(EINVAL);
        }
 
        count = (elts.end - elts.start) / sizeof(u16);
        elts.start -= RADEON_INDEX_PRIM_OFFSET;
 
-       if ( elts.start & 0x7 ) {
-               DRM_ERROR( "misaligned buffer 0x%x\n", elts.start );
+       if (elts.start & 0x7) {
+               DRM_ERROR("misaligned buffer 0x%x\n", elts.start);
                return DRM_ERR(EINVAL);
        }
-       if ( elts.start < buf->used ) {
-               DRM_ERROR( "no header 0x%x - 0x%x\n", elts.start, buf->used );
+       if (elts.start < buf->used) {
+               DRM_ERROR("no header 0x%x - 0x%x\n", elts.start, buf->used);
                return DRM_ERR(EINVAL);
        }
 
        buf->used = elts.end;
 
-       if ( sarea_priv->dirty & ~RADEON_UPLOAD_CLIPRECTS ) {
-               if ( radeon_emit_state( dev_priv, filp_priv,
-                                       &sarea_priv->context_state,
-                                       sarea_priv->tex_state,
-                                       sarea_priv->dirty ) ) {
-                       DRM_ERROR( "radeon_emit_state failed\n" );
-                       return DRM_ERR( EINVAL );
+       if (sarea_priv->dirty & ~RADEON_UPLOAD_CLIPRECTS) {
+               if (radeon_emit_state(dev_priv, filp_priv,
+                                     &sarea_priv->context_state,
+                                     sarea_priv->tex_state,
+                                     sarea_priv->dirty)) {
+                       DRM_ERROR("radeon_emit_state failed\n");
+                       return DRM_ERR(EINVAL);
                }
 
                sarea_priv->dirty &= ~(RADEON_UPLOAD_TEX0IMAGES |
@@ -2270,26 +2267,25 @@ static int radeon_cp_indices( DRM_IOCTL_ARGS )
                                       RADEON_REQUIRE_QUIESCENCE);
        }
 
-
        /* Build up a prim_t record:
         */
        prim.start = elts.start;
-       prim.finish = elts.end; 
+       prim.finish = elts.end;
        prim.prim = elts.prim;
        prim.offset = 0;        /* offset from start of dma buffers */
-       prim.numverts = RADEON_MAX_VB_VERTS; /* duh */
+       prim.numverts = RADEON_MAX_VB_VERTS;    /* duh */
        prim.vc_format = dev_priv->sarea_priv->vc_format;
-       
-       radeon_cp_dispatch_indices( dev, buf, &prim );
+
+       radeon_cp_dispatch_indices(dev, buf, &prim);
        if (elts.discard) {
-               radeon_cp_discard_buffer( dev, buf );
+               radeon_cp_discard_buffer(dev, buf);
        }
 
        COMMIT_RING();
        return 0;
 }
 
-static int radeon_cp_texture( DRM_IOCTL_ARGS )
+static int radeon_cp_texture(DRM_IOCTL_ARGS)
 {
        DRM_DEVICE;
        drm_radeon_private_t *dev_priv = dev->dev_private;
@@ -2297,53 +2293,54 @@ static int radeon_cp_texture( DRM_IOCTL_ARGS )
        drm_radeon_tex_image_t image;
        int ret;
 
-       LOCK_TEST_WITH_RETURN( dev, filp );
+       LOCK_TEST_WITH_RETURN(dev, filp);
 
-       DRM_COPY_FROM_USER_IOCTL( tex, (drm_radeon_texture_t __user *)data, sizeof(tex) );
+       DRM_COPY_FROM_USER_IOCTL(tex, (drm_radeon_texture_t __user *) data,
+                                sizeof(tex));
 
-       if ( tex.image == NULL ) {
-               DRM_ERROR( "null texture image!\n" );
+       if (tex.image == NULL) {
+               DRM_ERROR("null texture image!\n");
                return DRM_ERR(EINVAL);
        }
 
-       if ( DRM_COPY_FROM_USER( &image,
-                            (drm_radeon_tex_image_t __user *)tex.image,
-                            sizeof(image) ) )
+       if (DRM_COPY_FROM_USER(&image,
+                              (drm_radeon_tex_image_t __user *) tex.image,
+                              sizeof(image)))
                return DRM_ERR(EFAULT);
 
-       RING_SPACE_TEST_WITH_RETURN( dev_priv );
-       VB_AGE_TEST_WITH_RETURN( dev_priv );
+       RING_SPACE_TEST_WITH_RETURN(dev_priv);
+       VB_AGE_TEST_WITH_RETURN(dev_priv);
 
-       ret = radeon_cp_dispatch_texture( filp, dev, &tex, &image );
+       ret = radeon_cp_dispatch_texture(filp, dev, &tex, &image);
 
        COMMIT_RING();
        return ret;
 }
 
-static int radeon_cp_stipple( DRM_IOCTL_ARGS )
+static int radeon_cp_stipple(DRM_IOCTL_ARGS)
 {
        DRM_DEVICE;
        drm_radeon_private_t *dev_priv = dev->dev_private;
        drm_radeon_stipple_t stipple;
        u32 mask[32];
 
-       LOCK_TEST_WITH_RETURN( dev, filp );
+       LOCK_TEST_WITH_RETURN(dev, filp);
 
-       DRM_COPY_FROM_USER_IOCTL( stipple, (drm_radeon_stipple_t __user *)data,
-                            sizeof(stipple) );
+       DRM_COPY_FROM_USER_IOCTL(stipple, (drm_radeon_stipple_t __user *) data,
+                                sizeof(stipple));
 
-       if ( DRM_COPY_FROM_USER( &mask, stipple.mask, 32 * sizeof(u32) ) )
+       if (DRM_COPY_FROM_USER(&mask, stipple.mask, 32 * sizeof(u32)))
                return DRM_ERR(EFAULT);
 
-       RING_SPACE_TEST_WITH_RETURN( dev_priv );
+       RING_SPACE_TEST_WITH_RETURN(dev_priv);
 
-       radeon_cp_dispatch_stipple( dev, mask );
+       radeon_cp_dispatch_stipple(dev, mask);
 
        COMMIT_RING();
        return 0;
 }
 
-static int radeon_cp_indirect( DRM_IOCTL_ARGS )
+static int radeon_cp_indirect(DRM_IOCTL_ARGS)
 {
        DRM_DEVICE;
        drm_radeon_private_t *dev_priv = dev->dev_private;
@@ -2352,53 +2349,48 @@ static int radeon_cp_indirect( DRM_IOCTL_ARGS )
        drm_radeon_indirect_t indirect;
        RING_LOCALS;
 
-       LOCK_TEST_WITH_RETURN( dev, filp );
-
-       if ( !dev_priv ) {
-               DRM_ERROR( "%s called with no initialization\n", __FUNCTION__ );
-               return DRM_ERR(EINVAL);
-       }
+       LOCK_TEST_WITH_RETURN(dev, filp);
 
-       DRM_COPY_FROM_USER_IOCTL( indirect, (drm_radeon_indirect_t __user *)data,
-                            sizeof(indirect) );
+       DRM_COPY_FROM_USER_IOCTL(indirect,
+                                (drm_radeon_indirect_t __user *) data,
+                                sizeof(indirect));
 
-       DRM_DEBUG( "indirect: idx=%d s=%d e=%d d=%d\n",
-                  indirect.idx, indirect.start,
-                  indirect.end, indirect.discard );
+       DRM_DEBUG("indirect: idx=%d s=%d e=%d d=%d\n",
+                 indirect.idx, indirect.start, indirect.end, indirect.discard);
 
-       if ( indirect.idx < 0 || indirect.idx >= dma->buf_count ) {
-               DRM_ERROR( "buffer index %d (of %d max)\n",
-                          indirect.idx, dma->buf_count - 1 );
+       if (indirect.idx < 0 || indirect.idx >= dma->buf_count) {
+               DRM_ERROR("buffer index %d (of %d max)\n",
+                         indirect.idx, dma->buf_count - 1);
                return DRM_ERR(EINVAL);
        }
 
        buf = dma->buflist[indirect.idx];
 
-       if ( buf->filp != filp ) {
-               DRM_ERROR( "process %d using buffer owned by %p\n",
-                          DRM_CURRENTPID, buf->filp );
+       if (buf->filp != filp) {
+               DRM_ERROR("process %d using buffer owned by %p\n",
+                         DRM_CURRENTPID, buf->filp);
                return DRM_ERR(EINVAL);
        }
-       if ( buf->pending ) {
-               DRM_ERROR( "sending pending buffer %d\n", indirect.idx );
+       if (buf->pending) {
+               DRM_ERROR("sending pending buffer %d\n", indirect.idx);
                return DRM_ERR(EINVAL);
        }
 
-       if ( indirect.start < buf->used ) {
-               DRM_ERROR( "reusing indirect: start=0x%x actual=0x%x\n",
-                          indirect.start, buf->used );
+       if (indirect.start < buf->used) {
+               DRM_ERROR("reusing indirect: start=0x%x actual=0x%x\n",
+                         indirect.start, buf->used);
                return DRM_ERR(EINVAL);
        }
 
-       RING_SPACE_TEST_WITH_RETURN( dev_priv );
-       VB_AGE_TEST_WITH_RETURN( dev_priv );
+       RING_SPACE_TEST_WITH_RETURN(dev_priv);
+       VB_AGE_TEST_WITH_RETURN(dev_priv);
 
        buf->used = indirect.end;
 
        /* Wait for the 3D stream to idle before the indirect buffer
         * containing 2D acceleration commands is processed.
         */
-       BEGIN_RING( 2 );
+       BEGIN_RING(2);
 
        RADEON_WAIT_UNTIL_3D_IDLE();
 
@@ -2408,17 +2400,16 @@ static int radeon_cp_indirect( DRM_IOCTL_ARGS )
         * X server.  This is insecure and is thus only available to
         * privileged clients.
         */
-       radeon_cp_dispatch_indirect( dev, buf, indirect.start, indirect.end );
+       radeon_cp_dispatch_indirect(dev, buf, indirect.start, indirect.end);
        if (indirect.discard) {
-               radeon_cp_discard_buffer( dev, buf );
+               radeon_cp_discard_buffer(dev, buf);
        }
 
-
        COMMIT_RING();
        return 0;
 }
 
-static int radeon_cp_vertex2( DRM_IOCTL_ARGS )
+static int radeon_cp_vertex2(DRM_IOCTL_ARGS)
 {
        DRM_DEVICE;
        drm_radeon_private_t *dev_priv = dev->dev_private;
@@ -2430,65 +2421,59 @@ static int radeon_cp_vertex2( DRM_IOCTL_ARGS )
        int i;
        unsigned char laststate;
 
-       LOCK_TEST_WITH_RETURN( dev, filp );
+       LOCK_TEST_WITH_RETURN(dev, filp);
 
-       if ( !dev_priv ) {
-               DRM_ERROR( "%s called with no initialization\n", __FUNCTION__ );
-               return DRM_ERR(EINVAL);
-       }
-
-       DRM_GET_PRIV_WITH_RETURN( filp_priv, filp );
+       DRM_GET_PRIV_WITH_RETURN(filp_priv, filp);
 
-       DRM_COPY_FROM_USER_IOCTL( vertex, (drm_radeon_vertex2_t __user *)data,
-                            sizeof(vertex) );
+       DRM_COPY_FROM_USER_IOCTL(vertex, (drm_radeon_vertex2_t __user *) data,
+                                sizeof(vertex));
 
-       DRM_DEBUG( "pid=%d index=%d discard=%d\n",
-                  DRM_CURRENTPID,
-                  vertex.idx, vertex.discard );
+       DRM_DEBUG("pid=%d index=%d discard=%d\n",
+                 DRM_CURRENTPID, vertex.idx, vertex.discard);
 
-       if ( vertex.idx < 0 || vertex.idx >= dma->buf_count ) {
-               DRM_ERROR( "buffer index %d (of %d max)\n",
-                          vertex.idx, dma->buf_count - 1 );
+       if (vertex.idx < 0 || vertex.idx >= dma->buf_count) {
+               DRM_ERROR("buffer index %d (of %d max)\n",
+                         vertex.idx, dma->buf_count - 1);
                return DRM_ERR(EINVAL);
        }
 
-       RING_SPACE_TEST_WITH_RETURN( dev_priv );
-       VB_AGE_TEST_WITH_RETURN( dev_priv );
+       RING_SPACE_TEST_WITH_RETURN(dev_priv);
+       VB_AGE_TEST_WITH_RETURN(dev_priv);
 
        buf = dma->buflist[vertex.idx];
 
-       if ( buf->filp != filp ) {
-               DRM_ERROR( "process %d using buffer owned by %p\n",
-                          DRM_CURRENTPID, buf->filp );
+       if (buf->filp != filp) {
+               DRM_ERROR("process %d using buffer owned by %p\n",
+                         DRM_CURRENTPID, buf->filp);
                return DRM_ERR(EINVAL);
        }
 
-       if ( buf->pending ) {
-               DRM_ERROR( "sending pending buffer %d\n", vertex.idx );
+       if (buf->pending) {
+               DRM_ERROR("sending pending buffer %d\n", vertex.idx);
                return DRM_ERR(EINVAL);
        }
-       
+
        if (sarea_priv->nbox > RADEON_NR_SAREA_CLIPRECTS)
                return DRM_ERR(EINVAL);
 
-       for (laststate = 0xff, i = 0 ; i < vertex.nr_prims ; i++) {
+       for (laststate = 0xff, i = 0; i < vertex.nr_prims; i++) {
                drm_radeon_prim_t prim;
                drm_radeon_tcl_prim_t tclprim;
-               
-               if ( DRM_COPY_FROM_USER( &prim, &vertex.prim[i], sizeof(prim) ) )
+
+               if (DRM_COPY_FROM_USER(&prim, &vertex.prim[i], sizeof(prim)))
                        return DRM_ERR(EFAULT);
-               
-               if ( prim.stateidx != laststate ) {
-                       drm_radeon_state_t state;                              
-                               
-                       if ( DRM_COPY_FROM_USER( &state, 
-                                            &vertex.state[prim.stateidx], 
-                                            sizeof(state) ) )
+
+               if (prim.stateidx != laststate) {
+                       drm_radeon_state_t state;
+
+                       if (DRM_COPY_FROM_USER(&state,
+                                              &vertex.state[prim.stateidx],
+                                              sizeof(state)))
                                return DRM_ERR(EFAULT);
 
-                       if ( radeon_emit_state2( dev_priv, filp_priv, &state ) ) {
-                               DRM_ERROR( "radeon_emit_state2 failed\n" );
-                               return DRM_ERR( EINVAL );
+                       if (radeon_emit_state2(dev_priv, filp_priv, &state)) {
+                               DRM_ERROR("radeon_emit_state2 failed\n");
+                               return DRM_ERR(EINVAL);
                        }
 
                        laststate = prim.stateidx;
@@ -2499,42 +2484,40 @@ static int radeon_cp_vertex2( DRM_IOCTL_ARGS )
                tclprim.prim = prim.prim;
                tclprim.vc_format = prim.vc_format;
 
-               if ( prim.prim & RADEON_PRIM_WALK_IND ) {
+               if (prim.prim & RADEON_PRIM_WALK_IND) {
                        tclprim.offset = prim.numverts * 64;
-                       tclprim.numverts = RADEON_MAX_VB_VERTS; /* duh */
+                       tclprim.numverts = RADEON_MAX_VB_VERTS; /* duh */
 
-                       radeon_cp_dispatch_indices( dev, buf, &tclprim );
+                       radeon_cp_dispatch_indices(dev, buf, &tclprim);
                } else {
                        tclprim.numverts = prim.numverts;
-                       tclprim.offset = 0; /* not used */
+                       tclprim.offset = 0;     /* not used */
 
-                       radeon_cp_dispatch_vertex( dev, buf, &tclprim );
+                       radeon_cp_dispatch_vertex(dev, buf, &tclprim);
                }
-               
+
                if (sarea_priv->nbox == 1)
                        sarea_priv->nbox = 0;
        }
 
-       if ( vertex.discard ) {
-               radeon_cp_discard_buffer( dev, buf );
+       if (vertex.discard) {
+               radeon_cp_discard_buffer(dev, buf);
        }
 
        COMMIT_RING();
        return 0;
 }
 
-
-static int radeon_emit_packets( 
-       drm_radeon_private_t *dev_priv,
-       drm_file_t *filp_priv,
-       drm_radeon_cmd_header_t header,
-       drm_radeon_cmd_buffer_t *cmdbuf )
+static int radeon_emit_packets(drm_radeon_private_t * dev_priv,
+                              drm_file_t * filp_priv,
+                              drm_radeon_cmd_header_t header,
+                              drm_radeon_kcmd_buffer_t *cmdbuf)
 {
        int id = (int)header.packet.packet_id;
        int sz, reg;
        int *data = (int *)cmdbuf->buf;
        RING_LOCALS;
-   
+
        if (id >= RADEON_MAX_STATE_PACKETS)
                return DRM_ERR(EINVAL);
 
@@ -2542,18 +2525,18 @@ static int radeon_emit_packets(
        reg = packet[id].start;
 
        if (sz * sizeof(int) > cmdbuf->bufsz) {
-               DRM_ERROR( "Packet size provided larger than data provided\n" );
+               DRM_ERROR("Packet size provided larger than data provided\n");
                return DRM_ERR(EINVAL);
        }
 
-       if ( radeon_check_and_fixup_packets( dev_priv, filp_priv, id, data ) ) {
-               DRM_ERROR( "Packet verification failed\n" );
-               return DRM_ERR( EINVAL );
+       if (radeon_check_and_fixup_packets(dev_priv, filp_priv, id, data)) {
+               DRM_ERROR("Packet verification failed\n");
+               return DRM_ERR(EINVAL);
        }
 
-       BEGIN_RING(sz+1);
-       OUT_RING( CP_PACKET0( reg, (sz-1) ) );
-       OUT_RING_TABLE( data, sz );
+       BEGIN_RING(sz + 1);
+       OUT_RING(CP_PACKET0(reg, (sz - 1)));
+       OUT_RING_TABLE(data, sz);
        ADVANCE_RING();
 
        cmdbuf->buf += sz * sizeof(int);
@@ -2561,21 +2544,20 @@ static int radeon_emit_packets(
        return 0;
 }
 
-static __inline__ int radeon_emit_scalars( 
-       drm_radeon_private_t *dev_priv,
-       drm_radeon_cmd_header_t header,
-       drm_radeon_cmd_buffer_t *cmdbuf )
+static __inline__ int radeon_emit_scalars(drm_radeon_private_t *dev_priv,
+                                         drm_radeon_cmd_header_t header,
+                                         drm_radeon_kcmd_buffer_t *cmdbuf)
 {
        int sz = header.scalars.count;
        int start = header.scalars.offset;
        int stride = header.scalars.stride;
        RING_LOCALS;
 
-       BEGIN_RING( 3+sz );
-       OUT_RING( CP_PACKET0( RADEON_SE_TCL_SCALAR_INDX_REG, 0 ) );
-       OUT_RING( start | (stride << RADEON_SCAL_INDX_DWORD_STRIDE_SHIFT));
-       OUT_RING( CP_PACKET0_TABLE( RADEON_SE_TCL_SCALAR_DATA_REG, sz-1 ) );
-       OUT_RING_TABLE( cmdbuf->buf, sz );
+       BEGIN_RING(3 + sz);
+       OUT_RING(CP_PACKET0(RADEON_SE_TCL_SCALAR_INDX_REG, 0));
+       OUT_RING(start | (stride << RADEON_SCAL_INDX_DWORD_STRIDE_SHIFT));
+       OUT_RING(CP_PACKET0_TABLE(RADEON_SE_TCL_SCALAR_DATA_REG, sz - 1));
+       OUT_RING_TABLE(cmdbuf->buf, sz);
        ADVANCE_RING();
        cmdbuf->buf += sz * sizeof(int);
        cmdbuf->bufsz -= sz * sizeof(int);
@@ -2584,42 +2566,40 @@ static __inline__ int radeon_emit_scalars(
 
 /* God this is ugly
  */
-static __inline__ int radeon_emit_scalars2( 
-       drm_radeon_private_t *dev_priv,
-       drm_radeon_cmd_header_t header,
-       drm_radeon_cmd_buffer_t *cmdbuf )
+static __inline__ int radeon_emit_scalars2(drm_radeon_private_t *dev_priv,
+                                          drm_radeon_cmd_header_t header,
+                                          drm_radeon_kcmd_buffer_t *cmdbuf)
 {
        int sz = header.scalars.count;
        int start = ((unsigned int)header.scalars.offset) + 0x100;
        int stride = header.scalars.stride;
        RING_LOCALS;
 
-       BEGIN_RING( 3+sz );
-       OUT_RING( CP_PACKET0( RADEON_SE_TCL_SCALAR_INDX_REG, 0 ) );
-       OUT_RING( start | (stride << RADEON_SCAL_INDX_DWORD_STRIDE_SHIFT));
-       OUT_RING( CP_PACKET0_TABLE( RADEON_SE_TCL_SCALAR_DATA_REG, sz-1 ) );
-       OUT_RING_TABLE( cmdbuf->buf, sz );
+       BEGIN_RING(3 + sz);
+       OUT_RING(CP_PACKET0(RADEON_SE_TCL_SCALAR_INDX_REG, 0));
+       OUT_RING(start | (stride << RADEON_SCAL_INDX_DWORD_STRIDE_SHIFT));
+       OUT_RING(CP_PACKET0_TABLE(RADEON_SE_TCL_SCALAR_DATA_REG, sz - 1));
+       OUT_RING_TABLE(cmdbuf->buf, sz);
        ADVANCE_RING();
        cmdbuf->buf += sz * sizeof(int);
        cmdbuf->bufsz -= sz * sizeof(int);
        return 0;
 }
 
-static __inline__ int radeon_emit_vectors( 
-       drm_radeon_private_t *dev_priv,
-       drm_radeon_cmd_header_t header,
-       drm_radeon_cmd_buffer_t *cmdbuf )
+static __inline__ int radeon_emit_vectors(drm_radeon_private_t *dev_priv,
+                                         drm_radeon_cmd_header_t header,
+                                         drm_radeon_kcmd_buffer_t *cmdbuf)
 {
        int sz = header.vectors.count;
        int start = header.vectors.offset;
        int stride = header.vectors.stride;
        RING_LOCALS;
 
-       BEGIN_RING( 3+sz );
-       OUT_RING( CP_PACKET0( RADEON_SE_TCL_VECTOR_INDX_REG, 0 ) );
-       OUT_RING( start | (stride << RADEON_VEC_INDX_OCTWORD_STRIDE_SHIFT));
-       OUT_RING( CP_PACKET0_TABLE( RADEON_SE_TCL_VECTOR_DATA_REG, (sz-1) ) );
-       OUT_RING_TABLE( cmdbuf->buf, sz );
+       BEGIN_RING(3 + sz);
+       OUT_RING(CP_PACKET0(RADEON_SE_TCL_VECTOR_INDX_REG, 0));
+       OUT_RING(start | (stride << RADEON_VEC_INDX_OCTWORD_STRIDE_SHIFT));
+       OUT_RING(CP_PACKET0_TABLE(RADEON_SE_TCL_VECTOR_DATA_REG, (sz - 1)));
+       OUT_RING_TABLE(cmdbuf->buf, sz);
        ADVANCE_RING();
 
        cmdbuf->buf += sz * sizeof(int);
@@ -2627,10 +2607,9 @@ static __inline__ int radeon_emit_vectors(
        return 0;
 }
 
-
-static int radeon_emit_packet3( drm_device_t *dev,
-                               drm_file_t *filp_priv,
-                               drm_radeon_cmd_buffer_t *cmdbuf )
+static int radeon_emit_packet3(drm_device_t * dev,
+                              drm_file_t * filp_priv,
+                              drm_radeon_kcmd_buffer_t *cmdbuf)
 {
        drm_radeon_private_t *dev_priv = dev->dev_private;
        unsigned int cmdsz;
@@ -2639,14 +2618,14 @@ static int radeon_emit_packet3( drm_device_t *dev,
 
        DRM_DEBUG("\n");
 
-       if ( ( ret = radeon_check_and_fixup_packet3( dev_priv, filp_priv,
-                                                    cmdbuf, &cmdsz ) ) ) {
-               DRM_ERROR( "Packet verification failed\n" );
+       if ((ret = radeon_check_and_fixup_packet3(dev_priv, filp_priv,
+                                                 cmdbuf, &cmdsz))) {
+               DRM_ERROR("Packet verification failed\n");
                return ret;
        }
 
-       BEGIN_RING( cmdsz );
-       OUT_RING_TABLE( cmdbuf->buf, cmdsz );
+       BEGIN_RING(cmdsz);
+       OUT_RING_TABLE(cmdbuf->buf, cmdsz);
        ADVANCE_RING();
 
        cmdbuf->buf += cmdsz * 4;
@@ -2654,11 +2633,10 @@ static int radeon_emit_packet3( drm_device_t *dev,
        return 0;
 }
 
-
-static int radeon_emit_packet3_cliprect( drm_device_t *dev,
-                                        drm_file_t *filp_priv,
-                                        drm_radeon_cmd_buffer_t *cmdbuf,
-                                        int orig_nbox )
+static int radeon_emit_packet3_cliprect(drm_device_t *dev,
+                                       drm_file_t *filp_priv,
+                                       drm_radeon_kcmd_buffer_t *cmdbuf,
+                                       int orig_nbox)
 {
        drm_radeon_private_t *dev_priv = dev->dev_private;
        drm_clip_rect_t box;
@@ -2670,9 +2648,9 @@ static int radeon_emit_packet3_cliprect( drm_device_t *dev,
 
        DRM_DEBUG("\n");
 
-       if ( ( ret = radeon_check_and_fixup_packet3( dev_priv, filp_priv,
-                                                    cmdbuf, &cmdsz ) ) ) {
-               DRM_ERROR( "Packet verification failed\n" );
+       if ((ret = radeon_check_and_fixup_packet3(dev_priv, filp_priv,
+                                                 cmdbuf, &cmdsz))) {
+               DRM_ERROR("Packet verification failed\n");
                return ret;
        }
 
@@ -2680,8 +2658,8 @@ static int radeon_emit_packet3_cliprect( drm_device_t *dev,
                goto out;
 
        do {
-               if ( i < cmdbuf->nbox ) {
-                       if (DRM_COPY_FROM_USER( &box, &boxes[i], sizeof(box) ))
+               if (i < cmdbuf->nbox) {
+                       if (DRM_COPY_FROM_USER(&box, &boxes[i], sizeof(box)))
                                return DRM_ERR(EFAULT);
                        /* FIXME The second and subsequent times round
                         * this loop, send a WAIT_UNTIL_3D_IDLE before
@@ -2695,30 +2673,29 @@ static int radeon_emit_packet3_cliprect( drm_device_t *dev,
                         * the correct place to fix it but this works
                         * around it until I can figure that out - Tim
                         * Smith */
-                       if ( i ) {
-                               BEGIN_RING( 2 );
+                       if (i) {
+                               BEGIN_RING(2);
                                RADEON_WAIT_UNTIL_3D_IDLE();
                                ADVANCE_RING();
                        }
-                       radeon_emit_clip_rect( dev_priv, &box );
+                       radeon_emit_clip_rect(dev_priv, &box);
                }
-               
-               BEGIN_RING( cmdsz );
-               OUT_RING_TABLE( cmdbuf->buf, cmdsz );
+
+               BEGIN_RING(cmdsz);
+               OUT_RING_TABLE(cmdbuf->buf, cmdsz);
                ADVANCE_RING();
 
-       } while ( ++i < cmdbuf->nbox );
-       if (cmdbuf->nbox == 1)
+       } while (++i < cmdbuf->nbox);
+       if (cmdbuf->nbox == 1)
                cmdbuf->nbox = 0;
 
- out:
     out:
        cmdbuf->buf += cmdsz * 4;
        cmdbuf->bufsz -= cmdsz * 4;
        return 0;
 }
 
-
-static int radeon_emit_wait( drm_device_t *dev, int flags )
+static int radeon_emit_wait(drm_device_t * dev, int flags)
 {
        drm_radeon_private_t *dev_priv = dev->dev_private;
        RING_LOCALS;
@@ -2726,18 +2703,18 @@ static int radeon_emit_wait( drm_device_t *dev, int flags )
        DRM_DEBUG("%s: %x\n", __FUNCTION__, flags);
        switch (flags) {
        case RADEON_WAIT_2D:
-               BEGIN_RING( 2 );
-               RADEON_WAIT_UNTIL_2D_IDLE(); 
+               BEGIN_RING(2);
+               RADEON_WAIT_UNTIL_2D_IDLE();
                ADVANCE_RING();
                break;
        case RADEON_WAIT_3D:
-               BEGIN_RING( 2 );
-               RADEON_WAIT_UNTIL_3D_IDLE(); 
+               BEGIN_RING(2);
+               RADEON_WAIT_UNTIL_3D_IDLE();
                ADVANCE_RING();
                break;
-       case RADEON_WAIT_2D|RADEON_WAIT_3D:
-               BEGIN_RING( 2 );
-               RADEON_WAIT_UNTIL_IDLE(); 
+       case RADEON_WAIT_2D | RADEON_WAIT_3D:
+               BEGIN_RING(2);
+               RADEON_WAIT_UNTIL_IDLE();
                ADVANCE_RING();
                break;
        default:
@@ -2747,7 +2724,7 @@ static int radeon_emit_wait( drm_device_t *dev, int flags )
        return 0;
 }
 
-static int radeon_cp_cmdbuf( DRM_IOCTL_ARGS )
+static int radeon_cp_cmdbuf(DRM_IOCTL_ARGS)
 {
        DRM_DEVICE;
        drm_radeon_private_t *dev_priv = dev->dev_private;
@@ -2755,27 +2732,23 @@ static int radeon_cp_cmdbuf( DRM_IOCTL_ARGS )
        drm_device_dma_t *dma = dev->dma;
        drm_buf_t *buf = NULL;
        int idx;
-       drm_radeon_cmd_buffer_t cmdbuf;
+       drm_radeon_kcmd_buffer_t cmdbuf;
        drm_radeon_cmd_header_t header;
        int orig_nbox, orig_bufsz;
-       char *kbuf=NULL;
+       char *kbuf = NULL;
 
-       LOCK_TEST_WITH_RETURN( dev, filp );
+       LOCK_TEST_WITH_RETURN(dev, filp);
 
-       if ( !dev_priv ) {
-               DRM_ERROR( "%s called with no initialization\n", __FUNCTION__ );
-               return DRM_ERR(EINVAL);
-       }
-
-       DRM_GET_PRIV_WITH_RETURN( filp_priv, filp );
+       DRM_GET_PRIV_WITH_RETURN(filp_priv, filp);
 
-       DRM_COPY_FROM_USER_IOCTL( cmdbuf, (drm_radeon_cmd_buffer_t __user *)data,
-                            sizeof(cmdbuf) );
+       DRM_COPY_FROM_USER_IOCTL(cmdbuf,
+                                (drm_radeon_cmd_buffer_t __user *) data,
+                                sizeof(cmdbuf));
 
-       RING_SPACE_TEST_WITH_RETURN( dev_priv );
-       VB_AGE_TEST_WITH_RETURN( dev_priv );
+       RING_SPACE_TEST_WITH_RETURN(dev_priv);
+       VB_AGE_TEST_WITH_RETURN(dev_priv);
 
-       if (cmdbuf.bufsz > 64*1024 || cmdbuf.bufsz<0) {
+       if (cmdbuf.bufsz > 64 * 1024 || cmdbuf.bufsz < 0) {
                return DRM_ERR(EINVAL);
        }
 
@@ -2788,7 +2761,8 @@ static int radeon_cp_cmdbuf( DRM_IOCTL_ARGS )
                kbuf = drm_alloc(cmdbuf.bufsz, DRM_MEM_DRIVER);
                if (kbuf == NULL)
                        return DRM_ERR(ENOMEM);
-               if (DRM_COPY_FROM_USER(kbuf, cmdbuf.buf, cmdbuf.bufsz)) {
+               if (DRM_COPY_FROM_USER(kbuf, (void __user *)cmdbuf.buf,
+                                      cmdbuf.bufsz)) {
                        drm_free(kbuf, orig_bufsz, DRM_MEM_DRIVER);
                        return DRM_ERR(EFAULT);
                }
@@ -2797,16 +2771,28 @@ static int radeon_cp_cmdbuf( DRM_IOCTL_ARGS )
 
        orig_nbox = cmdbuf.nbox;
 
-       while ( cmdbuf.bufsz >= sizeof(header) ) {
+       if (dev_priv->microcode_version == UCODE_R300) {
+               int temp;
+               temp = r300_do_cp_cmdbuf(dev, filp, filp_priv, &cmdbuf);
+
+               if (orig_bufsz != 0)
+                       drm_free(kbuf, orig_bufsz, DRM_MEM_DRIVER);
+
+               return temp;
+       }
+
+       /* microcode_version != r300 */
+       while (cmdbuf.bufsz >= sizeof(header)) {
 
                header.i = *(int *)cmdbuf.buf;
                cmdbuf.buf += sizeof(header);
                cmdbuf.bufsz -= sizeof(header);
 
                switch (header.header.cmd_type) {
-               case RADEON_CMD_PACKET: 
+               case RADEON_CMD_PACKET:
                        DRM_DEBUG("RADEON_CMD_PACKET\n");
-                       if (radeon_emit_packets( dev_priv, filp_priv, header, &cmdbuf )) {
+                       if (radeon_emit_packets
+                           (dev_priv, filp_priv, header, &cmdbuf)) {
                                DRM_ERROR("radeon_emit_packets failed\n");
                                goto err;
                        }
@@ -2814,7 +2800,7 @@ static int radeon_cp_cmdbuf( DRM_IOCTL_ARGS )
 
                case RADEON_CMD_SCALARS:
                        DRM_DEBUG("RADEON_CMD_SCALARS\n");
-                       if (radeon_emit_scalars( dev_priv, header, &cmdbuf )) {
+                       if (radeon_emit_scalars(dev_priv, header, &cmdbuf)) {
                                DRM_ERROR("radeon_emit_scalars failed\n");
                                goto err;
                        }
@@ -2822,7 +2808,7 @@ static int radeon_cp_cmdbuf( DRM_IOCTL_ARGS )
 
                case RADEON_CMD_VECTORS:
                        DRM_DEBUG("RADEON_CMD_VECTORS\n");
-                       if (radeon_emit_vectors( dev_priv, header, &cmdbuf )) {
+                       if (radeon_emit_vectors(dev_priv, header, &cmdbuf)) {
                                DRM_ERROR("radeon_emit_vectors failed\n");
                                goto err;
                        }
@@ -2831,25 +2817,25 @@ static int radeon_cp_cmdbuf( DRM_IOCTL_ARGS )
                case RADEON_CMD_DMA_DISCARD:
                        DRM_DEBUG("RADEON_CMD_DMA_DISCARD\n");
                        idx = header.dma.buf_idx;
-                       if ( idx < 0 || idx >= dma->buf_count ) {
-                               DRM_ERROR( "buffer index %d (of %d max)\n",
-                                          idx, dma->buf_count - 1 );
+                       if (idx < 0 || idx >= dma->buf_count) {
+                               DRM_ERROR("buffer index %d (of %d max)\n",
+                                         idx, dma->buf_count - 1);
                                goto err;
                        }
 
                        buf = dma->buflist[idx];
-                       if ( buf->filp != filp || buf->pending ) {
-                               DRM_ERROR( "bad buffer %p %p %d\n",
-                                          buf->filp, filp, buf->pending);
+                       if (buf->filp != filp || buf->pending) {
+                               DRM_ERROR("bad buffer %p %p %d\n",
+                                         buf->filp, filp, buf->pending);
                                goto err;
                        }
 
-                       radeon_cp_discard_buffer( dev, buf );
+                       radeon_cp_discard_buffer(dev, buf);
                        break;
 
                case RADEON_CMD_PACKET3:
                        DRM_DEBUG("RADEON_CMD_PACKET3\n");
-                       if (radeon_emit_packet3( dev, filp_priv, &cmdbuf )) {
+                       if (radeon_emit_packet3(dev, filp_priv, &cmdbuf)) {
                                DRM_ERROR("radeon_emit_packet3 failed\n");
                                goto err;
                        }
@@ -2857,7 +2843,8 @@ static int radeon_cp_cmdbuf( DRM_IOCTL_ARGS )
 
                case RADEON_CMD_PACKET3_CLIP:
                        DRM_DEBUG("RADEON_CMD_PACKET3_CLIP\n");
-                       if (radeon_emit_packet3_cliprect( dev, filp_priv, &cmdbuf, orig_nbox )) {
+                       if (radeon_emit_packet3_cliprect
+                           (dev, filp_priv, &cmdbuf, orig_nbox)) {
                                DRM_ERROR("radeon_emit_packet3_clip failed\n");
                                goto err;
                        }
@@ -2865,7 +2852,7 @@ static int radeon_cp_cmdbuf( DRM_IOCTL_ARGS )
 
                case RADEON_CMD_SCALARS2:
                        DRM_DEBUG("RADEON_CMD_SCALARS2\n");
-                       if (radeon_emit_scalars2( dev_priv, header, &cmdbuf )) {
+                       if (radeon_emit_scalars2(dev_priv, header, &cmdbuf)) {
                                DRM_ERROR("radeon_emit_scalars2 failed\n");
                                goto err;
                        }
@@ -2873,13 +2860,13 @@ static int radeon_cp_cmdbuf( DRM_IOCTL_ARGS )
 
                case RADEON_CMD_WAIT:
                        DRM_DEBUG("RADEON_CMD_WAIT\n");
-                       if (radeon_emit_wait( dev, header.wait.flags )) {
+                       if (radeon_emit_wait(dev, header.wait.flags)) {
                                DRM_ERROR("radeon_emit_wait failed\n");
                                goto err;
                        }
                        break;
                default:
-                       DRM_ERROR("bad cmd_type %d at %p\n", 
+                       DRM_ERROR("bad cmd_type %d at %p\n",
                                  header.header.cmd_type,
                                  cmdbuf.buf - sizeof(header));
                        goto err;
@@ -2893,45 +2880,38 @@ static int radeon_cp_cmdbuf( DRM_IOCTL_ARGS )
        COMMIT_RING();
        return 0;
 
-err:
+      err:
        if (orig_bufsz != 0)
                drm_free(kbuf, orig_bufsz, DRM_MEM_DRIVER);
        return DRM_ERR(EINVAL);
 }
 
-
-
-static int radeon_cp_getparam( DRM_IOCTL_ARGS )
+static int radeon_cp_getparam(DRM_IOCTL_ARGS)
 {
        DRM_DEVICE;
        drm_radeon_private_t *dev_priv = dev->dev_private;
        drm_radeon_getparam_t param;
        int value;
 
-       if ( !dev_priv ) {
-               DRM_ERROR( "%s called with no initialization\n", __FUNCTION__ );
-               return DRM_ERR(EINVAL);
-       }
-
-       DRM_COPY_FROM_USER_IOCTL( param, (drm_radeon_getparam_t __user *)data,
-                            sizeof(param) );
+       DRM_COPY_FROM_USER_IOCTL(param, (drm_radeon_getparam_t __user *) data,
+                                sizeof(param));
 
-       DRM_DEBUG( "pid=%d\n", DRM_CURRENTPID );
+       DRM_DEBUG("pid=%d\n", DRM_CURRENTPID);
 
-       switch( param.param ) {
+       switch (param.param) {
        case RADEON_PARAM_GART_BUFFER_OFFSET:
                value = dev_priv->gart_buffers_offset;
                break;
        case RADEON_PARAM_LAST_FRAME:
                dev_priv->stats.last_frame_reads++;
-               value = GET_SCRATCH( 0 );
+               value = GET_SCRATCH(0);
                break;
        case RADEON_PARAM_LAST_DISPATCH:
-               value = GET_SCRATCH( 1 );
+               value = GET_SCRATCH(1);
                break;
        case RADEON_PARAM_LAST_CLEAR:
                dev_priv->stats.last_clear_reads++;
-               value = GET_SCRATCH( 2 );
+               value = GET_SCRATCH(2);
                break;
        case RADEON_PARAM_IRQ_NR:
                value = dev->irq;
@@ -2940,21 +2920,21 @@ static int radeon_cp_getparam( DRM_IOCTL_ARGS )
                value = dev_priv->gart_vm_start;
                break;
        case RADEON_PARAM_REGISTER_HANDLE:
-               value = dev_priv->mmio_offset;
+               value = dev_priv->mmio->offset;
                break;
        case RADEON_PARAM_STATUS_HANDLE:
                value = dev_priv->ring_rptr_offset;
                break;
 #if BITS_PER_LONG == 32
-       /*
-        * This ioctl() doesn't work on 64-bit platforms because hw_lock is a
-        * pointer which can't fit into an int-sized variable.  According to
-        * Michel Dänzer, the ioctl() is only used on embedded platforms, so
-        * not supporting it shouldn't be a problem.  If the same functionality
-        * is needed on 64-bit platforms, a new ioctl() would have to be added,
-        * so backwards-compatibility for the embedded platforms can be
-        * maintained.  --davidm 4-Feb-2004.
-        */
+               /*
+                * This ioctl() doesn't work on 64-bit platforms because hw_lock is a
+                * pointer which can't fit into an int-sized variable.  According to
+                * Michel Dänzer, the ioctl() is only used on embedded platforms, so
+                * not supporting it shouldn't be a problem.  If the same functionality
+                * is needed on 64-bit platforms, a new ioctl() would have to be added,
+                * so backwards-compatibility for the embedded platforms can be
+                * maintained.  --davidm 4-Feb-2004.
+                */
        case RADEON_PARAM_SAREA_HANDLE:
                /* The lock is the first dword in the sarea. */
                value = (long)dev->lock.hw_lock;
@@ -2963,57 +2943,67 @@ static int radeon_cp_getparam( DRM_IOCTL_ARGS )
        case RADEON_PARAM_GART_TEX_HANDLE:
                value = dev_priv->gart_textures_offset;
                break;
+       
+       case RADEON_PARAM_CARD_TYPE:
+               if (dev_priv->flags & CHIP_IS_PCIE)
+                       value = RADEON_CARD_PCIE;
+               else if (dev_priv->flags & CHIP_IS_AGP)
+                       value = RADEON_CARD_AGP;
+               else
+                       value = RADEON_CARD_PCI;
+               break;
        default:
                return DRM_ERR(EINVAL);
        }
 
-       if ( DRM_COPY_TO_USER( param.value, &value, sizeof(int) ) ) {
-               DRM_ERROR( "copy_to_user\n" );
+       if (DRM_COPY_TO_USER(param.value, &value, sizeof(int))) {
+               DRM_ERROR("copy_to_user\n");
                return DRM_ERR(EFAULT);
        }
-       
+
        return 0;
 }
 
-static int radeon_cp_setparam( DRM_IOCTL_ARGS ) {
+static int radeon_cp_setparam(DRM_IOCTL_ARGS)
+{
        DRM_DEVICE;
        drm_radeon_private_t *dev_priv = dev->dev_private;
        drm_file_t *filp_priv;
        drm_radeon_setparam_t sp;
        struct drm_radeon_driver_file_fields *radeon_priv;
 
-       if ( !dev_priv ) {
-               DRM_ERROR( "%s called with no initialization\n", __FUNCTION__ );
-               return DRM_ERR( EINVAL );
-       }
-
-       DRM_GET_PRIV_WITH_RETURN( filp_priv, filp );
+       DRM_GET_PRIV_WITH_RETURN(filp_priv, filp);
 
-       DRM_COPY_FROM_USER_IOCTL( sp, ( drm_radeon_setparam_t __user * )data,
-                                 sizeof( sp ) );
+       DRM_COPY_FROM_USER_IOCTL(sp, (drm_radeon_setparam_t __user *) data,
+                                sizeof(sp));
 
-       switch( sp.param ) {
+       switch (sp.param) {
        case RADEON_SETPARAM_FB_LOCATION:
                radeon_priv = filp_priv->driver_priv;
                radeon_priv->radeon_fb_delta = dev_priv->fb_location - sp.value;
                break;
        case RADEON_SETPARAM_SWITCH_TILING:
                if (sp.value == 0) {
-                       DRM_DEBUG( "color tiling disabled\n" );
+                       DRM_DEBUG("color tiling disabled\n");
                        dev_priv->front_pitch_offset &= ~RADEON_DST_TILE_MACRO;
                        dev_priv->back_pitch_offset &= ~RADEON_DST_TILE_MACRO;
                        dev_priv->sarea_priv->tiling_enabled = 0;
-               }
-               else if (sp.value == 1) {
-                       DRM_DEBUG( "color tiling enabled\n" );
+               } else if (sp.value == 1) {
+                       DRM_DEBUG("color tiling enabled\n");
                        dev_priv->front_pitch_offset |= RADEON_DST_TILE_MACRO;
                        dev_priv->back_pitch_offset |= RADEON_DST_TILE_MACRO;
                        dev_priv->sarea_priv->tiling_enabled = 1;
                }
-               break;  
+               break;
+       case RADEON_SETPARAM_PCIGART_LOCATION:
+               dev_priv->pcigart_offset = sp.value;
+               break;
+       case RADEON_SETPARAM_NEW_MEMMAP:
+               dev_priv->new_memmap = sp.value;
+               break;
        default:
-               DRM_DEBUG( "Invalid parameter %d\n", sp.param );
-               return DRM_ERR( EINVAL );
+               DRM_DEBUG("Invalid parameter %d\n", sp.param);
+               return DRM_ERR(EINVAL);
        }
 
        return 0;
@@ -3022,81 +3012,86 @@ static int radeon_cp_setparam( DRM_IOCTL_ARGS ) {
 /* When a client dies:
  *    - Check for and clean up flipped page state
  *    - Free any alloced GART memory.
+ *    - Free any alloced radeon surfaces.
  *
  * DRM infrastructure takes care of reclaiming dma buffers.
  */
-void radeon_driver_prerelease(drm_device_t *dev, DRMFILE filp)
+void radeon_driver_preclose(drm_device_t * dev, DRMFILE filp)
 {
-       if ( dev->dev_private ) {                               
-               drm_radeon_private_t *dev_priv = dev->dev_private; 
-               if ( dev_priv->page_flipping ) {                
-                       radeon_do_cleanup_pageflip( dev );      
-               }                                               
-               radeon_mem_release( filp, dev_priv->gart_heap ); 
-               radeon_mem_release( filp, dev_priv->fb_heap );  
+       if (dev->dev_private) {
+               drm_radeon_private_t *dev_priv = dev->dev_private;
+               if (dev_priv->page_flipping) {
+                       radeon_do_cleanup_pageflip(dev);
+               }
+               radeon_mem_release(filp, dev_priv->gart_heap);
+               radeon_mem_release(filp, dev_priv->fb_heap);
                radeon_surfaces_release(filp, dev_priv);
-       }                               
+       }
 }
 
-void radeon_driver_pretakedown(drm_device_t *dev)
+void radeon_driver_lastclose(drm_device_t * dev)
 {
        radeon_do_release(dev);
 }
 
-int radeon_driver_open_helper(drm_device_t *dev, drm_file_t *filp_priv)
+int radeon_driver_open(drm_device_t * dev, drm_file_t * filp_priv)
 {
        drm_radeon_private_t *dev_priv = dev->dev_private;
        struct drm_radeon_driver_file_fields *radeon_priv;
-       
-       radeon_priv = (struct drm_radeon_driver_file_fields *)drm_alloc(sizeof(*radeon_priv), DRM_MEM_FILES);
-       
+
+       DRM_DEBUG("\n");
+       radeon_priv =
+           (struct drm_radeon_driver_file_fields *)
+           drm_alloc(sizeof(*radeon_priv), DRM_MEM_FILES);
+
        if (!radeon_priv)
                return -ENOMEM;
 
        filp_priv->driver_priv = radeon_priv;
-       if ( dev_priv )
+
+       if (dev_priv)
                radeon_priv->radeon_fb_delta = dev_priv->fb_location;
        else
                radeon_priv->radeon_fb_delta = 0;
        return 0;
 }
 
-
-void radeon_driver_free_filp_priv(drm_device_t *dev, drm_file_t *filp_priv)
+void radeon_driver_postclose(drm_device_t * dev, drm_file_t * filp_priv)
 {
-        struct drm_radeon_driver_file_fields *radeon_priv = filp_priv->driver_priv;
-        
-        drm_free(radeon_priv, sizeof(*radeon_priv), DRM_MEM_FILES);
+       struct drm_radeon_driver_file_fields *radeon_priv =
+           filp_priv->driver_priv;
+
+       drm_free(radeon_priv, sizeof(*radeon_priv), DRM_MEM_FILES);
 }
 
 drm_ioctl_desc_t radeon_ioctls[] = {
-       [DRM_IOCTL_NR(DRM_RADEON_CP_INIT)]    = { radeon_cp_init,      1, 1 },
-       [DRM_IOCTL_NR(DRM_RADEON_CP_START)]   = { radeon_cp_start,     1, 1 },
-       [DRM_IOCTL_NR(DRM_RADEON_CP_STOP)]    = { radeon_cp_stop,      1, 1 },
-       [DRM_IOCTL_NR(DRM_RADEON_CP_RESET)]   = { radeon_cp_reset,     1, 1 },
-       [DRM_IOCTL_NR(DRM_RADEON_CP_IDLE)]    = { radeon_cp_idle,      1, 0 },
-       [DRM_IOCTL_NR(DRM_RADEON_CP_RESUME)]  = { radeon_cp_resume,    1, 0 },
-       [DRM_IOCTL_NR(DRM_RADEON_RESET)]      = { radeon_engine_reset, 1, 0 },
-       [DRM_IOCTL_NR(DRM_RADEON_FULLSCREEN)] = { radeon_fullscreen,   1, 0 },
-       [DRM_IOCTL_NR(DRM_RADEON_SWAP)]       = { radeon_cp_swap,      1, 0 },
-       [DRM_IOCTL_NR(DRM_RADEON_CLEAR)]      = { radeon_cp_clear,     1, 0 },
-       [DRM_IOCTL_NR(DRM_RADEON_VERTEX)]     = { radeon_cp_vertex,    1, 0 },
-       [DRM_IOCTL_NR(DRM_RADEON_INDICES)]    = { radeon_cp_indices,   1, 0 },
-       [DRM_IOCTL_NR(DRM_RADEON_TEXTURE)]    = { radeon_cp_texture,   1, 0 },
-       [DRM_IOCTL_NR(DRM_RADEON_STIPPLE)]    = { radeon_cp_stipple,   1, 0 },
-       [DRM_IOCTL_NR(DRM_RADEON_INDIRECT)]   = { radeon_cp_indirect,  1, 1 },
-       [DRM_IOCTL_NR(DRM_RADEON_VERTEX2)]    = { radeon_cp_vertex2,   1, 0 },
-       [DRM_IOCTL_NR(DRM_RADEON_CMDBUF)]     = { radeon_cp_cmdbuf,    1, 0 },
-       [DRM_IOCTL_NR(DRM_RADEON_GETPARAM)]   = { radeon_cp_getparam,  1, 0 },
-       [DRM_IOCTL_NR(DRM_RADEON_FLIP)]       = { radeon_cp_flip,      1, 0 },
-       [DRM_IOCTL_NR(DRM_RADEON_ALLOC)]      = { radeon_mem_alloc,    1, 0 },
-       [DRM_IOCTL_NR(DRM_RADEON_FREE)]       = { radeon_mem_free,     1, 0 },
-       [DRM_IOCTL_NR(DRM_RADEON_INIT_HEAP)]  = { radeon_mem_init_heap,1, 1 },
-       [DRM_IOCTL_NR(DRM_RADEON_IRQ_EMIT)]   = { radeon_irq_emit,     1, 0 },
-       [DRM_IOCTL_NR(DRM_RADEON_IRQ_WAIT)]   = { radeon_irq_wait,     1, 0 },
-       [DRM_IOCTL_NR(DRM_RADEON_SETPARAM)]   = { radeon_cp_setparam,  1, 0 },
-       [DRM_IOCTL_NR(DRM_RADEON_SURF_ALLOC)] = { radeon_surface_alloc,1, 0 },
-       [DRM_IOCTL_NR(DRM_RADEON_SURF_FREE)]  = { radeon_surface_free, 1, 0 }
+       [DRM_IOCTL_NR(DRM_RADEON_CP_INIT)] = {radeon_cp_init, DRM_AUTH|DRM_MASTER|DRM_ROOT_ONLY},
+       [DRM_IOCTL_NR(DRM_RADEON_CP_START)] = {radeon_cp_start, DRM_AUTH|DRM_MASTER|DRM_ROOT_ONLY},
+       [DRM_IOCTL_NR(DRM_RADEON_CP_STOP)] = {radeon_cp_stop, DRM_AUTH|DRM_MASTER|DRM_ROOT_ONLY},
+       [DRM_IOCTL_NR(DRM_RADEON_CP_RESET)] = {radeon_cp_reset, DRM_AUTH|DRM_MASTER|DRM_ROOT_ONLY},
+       [DRM_IOCTL_NR(DRM_RADEON_CP_IDLE)] = {radeon_cp_idle, DRM_AUTH},
+       [DRM_IOCTL_NR(DRM_RADEON_CP_RESUME)] = {radeon_cp_resume, DRM_AUTH},
+       [DRM_IOCTL_NR(DRM_RADEON_RESET)] = {radeon_engine_reset, DRM_AUTH},
+       [DRM_IOCTL_NR(DRM_RADEON_FULLSCREEN)] = {radeon_fullscreen, DRM_AUTH},
+       [DRM_IOCTL_NR(DRM_RADEON_SWAP)] = {radeon_cp_swap, DRM_AUTH},
+       [DRM_IOCTL_NR(DRM_RADEON_CLEAR)] = {radeon_cp_clear, DRM_AUTH},
+       [DRM_IOCTL_NR(DRM_RADEON_VERTEX)] = {radeon_cp_vertex, DRM_AUTH},
+       [DRM_IOCTL_NR(DRM_RADEON_INDICES)] = {radeon_cp_indices, DRM_AUTH},
+       [DRM_IOCTL_NR(DRM_RADEON_TEXTURE)] = {radeon_cp_texture, DRM_AUTH},
+       [DRM_IOCTL_NR(DRM_RADEON_STIPPLE)] = {radeon_cp_stipple, DRM_AUTH},
+       [DRM_IOCTL_NR(DRM_RADEON_INDIRECT)] = {radeon_cp_indirect, DRM_AUTH|DRM_MASTER|DRM_ROOT_ONLY},
+       [DRM_IOCTL_NR(DRM_RADEON_VERTEX2)] = {radeon_cp_vertex2, DRM_AUTH},
+       [DRM_IOCTL_NR(DRM_RADEON_CMDBUF)] = {radeon_cp_cmdbuf, DRM_AUTH},
+       [DRM_IOCTL_NR(DRM_RADEON_GETPARAM)] = {radeon_cp_getparam, DRM_AUTH},
+       [DRM_IOCTL_NR(DRM_RADEON_FLIP)] = {radeon_cp_flip, DRM_AUTH},
+       [DRM_IOCTL_NR(DRM_RADEON_ALLOC)] = {radeon_mem_alloc, DRM_AUTH},
+       [DRM_IOCTL_NR(DRM_RADEON_FREE)] = {radeon_mem_free, DRM_AUTH},
+       [DRM_IOCTL_NR(DRM_RADEON_INIT_HEAP)] = {radeon_mem_init_heap, DRM_AUTH|DRM_MASTER|DRM_ROOT_ONLY},
+       [DRM_IOCTL_NR(DRM_RADEON_IRQ_EMIT)] = {radeon_irq_emit, DRM_AUTH},
+       [DRM_IOCTL_NR(DRM_RADEON_IRQ_WAIT)] = {radeon_irq_wait, DRM_AUTH},
+       [DRM_IOCTL_NR(DRM_RADEON_SETPARAM)] = {radeon_cp_setparam, DRM_AUTH},
+       [DRM_IOCTL_NR(DRM_RADEON_SURF_ALLOC)] = {radeon_surface_alloc, DRM_AUTH},
+       [DRM_IOCTL_NR(DRM_RADEON_SURF_FREE)] = {radeon_surface_free, DRM_AUTH}
 };
 
 int radeon_max_ioctl = DRM_ARRAY_SIZE(radeon_ioctls);