linux 2.6.16.38 w/ vs2.0.3-rc1
[linux-2.6.git] / drivers / hwmon / w83792d.c
index 7576ec9..a2f6bb6 100644 (file)
@@ -35,6 +35,7 @@
     w83792d    9       7       7       3       0x7a    0x5ca3  yes     no
 */
 
+#include <linux/config.h>
 #include <linux/module.h>
 #include <linux/init.h>
 #include <linux/slab.h>
@@ -42,7 +43,6 @@
 #include <linux/hwmon.h>
 #include <linux/hwmon-sysfs.h>
 #include <linux/err.h>
-#include <linux/mutex.h>
 
 /* Addresses to scan */
 static unsigned short normal_i2c[] = { 0x2c, 0x2d, 0x2e, 0x2f, I2C_CLIENT_END };
@@ -249,6 +249,8 @@ FAN_TO_REG(long rpm, int div)
                        : (val)) / 1000, 0, 0xff))
 #define TEMP_ADD_TO_REG_LOW(val)       ((val%1000) ? 0x80 : 0x00)
 
+#define PWM_FROM_REG(val)              (val)
+#define PWM_TO_REG(val)                        (SENSORS_LIMIT((val),0,255))
 #define DIV_FROM_REG(val)              (1 << (val))
 
 static inline u8
@@ -269,7 +271,7 @@ struct w83792d_data {
        struct class_device *class_dev;
        enum chips type;
 
-       struct mutex update_lock;
+       struct semaphore update_lock;
        char valid;             /* !=0 if following fields are valid */
        unsigned long last_updated;     /* In jiffies */
 
@@ -288,6 +290,7 @@ struct w83792d_data {
        u8 pwm[7];              /* We only consider the first 3 set of pwm,
                                   although 792 chip has 7 set of pwm. */
        u8 pwmenable[3];
+       u8 pwm_mode[7];         /* indicates PWM or DC mode: 1->PWM; 0->DC */
        u32 alarms;             /* realtime status register encoding,combined */
        u8 chassis;             /* Chassis status */
        u8 chassis_clear;       /* CLR_CHS, clear chassis intrusion detection */
@@ -371,50 +374,38 @@ static ssize_t store_in_##reg (struct device *dev, \
        u32 val; \
         \
        val = simple_strtoul(buf, NULL, 10); \
-       mutex_lock(&data->update_lock); \
        data->in_##reg[nr] = SENSORS_LIMIT(IN_TO_REG(nr, val)/4, 0, 255); \
        w83792d_write_value(client, W83792D_REG_IN_##REG[nr], data->in_##reg[nr]); \
-       mutex_unlock(&data->update_lock); \
         \
        return count; \
 }
 store_in_reg(MIN, min);
 store_in_reg(MAX, max);
 
-static struct sensor_device_attribute sda_in_input[] = {
-       SENSOR_ATTR(in0_input, S_IRUGO, show_in, NULL, 0),
-       SENSOR_ATTR(in1_input, S_IRUGO, show_in, NULL, 1),
-       SENSOR_ATTR(in2_input, S_IRUGO, show_in, NULL, 2),
-       SENSOR_ATTR(in3_input, S_IRUGO, show_in, NULL, 3),
-       SENSOR_ATTR(in4_input, S_IRUGO, show_in, NULL, 4),
-       SENSOR_ATTR(in5_input, S_IRUGO, show_in, NULL, 5),
-       SENSOR_ATTR(in6_input, S_IRUGO, show_in, NULL, 6),
-       SENSOR_ATTR(in7_input, S_IRUGO, show_in, NULL, 7),
-       SENSOR_ATTR(in8_input, S_IRUGO, show_in, NULL, 8),
-};
-static struct sensor_device_attribute sda_in_min[] = {
-       SENSOR_ATTR(in0_min, S_IWUSR | S_IRUGO, show_in_min, store_in_min, 0),
-       SENSOR_ATTR(in1_min, S_IWUSR | S_IRUGO, show_in_min, store_in_min, 1),
-       SENSOR_ATTR(in2_min, S_IWUSR | S_IRUGO, show_in_min, store_in_min, 2),
-       SENSOR_ATTR(in3_min, S_IWUSR | S_IRUGO, show_in_min, store_in_min, 3),
-       SENSOR_ATTR(in4_min, S_IWUSR | S_IRUGO, show_in_min, store_in_min, 4),
-       SENSOR_ATTR(in5_min, S_IWUSR | S_IRUGO, show_in_min, store_in_min, 5),
-       SENSOR_ATTR(in6_min, S_IWUSR | S_IRUGO, show_in_min, store_in_min, 6),
-       SENSOR_ATTR(in7_min, S_IWUSR | S_IRUGO, show_in_min, store_in_min, 7),
-       SENSOR_ATTR(in8_min, S_IWUSR | S_IRUGO, show_in_min, store_in_min, 8),
-};
-static struct sensor_device_attribute sda_in_max[] = {
-       SENSOR_ATTR(in0_max, S_IWUSR | S_IRUGO, show_in_max, store_in_max, 0),
-       SENSOR_ATTR(in1_max, S_IWUSR | S_IRUGO, show_in_max, store_in_max, 1),
-       SENSOR_ATTR(in2_max, S_IWUSR | S_IRUGO, show_in_max, store_in_max, 2),
-       SENSOR_ATTR(in3_max, S_IWUSR | S_IRUGO, show_in_max, store_in_max, 3),
-       SENSOR_ATTR(in4_max, S_IWUSR | S_IRUGO, show_in_max, store_in_max, 4),
-       SENSOR_ATTR(in5_max, S_IWUSR | S_IRUGO, show_in_max, store_in_max, 5),
-       SENSOR_ATTR(in6_max, S_IWUSR | S_IRUGO, show_in_max, store_in_max, 6),
-       SENSOR_ATTR(in7_max, S_IWUSR | S_IRUGO, show_in_max, store_in_max, 7),
-       SENSOR_ATTR(in8_max, S_IWUSR | S_IRUGO, show_in_max, store_in_max, 8),
-};
-
+#define sysfs_in_reg(offset) \
+static SENSOR_DEVICE_ATTR(in##offset##_input, S_IRUGO, show_in, \
+                               NULL, offset); \
+static SENSOR_DEVICE_ATTR(in##offset##_min, S_IRUGO | S_IWUSR, \
+                               show_in_min, store_in_min, offset); \
+static SENSOR_DEVICE_ATTR(in##offset##_max, S_IRUGO | S_IWUSR, \
+                               show_in_max, store_in_max, offset);
+
+sysfs_in_reg(0);
+sysfs_in_reg(1);
+sysfs_in_reg(2);
+sysfs_in_reg(3);
+sysfs_in_reg(4);
+sysfs_in_reg(5);
+sysfs_in_reg(6);
+sysfs_in_reg(7);
+sysfs_in_reg(8);
+
+#define device_create_file_in(client, offset) \
+do { \
+device_create_file(&client->dev, &sensor_dev_attr_in##offset##_input.dev_attr); \
+device_create_file(&client->dev, &sensor_dev_attr_in##offset##_max.dev_attr); \
+device_create_file(&client->dev, &sensor_dev_attr_in##offset##_min.dev_attr); \
+} while (0)
 
 #define show_fan_reg(reg) \
 static ssize_t show_##reg (struct device *dev, struct device_attribute *attr, \
@@ -441,11 +432,9 @@ store_fan_min(struct device *dev, struct device_attribute *attr,
        u32 val;
 
        val = simple_strtoul(buf, NULL, 10);
-       mutex_lock(&data->update_lock);
        data->fan_min[nr] = FAN_TO_REG(val, DIV_FROM_REG(data->fan_div[nr]));
        w83792d_write_value(client, W83792D_REG_FAN_MIN[nr],
                                data->fan_min[nr]);
-       mutex_unlock(&data->update_lock);
 
        return count;
 }
@@ -462,7 +451,7 @@ show_fan_div(struct device *dev, struct device_attribute *attr,
 
 /* Note: we save and restore the fan minimum here, because its value is
    determined in part by the fan divisor.  This follows the principle of
-   least surprise; the user doesn't expect the fan minimum to change just
+   least suprise; the user doesn't expect the fan minimum to change just
    because the divisor changed. */
 static ssize_t
 store_fan_div(struct device *dev, struct device_attribute *attr,
@@ -478,7 +467,6 @@ store_fan_div(struct device *dev, struct device_attribute *attr,
        u8 tmp_fan_div;
 
        /* Save fan_min */
-       mutex_lock(&data->update_lock);
        min = FAN_FROM_REG(data->fan_min[nr],
                           DIV_FROM_REG(data->fan_div[nr]));
 
@@ -494,38 +482,32 @@ store_fan_div(struct device *dev, struct device_attribute *attr,
        /* Restore fan_min */
        data->fan_min[nr] = FAN_TO_REG(min, DIV_FROM_REG(data->fan_div[nr]));
        w83792d_write_value(client, W83792D_REG_FAN_MIN[nr], data->fan_min[nr]);
-       mutex_unlock(&data->update_lock);
 
        return count;
 }
 
-static struct sensor_device_attribute sda_fan_input[] = {
-       SENSOR_ATTR(fan1_input, S_IRUGO, show_fan, NULL, 1),
-       SENSOR_ATTR(fan2_input, S_IRUGO, show_fan, NULL, 2),
-       SENSOR_ATTR(fan3_input, S_IRUGO, show_fan, NULL, 3),
-       SENSOR_ATTR(fan4_input, S_IRUGO, show_fan, NULL, 4),
-       SENSOR_ATTR(fan5_input, S_IRUGO, show_fan, NULL, 5),
-       SENSOR_ATTR(fan6_input, S_IRUGO, show_fan, NULL, 6),
-       SENSOR_ATTR(fan7_input, S_IRUGO, show_fan, NULL, 7),
-};
-static struct sensor_device_attribute sda_fan_min[] = {
-       SENSOR_ATTR(fan1_min, S_IWUSR | S_IRUGO, show_fan_min, store_fan_min, 1),
-       SENSOR_ATTR(fan2_min, S_IWUSR | S_IRUGO, show_fan_min, store_fan_min, 2),
-       SENSOR_ATTR(fan3_min, S_IWUSR | S_IRUGO, show_fan_min, store_fan_min, 3),
-       SENSOR_ATTR(fan4_min, S_IWUSR | S_IRUGO, show_fan_min, store_fan_min, 4),
-       SENSOR_ATTR(fan5_min, S_IWUSR | S_IRUGO, show_fan_min, store_fan_min, 5),
-       SENSOR_ATTR(fan6_min, S_IWUSR | S_IRUGO, show_fan_min, store_fan_min, 6),
-       SENSOR_ATTR(fan7_min, S_IWUSR | S_IRUGO, show_fan_min, store_fan_min, 7),
-};
-static struct sensor_device_attribute sda_fan_div[] = {
-       SENSOR_ATTR(fan1_div, S_IWUSR | S_IRUGO, show_fan_div, store_fan_div, 1),
-       SENSOR_ATTR(fan2_div, S_IWUSR | S_IRUGO, show_fan_div, store_fan_div, 2),
-       SENSOR_ATTR(fan3_div, S_IWUSR | S_IRUGO, show_fan_div, store_fan_div, 3),
-       SENSOR_ATTR(fan4_div, S_IWUSR | S_IRUGO, show_fan_div, store_fan_div, 4),
-       SENSOR_ATTR(fan5_div, S_IWUSR | S_IRUGO, show_fan_div, store_fan_div, 5),
-       SENSOR_ATTR(fan6_div, S_IWUSR | S_IRUGO, show_fan_div, store_fan_div, 6),
-       SENSOR_ATTR(fan7_div, S_IWUSR | S_IRUGO, show_fan_div, store_fan_div, 7),
-};
+#define sysfs_fan(offset) \
+static SENSOR_DEVICE_ATTR(fan##offset##_input, S_IRUGO, show_fan, NULL, \
+                               offset); \
+static SENSOR_DEVICE_ATTR(fan##offset##_div, S_IRUGO | S_IWUSR, \
+                               show_fan_div, store_fan_div, offset); \
+static SENSOR_DEVICE_ATTR(fan##offset##_min, S_IRUGO | S_IWUSR, \
+                               show_fan_min, store_fan_min, offset);
+
+sysfs_fan(1);
+sysfs_fan(2);
+sysfs_fan(3);
+sysfs_fan(4);
+sysfs_fan(5);
+sysfs_fan(6);
+sysfs_fan(7);
+
+#define device_create_file_fan(client, offset) \
+do { \
+device_create_file(&client->dev, &sensor_dev_attr_fan##offset##_input.dev_attr); \
+device_create_file(&client->dev, &sensor_dev_attr_fan##offset##_div.dev_attr); \
+device_create_file(&client->dev, &sensor_dev_attr_fan##offset##_min.dev_attr); \
+} while (0)
 
 
 /* read/write the temperature1, includes measured value and limits */
@@ -549,15 +531,29 @@ static ssize_t store_temp1(struct device *dev, struct device_attribute *attr,
        s32 val;
 
        val = simple_strtol(buf, NULL, 10);
-       mutex_lock(&data->update_lock);
+
        data->temp1[nr] = TEMP1_TO_REG(val);
        w83792d_write_value(client, W83792D_REG_TEMP1[nr],
                data->temp1[nr]);
-       mutex_unlock(&data->update_lock);
 
        return count;
 }
 
+
+static SENSOR_DEVICE_ATTR(temp1_input, S_IRUGO, show_temp1, NULL, 0);
+static SENSOR_DEVICE_ATTR(temp1_max, S_IRUGO | S_IWUSR, show_temp1,
+                               store_temp1, 1);
+static SENSOR_DEVICE_ATTR(temp1_max_hyst, S_IRUGO | S_IWUSR, show_temp1,
+                               store_temp1, 2);
+
+#define device_create_file_temp1(client) \
+do { \
+device_create_file(&client->dev, &sensor_dev_attr_temp1_input.dev_attr); \
+device_create_file(&client->dev, &sensor_dev_attr_temp1_max.dev_attr); \
+device_create_file(&client->dev, &sensor_dev_attr_temp1_max_hyst.dev_attr); \
+} while (0)
+
+
 /* read/write the temperature2-3, includes measured value and limits */
 
 static ssize_t show_temp23(struct device *dev, struct device_attribute *attr,
@@ -583,35 +579,36 @@ static ssize_t store_temp23(struct device *dev, struct device_attribute *attr,
        s32 val;
 
        val = simple_strtol(buf, NULL, 10);
-       mutex_lock(&data->update_lock);
+
        data->temp_add[nr][index] = TEMP_ADD_TO_REG_HIGH(val);
        data->temp_add[nr][index+1] = TEMP_ADD_TO_REG_LOW(val);
        w83792d_write_value(client, W83792D_REG_TEMP_ADD[nr][index],
                data->temp_add[nr][index]);
        w83792d_write_value(client, W83792D_REG_TEMP_ADD[nr][index+1],
                data->temp_add[nr][index+1]);
-       mutex_unlock(&data->update_lock);
 
        return count;
 }
 
-static struct sensor_device_attribute_2 sda_temp_input[] = {
-       SENSOR_ATTR_2(temp1_input, S_IRUGO, show_temp1, NULL, 0, 0),
-       SENSOR_ATTR_2(temp2_input, S_IRUGO, show_temp23, NULL, 0, 0),
-       SENSOR_ATTR_2(temp3_input, S_IRUGO, show_temp23, NULL, 1, 0),
-};
+#define sysfs_temp23(name,idx) \
+static SENSOR_DEVICE_ATTR_2(name##_input, S_IRUGO, show_temp23, NULL, \
+                               idx, 0); \
+static SENSOR_DEVICE_ATTR_2(name##_max, S_IRUGO | S_IWUSR, \
+                               show_temp23, store_temp23, idx, 2); \
+static SENSOR_DEVICE_ATTR_2(name##_max_hyst, S_IRUGO | S_IWUSR, \
+                               show_temp23, store_temp23, idx, 4);
 
-static struct sensor_device_attribute_2 sda_temp_max[] = {
-       SENSOR_ATTR_2(temp1_max, S_IRUGO | S_IWUSR, show_temp1, store_temp1, 0, 1),
-       SENSOR_ATTR_2(temp2_max, S_IRUGO | S_IWUSR, show_temp23, store_temp23, 0, 2),
-       SENSOR_ATTR_2(temp3_max, S_IRUGO | S_IWUSR, show_temp23, store_temp23, 1, 2),
-};
+sysfs_temp23(temp2,0)
+sysfs_temp23(temp3,1)
+
+#define device_create_file_temp_add(client, offset) \
+do { \
+device_create_file(&client->dev, &sensor_dev_attr_temp##offset##_input.dev_attr); \
+device_create_file(&client->dev, &sensor_dev_attr_temp##offset##_max.dev_attr); \
+device_create_file(&client->dev, \
+&sensor_dev_attr_temp##offset##_max_hyst.dev_attr); \
+} while (0)
 
-static struct sensor_device_attribute_2 sda_temp_max_hyst[] = {
-       SENSOR_ATTR_2(temp1_max_hyst, S_IRUGO | S_IWUSR, show_temp1, store_temp1, 0, 2),
-       SENSOR_ATTR_2(temp2_max_hyst, S_IRUGO | S_IWUSR, show_temp23, store_temp23, 0, 4),
-       SENSOR_ATTR_2(temp3_max_hyst, S_IRUGO | S_IWUSR, show_temp23, store_temp23, 1, 4),
-};
 
 /* get reatime status of all sensors items: voltage, temp, fan */
 static ssize_t
@@ -623,6 +620,10 @@ show_alarms_reg(struct device *dev, struct device_attribute *attr, char *buf)
 
 static
 DEVICE_ATTR(alarms, S_IRUGO, show_alarms_reg, NULL);
+#define device_create_file_alarms(client) \
+device_create_file(&client->dev, &dev_attr_alarms);
+
+
 
 static ssize_t
 show_pwm(struct device *dev, struct device_attribute *attr,
@@ -631,7 +632,7 @@ show_pwm(struct device *dev, struct device_attribute *attr,
        struct sensor_device_attribute *sensor_attr = to_sensor_dev_attr(attr);
        int nr = sensor_attr->index;
        struct w83792d_data *data = w83792d_update_device(dev);
-       return sprintf(buf, "%d\n", (data->pwm[nr] & 0x0f) << 4);
+       return sprintf(buf, "%ld\n", (long) PWM_FROM_REG(data->pwm[nr-1]));
 }
 
 static ssize_t
@@ -663,16 +664,14 @@ store_pwm(struct device *dev, struct device_attribute *attr,
                const char *buf, size_t count)
 {
        struct sensor_device_attribute *sensor_attr = to_sensor_dev_attr(attr);
-       int nr = sensor_attr->index;
+       int nr = sensor_attr->index - 1;
        struct i2c_client *client = to_i2c_client(dev);
        struct w83792d_data *data = i2c_get_clientdata(client);
-       u8 val = SENSORS_LIMIT(simple_strtoul(buf, NULL, 10), 0, 255) >> 4;
+       u32 val;
 
-       mutex_lock(&data->update_lock);
-       val |= w83792d_read_value(client, W83792D_REG_PWM[nr]) & 0xf0;
-       data->pwm[nr] = val;
+       val = simple_strtoul(buf, NULL, 10);
+       data->pwm[nr] = PWM_TO_REG(val);
        w83792d_write_value(client, W83792D_REG_PWM[nr], data->pwm[nr]);
-       mutex_unlock(&data->update_lock);
 
        return count;
 }
@@ -689,10 +688,6 @@ store_pwmenable(struct device *dev, struct device_attribute *attr,
        u8 fan_cfg_tmp, cfg1_tmp, cfg2_tmp, cfg3_tmp, cfg4_tmp;
 
        val = simple_strtoul(buf, NULL, 10);
-       if (val < 1 || val > 3)
-               return -EINVAL;
-
-       mutex_lock(&data->update_lock);
        switch (val) {
        case 1:
                data->pwmenable[nr] = 0; /* manual mode */
@@ -703,6 +698,8 @@ store_pwmenable(struct device *dev, struct device_attribute *attr,
        case 3:
                data->pwmenable[nr] = 1; /* thermal cruise/Smart Fan I */
                break;
+       default:
+               return -EINVAL;
        }
        cfg1_tmp = data->pwmenable[0];
        cfg2_tmp = (data->pwmenable[1]) << 2;
@@ -710,24 +707,30 @@ store_pwmenable(struct device *dev, struct device_attribute *attr,
        cfg4_tmp = w83792d_read_value(client,W83792D_REG_FAN_CFG) & 0xc0;
        fan_cfg_tmp = ((cfg4_tmp | cfg3_tmp) | cfg2_tmp) | cfg1_tmp;
        w83792d_write_value(client, W83792D_REG_FAN_CFG, fan_cfg_tmp);
-       mutex_unlock(&data->update_lock);
 
        return count;
 }
 
-static struct sensor_device_attribute sda_pwm[] = {
-       SENSOR_ATTR(pwm1, S_IWUSR | S_IRUGO, show_pwm, store_pwm, 0),
-       SENSOR_ATTR(pwm2, S_IWUSR | S_IRUGO, show_pwm, store_pwm, 1),
-       SENSOR_ATTR(pwm3, S_IWUSR | S_IRUGO, show_pwm, store_pwm, 2),
-};
-static struct sensor_device_attribute sda_pwm_enable[] = {
-       SENSOR_ATTR(pwm1_enable, S_IWUSR | S_IRUGO,
-                   show_pwmenable, store_pwmenable, 1),
-       SENSOR_ATTR(pwm2_enable, S_IWUSR | S_IRUGO,
-                   show_pwmenable, store_pwmenable, 2),
-       SENSOR_ATTR(pwm3_enable, S_IWUSR | S_IRUGO,
-                   show_pwmenable, store_pwmenable, 3),
-};
+#define sysfs_pwm(offset) \
+static SENSOR_DEVICE_ATTR(pwm##offset, S_IRUGO | S_IWUSR, \
+                               show_pwm, store_pwm, offset); \
+static SENSOR_DEVICE_ATTR(pwm##offset##_enable, S_IRUGO | S_IWUSR, \
+                               show_pwmenable, store_pwmenable, offset); \
+
+sysfs_pwm(1);
+sysfs_pwm(2);
+sysfs_pwm(3);
+
+
+#define device_create_file_pwm(client, offset) \
+do { \
+device_create_file(&client->dev, &sensor_dev_attr_pwm##offset.dev_attr); \
+} while (0)
+
+#define device_create_file_pwmenable(client, offset) \
+do { \
+device_create_file(&client->dev, &sensor_dev_attr_pwm##offset##_enable.dev_attr); \
+} while (0)
 
 
 static ssize_t
@@ -737,7 +740,7 @@ show_pwm_mode(struct device *dev, struct device_attribute *attr,
        struct sensor_device_attribute *sensor_attr = to_sensor_dev_attr(attr);
        int nr = sensor_attr->index;
        struct w83792d_data *data = w83792d_update_device(dev);
-       return sprintf(buf, "%d\n", data->pwm[nr] >> 7);
+       return sprintf(buf, "%d\n", data->pwm_mode[nr-1]);
 }
 
 static ssize_t
@@ -745,36 +748,34 @@ store_pwm_mode(struct device *dev, struct device_attribute *attr,
                        const char *buf, size_t count)
 {
        struct sensor_device_attribute *sensor_attr = to_sensor_dev_attr(attr);
-       int nr = sensor_attr->index;
+       int nr = sensor_attr->index - 1;
        struct i2c_client *client = to_i2c_client(dev);
        struct w83792d_data *data = i2c_get_clientdata(client);
        u32 val;
+       u8 pwm_mode_mask = 0;
 
        val = simple_strtoul(buf, NULL, 10);
-       if (val != 0 && val != 1)
-               return -EINVAL;
-
-       mutex_lock(&data->update_lock);
-       data->pwm[nr] = w83792d_read_value(client, W83792D_REG_PWM[nr]);
-       if (val) {                      /* PWM mode */
-               data->pwm[nr] |= 0x80;
-       } else {                        /* DC mode */
-               data->pwm[nr] &= 0x7f;
-       }
-       w83792d_write_value(client, W83792D_REG_PWM[nr], data->pwm[nr]);
-       mutex_unlock(&data->update_lock);
+       data->pwm_mode[nr] = SENSORS_LIMIT(val, 0, 1);
+       pwm_mode_mask = w83792d_read_value(client,
+               W83792D_REG_PWM[nr]) & 0x7f;
+       w83792d_write_value(client, W83792D_REG_PWM[nr],
+               ((data->pwm_mode[nr]) << 7) | pwm_mode_mask);
 
        return count;
 }
 
-static struct sensor_device_attribute sda_pwm_mode[] = {
-       SENSOR_ATTR(pwm1_mode, S_IWUSR | S_IRUGO,
-                   show_pwm_mode, store_pwm_mode, 0),
-       SENSOR_ATTR(pwm2_mode, S_IWUSR | S_IRUGO,
-                   show_pwm_mode, store_pwm_mode, 1),
-       SENSOR_ATTR(pwm3_mode, S_IWUSR | S_IRUGO,
-                   show_pwm_mode, store_pwm_mode, 2),
-};
+#define sysfs_pwm_mode(offset) \
+static SENSOR_DEVICE_ATTR(pwm##offset##_mode, S_IRUGO | S_IWUSR, \
+                               show_pwm_mode, store_pwm_mode, offset);
+
+sysfs_pwm_mode(1);
+sysfs_pwm_mode(2);
+sysfs_pwm_mode(3);
+
+#define device_create_file_pwm_mode(client, offset) \
+do { \
+device_create_file(&client->dev, &sensor_dev_attr_pwm##offset##_mode.dev_attr); \
+} while (0)
 
 
 static ssize_t
@@ -787,6 +788,12 @@ show_regs_chassis(struct device *dev, struct device_attribute *attr,
 
 static DEVICE_ATTR(chassis, S_IRUGO, show_regs_chassis, NULL);
 
+#define device_create_file_chassis(client) \
+do { \
+device_create_file(&client->dev, &dev_attr_chassis); \
+} while (0)
+
+
 static ssize_t
 show_chassis_clear(struct device *dev, struct device_attribute *attr, char *buf)
 {
@@ -804,13 +811,12 @@ store_chassis_clear(struct device *dev, struct device_attribute *attr,
        u8 temp1 = 0, temp2 = 0;
 
        val = simple_strtoul(buf, NULL, 10);
-       mutex_lock(&data->update_lock);
+
        data->chassis_clear = SENSORS_LIMIT(val, 0 ,1);
        temp1 = ((data->chassis_clear) << 7) & 0x80;
        temp2 = w83792d_read_value(client,
                W83792D_REG_CHASSIS_CLR) & 0x7f;
        w83792d_write_value(client, W83792D_REG_CHASSIS_CLR, temp1 | temp2);
-       mutex_unlock(&data->update_lock);
 
        return count;
 }
@@ -818,6 +824,13 @@ store_chassis_clear(struct device *dev, struct device_attribute *attr,
 static DEVICE_ATTR(chassis_clear, S_IRUGO | S_IWUSR,
                show_chassis_clear, store_chassis_clear);
 
+#define device_create_file_chassis_clear(client) \
+do { \
+device_create_file(&client->dev, &dev_attr_chassis_clear); \
+} while (0)
+
+
+
 /* For Smart Fan I / Thermal Cruise */
 static ssize_t
 show_thermal_cruise(struct device *dev, struct device_attribute *attr,
@@ -843,24 +856,28 @@ store_thermal_cruise(struct device *dev, struct device_attribute *attr,
        val = simple_strtoul(buf, NULL, 10);
        target_tmp = val;
        target_tmp = target_tmp & 0x7f;
-       mutex_lock(&data->update_lock);
        target_mask = w83792d_read_value(client, W83792D_REG_THERMAL[nr]) & 0x80;
        data->thermal_cruise[nr] = SENSORS_LIMIT(target_tmp, 0, 255);
        w83792d_write_value(client, W83792D_REG_THERMAL[nr],
                (data->thermal_cruise[nr]) | target_mask);
-       mutex_unlock(&data->update_lock);
 
        return count;
 }
 
-static struct sensor_device_attribute sda_thermal_cruise[] = {
-       SENSOR_ATTR(thermal_cruise1, S_IWUSR | S_IRUGO,
-                   show_thermal_cruise, store_thermal_cruise, 1),
-       SENSOR_ATTR(thermal_cruise2, S_IWUSR | S_IRUGO,
-                   show_thermal_cruise, store_thermal_cruise, 2),
-       SENSOR_ATTR(thermal_cruise3, S_IWUSR | S_IRUGO,
-                   show_thermal_cruise, store_thermal_cruise, 3),
-};
+#define sysfs_thermal_cruise(offset) \
+static SENSOR_DEVICE_ATTR(thermal_cruise##offset, S_IRUGO | S_IWUSR, \
+                       show_thermal_cruise, store_thermal_cruise, offset);
+
+sysfs_thermal_cruise(1);
+sysfs_thermal_cruise(2);
+sysfs_thermal_cruise(3);
+
+#define device_create_file_thermal_cruise(client, offset) \
+do { \
+device_create_file(&client->dev, \
+&sensor_dev_attr_thermal_cruise##offset.dev_attr); \
+} while (0)
+
 
 /* For Smart Fan I/Thermal Cruise and Smart Fan II */
 static ssize_t
@@ -885,7 +902,6 @@ store_tolerance(struct device *dev, struct device_attribute *attr,
        u8 tol_tmp, tol_mask;
 
        val = simple_strtoul(buf, NULL, 10);
-       mutex_lock(&data->update_lock);
        tol_mask = w83792d_read_value(client,
                W83792D_REG_TOLERANCE[nr]) & ((nr == 1) ? 0x0f : 0xf0);
        tol_tmp = SENSORS_LIMIT(val, 0, 15);
@@ -896,19 +912,23 @@ store_tolerance(struct device *dev, struct device_attribute *attr,
        }
        w83792d_write_value(client, W83792D_REG_TOLERANCE[nr],
                tol_mask | tol_tmp);
-       mutex_unlock(&data->update_lock);
 
        return count;
 }
 
-static struct sensor_device_attribute sda_tolerance[] = {
-       SENSOR_ATTR(tolerance1, S_IWUSR | S_IRUGO,
-                   show_tolerance, store_tolerance, 1),
-       SENSOR_ATTR(tolerance2, S_IWUSR | S_IRUGO,
-                   show_tolerance, store_tolerance, 2),
-       SENSOR_ATTR(tolerance3, S_IWUSR | S_IRUGO,
-                   show_tolerance, store_tolerance, 3),
-};
+#define sysfs_tolerance(offset) \
+static SENSOR_DEVICE_ATTR(tolerance##offset, S_IRUGO | S_IWUSR, \
+                               show_tolerance, store_tolerance, offset);
+
+sysfs_tolerance(1);
+sysfs_tolerance(2);
+sysfs_tolerance(3);
+
+#define device_create_file_tolerance(client, offset) \
+do { \
+device_create_file(&client->dev, &sensor_dev_attr_tolerance##offset.dev_attr); \
+} while (0)
+
 
 /* For Smart Fan II */
 static ssize_t
@@ -935,45 +955,37 @@ store_sf2_point(struct device *dev, struct device_attribute *attr,
        u8 mask_tmp = 0;
 
        val = simple_strtoul(buf, NULL, 10);
-       mutex_lock(&data->update_lock);
        data->sf2_points[index][nr] = SENSORS_LIMIT(val, 0, 127);
        mask_tmp = w83792d_read_value(client,
                                        W83792D_REG_POINTS[index][nr]) & 0x80;
        w83792d_write_value(client, W83792D_REG_POINTS[index][nr],
                mask_tmp|data->sf2_points[index][nr]);
-       mutex_unlock(&data->update_lock);
 
        return count;
 }
 
-static struct sensor_device_attribute_2 sda_sf2_point[] = {
-       SENSOR_ATTR_2(sf2_point1_fan1, S_IRUGO | S_IWUSR,
-                     show_sf2_point, store_sf2_point, 1, 1),
-       SENSOR_ATTR_2(sf2_point2_fan1, S_IRUGO | S_IWUSR,
-                     show_sf2_point, store_sf2_point, 2, 1),
-       SENSOR_ATTR_2(sf2_point3_fan1, S_IRUGO | S_IWUSR,
-                     show_sf2_point, store_sf2_point, 3, 1),
-       SENSOR_ATTR_2(sf2_point4_fan1, S_IRUGO | S_IWUSR,
-                     show_sf2_point, store_sf2_point, 4, 1),
-
-       SENSOR_ATTR_2(sf2_point1_fan2, S_IRUGO | S_IWUSR,
-                     show_sf2_point, store_sf2_point, 1, 2),
-       SENSOR_ATTR_2(sf2_point2_fan2, S_IRUGO | S_IWUSR,
-                     show_sf2_point, store_sf2_point, 2, 2),
-       SENSOR_ATTR_2(sf2_point3_fan2, S_IRUGO | S_IWUSR,
-                     show_sf2_point, store_sf2_point, 3, 2),
-       SENSOR_ATTR_2(sf2_point4_fan2, S_IRUGO | S_IWUSR,
-                     show_sf2_point, store_sf2_point, 4, 2),
-
-       SENSOR_ATTR_2(sf2_point1_fan3, S_IRUGO | S_IWUSR,
-                     show_sf2_point, store_sf2_point, 1, 3),
-       SENSOR_ATTR_2(sf2_point2_fan3, S_IRUGO | S_IWUSR,
-                     show_sf2_point, store_sf2_point, 2, 3),
-       SENSOR_ATTR_2(sf2_point3_fan3, S_IRUGO | S_IWUSR,
-                     show_sf2_point, store_sf2_point, 3, 3),
-       SENSOR_ATTR_2(sf2_point4_fan3, S_IRUGO | S_IWUSR,
-                     show_sf2_point, store_sf2_point, 4, 3),
-};
+#define sysfs_sf2_point(offset, index) \
+static SENSOR_DEVICE_ATTR_2(sf2_point##offset##_fan##index, S_IRUGO | S_IWUSR, \
+                               show_sf2_point, store_sf2_point, offset, index);
+
+sysfs_sf2_point(1, 1); /* Fan1 */
+sysfs_sf2_point(2, 1); /* Fan1 */
+sysfs_sf2_point(3, 1); /* Fan1 */
+sysfs_sf2_point(4, 1); /* Fan1 */
+sysfs_sf2_point(1, 2); /* Fan2 */
+sysfs_sf2_point(2, 2); /* Fan2 */
+sysfs_sf2_point(3, 2); /* Fan2 */
+sysfs_sf2_point(4, 2); /* Fan2 */
+sysfs_sf2_point(1, 3); /* Fan3 */
+sysfs_sf2_point(2, 3); /* Fan3 */
+sysfs_sf2_point(3, 3); /* Fan3 */
+sysfs_sf2_point(4, 3); /* Fan3 */
+
+#define device_create_file_sf2_point(client, offset, index) \
+do { \
+device_create_file(&client->dev, \
+&sensor_dev_attr_sf2_point##offset##_fan##index.dev_attr); \
+} while (0)
 
 
 static ssize_t
@@ -1001,7 +1013,6 @@ store_sf2_level(struct device *dev, struct device_attribute *attr,
        u8 mask_tmp=0, level_tmp=0;
 
        val = simple_strtoul(buf, NULL, 10);
-       mutex_lock(&data->update_lock);
        data->sf2_levels[index][nr] = SENSORS_LIMIT((val * 15) / 100, 0, 15);
        mask_tmp = w83792d_read_value(client, W83792D_REG_LEVELS[index][nr])
                & ((nr==3) ? 0xf0 : 0x0f);
@@ -1011,33 +1022,30 @@ store_sf2_level(struct device *dev, struct device_attribute *attr,
                level_tmp = data->sf2_levels[index][nr] << 4;
        }
        w83792d_write_value(client, W83792D_REG_LEVELS[index][nr], level_tmp | mask_tmp);
-       mutex_unlock(&data->update_lock);
 
        return count;
 }
 
-static struct sensor_device_attribute_2 sda_sf2_level[] = {
-       SENSOR_ATTR_2(sf2_level1_fan1, S_IRUGO | S_IWUSR,
-                     show_sf2_level, store_sf2_level, 1, 1),
-       SENSOR_ATTR_2(sf2_level2_fan1, S_IRUGO | S_IWUSR,
-                     show_sf2_level, store_sf2_level, 2, 1),
-       SENSOR_ATTR_2(sf2_level3_fan1, S_IRUGO | S_IWUSR,
-                     show_sf2_level, store_sf2_level, 3, 1),
-
-       SENSOR_ATTR_2(sf2_level1_fan2, S_IRUGO | S_IWUSR,
-                     show_sf2_level, store_sf2_level, 1, 2),
-       SENSOR_ATTR_2(sf2_level2_fan2, S_IRUGO | S_IWUSR,
-                     show_sf2_level, store_sf2_level, 2, 2),
-       SENSOR_ATTR_2(sf2_level3_fan2, S_IRUGO | S_IWUSR,
-                     show_sf2_level, store_sf2_level, 3, 2),
-
-       SENSOR_ATTR_2(sf2_level1_fan3, S_IRUGO | S_IWUSR,
-                     show_sf2_level, store_sf2_level, 1, 3),
-       SENSOR_ATTR_2(sf2_level2_fan3, S_IRUGO | S_IWUSR,
-                     show_sf2_level, store_sf2_level, 2, 3),
-       SENSOR_ATTR_2(sf2_level3_fan3, S_IRUGO | S_IWUSR,
-                     show_sf2_level, store_sf2_level, 3, 3),
-};
+#define sysfs_sf2_level(offset, index) \
+static SENSOR_DEVICE_ATTR_2(sf2_level##offset##_fan##index, S_IRUGO | S_IWUSR, \
+                               show_sf2_level, store_sf2_level, offset, index);
+
+sysfs_sf2_level(1, 1); /* Fan1 */
+sysfs_sf2_level(2, 1); /* Fan1 */
+sysfs_sf2_level(3, 1); /* Fan1 */
+sysfs_sf2_level(1, 2); /* Fan2 */
+sysfs_sf2_level(2, 2); /* Fan2 */
+sysfs_sf2_level(3, 2); /* Fan2 */
+sysfs_sf2_level(1, 3); /* Fan3 */
+sysfs_sf2_level(2, 3); /* Fan3 */
+sysfs_sf2_level(3, 3); /* Fan3 */
+
+#define device_create_file_sf2_level(client, offset, index) \
+do { \
+device_create_file(&client->dev, \
+&sensor_dev_attr_sf2_level##offset##_fan##index.dev_attr); \
+} while (0)
+
 
 /* This function is called when:
      * w83792d_driver is inserted (when this module is loaded), for each
@@ -1139,19 +1147,12 @@ ERROR_SC_0:
        return err;
 }
 
-static void device_create_file_fan(struct device *dev, int i)
-{
-       device_create_file(dev, &sda_fan_input[i].dev_attr);
-       device_create_file(dev, &sda_fan_div[i].dev_attr);
-       device_create_file(dev, &sda_fan_min[i].dev_attr);
-}
 
 static int
 w83792d_detect(struct i2c_adapter *adapter, int address, int kind)
 {
        int i = 0, val1 = 0, val2;
-       struct i2c_client *client;
-       struct device *dev;
+       struct i2c_client *new_client;
        struct w83792d_data *data;
        int err = 0;
        const char *client_name = "";
@@ -1169,13 +1170,12 @@ w83792d_detect(struct i2c_adapter *adapter, int address, int kind)
                goto ERROR0;
        }
 
-       client = &data->client;
-       dev = &client->dev;
-       i2c_set_clientdata(client, data);
-       client->addr = address;
-       client->adapter = adapter;
-       client->driver = &w83792d_driver;
-       client->flags = 0;
+       new_client = &data->client;
+       i2c_set_clientdata(new_client, data);
+       new_client->addr = address;
+       new_client->adapter = adapter;
+       new_client->driver = &w83792d_driver;
+       new_client->flags = 0;
 
        /* Now, we do the remaining detection. */
 
@@ -1184,49 +1184,50 @@ w83792d_detect(struct i2c_adapter *adapter, int address, int kind)
           force_*=... parameter, and the Winbond will be reset to the right
           bank. */
        if (kind < 0) {
-               if (w83792d_read_value(client, W83792D_REG_CONFIG) & 0x80) {
-                       dev_dbg(dev, "Detection failed at step 1\n");
+               if (w83792d_read_value(new_client, W83792D_REG_CONFIG) & 0x80) {
+                       dev_warn(&new_client->dev, "Detection failed at step "
+                               "3\n");
                        goto ERROR1;
                }
-               val1 = w83792d_read_value(client, W83792D_REG_BANK);
-               val2 = w83792d_read_value(client, W83792D_REG_CHIPMAN);
+               val1 = w83792d_read_value(new_client, W83792D_REG_BANK);
+               val2 = w83792d_read_value(new_client, W83792D_REG_CHIPMAN);
                /* Check for Winbond ID if in bank 0 */
                if (!(val1 & 0x07)) {  /* is Bank0 */
                        if (((!(val1 & 0x80)) && (val2 != 0xa3)) ||
                             ((val1 & 0x80) && (val2 != 0x5c))) {
-                               dev_dbg(dev, "Detection failed at step 2\n");
                                goto ERROR1;
                        }
                }
                /* If Winbond chip, address of chip and W83792D_REG_I2C_ADDR
                   should match */
-               if (w83792d_read_value(client,
+               if (w83792d_read_value(new_client,
                                        W83792D_REG_I2C_ADDR) != address) {
-                       dev_dbg(dev, "Detection failed at step 3\n");
+                       dev_warn(&new_client->dev, "Detection failed "
+                               "at step 5\n");
                        goto ERROR1;
                }
        }
 
        /* We have either had a force parameter, or we have already detected the
           Winbond. Put it now into bank 0 and Vendor ID High Byte */
-       w83792d_write_value(client,
+       w83792d_write_value(new_client,
                            W83792D_REG_BANK,
-                           (w83792d_read_value(client,
+                           (w83792d_read_value(new_client,
                                W83792D_REG_BANK) & 0x78) | 0x80);
 
        /* Determine the chip type. */
        if (kind <= 0) {
                /* get vendor ID */
-               val2 = w83792d_read_value(client, W83792D_REG_CHIPMAN);
+               val2 = w83792d_read_value(new_client, W83792D_REG_CHIPMAN);
                if (val2 != 0x5c) {  /* the vendor is NOT Winbond */
                        goto ERROR1;
                }
-               val1 = w83792d_read_value(client, W83792D_REG_WCHIPID);
+               val1 = w83792d_read_value(new_client, W83792D_REG_WCHIPID);
                if (val1 == 0x7a) {
                        kind = w83792d;
                } else {
                        if (kind == 0)
-                                       dev_warn(dev,
+                                       dev_warn(&new_client->dev,
                                        "w83792d: Ignoring 'force' parameter for"
                                        " unknown chip at adapter %d, address"
                                        " 0x%02x\n", i2c_adapter_id(adapter),
@@ -1238,86 +1239,120 @@ w83792d_detect(struct i2c_adapter *adapter, int address, int kind)
        if (kind == w83792d) {
                client_name = "w83792d";
        } else {
-               dev_err(dev, "w83792d: Internal error: unknown"
+               dev_err(&new_client->dev, "w83792d: Internal error: unknown"
                                          " kind (%d)?!?", kind);
                goto ERROR1;
        }
 
        /* Fill in the remaining client fields and put into the global list */
-       strlcpy(client->name, client_name, I2C_NAME_SIZE);
+       strlcpy(new_client->name, client_name, I2C_NAME_SIZE);
        data->type = kind;
 
        data->valid = 0;
-       mutex_init(&data->update_lock);
+       init_MUTEX(&data->update_lock);
 
        /* Tell the I2C layer a new client has arrived */
-       if ((err = i2c_attach_client(client)))
+       if ((err = i2c_attach_client(new_client)))
                goto ERROR1;
 
        if ((err = w83792d_detect_subclients(adapter, address,
-                       kind, client)))
+                       kind, new_client)))
                goto ERROR2;
 
        /* Initialize the chip */
-       w83792d_init_client(client);
+       w83792d_init_client(new_client);
 
        /* A few vars need to be filled upon startup */
        for (i = 0; i < 7; i++) {
-               data->fan_min[i] = w83792d_read_value(client,
+               data->fan_min[i] = w83792d_read_value(new_client,
                                        W83792D_REG_FAN_MIN[i]);
        }
 
        /* Register sysfs hooks */
-       data->class_dev = hwmon_device_register(dev);
+       data->class_dev = hwmon_device_register(&new_client->dev);
        if (IS_ERR(data->class_dev)) {
                err = PTR_ERR(data->class_dev);
                goto ERROR3;
        }
-       for (i = 0; i < 9; i++) {
-               device_create_file(dev, &sda_in_input[i].dev_attr);
-               device_create_file(dev, &sda_in_max[i].dev_attr);
-               device_create_file(dev, &sda_in_min[i].dev_attr);
-       }
-       for (i = 0; i < 3; i++)
-               device_create_file_fan(dev, i);
+       device_create_file_in(new_client, 0);
+       device_create_file_in(new_client, 1);
+       device_create_file_in(new_client, 2);
+       device_create_file_in(new_client, 3);
+       device_create_file_in(new_client, 4);
+       device_create_file_in(new_client, 5);
+       device_create_file_in(new_client, 6);
+       device_create_file_in(new_client, 7);
+       device_create_file_in(new_client, 8);
+
+       device_create_file_fan(new_client, 1);
+       device_create_file_fan(new_client, 2);
+       device_create_file_fan(new_client, 3);
 
        /* Read GPIO enable register to check if pins for fan 4,5 are used as
           GPIO */
-       val1 = w83792d_read_value(client, W83792D_REG_GPIO_EN);
+       val1 = w83792d_read_value(new_client, W83792D_REG_GPIO_EN);
        if (!(val1 & 0x40))
-               device_create_file_fan(dev, 3);
+               device_create_file_fan(new_client, 4);
        if (!(val1 & 0x20))
-               device_create_file_fan(dev, 4);
+               device_create_file_fan(new_client, 5);
 
-       val1 = w83792d_read_value(client, W83792D_REG_PIN);
+       val1 = w83792d_read_value(new_client, W83792D_REG_PIN);
        if (val1 & 0x40)
-               device_create_file_fan(dev, 5);
+               device_create_file_fan(new_client, 6);
        if (val1 & 0x04)
-               device_create_file_fan(dev, 6);
-
-       for (i = 0; i < 3; i++) {
-               device_create_file(dev, &sda_temp_input[i].dev_attr);
-               device_create_file(dev, &sda_temp_max[i].dev_attr);
-               device_create_file(dev, &sda_temp_max_hyst[i].dev_attr);
-               device_create_file(dev, &sda_thermal_cruise[i].dev_attr);
-               device_create_file(dev, &sda_tolerance[i].dev_attr);
-       }
-
-       for (i = 0; i < ARRAY_SIZE(sda_pwm); i++) {
-               device_create_file(dev, &sda_pwm[i].dev_attr);
-               device_create_file(dev, &sda_pwm_enable[i].dev_attr);
-               device_create_file(dev, &sda_pwm_mode[i].dev_attr);
-       }
-
-       device_create_file(dev, &dev_attr_alarms);
-       device_create_file(dev, &dev_attr_chassis);
-       device_create_file(dev, &dev_attr_chassis_clear);
-
-       for (i = 0; i < ARRAY_SIZE(sda_sf2_point); i++)
-               device_create_file(dev, &sda_sf2_point[i].dev_attr);
-
-       for (i = 0; i < ARRAY_SIZE(sda_sf2_level); i++)
-               device_create_file(dev, &sda_sf2_level[i].dev_attr);
+               device_create_file_fan(new_client, 7);
+
+       device_create_file_temp1(new_client);           /* Temp1 */
+       device_create_file_temp_add(new_client, 2);     /* Temp2 */
+       device_create_file_temp_add(new_client, 3);     /* Temp3 */
+
+       device_create_file_alarms(new_client);
+
+       device_create_file_pwm(new_client, 1);
+       device_create_file_pwm(new_client, 2);
+       device_create_file_pwm(new_client, 3);
+
+       device_create_file_pwmenable(new_client, 1);
+       device_create_file_pwmenable(new_client, 2);
+       device_create_file_pwmenable(new_client, 3);
+
+       device_create_file_pwm_mode(new_client, 1);
+       device_create_file_pwm_mode(new_client, 2);
+       device_create_file_pwm_mode(new_client, 3);
+
+       device_create_file_chassis(new_client);
+       device_create_file_chassis_clear(new_client);
+
+       device_create_file_thermal_cruise(new_client, 1);
+       device_create_file_thermal_cruise(new_client, 2);
+       device_create_file_thermal_cruise(new_client, 3);
+
+       device_create_file_tolerance(new_client, 1);
+       device_create_file_tolerance(new_client, 2);
+       device_create_file_tolerance(new_client, 3);
+
+       device_create_file_sf2_point(new_client, 1, 1); /* Fan1 */
+       device_create_file_sf2_point(new_client, 2, 1); /* Fan1 */
+       device_create_file_sf2_point(new_client, 3, 1); /* Fan1 */
+       device_create_file_sf2_point(new_client, 4, 1); /* Fan1 */
+       device_create_file_sf2_point(new_client, 1, 2); /* Fan2 */
+       device_create_file_sf2_point(new_client, 2, 2); /* Fan2 */
+       device_create_file_sf2_point(new_client, 3, 2); /* Fan2 */
+       device_create_file_sf2_point(new_client, 4, 2); /* Fan2 */
+       device_create_file_sf2_point(new_client, 1, 3); /* Fan3 */
+       device_create_file_sf2_point(new_client, 2, 3); /* Fan3 */
+       device_create_file_sf2_point(new_client, 3, 3); /* Fan3 */
+       device_create_file_sf2_point(new_client, 4, 3); /* Fan3 */
+
+       device_create_file_sf2_level(new_client, 1, 1); /* Fan1 */
+       device_create_file_sf2_level(new_client, 2, 1); /* Fan1 */
+       device_create_file_sf2_level(new_client, 3, 1); /* Fan1 */
+       device_create_file_sf2_level(new_client, 1, 2); /* Fan2 */
+       device_create_file_sf2_level(new_client, 2, 2); /* Fan2 */
+       device_create_file_sf2_level(new_client, 3, 2); /* Fan2 */
+       device_create_file_sf2_level(new_client, 1, 3); /* Fan3 */
+       device_create_file_sf2_level(new_client, 2, 3); /* Fan3 */
+       device_create_file_sf2_level(new_client, 3, 3); /* Fan3 */
 
        return 0;
 
@@ -1331,7 +1366,7 @@ ERROR3:
                kfree(data->lm75[1]);
        }
 ERROR2:
-       i2c_detach_client(client);
+       i2c_detach_client(new_client);
 ERROR1:
        kfree(data);
 ERROR0:
@@ -1397,9 +1432,9 @@ static struct w83792d_data *w83792d_update_device(struct device *dev)
        struct i2c_client *client = to_i2c_client(dev);
        struct w83792d_data *data = i2c_get_clientdata(client);
        int i, j;
-       u8 reg_array_tmp[4], reg_tmp;
+       u8 reg_array_tmp[4], pwm_array_tmp[7], reg_tmp;
 
-       mutex_lock(&data->update_lock);
+       down(&data->update_lock);
 
        if (time_after
            (jiffies - data->last_updated, (unsigned long) (HZ * 3))
@@ -1426,8 +1461,10 @@ static struct w83792d_data *w83792d_update_device(struct device *dev)
                        data->fan_min[i] = w83792d_read_value(client,
                                                W83792D_REG_FAN_MIN[i]);
                        /* Update the PWM/DC Value and PWM/DC flag */
-                       data->pwm[i] = w83792d_read_value(client,
+                       pwm_array_tmp[i] = w83792d_read_value(client,
                                                W83792D_REG_PWM[i]);
+                       data->pwm[i] = pwm_array_tmp[i] & 0x0f;
+                       data->pwm_mode[i] = pwm_array_tmp[i] >> 7;
                }
 
                reg_tmp = w83792d_read_value(client, W83792D_REG_FAN_CFG);
@@ -1508,7 +1545,7 @@ static struct w83792d_data *w83792d_update_device(struct device *dev)
                data->valid = 1;
        }
 
-       mutex_unlock(&data->update_lock);
+       up(&data->update_lock);
 
 #ifdef DEBUG
        w83792d_print_debug(data, dev);
@@ -1535,6 +1572,7 @@ static void w83792d_print_debug(struct w83792d_data *data, struct device *dev)
                dev_dbg(dev, "fan[%d] is: 0x%x\n", i, data->fan[i]);
                dev_dbg(dev, "fan[%d] min is: 0x%x\n", i, data->fan_min[i]);
                dev_dbg(dev, "pwm[%d]     is: 0x%x\n", i, data->pwm[i]);
+               dev_dbg(dev, "pwm_mode[%d] is: 0x%x\n", i, data->pwm_mode[i]);
        }
        dev_dbg(dev, "3 set of Temperatures: =====>\n");
        for (i=0; i<3; i++) {