Fedora kernel-2.6.17-1.2142_FC4 patched with stable patch-2.6.17.4-vs2.0.2-rc26.diff
[linux-2.6.git] / drivers / i2c / busses / i2c-viapro.c
index 0bb60a6..47e52bf 100644 (file)
@@ -1,9 +1,10 @@
 /*
     i2c-viapro.c - Part of lm_sensors, Linux kernel modules for hardware
               monitoring
-    Copyright (c) 1998 - 2002  Frodo Looijaard <frodol@dds.nl>, 
+    Copyright (c) 1998 - 2002  Frodo Looijaard <frodol@dds.nl>,
     Philip Edelbrock <phil@netroedge.com>, Kyösti Mälkki <kmalkki@cc.hut.fi>,
     Mark D. Studebaker <mdsxyz123@yahoo.com>
+    Copyright (C) 2005  Jean Delvare <khali@linux-fr.org>
 
     This program is free software; you can redistribute it and/or modify
     it under the terms of the GNU General Public License as published by
 */
 
 /*
-   Supports Via devices:
-       82C596A/B (0x3050)
-       82C596B (0x3051)
-       82C686A/B
-       8231
-       8233
-       8233A (0x3147 and 0x3177)
-       8235
-       8237
+   Supports the following VIA south bridges:
+
+   Chip name          PCI ID  REV     I2C block
+   VT82C596A          0x3050             no
+   VT82C596B          0x3051             no
+   VT82C686A          0x3057  0x30       no
+   VT82C686B          0x3057  0x40       yes
+   VT8231             0x8235             no?
+   VT8233             0x3074             yes
+   VT8233A            0x3147             yes?
+   VT8235             0x3177             yes
+   VT8237R            0x3227             yes
+
    Note: we assume there can only be one device, with one SMBus interface.
 */
 
-#include <linux/config.h>
 #include <linux/module.h>
 #include <linux/delay.h>
 #include <linux/pci.h>
 #include <linux/kernel.h>
 #include <linux/stddef.h>
-#include <linux/sched.h>
 #include <linux/ioport.h>
 #include <linux/i2c.h>
 #include <linux/init.h>
 
 static struct pci_dev *vt596_pdev;
 
-#define SMBBA1          0x90
-#define SMBBA2          0x80
-#define SMBBA3          0xD0
+#define SMBBA1         0x90
+#define SMBBA2         0x80
+#define SMBBA3         0xD0
 
 /* SMBus address offsets */
 static unsigned short vt596_smba;
 #define SMBHSTSTS      (vt596_smba + 0)
-#define SMBHSLVSTS     (vt596_smba + 1)
 #define SMBHSTCNT      (vt596_smba + 2)
 #define SMBHSTCMD      (vt596_smba + 3)
 #define SMBHSTADD      (vt596_smba + 4)
 #define SMBHSTDAT0     (vt596_smba + 5)
 #define SMBHSTDAT1     (vt596_smba + 6)
 #define SMBBLKDAT      (vt596_smba + 7)
-#define SMBSLVCNT      (vt596_smba + 8)
-#define SMBSHDWCMD     (vt596_smba + 9)
-#define SMBSLVEVT      (vt596_smba + 0xA)
-#define SMBSLVDAT      (vt596_smba + 0xC)
 
 /* PCI Address Constants */
 
 /* SMBus data in configuration space can be found in two places,
-   We try to select the better one*/
-
-static unsigned short smb_cf_hstcfg = 0xD2;
+   We try to select the better one */
 
-#define SMBHSTCFG   (smb_cf_hstcfg)
-#define SMBSLVC     (smb_cf_hstcfg + 1)
-#define SMBSHDW1    (smb_cf_hstcfg + 2)
-#define SMBSHDW2    (smb_cf_hstcfg + 3)
-#define SMBREV      (smb_cf_hstcfg + 4)
+static unsigned short SMBHSTCFG = 0xD2;
 
 /* Other settings */
 #define MAX_TIMEOUT    500
-#define ENABLE_INT9    0
 
 /* VT82C596 constants */
-#define VT596_QUICK      0x00
-#define VT596_BYTE       0x04
-#define VT596_BYTE_DATA  0x08
-#define VT596_WORD_DATA  0x0C
-#define VT596_BLOCK_DATA 0x14
+#define VT596_QUICK            0x00
+#define VT596_BYTE             0x04
+#define VT596_BYTE_DATA                0x08
+#define VT596_WORD_DATA                0x0C
+#define VT596_BLOCK_DATA       0x14
+#define VT596_I2C_BLOCK_DATA   0x34
 
 
 /* If force is set to anything different from 0, we forcibly enable the
@@ -106,40 +98,64 @@ MODULE_PARM_DESC(force_addr,
                 "EXTREMELY DANGEROUS!");
 
 
+static struct pci_driver vt596_driver;
 static struct i2c_adapter vt596_adapter;
 
-/* Another internally used function */
-static int vt596_transaction(void)
+#define FEATURE_I2CBLOCK       (1<<0)
+static unsigned int vt596_features;
+
+#ifdef DEBUG
+static void vt596_dump_regs(const char *msg, u8 size)
+{
+       dev_dbg(&vt596_adapter.dev, "%s: STS=%02x CNT=%02x CMD=%02x ADD=%02x "
+               "DAT=%02x,%02x\n", msg, inb_p(SMBHSTSTS), inb_p(SMBHSTCNT),
+               inb_p(SMBHSTCMD), inb_p(SMBHSTADD), inb_p(SMBHSTDAT0),
+               inb_p(SMBHSTDAT1));
+
+       if (size == VT596_BLOCK_DATA
+        || size == VT596_I2C_BLOCK_DATA) {
+               int i;
+
+               dev_dbg(&vt596_adapter.dev, "BLK=");
+               for (i = 0; i < I2C_SMBUS_BLOCK_MAX / 2; i++)
+                       printk("%02x,", inb_p(SMBBLKDAT));
+               printk("\n");
+               dev_dbg(&vt596_adapter.dev, "    ");
+               for (; i < I2C_SMBUS_BLOCK_MAX - 1; i++)
+                       printk("%02x,", inb_p(SMBBLKDAT));
+               printk("%02x\n", inb_p(SMBBLKDAT));
+       }
+}
+#else
+static inline void vt596_dump_regs(const char *msg, u8 size) { }
+#endif
+
+/* Return -1 on error, 0 on success */
+static int vt596_transaction(u8 size)
 {
        int temp;
        int result = 0;
        int timeout = 0;
 
-       dev_dbg(&vt596_adapter.dev, "Transaction (pre): CNT=%02x, CMD=%02x, "
-               "ADD=%02x, DAT0=%02x, DAT1=%02x\n", inb_p(SMBHSTCNT), 
-               inb_p(SMBHSTCMD), inb_p(SMBHSTADD), inb_p(SMBHSTDAT0), 
-               inb_p(SMBHSTDAT1));
+       vt596_dump_regs("Transaction (pre)", size);
 
        /* Make sure the SMBus host is ready to start transmitting */
        if ((temp = inb_p(SMBHSTSTS)) & 0x1F) {
                dev_dbg(&vt596_adapter.dev, "SMBus busy (0x%02x). "
-                               "Resetting...\n", temp);
-               
+                       "Resetting...\n", temp);
+
                outb_p(temp, SMBHSTSTS);
                if ((temp = inb_p(SMBHSTSTS)) & 0x1F) {
-                       dev_dbg(&vt596_adapter.dev, "Failed! (0x%02x)\n", temp);
-                       
+                       dev_err(&vt596_adapter.dev, "SMBus reset failed! "
+                               "(0x%02x)\n", temp);
                        return -1;
-               } else {
-                       dev_dbg(&vt596_adapter.dev, "Successfull!\n");
                }
        }
 
-       /* start the transaction by setting bit 6 */
-       outb_p(inb(SMBHSTCNT) | 0x040, SMBHSTCNT);
+       /* Start the transaction by setting bit 6 */
+       outb_p(0x40 | size, SMBHSTCNT);
 
-       /* We will always wait for a fraction of a second! 
-          I don't know if VIA needs this, Intel did  */
+       /* We will always wait for a fraction of a second */
        do {
                msleep(1);
                temp = inb_p(SMBHSTSTS);
@@ -148,77 +164,63 @@ static int vt596_transaction(void)
        /* If the SMBus is still busy, we give up */
        if (timeout >= MAX_TIMEOUT) {
                result = -1;
-               dev_dbg(&vt596_adapter.dev, "SMBus Timeout!\n");
+               dev_err(&vt596_adapter.dev, "SMBus timeout!\n");
        }
 
        if (temp & 0x10) {
                result = -1;
-               dev_dbg(&vt596_adapter.dev, "Error: Failed bus transaction\n");
+               dev_err(&vt596_adapter.dev, "Transaction failed (0x%02x)\n",
+                       size);
        }
 
        if (temp & 0x08) {
                result = -1;
-               dev_info(&vt596_adapter.dev, "Bus collision! SMBus may be "
-                       "locked until next hard\nreset. (sorry!)\n");
-               /* Clock stops and slave is stuck in mid-transmission */
+               dev_err(&vt596_adapter.dev, "SMBus collision!\n");
        }
 
        if (temp & 0x04) {
+               int read = inb_p(SMBHSTADD) & 0x01;
                result = -1;
-               dev_dbg(&vt596_adapter.dev, "Error: no response!\n");
+               /* The quick and receive byte commands are used to probe
+                  for chips, so errors are expected, and we don't want
+                  to frighten the user. */
+               if (!((size == VT596_QUICK && !read) ||
+                     (size == VT596_BYTE && read)))
+                       dev_err(&vt596_adapter.dev, "Transaction error!\n");
        }
 
-       if ((temp = inb_p(SMBHSTSTS)) & 0x1F) {
+       /* Resetting status register */
+       if (temp & 0x1F)
                outb_p(temp, SMBHSTSTS);
-               if ((temp = inb_p(SMBHSTSTS)) & 0x1F) {
-                       dev_warn(&vt596_adapter.dev, "Failed reset at end "
-                                "of transaction (%02x)\n", temp);
-               }
-       }
 
-       dev_dbg(&vt596_adapter.dev, "Transaction (post): CNT=%02x, CMD=%02x, "
-               "ADD=%02x, DAT0=%02x, DAT1=%02x\n", inb_p(SMBHSTCNT),
-               inb_p(SMBHSTCMD), inb_p(SMBHSTADD), inb_p(SMBHSTDAT0), 
-               inb_p(SMBHSTDAT1));
-       
+       vt596_dump_regs("Transaction (post)", size);
+
        return result;
 }
 
-/* Return -1 on error. */
+/* Return -1 on error, 0 on success */
 static s32 vt596_access(struct i2c_adapter *adap, u16 addr,
-               unsigned short flags,  char read_write, u8 command,
-               int size,  union i2c_smbus_data *data)
+               unsigned short flags, char read_write, u8 command,
+               int size, union i2c_smbus_data *data)
 {
-       int i, len;
+       int i;
 
        switch (size) {
-       case I2C_SMBUS_PROC_CALL:
-               dev_info(&vt596_adapter.dev,
-                        "I2C_SMBUS_PROC_CALL not supported!\n");
-               return -1;
        case I2C_SMBUS_QUICK:
-               outb_p(((addr & 0x7f) << 1) | (read_write & 0x01),
-                      SMBHSTADD);
                size = VT596_QUICK;
                break;
        case I2C_SMBUS_BYTE:
-               outb_p(((addr & 0x7f) << 1) | (read_write & 0x01),
-                      SMBHSTADD);
                if (read_write == I2C_SMBUS_WRITE)
                        outb_p(command, SMBHSTCMD);
                size = VT596_BYTE;
                break;
        case I2C_SMBUS_BYTE_DATA:
-               outb_p(((addr & 0x7f) << 1) | (read_write & 0x01),
-                      SMBHSTADD);
                outb_p(command, SMBHSTCMD);
                if (read_write == I2C_SMBUS_WRITE)
                        outb_p(data->byte, SMBHSTDAT0);
                size = VT596_BYTE_DATA;
                break;
        case I2C_SMBUS_WORD_DATA:
-               outb_p(((addr & 0x7f) << 1) | (read_write & 0x01),
-                      SMBHSTADD);
                outb_p(command, SMBHSTCMD);
                if (read_write == I2C_SMBUS_WRITE) {
                        outb_p(data->word & 0xff, SMBHSTDAT0);
@@ -226,28 +228,33 @@ static s32 vt596_access(struct i2c_adapter *adap, u16 addr,
                }
                size = VT596_WORD_DATA;
                break;
+       case I2C_SMBUS_I2C_BLOCK_DATA:
+               if (!(vt596_features & FEATURE_I2CBLOCK))
+                       goto exit_unsupported;
+               if (read_write == I2C_SMBUS_READ)
+                       outb_p(I2C_SMBUS_BLOCK_MAX, SMBHSTDAT0);
+               /* Fall through */
        case I2C_SMBUS_BLOCK_DATA:
-               outb_p(((addr & 0x7f) << 1) | (read_write & 0x01),
-                      SMBHSTADD);
                outb_p(command, SMBHSTCMD);
                if (read_write == I2C_SMBUS_WRITE) {
-                       len = data->block[0];
-                       if (len < 0)
-                               len = 0;
+                       u8 len = data->block[0];
                        if (len > I2C_SMBUS_BLOCK_MAX)
                                len = I2C_SMBUS_BLOCK_MAX;
                        outb_p(len, SMBHSTDAT0);
-                       i = inb_p(SMBHSTCNT);   /* Reset SMBBLKDAT */
+                       inb_p(SMBHSTCNT);       /* Reset SMBBLKDAT */
                        for (i = 1; i <= len; i++)
                                outb_p(data->block[i], SMBBLKDAT);
                }
-               size = VT596_BLOCK_DATA;
+               size = (size == I2C_SMBUS_I2C_BLOCK_DATA) ?
+                      VT596_I2C_BLOCK_DATA : VT596_BLOCK_DATA;
                break;
+       default:
+               goto exit_unsupported;
        }
 
-       outb_p((size & 0x1C) + (ENABLE_INT9 & 1), SMBHSTCNT);
+       outb_p(((addr & 0x7f) << 1) | read_write, SMBHSTADD);
 
-       if (vt596_transaction()) /* Error in transaction */
+       if (vt596_transaction(size)) /* Error in transaction */
                return -1;
 
        if ((read_write == I2C_SMBUS_WRITE) || (size == VT596_QUICK))
@@ -255,40 +262,42 @@ static s32 vt596_access(struct i2c_adapter *adap, u16 addr,
 
        switch (size) {
        case VT596_BYTE:
-               /* Where is the result put? I assume here it is in
-                * SMBHSTDAT0 but it might just as well be in the
-                * SMBHSTCMD. No clue in the docs 
-                */
-               data->byte = inb_p(SMBHSTDAT0);
-               break;
        case VT596_BYTE_DATA:
                data->byte = inb_p(SMBHSTDAT0);
                break;
        case VT596_WORD_DATA:
                data->word = inb_p(SMBHSTDAT0) + (inb_p(SMBHSTDAT1) << 8);
                break;
+       case VT596_I2C_BLOCK_DATA:
        case VT596_BLOCK_DATA:
                data->block[0] = inb_p(SMBHSTDAT0);
                if (data->block[0] > I2C_SMBUS_BLOCK_MAX)
                        data->block[0] = I2C_SMBUS_BLOCK_MAX;
-               i = inb_p(SMBHSTCNT);   /* Reset SMBBLKDAT */
+               inb_p(SMBHSTCNT);       /* Reset SMBBLKDAT */
                for (i = 1; i <= data->block[0]; i++)
                        data->block[i] = inb_p(SMBBLKDAT);
                break;
        }
        return 0;
+
+exit_unsupported:
+       dev_warn(&vt596_adapter.dev, "Unsupported command invoked! (0x%02x)\n",
+                size);
+       return -1;
 }
 
 static u32 vt596_func(struct i2c_adapter *adapter)
 {
-       return I2C_FUNC_SMBUS_QUICK | I2C_FUNC_SMBUS_BYTE |
+       u32 func = I2C_FUNC_SMBUS_QUICK | I2C_FUNC_SMBUS_BYTE |
            I2C_FUNC_SMBUS_BYTE_DATA | I2C_FUNC_SMBUS_WORD_DATA |
            I2C_FUNC_SMBUS_BLOCK_DATA;
+
+       if (vt596_features & FEATURE_I2CBLOCK)
+               func |= I2C_FUNC_SMBUS_I2C_BLOCK;
+       return func;
 }
 
 static struct i2c_algorithm smbus_algorithm = {
-       .name           = "Non-I2C SMBus adapter",
-       .id             = I2C_ALGO_SMBUS,
        .smbus_xfer     = vt596_access,
        .functionality  = vt596_func,
 };
@@ -297,7 +306,6 @@ static struct i2c_adapter vt596_adapter = {
        .owner          = THIS_MODULE,
        .class          = I2C_CLASS_HWMON,
        .algo           = &smbus_algorithm,
-       .name           = "unset",
 };
 
 static int __devinit vt596_probe(struct pci_dev *pdev,
@@ -305,7 +313,7 @@ static int __devinit vt596_probe(struct pci_dev *pdev,
 {
        unsigned char temp;
        int error = -ENODEV;
-       
+
        /* Determine the address of the SMBus areas */
        if (force_addr) {
                vt596_smba = force_addr & 0xfff0;
@@ -314,12 +322,12 @@ static int __devinit vt596_probe(struct pci_dev *pdev,
        }
 
        if ((pci_read_config_word(pdev, id->driver_data, &vt596_smba)) ||
-           !(vt596_smba & 0x1)) {
+           !(vt596_smba & 0x0001)) {
                /* try 2nd address and config reg. for 596 */
                if (id->device == PCI_DEVICE_ID_VIA_82C596_3 &&
                    !pci_read_config_word(pdev, SMBBA2, &vt596_smba) &&
-                   (vt596_smba & 0x1)) {
-                       smb_cf_hstcfg = 0x84;
+                   (vt596_smba & 0x0001)) {
+                       SMBHSTCFG = 0x84;
                } else {
                        /* no matches at all */
                        dev_err(&pdev->dev, "Cannot configure "
@@ -336,10 +344,10 @@ static int __devinit vt596_probe(struct pci_dev *pdev,
                return -ENODEV;
        }
 
- found:
-       if (!request_region(vt596_smba, 8, "viapro-smbus")) {
+found:
+       if (!request_region(vt596_smba, 8, vt596_driver.name)) {
                dev_err(&pdev->dev, "SMBus region 0x%x already in use!\n",
-                       vt596_smba);
+                       vt596_smba);
                return -ENODEV;
        }
 
@@ -351,16 +359,16 @@ static int __devinit vt596_probe(struct pci_dev *pdev,
                pci_write_config_word(pdev, id->driver_data, vt596_smba);
                pci_write_config_byte(pdev, SMBHSTCFG, temp | 0x01);
                dev_warn(&pdev->dev, "WARNING: SMBus interface set to new "
-                    "address 0x%04x!\n", vt596_smba);
-       } else if ((temp & 1) == 0) {
+                        "address 0x%04x!\n", vt596_smba);
+       } else if (!(temp & 0x01)) {
                if (force) {
-                       /* NOTE: This assumes I/O space and other allocations 
-                        * WERE done by the Bios!  Don't complain if your 
-                        * hardware does weird things after enabling this. 
-                        * :') Check for Bios updates before resorting to 
+                       /* NOTE: This assumes I/O space and other allocations
+                        * WERE done by the Bios!  Don't complain if your
+                        * hardware does weird things after enabling this.
+                        * :') Check for Bios updates before resorting to
                         * this.
                         */
-                       pci_write_config_byte(pdev, SMBHSTCFG, temp | 1);
+                       pci_write_config_byte(pdev, SMBHSTCFG, temp | 0x01);
                        dev_info(&pdev->dev, "Enabling SMBus device\n");
                } else {
                        dev_err(&pdev->dev, "SMBUS: Error: Host SMBus "
@@ -370,22 +378,28 @@ static int __devinit vt596_probe(struct pci_dev *pdev,
                }
        }
 
-       if ((temp & 0x0E) == 8)
-               dev_dbg(&pdev->dev, "using Interrupt 9 for SMBus.\n");
-       else if ((temp & 0x0E) == 0)
-               dev_dbg(&pdev->dev, "using Interrupt SMI# for SMBus.\n");
-       else
-               dev_dbg(&pdev->dev, "Illegal Interrupt configuration "
-                       "(or code out of date)!\n");
-
-       pci_read_config_byte(pdev, SMBREV, &temp);
-       dev_dbg(&pdev->dev, "SMBREV = 0x%X\n", temp);
        dev_dbg(&pdev->dev, "VT596_smba = 0x%X\n", vt596_smba);
 
+       switch (pdev->device) {
+       case PCI_DEVICE_ID_VIA_8237:
+       case PCI_DEVICE_ID_VIA_8235:
+       case PCI_DEVICE_ID_VIA_8233A:
+       case PCI_DEVICE_ID_VIA_8233_0:
+               vt596_features |= FEATURE_I2CBLOCK;
+               break;
+       case PCI_DEVICE_ID_VIA_82C686_4:
+               /* The VT82C686B (rev 0x40) does support I2C block
+                  transactions, but the VT82C686A (rev 0x30) doesn't */
+               if (!pci_read_config_byte(pdev, PCI_REVISION_ID, &temp)
+                && temp >= 0x40)
+                       vt596_features |= FEATURE_I2CBLOCK;
+               break;
+       }
+
        vt596_adapter.dev.parent = &pdev->dev;
        snprintf(vt596_adapter.name, I2C_NAME_SIZE,
-                       "SMBus Via Pro adapter at %04x", vt596_smba);
-       
+                "SMBus Via Pro adapter at %04x", vt596_smba);
+
        vt596_pdev = pci_dev_get(pdev);
        if (i2c_add_adapter(&vt596_adapter)) {
                pci_dev_put(vt596_pdev);
@@ -398,7 +412,7 @@ static int __devinit vt596_probe(struct pci_dev *pdev,
         */
        return -ENODEV;
 
- release_region:
+release_region:
        release_region(vt596_smba, 8);
        return error;
 }
@@ -423,7 +437,7 @@ static struct pci_device_id vt596_ids[] = {
        { 0, }
 };
 
-MODULE_DEVICE_TABLE (pci, vt596_ids);
+MODULE_DEVICE_TABLE(pci, vt596_ids);
 
 static struct pci_driver vt596_driver = {
        .name           = "vt596_smbus",
@@ -448,9 +462,9 @@ static void __exit i2c_vt596_exit(void)
        }
 }
 
-MODULE_AUTHOR(
-    "Frodo Looijaard <frodol@dds.nl> and "
-    "Philip Edelbrock <phil@netroedge.com>");
+MODULE_AUTHOR("Kyosti Malkki <kmalkki@cc.hut.fi>, "
+             "Mark D. Studebaker <mdsxyz123@yahoo.com> and "
+             "Jean Delvare <khali@linux-fr.org>");
 MODULE_DESCRIPTION("vt82c596 SMBus driver");
 MODULE_LICENSE("GPL");