vserver 2.0 rc7
[linux-2.6.git] / drivers / infiniband / hw / mthca / mthca_main.c
index 4d71ae8..d405903 100644 (file)
@@ -73,14 +73,15 @@ static const char mthca_version[] __devinitdata =
        DRV_VERSION " (" DRV_RELDATE ")\n";
 
 static struct mthca_profile default_profile = {
-       .num_qp     = 1 << 16,
-       .rdb_per_qp = 4,
-       .num_cq     = 1 << 16,
-       .num_mcg    = 1 << 13,
-       .num_mpt    = 1 << 17,
-       .num_mtt    = 1 << 20,
-       .num_udav   = 1 << 15,  /* Tavor only */
-       .uarc_size  = 1 << 18,  /* Arbel only */
+       .num_qp            = 1 << 16,
+       .rdb_per_qp        = 4,
+       .num_cq            = 1 << 16,
+       .num_mcg           = 1 << 13,
+       .num_mpt           = 1 << 17,
+       .num_mtt           = 1 << 20,
+       .num_udav          = 1 << 15,   /* Tavor only */
+       .fmr_reserved_mtts = 1 << 18,   /* Tavor only */
+       .uarc_size         = 1 << 18,   /* Arbel only */
 };
 
 static int __devinit mthca_tune_pci(struct mthca_dev *mdev)
@@ -102,7 +103,7 @@ static int __devinit mthca_tune_pci(struct mthca_dev *mdev)
                                  "aborting.\n");
                        return -ENODEV;
                }
-       } else if (mdev->hca_type == TAVOR)
+       } else if (!(mdev->mthca_flags & MTHCA_FLAG_PCIE))
                mthca_info(mdev, "No PCI-X capability, not setting RBC.\n");
 
        cap = pci_find_capability(mdev->pdev, PCI_CAP_ID_EXP);
@@ -118,8 +119,7 @@ static int __devinit mthca_tune_pci(struct mthca_dev *mdev)
                                  "register, aborting.\n");
                        return -ENODEV;
                }
-       } else if (mdev->hca_type == ARBEL_NATIVE ||
-                  mdev->hca_type == ARBEL_COMPAT)
+       } else if (mdev->mthca_flags & MTHCA_FLAG_PCIE)
                mthca_info(mdev, "No PCI Express capability, "
                           "not setting Max Read Request Size.\n");
 
@@ -171,6 +171,33 @@ static int __devinit mthca_dev_lim(struct mthca_dev *mdev, struct mthca_dev_lim
        mdev->limits.reserved_uars      = dev_lim->reserved_uars;
        mdev->limits.reserved_pds       = dev_lim->reserved_pds;
 
+       /* IB_DEVICE_RESIZE_MAX_WR not supported by driver.
+          May be doable since hardware supports it for SRQ.
+
+          IB_DEVICE_N_NOTIFY_CQ is supported by hardware but not by driver.
+
+          IB_DEVICE_SRQ_RESIZE is supported by hardware but SRQ is not
+          supported by driver. */
+       mdev->device_cap_flags = IB_DEVICE_CHANGE_PHY_PORT |
+               IB_DEVICE_PORT_ACTIVE_EVENT |
+               IB_DEVICE_SYS_IMAGE_GUID |
+               IB_DEVICE_RC_RNR_NAK_GEN;
+
+       if (dev_lim->flags & DEV_LIM_FLAG_BAD_PKEY_CNTR)
+               mdev->device_cap_flags |= IB_DEVICE_BAD_PKEY_CNTR;
+
+       if (dev_lim->flags & DEV_LIM_FLAG_BAD_QKEY_CNTR)
+               mdev->device_cap_flags |= IB_DEVICE_BAD_QKEY_CNTR;
+
+       if (dev_lim->flags & DEV_LIM_FLAG_RAW_MULTI)
+               mdev->device_cap_flags |= IB_DEVICE_RAW_MULTI;
+
+       if (dev_lim->flags & DEV_LIM_FLAG_AUTO_PATH_MIG)
+               mdev->device_cap_flags |= IB_DEVICE_AUTO_PATH_MIG;
+
+       if (dev_lim->flags & DEV_LIM_FLAG_UD_AV_PORT_ENFORCE)
+               mdev->device_cap_flags |= IB_DEVICE_UD_AV_PORT_ENFORCE;
+
        if (dev_lim->flags & DEV_LIM_FLAG_SRQ)
                mdev->mthca_flags |= MTHCA_FLAG_SRQ;
 
@@ -363,10 +390,9 @@ static int __devinit mthca_init_icm(struct mthca_dev *mdev,
        }
 
        mdev->mr_table.mtt_table = mthca_alloc_icm_table(mdev, init_hca->mtt_base,
-                                                        mdev->limits.num_mtt_segs *
-                                                        init_hca->mtt_seg_sz,
-                                                        mdev->limits.reserved_mtts *
-                                                        init_hca->mtt_seg_sz, 1);
+                                                        MTHCA_MTT_SEG_SIZE,
+                                                        mdev->limits.num_mtt_segs,
+                                                        mdev->limits.reserved_mtts, 1);
        if (!mdev->mr_table.mtt_table) {
                mthca_err(mdev, "Failed to map MTT context memory, aborting.\n");
                err = -ENOMEM;
@@ -374,10 +400,9 @@ static int __devinit mthca_init_icm(struct mthca_dev *mdev,
        }
 
        mdev->mr_table.mpt_table = mthca_alloc_icm_table(mdev, init_hca->mpt_base,
-                                                        mdev->limits.num_mpts *
                                                         dev_lim->mpt_entry_sz,
-                                                        mdev->limits.reserved_mrws *
-                                                        dev_lim->mpt_entry_sz, 1);
+                                                        mdev->limits.num_mpts,
+                                                        mdev->limits.reserved_mrws, 1);
        if (!mdev->mr_table.mpt_table) {
                mthca_err(mdev, "Failed to map MPT context memory, aborting.\n");
                err = -ENOMEM;
@@ -385,10 +410,9 @@ static int __devinit mthca_init_icm(struct mthca_dev *mdev,
        }
 
        mdev->qp_table.qp_table = mthca_alloc_icm_table(mdev, init_hca->qpc_base,
-                                                       mdev->limits.num_qps *
                                                        dev_lim->qpc_entry_sz,
-                                                       mdev->limits.reserved_qps *
-                                                       dev_lim->qpc_entry_sz, 1);
+                                                       mdev->limits.num_qps,
+                                                       mdev->limits.reserved_qps, 0);
        if (!mdev->qp_table.qp_table) {
                mthca_err(mdev, "Failed to map QP context memory, aborting.\n");
                err = -ENOMEM;
@@ -396,29 +420,62 @@ static int __devinit mthca_init_icm(struct mthca_dev *mdev,
        }
 
        mdev->qp_table.eqp_table = mthca_alloc_icm_table(mdev, init_hca->eqpc_base,
-                                                        mdev->limits.num_qps *
                                                         dev_lim->eqpc_entry_sz,
-                                                        mdev->limits.reserved_qps *
-                                                        dev_lim->eqpc_entry_sz, 1);
+                                                        mdev->limits.num_qps,
+                                                        mdev->limits.reserved_qps, 0);
        if (!mdev->qp_table.eqp_table) {
                mthca_err(mdev, "Failed to map EQP context memory, aborting.\n");
                err = -ENOMEM;
                goto err_unmap_qp;
        }
 
-       mdev->cq_table.table = mthca_alloc_icm_table(mdev, init_hca->cqc_base,
-                                                    mdev->limits.num_cqs *
+       mdev->qp_table.rdb_table = mthca_alloc_icm_table(mdev, init_hca->rdb_base,
+                                                        MTHCA_RDB_ENTRY_SIZE,
+                                                        mdev->limits.num_qps <<
+                                                        mdev->qp_table.rdb_shift,
+                                                        0, 0);
+       if (!mdev->qp_table.rdb_table) {
+               mthca_err(mdev, "Failed to map RDB context memory, aborting\n");
+               err = -ENOMEM;
+               goto err_unmap_eqp;
+       }
+
+       mdev->cq_table.table = mthca_alloc_icm_table(mdev, init_hca->cqc_base,
                                                     dev_lim->cqc_entry_sz,
-                                                    mdev->limits.reserved_cqs *
-                                                    dev_lim->cqc_entry_sz, 1);
+                                                    mdev->limits.num_cqs,
+                                                    mdev->limits.reserved_cqs, 0);
        if (!mdev->cq_table.table) {
                mthca_err(mdev, "Failed to map CQ context memory, aborting.\n");
                err = -ENOMEM;
-               goto err_unmap_eqp;
+               goto err_unmap_rdb;
+       }
+
+       /*
+        * It's not strictly required, but for simplicity just map the
+        * whole multicast group table now.  The table isn't very big
+        * and it's a lot easier than trying to track ref counts.
+        */
+       mdev->mcg_table.table = mthca_alloc_icm_table(mdev, init_hca->mc_base,
+                                                     MTHCA_MGM_ENTRY_SIZE,
+                                                     mdev->limits.num_mgms +
+                                                     mdev->limits.num_amgms,
+                                                     mdev->limits.num_mgms +
+                                                     mdev->limits.num_amgms,
+                                                     0);
+       if (!mdev->mcg_table.table) {
+               mthca_err(mdev, "Failed to map MCG context memory, aborting.\n");
+               err = -ENOMEM;
+               goto err_unmap_cq;
        }
 
        return 0;
 
+err_unmap_cq:
+       mthca_free_icm_table(mdev, mdev->cq_table.table);
+
+err_unmap_rdb:
+       mthca_free_icm_table(mdev, mdev->qp_table.rdb_table);
+
 err_unmap_eqp:
        mthca_free_icm_table(mdev, mdev->qp_table.eqp_table);
 
@@ -535,6 +592,7 @@ static int __devinit mthca_init_arbel(struct mthca_dev *mdev)
 
 err_free_icm:
        mthca_free_icm_table(mdev, mdev->cq_table.table);
+       mthca_free_icm_table(mdev, mdev->qp_table.rdb_table);
        mthca_free_icm_table(mdev, mdev->qp_table.eqp_table);
        mthca_free_icm_table(mdev, mdev->qp_table.qp_table);
        mthca_free_icm_table(mdev, mdev->mr_table.mpt_table);
@@ -557,7 +615,7 @@ err_disable:
 
 static int __devinit mthca_init_hca(struct mthca_dev *mdev)
 {
-       if (mdev->hca_type == ARBEL_NATIVE)
+       if (mthca_is_memfree(mdev))
                return mthca_init_arbel(mdev);
        else
                return mthca_init_tavor(mdev);
@@ -570,11 +628,33 @@ static int __devinit mthca_setup_hca(struct mthca_dev *dev)
 
        MTHCA_INIT_DOORBELL_LOCK(&dev->doorbell_lock);
 
+       err = mthca_init_uar_table(dev);
+       if (err) {
+               mthca_err(dev, "Failed to initialize "
+                         "user access region table, aborting.\n");
+               return err;
+       }
+
+       err = mthca_uar_alloc(dev, &dev->driver_uar);
+       if (err) {
+               mthca_err(dev, "Failed to allocate driver access region, "
+                         "aborting.\n");
+               goto err_uar_table_free;
+       }
+
+       dev->kar = ioremap(dev->driver_uar.pfn << PAGE_SHIFT, PAGE_SIZE);
+       if (!dev->kar) {
+               mthca_err(dev, "Couldn't map kernel access region, "
+                         "aborting.\n");
+               err = -ENOMEM;
+               goto err_uar_free;
+       }
+
        err = mthca_init_pd_table(dev);
        if (err) {
                mthca_err(dev, "Failed to initialize "
                          "protection domain table, aborting.\n");
-               return err;
+               goto err_kar_unmap;
        }
 
        err = mthca_init_mr_table(dev);
@@ -591,13 +671,6 @@ static int __devinit mthca_setup_hca(struct mthca_dev *dev)
                goto err_mr_table_free;
        }
 
-       if (dev->hca_type == ARBEL_NATIVE) {
-               mthca_warn(dev, "Sorry, native MT25208 mode support is not done, "
-                          "aborting.\n");
-               err = -ENODEV;
-               goto err_pd_free;
-       }
-
        err = mthca_init_eq_table(dev);
        if (err) {
                mthca_err(dev, "Failed to initialize "
@@ -614,15 +687,19 @@ static int __devinit mthca_setup_hca(struct mthca_dev *dev)
 
        err = mthca_NOP(dev, &status);
        if (err || status) {
-               mthca_err(dev, "NOP command failed to generate interrupt, aborting.\n");
+               mthca_err(dev, "NOP command failed to generate interrupt (IRQ %d), aborting.\n",
+                         dev->mthca_flags & MTHCA_FLAG_MSI_X ?
+                         dev->eq_table.eq[MTHCA_EQ_CMD].msi_x_vector :
+                         dev->pdev->irq);
                if (dev->mthca_flags & (MTHCA_FLAG_MSI | MTHCA_FLAG_MSI_X))
                        mthca_err(dev, "Try again with MSI/MSI-X disabled.\n");
                else
                        mthca_err(dev, "BIOS or ACPI interrupt routing problem?\n");
 
                goto err_cmd_poll;
-       } else
-               mthca_dbg(dev, "NOP command IRQ test passed\n");
+       }
+
+       mthca_dbg(dev, "NOP command IRQ test passed\n");
 
        err = mthca_init_cq_table(dev);
        if (err) {
@@ -677,6 +754,15 @@ err_mr_table_free:
 
 err_pd_table_free:
        mthca_cleanup_pd_table(dev);
+
+err_kar_unmap:
+       iounmap(dev->kar);
+
+err_uar_free:
+       mthca_uar_free(dev, &dev->driver_uar);
+
+err_uar_table_free:
+       mthca_cleanup_uar_table(dev);
        return err;
 }
 
@@ -686,37 +772,18 @@ static int __devinit mthca_request_regions(struct pci_dev *pdev,
        int err;
 
        /*
-        * We request our first BAR in two chunks, since the MSI-X
-        * vector table is right in the middle.
+        * We can't just use pci_request_regions() because the MSI-X
+        * table is right in the middle of the first BAR.  If we did
+        * pci_request_region and grab all of the first BAR, then
+        * setting up MSI-X would fail, since the PCI core wants to do
+        * request_mem_region on the MSI-X vector table.
         *
-        * This is why we can't just use pci_request_regions() -- if
-        * we did then setting up MSI-X would fail, since the PCI core
-        * wants to do request_mem_region on the MSI-X vector table.
+        * So just request what we need right now, and request any
+        * other regions we need when setting up EQs.
         */
-       if (!request_mem_region(pci_resource_start(pdev, 0) +
-                               MTHCA_HCR_BASE,
-                               MTHCA_HCR_SIZE,
-                               DRV_NAME)) {
-               err = -EBUSY;
-               goto err_hcr_failed;
-       }
-
-       if (!request_mem_region(pci_resource_start(pdev, 0) +
-                               MTHCA_ECR_BASE,
-                               MTHCA_MAP_ECR_SIZE,
-                               DRV_NAME)) {
-               err = -EBUSY;
-               goto err_ecr_failed;
-       }
-
-       if (!request_mem_region(pci_resource_start(pdev, 0) +
-                               MTHCA_CLR_INT_BASE,
-                               MTHCA_CLR_INT_SIZE,
-                               DRV_NAME)) {
-               err = -EBUSY;
-               goto err_int_failed;
-       }
-
+       if (!request_mem_region(pci_resource_start(pdev, 0) + MTHCA_HCR_BASE,
+                               MTHCA_HCR_SIZE, DRV_NAME))
+               return -EBUSY;
 
        err = pci_request_region(pdev, 2, DRV_NAME);
        if (err)
@@ -731,24 +798,11 @@ static int __devinit mthca_request_regions(struct pci_dev *pdev,
        return 0;
 
 err_bar4_failed:
-
        pci_release_region(pdev, 2);
-err_bar2_failed:
-
-       release_mem_region(pci_resource_start(pdev, 0) +
-                          MTHCA_CLR_INT_BASE,
-                          MTHCA_CLR_INT_SIZE);
-err_int_failed:
 
-       release_mem_region(pci_resource_start(pdev, 0) +
-                          MTHCA_ECR_BASE,
-                          MTHCA_MAP_ECR_SIZE);
-err_ecr_failed:
-
-       release_mem_region(pci_resource_start(pdev, 0) +
-                          MTHCA_HCR_BASE,
+err_bar2_failed:
+       release_mem_region(pci_resource_start(pdev, 0) + MTHCA_HCR_BASE,
                           MTHCA_HCR_SIZE);
-err_hcr_failed:
 
        return err;
 }
@@ -761,16 +815,7 @@ static void mthca_release_regions(struct pci_dev *pdev,
 
        pci_release_region(pdev, 2);
 
-       release_mem_region(pci_resource_start(pdev, 0) +
-                          MTHCA_CLR_INT_BASE,
-                          MTHCA_CLR_INT_SIZE);
-
-       release_mem_region(pci_resource_start(pdev, 0) +
-                          MTHCA_ECR_BASE,
-                          MTHCA_MAP_ECR_SIZE);
-
-       release_mem_region(pci_resource_start(pdev, 0) +
-                          MTHCA_HCR_BASE,
+       release_mem_region(pci_resource_start(pdev, 0) + MTHCA_HCR_BASE,
                           MTHCA_HCR_SIZE);
 }
 
@@ -804,8 +849,9 @@ static void mthca_close_hca(struct mthca_dev *mdev)
 
        mthca_CLOSE_HCA(mdev, 0, &status);
 
-       if (mdev->hca_type == ARBEL_NATIVE) {
+       if (mthca_is_memfree(mdev)) {
                mthca_free_icm_table(mdev, mdev->cq_table.table);
+               mthca_free_icm_table(mdev, mdev->qp_table.rdb_table);
                mthca_free_icm_table(mdev, mdev->qp_table.eqp_table);
                mthca_free_icm_table(mdev, mdev->qp_table.qp_table);
                mthca_free_icm_table(mdev, mdev->mr_table.mpt_table);
@@ -824,13 +870,34 @@ static void mthca_close_hca(struct mthca_dev *mdev)
                mthca_SYS_DIS(mdev, &status);
 }
 
+/* Types of supported HCA */
+enum {
+       TAVOR,                  /* MT23108                        */
+       ARBEL_COMPAT,           /* MT25208 in Tavor compat mode   */
+       ARBEL_NATIVE,           /* MT25208 with extended features */
+       SINAI                   /* MT25204 */
+};
+
+#define MTHCA_FW_VER(major, minor, subminor) \
+       (((u64) (major) << 32) | ((u64) (minor) << 16) | (u64) (subminor))
+
+static struct {
+       u64 latest_fw;
+       int is_memfree;
+       int is_pcie;
+} mthca_hca_table[] = {
+       [TAVOR]        = { .latest_fw = MTHCA_FW_VER(3, 3, 2), .is_memfree = 0, .is_pcie = 0 },
+       [ARBEL_COMPAT] = { .latest_fw = MTHCA_FW_VER(4, 6, 2), .is_memfree = 0, .is_pcie = 1 },
+       [ARBEL_NATIVE] = { .latest_fw = MTHCA_FW_VER(5, 0, 1), .is_memfree = 1, .is_pcie = 1 },
+       [SINAI]        = { .latest_fw = MTHCA_FW_VER(1, 0, 1), .is_memfree = 1, .is_pcie = 1 }
+};
+
 static int __devinit mthca_init_one(struct pci_dev *pdev,
                                    const struct pci_device_id *id)
 {
        static int mthca_version_printed = 0;
        int ddr_hidden = 0;
        int err;
-       unsigned long mthca_base;
        struct mthca_dev *mdev;
 
        if (!mthca_version_printed) {
@@ -841,6 +908,12 @@ static int __devinit mthca_init_one(struct pci_dev *pdev,
        printk(KERN_INFO PFX "Initializing %s (%s)\n",
               pci_pretty_name(pdev), pci_name(pdev));
 
+       if (id->driver_data >= ARRAY_SIZE(mthca_hca_table)) {
+               printk(KERN_ERR PFX "%s (%s) has invalid driver data %lx\n",
+                      pci_pretty_name(pdev), pci_name(pdev), id->driver_data);
+               return -ENODEV;
+       }
+
        err = pci_enable_device(pdev);
        if (err) {
                dev_err(&pdev->dev, "Cannot enable PCI device, "
@@ -905,11 +978,14 @@ static int __devinit mthca_init_one(struct pci_dev *pdev,
                goto err_free_res;
        }
 
-       mdev->pdev     = pdev;
-       mdev->hca_type = id->driver_data;
+       mdev->pdev = pdev;
 
        if (ddr_hidden)
                mdev->mthca_flags |= MTHCA_FLAG_DDR_HIDDEN;
+       if (mthca_hca_table[id->driver_data].is_memfree)
+               mdev->mthca_flags |= MTHCA_FLAG_MEMFREE;
+       if (mthca_hca_table[id->driver_data].is_pcie)
+               mdev->mthca_flags |= MTHCA_FLAG_PCIE;
 
        /*
         * Now reset the HCA before we touch the PCI capabilities or
@@ -932,8 +1008,7 @@ static int __devinit mthca_init_one(struct pci_dev *pdev,
        sema_init(&mdev->cmd.poll_sem, 1);
        mdev->cmd.use_events = 0;
 
-       mthca_base = pci_resource_start(pdev, 0);
-       mdev->hcr = ioremap(mthca_base + MTHCA_HCR_BASE, MTHCA_HCR_SIZE);
+       mdev->hcr = ioremap(pci_resource_start(pdev, 0) + MTHCA_HCR_BASE, MTHCA_HCR_SIZE);
        if (!mdev->hcr) {
                mthca_err(mdev, "Couldn't map command register, "
                          "aborting.\n");
@@ -941,40 +1016,23 @@ static int __devinit mthca_init_one(struct pci_dev *pdev,
                goto err_free_dev;
        }
 
-       mdev->clr_base = ioremap(mthca_base + MTHCA_CLR_INT_BASE,
-                                MTHCA_CLR_INT_SIZE);
-       if (!mdev->clr_base) {
-               mthca_err(mdev, "Couldn't map interrupt clear register, "
-                         "aborting.\n");
-               err = -ENOMEM;
-               goto err_iounmap;
-       }
-
-       mdev->ecr_base = ioremap(mthca_base + MTHCA_ECR_BASE,
-                                MTHCA_ECR_SIZE + MTHCA_ECR_CLR_SIZE);
-       if (!mdev->ecr_base) {
-               mthca_err(mdev, "Couldn't map ecr register, "
-                         "aborting.\n");
-               err = -ENOMEM;
-               goto err_iounmap_clr;
-       }
-
-       mthca_base = pci_resource_start(pdev, 2);
-       mdev->kar = ioremap(mthca_base + PAGE_SIZE * MTHCA_KAR_PAGE, PAGE_SIZE);
-       if (!mdev->kar) {
-               mthca_err(mdev, "Couldn't map kernel access region, "
-                         "aborting.\n");
-               err = -ENOMEM;
-               goto err_iounmap_ecr;
-       }
-
        err = mthca_tune_pci(mdev);
        if (err)
-               goto err_iounmap_kar;
+               goto err_iounmap;
 
        err = mthca_init_hca(mdev);
        if (err)
-               goto err_iounmap_kar;
+               goto err_iounmap;
+
+       if (mdev->fw_ver < mthca_hca_table[id->driver_data].latest_fw) {
+               mthca_warn(mdev, "HCA FW version %x.%x.%x is old (%x.%x.%x is current).\n",
+                          (int) (mdev->fw_ver >> 32), (int) (mdev->fw_ver >> 16) & 0xffff,
+                          (int) (mdev->fw_ver & 0xffff),
+                          (int) (mthca_hca_table[id->driver_data].latest_fw >> 32),
+                          (int) (mthca_hca_table[id->driver_data].latest_fw >> 16) & 0xffff,
+                          (int) (mthca_hca_table[id->driver_data].latest_fw & 0xffff));
+               mthca_warn(mdev, "If you have problems, try updating your HCA FW.\n");
+       }
 
        err = mthca_setup_hca(mdev);
        if (err)
@@ -1007,19 +1065,11 @@ err_cleanup:
 
        mthca_cleanup_mr_table(mdev);
        mthca_cleanup_pd_table(mdev);
+       mthca_cleanup_uar_table(mdev);
 
 err_close:
        mthca_close_hca(mdev);
 
-err_iounmap_kar:
-       iounmap(mdev->kar);
-
-err_iounmap_ecr:
-       iounmap(mdev->ecr_base);
-
-err_iounmap_clr:
-       iounmap(mdev->clr_base);
-
 err_iounmap:
        iounmap(mdev->hcr);
 
@@ -1065,11 +1115,13 @@ static void __devexit mthca_remove_one(struct pci_dev *pdev)
                mthca_cleanup_mr_table(mdev);
                mthca_cleanup_pd_table(mdev);
 
+               iounmap(mdev->kar);
+               mthca_uar_free(mdev, &mdev->driver_uar);
+               mthca_cleanup_uar_table(mdev);
+
                mthca_close_hca(mdev);
 
                iounmap(mdev->hcr);
-               iounmap(mdev->ecr_base);
-               iounmap(mdev->clr_base);
 
                if (mdev->mthca_flags & MTHCA_FLAG_MSI_X)
                        pci_disable_msix(pdev);
@@ -1097,6 +1149,14 @@ static struct pci_device_id mthca_pci_table[] = {
          .driver_data = ARBEL_NATIVE },
        { PCI_DEVICE(PCI_VENDOR_ID_TOPSPIN, PCI_DEVICE_ID_MELLANOX_ARBEL),
          .driver_data = ARBEL_NATIVE },
+       { PCI_DEVICE(PCI_VENDOR_ID_MELLANOX, PCI_DEVICE_ID_MELLANOX_SINAI),
+         .driver_data = SINAI },
+       { PCI_DEVICE(PCI_VENDOR_ID_TOPSPIN, PCI_DEVICE_ID_MELLANOX_SINAI),
+         .driver_data = SINAI },
+       { PCI_DEVICE(PCI_VENDOR_ID_MELLANOX, PCI_DEVICE_ID_MELLANOX_SINAI_OLD),
+         .driver_data = SINAI },
+       { PCI_DEVICE(PCI_VENDOR_ID_TOPSPIN, PCI_DEVICE_ID_MELLANOX_SINAI_OLD),
+         .driver_data = SINAI },
        { 0, }
 };