linux 2.6.16.38 w/ vs2.0.3-rc1
[linux-2.6.git] / drivers / media / video / msp3400-kthreads.c
index 4c7f85b..2072c3e 100644 (file)
 #include <linux/videodev.h>
 #include <linux/videodev2.h>
 #include <media/v4l2-common.h>
-#include <media/msp3400.h>
+#include <media/audiochip.h>
 #include <linux/kthread.h>
 #include <linux/suspend.h>
-#include "msp3400-driver.h"
+#include "msp3400.h"
 
 /* this one uses the automatic sound standard detection of newer msp34xx
    chip versions */
@@ -45,13 +45,11 @@ static struct {
        { 0x0004, MSP_CARRIER(6.5), MSP_CARRIER(6.2578125), "6.5/6.25  D/K1 Dual FM-Stereo" },
        { 0x0005, MSP_CARRIER(6.5), MSP_CARRIER(6.7421875), "6.5/6.74  D/K2 Dual FM-Stereo" },
        { 0x0006, MSP_CARRIER(6.5), MSP_CARRIER(6.5), "6.5  D/K FM-Mono (HDEV3)" },
-       { 0x0007, MSP_CARRIER(6.5), MSP_CARRIER(5.7421875), "6.5/5.74  D/K3 Dual FM-Stereo" },
        { 0x0008, MSP_CARRIER(5.5), MSP_CARRIER(5.85), "5.5/5.85  B/G NICAM FM" },
        { 0x0009, MSP_CARRIER(6.5), MSP_CARRIER(5.85), "6.5/5.85  L NICAM AM" },
        { 0x000a, MSP_CARRIER(6.0), MSP_CARRIER(6.55), "6.0/6.55  I NICAM FM" },
        { 0x000b, MSP_CARRIER(6.5), MSP_CARRIER(5.85), "6.5/5.85  D/K NICAM FM" },
        { 0x000c, MSP_CARRIER(6.5), MSP_CARRIER(5.85), "6.5/5.85  D/K NICAM FM (HDEV2)" },
-       { 0x000d, MSP_CARRIER(6.5), MSP_CARRIER(5.85), "6.5/5.85  D/K NICAM FM (HDEV3)" },
        { 0x0020, MSP_CARRIER(4.5), MSP_CARRIER(4.5), "4.5  M BTSC-Stereo" },
        { 0x0021, MSP_CARRIER(4.5), MSP_CARRIER(4.5), "4.5  M BTSC-Mono + SAP" },
        { 0x0030, MSP_CARRIER(4.5), MSP_CARRIER(4.5), "4.5  M EIA-J Japan Stereo" },
@@ -111,7 +109,7 @@ static struct msp3400c_init_data_dem {
                {-2, -8, -10, 10, 50, 86},
                {-4, -12, -9, 23, 79, 126},
                MSP_CARRIER(6.5), MSP_CARRIER(6.5),
-               0x00c6, 0x0140, 0x0120, 0x7c00
+               0x00c6, 0x0140, 0x0120, 0x7c03
        },
 };
 
@@ -156,172 +154,139 @@ const char *msp_standard_std_name(int std)
        return "unknown";
 }
 
-static void msp_set_source(struct i2c_client *client, u16 src)
-{
-       struct msp_state *state = i2c_get_clientdata(client);
-
-       if (msp_dolby) {
-               msp_write_dsp(client, 0x0008, 0x0520); /* I2S1 */
-               msp_write_dsp(client, 0x0009, 0x0620); /* I2S2 */
-       } else {
-               msp_write_dsp(client, 0x0008, src);
-               msp_write_dsp(client, 0x0009, src);
-       }
-       msp_write_dsp(client, 0x000a, src);
-       msp_write_dsp(client, 0x000b, src);
-       msp_write_dsp(client, 0x000c, src);
-       if (state->has_scart2_out)
-               msp_write_dsp(client, 0x0041, src);
-}
-
-void msp3400c_set_carrier(struct i2c_client *client, int cdo1, int cdo2)
+void msp3400c_setcarrier(struct i2c_client *client, int cdo1, int cdo2)
 {
        msp_write_dem(client, 0x0093, cdo1 & 0xfff);
        msp_write_dem(client, 0x009b, cdo1 >> 12);
        msp_write_dem(client, 0x00a3, cdo2 & 0xfff);
        msp_write_dem(client, 0x00ab, cdo2 >> 12);
-       msp_write_dem(client, 0x0056, 0); /* LOAD_REG_1/2 */
+       msp_write_dem(client, 0x0056, 0); /*LOAD_REG_1/2*/
 }
 
-void msp3400c_set_mode(struct i2c_client *client, int mode)
+void msp3400c_setmode(struct i2c_client *client, int type)
 {
        struct msp_state *state = i2c_get_clientdata(client);
-       struct msp3400c_init_data_dem *data = &msp3400c_init_data[mode];
-       int tuner = (state->routing.input >> 3) & 1;
        int i;
 
-       v4l_dbg(1, msp_debug, client, "set_mode: %d\n", mode);
-       state->mode = mode;
+       v4l_dbg(1, msp_debug, client, "setmode: %d\n", type);
+       state->mode       = type;
+       state->audmode    = V4L2_TUNER_MODE_MONO;
        state->rxsubchans = V4L2_TUNER_SUB_MONO;
 
-       msp_write_dem(client, 0x00bb, data->ad_cv | (tuner ? 0x100 : 0));
+       msp_write_dem(client, 0x00bb, msp3400c_init_data[type].ad_cv);
 
        for (i = 5; i >= 0; i--)               /* fir 1 */
-               msp_write_dem(client, 0x0001, data->fir1[i]);
+               msp_write_dem(client, 0x0001, msp3400c_init_data[type].fir1[i]);
 
        msp_write_dem(client, 0x0005, 0x0004); /* fir 2 */
        msp_write_dem(client, 0x0005, 0x0040);
        msp_write_dem(client, 0x0005, 0x0000);
        for (i = 5; i >= 0; i--)
-               msp_write_dem(client, 0x0005, data->fir2[i]);
+               msp_write_dem(client, 0x0005, msp3400c_init_data[type].fir2[i]);
+
+       msp_write_dem(client, 0x0083, msp3400c_init_data[type].mode_reg);
 
-       msp_write_dem(client, 0x0083, data->mode_reg);
+       msp3400c_setcarrier(client, msp3400c_init_data[type].cdo1,
+                           msp3400c_init_data[type].cdo2);
 
-       msp3400c_set_carrier(client, data->cdo1, data->cdo2);
+       msp_write_dem(client, 0x0056, 0); /*LOAD_REG_1/2*/
 
-       msp_set_source(client, data->dsp_src);
-       /* set prescales */
+       if (msp_dolby) {
+               msp_write_dsp(client, 0x0008, 0x0520); /* I2S1 */
+               msp_write_dsp(client, 0x0009, 0x0620); /* I2S2 */
+               msp_write_dsp(client, 0x000b, msp3400c_init_data[type].dsp_src);
+       } else {
+               msp_write_dsp(client, 0x0008, msp3400c_init_data[type].dsp_src);
+               msp_write_dsp(client, 0x0009, msp3400c_init_data[type].dsp_src);
+               msp_write_dsp(client, 0x000b, msp3400c_init_data[type].dsp_src);
+       }
+       msp_write_dsp(client, 0x000a, msp3400c_init_data[type].dsp_src);
+       msp_write_dsp(client, 0x000e, msp3400c_init_data[type].dsp_matrix);
 
-       /* volume prescale for SCART (AM mono input) */
-       msp_write_dsp(client, 0x000d, 0x1900);
-       msp_write_dsp(client, 0x000e, data->dsp_matrix);
-       if (state->has_nicam) /* nicam prescale */
-               msp_write_dsp(client, 0x0010, 0x5a00);
+       if (state->has_nicam) {
+               /* nicam prescale */
+               msp_write_dsp(client, 0x0010, 0x5a00); /* was: 0x3000 */
+       }
 }
 
-/* Set audio mode. Note that the pre-'G' models do not support BTSC+SAP,
-   nor do they support stereo BTSC. */
-static void msp3400c_set_audmode(struct i2c_client *client)
+/* turn on/off nicam + stereo */
+void msp3400c_setstereo(struct i2c_client *client, int mode)
 {
-       static char *strmode[] = { "mono", "stereo", "lang2", "lang1", "lang1+lang2" };
+       static char *strmode[] = { "mono", "stereo", "lang2", "lang1" };
        struct msp_state *state = i2c_get_clientdata(client);
-       char *modestr = (state->audmode >= 0 && state->audmode < 5) ?
-               strmode[state->audmode] : "unknown";
-       int src = 0;    /* channel source: FM/AM, nicam or SCART */
-       int audmode = state->audmode;
+       int nicam = 0;          /* channel source: FM/AM or nicam */
+       int src = 0;
 
        if (state->opmode == OPMODE_AUTOSELECT) {
                /* this method would break everything, let's make sure
                 * it's never called
                 */
-               v4l_dbg(1, msp_debug, client,
-                       "set_audmode called with mode=%d instead of set_source (ignored)\n",
-                       state->audmode);
+               v4l_dbg(1, msp_debug, client, "setstereo called with mode=%d instead of set_source (ignored)\n",
+                    mode);
                return;
        }
 
-       /* Note: for the C and D revs no NTSC stereo + SAP is possible as
-          the hardware does not support SAP. So the rxsubchans combination
-          of STEREO | LANG2 does not occur. */
-
-       if (state->mode != MSP_MODE_EXTERN) {
-               /* switch to mono if only mono is available */
-               if (state->rxsubchans == V4L2_TUNER_SUB_MONO)
-                       audmode = V4L2_TUNER_MODE_MONO;
-               /* if bilingual */
-               else if (state->rxsubchans & V4L2_TUNER_SUB_LANG2) {
-                       /* and mono or stereo, then fallback to lang1 */
-                       if (audmode == V4L2_TUNER_MODE_MONO ||
-                           audmode == V4L2_TUNER_MODE_STEREO)
-                               audmode = V4L2_TUNER_MODE_LANG1;
-               }
-               /* if stereo, and audmode is not mono, then switch to stereo */
-               else if (audmode != V4L2_TUNER_MODE_MONO)
-                       audmode = V4L2_TUNER_MODE_STEREO;
-       }
-
        /* switch demodulator */
        switch (state->mode) {
        case MSP_MODE_FM_TERRA:
-               v4l_dbg(1, msp_debug, client, "FM set_audmode: %s\n", modestr);
-               switch (audmode) {
+               v4l_dbg(1, msp_debug, client, "FM setstereo: %s\n", strmode[mode]);
+               msp3400c_setcarrier(client, state->second, state->main);
+               switch (mode) {
                case V4L2_TUNER_MODE_STEREO:
                        msp_write_dsp(client, 0x000e, 0x3001);
                        break;
                case V4L2_TUNER_MODE_MONO:
                case V4L2_TUNER_MODE_LANG1:
                case V4L2_TUNER_MODE_LANG2:
-               case V4L2_TUNER_MODE_LANG1_LANG2:
                        msp_write_dsp(client, 0x000e, 0x3000);
                        break;
                }
                break;
        case MSP_MODE_FM_SAT:
-               v4l_dbg(1, msp_debug, client, "SAT set_audmode: %s\n", modestr);
-               switch (audmode) {
+               v4l_dbg(1, msp_debug, client, "SAT setstereo: %s\n", strmode[mode]);
+               switch (mode) {
                case V4L2_TUNER_MODE_MONO:
-                       msp3400c_set_carrier(client, MSP_CARRIER(6.5), MSP_CARRIER(6.5));
+                       msp3400c_setcarrier(client, MSP_CARRIER(6.5), MSP_CARRIER(6.5));
                        break;
                case V4L2_TUNER_MODE_STEREO:
-               case V4L2_TUNER_MODE_LANG1_LANG2:
-                       msp3400c_set_carrier(client, MSP_CARRIER(7.2), MSP_CARRIER(7.02));
+                       msp3400c_setcarrier(client, MSP_CARRIER(7.2), MSP_CARRIER(7.02));
                        break;
                case V4L2_TUNER_MODE_LANG1:
-                       msp3400c_set_carrier(client, MSP_CARRIER(7.38), MSP_CARRIER(7.02));
+                       msp3400c_setcarrier(client, MSP_CARRIER(7.38), MSP_CARRIER(7.02));
                        break;
                case V4L2_TUNER_MODE_LANG2:
-                       msp3400c_set_carrier(client, MSP_CARRIER(7.38), MSP_CARRIER(7.02));
+                       msp3400c_setcarrier(client, MSP_CARRIER(7.38), MSP_CARRIER(7.02));
                        break;
                }
                break;
        case MSP_MODE_FM_NICAM1:
        case MSP_MODE_FM_NICAM2:
        case MSP_MODE_AM_NICAM:
-               v4l_dbg(1, msp_debug, client, "NICAM set_audmode: %s\n",modestr);
+               v4l_dbg(1, msp_debug, client, "NICAM setstereo: %s\n",strmode[mode]);
+               msp3400c_setcarrier(client,state->second,state->main);
                if (state->nicam_on)
-                       src = 0x0100;  /* NICAM */
+                       nicam=0x0100;
                break;
        case MSP_MODE_BTSC:
-               v4l_dbg(1, msp_debug, client, "BTSC set_audmode: %s\n",modestr);
+               v4l_dbg(1, msp_debug, client, "BTSC setstereo: %s\n",strmode[mode]);
+               nicam=0x0300;
                break;
        case MSP_MODE_EXTERN:
-               v4l_dbg(1, msp_debug, client, "extern set_audmode: %s\n",modestr);
-               src = 0x0200;  /* SCART */
+               v4l_dbg(1, msp_debug, client, "extern setstereo: %s\n",strmode[mode]);
+               nicam = 0x0200;
                break;
        case MSP_MODE_FM_RADIO:
-               v4l_dbg(1, msp_debug, client, "FM-Radio set_audmode: %s\n",modestr);
+               v4l_dbg(1, msp_debug, client, "FM-Radio setstereo: %s\n",strmode[mode]);
                break;
        default:
-               v4l_dbg(1, msp_debug, client, "mono set_audmode\n");
+               v4l_dbg(1, msp_debug, client, "mono setstereo\n");
                return;
        }
 
        /* switch audio */
-       v4l_dbg(1, msp_debug, client, "set audmode %d\n", audmode);
-       switch (audmode) {
+       switch (mode) {
        case V4L2_TUNER_MODE_STEREO:
-       case V4L2_TUNER_MODE_LANG1_LANG2:
-               src |= 0x0020;
+               src = 0x0020 | nicam;
                break;
        case V4L2_TUNER_MODE_MONO:
                if (state->mode == MSP_MODE_AM_NICAM) {
@@ -332,18 +297,29 @@ static void msp3400c_set_audmode(struct i2c_client *client)
                        src = 0x0200;
                        break;
                }
-               if (state->rxsubchans & V4L2_TUNER_SUB_STEREO)
-                       src = 0x0030;
-               break;
        case V4L2_TUNER_MODE_LANG1:
+               src = 0x0000 | nicam;
                break;
        case V4L2_TUNER_MODE_LANG2:
-               src |= 0x0010;
+               src = 0x0010 | nicam;
                break;
        }
-       v4l_dbg(1, msp_debug, client, "set_audmode final source/matrix = 0x%x\n", src);
+       v4l_dbg(1, msp_debug, client, "setstereo final source/matrix = 0x%x\n", src);
 
-       msp_set_source(client, src);
+       if (msp_dolby) {
+               msp_write_dsp(client, 0x0008, 0x0520);
+               msp_write_dsp(client, 0x0009, 0x0620);
+               msp_write_dsp(client, 0x000a, src);
+               msp_write_dsp(client, 0x000b, src);
+       } else {
+               msp_write_dsp(client, 0x0008, src);
+               msp_write_dsp(client, 0x0009, src);
+               msp_write_dsp(client, 0x000a, src);
+               msp_write_dsp(client, 0x000b, src);
+               msp_write_dsp(client, 0x000c, src);
+               if (state->has_scart23_in_scart2_out)
+                       msp_write_dsp(client, 0x0041, src);
+       }
 }
 
 static void msp3400c_print_mode(struct i2c_client *client)
@@ -371,12 +347,12 @@ static void msp3400c_print_mode(struct i2c_client *client)
 
 /* ----------------------------------------------------------------------- */
 
-static int msp3400c_detect_stereo(struct i2c_client *client)
+int autodetect_stereo(struct i2c_client *client)
 {
        struct msp_state *state = i2c_get_clientdata(client);
        int val;
        int rxsubchans = state->rxsubchans;
-       int newnicam = state->nicam_on;
+       int newnicam   = state->nicam_on;
        int update = 0;
 
        switch (state->mode) {
@@ -385,8 +361,8 @@ static int msp3400c_detect_stereo(struct i2c_client *client)
                if (val > 32767)
                        val -= 65536;
                v4l_dbg(2, msp_debug, client, "stereo detect register: %d\n", val);
-               if (val > 8192) {
-                       rxsubchans = V4L2_TUNER_SUB_STEREO;
+               if (val > 4096) {
+                       rxsubchans = V4L2_TUNER_SUB_STEREO | V4L2_TUNER_SUB_MONO;
                } else if (val < -4096) {
                        rxsubchans = V4L2_TUNER_SUB_LANG1 | V4L2_TUNER_SUB_LANG2;
                } else {
@@ -410,11 +386,14 @@ static int msp3400c_detect_stereo(struct i2c_client *client)
                                break;
                        case 1:
                        case 9:
-                               rxsubchans = V4L2_TUNER_SUB_MONO;
+                               rxsubchans = V4L2_TUNER_SUB_MONO
+                                       | V4L2_TUNER_SUB_LANG1;
                                break;
                        case 2:
                        case 10:
-                               rxsubchans = V4L2_TUNER_SUB_LANG1 | V4L2_TUNER_SUB_LANG2;
+                               rxsubchans = V4L2_TUNER_SUB_MONO
+                                       | V4L2_TUNER_SUB_LANG1
+                                       | V4L2_TUNER_SUB_LANG2;
                                break;
                        default:
                                rxsubchans = V4L2_TUNER_SUB_MONO;
@@ -426,17 +405,30 @@ static int msp3400c_detect_stereo(struct i2c_client *client)
                        rxsubchans = V4L2_TUNER_SUB_MONO;
                }
                break;
+       case MSP_MODE_BTSC:
+               val = msp_read_dem(client, 0x200);
+               v4l_dbg(2, msp_debug, client, "status=0x%x (pri=%s, sec=%s, %s%s%s)\n",
+                       val,
+                       (val & 0x0002) ? "no"     : "yes",
+                       (val & 0x0004) ? "no"     : "yes",
+                       (val & 0x0040) ? "stereo" : "mono",
+                       (val & 0x0080) ? ", nicam 2nd mono" : "",
+                       (val & 0x0100) ? ", bilingual/SAP"  : "");
+               rxsubchans = V4L2_TUNER_SUB_MONO;
+               if (val & 0x0040) rxsubchans |= V4L2_TUNER_SUB_STEREO;
+               if (val & 0x0100) rxsubchans |= V4L2_TUNER_SUB_LANG1;
+               break;
        }
        if (rxsubchans != state->rxsubchans) {
                update = 1;
-               v4l_dbg(1, msp_debug, client, "watch: rxsubchans %02x => %02x\n",
-                       state->rxsubchans, rxsubchans);
+               v4l_dbg(1, msp_debug, client, "watch: rxsubchans %d => %d\n",
+                       state->rxsubchans,rxsubchans);
                state->rxsubchans = rxsubchans;
        }
        if (newnicam != state->nicam_on) {
                update = 1;
                v4l_dbg(1, msp_debug, client, "watch: nicam %d => %d\n",
-                       state->nicam_on, newnicam);
+                       state->nicam_on,newnicam);
                state->nicam_on = newnicam;
        }
        return update;
@@ -451,8 +443,13 @@ static void watch_stereo(struct i2c_client *client)
 {
        struct msp_state *state = i2c_get_clientdata(client);
 
-       if (msp_detect_stereo(client)) {
-               msp_set_audmode(client);
+       if (autodetect_stereo(client)) {
+               if (state->rxsubchans & V4L2_TUNER_SUB_STEREO)
+                       msp3400c_setstereo(client, V4L2_TUNER_MODE_STEREO);
+               else if (state->rxsubchans & V4L2_TUNER_SUB_LANG1)
+                       msp3400c_setstereo(client, V4L2_TUNER_MODE_LANG1);
+               else
+                       msp3400c_setstereo(client, V4L2_TUNER_MODE_MONO);
        }
 
        if (msp_once)
@@ -464,7 +461,7 @@ int msp3400c_thread(void *data)
        struct i2c_client *client = data;
        struct msp_state *state = i2c_get_clientdata(client);
        struct msp3400c_carrier_detect *cd;
-       int count, max1, max2, val1, val2, val, this;
+       int count, max1,max2,val1,val2, val,this;
 
 
        v4l_dbg(1, msp_debug, client, "msp3400 daemon started\n");
@@ -474,7 +471,7 @@ int msp3400c_thread(void *data)
                v4l_dbg(2, msp_debug, client, "msp3400 thread: wakeup\n");
 
        restart:
-               v4l_dbg(2, msp_debug, client, "thread: restart scan\n");
+               v4l_dbg(1, msp_debug, client, "thread: restart scan\n");
                state->restart = 0;
                if (kthread_should_stop())
                        break;
@@ -482,24 +479,19 @@ int msp3400c_thread(void *data)
                if (state->radio || MSP_MODE_EXTERN == state->mode) {
                        /* no carrier scan, just unmute */
                        v4l_dbg(1, msp_debug, client, "thread: no carrier scan\n");
-                       state->scan_in_progress = 0;
-                       state->rxsubchans = V4L2_TUNER_SUB_STEREO;
                        msp_set_audio(client);
                        continue;
                }
 
-               /* mute audio */
-               state->scan_in_progress = 1;
-               msp_set_audio(client);
-
-               msp3400c_set_mode(client, MSP_MODE_AM_DETECT);
+               /* mute */
+               msp_set_mute(client);
+               msp3400c_setmode(client, MSP_MODE_AM_DETECT /* +1 */ );
                val1 = val2 = 0;
                max1 = max2 = -1;
                state->watch_stereo = 0;
-               state->nicam_on = 0;
 
-               /* wait for tuner to settle down after a channel change */
-               if (msp_sleep(state, 200))
+               /* some time for the tuner to sync */
+               if (msp_sleep(state,200))
                        goto restart;
 
                /* carrier detect pass #1 -- main carrier */
@@ -514,7 +506,7 @@ int msp3400c_thread(void *data)
                }
 
                for (this = 0; this < count; this++) {
-                       msp3400c_set_carrier(client, cd[this].cdo, cd[this].cdo);
+                       msp3400c_setcarrier(client, cd[this].cdo,cd[this].cdo);
                        if (msp_sleep(state,100))
                                goto restart;
                        val = msp_read_dsp(client, 0x1b);
@@ -550,7 +542,7 @@ int msp3400c_thread(void *data)
                        max2 = 0;
                }
                for (this = 0; this < count; this++) {
-                       msp3400c_set_carrier(client, cd[this].cdo, cd[this].cdo);
+                       msp3400c_setcarrier(client, cd[this].cdo,cd[this].cdo);
                        if (msp_sleep(state,100))
                                goto restart;
                        val = msp_read_dsp(client, 0x1b);
@@ -562,19 +554,22 @@ int msp3400c_thread(void *data)
                }
 
                /* program the msp3400 according to the results */
-               state->main = msp3400c_carrier_detect_main[max1].cdo;
+               state->main   = msp3400c_carrier_detect_main[max1].cdo;
                switch (max1) {
                case 1: /* 5.5 */
                        if (max2 == 0) {
                                /* B/G FM-stereo */
                                state->second = msp3400c_carrier_detect_55[max2].cdo;
-                               msp3400c_set_mode(client, MSP_MODE_FM_TERRA);
+                               msp3400c_setmode(client, MSP_MODE_FM_TERRA);
+                               state->nicam_on = 0;
+                               msp3400c_setstereo(client, V4L2_TUNER_MODE_MONO);
                                state->watch_stereo = 1;
                        } else if (max2 == 1 && state->has_nicam) {
                                /* B/G NICAM */
                                state->second = msp3400c_carrier_detect_55[max2].cdo;
-                               msp3400c_set_mode(client, MSP_MODE_FM_NICAM1);
+                               msp3400c_setmode(client, MSP_MODE_FM_NICAM1);
                                state->nicam_on = 1;
+                               msp3400c_setcarrier(client, state->second, state->main);
                                state->watch_stereo = 1;
                        } else {
                                goto no_second;
@@ -583,26 +578,35 @@ int msp3400c_thread(void *data)
                case 2: /* 6.0 */
                        /* PAL I NICAM */
                        state->second = MSP_CARRIER(6.552);
-                       msp3400c_set_mode(client, MSP_MODE_FM_NICAM2);
+                       msp3400c_setmode(client, MSP_MODE_FM_NICAM2);
                        state->nicam_on = 1;
+                       msp3400c_setcarrier(client, state->second, state->main);
                        state->watch_stereo = 1;
                        break;
                case 3: /* 6.5 */
                        if (max2 == 1 || max2 == 2) {
                                /* D/K FM-stereo */
                                state->second = msp3400c_carrier_detect_65[max2].cdo;
-                               msp3400c_set_mode(client, MSP_MODE_FM_TERRA);
+                               msp3400c_setmode(client, MSP_MODE_FM_TERRA);
+                               state->nicam_on = 0;
+                               msp3400c_setstereo(client, V4L2_TUNER_MODE_MONO);
                                state->watch_stereo = 1;
                        } else if (max2 == 0 && (state->v4l2_std & V4L2_STD_SECAM)) {
                                /* L NICAM or AM-mono */
                                state->second = msp3400c_carrier_detect_65[max2].cdo;
-                               msp3400c_set_mode(client, MSP_MODE_AM_NICAM);
+                               msp3400c_setmode(client, MSP_MODE_AM_NICAM);
+                               state->nicam_on = 0;
+                               msp3400c_setstereo(client, V4L2_TUNER_MODE_MONO);
+                               msp3400c_setcarrier(client, state->second, state->main);
+                               /* volume prescale for SCART (AM mono input) */
+                               msp_write_dsp(client, 0x000d, 0x1900);
                                state->watch_stereo = 1;
                        } else if (max2 == 0 && state->has_nicam) {
                                /* D/K NICAM */
                                state->second = msp3400c_carrier_detect_65[max2].cdo;
-                               msp3400c_set_mode(client, MSP_MODE_FM_NICAM1);
+                               msp3400c_setmode(client, MSP_MODE_FM_NICAM1);
                                state->nicam_on = 1;
+                               msp3400c_setcarrier(client, state->second, state->main);
                                state->watch_stereo = 1;
                        } else {
                                goto no_second;
@@ -612,26 +616,24 @@ int msp3400c_thread(void *data)
                default:
                no_second:
                        state->second = msp3400c_carrier_detect_main[max1].cdo;
-                       msp3400c_set_mode(client, MSP_MODE_FM_TERRA);
+                       msp3400c_setmode(client, MSP_MODE_FM_TERRA);
+                       state->nicam_on = 0;
+                       msp3400c_setcarrier(client, state->second, state->main);
+                       state->rxsubchans = V4L2_TUNER_SUB_MONO;
+                       msp3400c_setstereo(client, V4L2_TUNER_MODE_MONO);
                        break;
                }
-               msp3400c_set_carrier(client, state->second, state->main);
 
                /* unmute */
-               state->scan_in_progress = 0;
-               msp3400c_set_audmode(client);
                msp_set_audio(client);
 
                if (msp_debug)
                        msp3400c_print_mode(client);
 
-               /* monitor tv audio mode, the first time don't wait
-                  so long to get a quick stereo/bilingual result */
-               count = 3;
+               /* monitor tv audio mode */
                while (state->watch_stereo) {
-                       if (msp_sleep(state, count ? 1000 : 5000))
+                       if (msp_sleep(state,5000))
                                goto restart;
-                       if (count) count--;
                        watch_stereo(client);
                }
        }
@@ -644,7 +646,7 @@ int msp3410d_thread(void *data)
 {
        struct i2c_client *client = data;
        struct msp_state *state = i2c_get_clientdata(client);
-       int val, i, std, count;
+       int val, i, std;
 
        v4l_dbg(1, msp_debug, client, "msp3410 daemon started\n");
 
@@ -654,7 +656,7 @@ int msp3410d_thread(void *data)
                v4l_dbg(2, msp_debug, client, "msp3410 thread: wakeup\n");
 
        restart:
-               v4l_dbg(2, msp_debug, client, "thread: restart scan\n");
+               v4l_dbg(1, msp_debug, client, "thread: restart scan\n");
                state->restart = 0;
                if (kthread_should_stop())
                        break;
@@ -662,30 +664,26 @@ int msp3410d_thread(void *data)
                if (state->mode == MSP_MODE_EXTERN) {
                        /* no carrier scan needed, just unmute */
                        v4l_dbg(1, msp_debug, client, "thread: no carrier scan\n");
-                       state->scan_in_progress = 0;
                        msp_set_audio(client);
                        continue;
                }
 
-               /* mute audio */
-               state->scan_in_progress = 1;
-               msp_set_audio(client);
+               /* put into sane state (and mute) */
+               msp_reset(client);
 
-               /* start autodetect. Note: autodetect is not supported for
-                  NTSC-M and radio, hence we force the standard in those cases. */
+               /* some time for the tuner to sync */
+               if (msp_sleep(state,200))
+                       goto restart;
+
+               /* start autodetect */
                if (state->radio)
                        std = 0x40;
                else
                        std = (state->v4l2_std & V4L2_STD_NTSC) ? 0x20 : 1;
                state->watch_stereo = 0;
-               state->nicam_on = 0;
-
-               /* wait for tuner to settle down after a channel change */
-               if (msp_sleep(state, 200))
-                       goto restart;
 
                if (msp_debug)
-                       v4l_dbg(2, msp_debug, client, "setting standard: %s (0x%04x)\n",
+                       v4l_dbg(1, msp_debug, client, "setting standard: %s (0x%04x)\n",
                               msp_standard_std_name(std), std);
 
                if (std != 1) {
@@ -702,7 +700,7 @@ int msp3410d_thread(void *data)
                                val = msp_read_dem(client, 0x7e);
                                if (val < 0x07ff)
                                        break;
-                               v4l_dbg(2, msp_debug, client, "detection still in progress\n");
+                               v4l_dbg(1, msp_debug, client, "detection still in progress\n");
                        }
                }
                for (i = 0; msp_stdlist[i].name != NULL; i++)
@@ -713,7 +711,6 @@ int msp3410d_thread(void *data)
                state->main   = msp_stdlist[i].main;
                state->second = msp_stdlist[i].second;
                state->std = val;
-               state->rxsubchans = V4L2_TUNER_SUB_MONO;
 
                if (msp_amsound && !state->radio && (state->v4l2_std & V4L2_STD_SECAM) &&
                                (val != 0x0009)) {
@@ -721,71 +718,83 @@ int msp3410d_thread(void *data)
                        v4l_dbg(1, msp_debug, client, "autodetection failed,"
                                " switching to backup standard: %s (0x%04x)\n",
                                msp_stdlist[8].name ? msp_stdlist[8].name : "unknown",val);
-                       state->std = val = 0x0009;
+                       val = 0x0009;
                        msp_write_dem(client, 0x20, val);
                }
 
+               /* set various prescales */
+               msp_write_dsp(client, 0x0d, 0x1900); /* scart */
+               msp_write_dsp(client, 0x0e, 0x2403); /* FM */
+               msp_write_dsp(client, 0x10, 0x5a00); /* nicam */
+
                /* set stereo */
                switch (val) {
                case 0x0008: /* B/G NICAM */
                case 0x000a: /* I NICAM */
-               case 0x000b: /* D/K NICAM */
-                       if (val == 0x000a)
-                               state->mode = MSP_MODE_FM_NICAM2;
-                       else
+                       if (val == 0x0008)
                                state->mode = MSP_MODE_FM_NICAM1;
+                       else
+                               state->mode = MSP_MODE_FM_NICAM2;
                        /* just turn on stereo */
+                       state->rxsubchans = V4L2_TUNER_SUB_STEREO;
                        state->nicam_on = 1;
                        state->watch_stereo = 1;
+                       msp3400c_setstereo(client,V4L2_TUNER_MODE_STEREO);
                        break;
                case 0x0009:
                        state->mode = MSP_MODE_AM_NICAM;
+                       state->rxsubchans = V4L2_TUNER_SUB_MONO;
                        state->nicam_on = 1;
+                       msp3400c_setstereo(client,V4L2_TUNER_MODE_MONO);
                        state->watch_stereo = 1;
                        break;
                case 0x0020: /* BTSC */
-                       /* The pre-'G' models only have BTSC-mono */
+                       /* just turn on stereo */
                        state->mode = MSP_MODE_BTSC;
+                       state->rxsubchans = V4L2_TUNER_SUB_STEREO;
+                       state->nicam_on = 0;
+                       state->watch_stereo = 1;
+                       msp3400c_setstereo(client,V4L2_TUNER_MODE_STEREO);
                        break;
                case 0x0040: /* FM radio */
                        state->mode = MSP_MODE_FM_RADIO;
                        state->rxsubchans = V4L2_TUNER_SUB_STEREO;
+                       state->audmode = V4L2_TUNER_MODE_STEREO;
+                       state->nicam_on = 0;
+                       state->watch_stereo = 0;
                        /* not needed in theory if we have radio, but
                           short programming enables carrier mute */
-                       msp3400c_set_mode(client, MSP_MODE_FM_RADIO);
-                       msp3400c_set_carrier(client, MSP_CARRIER(10.7),
+                       msp3400c_setmode(client, MSP_MODE_FM_RADIO);
+                       msp3400c_setcarrier(client, MSP_CARRIER(10.7),
                                            MSP_CARRIER(10.7));
+                       /* scart routing */
+                       msp_set_scart(client,SCART_IN2,0);
+                       /* msp34xx does radio decoding */
+                       msp_write_dsp(client, 0x08, 0x0020);
+                       msp_write_dsp(client, 0x09, 0x0020);
+                       msp_write_dsp(client, 0x0b, 0x0020);
                        break;
-               case 0x0002:
                case 0x0003:
                case 0x0004:
                case 0x0005:
                        state->mode = MSP_MODE_FM_TERRA;
+                       state->rxsubchans = V4L2_TUNER_SUB_MONO;
+                       state->audmode = V4L2_TUNER_MODE_MONO;
+                       state->nicam_on = 0;
                        state->watch_stereo = 1;
                        break;
                }
 
-               /* set various prescales */
-               msp_write_dsp(client, 0x0d, 0x1900); /* scart */
-               msp_write_dsp(client, 0x0e, 0x3000); /* FM */
-               if (state->has_nicam)
-                       msp_write_dsp(client, 0x10, 0x5a00); /* nicam */
-
+               /* unmute, restore misc registers */
+               msp_set_audio(client);
+               msp_write_dsp(client, 0x13, state->acb);
                if (state->has_i2s_conf)
                        msp_write_dem(client, 0x40, state->i2s_mode);
 
-               /* unmute */
-               msp3400c_set_audmode(client);
-               state->scan_in_progress = 0;
-               msp_set_audio(client);
-
-               /* monitor tv audio mode, the first time don't wait
-                  so long to get a quick stereo/bilingual result */
-               count = 3;
+               /* monitor tv audio mode */
                while (state->watch_stereo) {
-                       if (msp_sleep(state, count ? 1000 : 5000))
+                       if (msp_sleep(state,5000))
                                goto restart;
-                       if (count) count--;
                        watch_stereo(client);
                }
        }
@@ -795,150 +804,102 @@ int msp3410d_thread(void *data)
 
 /* ----------------------------------------------------------------------- */
 
-/* msp34xxG + (autoselect no-thread)
- * this one uses both automatic standard detection and automatic sound
- * select which are available in the newer G versions
- * struct msp: only norm, acb and source are really used in this mode
- */
+/* msp34xxG + (autoselect no-thread)                                       */
+/* this one uses both automatic standard detection and automatic sound     */
+/* select which are available in the newer G versions                      */
+/* struct msp: only norm, acb and source are really used in this mode      */
 
-static int msp34xxg_modus(struct i2c_client *client)
+/* set the same 'source' for the loudspeaker, scart and quasi-peak detector
+ * the value for source is the same as bit 15:8 of DSP registers 0x08,
+ * 0x0a and 0x0c: 0=mono, 1=stereo or A|B, 2=SCART, 3=stereo or A, 4=stereo or B
+ *
+ * this function replaces msp3400c_setstereo
+ */
+static void msp34xxg_set_source(struct i2c_client *client, int source)
 {
        struct msp_state *state = i2c_get_clientdata(client);
 
-       if (state->radio) {
-               v4l_dbg(1, msp_debug, client, "selected radio modus\n");
-               return 0x0001;
-       }
-
-       if (state->v4l2_std & V4L2_STD_PAL) {
-               v4l_dbg(1, msp_debug, client, "selected PAL modus\n");
-               return 0x7001;
-       }
-       if (state->v4l2_std == V4L2_STD_NTSC_M_JP) {
-               v4l_dbg(1, msp_debug, client, "selected M (EIA-J) modus\n");
-               return 0x4001;
-       }
-       if (state->v4l2_std == V4L2_STD_NTSC_M_KR) {
-               v4l_dbg(1, msp_debug, client, "selected M (A2) modus\n");
-               return 0x0001;
-       }
-       if (state->v4l2_std & V4L2_STD_MN) {
-               v4l_dbg(1, msp_debug, client, "selected M (BTSC) modus\n");
-               return 0x2001;
-       }
-       if (state->v4l2_std & V4L2_STD_SECAM) {
-               v4l_dbg(1, msp_debug, client, "selected SECAM modus\n");
-               return 0x6001;
-       }
-       return 0x0001;
-}
-
-static void msp34xxg_set_source(struct i2c_client *client, u16 reg, int in)
- {
-       struct msp_state *state = i2c_get_clientdata(client);
-       int source, matrix;
-
-       switch (state->audmode) {
-       case V4L2_TUNER_MODE_MONO:
-               source = 0; /* mono only */
-               matrix = 0x30;
-               break;
-       case V4L2_TUNER_MODE_LANG2:
-               source = 4; /* stereo or B */
-               matrix = 0x10;
-               break;
-       case V4L2_TUNER_MODE_LANG1_LANG2:
-               source = 1; /* stereo or A|B */
-               matrix = 0x20;
-               break;
-       case V4L2_TUNER_MODE_STEREO:
-       case V4L2_TUNER_MODE_LANG1:
-       default:
-               source = 3; /* stereo or A */
-               matrix = 0x00;
-               break;
-       }
-
-       if (in == MSP_DSP_IN_TUNER)
-               source = (source << 8) | 0x20;
-       /* the msp34x2g puts the MAIN_AVC, MAIN and AUX sources in 12, 13, 14
-          instead of 11, 12, 13. So we add one for that msp version. */
-       else if (in >= MSP_DSP_IN_MAIN_AVC && state->has_dolby_pro_logic)
-               source = ((in + 1) << 8) | matrix;
-       else
-               source = (in << 8) | matrix;
-
-       v4l_dbg(1, msp_debug, client, "set source to %d (0x%x) for output %02x\n",
-                       in, source, reg);
-       msp_write_dsp(client, reg, source);
-}
-
-static void msp34xxg_set_sources(struct i2c_client *client)
-{
-       struct msp_state *state = i2c_get_clientdata(client);
-       u32 in = state->routing.input;
-
-       msp34xxg_set_source(client, 0x0008, (in >> 4) & 0xf);
-       /* quasi-peak detector is set to same input as the loudspeaker (MAIN) */
-       msp34xxg_set_source(client, 0x000c, (in >> 4) & 0xf);
-       msp34xxg_set_source(client, 0x0009, (in >> 8) & 0xf);
-       msp34xxg_set_source(client, 0x000a, (in >> 12) & 0xf);
-       if (state->has_scart2_out)
-               msp34xxg_set_source(client, 0x0041, (in >> 16) & 0xf);
-       msp34xxg_set_source(client, 0x000b, (in >> 20) & 0xf);
+       /* fix matrix mode to stereo and let the msp choose what
+        * to output according to 'source', as recommended
+        * for MONO (source==0) downmixing set bit[7:0] to 0x30
+        */
+       int value = (source & 0x07) << 8 | (source == 0 ? 0x30 : 0x20);
+
+       v4l_dbg(1, msp_debug, client, "set source to %d (0x%x)\n", source, value);
+       /* Loudspeaker Output */
+       msp_write_dsp(client, 0x08, value);
+       /* SCART1 DA Output */
+       msp_write_dsp(client, 0x0a, value);
+       /* Quasi-peak detector */
+       msp_write_dsp(client, 0x0c, value);
+       /*
+        * set identification threshold. Personally, I
+        * I set it to a higher value that the default
+        * of 0x190 to ignore noisy stereo signals.
+        * this needs tuning. (recommended range 0x00a0-0x03c0)
+        * 0x7f0 = forced mono mode
+        */
+       /* a2 threshold for stereo/bilingual */
+       msp_write_dem(client, 0x22, msp_stereo_thresh);
+       state->source = source;
 }
 
-/* (re-)initialize the msp34xxg */
-static void msp34xxg_reset(struct i2c_client *client)
+/* (re-)initialize the msp34xxg, according to the current norm in state->norm
+ * return 0 if it worked, -1 if it failed
+ */
+static int msp34xxg_reset(struct i2c_client *client)
 {
        struct msp_state *state = i2c_get_clientdata(client);
-       int tuner = (state->routing.input >> 3) & 1;
-       int modus;
+       int modus, std;
 
-       /* initialize std to 1 (autodetect) to signal that no standard is
-          selected yet. */
-       state->std = 1;
+       if (msp_reset(client))
+               return -1;
 
-       msp_reset(client);
+       /* make sure that input/output is muted (paranoid mode) */
+       /* ACB, mute DSP input, mute SCART 1 */
+       if (msp_write_dsp(client, 0x13, 0x0f20))
+               return -1;
 
        if (state->has_i2s_conf)
                msp_write_dem(client, 0x40, state->i2s_mode);
 
        /* step-by-step initialisation, as described in the manual */
-       modus = msp34xxg_modus(client);
-       modus |= tuner ? 0x100 : 0;
-       msp_write_dem(client, 0x30, modus);
+       modus = msp_modus(client);
+       if (state->radio)
+               std = 0x40;
+       else
+               std = (state->v4l2_std & V4L2_STD_NTSC) ? 0x20 : 1;
+       modus &= ~0x03; /* STATUS_CHANGE = 0 */
+       modus |= 0x01;  /* AUTOMATIC_SOUND_DETECTION = 1 */
+       if (msp_write_dem(client, 0x30, modus))
+               return -1;
+       if (msp_write_dem(client, 0x20, std))
+               return -1;
 
        /* write the dsps that may have an influence on
           standard/audio autodetection right now */
-       msp34xxg_set_sources(client);
+       msp34xxg_set_source(client, state->source);
 
-       msp_write_dsp(client, 0x0d, 0x1900); /* scart */
-       msp_write_dsp(client, 0x0e, 0x3000); /* FM */
-       if (state->has_nicam)
-               msp_write_dsp(client, 0x10, 0x5a00); /* nicam */
+       /* AM/FM Prescale [15:8] 75khz deviation */
+       if (msp_write_dsp(client, 0x0e, 0x3000))
+               return -1;
 
-       /* set identification threshold. Personally, I
-        * I set it to a higher value than the default
-        * of 0x190 to ignore noisy stereo signals.
-        * this needs tuning. (recommended range 0x00a0-0x03c0)
-        * 0x7f0 = forced mono mode
-        *
-        * a2 threshold for stereo/bilingual.
-        * Note: this register is part of the Manual/Compatibility mode.
-        * It is supported by all 'G'-family chips.
-        */
-       msp_write_dem(client, 0x22, msp_stereo_thresh);
+       /* NICAM Prescale 9db gain (as recommended) */
+       if (msp_write_dsp(client, 0x10, 0x5a00))
+               return -1;
+
+       return 0;
 }
 
 int msp34xxg_thread(void *data)
 {
        struct i2c_client *client = data;
        struct msp_state *state = i2c_get_clientdata(client);
-       int val, i;
+       int val, std, i;
 
        v4l_dbg(1, msp_debug, client, "msp34xxg daemon started\n");
 
+       state->source = 1; /* default */
        for (;;) {
                v4l_dbg(2, msp_debug, client, "msp34xxg thread: sleep\n");
                msp_sleep(state, -1);
@@ -950,25 +911,14 @@ int msp34xxg_thread(void *data)
                if (kthread_should_stop())
                        break;
 
-               if (state->mode == MSP_MODE_EXTERN) {
-                       /* no carrier scan needed, just unmute */
-                       v4l_dbg(1, msp_debug, client, "thread: no carrier scan\n");
-                       state->scan_in_progress = 0;
-                       msp_set_audio(client);
-                       continue;
-               }
-
                /* setup the chip*/
                msp34xxg_reset(client);
-               state->std = state->radio ? 0x40 :
-                       (state->force_btsc && msp_standard == 1) ? 32 : msp_standard;
-               msp_write_dem(client, 0x20, state->std);
-               /* start autodetect */
-               if (state->std != 1)
+               std = msp_standard;
+               if (std != 0x01)
                        goto unmute;
 
                /* watch autodetect */
-               v4l_dbg(1, msp_debug, client, "started autodetect, waiting for result\n");
+               v4l_dbg(1, msp_debug, client, "triggered autodetect, waiting for result\n");
                for (i = 0; i < 10; i++) {
                        if (msp_sleep(state, 100))
                                goto restart;
@@ -976,24 +926,20 @@ int msp34xxg_thread(void *data)
                        /* check results */
                        val = msp_read_dem(client, 0x7e);
                        if (val < 0x07ff) {
-                               state->std = val;
+                               std = val;
                                break;
                        }
                        v4l_dbg(2, msp_debug, client, "detection still in progress\n");
                }
-               if (state->std == 1) {
+               if (std == 1) {
                        v4l_dbg(1, msp_debug, client, "detection still in progress after 10 tries. giving up.\n");
                        continue;
                }
 
        unmute:
-               v4l_dbg(1, msp_debug, client, "detected standard: %s (0x%04x)\n",
-                       msp_standard_std_name(state->std), state->std);
-
-               if (state->std == 9) {
-                       /* AM NICAM mode */
-                       msp_write_dsp(client, 0x0e, 0x7c00);
-               }
+               state->std = std;
+               v4l_dbg(1, msp_debug, client, "current standard: %s (0x%04x)\n",
+                       msp_standard_std_name(std), std);
 
                /* unmute: dispatch sound to scart output, set scart volume */
                msp_set_audio(client);
@@ -1002,93 +948,63 @@ int msp34xxg_thread(void *data)
                if (msp_write_dsp(client, 0x13, state->acb))
                        return -1;
 
-               /* the periodic stereo/SAP check is only relevant for
-                  the 0x20 standard (BTSC) */
-               if (state->std != 0x20)
-                       continue;
-
-               state->watch_stereo = 1;
-
-               /* monitor tv audio mode, the first time don't wait
-                  in order to get a quick stereo/SAP update */
-               watch_stereo(client);
-               while (state->watch_stereo) {
-                       watch_stereo(client);
-                       if (msp_sleep(state, 5000))
-                               goto restart;
-               }
+               msp_write_dem(client, 0x40, state->i2s_mode);
        }
        v4l_dbg(1, msp_debug, client, "thread: exit\n");
        return 0;
 }
 
-static int msp34xxg_detect_stereo(struct i2c_client *client)
+void msp34xxg_detect_stereo(struct i2c_client *client)
 {
        struct msp_state *state = i2c_get_clientdata(client);
+
        int status = msp_read_dem(client, 0x0200);
        int is_bilingual = status & 0x100;
        int is_stereo = status & 0x40;
-       int oldrx = state->rxsubchans;
 
        state->rxsubchans = 0;
        if (is_stereo)
-               state->rxsubchans = V4L2_TUNER_SUB_STEREO;
+               state->rxsubchans |= V4L2_TUNER_SUB_STEREO;
        else
-               state->rxsubchans = V4L2_TUNER_SUB_MONO;
+               state->rxsubchans |= V4L2_TUNER_SUB_MONO;
        if (is_bilingual) {
-               if (state->std == 0x20)
-                       state->rxsubchans |= V4L2_TUNER_SUB_SAP;
-               else
-                       state->rxsubchans = V4L2_TUNER_SUB_LANG1 | V4L2_TUNER_SUB_LANG2;
+               state->rxsubchans |= V4L2_TUNER_SUB_LANG1 | V4L2_TUNER_SUB_LANG2;
+               /* I'm supposed to check whether it's SAP or not
+                * and set only LANG2/SAP in this case. Yet, the MSP
+                * does a lot of work to hide this and handle everything
+                * the same way. I don't want to work around it so unless
+                * this is a problem, I'll handle SAP just like lang1/lang2.
+                */
        }
        v4l_dbg(1, msp_debug, client, "status=0x%x, stereo=%d, bilingual=%d -> rxsubchans=%d\n",
                status, is_stereo, is_bilingual, state->rxsubchans);
-       return (oldrx != state->rxsubchans);
-}
-
-static void msp34xxg_set_audmode(struct i2c_client *client)
-{
-       struct msp_state *state = i2c_get_clientdata(client);
-
-       if (state->std == 0x20) {
-              if ((state->rxsubchans & V4L2_TUNER_SUB_SAP) &&
-                  (state->audmode == V4L2_TUNER_MODE_LANG1_LANG2 ||
-                   state->audmode == V4L2_TUNER_MODE_LANG2)) {
-                       msp_write_dem(client, 0x20, 0x21);
-              } else {
-                       msp_write_dem(client, 0x20, 0x20);
-              }
-       }
-
-       msp34xxg_set_sources(client);
 }
 
-void msp_set_audmode(struct i2c_client *client)
+void msp34xxg_set_audmode(struct i2c_client *client, int audmode)
 {
        struct msp_state *state = i2c_get_clientdata(client);
+       int source;
 
-       switch (state->opmode) {
-       case OPMODE_MANUAL:
-       case OPMODE_AUTODETECT:
-               msp3400c_set_audmode(client);
+       switch (audmode) {
+       case V4L2_TUNER_MODE_MONO:
+               source = 0; /* mono only */
                break;
-       case OPMODE_AUTOSELECT:
-               msp34xxg_set_audmode(client);
+       case V4L2_TUNER_MODE_STEREO:
+               source = 1; /* stereo or A|B, see comment in msp34xxg_get_v4l2_stereo() */
+               /* problem: that could also mean 2 (scart input) */
+               break;
+       case V4L2_TUNER_MODE_LANG1:
+               source = 3; /* stereo or A */
+               break;
+       case V4L2_TUNER_MODE_LANG2:
+               source = 4; /* stereo or B */
+               break;
+       default:
+               audmode = 0;
+               source  = 1;
                break;
        }
-}
-
-int msp_detect_stereo(struct i2c_client *client)
-{
-       struct msp_state *state  = i2c_get_clientdata(client);
-
-       switch (state->opmode) {
-       case OPMODE_MANUAL:
-       case OPMODE_AUTODETECT:
-               return msp3400c_detect_stereo(client);
-       case OPMODE_AUTOSELECT:
-               return msp34xxg_detect_stereo(client);
-       }
-       return 0;
+       state->audmode = audmode;
+       msp34xxg_set_source(client, source);
 }