Fedora kernel-2.6.17-1.2142_FC4 patched with stable patch-2.6.17.4-vs2.0.2-rc26.diff
[linux-2.6.git] / drivers / mtd / maps / pcmciamtd.c
index e37b4c1..d27f412 100644 (file)
@@ -1,5 +1,5 @@
 /*
- * $Id: pcmciamtd.c,v 1.51 2004/07/12 22:38:29 dwmw2 Exp $
+ * $Id: pcmciamtd.c,v 1.55 2005/11/07 11:14:28 gleixner Exp $
  *
  * pcmciamtd.c - MTD driver for PCMCIA flash memory cards
  *
@@ -18,7 +18,6 @@
 #include <asm/io.h>
 #include <asm/system.h>
 
-#include <pcmcia/version.h>
 #include <pcmcia/cs_types.h>
 #include <pcmcia/cs.h>
 #include <pcmcia/cistpl.h>
@@ -29,7 +28,7 @@
 
 #ifdef CONFIG_MTD_DEBUG
 static int debug = CONFIG_MTD_DEBUG_VERBOSE;
-MODULE_PARM(debug, "i");
+module_param(debug, int, 0);
 MODULE_PARM_DESC(debug, "Set Debug Level 0=quiet, 5=noisy");
 #undef DEBUG
 #define DEBUG(n, format, arg...) \
@@ -49,13 +48,13 @@ static const int debug = 0;
 
 
 #define DRIVER_DESC    "PCMCIA Flash memory card driver"
-#define DRIVER_VERSION "$Revision: 1.51 $"
+#define DRIVER_VERSION "$Revision: 1.55 $"
 
 /* Size of the PCMCIA address space: 26 bits = 64 MB */
 #define MAX_PCMCIA_ADDR        0x4000000
 
 struct pcmciamtd_dev {
-       dev_link_t      link;           /* PCMCIA link */
+       struct pcmcia_device    *p_dev;
        dev_node_t      node;           /* device node */
        caddr_t         win_base;       /* ioremapped address of PCMCIA window */
        unsigned int    win_size;       /* size of window */
@@ -67,9 +66,6 @@ struct pcmciamtd_dev {
 };
 
 
-static dev_info_t dev_info = "pcmciamtd";
-static dev_link_t *dev_list;
-
 /* Module parameters */
 
 /* 2 = do 16-bit transfers, 1 = do 8-bit transfers */
@@ -93,17 +89,17 @@ static int mem_type;
 MODULE_LICENSE("GPL");
 MODULE_AUTHOR("Simon Evans <spse@secret.org.uk>");
 MODULE_DESCRIPTION(DRIVER_DESC);
-MODULE_PARM(bankwidth, "i");
+module_param(bankwidth, int, 0);
 MODULE_PARM_DESC(bankwidth, "Set bankwidth (1=8 bit, 2=16 bit, default=2)");
-MODULE_PARM(mem_speed, "i");
+module_param(mem_speed, int, 0);
 MODULE_PARM_DESC(mem_speed, "Set memory access speed in ns");
-MODULE_PARM(force_size, "i");
+module_param(force_size, int, 0);
 MODULE_PARM_DESC(force_size, "Force size of card in MiB (1-64)");
-MODULE_PARM(setvpp, "i");
+module_param(setvpp, int, 0);
 MODULE_PARM_DESC(setvpp, "Set Vpp (0=Never, 1=On writes, 2=Always on, default=0)");
-MODULE_PARM(vpp, "i");
+module_param(vpp, int, 0);
 MODULE_PARM_DESC(vpp, "Vpp value in 1/10ths eg 33=3.3V 120=12V (Dangerous)");
-MODULE_PARM(mem_type, "i");
+module_param(mem_type, int, 0);
 MODULE_PARM_DESC(mem_type, "Set Memory type (0=Flash, 1=RAM, 2=ROM, default=0)");
 
 
@@ -115,8 +111,8 @@ static caddr_t remap_window(struct map_info *map, unsigned long to)
        memreq_t mrq;
        int ret;
 
-       if(!(dev->link.state & DEV_PRESENT)) {
-               DEBUG(1, "device removed state = 0x%4.4X", dev->link.state);
+       if (!pcmcia_dev_present(dev->p_dev)) {
+               DEBUG(1, "device removed");
                return 0;
        }
 
@@ -126,7 +122,7 @@ static caddr_t remap_window(struct map_info *map, unsigned long to)
                      dev->offset, mrq.CardOffset);
                mrq.Page = 0;
                if( (ret = pcmcia_map_mem_page(win, &mrq)) != CS_SUCCESS) {
-                       cs_error(dev->link.handle, MapMemPage, ret);
+                       cs_error(dev->p_dev, MapMemPage, ret);
                        return NULL;
                }
                dev->offset = mrq.CardOffset;
@@ -177,7 +173,7 @@ static void pcmcia_copy_from_remap(struct map_info *map, void *to, unsigned long
 
                if(toread > len)
                        toread = len;
-               
+
                addr = remap_window(map, from);
                if(!addr)
                        return;
@@ -242,7 +238,7 @@ static void pcmcia_copy_to_remap(struct map_info *map, unsigned long to, const v
 
 /* read/write{8,16} copy_{from,to} routines with direct access */
 
-#define DEV_REMOVED(x)  (!(*(u_int *)x->map_priv_1 & DEV_PRESENT))
+#define DEV_REMOVED(x)  (!(pcmcia_dev_present(((struct pcmciamtd_dev *)map->map_priv_1)->p_dev)))
 
 static map_word pcmcia_read8(struct map_info *map, unsigned long ofs)
 {
@@ -323,7 +319,7 @@ static void pcmcia_copy_to(struct map_info *map, unsigned long to, const void *f
 static void pcmciamtd_set_vpp(struct map_info *map, int on)
 {
        struct pcmciamtd_dev *dev = (struct pcmciamtd_dev *)map->map_priv_1;
-       dev_link_t *link = &dev->link;
+       struct pcmcia_device *link = dev->p_dev;
        modconf_t mod;
        int ret;
 
@@ -332,9 +328,9 @@ static void pcmciamtd_set_vpp(struct map_info *map, int on)
        mod.Vpp1 = mod.Vpp2 = on ? dev->vpp : 0;
 
        DEBUG(2, "dev = %p on = %d vpp = %d\n", dev, on, dev->vpp);
-       ret = pcmcia_modify_configuration(link->handle, &mod);
+       ret = pcmcia_modify_configuration(link, &mod);
        if(ret != CS_SUCCESS) {
-               cs_error(link->handle, ModifyConfiguration, ret);
+               cs_error(link, ModifyConfiguration, ret);
        }
 }
 
@@ -344,7 +340,7 @@ static void pcmciamtd_set_vpp(struct map_info *map, int on)
  * still open, this will be postponed until it is closed.
  */
 
-static void pcmciamtd_release(dev_link_t *link)
+static void pcmciamtd_release(struct pcmcia_device *link)
 {
        struct pcmciamtd_dev *dev = link->priv;
 
@@ -357,12 +353,11 @@ static void pcmciamtd_release(dev_link_t *link)
                }
                pcmcia_release_window(link->win);
        }
-       pcmcia_release_configuration(link->handle);
-       link->state &= ~DEV_CONFIG;
+       pcmcia_disable_device(link);
 }
 
 
-static void card_settings(struct pcmciamtd_dev *dev, dev_link_t *link, int *new_name)
+static void card_settings(struct pcmciamtd_dev *dev, struct pcmcia_device *link, int *new_name)
 {
        int rc;
        tuple_t tuple;
@@ -375,19 +370,19 @@ static void card_settings(struct pcmciamtd_dev *dev, dev_link_t *link, int *new_
        tuple.TupleOffset = 0;
        tuple.DesiredTuple = RETURN_FIRST_TUPLE;
 
-       rc = pcmcia_get_first_tuple(link->handle, &tuple);
+       rc = pcmcia_get_first_tuple(link, &tuple);
        while(rc == CS_SUCCESS) {
-               rc = pcmcia_get_tuple_data(link->handle, &tuple);
+               rc = pcmcia_get_tuple_data(link, &tuple);
                if(rc != CS_SUCCESS) {
-                       cs_error(link->handle, GetTupleData, rc);
+                       cs_error(link, GetTupleData, rc);
                        break;
                }
-               rc = pcmcia_parse_tuple(link->handle, &tuple, &parse);
+               rc = pcmcia_parse_tuple(link, &tuple, &parse);
                if(rc != CS_SUCCESS) {
-                       cs_error(link->handle, ParseTuple, rc);
+                       cs_error(link, ParseTuple, rc);
                        break;
                }
-               
+
                switch(tuple.TupleCode) {
                case  CISTPL_FORMAT: {
                        cistpl_format_t *t = &parse.format;
@@ -395,9 +390,9 @@ static void card_settings(struct pcmciamtd_dev *dev, dev_link_t *link, int *new_
                        DEBUG(2, "Format type: %u, Error Detection: %u, offset = %u, length =%u",
                              t->type, t->edc, t->offset, t->length);
                        break;
-                       
+
                }
-                       
+
                case CISTPL_DEVICE: {
                        cistpl_device_t *t = &parse.device;
                        int i;
@@ -411,7 +406,7 @@ static void card_settings(struct pcmciamtd_dev *dev, dev_link_t *link, int *new_
                        }
                        break;
                }
-                       
+
                case CISTPL_VERS_1: {
                        cistpl_vers_1_t *t = &parse.version_1;
                        int i;
@@ -426,7 +421,7 @@ static void card_settings(struct pcmciamtd_dev *dev, dev_link_t *link, int *new_
                        DEBUG(2, "Found name: %s", dev->mtd_name);
                        break;
                }
-                       
+
                case CISTPL_JEDEC_C: {
                        cistpl_jedec_t *t = &parse.jedec;
                        int i;
@@ -435,7 +430,7 @@ static void card_settings(struct pcmciamtd_dev *dev, dev_link_t *link, int *new_
                        }
                        break;
                }
-                       
+
                case CISTPL_DEVICE_GEO: {
                        cistpl_device_geo_t *t = &parse.device_geo;
                        int i;
@@ -450,12 +445,12 @@ static void card_settings(struct pcmciamtd_dev *dev, dev_link_t *link, int *new_
                        }
                        break;
                }
-                       
+
                default:
                        DEBUG(2, "Unknown tuple code %d", tuple.TupleCode);
                }
-               
-               rc = pcmcia_get_next_tuple(link->handle, &tuple);
+
+               rc = pcmcia_get_next_tuple(link, &tuple);
        }
        if(!dev->pcmcia_map.size)
                dev->pcmcia_map.size = MAX_PCMCIA_ADDR;
@@ -471,7 +466,7 @@ static void card_settings(struct pcmciamtd_dev *dev, dev_link_t *link, int *new_
        if(bankwidth) {
                dev->pcmcia_map.bankwidth = bankwidth;
                DEBUG(2, "bankwidth forced to %d", bankwidth);
-       }               
+       }
 
        dev->pcmcia_map.name = dev->mtd_name;
        if(!dev->mtd_name[0]) {
@@ -492,7 +487,7 @@ static void card_settings(struct pcmciamtd_dev *dev, dev_link_t *link, int *new_
 #define CS_CHECK(fn, ret) \
 do { last_fn = (fn); if ((last_ret = (ret)) != 0) goto cs_failed; } while (0)
 
-static void pcmciamtd_config(dev_link_t *link)
+static int pcmciamtd_config(struct pcmcia_device *link)
 {
        struct pcmciamtd_dev *dev = link->priv;
        struct mtd_info *mtd = NULL;
@@ -508,13 +503,10 @@ static void pcmciamtd_config(dev_link_t *link)
 
        DEBUG(3, "link=0x%p", link);
 
-       /* Configure card */
-       link->state |= DEV_CONFIG;
-
        DEBUG(2, "Validating CIS");
-       ret = pcmcia_validate_cis(link->handle, &cisinfo);
+       ret = pcmcia_validate_cis(link, &cisinfo);
        if(ret != CS_SUCCESS) {
-               cs_error(link->handle, GetTupleData, ret);
+               cs_error(link, GetTupleData, ret);
        } else {
                DEBUG(2, "ValidateCIS found %d chains", cisinfo.Chains);
        }
@@ -542,7 +534,7 @@ static void pcmciamtd_config(dev_link_t *link)
        req.Attributes |= (dev->pcmcia_map.bankwidth == 1) ? WIN_DATA_WIDTH_8 : WIN_DATA_WIDTH_16;
        req.Base = 0;
        req.AccessSpeed = mem_speed;
-       link->win = (window_handle_t)link->handle;
+       link->win = (window_handle_t)link;
        req.Size = (force_size) ? force_size << 20 : MAX_PCMCIA_ADDR;
        dev->win_size = 0;
 
@@ -550,7 +542,7 @@ static void pcmciamtd_config(dev_link_t *link)
                int ret;
                DEBUG(2, "requesting window with size = %dKiB memspeed = %d",
                      req.Size >> 10, req.AccessSpeed);
-               ret = pcmcia_request_window(&link->handle, &req, &link->win);
+               ret = pcmcia_request_window(&link, &req, &link->win);
                DEBUG(2, "ret = %d dev->win_size = %d", ret, dev->win_size);
                if(ret) {
                        req.Size >>= 1;
@@ -566,19 +558,19 @@ static void pcmciamtd_config(dev_link_t *link)
        if(!dev->win_size) {
                err("Cant allocate memory window");
                pcmciamtd_release(link);
-               return;
+               return -ENODEV;
        }
        DEBUG(1, "Allocated a window of %dKiB", dev->win_size >> 10);
-               
+
        /* Get write protect status */
-       CS_CHECK(GetStatus, pcmcia_get_status(link->handle, &status));
+       CS_CHECK(GetStatus, pcmcia_get_status(link, &status));
        DEBUG(2, "status value: 0x%x window handle = 0x%8.8lx",
              status.CardState, (unsigned long)link->win);
        dev->win_base = ioremap(req.Base, req.Size);
        if(!dev->win_base) {
                err("ioremap(%lu, %u) failed", req.Base, req.Size);
                pcmciamtd_release(link);
-               return;
+               return -ENODEV;
        }
        DEBUG(1, "mapped window dev = %p req.base = 0x%lx base = %p size = 0x%x",
              dev, req.Base, dev->win_base, req.Size);
@@ -588,17 +580,14 @@ static void pcmciamtd_config(dev_link_t *link)
        dev->pcmcia_map.map_priv_2 = (unsigned long)link->win;
 
        DEBUG(2, "Getting configuration");
-       CS_CHECK(GetConfigurationInfo, pcmcia_get_configuration_info(link->handle, &t));
+       CS_CHECK(GetConfigurationInfo, pcmcia_get_configuration_info(link, &t));
        DEBUG(2, "Vcc = %d Vpp1 = %d Vpp2 = %d", t.Vcc, t.Vpp1, t.Vpp2);
        dev->vpp = (vpp) ? vpp : t.Vpp1;
        link->conf.Attributes = 0;
-       link->conf.Vcc = t.Vcc;
        if(setvpp == 2) {
-               link->conf.Vpp1 = dev->vpp;
-               link->conf.Vpp2 = dev->vpp;
+               link->conf.Vpp = dev->vpp;
        } else {
-               link->conf.Vpp1 = 0;
-               link->conf.Vpp2 = 0;
+               link->conf.Vpp = 0;
        }
 
        link->conf.IntType = INT_MEMORY;
@@ -610,9 +599,10 @@ static void pcmciamtd_config(dev_link_t *link)
        link->conf.ConfigIndex = 0;
        link->conf.Present = t.Present;
        DEBUG(2, "Setting Configuration");
-       ret = pcmcia_request_configuration(link->handle, &link->conf);
+       ret = pcmcia_request_configuration(link, &link->conf);
        if(ret != CS_SUCCESS) {
-               cs_error(link->handle, RequestConfiguration, ret);
+               cs_error(link, RequestConfiguration, ret);
+               return -ENODEV;
        }
 
        if(mem_type == 1) {
@@ -620,20 +610,20 @@ static void pcmciamtd_config(dev_link_t *link)
        } else if(mem_type == 2) {
                mtd = do_map_probe("map_rom", &dev->pcmcia_map);
        } else {
-               for(i = 0; i < sizeof(probes) / sizeof(char *); i++) {
+               for(i = 0; i < ARRAY_SIZE(probes); i++) {
                        DEBUG(1, "Trying %s", probes[i]);
                        mtd = do_map_probe(probes[i], &dev->pcmcia_map);
                        if(mtd)
                                break;
-                       
+
                        DEBUG(1, "FAILED: %s", probes[i]);
                }
        }
-       
+
        if(!mtd) {
                DEBUG(1, "Cant find an MTD");
                pcmciamtd_release(link);
-               return;
+               return -ENODEV;
        }
 
        dev->mtd_info = mtd;
@@ -658,7 +648,6 @@ static void pcmciamtd_config(dev_link_t *link)
           use the faster non-remapping read/write functions */
        if(mtd->size <= dev->win_size) {
                DEBUG(1, "Using non remapping memory functions");
-               dev->pcmcia_map.map_priv_1 = (unsigned long)&(dev->link.state);
                dev->pcmcia_map.map_priv_2 = (unsigned long)dev->win_base;
                if (dev->pcmcia_map.bankwidth == 1) {
                        dev->pcmcia_map.read = pcmcia_read8;
@@ -676,71 +665,36 @@ static void pcmciamtd_config(dev_link_t *link)
                dev->mtd_info = NULL;
                err("Couldnt register MTD device");
                pcmciamtd_release(link);
-               return;
+               return -ENODEV;
        }
        snprintf(dev->node.dev_name, sizeof(dev->node.dev_name), "mtd%d", mtd->index);
        info("mtd%d: %s", mtd->index, mtd->name);
-       link->state &= ~DEV_CONFIG_PENDING;
-       link->dev = &dev->node;
-       return;
+       link->dev_node = &dev->node;
+       return 0;
 
  cs_failed:
-       cs_error(link->handle, last_fn, last_ret);
+       cs_error(link, last_fn, last_ret);
        err("CS Error, exiting");
        pcmciamtd_release(link);
-       return;
+       return -ENODEV;
 }
 
 
-/* The card status event handler.  Mostly, this schedules other
- * stuff to run after an event is received.  A CARD_REMOVAL event
- * also sets some flags to discourage the driver from trying
- * to talk to the card any more.
- */
+static int pcmciamtd_suspend(struct pcmcia_device *dev)
+{
+       DEBUG(2, "EVENT_PM_RESUME");
+
+       /* get_lock(link); */
+
+       return 0;
+}
 
-static int pcmciamtd_event(event_t event, int priority,
-                       event_callback_args_t *args)
+static int pcmciamtd_resume(struct pcmcia_device *dev)
 {
-       dev_link_t *link = args->client_data;
-
-       DEBUG(1, "event=0x%06x", event);
-       switch (event) {
-       case CS_EVENT_CARD_REMOVAL:
-               DEBUG(2, "EVENT_CARD_REMOVAL");
-               link->state &= ~DEV_PRESENT;
-               if (link->state & DEV_CONFIG) {
-                       struct pcmciamtd_dev *dev = link->priv;
-                       if(dev->mtd_info) {
-                               del_mtd_device(dev->mtd_info);
-                               info("mtd%d: Removed", dev->mtd_info->index);
-                       }
-                       pcmciamtd_release(link);
-               }
-               break;
-       case CS_EVENT_CARD_INSERTION:
-               DEBUG(2, "EVENT_CARD_INSERTION");
-               link->state |= DEV_PRESENT | DEV_CONFIG_PENDING;
-               pcmciamtd_config(link);
-               break;
-       case CS_EVENT_PM_SUSPEND:
-               DEBUG(2, "EVENT_PM_SUSPEND");
-               link->state |= DEV_SUSPEND;
-               /* Fall through... */
-       case CS_EVENT_RESET_PHYSICAL:
-               DEBUG(2, "EVENT_RESET_PHYSICAL");
-               /* get_lock(link); */
-               break;
-       case CS_EVENT_PM_RESUME:
-               DEBUG(2, "EVENT_PM_RESUME");
-               link->state &= ~DEV_SUSPEND;
-               /* Fall through... */
-       case CS_EVENT_CARD_RESET:
-               DEBUG(2, "EVENT_CARD_RESET");
-               /* free_lock(link); */
-               break;
-       default:
-               DEBUG(2, "Unknown event %d", event);
-       }
+       DEBUG(2, "EVENT_PM_SUSPEND");
+
+       /* free_lock(link); */
+
        return 0;
 }
 
@@ -751,23 +705,18 @@ static int pcmciamtd_event(event_t event, int priority,
  * when the device is released.
  */
 
-static void pcmciamtd_detach(dev_link_t *link)
+static void pcmciamtd_detach(struct pcmcia_device *link)
 {
-       DEBUG(3, "link=0x%p", link);
+       struct pcmciamtd_dev *dev = link->priv;
 
-       if(link->state & DEV_CONFIG) {
-               pcmciamtd_release(link);
-       }
+       DEBUG(3, "link=0x%p", link);
 
-       if (link->handle) {
-               int ret;
-               DEBUG(2, "Deregistering with card services");
-               ret = pcmcia_deregister_client(link->handle);
-               if (ret != CS_SUCCESS)
-                       cs_error(link->handle, DeregisterClient, ret);
+       if(dev->mtd_info) {
+               del_mtd_device(dev->mtd_info);
+               info("mtd%d: Removed", dev->mtd_info->index);
        }
 
-       link->state |= DEV_STALE_LINK;
+       pcmciamtd_release(link);
 }
 
 
@@ -776,56 +725,62 @@ static void pcmciamtd_detach(dev_link_t *link)
  * with Card Services.
  */
 
-static dev_link_t *pcmciamtd_attach(void)
+static int pcmciamtd_probe(struct pcmcia_device *link)
 {
        struct pcmciamtd_dev *dev;
-       dev_link_t *link;
-       client_reg_t client_reg;
-       int ret;
 
        /* Create new memory card device */
        dev = kmalloc(sizeof(*dev), GFP_KERNEL);
-       if (!dev) return NULL;
+       if (!dev) return -ENOMEM;
        DEBUG(1, "dev=0x%p", dev);
 
        memset(dev, 0, sizeof(*dev));
-       link = &dev->link;
+       dev->p_dev = link;
        link->priv = dev;
 
        link->conf.Attributes = 0;
        link->conf.IntType = INT_MEMORY;
 
-       link->next = dev_list;
-       dev_list = link;
-
-       /* Register with Card Services */
-       client_reg.dev_info = &dev_info;
-       client_reg.EventMask =
-               CS_EVENT_RESET_PHYSICAL | CS_EVENT_CARD_RESET |
-               CS_EVENT_CARD_INSERTION | CS_EVENT_CARD_REMOVAL |
-               CS_EVENT_PM_SUSPEND | CS_EVENT_PM_RESUME;
-       client_reg.event_handler = &pcmciamtd_event;
-       client_reg.Version = 0x0210;
-       client_reg.event_callback_args.client_data = link;
-       DEBUG(2, "Calling RegisterClient");
-       ret = pcmcia_register_client(&link->handle, &client_reg);
-       if (ret != 0) {
-               cs_error(link->handle, RegisterClient, ret);
-               pcmciamtd_detach(link);
-               return NULL;
-       }
-       DEBUG(2, "link = %p", link);
-       return link;
+       return pcmciamtd_config(link);
 }
 
+static struct pcmcia_device_id pcmciamtd_ids[] = {
+       PCMCIA_DEVICE_FUNC_ID(1),
+       PCMCIA_DEVICE_PROD_ID123("IO DATA", "PCS-2M", "2MB SRAM", 0x547e66dc, 0x1fed36cd, 0x36eadd21),
+       PCMCIA_DEVICE_PROD_ID12("IBM", "2MB SRAM", 0xb569a6e5, 0x36eadd21),
+       PCMCIA_DEVICE_PROD_ID12("IBM", "4MB FLASH", 0xb569a6e5, 0x8bc54d2a),
+       PCMCIA_DEVICE_PROD_ID12("IBM", "8MB FLASH", 0xb569a6e5, 0x6df1be3e),
+       PCMCIA_DEVICE_PROD_ID12("Intel", "S2E20SW", 0x816cc815, 0xd14c9dcf),
+       PCMCIA_DEVICE_PROD_ID12("Intel", "S2E8 SW", 0x816cc815, 0xa2d7dedb),
+       PCMCIA_DEVICE_PROD_ID12("intel", "SERIES2-02 ", 0x40ade711, 0x145cea5c),
+       PCMCIA_DEVICE_PROD_ID12("intel", "SERIES2-04 ", 0x40ade711, 0x42064dda),
+       PCMCIA_DEVICE_PROD_ID12("intel", "SERIES2-20 ", 0x40ade711, 0x25ee5cb0),
+       PCMCIA_DEVICE_PROD_ID12("intel", "VALUE SERIES 100 ", 0x40ade711, 0xdf8506d8),
+       PCMCIA_DEVICE_PROD_ID12("KINGMAX TECHNOLOGY INC.", "SRAM 256K Bytes", 0x54d0c69c, 0xad12c29c),
+       PCMCIA_DEVICE_PROD_ID12("Maxtor", "MAXFL MobileMax Flash Memory Card", 0xb68968c8, 0x2dfb47b0),
+       PCMCIA_DEVICE_PROD_ID12("SEIKO EPSON", "WWB101EN20", 0xf9876baf, 0xad0b207b),
+       PCMCIA_DEVICE_PROD_ID12("SEIKO EPSON", "WWB513EN20", 0xf9876baf, 0xe8d884ad),
+       PCMCIA_DEVICE_PROD_ID12("Starfish, Inc.", "REX-3000", 0x05ddca47, 0xe7d67bca),
+       PCMCIA_DEVICE_PROD_ID12("Starfish, Inc.", "REX-4100", 0x05ddca47, 0x7bc32944),
+       /* the following was commented out in pcmcia-cs-3.2.7 */
+       /* PCMCIA_DEVICE_PROD_ID12("RATOC Systems,Inc.", "SmartMedia ADAPTER PC Card", 0xf4a2fefe, 0x5885b2ae), */
+#ifdef CONFIG_MTD_PCMCIA_ANONYMOUS
+       { .match_flags = PCMCIA_DEV_ID_MATCH_ANONYMOUS, },
+#endif
+       PCMCIA_DEVICE_NULL
+};
+MODULE_DEVICE_TABLE(pcmcia, pcmciamtd_ids);
 
 static struct pcmcia_driver pcmciamtd_driver = {
        .drv            = {
                .name   = "pcmciamtd"
        },
-       .attach         = pcmciamtd_attach,
-       .detach         = pcmciamtd_detach,
-       .owner          = THIS_MODULE
+       .probe          = pcmciamtd_probe,
+       .remove         = pcmciamtd_detach,
+       .owner          = THIS_MODULE,
+       .id_table       = pcmciamtd_ids,
+       .suspend        = pcmciamtd_suspend,
+       .resume         = pcmciamtd_resume,
 };
 
 
@@ -853,7 +808,6 @@ static void __exit exit_pcmciamtd(void)
 {
        DEBUG(1, DRIVER_DESC " unloading");
        pcmcia_unregister_driver(&pcmciamtd_driver);
-       BUG_ON(dev_list != NULL);
 }
 
 module_init(init_pcmciamtd);