vserver 2.0 rc7
[linux-2.6.git] / drivers / net / sis900.c
index 75d84fd..3107aed 100644 (file)
@@ -1,6 +1,6 @@
 /* sis900.c: A SiS 900/7016 PCI Fast Ethernet driver for Linux.
    Copyright 1999 Silicon Integrated System Corporation 
-   Revision:   1.08.06 Sep. 24 2002
+   Revision:   1.08.08 Jan. 22 2005
    
    Modified from the driver which is originally written by Donald Becker.
    
@@ -16,8 +16,8 @@
    preliminary Rev. 1.0 Nov. 10, 1998
    SiS 7014 Single Chip 100BASE-TX/10BASE-T Physical Layer Solution,
    preliminary Rev. 1.0 Jan. 18, 1998
-   http://www.sis.com.tw/support/databook.htm
 
+   Rev 1.08.08 Jan. 22 2005 Daniele Venzano use netif_msg for debugging messages
    Rev 1.08.07 Nov.  2 2003 Daniele Venzano <webvenza@libero.it> add suspend/resume support
    Rev 1.08.06 Sep. 24 2002 Mufasa Yang bug fix for Tx timeout & add SiS963 support
    Rev 1.08.05 Jun.  6 2002 Mufasa Yang bug fix for read_eeprom & Tx descriptor over-boundary
 
 #include <asm/processor.h>      /* Processor type for cache alignment. */
 #include <asm/io.h>
+#include <asm/irq.h>
 #include <asm/uaccess.h>       /* User space memory access functions */
 
 #include "sis900.h"
 
 #define SIS900_MODULE_NAME "sis900"
-#define SIS900_DRV_VERSION "v1.08.07 11/02/2003"
+#define SIS900_DRV_VERSION "v1.08.08 Jan. 22 2005"
 
 static char version[] __devinitdata =
 KERN_INFO "sis900.c: " SIS900_DRV_VERSION "\n";
@@ -82,8 +83,13 @@ KERN_INFO "sis900.c: " SIS900_DRV_VERSION "\n";
 static int max_interrupt_work = 40;
 static int multicast_filter_limit = 128;
 
-#define sis900_debug debug
-static int sis900_debug;
+static int sis900_debug = -1; /* Use SIS900_DEF_MSG as value */
+
+#define SIS900_DEF_MSG \
+       (NETIF_MSG_DRV          | \
+        NETIF_MSG_LINK         | \
+        NETIF_MSG_RX_ERR       | \
+        NETIF_MSG_TX_ERR)
 
 /* Time in jiffies before concluding the transmitter is hung. */
 #define TX_TIMEOUT  (4*HZ)
@@ -156,10 +162,13 @@ struct sis900_private {
        struct mii_phy * mii;
        struct mii_phy * first_mii; /* record the first mii structure */
        unsigned int cur_phy;
+       struct mii_if_info mii_info;
 
        struct timer_list timer; /* Link status detection timer. */
        u8 autong_complete; /* 1: auto-negotiate complete  */
 
+       u32 msg_enable;
+
        unsigned int cur_rx, dirty_rx; /* producer/comsumer pointers for Tx/Rx ring */
        unsigned int cur_tx, dirty_tx;
 
@@ -174,6 +183,7 @@ struct sis900_private {
 
        unsigned int tx_full; /* The Tx queue is full. */
        u8 host_bridge_rev;
+       u8 chipset_rev;
 };
 
 MODULE_AUTHOR("Jim Huang <cmhuang@sis.com.tw>, Ollie Lho <ollie@sis.com.tw>");
@@ -182,16 +192,19 @@ MODULE_LICENSE("GPL");
 
 module_param(multicast_filter_limit, int, 0444);
 module_param(max_interrupt_work, int, 0444);
-module_param(debug, int, 0444);
+module_param(sis900_debug, int, 0444);
 MODULE_PARM_DESC(multicast_filter_limit, "SiS 900/7016 maximum number of filtered multicast addresses");
 MODULE_PARM_DESC(max_interrupt_work, "SiS 900/7016 maximum events handled per interrupt");
-MODULE_PARM_DESC(debug, "SiS 900/7016 debug level (2-4)");
+MODULE_PARM_DESC(sis900_debug, "SiS 900/7016 bitmapped debugging message level");
 
+#ifdef CONFIG_NET_POLL_CONTROLLER
+static void sis900_poll(struct net_device *dev);
+#endif
 static int sis900_open(struct net_device *net_dev);
 static int sis900_mii_probe (struct net_device * net_dev);
 static void sis900_init_rxfilter (struct net_device * net_dev);
 static u16 read_eeprom(long ioaddr, int location);
-static u16 mdio_read(struct net_device *net_dev, int phy_id, int location);
+static int mdio_read(struct net_device *net_dev, int phy_id, int location);
 static void mdio_write(struct net_device *net_dev, int phy_id, int location, int val);
 static void sis900_timer(unsigned long data);
 static void sis900_check_mode (struct net_device *net_dev, struct mii_phy *mii_phy);
@@ -235,7 +248,7 @@ static int __devinit sis900_get_mac_addr(struct pci_dev * pci_dev, struct net_de
        /* check to see if we have sane EEPROM */
        signature = (u16) read_eeprom(ioaddr, EEPROMSignature);    
        if (signature == 0xffff || signature == 0x0000) {
-               printk (KERN_INFO "%s: Error EERPOM read %x\n", 
+               printk (KERN_WARNING "%s: Error EERPOM read %x\n", 
                        pci_name(pci_dev), signature);
                return 0;
        }
@@ -268,7 +281,8 @@ static int __devinit sis630e_get_mac_addr(struct pci_dev * pci_dev,
        if (!isa_bridge)
                isa_bridge = pci_get_device(PCI_VENDOR_ID_SI, 0x0018, isa_bridge);
        if (!isa_bridge) {
-               printk("%s: Can not find ISA bridge\n", pci_name(pci_dev));
+               printk(KERN_WARNING "%s: Can not find ISA bridge\n",
+                      pci_name(pci_dev));
                return 0;
        }
        pci_read_config_byte(isa_bridge, 0x48, &reg);
@@ -386,8 +400,8 @@ static int __devinit sis900_probe(struct pci_dev *pci_dev,
        void *ring_space;
        long ioaddr;
        int i, ret;
-       u8 revision;
        char *card_name = card_names[pci_id->driver_data];
+       const char *dev_name = pci_name(pci_dev);
 
 /* when built into the kernel, we only print version if device is found */
 #ifndef MODULE
@@ -456,31 +470,53 @@ static int __devinit sis900_probe(struct pci_dev *pci_dev,
        net_dev->tx_timeout = sis900_tx_timeout;
        net_dev->watchdog_timeo = TX_TIMEOUT;
        net_dev->ethtool_ops = &sis900_ethtool_ops;
-               
+
+#ifdef CONFIG_NET_POLL_CONTROLLER
+        net_dev->poll_controller = &sis900_poll;
+#endif
+
+       if (sis900_debug > 0)
+               sis_priv->msg_enable = sis900_debug;
+       else
+               sis_priv->msg_enable = SIS900_DEF_MSG;
+
+       sis_priv->mii_info.dev = net_dev;
+       sis_priv->mii_info.mdio_read = mdio_read;
+       sis_priv->mii_info.mdio_write = mdio_write;
+       sis_priv->mii_info.phy_id_mask = 0x1f;
+       sis_priv->mii_info.reg_num_mask = 0x1f;
+
        /* Get Mac address according to the chip revision */
-       pci_read_config_byte(pci_dev, PCI_CLASS_REVISION, &revision);
+       pci_read_config_byte(pci_dev, PCI_CLASS_REVISION, &(sis_priv->chipset_rev));
+       if(netif_msg_probe(sis_priv))
+               printk(KERN_DEBUG "%s: detected revision %2.2x, "
+                               "trying to get MAC address...\n",
+                               dev_name, sis_priv->chipset_rev);
+       
        ret = 0;
-
-       if (revision == SIS630E_900_REV)
+       if (sis_priv->chipset_rev == SIS630E_900_REV)
                ret = sis630e_get_mac_addr(pci_dev, net_dev);
-       else if ((revision > 0x81) && (revision <= 0x90) )
+       else if ((sis_priv->chipset_rev > 0x81) && (sis_priv->chipset_rev <= 0x90) )
                ret = sis635_get_mac_addr(pci_dev, net_dev);
-       else if (revision == SIS96x_900_REV)
+       else if (sis_priv->chipset_rev == SIS96x_900_REV)
                ret = sis96x_get_mac_addr(pci_dev, net_dev);
        else
                ret = sis900_get_mac_addr(pci_dev, net_dev);
 
        if (ret == 0) {
+               printk(KERN_WARNING "%s: Cannot read MAC address.\n", dev_name);
                ret = -ENODEV;
                goto err_unmap_rx;
        }
        
        /* 630ET : set the mii access mode as software-mode */
-       if (revision == SIS630ET_900_REV)
+       if (sis_priv->chipset_rev == SIS630ET_900_REV)
                outl(ACCESSMODE | inl(ioaddr + cr), ioaddr + cr);
 
        /* probe for mii transceiver */
        if (sis900_mii_probe(net_dev) == 0) {
+               printk(KERN_WARNING "%s: Error probing MII device.\n",
+                      dev_name);
                ret = -ENODEV;
                goto err_unmap_rx;
        }
@@ -535,7 +571,6 @@ static int __init sis900_mii_probe(struct net_device * net_dev)
        u16 poll_bit = MII_STAT_LINK, status = 0;
        unsigned long timeout = jiffies + 5 * HZ;
        int phy_addr;
-       u8 revision;
 
        sis_priv->mii = NULL;
 
@@ -549,12 +584,16 @@ static int __init sis900_mii_probe(struct net_device * net_dev)
                for(i = 0; i < 2; i++)
                        mii_status = mdio_read(net_dev, phy_addr, MII_STATUS);
 
-               if (mii_status == 0xffff || mii_status == 0x0000)
-                       /* the mii is not accessible, try next one */
+               if (mii_status == 0xffff || mii_status == 0x0000) {
+                       if (netif_msg_probe(sis_priv))
+                               printk(KERN_DEBUG "%s: MII at address %d"
+                                               " not accessible\n",
+                                               dev_name, phy_addr);
                        continue;
+               }
                
                if ((mii_phy = kmalloc(sizeof(struct mii_phy), GFP_KERNEL)) == NULL) {
-                       printk(KERN_INFO "Cannot allocate mem for struct mii_phy\n");
+                       printk(KERN_WARNING "Cannot allocate mem for struct mii_phy\n");
                        mii_phy = sis_priv->first_mii;
                        while (mii_phy) {
                                struct mii_phy *phy;
@@ -580,9 +619,11 @@ static int __init sis900_mii_probe(struct net_device * net_dev)
                                if (mii_chip_table[i].phy_types == MIX)
                                        mii_phy->phy_types =
                                            (mii_status & (MII_STAT_CAN_TX_FDX | MII_STAT_CAN_TX)) ? LAN : HOME;
-                               printk(KERN_INFO "%s: %s transceiver found at address %d.\n",
-                                      dev_name, mii_chip_table[i].name,
-                                      phy_addr);
+                               printk(KERN_INFO "%s: %s transceiver found "
+                                                       "at address %d.\n",
+                                                       dev_name,
+                                                       mii_chip_table[i].name,
+                                                       phy_addr);
                                break;
                        }
                        
@@ -625,8 +666,7 @@ static int __init sis900_mii_probe(struct net_device * net_dev)
                }
        }
 
-       pci_read_config_byte(sis_priv->pci_dev, PCI_CLASS_REVISION, &revision);
-       if (revision == SIS630E_900_REV) {
+       if (sis_priv->chipset_rev == SIS630E_900_REV) {
                /* SiS 630E has some bugs on default value of PHY registers */
                mdio_write(net_dev, sis_priv->cur_phy, MII_ANADV, 0x05e1);
                mdio_write(net_dev, sis_priv->cur_phy, MII_CONFIG1, 0x22);
@@ -692,6 +732,8 @@ static u16 sis900_default_phy(struct net_device * net_dev)
                       pci_name(sis_priv->pci_dev), sis_priv->cur_phy);
        }
        
+       sis_priv->mii_info.phy_id = sis_priv->cur_phy;
+
        status = mdio_read(net_dev, sis_priv->cur_phy, MII_CONTROL);
        status &= (~MII_CNTL_ISOLATE);
 
@@ -819,7 +861,7 @@ static void mdio_reset(long mdio_addr)
  *     Please see SiS7014 or ICS spec
  */
 
-static u16 mdio_read(struct net_device *net_dev, int phy_id, int location)
+static int mdio_read(struct net_device *net_dev, int phy_id, int location)
 {
        long mdio_addr = net_dev->base_addr + mear;
        int mii_cmd = MIIread|(phy_id<<MIIpmdShift)|(location<<MIIregShift);
@@ -928,6 +970,20 @@ static u16 sis900_reset_phy(struct net_device *net_dev, int phy_addr)
        return status;
 }
 
+#ifdef CONFIG_NET_POLL_CONTROLLER
+/*
+ * Polling 'interrupt' - used by things like netconsole to send skbs
+ * without having to re-enable interrupts. It's not called while
+ * the interrupt routine is executing.
+*/
+static void sis900_poll(struct net_device *dev)
+{
+       disable_irq(dev->irq);
+       sis900_interrupt(dev->irq, dev, NULL);
+       enable_irq(dev->irq);
+}
+#endif
+
 /**
  *     sis900_open - open sis900 device
  *     @net_dev: the net device to open
@@ -941,15 +997,13 @@ sis900_open(struct net_device *net_dev)
 {
        struct sis900_private *sis_priv = net_dev->priv;
        long ioaddr = net_dev->base_addr;
-       u8 revision;
        int ret;
 
        /* Soft reset the chip. */
        sis900_reset(net_dev);
 
        /* Equalizer workaround Rule */
-       pci_read_config_byte(sis_priv->pci_dev, PCI_CLASS_REVISION, &revision);
-       sis630_set_eq(net_dev, revision);
+       sis630_set_eq(net_dev, sis_priv->chipset_rev);
 
        ret = request_irq(net_dev->irq, &sis900_interrupt, SA_SHIRQ,
                                                net_dev->name, net_dev);
@@ -997,6 +1051,7 @@ sis900_open(struct net_device *net_dev)
 static void
 sis900_init_rxfilter (struct net_device * net_dev)
 {
+       struct sis900_private *sis_priv = net_dev->priv;
        long ioaddr = net_dev->base_addr;
        u32 rfcrSave;
        u32 i;
@@ -1014,8 +1069,8 @@ sis900_init_rxfilter (struct net_device * net_dev)
                outl((i << RFADDR_shift), ioaddr + rfcr);
                outl(w, ioaddr + rfdr);
 
-               if (sis900_debug > 2) {
-                       printk(KERN_INFO "%s: Receive Filter Addrss[%d]=%x\n",
+               if (netif_msg_hw(sis_priv)) {
+                       printk(KERN_DEBUG "%s: Receive Filter Addrss[%d]=%x\n",
                               net_dev->name, i, inl(ioaddr + rfdr));
                }
        }
@@ -1052,8 +1107,8 @@ sis900_init_tx_ring(struct net_device *net_dev)
 
        /* load Transmit Descriptor Register */
        outl(sis_priv->tx_ring_dma, ioaddr + txdp);
-       if (sis900_debug > 2)
-               printk(KERN_INFO "%s: TX descriptor register loaded with: %8.8x\n",
+       if (netif_msg_hw(sis_priv))
+               printk(KERN_DEBUG "%s: TX descriptor register loaded with: %8.8x\n",
                       net_dev->name, inl(ioaddr + txdp));
 }
 
@@ -1106,8 +1161,8 @@ sis900_init_rx_ring(struct net_device *net_dev)
 
        /* load Receive Descriptor Register */
        outl(sis_priv->rx_ring_dma, ioaddr + rxdp);
-       if (sis900_debug > 2)
-               printk(KERN_INFO "%s: RX descriptor register loaded with: %8.8x\n",
+       if (netif_msg_hw(sis_priv))
+               printk(KERN_DEBUG "%s: RX descriptor register loaded with: %8.8x\n",
                       net_dev->name, inl(ioaddr + rxdp));
 }
 
@@ -1217,7 +1272,6 @@ static void sis900_timer(unsigned long data)
        struct mii_phy *mii_phy = sis_priv->mii;
        static int next_tick = 5*HZ;
        u16 status;
-       u8 revision;
 
        if (!sis_priv->autong_complete){
                int speed, duplex = 0;
@@ -1225,9 +1279,7 @@ static void sis900_timer(unsigned long data)
                sis900_read_mode(net_dev, &speed, &duplex);
                if (duplex){
                        sis900_set_mode(net_dev->base_addr, speed, duplex);
-                       pci_read_config_byte(sis_priv->pci_dev,
-                                               PCI_CLASS_REVISION, &revision);
-                       sis630_set_eq(net_dev, revision);
+                       sis630_set_eq(net_dev, sis_priv->chipset_rev);
                        netif_start_queue(net_dev);
                }
 
@@ -1254,16 +1306,15 @@ static void sis900_timer(unsigned long data)
        /* Link ON -> OFF */
                 if (!(status & MII_STAT_LINK)){
                        netif_carrier_off(net_dev);
-                       printk(KERN_INFO "%s: Media Link Off\n", net_dev->name);
+                       if(netif_msg_link(sis_priv))
+                               printk(KERN_INFO "%s: Media Link Off\n", net_dev->name);
 
                        /* Change mode issue */
                        if ((mii_phy->phy_id0 == 0x001D) && 
                            ((mii_phy->phy_id1 & 0xFFF0) == 0x8000))
                                        sis900_reset_phy(net_dev,  sis_priv->cur_phy);
   
-                       pci_read_config_byte(sis_priv->pci_dev,
-                                       PCI_CLASS_REVISION, &revision);
-                       sis630_set_eq(net_dev, revision);
+                       sis630_set_eq(net_dev, sis_priv->chipset_rev);
   
                        goto LookForLink;
                 }
@@ -1369,7 +1420,8 @@ static void sis900_auto_negotiate(struct net_device *net_dev, int phy_addr)
                status = mdio_read(net_dev, phy_addr, MII_STATUS);
 
        if (!(status & MII_STAT_LINK)){
-               printk(KERN_INFO "%s: Media Link Off\n", net_dev->name);
+               if(netif_msg_link(sis_priv))
+                       printk(KERN_INFO "%s: Media Link Off\n", net_dev->name);
                sis_priv->autong_complete = 1;
                netif_carrier_off(net_dev);
                return;
@@ -1431,7 +1483,8 @@ static void sis900_read_mode(struct net_device *net_dev, int *speed, int *duplex
                        *speed = HW_SPEED_100_MBPS;
        }
 
-       printk(KERN_INFO "%s: Media Link On %s %s-duplex \n",
+       if(netif_msg_link(sis_priv))
+               printk(KERN_INFO "%s: Media Link On %s %s-duplex \n",
                                        net_dev->name,
                                        *speed == HW_SPEED_100_MBPS ?
                                                "100mbps" : "10mbps",
@@ -1454,8 +1507,9 @@ static void sis900_tx_timeout(struct net_device *net_dev)
        unsigned long flags;
        int i;
 
-       printk(KERN_INFO "%s: Transmit timeout, status %8.8x %8.8x \n",
-              net_dev->name, inl(ioaddr + cr), inl(ioaddr + isr));
+       if(netif_msg_tx_err(sis_priv))
+               printk(KERN_INFO "%s: Transmit timeout, status %8.8x %8.8x \n",
+                       net_dev->name, inl(ioaddr + cr), inl(ioaddr + isr));
 
        /* Disable interrupts by clearing the interrupt mask. */
        outl(0x0000, ioaddr + imr);
@@ -1556,8 +1610,8 @@ sis900_start_xmit(struct sk_buff *skb, struct net_device *net_dev)
 
        net_dev->trans_start = jiffies;
 
-       if (sis900_debug > 3)
-               printk(KERN_INFO "%s: Queued Tx packet at %p size %d "
+       if (netif_msg_tx_queued(sis_priv))
+               printk(KERN_DEBUG "%s: Queued Tx packet at %p size %d "
                       "to slot %d.\n",
                       net_dev->name, skb->data, (int)skb->len, entry);
 
@@ -1604,20 +1658,22 @@ static irqreturn_t sis900_interrupt(int irq, void *dev_instance, struct pt_regs
 
                /* something strange happened !!! */
                if (status & HIBERR) {
-                       printk(KERN_INFO "%s: Abnormal interrupt,"
-                              "status %#8.8x.\n", net_dev->name, status);
+                       if(netif_msg_intr(sis_priv))
+                               printk(KERN_INFO "%s: Abnormal interrupt,"
+                                       "status %#8.8x.\n", net_dev->name, status);
                        break;
                }
                if (--boguscnt < 0) {
-                       printk(KERN_INFO "%s: Too much work at interrupt, "
-                              "interrupt status = %#8.8x.\n",
-                              net_dev->name, status);
+                       if(netif_msg_intr(sis_priv))
+                               printk(KERN_INFO "%s: Too much work at interrupt, "
+                                       "interrupt status = %#8.8x.\n",
+                                       net_dev->name, status);
                        break;
                }
        } while (1);
 
-       if (sis900_debug > 3)
-               printk(KERN_INFO "%s: exiting interrupt, "
+       if(netif_msg_intr(sis_priv))
+               printk(KERN_DEBUG "%s: exiting interrupt, "
                       "interrupt status = 0x%#8.8x.\n",
                       net_dev->name, inl(ioaddr + isr));
        
@@ -1642,8 +1698,8 @@ static int sis900_rx(struct net_device *net_dev)
        unsigned int entry = sis_priv->cur_rx % NUM_RX_DESC;
        u32 rx_status = sis_priv->rx_ring[entry].cmdsts;
 
-       if (sis900_debug > 3)
-               printk(KERN_INFO "sis900_rx, cur_rx:%4.4d, dirty_rx:%4.4d "
+       if (netif_msg_rx_status(sis_priv))
+               printk(KERN_DEBUG "sis900_rx, cur_rx:%4.4d, dirty_rx:%4.4d "
                       "status:0x%8.8x\n",
                       sis_priv->cur_rx, sis_priv->dirty_rx, rx_status);
 
@@ -1654,8 +1710,8 @@ static int sis900_rx(struct net_device *net_dev)
 
                if (rx_status & (ABORT|OVERRUN|TOOLONG|RUNT|RXISERR|CRCERR|FAERR)) {
                        /* corrupted packet received */
-                       if (sis900_debug > 3)
-                               printk(KERN_INFO "%s: Corrupted packet "
+                       if (netif_msg_rx_err(sis_priv))
+                               printk(KERN_DEBUG "%s: Corrupted packet "
                                       "received, buffer status = 0x%8.8x.\n",
                                       net_dev->name, rx_status);
                        sis_priv->stats.rx_errors++;
@@ -1676,9 +1732,10 @@ static int sis900_rx(struct net_device *net_dev)
                           some unknow bugs, it is possible that
                           we are working on NULL sk_buff :-( */
                        if (sis_priv->rx_skbuff[entry] == NULL) {
-                               printk(KERN_INFO "%s: NULL pointer " 
-                                      "encountered in Rx ring, skipping\n",
-                                      net_dev->name);
+                               if (netif_msg_rx_err(sis_priv))
+                                       printk(KERN_INFO "%s: NULL pointer " 
+                                               "encountered in Rx ring, skipping\n",
+                                               net_dev->name);
                                break;
                        }
 
@@ -1705,9 +1762,10 @@ static int sis900_rx(struct net_device *net_dev)
                                 * "hole" on the buffer ring, it is not clear
                                 * how the hardware will react to this kind
                                 * of degenerated buffer */
-                               printk(KERN_INFO "%s: Memory squeeze,"
-                                      "deferring packet.\n",
-                                      net_dev->name);
+                               if (netif_msg_rx_status(sis_priv))
+                                       printk(KERN_INFO "%s: Memory squeeze,"
+                                               "deferring packet.\n",
+                                               net_dev->name);
                                sis_priv->rx_skbuff[entry] = NULL;
                                /* reset buffer descriptor state */
                                sis_priv->rx_ring[entry].cmdsts = 0;
@@ -1741,9 +1799,10 @@ static int sis900_rx(struct net_device *net_dev)
                                 * "hole" on the buffer ring, it is not clear
                                 * how the hardware will react to this kind
                                 * of degenerated buffer */
-                               printk(KERN_INFO "%s: Memory squeeze,"
-                                      "deferring packet.\n",
-                                      net_dev->name);
+                               if (netif_msg_rx_err(sis_priv))
+                                       printk(KERN_INFO "%s: Memory squeeze,"
+                                               "deferring packet.\n",
+                                               net_dev->name);
                                sis_priv->stats.rx_dropped++;
                                break;
                        }
@@ -1792,8 +1851,8 @@ static void sis900_finish_xmit (struct net_device *net_dev)
 
                if (tx_status & (ABORT | UNDERRUN | OWCOLL)) {
                        /* packet unsuccessfully transmitted */
-                       if (sis900_debug > 3)
-                               printk(KERN_INFO "%s: Transmit "
+                       if (netif_msg_tx_err(sis_priv))
+                               printk(KERN_DEBUG "%s: Transmit "
                                       "error, Tx status %8.8x.\n",
                                       net_dev->name, tx_status);
                        sis_priv->stats.tx_errors++;
@@ -1904,8 +1963,59 @@ static void sis900_get_drvinfo(struct net_device *net_dev,
        strcpy (info->bus_info, pci_name(sis_priv->pci_dev));
 }
 
+static u32 sis900_get_msglevel(struct net_device *net_dev)
+{
+       struct sis900_private *sis_priv = net_dev->priv;
+       return sis_priv->msg_enable;
+}
+  
+static void sis900_set_msglevel(struct net_device *net_dev, u32 value)
+{
+       struct sis900_private *sis_priv = net_dev->priv;
+       sis_priv->msg_enable = value;
+}
+
+static u32 sis900_get_link(struct net_device *net_dev)
+{
+       struct sis900_private *sis_priv = net_dev->priv;
+       return mii_link_ok(&sis_priv->mii_info);
+}
+
+static int sis900_get_settings(struct net_device *net_dev,
+                               struct ethtool_cmd *cmd)
+{
+       struct sis900_private *sis_priv = net_dev->priv;
+       spin_lock_irq(&sis_priv->lock);
+       mii_ethtool_gset(&sis_priv->mii_info, cmd);
+       spin_unlock_irq(&sis_priv->lock);
+       return 0;
+}
+
+static int sis900_set_settings(struct net_device *net_dev,
+                               struct ethtool_cmd *cmd)
+{
+       struct sis900_private *sis_priv = net_dev->priv;
+       int rt;
+       spin_lock_irq(&sis_priv->lock);
+       rt = mii_ethtool_sset(&sis_priv->mii_info, cmd);
+       spin_unlock_irq(&sis_priv->lock);
+       return rt;
+}
+
+static int sis900_nway_reset(struct net_device *net_dev)
+{
+       struct sis900_private *sis_priv = net_dev->priv;
+       return mii_nway_restart(&sis_priv->mii_info);
+}
+
 static struct ethtool_ops sis900_ethtool_ops = {
-       .get_drvinfo =          sis900_get_drvinfo,
+       .get_drvinfo    = sis900_get_drvinfo,
+       .get_msglevel   = sis900_get_msglevel,
+       .set_msglevel   = sis900_set_msglevel,
+       .get_link       = sis900_get_link,
+       .get_settings   = sis900_get_settings,
+       .set_settings   = sis900_set_settings,
+       .nway_reset     = sis900_nway_reset,
 };
 
 /**
@@ -2046,12 +2156,10 @@ static int sis900_set_config(struct net_device *dev, struct ifmap *map)
                case IF_PORT_AUI: /* AUI */
                case IF_PORT_100BASEFX: /* 100BaseFx */
                        /* These Modes are not supported (are they?)*/
-                       printk(KERN_INFO "Not supported");
                        return -EOPNOTSUPP;
                        break;
             
                default:
-                       printk(KERN_INFO "Invalid");
                        return -EINVAL;
                }
        }
@@ -2097,11 +2205,10 @@ static void set_rx_mode(struct net_device *net_dev)
        u16 mc_filter[16] = {0};        /* 256/128 bits multicast hash table */
        int i, table_entries;
        u32 rx_mode;
-       u8 revision;
 
        /* 635 Hash Table entires = 256(2^16) */
-       pci_read_config_byte(sis_priv->pci_dev, PCI_CLASS_REVISION, &revision);
-       if((revision >= SIS635A_900_REV) || (revision == SIS900B_900_REV))
+       if((sis_priv->chipset_rev >= SIS635A_900_REV) ||
+                       (sis_priv->chipset_rev == SIS900B_900_REV))
                table_entries = 16;
        else
                table_entries = 8;
@@ -2127,7 +2234,7 @@ static void set_rx_mode(struct net_device *net_dev)
                        mclist && i < net_dev->mc_count;
                        i++, mclist = mclist->next) {
                        unsigned int bit_nr =
-                               sis900_mcast_bitnr(mclist->dmi_addr, revision);
+                               sis900_mcast_bitnr(mclist->dmi_addr, sis_priv->chipset_rev);
                        mc_filter[bit_nr >> 4] |= (1 << (bit_nr & 0xf));
                }
        }
@@ -2173,7 +2280,6 @@ static void sis900_reset(struct net_device *net_dev)
        long ioaddr = net_dev->base_addr;
        int i = 0;
        u32 status = TxRCMP | RxRCMP;
-       u8  revision;
 
        outl(0, ioaddr + ier);
        outl(0, ioaddr + imr);
@@ -2186,8 +2292,8 @@ static void sis900_reset(struct net_device *net_dev)
                status ^= (inl(isr + ioaddr) & status);
        }
 
-       pci_read_config_byte(sis_priv->pci_dev, PCI_CLASS_REVISION, &revision);
-       if( (revision >= SIS635A_900_REV) || (revision == SIS900B_900_REV) )
+       if( (sis_priv->chipset_rev >= SIS635A_900_REV) ||
+                       (sis_priv->chipset_rev == SIS900B_900_REV) )
                outl(PESEL | RND_CNT, ioaddr + cfg);
        else
                outl(PESEL, ioaddr + cfg);
@@ -2224,7 +2330,7 @@ static void __devexit sis900_remove(struct pci_dev *pci_dev)
 
 #ifdef CONFIG_PM
 
-static int sis900_suspend(struct pci_dev *pci_dev, u32 state)
+static int sis900_suspend(struct pci_dev *pci_dev, pm_message_t state)
 {
        struct net_device *net_dev = pci_get_drvdata(pci_dev);
        long ioaddr = net_dev->base_addr;