linux 2.6.16.38 w/ vs2.0.3-rc1
[linux-2.6.git] / drivers / pci / hotplug / acpiphp_glue.c
index ae67a8f..509a5b3 100644 (file)
@@ -26,7 +26,7 @@
  * along with this program; if not, write to the Free Software
  * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
  *
- * Send feedback to <kristen.c.accardi@intel.com>
+ * Send feedback to <t-kochi@bq.jp.nec.com>
  *
  */
 
@@ -46,7 +46,7 @@
 #include <linux/kernel.h>
 #include <linux/pci.h>
 #include <linux/smp_lock.h>
-#include <linux/mutex.h>
+#include <asm/semaphore.h>
 
 #include "../pci.h"
 #include "pci_hotplug.h"
@@ -57,9 +57,9 @@ static LIST_HEAD(bridge_list);
 #define MY_NAME "acpiphp_glue"
 
 static void handle_hotplug_event_bridge (acpi_handle, u32, void *);
+static void handle_hotplug_event_func (acpi_handle, u32, void *);
 static void acpiphp_sanitize_bus(struct pci_bus *bus);
 static void acpiphp_set_hpp_values(acpi_handle handle, struct pci_bus *bus);
-static void handle_hotplug_event_func(acpi_handle handle, u32 type, void *context);
 
 
 /*
@@ -117,59 +117,6 @@ is_ejectable_slot(acpi_handle handle, u32 lvl, void *context, void **rv)
        }
 }
 
-/* callback routine to check for the existance of a pci dock device */
-static acpi_status
-is_pci_dock_device(acpi_handle handle, u32 lvl, void *context, void **rv)
-{
-       int *count = (int *)context;
-
-       if (is_dock_device(handle)) {
-               (*count)++;
-               return AE_CTRL_TERMINATE;
-       } else {
-               return AE_OK;
-       }
-}
-
-
-
-
-/*
- * the _DCK method can do funny things... and sometimes not
- * hah-hah funny.
- *
- * TBD - figure out a way to only call fixups for
- * systems that require them.
- */
-static int post_dock_fixups(struct notifier_block *nb, unsigned long val,
-       void *v)
-{
-       struct acpiphp_func *func = container_of(nb, struct acpiphp_func, nb);
-       struct pci_bus *bus = func->slot->bridge->pci_bus;
-       u32 buses;
-
-       if (!bus->self)
-               return  NOTIFY_OK;
-
-       /* fixup bad _DCK function that rewrites
-        * secondary bridge on slot
-        */
-       pci_read_config_dword(bus->self,
-                       PCI_PRIMARY_BUS,
-                       &buses);
-
-       if (((buses >> 8) & 0xff) != bus->secondary) {
-               buses = (buses & 0xff000000)
-                       | ((unsigned int)(bus->primary)     <<  0)
-                       | ((unsigned int)(bus->secondary)   <<  8)
-                       | ((unsigned int)(bus->subordinate) << 16);
-               pci_write_config_dword(bus->self, PCI_PRIMARY_BUS, buses);
-       }
-       return NOTIFY_OK;
-}
-
-
-
 
 /* callback routine to register each ACPI PCI slot object */
 static acpi_status
@@ -181,7 +128,8 @@ register_slot(acpi_handle handle, u32 lvl, void *context, void **rv)
        acpi_handle tmp;
        acpi_status status = AE_OK;
        unsigned long adr, sun;
-       int device, function, retval;
+       int device, function;
+       static int num_slots = 0;       /* XXX if we support I/O node hotplug... */
 
        status = acpi_evaluate_integer(handle, "_ADR", NULL, &adr);
 
@@ -190,21 +138,21 @@ register_slot(acpi_handle handle, u32 lvl, void *context, void **rv)
 
        status = acpi_get_handle(handle, "_EJ0", &tmp);
 
-       if (ACPI_FAILURE(status) && !(is_dock_device(handle)))
+       if (ACPI_FAILURE(status))
                return AE_OK;
 
        device = (adr >> 16) & 0xffff;
        function = adr & 0xffff;
 
-       newfunc = kzalloc(sizeof(struct acpiphp_func), GFP_KERNEL);
+       newfunc = kmalloc(sizeof(struct acpiphp_func), GFP_KERNEL);
        if (!newfunc)
                return AE_NO_MEMORY;
+       memset(newfunc, 0, sizeof(struct acpiphp_func));
 
        INIT_LIST_HEAD(&newfunc->sibling);
        newfunc->handle = handle;
        newfunc->function = function;
-       if (ACPI_SUCCESS(status))
-               newfunc->flags = FUNC_HAS_EJ0;
+       newfunc->flags = FUNC_HAS_EJ0;
 
        if (ACPI_SUCCESS(acpi_get_handle(handle, "_STA", &tmp)))
                newfunc->flags |= FUNC_HAS_STA;
@@ -215,17 +163,9 @@ register_slot(acpi_handle handle, u32 lvl, void *context, void **rv)
        if (ACPI_SUCCESS(acpi_get_handle(handle, "_PS3", &tmp)))
                newfunc->flags |= FUNC_HAS_PS3;
 
-       if (ACPI_SUCCESS(acpi_get_handle(handle, "_DCK", &tmp)))
-               newfunc->flags |= FUNC_HAS_DCK;
-
        status = acpi_evaluate_integer(handle, "_SUN", NULL, &sun);
-       if (ACPI_FAILURE(status)) {
-               /*
-                * use the count of the number of slots we've found
-                * for the number of the slot
-                */
-               sun = bridge->nr_slots+1;
-       }
+       if (ACPI_FAILURE(status))
+               sun = -1;
 
        /* search for objects that share the same slot */
        for (slot = bridge->slots; slot; slot = slot->next)
@@ -236,17 +176,19 @@ register_slot(acpi_handle handle, u32 lvl, void *context, void **rv)
                }
 
        if (!slot) {
-               slot = kzalloc(sizeof(struct acpiphp_slot), GFP_KERNEL);
+               slot = kmalloc(sizeof(struct acpiphp_slot), GFP_KERNEL);
                if (!slot) {
                        kfree(newfunc);
                        return AE_NO_MEMORY;
                }
 
+               memset(slot, 0, sizeof(struct acpiphp_slot));
                slot->bridge = bridge;
+               slot->id = num_slots++;
                slot->device = device;
                slot->sun = sun;
                INIT_LIST_HEAD(&slot->funcs);
-               mutex_init(&slot->crit_sect);
+               init_MUTEX(&slot->crit_sect);
 
                slot->next = bridge->slots;
                bridge->slots = slot;
@@ -256,11 +198,6 @@ register_slot(acpi_handle handle, u32 lvl, void *context, void **rv)
                dbg("found ACPI PCI Hotplug slot %d at PCI %04x:%02x:%02x\n",
                                slot->sun, pci_domain_nr(bridge->pci_bus),
                                bridge->pci_bus->number, slot->device);
-               retval = acpiphp_register_hotplug_slot(slot);
-               if (retval) {
-                       warn("acpiphp_register_hotplug_slot failed(err code = 0x%x)\n", retval);
-                       goto err_exit;
-               }
        }
 
        newfunc->slot = slot;
@@ -273,44 +210,16 @@ register_slot(acpi_handle handle, u32 lvl, void *context, void **rv)
                slot->flags |= (SLOT_ENABLED | SLOT_POWEREDON);
        }
 
-       if (is_dock_device(handle)) {
-               /* we don't want to call this device's _EJ0
-                * because we want the dock notify handler
-                * to call it after it calls _DCK
-                */
-               newfunc->flags &= ~FUNC_HAS_EJ0;
-               if (register_hotplug_dock_device(handle,
-                       handle_hotplug_event_func, newfunc))
-                       dbg("failed to register dock device\n");
-
-               /* we need to be notified when dock events happen
-                * outside of the hotplug operation, since we may
-                * need to do fixups before we can hotplug.
-                */
-               newfunc->nb.notifier_call = post_dock_fixups;
-               if (register_dock_notifier(&newfunc->nb))
-                       dbg("failed to register a dock notifier");
-       }
-
        /* install notify handler */
-       if (!(newfunc->flags & FUNC_HAS_DCK)) {
-               status = acpi_install_notify_handler(handle,
+       status = acpi_install_notify_handler(handle,
                                             ACPI_SYSTEM_NOTIFY,
                                             handle_hotplug_event_func,
                                             newfunc);
 
-               if (ACPI_FAILURE(status))
-                       err("failed to register interrupt notify handler\n");
-       } else
-               status = AE_OK;
-
-       return status;
-
- err_exit:
-       bridge->nr_slots--;
-       bridge->slots = slot->next;
-       kfree(slot);
-       kfree(newfunc);
+       if (ACPI_FAILURE(status)) {
+               err("failed to register interrupt notify handler\n");
+               return status;
+       }
 
        return AE_OK;
 }
@@ -328,15 +237,6 @@ static int detect_ejectable_slots(acpi_handle *bridge_handle)
        status = acpi_walk_namespace(ACPI_TYPE_DEVICE, bridge_handle, (u32)1,
                                     is_ejectable_slot, (void *)&count, NULL);
 
-       /*
-        * we also need to add this bridge if there is a dock bridge or
-        * other pci device on a dock station (removable)
-        */
-       if (!count)
-               status = acpi_walk_namespace(ACPI_TYPE_DEVICE, bridge_handle,
-                               (u32)1, is_pci_dock_device, (void *)&count,
-                               NULL);
-
        return count;
 }
 
@@ -345,23 +245,55 @@ static int detect_ejectable_slots(acpi_handle *bridge_handle)
 static void decode_hpp(struct acpiphp_bridge *bridge)
 {
        acpi_status status;
+       struct acpi_buffer buffer = { .length = ACPI_ALLOCATE_BUFFER,
+                                     .pointer = NULL};
+       union acpi_object *package;
+       int i;
+
+       /* default numbers */
+       bridge->hpp.cache_line_size = 0x10;
+       bridge->hpp.latency_timer = 0x40;
+       bridge->hpp.enable_SERR = 0;
+       bridge->hpp.enable_PERR = 0;
 
-       status = acpi_get_hp_params_from_firmware(bridge->pci_bus, &bridge->hpp);
-       if (ACPI_FAILURE(status) ||
-           !bridge->hpp.t0 || (bridge->hpp.t0->revision > 1)) {
-               /* use default numbers */
-               printk(KERN_WARNING
-                      "%s: Could not get hotplug parameters. Use defaults\n",
-                      __FUNCTION__);
-               bridge->hpp.t0 = &bridge->hpp.type0_data;
-               bridge->hpp.t0->revision = 0;
-               bridge->hpp.t0->cache_line_size = 0x10;
-               bridge->hpp.t0->latency_timer = 0x40;
-               bridge->hpp.t0->enable_serr = 0;
-               bridge->hpp.t0->enable_perr = 0;
+       status = acpi_evaluate_object(bridge->handle, "_HPP", NULL, &buffer);
+
+       if (ACPI_FAILURE(status)) {
+               dbg("_HPP evaluation failed\n");
+               return;
        }
-}
 
+       package = (union acpi_object *) buffer.pointer;
+
+       if (!package || package->type != ACPI_TYPE_PACKAGE ||
+           package->package.count != 4 || !package->package.elements) {
+               err("invalid _HPP object; ignoring\n");
+               goto err_exit;
+       }
+
+       for (i = 0; i < 4; i++) {
+               if (package->package.elements[i].type != ACPI_TYPE_INTEGER) {
+                       err("invalid _HPP parameter type; ignoring\n");
+                       goto err_exit;
+               }
+       }
+
+       bridge->hpp.cache_line_size = package->package.elements[0].integer.value;
+       bridge->hpp.latency_timer = package->package.elements[1].integer.value;
+       bridge->hpp.enable_SERR = package->package.elements[2].integer.value;
+       bridge->hpp.enable_PERR = package->package.elements[3].integer.value;
+
+       dbg("_HPP parameter = (%02x, %02x, %02x, %02x)\n",
+               bridge->hpp.cache_line_size,
+               bridge->hpp.latency_timer,
+               bridge->hpp.enable_SERR,
+               bridge->hpp.enable_PERR);
+
+       bridge->flags |= BRIDGE_HAS_HPP;
+
+ err_exit:
+       kfree(buffer.pointer);
+}
 
 
 /* initialize miscellaneous stuff for both root and PCI-to-PCI bridge */
@@ -372,26 +304,12 @@ static void init_bridge_misc(struct acpiphp_bridge *bridge)
        /* decode ACPI 2.0 _HPP (hot plug parameters) */
        decode_hpp(bridge);
 
-       /* must be added to the list prior to calling register_slot */
-       list_add(&bridge->list, &bridge_list);
-
        /* register all slot objects under this bridge */
        status = acpi_walk_namespace(ACPI_TYPE_DEVICE, bridge->handle, (u32)1,
                                     register_slot, bridge, NULL);
-       if (ACPI_FAILURE(status)) {
-               list_del(&bridge->list);
-               return;
-       }
 
        /* install notify handler */
        if (bridge->type != BRIDGE_TYPE_HOST) {
-               if ((bridge->flags & BRIDGE_HAS_EJ0) && bridge->func) {
-                       status = acpi_remove_notify_handler(bridge->func->handle,
-                                               ACPI_SYSTEM_NOTIFY,
-                                               handle_hotplug_event_func);
-                       if (ACPI_FAILURE(status))
-                               err("failed to remove notify handler\n");
-               }
                status = acpi_install_notify_handler(bridge->handle,
                                             ACPI_SYSTEM_NOTIFY,
                                             handle_hotplug_event_bridge,
@@ -401,66 +319,8 @@ static void init_bridge_misc(struct acpiphp_bridge *bridge)
                        err("failed to register interrupt notify handler\n");
                }
        }
-}
-
-
-/* find acpiphp_func from acpiphp_bridge */
-static struct acpiphp_func *acpiphp_bridge_handle_to_function(acpi_handle handle)
-{
-       struct list_head *node, *l;
-       struct acpiphp_bridge *bridge;
-       struct acpiphp_slot *slot;
-       struct acpiphp_func *func;
-
-       list_for_each(node, &bridge_list) {
-               bridge = list_entry(node, struct acpiphp_bridge, list);
-               for (slot = bridge->slots; slot; slot = slot->next) {
-                       list_for_each(l, &slot->funcs) {
-                               func = list_entry(l, struct acpiphp_func,
-                                                       sibling);
-                               if (func->handle == handle)
-                                       return func;
-                       }
-               }
-       }
-
-       return NULL;
-}
-
-
-static inline void config_p2p_bridge_flags(struct acpiphp_bridge *bridge)
-{
-       acpi_handle dummy_handle;
-
-       if (ACPI_SUCCESS(acpi_get_handle(bridge->handle,
-                                       "_STA", &dummy_handle)))
-               bridge->flags |= BRIDGE_HAS_STA;
 
-       if (ACPI_SUCCESS(acpi_get_handle(bridge->handle,
-                                       "_EJ0", &dummy_handle)))
-               bridge->flags |= BRIDGE_HAS_EJ0;
-
-       if (ACPI_SUCCESS(acpi_get_handle(bridge->handle,
-                                       "_PS0", &dummy_handle)))
-               bridge->flags |= BRIDGE_HAS_PS0;
-
-       if (ACPI_SUCCESS(acpi_get_handle(bridge->handle,
-                                       "_PS3", &dummy_handle)))
-               bridge->flags |= BRIDGE_HAS_PS3;
-
-       /* is this ejectable p2p bridge? */
-       if (bridge->flags & BRIDGE_HAS_EJ0) {
-               struct acpiphp_func *func;
-
-               dbg("found ejectable p2p bridge\n");
-
-               /* make link between PCI bridge and PCI function */
-               func = acpiphp_bridge_handle_to_function(bridge->handle);
-               if (!func)
-                       return;
-               bridge->func = func;
-               func->bridge = bridge;
-       }
+       list_add(&bridge->list, &bridge_list);
 }
 
 
@@ -469,10 +329,12 @@ static void add_host_bridge(acpi_handle *handle, struct pci_bus *pci_bus)
 {
        struct acpiphp_bridge *bridge;
 
-       bridge = kzalloc(sizeof(struct acpiphp_bridge), GFP_KERNEL);
+       bridge = kmalloc(sizeof(struct acpiphp_bridge), GFP_KERNEL);
        if (bridge == NULL)
                return;
 
+       memset(bridge, 0, sizeof(struct acpiphp_bridge));
+
        bridge->type = BRIDGE_TYPE_HOST;
        bridge->handle = handle;
 
@@ -489,15 +351,16 @@ static void add_p2p_bridge(acpi_handle *handle, struct pci_dev *pci_dev)
 {
        struct acpiphp_bridge *bridge;
 
-       bridge = kzalloc(sizeof(struct acpiphp_bridge), GFP_KERNEL);
+       bridge = kmalloc(sizeof(struct acpiphp_bridge), GFP_KERNEL);
        if (bridge == NULL) {
                err("out of memory\n");
                return;
        }
 
+       memset(bridge, 0, sizeof(struct acpiphp_bridge));
+
        bridge->type = BRIDGE_TYPE_P2P;
        bridge->handle = handle;
-       config_p2p_bridge_flags(bridge);
 
        bridge->pci_dev = pci_dev_get(pci_dev);
        bridge->pci_bus = pci_dev->subordinate;
@@ -547,17 +410,11 @@ find_p2p_bridge(acpi_handle handle, u32 lvl, void *context, void **rv)
                goto out;
 
        /* check if this bridge has ejectable slots */
-       if ((detect_ejectable_slots(handle) > 0)) {
+       if (detect_ejectable_slots(handle) > 0) {
                dbg("found PCI-to-PCI bridge at PCI %s\n", pci_name(dev));
                add_p2p_bridge(handle, dev);
        }
 
-       /* search P2P bridges under this p2p bridge */
-       status = acpi_walk_namespace(ACPI_TYPE_DEVICE, handle, (u32)1,
-                                    find_p2p_bridge, dev->subordinate, NULL);
-       if (ACPI_FAILURE(status))
-               warn("find_p2p_bridge failed (error code = 0x%x)\n", status);
-
  out:
        pci_dev_put(dev);
        return AE_OK;
@@ -611,6 +468,7 @@ static int add_bridge(acpi_handle handle)
        if (detect_ejectable_slots(handle) > 0) {
                dbg("found PCI host-bus bridge with hot-pluggable slots\n");
                add_host_bridge(handle, pci_bus);
+               return 0;
        }
 
        /* search P2P bridges under this host bridge */
@@ -618,7 +476,7 @@ static int add_bridge(acpi_handle handle)
                                     find_p2p_bridge, pci_bus, NULL);
 
        if (ACPI_FAILURE(status))
-               warn("find_p2p_bridge failed (error code = 0x%x)\n", status);
+               warn("find_p2p_bridge faied (error code = 0x%x)\n",status);
 
        return 0;
 }
@@ -648,39 +506,21 @@ static void cleanup_bridge(struct acpiphp_bridge *bridge)
        if (ACPI_FAILURE(status))
                err("failed to remove notify handler\n");
 
-       if ((bridge->type != BRIDGE_TYPE_HOST) &&
-           ((bridge->flags & BRIDGE_HAS_EJ0) && bridge->func)) {
-               status = acpi_install_notify_handler(bridge->func->handle,
-                                               ACPI_SYSTEM_NOTIFY,
-                                               handle_hotplug_event_func,
-                                               bridge->func);
-               if (ACPI_FAILURE(status))
-                       err("failed to install interrupt notify handler\n");
-       }
-
        slot = bridge->slots;
        while (slot) {
                struct acpiphp_slot *next = slot->next;
                list_for_each_safe (list, tmp, &slot->funcs) {
                        struct acpiphp_func *func;
                        func = list_entry(list, struct acpiphp_func, sibling);
-                       if (is_dock_device(func->handle)) {
-                               unregister_hotplug_dock_device(func->handle);
-                               unregister_dock_notifier(&func->nb);
-                       }
-                       if (!(func->flags & FUNC_HAS_DCK)) {
-                               status = acpi_remove_notify_handler(func->handle,
+                       status = acpi_remove_notify_handler(func->handle,
                                                ACPI_SYSTEM_NOTIFY,
                                                handle_hotplug_event_func);
-                               if (ACPI_FAILURE(status))
-                                       err("failed to remove notify handler\n");
-                       }
+                       if (ACPI_FAILURE(status))
+                               err("failed to remove notify handler\n");
                        pci_dev_put(func->pci_dev);
                        list_del(list);
                        kfree(func);
                }
-               acpiphp_unregister_hotplug_slot(slot);
-               list_del(&slot->funcs);
                kfree(slot);
                slot = next;
        }
@@ -695,11 +535,6 @@ cleanup_p2p_bridge(acpi_handle handle, u32 lvl, void *context, void **rv)
 {
        struct acpiphp_bridge *bridge;
 
-       /* cleanup p2p bridges under this P2P bridge
-          in a depth-first manner */
-       acpi_walk_namespace(ACPI_TYPE_DEVICE, handle, (u32)1,
-                               cleanup_p2p_bridge, NULL, NULL);
-
        if (!(bridge = acpiphp_handle_to_bridge(handle)))
                return AE_OK;
        cleanup_bridge(bridge);
@@ -710,14 +545,14 @@ static void remove_bridge(acpi_handle handle)
 {
        struct acpiphp_bridge *bridge;
 
-       /* cleanup p2p bridges under this host bridge
-          in a depth-first manner */
-       acpi_walk_namespace(ACPI_TYPE_DEVICE, handle,
-                               (u32)1, cleanup_p2p_bridge, NULL, NULL);
-
        bridge = acpiphp_handle_to_bridge(handle);
-       if (bridge)
+       if (bridge) {
                cleanup_bridge(bridge);
+       } else {
+               /* clean-up p2p bridges under this host bridge */
+               acpi_walk_namespace(ACPI_TYPE_DEVICE, handle,
+                               (u32)1, cleanup_p2p_bridge, NULL, NULL);
+       }
 }
 
 static struct pci_dev * get_apic_pci_info(acpi_handle handle)
@@ -784,7 +619,7 @@ static int get_gsi_base(acpi_handle handle, u32 *gsi_base)
                break;
        }
  out:
-       kfree(buffer.pointer);
+       acpi_os_free(buffer.pointer);
        return result;
 }
 
@@ -916,105 +751,6 @@ static int power_off_slot(struct acpiphp_slot *slot)
 }
 
 
-
-/**
- * acpiphp_max_busnr - return the highest reserved bus number under
- * the given bus.
- * @bus: bus to start search with
- *
- */
-static unsigned char acpiphp_max_busnr(struct pci_bus *bus)
-{
-       struct list_head *tmp;
-       unsigned char max, n;
-
-       /*
-        * pci_bus_max_busnr will return the highest
-        * reserved busnr for all these children.
-        * that is equivalent to the bus->subordinate
-        * value.  We don't want to use the parent's
-        * bus->subordinate value because it could have
-        * padding in it.
-        */
-       max = bus->secondary;
-
-       list_for_each(tmp, &bus->children) {
-               n = pci_bus_max_busnr(pci_bus_b(tmp));
-               if (n > max)
-                       max = n;
-       }
-       return max;
-}
-
-
-/**
- * acpiphp_bus_add - add a new bus to acpi subsystem
- * @func: acpiphp_func of the bridge
- *
- */
-static int acpiphp_bus_add(struct acpiphp_func *func)
-{
-       acpi_handle phandle;
-       struct acpi_device *device, *pdevice;
-       int ret_val;
-
-       acpi_get_parent(func->handle, &phandle);
-       if (acpi_bus_get_device(phandle, &pdevice)) {
-               dbg("no parent device, assuming NULL\n");
-               pdevice = NULL;
-       }
-       if (!acpi_bus_get_device(func->handle, &device)) {
-               dbg("bus exists... trim\n");
-               /* this shouldn't be in here, so remove
-                * the bus then re-add it...
-                */
-               ret_val = acpi_bus_trim(device, 1);
-               dbg("acpi_bus_trim return %x\n", ret_val);
-       }
-
-       ret_val = acpi_bus_add(&device, pdevice, func->handle,
-               ACPI_BUS_TYPE_DEVICE);
-       if (ret_val) {
-               dbg("error adding bus, %x\n",
-                       -ret_val);
-               goto acpiphp_bus_add_out;
-       }
-       /*
-        * try to start anyway.  We could have failed to add
-        * simply because this bus had previously been added
-        * on another add.  Don't bother with the return value
-        * we just keep going.
-        */
-       ret_val = acpi_bus_start(device);
-
-acpiphp_bus_add_out:
-       return ret_val;
-}
-
-
-/**
- * acpiphp_bus_trim - trim a bus from acpi subsystem
- * @handle: handle to acpi namespace
- *
- */
-int acpiphp_bus_trim(acpi_handle handle)
-{
-       struct acpi_device *device;
-       int retval;
-
-       retval = acpi_bus_get_device(handle, &device);
-       if (retval) {
-               dbg("acpi_device not found\n");
-               return retval;
-       }
-
-       retval = acpi_bus_trim(device, 1);
-       if (retval)
-               err("cannot remove from acpi list\n");
-
-       return retval;
-}
-
 /**
  * enable_device - enable, configure a slot
  * @slot: slot to be enabled
@@ -1031,7 +767,6 @@ static int enable_device(struct acpiphp_slot *slot)
        struct acpiphp_func *func;
        int retval = 0;
        int num, max, pass;
-       acpi_status status;
 
        if (slot->flags & SLOT_ENABLED)
                goto err_exit;
@@ -1053,7 +788,7 @@ static int enable_device(struct acpiphp_slot *slot)
                goto err_exit;
        }
 
-       max = acpiphp_max_busnr(bus);
+       max = bus->secondary;
        for (pass = 0; pass < 2; pass++) {
                list_for_each_entry(dev, &bus->devices, bus_list) {
                        if (PCI_SLOT(dev->devfn) != slot->device)
@@ -1067,34 +802,18 @@ static int enable_device(struct acpiphp_slot *slot)
                }
        }
 
-       list_for_each (l, &slot->funcs) {
-               func = list_entry(l, struct acpiphp_func, sibling);
-               acpiphp_bus_add(func);
-       }
-
        pci_bus_assign_resources(bus);
        acpiphp_sanitize_bus(bus);
        pci_enable_bridges(bus);
        pci_bus_add_devices(bus);
-       acpiphp_set_hpp_values(slot->bridge->handle, bus);
-       acpiphp_configure_ioapics(slot->bridge->handle);
+       acpiphp_set_hpp_values(DEVICE_ACPI_HANDLE(&bus->self->dev), bus);
+       acpiphp_configure_ioapics(DEVICE_ACPI_HANDLE(&bus->self->dev));
 
        /* associate pci_dev to our representation */
        list_for_each (l, &slot->funcs) {
                func = list_entry(l, struct acpiphp_func, sibling);
                func->pci_dev = pci_get_slot(bus, PCI_DEVFN(slot->device,
                                                        func->function));
-               if (!func->pci_dev)
-                       continue;
-
-               if (func->pci_dev->hdr_type != PCI_HEADER_TYPE_BRIDGE &&
-                   func->pci_dev->hdr_type != PCI_HEADER_TYPE_CARDBUS)
-                       continue;
-
-               status = find_p2p_bridge(func->handle, (u32)1, bus, NULL);
-               if (ACPI_FAILURE(status))
-                       warn("find_p2p_bridge failed (error code = 0x%x)\n",
-                               status);
        }
 
        slot->flags |= SLOT_ENABLED;
@@ -1119,18 +838,6 @@ static int disable_device(struct acpiphp_slot *slot)
 
        list_for_each (l, &slot->funcs) {
                func = list_entry(l, struct acpiphp_func, sibling);
-
-               if (func->bridge) {
-                       /* cleanup p2p bridges under this P2P bridge */
-                       cleanup_p2p_bridge(func->bridge->handle,
-                                               (u32)1, NULL, NULL);
-                       func->bridge = NULL;
-               }
-
-               acpiphp_bus_trim(func->handle);
-               /* try to remove anyway.
-                * acpiphp_bus_add might have been failed */
-
                if (!func->pci_dev)
                        continue;
 
@@ -1275,17 +982,16 @@ static void program_hpp(struct pci_dev *dev, struct acpiphp_bridge *bridge)
                        (dev->hdr_type == PCI_HEADER_TYPE_BRIDGE &&
                        (dev->class >> 8) == PCI_CLASS_BRIDGE_PCI)))
                return;
-
        pci_write_config_byte(dev, PCI_CACHE_LINE_SIZE,
-                       bridge->hpp.t0->cache_line_size);
+                       bridge->hpp.cache_line_size);
        pci_write_config_byte(dev, PCI_LATENCY_TIMER,
-                       bridge->hpp.t0->latency_timer);
+                       bridge->hpp.latency_timer);
        pci_read_config_word(dev, PCI_COMMAND, &pci_cmd);
-       if (bridge->hpp.t0->enable_serr)
+       if (bridge->hpp.enable_SERR)
                pci_cmd |= PCI_COMMAND_SERR;
        else
                pci_cmd &= ~PCI_COMMAND_SERR;
-       if (bridge->hpp.t0->enable_perr)
+       if (bridge->hpp.enable_PERR)
                pci_cmd |= PCI_COMMAND_PARITY;
        else
                pci_cmd &= ~PCI_COMMAND_PARITY;
@@ -1294,13 +1000,13 @@ static void program_hpp(struct pci_dev *dev, struct acpiphp_bridge *bridge)
        /* Program bridge control value and child devices */
        if ((dev->class >> 8) == PCI_CLASS_BRIDGE_PCI) {
                pci_write_config_byte(dev, PCI_SEC_LATENCY_TIMER,
-                               bridge->hpp.t0->latency_timer);
+                               bridge->hpp.latency_timer);
                pci_read_config_word(dev, PCI_BRIDGE_CONTROL, &pci_bctl);
-               if (bridge->hpp.t0->enable_serr)
+               if (bridge->hpp.enable_SERR)
                        pci_bctl |= PCI_BRIDGE_CTL_SERR;
                else
                        pci_bctl &= ~PCI_BRIDGE_CTL_SERR;
-               if (bridge->hpp.t0->enable_perr)
+               if (bridge->hpp.enable_PERR)
                        pci_bctl |= PCI_BRIDGE_CTL_PARITY;
                else
                        pci_bctl &= ~PCI_BRIDGE_CTL_PARITY;
@@ -1320,8 +1026,6 @@ static void acpiphp_set_hpp_values(acpi_handle handle, struct pci_bus *bus)
 
        memset(&bridge, 0, sizeof(bridge));
        bridge.handle = handle;
-       bridge.pci_bus = bus;
-       bridge.pci_dev = bus->self;
        decode_hpp(&bridge);
        list_for_each_entry(dev, &bus->devices, bus_list)
                program_hpp(dev, &bridge);
@@ -1463,13 +1167,6 @@ static void handle_hotplug_event_bridge(acpi_handle handle, u32 type, void *cont
        case ACPI_NOTIFY_EJECT_REQUEST:
                /* request device eject */
                dbg("%s: Device eject notify on %s\n", __FUNCTION__, objname);
-               if ((bridge->type != BRIDGE_TYPE_HOST) &&
-                   (bridge->flags & BRIDGE_HAS_EJ0)) {
-                       struct acpiphp_slot *slot;
-                       slot = bridge->func->slot;
-                       if (!acpiphp_disable_slot(slot))
-                               acpiphp_eject_slot(slot);
-               }
                break;
 
        case ACPI_NOTIFY_FREQUENCY_MISMATCH:
@@ -1545,13 +1242,41 @@ static void handle_hotplug_event_func(acpi_handle handle, u32 type, void *contex
        }
 }
 
+static int is_root_bridge(acpi_handle handle)
+{
+       acpi_status status;
+       struct acpi_device_info *info;
+       struct acpi_buffer buffer = {ACPI_ALLOCATE_BUFFER, NULL};
+       int i;
+
+       status = acpi_get_object_info(handle, &buffer);
+       if (ACPI_SUCCESS(status)) {
+               info = buffer.pointer;
+               if ((info->valid & ACPI_VALID_HID) &&
+                       !strcmp(PCI_ROOT_HID_STRING,
+                                       info->hardware_id.value)) {
+                       acpi_os_free(buffer.pointer);
+                       return 1;
+               }
+               if (info->valid & ACPI_VALID_CID) {
+                       for (i=0; i < info->compatibility_id.count; i++) {
+                               if (!strcmp(PCI_ROOT_HID_STRING,
+                                       info->compatibility_id.id[i].value)) {
+                                       acpi_os_free(buffer.pointer);
+                                       return 1;
+                               }
+                       }
+               }
+       }
+       return 0;
+}
 
 static acpi_status
 find_root_bridges(acpi_handle handle, u32 lvl, void *context, void **rv)
 {
        int *count = (int *)context;
 
-       if (acpi_root_bridge(handle)) {
+       if (is_root_bridge(handle)) {
                acpi_install_notify_handler(handle, ACPI_SYSTEM_NOTIFY,
                                handle_hotplug_event_bridge, NULL);
                        (*count)++;
@@ -1648,6 +1373,26 @@ static int acpiphp_for_each_slot(acpiphp_callback fn, void *data)
 }
 #endif
 
+/* search matching slot from id  */
+struct acpiphp_slot *get_slot_from_id(int id)
+{
+       struct list_head *node;
+       struct acpiphp_bridge *bridge;
+       struct acpiphp_slot *slot;
+
+       list_for_each (node, &bridge_list) {
+               bridge = (struct acpiphp_bridge *)node;
+               for (slot = bridge->slots; slot; slot = slot->next)
+                       if (slot->id == id)
+                               return slot;
+       }
+
+       /* should never happen! */
+       err("%s: no object for id %d\n", __FUNCTION__, id);
+       WARN_ON(1);
+       return NULL;
+}
+
 
 /**
  * acpiphp_enable_slot - power on slot
@@ -1656,25 +1401,19 @@ int acpiphp_enable_slot(struct acpiphp_slot *slot)
 {
        int retval;
 
-       mutex_lock(&slot->crit_sect);
+       down(&slot->crit_sect);
 
        /* wake up all functions */
        retval = power_on_slot(slot);
        if (retval)
                goto err_exit;
 
-       if (get_slot_status(slot) == ACPI_STA_ALL) {
+       if (get_slot_status(slot) == ACPI_STA_ALL)
                /* configure all functions */
                retval = enable_device(slot);
-               if (retval)
-                       power_off_slot(slot);
-       } else {
-               dbg("%s: Slot status is not ACPI_STA_ALL\n", __FUNCTION__);
-               power_off_slot(slot);
-       }
 
  err_exit:
-       mutex_unlock(&slot->crit_sect);
+       up(&slot->crit_sect);
        return retval;
 }
 
@@ -1685,7 +1424,7 @@ int acpiphp_disable_slot(struct acpiphp_slot *slot)
 {
        int retval = 0;
 
-       mutex_lock(&slot->crit_sect);
+       down(&slot->crit_sect);
 
        /* unconfigure all functions */
        retval = disable_device(slot);
@@ -1698,7 +1437,7 @@ int acpiphp_disable_slot(struct acpiphp_slot *slot)
                goto err_exit;
 
  err_exit:
-       mutex_unlock(&slot->crit_sect);
+       up(&slot->crit_sect);
        return retval;
 }