Fedora kernel-2.6.17-1.2142_FC4 patched with stable patch-2.6.17.4-vs2.0.2-rc26.diff
[linux-2.6.git] / drivers / pci / hotplug / shpchp_hpc.c
index 38c5d90..66123cf 100644 (file)
  * along with this program; if not, write to the Free Software
  * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
  *
- * Send feedback to <greg@kroah.com>,<dely.l.sy@intel.com>
+ * Send feedback to <greg@kroah.com>,<kristen.c.accardi@intel.com>
  *
  */
 
-#include <linux/config.h>
 #include <linux/kernel.h>
 #include <linux/module.h>
 #include <linux/types.h>
-#include <linux/slab.h>
-#include <linux/vmalloc.h>
-#include <linux/interrupt.h>
-#include <linux/spinlock.h>
-#include <linux/delay.h>
 #include <linux/pci.h>
-#include <asm/system.h>
+#include <linux/interrupt.h>
+
 #include "shpchp.h"
 
 #ifdef DEBUG
 #define SLOT_100MHZ_PCIX_533   0x0f000000
 #define SLOT_133MHZ_PCIX_533   0xf0000000
 
-
-/* Secondary Bus Configuration Register */
-/* For PI = 1, Bits 0 to 2 have been encoded as follows to show current bus speed/mode */
-#define PCI_33MHZ              0x0
-#define PCI_66MHZ              0x1
-#define PCIX_66MHZ             0x2
-#define PCIX_100MHZ            0x3
-#define PCIX_133MHZ            0x4
-
-/* For PI = 2, Bits 0 to 3 have been encoded as follows to show current bus speed/mode */
-#define PCI_33MHZ              0x0
-#define PCI_66MHZ              0x1
-#define PCIX_66MHZ             0x2
-#define PCIX_100MHZ            0x3
-#define PCIX_133MHZ            0x4
-#define PCIX_66MHZ_ECC         0x5
-#define PCIX_100MHZ_ECC                0x6
-#define PCIX_133MHZ_ECC                0x7
-#define PCIX_66MHZ_266         0x9
-#define PCIX_100MHZ_266                0xa
-#define PCIX_133MHZ_266                0xb
-#define PCIX_66MHZ_533         0x11
-#define PCIX_100MHZ_533                0x12
-#define PCIX_133MHZ_533                0x13
-
 /* Slot Configuration */
 #define SLOT_NUM               0x0000001F
 #define        FIRST_DEV_NUM           0x00001F00
@@ -236,6 +206,7 @@ static spinlock_t list_lock;
 static irqreturn_t shpc_isr(int IRQ, void *dev_id, struct pt_regs *regs);
 
 static void start_int_poll_timer(struct php_ctlr_state_s *php_ctlr, int seconds);
+static int hpc_check_cmd_status(struct controller *ctrl);
 
 /* This is the interrupt polling timeout function. */
 static void int_poll_timeout(unsigned long lphp_ctlr)
@@ -280,19 +251,41 @@ static void start_int_poll_timer(struct php_ctlr_state_s *php_ctlr, int seconds)
        return;
 }
 
+static inline int shpc_wait_cmd(struct controller *ctrl)
+{
+       int retval = 0;
+       unsigned int timeout_msec = shpchp_poll_mode ? 2000 : 1000;
+       unsigned long timeout = msecs_to_jiffies(timeout_msec);
+       int rc = wait_event_interruptible_timeout(ctrl->queue,
+                                                 !ctrl->cmd_busy, timeout);
+       if (!rc) {
+               retval = -EIO;
+               err("Command not completed in %d msec\n", timeout_msec);
+       } else if (rc < 0) {
+               retval = -EINTR;
+               info("Command was interrupted by a signal\n");
+       }
+       ctrl->cmd_busy = 0;
+
+       return retval;
+}
+
 static int shpc_write_cmd(struct slot *slot, u8 t_slot, u8 cmd)
 {
-       struct php_ctlr_state_s *php_ctlr = (struct php_ctlr_state_s *) slot->ctrl->hpc_ctlr_handle;
+       struct php_ctlr_state_s *php_ctlr = slot->ctrl->hpc_ctlr_handle;
        u16 cmd_status;
        int retval = 0;
        u16 temp_word;
        int i;
 
        DBG_ENTER_ROUTINE 
-       
+
+       mutex_lock(&slot->ctrl->cmd_lock);
+
        if (!php_ctlr) {
                err("%s: Invalid HPC controller handle!\n", __FUNCTION__);
-               return -1;
+               retval = -EINVAL;
+               goto out;
        }
 
        for (i = 0; i < 10; i++) {
@@ -309,7 +302,8 @@ static int shpc_write_cmd(struct slot *slot, u8 t_slot, u8 cmd)
        if (cmd_status & 0x1) { 
                /* After 1 sec and and the controller is still busy */
                err("%s : Controller is still busy after 1 sec.\n", __FUNCTION__);
-               return -1;
+               retval = -EBUSY;
+               goto out;
        }
 
        ++t_slot;
@@ -319,8 +313,24 @@ static int shpc_write_cmd(struct slot *slot, u8 t_slot, u8 cmd)
        /* To make sure the Controller Busy bit is 0 before we send out the
         * command. 
         */
+       slot->ctrl->cmd_busy = 1;
        writew(temp_word, php_ctlr->creg + CMD);
-       dbg("%s: temp_word written %x\n", __FUNCTION__, temp_word);
+
+       /*
+        * Wait for command completion.
+        */
+       retval = shpc_wait_cmd(slot->ctrl);
+       if (retval)
+               goto out;
+
+       cmd_status = hpc_check_cmd_status(slot->ctrl);
+       if (cmd_status) {
+               err("%s: Failed to issued command 0x%x (error code = %d)\n",
+                   __FUNCTION__, cmd, cmd_status);
+               retval = -EIO;
+       }
+ out:
+       mutex_unlock(&slot->ctrl->cmd_lock);
 
        DBG_LEAVE_ROUTINE 
        return retval;
@@ -328,7 +338,7 @@ static int shpc_write_cmd(struct slot *slot, u8 t_slot, u8 cmd)
 
 static int hpc_check_cmd_status(struct controller *ctrl)
 {
-       struct php_ctlr_state_s *php_ctlr = (struct php_ctlr_state_s *) ctrl->hpc_ctlr_handle;
+       struct php_ctlr_state_s *php_ctlr = ctrl->hpc_ctlr_handle;
        u16 cmd_status;
        int retval = 0;
 
@@ -368,7 +378,7 @@ static int hpc_check_cmd_status(struct controller *ctrl)
 
 static int hpc_get_attention_status(struct slot *slot, u8 *status)
 {
-       struct php_ctlr_state_s *php_ctlr = (struct php_ctlr_state_s *) slot->ctrl->hpc_ctlr_handle;
+       struct php_ctlr_state_s *php_ctlr = slot->ctrl->hpc_ctlr_handle;
        u32 slot_reg;
        u16 slot_status;
        u8 atten_led_state;
@@ -408,7 +418,7 @@ static int hpc_get_attention_status(struct slot *slot, u8 *status)
 
 static int hpc_get_power_status(struct slot * slot, u8 *status)
 {
-       struct php_ctlr_state_s *php_ctlr = (struct php_ctlr_state_s *) slot->ctrl->hpc_ctlr_handle;
+       struct php_ctlr_state_s *php_ctlr = slot->ctrl->hpc_ctlr_handle;
        u32 slot_reg;
        u16 slot_status;
        u8 slot_state;
@@ -450,7 +460,7 @@ static int hpc_get_power_status(struct slot * slot, u8 *status)
 
 static int hpc_get_latch_status(struct slot *slot, u8 *status)
 {
-       struct php_ctlr_state_s *php_ctlr = (struct php_ctlr_state_s *) slot->ctrl->hpc_ctlr_handle;
+       struct php_ctlr_state_s *php_ctlr = slot->ctrl->hpc_ctlr_handle;
        u32 slot_reg;
        u16 slot_status;
 
@@ -473,7 +483,7 @@ static int hpc_get_latch_status(struct slot *slot, u8 *status)
 
 static int hpc_get_adapter_status(struct slot *slot, u8 *status)
 {
-       struct php_ctlr_state_s *php_ctlr = (struct php_ctlr_state_s *) slot->ctrl->hpc_ctlr_handle;
+       struct php_ctlr_state_s *php_ctlr = slot->ctrl->hpc_ctlr_handle;
        u32 slot_reg;
        u16 slot_status;
        u8 card_state;
@@ -496,7 +506,7 @@ static int hpc_get_adapter_status(struct slot *slot, u8 *status)
 
 static int hpc_get_prog_int(struct slot *slot, u8 *prog_int)
 {
-       struct php_ctlr_state_s *php_ctlr = (struct php_ctlr_state_s *) slot->ctrl->hpc_ctlr_handle;
+       struct php_ctlr_state_s *php_ctlr = slot->ctrl->hpc_ctlr_handle;
 
        DBG_ENTER_ROUTINE 
        
@@ -513,88 +523,48 @@ static int hpc_get_prog_int(struct slot *slot, u8 *prog_int)
 
 static int hpc_get_adapter_speed(struct slot *slot, enum pci_bus_speed *value)
 {
-       struct php_ctlr_state_s *php_ctlr = (struct php_ctlr_state_s *) slot->ctrl->hpc_ctlr_handle;
-       u32 slot_reg;
-       u16 slot_status, sec_bus_status;
-       u8 m66_cap, pcix_cap, pi;
        int retval = 0;
+       struct php_ctlr_state_s *php_ctlr = slot->ctrl->hpc_ctlr_handle;
+       u32 slot_reg = readl(php_ctlr->creg + SLOT1 + 4 * slot->hp_slot);
+       u8 pcix_cap = (slot_reg >> 12) & 7;
+       u8 m66_cap  = (slot_reg >> 9) & 1;
 
        DBG_ENTER_ROUTINE 
 
-       if (!slot->ctrl->hpc_ctlr_handle) {
-               err("%s: Invalid HPC controller handle!\n", __FUNCTION__);
-               return -1;
-       }
-
-       if (slot->hp_slot >= php_ctlr->num_slots) {
-               err("%s: Invalid HPC slot number!\n", __FUNCTION__);
-               return -1;
-       }
-       
-       pi = readb(php_ctlr->creg + PROG_INTERFACE);
-       slot_reg = readl(php_ctlr->creg + SLOT1 + 4*(slot->hp_slot));
-       dbg("%s: pi = %d, slot_reg = %x\n", __FUNCTION__, pi, slot_reg);
-       slot_status = (u16) slot_reg;
-       dbg("%s: slot_status = %x\n", __FUNCTION__, slot_status);
-       sec_bus_status = readw(php_ctlr->creg + SEC_BUS_CONFIG);
-
-       pcix_cap = (u8) ((slot_status & 0x3000) >> 12);
-       dbg("%s:  pcix_cap = %x\n", __FUNCTION__, pcix_cap);
-       m66_cap = (u8) ((slot_status & 0x0200) >> 9);
-       dbg("%s:  m66_cap = %x\n", __FUNCTION__, m66_cap);
-
+       dbg("%s: slot_reg = %x, pcix_cap = %x, m66_cap = %x\n",
+           __FUNCTION__, slot_reg, pcix_cap, m66_cap);
 
-       if (pi == 2) {
-               switch (pcix_cap) {
-               case 0:
-                       *value = m66_cap ? PCI_SPEED_66MHz : PCI_SPEED_33MHz;
-                       break;
-               case 1:
-                       *value = PCI_SPEED_66MHz_PCIX;
-                       break;
-               case 3:
-                       *value = PCI_SPEED_133MHz_PCIX;
-                       break;
-               case 4:
-                       *value = PCI_SPEED_133MHz_PCIX_266;     
-                       break;
-               case 5:
-                       *value = PCI_SPEED_133MHz_PCIX_533;     
-                       break;
-               case 2: /* Reserved */
-               default:
-                       *value = PCI_SPEED_UNKNOWN;
-                       retval = -ENODEV;
-                       break;
-               }
-       } else {
-               switch (pcix_cap) {
-               case 0:
-                       *value = m66_cap ? PCI_SPEED_66MHz : PCI_SPEED_33MHz;
-                       break;
-               case 1:
-                       *value = PCI_SPEED_66MHz_PCIX;
-                       break;
-               case 3:
-                       *value = PCI_SPEED_133MHz_PCIX; 
-                       break;
-               case 2: /* Reserved */
-               default:
-                       *value = PCI_SPEED_UNKNOWN;
-                       retval = -ENODEV;
-                       break;
-               }
+       switch (pcix_cap) {
+       case 0x0:
+               *value = m66_cap ? PCI_SPEED_66MHz : PCI_SPEED_33MHz;
+               break;
+       case 0x1:
+               *value = PCI_SPEED_66MHz_PCIX;
+               break;
+       case 0x3:
+               *value = PCI_SPEED_133MHz_PCIX;
+               break;
+       case 0x4:
+               *value = PCI_SPEED_133MHz_PCIX_266;
+               break;
+       case 0x5:
+               *value = PCI_SPEED_133MHz_PCIX_533;
+               break;
+       case 0x2:
+       default:
+               *value = PCI_SPEED_UNKNOWN;
+               retval = -ENODEV;
+               break;
        }
 
        dbg("Adapter speed = %d\n", *value);
-       
        DBG_LEAVE_ROUTINE 
        return retval;
 }
 
 static int hpc_get_mode1_ECC_cap(struct slot *slot, u8 *mode)
 {
-       struct php_ctlr_state_s *php_ctlr = (struct php_ctlr_state_s *) slot->ctrl->hpc_ctlr_handle;
+       struct php_ctlr_state_s *php_ctlr = slot->ctrl->hpc_ctlr_handle;
        u16 sec_bus_status;
        u8 pi;
        int retval = 0;
@@ -610,7 +580,7 @@ static int hpc_get_mode1_ECC_cap(struct slot *slot, u8 *mode)
        sec_bus_status = readw(php_ctlr->creg + SEC_BUS_CONFIG);
 
        if (pi == 2) {
-               *mode = (sec_bus_status & 0x0100) >> 7;
+               *mode = (sec_bus_status & 0x0100) >> 8;
        } else {
                retval = -1;
        }
@@ -623,7 +593,7 @@ static int hpc_get_mode1_ECC_cap(struct slot *slot, u8 *mode)
 
 static int hpc_query_power_fault(struct slot * slot)
 {
-       struct php_ctlr_state_s *php_ctlr = (struct php_ctlr_state_s *) slot->ctrl->hpc_ctlr_handle;
+       struct php_ctlr_state_s *php_ctlr = slot->ctrl->hpc_ctlr_handle;
        u32 slot_reg;
        u16 slot_status;
        u8 pwr_fault_state, status;
@@ -647,7 +617,7 @@ static int hpc_query_power_fault(struct slot * slot)
 
 static int hpc_set_attention_status(struct slot *slot, u8 value)
 {
-       struct php_ctlr_state_s *php_ctlr =(struct php_ctlr_state_s *) slot->ctrl->hpc_ctlr_handle;
+       struct php_ctlr_state_s *php_ctlr = slot->ctrl->hpc_ctlr_handle;
        u8 slot_cmd = 0;
        int rc = 0;
 
@@ -683,7 +653,7 @@ static int hpc_set_attention_status(struct slot *slot, u8 value)
 
 static void hpc_set_green_led_on(struct slot *slot)
 {
-       struct php_ctlr_state_s *php_ctlr =(struct php_ctlr_state_s *) slot->ctrl->hpc_ctlr_handle;
+       struct php_ctlr_state_s *php_ctlr = slot->ctrl->hpc_ctlr_handle;
        u8 slot_cmd;
 
        if (!slot->ctrl->hpc_ctlr_handle) {
@@ -705,7 +675,7 @@ static void hpc_set_green_led_on(struct slot *slot)
 
 static void hpc_set_green_led_off(struct slot *slot)
 {
-       struct php_ctlr_state_s *php_ctlr =(struct php_ctlr_state_s *) slot->ctrl->hpc_ctlr_handle;
+       struct php_ctlr_state_s *php_ctlr = slot->ctrl->hpc_ctlr_handle;
        u8 slot_cmd;
 
        if (!slot->ctrl->hpc_ctlr_handle) {
@@ -727,7 +697,7 @@ static void hpc_set_green_led_off(struct slot *slot)
 
 static void hpc_set_green_led_blink(struct slot *slot)
 {
-       struct php_ctlr_state_s *php_ctlr =(struct php_ctlr_state_s *) slot->ctrl->hpc_ctlr_handle;
+       struct php_ctlr_state_s *php_ctlr = slot->ctrl->hpc_ctlr_handle;
        u8 slot_cmd;
 
        if (!slot->ctrl->hpc_ctlr_handle) {
@@ -754,7 +724,7 @@ int shpc_get_ctlr_slot_config(struct controller *ctrl,
        int *updown,            /* physical_slot_num increament: 1 or -1        */
        int *flags)
 {
-       struct php_ctlr_state_s *php_ctlr = (struct php_ctlr_state_s *) ctrl->hpc_ctlr_handle;
+       struct php_ctlr_state_s *php_ctlr = ctrl->hpc_ctlr_handle;
 
        DBG_ENTER_ROUTINE 
 
@@ -776,8 +746,9 @@ int shpc_get_ctlr_slot_config(struct controller *ctrl,
 
 static void hpc_release_ctlr(struct controller *ctrl)
 {
-       struct php_ctlr_state_s *php_ctlr = (struct php_ctlr_state_s *) ctrl->hpc_ctlr_handle;
+       struct php_ctlr_state_s *php_ctlr = ctrl->hpc_ctlr_handle;
        struct php_ctlr_state_s *p, *p_prev;
+       int i;
 
        DBG_ENTER_ROUTINE 
 
@@ -786,6 +757,14 @@ static void hpc_release_ctlr(struct controller *ctrl)
                return ;
        }
 
+       /*
+        * Mask all slot event interrupts
+        */
+       for (i = 0; i < ctrl->num_slots; i++)
+               writel(0xffff3fff, php_ctlr->creg + SLOT1 + (4 * i));
+
+       cleanup_slots(ctrl);
+
        if (shpchp_poll_mode) {
            del_timer(&php_ctlr->int_poll_timer);
        } else {        
@@ -795,11 +774,10 @@ static void hpc_release_ctlr(struct controller *ctrl)
                        pci_disable_msi(php_ctlr->pci_dev);
                }
        }
+
        if (php_ctlr->pci_dev) {
-               dbg("%s: before calling iounmap & release_mem_region\n", __FUNCTION__);
                iounmap(php_ctlr->creg);
-               release_mem_region(pci_resource_start(php_ctlr->pci_dev, 0), pci_resource_len(php_ctlr->pci_dev, 0));
-               dbg("%s: before calling iounmap & release_mem_region\n", __FUNCTION__);
+               release_mem_region(ctrl->mmio_base, ctrl->mmio_size);
                php_ctlr->pci_dev = NULL;
        }
 
@@ -828,7 +806,7 @@ DBG_LEAVE_ROUTINE
 
 static int hpc_power_on_slot(struct slot * slot)
 {
-       struct php_ctlr_state_s *php_ctlr = (struct php_ctlr_state_s *) slot->ctrl->hpc_ctlr_handle;
+       struct php_ctlr_state_s *php_ctlr = slot->ctrl->hpc_ctlr_handle;
        u8 slot_cmd;
        int retval = 0;
 
@@ -859,7 +837,7 @@ static int hpc_power_on_slot(struct slot * slot)
 
 static int hpc_slot_enable(struct slot * slot)
 {
-       struct php_ctlr_state_s *php_ctlr = (struct php_ctlr_state_s *) slot->ctrl->hpc_ctlr_handle;
+       struct php_ctlr_state_s *php_ctlr = slot->ctrl->hpc_ctlr_handle;
        u8 slot_cmd;
        int retval = 0;
 
@@ -890,7 +868,7 @@ static int hpc_slot_enable(struct slot * slot)
 
 static int hpc_slot_disable(struct slot * slot)
 {
-       struct php_ctlr_state_s *php_ctlr = (struct php_ctlr_state_s *) slot->ctrl->hpc_ctlr_handle;
+       struct php_ctlr_state_s *php_ctlr = slot->ctrl->hpc_ctlr_handle;
        u8 slot_cmd;
        int retval = 0;
 
@@ -920,139 +898,68 @@ static int hpc_slot_disable(struct slot * slot)
        return retval;
 }
 
-static int hpc_enable_all_slots( struct slot *slot )
-{
-       int retval = 0;
-
-       DBG_ENTER_ROUTINE 
-       
-       if (!slot->ctrl->hpc_ctlr_handle) {
-               err("%s: Invalid HPC controller handle!\n", __FUNCTION__);
-               return -1;
-       }
-
-       retval = shpc_write_cmd(slot, 0, SET_ENABLE_ALL);
-       if (retval) {
-               err("%s: Write command failed!\n", __FUNCTION__);
-               return -1;
-       }
-
-       DBG_LEAVE_ROUTINE
-
-       return retval;
-}
-
-static int hpc_pwr_on_all_slots(struct slot *slot)
-{
-       int retval = 0;
-
-       DBG_ENTER_ROUTINE 
-
-       retval = shpc_write_cmd(slot, 0, SET_PWR_ON_ALL);
-
-       if (retval) {
-               err("%s: Write command failed!\n", __FUNCTION__);
-               return -1;
-       }
-
-       DBG_LEAVE_ROUTINE
-       return retval;
-}
-
 static int hpc_set_bus_speed_mode(struct slot * slot, enum pci_bus_speed value)
 {
-       u8 slot_cmd;
-       u8 pi;
-       int retval = 0;
-       struct php_ctlr_state_s *php_ctlr = (struct php_ctlr_state_s *) slot->ctrl->hpc_ctlr_handle;
+       int retval;
+       struct php_ctlr_state_s *php_ctlr = slot->ctrl->hpc_ctlr_handle;
+       u8 pi, cmd;
 
        DBG_ENTER_ROUTINE 
-       
-       if (!slot->ctrl->hpc_ctlr_handle) {
-               err("%s: Invalid HPC controller handle!\n", __FUNCTION__);
-               return -1;
-       }
 
        pi = readb(php_ctlr->creg + PROG_INTERFACE);
-       
-       if (pi == 1) {
-               switch (value) {
-               case 0:
-                       slot_cmd = SETA_PCI_33MHZ;
-                       break;
-               case 1:
-                       slot_cmd = SETA_PCI_66MHZ;
-                       break;
-               case 2:
-                       slot_cmd = SETA_PCIX_66MHZ;
-                       break;
-               case 3:
-                       slot_cmd = SETA_PCIX_100MHZ;    
-                       break;
-               case 4:
-                       slot_cmd = SETA_PCIX_133MHZ;    
-                       break;
-               default:
-                       slot_cmd = PCI_SPEED_UNKNOWN;
-                       retval = -ENODEV;
-                       return retval;  
-               }
-       } else {
-               switch (value) {
-               case 0:
-                       slot_cmd = SETB_PCI_33MHZ;
-                       break;
-               case 1:
-                       slot_cmd = SETB_PCI_66MHZ;
-                       break;
-               case 2:
-                       slot_cmd = SETB_PCIX_66MHZ_PM;
-                       break;
-               case 3:
-                       slot_cmd = SETB_PCIX_100MHZ_PM; 
-                       break;
-               case 4:
-                       slot_cmd = SETB_PCIX_133MHZ_PM; 
-                       break;
-               case 5:
-                       slot_cmd = SETB_PCIX_66MHZ_EM;  
-                       break;
-               case 6:
-                       slot_cmd = SETB_PCIX_100MHZ_EM; 
-                       break;
-               case 7:
-                       slot_cmd = SETB_PCIX_133MHZ_EM; 
-                       break;
-               case 8:
-                       slot_cmd = SETB_PCIX_66MHZ_266; 
-                       break;
-               case 0x9:
-                       slot_cmd = SETB_PCIX_100MHZ_266;        
-                       break;
-               case 0xa:
-                       slot_cmd = SETB_PCIX_133MHZ_266;        
-                       break;
-               case 0xb:
-                       slot_cmd = SETB_PCIX_66MHZ_533; 
-                       break;
-               case 0xc:
-                       slot_cmd = SETB_PCIX_100MHZ_533;        
-                       break;
-               case 0xd:
-                       slot_cmd = SETB_PCIX_133MHZ_533;        
-                       break;
-               default:
-                       slot_cmd = PCI_SPEED_UNKNOWN;
-                       retval = -ENODEV;
-                       return retval;  
-               }
+       if ((pi == 1) && (value > PCI_SPEED_133MHz_PCIX))
+               return -EINVAL;
 
+       switch (value) {
+       case PCI_SPEED_33MHz:
+               cmd = SETA_PCI_33MHZ;
+               break;
+       case PCI_SPEED_66MHz:
+               cmd = SETA_PCI_66MHZ;
+               break;
+       case PCI_SPEED_66MHz_PCIX:
+               cmd = SETA_PCIX_66MHZ;
+               break;
+       case PCI_SPEED_100MHz_PCIX:
+               cmd = SETA_PCIX_100MHZ;
+               break;
+       case PCI_SPEED_133MHz_PCIX:
+               cmd = SETA_PCIX_133MHZ;
+               break;
+       case PCI_SPEED_66MHz_PCIX_ECC:
+               cmd = SETB_PCIX_66MHZ_EM;
+               break;
+       case PCI_SPEED_100MHz_PCIX_ECC:
+               cmd = SETB_PCIX_100MHZ_EM;
+               break;
+       case PCI_SPEED_133MHz_PCIX_ECC:
+               cmd = SETB_PCIX_133MHZ_EM;
+               break;
+       case PCI_SPEED_66MHz_PCIX_266:
+               cmd = SETB_PCIX_66MHZ_266;
+               break;
+       case PCI_SPEED_100MHz_PCIX_266:
+               cmd = SETB_PCIX_100MHZ_266;
+               break;
+       case PCI_SPEED_133MHz_PCIX_266:
+               cmd = SETB_PCIX_133MHZ_266;
+               break;
+       case PCI_SPEED_66MHz_PCIX_533:
+               cmd = SETB_PCIX_66MHZ_533;
+               break;
+       case PCI_SPEED_100MHz_PCIX_533:
+               cmd = SETB_PCIX_100MHZ_533;
+               break;
+       case PCI_SPEED_133MHz_PCIX_533:
+               cmd = SETB_PCIX_133MHZ_533;
+               break;
+       default:
+               return -EINVAL;
        }
-       retval = shpc_write_cmd(slot, 0, slot_cmd);
-       if (retval) {
+
+       retval = shpc_write_cmd(slot, 0, cmd);
+       if (retval)
                err("%s: Write command failed!\n", __FUNCTION__);
-               return -1;
-       }
 
        DBG_LEAVE_ROUTINE
        return retval;
@@ -1089,18 +996,13 @@ static irqreturn_t shpc_isr(int IRQ, void *dev_id, struct pt_regs *regs)
 
        if (!intr_loc)
                return IRQ_NONE;
-       dbg("%s: shpc_isr proceeds\n", __FUNCTION__);
        dbg("%s: intr_loc = %x\n",__FUNCTION__, intr_loc); 
 
        if(!shpchp_poll_mode) {
                /* Mask Global Interrupt Mask - see implementation note on p. 139 */
                /* of SHPC spec rev 1.0*/
                temp_dword = readl(php_ctlr->creg + SERR_INTR_ENABLE);
-               dbg("%s: Before masking global interrupt, temp_dword = %x\n",
-                       __FUNCTION__, temp_dword); 
                temp_dword |= 0x00000001;
-               dbg("%s: After masking global interrupt, temp_dword = %x\n",
-                       __FUNCTION__, temp_dword); 
                writel(temp_dword, php_ctlr->creg + SERR_INTR_ENABLE);
 
                intr_loc2 = readl(php_ctlr->creg + INTR_LOC);  
@@ -1110,41 +1012,26 @@ static irqreturn_t shpc_isr(int IRQ, void *dev_id, struct pt_regs *regs)
        if (intr_loc & 0x0001) {
                /* 
                 * Command Complete Interrupt Pending 
-                * RO only - clear by writing 0 to the Command Completion
+                * RO only - clear by writing 1 to the Command Completion
                 * Detect bit in Controller SERR-INT register
                 */
                temp_dword = readl(php_ctlr->creg + SERR_INTR_ENABLE);
-               dbg("%s: Before clearing CCIP, temp_dword = %x\n",
-                       __FUNCTION__, temp_dword); 
-               temp_dword &= 0xfffeffff;
-               dbg("%s: After clearing CCIP, temp_dword = %x\n",
-                       __FUNCTION__, temp_dword); 
+               temp_dword &= 0xfffdffff;
                writel(temp_dword, php_ctlr->creg + SERR_INTR_ENABLE);
+               ctrl->cmd_busy = 0;
                wake_up_interruptible(&ctrl->queue);
        }
 
-       if ((intr_loc = (intr_loc >> 1)) == 0) {
-               /* Unmask Global Interrupt Mask */
-               temp_dword = readl(php_ctlr->creg + SERR_INTR_ENABLE);
-               dbg("%s: 1-Before unmasking global interrupt, temp_dword = %x\n",
-                       __FUNCTION__, temp_dword); 
-               temp_dword &= 0xfffffffe;
-               dbg("%s: 1-After unmasking global interrupt, temp_dword = %x\n",
-                       __FUNCTION__, temp_dword); 
-               writel(temp_dword, php_ctlr->creg + SERR_INTR_ENABLE);
-
-               return IRQ_NONE;
-       }
+       if ((intr_loc = (intr_loc >> 1)) == 0)
+               goto out;
 
        for (hp_slot = 0; hp_slot < ctrl->num_slots; hp_slot++) { 
        /* To find out which slot has interrupt pending */
                if ((intr_loc >> hp_slot) & 0x01) {
                        temp_dword = readl(php_ctlr->creg + SLOT1 + (4*hp_slot));
-                       dbg("%s: Slot %x with intr, temp_dword = %x\n",
-                               __FUNCTION__, hp_slot, temp_dword); 
+                       dbg("%s: Slot %x with intr, slot register = %x\n",
+                               __FUNCTION__, hp_slot, temp_dword);
                        temp_byte = (temp_dword >> 16) & 0xFF;
-                       dbg("%s: Slot with intr, temp_byte = %x\n",
-                               __FUNCTION__, temp_byte); 
                        if ((php_ctlr->switch_change_callback) && (temp_byte & 0x08))
                                schedule_flag += php_ctlr->switch_change_callback(
                                        hp_slot, php_ctlr->callback_instance_id);
@@ -1160,22 +1047,17 @@ static irqreturn_t shpc_isr(int IRQ, void *dev_id, struct pt_regs *regs)
                        
                        /* Clear all slot events */
                        temp_dword = 0xe01f3fff;
-                       dbg("%s: Clearing slot events, temp_dword = %x\n",
-                               __FUNCTION__, temp_dword); 
                        writel(temp_dword, php_ctlr->creg + SLOT1 + (4*hp_slot));
 
                        intr_loc2 = readl(php_ctlr->creg + INTR_LOC);  
                        dbg("%s: intr_loc2 = %x\n",__FUNCTION__, intr_loc2); 
                }
        }
+ out:
        if (!shpchp_poll_mode) {
                /* Unmask Global Interrupt Mask */
                temp_dword = readl(php_ctlr->creg + SERR_INTR_ENABLE);
-               dbg("%s: 2-Before unmasking global interrupt, temp_dword = %x\n",
-                       __FUNCTION__, temp_dword); 
                temp_dword &= 0xfffffffe;
-               dbg("%s: 2-After unmasking global interrupt, temp_dword = %x\n",
-                       __FUNCTION__, temp_dword); 
                writel(temp_dword, php_ctlr->creg + SERR_INTR_ENABLE);
        }
        
@@ -1184,65 +1066,43 @@ static irqreturn_t shpc_isr(int IRQ, void *dev_id, struct pt_regs *regs)
 
 static int hpc_get_max_bus_speed (struct slot *slot, enum pci_bus_speed *value)
 {
-       struct php_ctlr_state_s *php_ctlr = (struct php_ctlr_state_s *) slot->ctrl->hpc_ctlr_handle;
-       enum pci_bus_speed bus_speed = PCI_SPEED_UNKNOWN;
        int retval = 0;
-       u8 pi;
-       u32 slot_avail1, slot_avail2;
-       int slot_num;
+       struct php_ctlr_state_s *php_ctlr = slot->ctrl->hpc_ctlr_handle;
+       enum pci_bus_speed bus_speed = PCI_SPEED_UNKNOWN;
+       u8 pi = readb(php_ctlr->creg + PROG_INTERFACE);
+       u32 slot_avail1 = readl(php_ctlr->creg + SLOT_AVAIL1);
+       u32 slot_avail2 = readl(php_ctlr->creg + SLOT_AVAIL2);
 
        DBG_ENTER_ROUTINE 
 
-       if (!slot->ctrl->hpc_ctlr_handle) {
-               err("%s: Invalid HPC controller handle!\n", __FUNCTION__);
-               return -1;
-       }
-
-       if (slot->hp_slot >= php_ctlr->num_slots) {
-               err("%s: Invalid HPC slot number!\n", __FUNCTION__);
-               return -1;
-       }
-
-       pi = readb(php_ctlr->creg + PROG_INTERFACE);
-       slot_avail1 = readl(php_ctlr->creg + SLOT_AVAIL1);
-       slot_avail2 = readl(php_ctlr->creg + SLOT_AVAIL2);
-
        if (pi == 2) {
-               if ((slot_num = ((slot_avail2 & SLOT_133MHZ_PCIX_533) >> 27)  ) != 0 )
-                       bus_speed = PCIX_133MHZ_533;
-               else if ((slot_num = ((slot_avail2 & SLOT_100MHZ_PCIX_533) >> 23)  ) != 0 )
-                       bus_speed = PCIX_100MHZ_533;
-               else if ((slot_num = ((slot_avail2 & SLOT_66MHZ_PCIX_533) >> 19)  ) != 0 )
-                       bus_speed = PCIX_66MHZ_533;
-               else if ((slot_num = ((slot_avail2 & SLOT_133MHZ_PCIX_266) >> 15)  ) != 0 )
-                       bus_speed = PCIX_133MHZ_266;
-               else if ((slot_num = ((slot_avail2 & SLOT_100MHZ_PCIX_266) >> 11)  ) != 0 )
-                       bus_speed = PCIX_100MHZ_266;
-               else if ((slot_num = ((slot_avail2 & SLOT_66MHZ_PCIX_266) >> 7)  ) != 0 )
-                       bus_speed = PCIX_66MHZ_266;
-               else if ((slot_num = ((slot_avail1 & SLOT_133MHZ_PCIX) >> 23)  ) != 0 )
-                       bus_speed = PCIX_133MHZ;
-               else if ((slot_num = ((slot_avail1 & SLOT_100MHZ_PCIX) >> 15)  ) != 0 )
-                       bus_speed = PCIX_100MHZ;
-               else if ((slot_num = ((slot_avail1 & SLOT_66MHZ_PCIX) >> 7)  ) != 0 )
-                       bus_speed = PCIX_66MHZ;
-               else if ((slot_num = (slot_avail2 & SLOT_66MHZ)) != 0 )
-                       bus_speed = PCI_66MHZ;
-               else if ((slot_num = (slot_avail1 & SLOT_33MHZ)) != 0 )
-                       bus_speed = PCI_33MHZ;
-               else bus_speed = PCI_SPEED_UNKNOWN;
-       } else {
-               if ((slot_num = ((slot_avail1 & SLOT_133MHZ_PCIX) >> 23)  ) != 0 )
-                       bus_speed = PCIX_133MHZ;
-               else if ((slot_num = ((slot_avail1 & SLOT_100MHZ_PCIX) >> 15)  ) != 0 )
-                       bus_speed = PCIX_100MHZ;
-               else if ((slot_num = ((slot_avail1 & SLOT_66MHZ_PCIX) >> 7)  ) != 0 )
-                       bus_speed = PCIX_66MHZ;
-               else if ((slot_num = (slot_avail2 & SLOT_66MHZ)) != 0 )
-                       bus_speed = PCI_66MHZ;
-               else if ((slot_num = (slot_avail1 & SLOT_33MHZ)) != 0 )
-                       bus_speed = PCI_33MHZ;
-               else bus_speed = PCI_SPEED_UNKNOWN;
+               if (slot_avail2 & SLOT_133MHZ_PCIX_533)
+                       bus_speed = PCI_SPEED_133MHz_PCIX_533;
+               else if (slot_avail2 & SLOT_100MHZ_PCIX_533)
+                       bus_speed = PCI_SPEED_100MHz_PCIX_533;
+               else if (slot_avail2 & SLOT_66MHZ_PCIX_533)
+                       bus_speed = PCI_SPEED_66MHz_PCIX_533;
+               else if (slot_avail2 & SLOT_133MHZ_PCIX_266)
+                       bus_speed = PCI_SPEED_133MHz_PCIX_266;
+               else if (slot_avail2 & SLOT_100MHZ_PCIX_266)
+                       bus_speed = PCI_SPEED_100MHz_PCIX_266;
+               else if (slot_avail2 & SLOT_66MHZ_PCIX_266)
+                       bus_speed = PCI_SPEED_66MHz_PCIX_266;
+       }
+
+       if (bus_speed == PCI_SPEED_UNKNOWN) {
+               if (slot_avail1 & SLOT_133MHZ_PCIX)
+                       bus_speed = PCI_SPEED_133MHz_PCIX;
+               else if (slot_avail1 & SLOT_100MHZ_PCIX)
+                       bus_speed = PCI_SPEED_100MHz_PCIX;
+               else if (slot_avail1 & SLOT_66MHZ_PCIX)
+                       bus_speed = PCI_SPEED_66MHz_PCIX;
+               else if (slot_avail2 & SLOT_66MHZ)
+                       bus_speed = PCI_SPEED_66MHz;
+               else if (slot_avail1 & SLOT_33MHZ)
+                       bus_speed = PCI_SPEED_33MHz;
+               else
+                       retval = -ENODEV;
        }
 
        *value = bus_speed;
@@ -1253,111 +1113,69 @@ static int hpc_get_max_bus_speed (struct slot *slot, enum pci_bus_speed *value)
 
 static int hpc_get_cur_bus_speed (struct slot *slot, enum pci_bus_speed *value)
 {
-       struct php_ctlr_state_s *php_ctlr = (struct php_ctlr_state_s *) slot->ctrl->hpc_ctlr_handle;
-       enum pci_bus_speed bus_speed = PCI_SPEED_UNKNOWN;
-       u16 sec_bus_status;
        int retval = 0;
-       u8 pi;
+       struct php_ctlr_state_s *php_ctlr = slot->ctrl->hpc_ctlr_handle;
+       enum pci_bus_speed bus_speed = PCI_SPEED_UNKNOWN;
+       u16 sec_bus_reg = readw(php_ctlr->creg + SEC_BUS_CONFIG);
+       u8 pi = readb(php_ctlr->creg + PROG_INTERFACE);
+       u8 speed_mode = (pi == 2) ? (sec_bus_reg & 0xF) : (sec_bus_reg & 0x7);
 
        DBG_ENTER_ROUTINE 
 
-       if (!slot->ctrl->hpc_ctlr_handle) {
-               err("%s: Invalid HPC controller handle!\n", __FUNCTION__);
-               return -1;
-       }
-
-       if (slot->hp_slot >= php_ctlr->num_slots) {
-               err("%s: Invalid HPC slot number!\n", __FUNCTION__);
-               return -1;
+       if ((pi == 1) && (speed_mode > 4)) {
+               *value = PCI_SPEED_UNKNOWN;
+               return -ENODEV;
        }
 
-       pi = readb(php_ctlr->creg + PROG_INTERFACE);
-       sec_bus_status = readw(php_ctlr->creg + SEC_BUS_CONFIG);
-
-       if (pi == 2) {
-               switch (sec_bus_status & 0x000f) {
-               case 0:
-                       bus_speed = PCI_SPEED_33MHz;
-                       break;
-               case 1:
-                       bus_speed = PCI_SPEED_66MHz;
-                       break;
-               case 2:
-                       bus_speed = PCI_SPEED_66MHz_PCIX;
-                       break;
-               case 3:
-                       bus_speed = PCI_SPEED_100MHz_PCIX;      
-                       break;
-               case 4:
-                       bus_speed = PCI_SPEED_133MHz_PCIX;      
-                       break;
-               case 5:
-                       bus_speed = PCI_SPEED_66MHz_PCIX_ECC;
-                       break;
-               case 6:
-                       bus_speed = PCI_SPEED_100MHz_PCIX_ECC;
-                       break;
-               case 7:
-                       bus_speed = PCI_SPEED_133MHz_PCIX_ECC;  
-                       break;
-               case 8:
-                       bus_speed = PCI_SPEED_66MHz_PCIX_266;   
-                       break;
-               case 9:
-                       bus_speed = PCI_SPEED_100MHz_PCIX_266;  
-                       break;
-               case 0xa:
-                       bus_speed = PCI_SPEED_133MHz_PCIX_266;  
-                       break;
-               case 0xb:
-                       bus_speed = PCI_SPEED_66MHz_PCIX_533;   
-                       break;
-               case 0xc:
-                       bus_speed = PCI_SPEED_100MHz_PCIX_533;  
-                       break;
-               case 0xd:
-                       bus_speed = PCI_SPEED_133MHz_PCIX_533;  
-                       break;
-               case 0xe:
-               case 0xf:
-               default:
-                       bus_speed = PCI_SPEED_UNKNOWN;
-                       break;
-               }
-       } else {
-               /* In the case where pi is undefined, default it to 1 */ 
-               switch (sec_bus_status & 0x0007) {
-               case 0:
-                       bus_speed = PCI_SPEED_33MHz;
-                       break;
-               case 1:
-                       bus_speed = PCI_SPEED_66MHz;
-                       break;
-               case 2:
-                       bus_speed = PCI_SPEED_66MHz_PCIX;
-                       break;
-               case 3:
-                       bus_speed = PCI_SPEED_100MHz_PCIX;      
-                       break;
-               case 4:
-                       bus_speed = PCI_SPEED_133MHz_PCIX;      
-                       break;
-               case 5:
-                       bus_speed = PCI_SPEED_UNKNOWN;          /*      Reserved */
-                       break;
-               case 6:
-                       bus_speed = PCI_SPEED_UNKNOWN;          /*      Reserved */
-                       break;
-               case 7:
-                       bus_speed = PCI_SPEED_UNKNOWN;          /*      Reserved */     
-                       break;
-               default:
-                       bus_speed = PCI_SPEED_UNKNOWN;
-                       break;
-               }
+       switch (speed_mode) {
+       case 0x0:
+               *value = PCI_SPEED_33MHz;
+               break;
+       case 0x1:
+               *value = PCI_SPEED_66MHz;
+               break;
+       case 0x2:
+               *value = PCI_SPEED_66MHz_PCIX;
+               break;
+       case 0x3:
+               *value = PCI_SPEED_100MHz_PCIX;
+               break;
+       case 0x4:
+               *value = PCI_SPEED_133MHz_PCIX;
+               break;
+       case 0x5:
+               *value = PCI_SPEED_66MHz_PCIX_ECC;
+               break;
+       case 0x6:
+               *value = PCI_SPEED_100MHz_PCIX_ECC;
+               break;
+       case 0x7:
+               *value = PCI_SPEED_133MHz_PCIX_ECC;
+               break;
+       case 0x8:
+               *value = PCI_SPEED_66MHz_PCIX_266;
+               break;
+       case 0x9:
+               *value = PCI_SPEED_100MHz_PCIX_266;
+               break;
+       case 0xa:
+               *value = PCI_SPEED_133MHz_PCIX_266;
+               break;
+       case 0xb:
+               *value = PCI_SPEED_66MHz_PCIX_533;
+               break;
+       case 0xc:
+               *value = PCI_SPEED_100MHz_PCIX_533;
+               break;
+       case 0xd:
+               *value = PCI_SPEED_133MHz_PCIX_533;
+               break;
+       default:
+               *value = PCI_SPEED_UNKNOWN;
+               retval = -ENODEV;
+               break;
        }
 
-       *value = bus_speed;
        dbg("Current bus speed = %d\n", bus_speed);
        DBG_LEAVE_ROUTINE 
        return retval;
@@ -1367,8 +1185,6 @@ static struct hpc_ops shpchp_hpc_ops = {
        .power_on_slot                  = hpc_power_on_slot,
        .slot_enable                    = hpc_slot_enable,
        .slot_disable                   = hpc_slot_disable,
-       .enable_all_slots               = hpc_enable_all_slots,
-       .pwr_on_all_slots               = hpc_pwr_on_all_slots,
        .set_bus_speed_mode             = hpc_set_bus_speed_mode,         
        .set_attention_status   = hpc_set_attention_status,
        .get_power_status               = hpc_get_power_status,
@@ -1388,89 +1204,87 @@ static struct hpc_ops shpchp_hpc_ops = {
        .green_led_blink                = hpc_set_green_led_blink,
        
        .release_ctlr                   = hpc_release_ctlr,
-       .check_cmd_status               = hpc_check_cmd_status,
 };
 
-int shpc_init(struct controller * ctrl,
-               struct pci_dev * pdev,
-               php_intr_callback_t attention_button_callback,
-               php_intr_callback_t switch_change_callback,
-               php_intr_callback_t presence_change_callback,
-               php_intr_callback_t power_fault_callback)
+inline static int shpc_indirect_creg_read(struct controller *ctrl, int index,
+                                         u32 *value)
+{
+       int rc;
+       u32 cap_offset = ctrl->cap_offset;
+       struct pci_dev *pdev = ctrl->pci_dev;
+
+       rc = pci_write_config_byte(pdev, cap_offset + DWORD_SELECT, index);
+       if (rc)
+               return rc;
+       return pci_read_config_dword(pdev, cap_offset + DWORD_DATA, value);
+}
+
+int shpc_init(struct controller * ctrl, struct pci_dev * pdev)
 {
        struct php_ctlr_state_s *php_ctlr, *p;
        void *instance_id = ctrl;
-       int rc;
+       int rc, num_slots = 0;
        u8 hp_slot;
        static int first = 1;
-       u32 shpc_cap_offset, shpc_base_offset;
+       u32 shpc_base_offset;
        u32 tempdword, slot_reg;
-       u16 vendor_id, device_id;
        u8 i;
 
        DBG_ENTER_ROUTINE
 
+       ctrl->pci_dev = pdev;  /* pci_dev of the P2P bridge */
+
        spin_lock_init(&list_lock);
-       php_ctlr = (struct php_ctlr_state_s *) kmalloc(sizeof(struct php_ctlr_state_s), GFP_KERNEL);
+       php_ctlr = kzalloc(sizeof(*php_ctlr), GFP_KERNEL);
 
        if (!php_ctlr) {        /* allocate controller state data */
                err("%s: HPC controller memory allocation error!\n", __FUNCTION__);
                goto abort;
        }
 
-       memset(php_ctlr, 0, sizeof(struct php_ctlr_state_s));
-
        php_ctlr->pci_dev = pdev;       /* save pci_dev in context */
 
-       rc = pci_read_config_word(pdev, PCI_VENDOR_ID, &vendor_id);
-       dbg("%s: Vendor ID: %x\n",__FUNCTION__, vendor_id);
-       if (rc) {
-               err("%s: unable to read PCI configuration data\n", __FUNCTION__);
-               goto abort_free_ctlr;
-       }
-
-       rc = pci_read_config_word(pdev, PCI_DEVICE_ID, &device_id);
-       dbg("%s: Device ID: %x\n",__FUNCTION__, device_id);
-       if (rc) {
-               err("%s: unable to read PCI configuration data\n", __FUNCTION__);
-               goto abort_free_ctlr;
-       }
-
-       if ((vendor_id == PCI_VENDOR_ID_AMD) || (device_id == PCI_DEVICE_ID_AMD_GOLAM_7450)) {
-               shpc_base_offset = 0;  /* amd shpc driver doesn't use this; assume 0 */
+       if ((pdev->vendor == PCI_VENDOR_ID_AMD) || (pdev->device ==
+                               PCI_DEVICE_ID_AMD_GOLAM_7450)) {
+               /* amd shpc driver doesn't use Base Offset; assume 0 */
+               ctrl->mmio_base = pci_resource_start(pdev, 0);
+               ctrl->mmio_size = pci_resource_len(pdev, 0);
        } else {
-               if ((shpc_cap_offset = pci_find_capability(pdev, PCI_CAP_ID_SHPC)) == 0) {
-                       err("%s : shpc_cap_offset == 0\n", __FUNCTION__);
+               ctrl->cap_offset = pci_find_capability(pdev, PCI_CAP_ID_SHPC);
+               if (!ctrl->cap_offset) {
+                       err("%s : cap_offset == 0\n", __FUNCTION__);
                        goto abort_free_ctlr;
                }
-               dbg("%s: shpc_cap_offset = %x\n", __FUNCTION__, shpc_cap_offset);       
-       
-               rc = pci_write_config_byte(pdev, (u8)shpc_cap_offset + DWORD_SELECT , BASE_OFFSET);
+               dbg("%s: cap_offset = %x\n", __FUNCTION__, ctrl->cap_offset);
+
+               rc = shpc_indirect_creg_read(ctrl, 0, &shpc_base_offset);
                if (rc) {
-                       err("%s : pci_word_config_byte failed\n", __FUNCTION__);
+                       err("%s: cannot read base_offset\n", __FUNCTION__);
                        goto abort_free_ctlr;
                }
-       
-               rc = pci_read_config_dword(pdev, (u8)shpc_cap_offset + DWORD_DATA, &shpc_base_offset);
+
+               rc = shpc_indirect_creg_read(ctrl, 3, &tempdword);
                if (rc) {
-                       err("%s : pci_read_config_dword failed\n", __FUNCTION__);
+                       err("%s: cannot read slot config\n", __FUNCTION__);
                        goto abort_free_ctlr;
                }
+               num_slots = tempdword & SLOT_NUM;
+               dbg("%s: num_slots (indirect) %x\n", __FUNCTION__, num_slots);
 
-               for (i = 0; i <= 14; i++) {
-                       rc = pci_write_config_byte(pdev, (u8)shpc_cap_offset +  DWORD_SELECT , i);
-                       if (rc) {
-                               err("%s : pci_word_config_byte failed\n", __FUNCTION__);
-                               goto abort_free_ctlr;
-                       }
-       
-                       rc = pci_read_config_dword(pdev, (u8)shpc_cap_offset + DWORD_DATA, &tempdword);
+               for (i = 0; i < 9 + num_slots; i++) {
+                       rc = shpc_indirect_creg_read(ctrl, i, &tempdword);
                        if (rc) {
-                               err("%s : pci_read_config_dword failed\n", __FUNCTION__);
+                               err("%s: cannot read creg (index = %d)\n",
+                                   __FUNCTION__, i);
                                goto abort_free_ctlr;
                        }
-                       dbg("%s: offset %d: tempdword %x\n", __FUNCTION__,i, tempdword);
+                       dbg("%s: offset %d: value %x\n", __FUNCTION__,i,
+                                       tempdword);
                }
+
+               ctrl->mmio_base =
+                       pci_resource_start(pdev, 0) + shpc_base_offset;
+               ctrl->mmio_size = 0x24 + 0x4 * num_slots;
        }
 
        if (first) {
@@ -1478,47 +1292,38 @@ int shpc_init(struct controller * ctrl,
                first = 0;
        }
 
-       dbg("pdev = %p: b:d:f:irq=0x%x:%x:%x:%x\n", pdev, pdev->bus->number, PCI_SLOT(pdev->devfn), 
-               PCI_FUNC(pdev->devfn), pdev->irq);
-       for ( rc = 0; rc < DEVICE_COUNT_RESOURCE; rc++)
-               if (pci_resource_len(pdev, rc) > 0)
-                       dbg("pci resource[%d] start=0x%lx(len=0x%lx), shpc_base_offset %x\n", rc,
-                               pci_resource_start(pdev, rc), pci_resource_len(pdev, rc), shpc_base_offset);
-
        info("HPC vendor_id %x device_id %x ss_vid %x ss_did %x\n", pdev->vendor, pdev->device, pdev->subsystem_vendor, 
                pdev->subsystem_device);
        
        if (pci_enable_device(pdev))
                goto abort_free_ctlr;
 
-       if (!request_mem_region(pci_resource_start(pdev, 0) + shpc_base_offset, pci_resource_len(pdev, 0), MY_NAME)) {
+       if (!request_mem_region(ctrl->mmio_base, ctrl->mmio_size, MY_NAME)) {
                err("%s: cannot reserve MMIO region\n", __FUNCTION__);
                goto abort_free_ctlr;
        }
 
-       php_ctlr->creg = ioremap(pci_resource_start(pdev, 0) + shpc_base_offset, pci_resource_len(pdev, 0));
+       php_ctlr->creg = ioremap(ctrl->mmio_base, ctrl->mmio_size);
        if (!php_ctlr->creg) {
-               err("%s: cannot remap MMIO region %lx @ %lx\n", __FUNCTION__, pci_resource_len(pdev, 0), 
-                       pci_resource_start(pdev, 0) + shpc_base_offset);
-               release_mem_region(pci_resource_start(pdev, 0) + shpc_base_offset, pci_resource_len(pdev, 0));
+               err("%s: cannot remap MMIO region %lx @ %lx\n", __FUNCTION__,
+                   ctrl->mmio_size, ctrl->mmio_base);
+               release_mem_region(ctrl->mmio_base, ctrl->mmio_size);
                goto abort_free_ctlr;
        }
        dbg("%s: php_ctlr->creg %p\n", __FUNCTION__, php_ctlr->creg);
-       dbg("%s: physical addr %p\n", __FUNCTION__, (void*)pci_resource_start(pdev, 0));
 
-       init_MUTEX(&ctrl->crit_sect);
+       mutex_init(&ctrl->crit_sect);
+       mutex_init(&ctrl->cmd_lock);
+
        /* Setup wait queue */
        init_waitqueue_head(&ctrl->queue);
 
        /* Find the IRQ */
        php_ctlr->irq = pdev->irq;
-       dbg("HPC interrupt = %d\n", php_ctlr->irq);
-
-       /* Save interrupt callback info */
-       php_ctlr->attention_button_callback = attention_button_callback;
-       php_ctlr->switch_change_callback = switch_change_callback;
-       php_ctlr->presence_change_callback = presence_change_callback;
-       php_ctlr->power_fault_callback = power_fault_callback;
+       php_ctlr->attention_button_callback = shpchp_handle_attention_button,
+       php_ctlr->switch_change_callback = shpchp_handle_switch_change;
+       php_ctlr->presence_change_callback = shpchp_handle_presence_change;
+       php_ctlr->power_fault_callback = shpchp_handle_power_fault;
        php_ctlr->callback_instance_id = instance_id;
 
        /* Return PCI Controller Info */
@@ -1556,7 +1361,6 @@ int shpc_init(struct controller * ctrl,
                if (rc) {
                        info("Can't get msi for the hotplug controller\n");
                        info("Use INTx for the hotplug controller\n");
-                       dbg("%s: rc = %x\n", __FUNCTION__, rc);
                } else
                        php_ctlr->irq = pdev->irq;
                
@@ -1566,9 +1370,11 @@ int shpc_init(struct controller * ctrl,
                        err("Can't get irq %d for the hotplug controller\n", php_ctlr->irq);
                        goto abort_free_ctlr;
                }
-               /* Execute OSHP method here */
        }
-       dbg("%s: Before adding HPC to HPC list\n", __FUNCTION__);
+       dbg("%s: HPC at b:d:f:irq=0x%x:%x:%x:%x\n", __FUNCTION__,
+                       pdev->bus->number, PCI_SLOT(pdev->devfn),
+                       PCI_FUNC(pdev->devfn), pdev->irq);
+       get_hp_hw_control_from_firmware(pdev);
 
        /*  Add this HPC instance into the HPC list */
        spin_lock(&list_lock);
@@ -1607,7 +1413,6 @@ int shpc_init(struct controller * ctrl,
                dbg("%s: SERR_INTR_ENABLE = %x\n", __FUNCTION__, tempdword);
        }
 
-       dbg("%s: Leaving shpc_init\n", __FUNCTION__);
        DBG_LEAVE_ROUTINE
        return 0;