vserver 2.0 rc7
[linux-2.6.git] / drivers / scsi / scsi_transport_spi.c
index 83c038e..67c6cc4 100644 (file)
  *  along with this program; if not, write to the Free Software
  *  Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
  */
-#include <linux/module.h>
+#include <linux/ctype.h>
 #include <linux/init.h>
-#include <linux/smp_lock.h>
-#include <linux/list.h>
-#include <linux/spinlock.h>
-#include <linux/mm.h>
+#include <linux/module.h>
 #include <linux/workqueue.h>
-#include <asm/scatterlist.h>
-#include <asm/io.h>
+#include <linux/blkdev.h>
+#include <asm/semaphore.h>
 #include <scsi/scsi.h>
 #include "scsi_priv.h"
 #include <scsi/scsi_device.h>
 
 #define SPI_PRINTK(x, l, f, a...)      dev_printk(l, &(x)->dev, f , ##a)
 
-#define SPI_NUM_ATTRS 10       /* increase this if you add attributes */
+#define SPI_NUM_ATTRS 13       /* increase this if you add attributes */
 #define SPI_OTHER_ATTRS 1      /* Increase this if you add "always
                                 * on" attributes */
 #define SPI_HOST_ATTRS 1
 
 #define SPI_MAX_ECHO_BUFFER_SIZE       4096
 
+#define DV_LOOPS       3
+#define DV_TIMEOUT     (10*HZ)
+#define DV_RETRIES     3       /* should only need at most 
+                                * two cc/ua clears */
+
 /* Private data accessors (keep these out of the header file) */
 #define spi_dv_pending(x) (((struct spi_transport_attrs *)&(x)->starget_data)->dv_pending)
 #define spi_dv_sem(x) (((struct spi_transport_attrs *)&(x)->starget_data)->dv_sem)
@@ -63,27 +65,70 @@ struct spi_internal {
 
 #define to_spi_internal(tmpl)  container_of(tmpl, struct spi_internal, t)
 
-static const char *const ppr_to_ns[] = {
+static const int ppr_to_ps[] = {
        /* The PPR values 0-6 are reserved, fill them in when
         * the committee defines them */
-       NULL,                   /* 0x00 */
-       NULL,                   /* 0x01 */
-       NULL,                   /* 0x02 */
-       NULL,                   /* 0x03 */
-       NULL,                   /* 0x04 */
-       NULL,                   /* 0x05 */
-       NULL,                   /* 0x06 */
-       "3.125",                /* 0x07 */
-       "6.25",                 /* 0x08 */
-       "12.5",                 /* 0x09 */
-       "25",                   /* 0x0a */
-       "30.3",                 /* 0x0b */
-       "50",                   /* 0x0c */
+       -1,                     /* 0x00 */
+       -1,                     /* 0x01 */
+       -1,                     /* 0x02 */
+       -1,                     /* 0x03 */
+       -1,                     /* 0x04 */
+       -1,                     /* 0x05 */
+       -1,                     /* 0x06 */
+        3125,                  /* 0x07 */
+        6250,                  /* 0x08 */
+       12500,                  /* 0x09 */
+       25000,                  /* 0x0a */
+       30300,                  /* 0x0b */
+       50000,                  /* 0x0c */
 };
 /* The PPR values at which you calculate the period in ns by multiplying
  * by 4 */
 #define SPI_STATIC_PPR 0x0c
 
+static int sprint_frac(char *dest, int value, int denom)
+{
+       int frac = value % denom;
+       int result = sprintf(dest, "%d", value / denom);
+
+       if (frac == 0)
+               return result;
+       dest[result++] = '.';
+
+       do {
+               denom /= 10;
+               sprintf(dest + result, "%d", frac / denom);
+               result++;
+               frac %= denom;
+       } while (frac);
+
+       dest[result++] = '\0';
+       return result;
+}
+
+/* Modification of scsi_wait_req that will clear UNIT ATTENTION conditions
+ * resulting from (likely) bus and device resets */
+static void spi_wait_req(struct scsi_request *sreq, const void *cmd,
+                        void *buffer, unsigned bufflen)
+{
+       int i;
+
+       for(i = 0; i < DV_RETRIES; i++) {
+               sreq->sr_request->flags |= REQ_FAILFAST;
+
+               scsi_wait_req(sreq, cmd, buffer, bufflen,
+                             DV_TIMEOUT, /* retries */ 1);
+               if (sreq->sr_result & DRIVER_SENSE) {
+                       struct scsi_sense_hdr sshdr;
+
+                       if (scsi_request_normalize_sense(sreq, &sshdr)
+                           && sshdr.sense_key == UNIT_ATTENTION)
+                               continue;
+               }
+               break;
+       }
+}
+
 static struct {
        enum spi_signal_type    value;
        char                    *name;
@@ -142,13 +187,13 @@ static int spi_host_match(struct attribute_container *cont,
                return 0;
 
        shost = dev_to_shost(dev);
-       if (!shost->transportt  || shost->transportt->host_attrs.class
+       if (!shost->transportt  || shost->transportt->host_attrs.ac.class
            != &spi_host_class.class)
                return 0;
 
        i = to_spi_internal(shost->transportt);
        
-       return &i->t.host_attrs == cont;
+       return &i->t.host_attrs.ac == cont;
 }
 
 static int spi_device_configure(struct device *dev)
@@ -174,8 +219,11 @@ static int spi_setup_transport_attrs(struct device *dev)
        struct scsi_target *starget = to_scsi_target(dev);
 
        spi_period(starget) = -1;       /* illegal value */
+       spi_min_period(starget) = 0;
        spi_offset(starget) = 0;        /* async */
+       spi_max_offset(starget) = 255;
        spi_width(starget) = 0; /* narrow */
+       spi_max_width(starget) = 1;
        spi_iu(starget) = 0;    /* no IU */
        spi_dt(starget) = 0;    /* ST */
        spi_qas(starget) = 0;
@@ -190,6 +238,34 @@ static int spi_setup_transport_attrs(struct device *dev)
        return 0;
 }
 
+#define spi_transport_show_simple(field, format_string)                        \
+                                                                       \
+static ssize_t                                                         \
+show_spi_transport_##field(struct class_device *cdev, char *buf)       \
+{                                                                      \
+       struct scsi_target *starget = transport_class_to_starget(cdev); \
+       struct spi_transport_attrs *tp;                                 \
+                                                                       \
+       tp = (struct spi_transport_attrs *)&starget->starget_data;      \
+       return snprintf(buf, 20, format_string, tp->field);             \
+}
+
+#define spi_transport_store_simple(field, format_string)               \
+                                                                       \
+static ssize_t                                                         \
+store_spi_transport_##field(struct class_device *cdev, const char *buf, \
+                           size_t count)                               \
+{                                                                      \
+       int val;                                                        \
+       struct scsi_target *starget = transport_class_to_starget(cdev); \
+       struct spi_transport_attrs *tp;                                 \
+                                                                       \
+       tp = (struct spi_transport_attrs *)&starget->starget_data;      \
+       val = simple_strtoul(buf, NULL, 0);                             \
+       tp->field = val;                                                \
+       return count;                                                   \
+}
+
 #define spi_transport_show_function(field, format_string)              \
                                                                        \
 static ssize_t                                                         \
@@ -216,6 +292,25 @@ store_spi_transport_##field(struct class_device *cdev, const char *buf, \
        struct spi_internal *i = to_spi_internal(shost->transportt);    \
                                                                        \
        val = simple_strtoul(buf, NULL, 0);                             \
+       i->f->set_##field(starget, val);                        \
+       return count;                                                   \
+}
+
+#define spi_transport_store_max(field, format_string)                  \
+static ssize_t                                                         \
+store_spi_transport_##field(struct class_device *cdev, const char *buf, \
+                           size_t count)                               \
+{                                                                      \
+       int val;                                                        \
+       struct scsi_target *starget = transport_class_to_starget(cdev); \
+       struct Scsi_Host *shost = dev_to_shost(starget->dev.parent);    \
+       struct spi_internal *i = to_spi_internal(shost->transportt);    \
+       struct spi_transport_attrs *tp                                  \
+               = (struct spi_transport_attrs *)&starget->starget_data; \
+                                                                       \
+       val = simple_strtoul(buf, NULL, 0);                             \
+       if (val > tp->max_##field)                                      \
+               val = tp->max_##field;                                  \
        i->f->set_##field(starget, val);                                \
        return count;                                                   \
 }
@@ -227,9 +322,24 @@ static CLASS_DEVICE_ATTR(field, S_IRUGO | S_IWUSR,                 \
                         show_spi_transport_##field,                    \
                         store_spi_transport_##field);
 
+#define spi_transport_simple_attr(field, format_string)                        \
+       spi_transport_show_simple(field, format_string)                 \
+       spi_transport_store_simple(field, format_string)                \
+static CLASS_DEVICE_ATTR(field, S_IRUGO | S_IWUSR,                     \
+                        show_spi_transport_##field,                    \
+                        store_spi_transport_##field);
+
+#define spi_transport_max_attr(field, format_string)                   \
+       spi_transport_show_function(field, format_string)               \
+       spi_transport_store_max(field, format_string)                   \
+       spi_transport_simple_attr(max_##field, format_string)           \
+static CLASS_DEVICE_ATTR(field, S_IRUGO | S_IWUSR,                     \
+                        show_spi_transport_##field,                    \
+                        store_spi_transport_##field);
+
 /* The Parallel SCSI Tranport Attributes: */
-spi_transport_rd_attr(offset, "%d\n");
-spi_transport_rd_attr(width, "%d\n");
+spi_transport_max_attr(offset, "%d\n");
+spi_transport_max_attr(width, "%d\n");
 spi_transport_rd_attr(iu, "%d\n");
 spi_transport_rd_attr(dt, "%d\n");
 spi_transport_rd_attr(qas, "%d\n");
@@ -255,36 +365,81 @@ static CLASS_DEVICE_ATTR(revalidate, S_IWUSR, NULL, store_spi_revalidate);
 
 /* Translate the period into ns according to the current spec
  * for SDTR/PPR messages */
-static ssize_t show_spi_transport_period(struct class_device *cdev, char *buf)
-
+static ssize_t
+show_spi_transport_period_helper(struct class_device *cdev, char *buf,
+                                int period)
 {
-       struct scsi_target *starget = transport_class_to_starget(cdev);
-       struct Scsi_Host *shost = dev_to_shost(starget->dev.parent);
-       struct spi_transport_attrs *tp;
-       const char *str;
-       struct spi_internal *i = to_spi_internal(shost->transportt);
+       int len, picosec;
+
+       if (period < 0 || period > 0xff) {
+               picosec = -1;
+       } else if (period <= SPI_STATIC_PPR) {
+               picosec = ppr_to_ps[period];
+       } else {
+               picosec = period * 4000;
+       }
 
-       tp = (struct spi_transport_attrs *)&starget->starget_data;
+       if (picosec == -1) {
+               len = sprintf(buf, "reserved");
+       } else {
+               len = sprint_frac(buf, picosec, 1000);
+       }
 
-       if (i->f->get_period)
-               i->f->get_period(starget);
+       buf[len++] = '\n';
+       buf[len] = '\0';
+       return len;
+}
 
-       switch(tp->period) {
+static ssize_t
+store_spi_transport_period_helper(struct class_device *cdev, const char *buf,
+                                 size_t count, int *periodp)
+{
+       int j, picosec, period = -1;
+       char *endp;
+
+       picosec = simple_strtoul(buf, &endp, 10) * 1000;
+       if (*endp == '.') {
+               int mult = 100;
+               do {
+                       endp++;
+                       if (!isdigit(*endp))
+                               break;
+                       picosec += (*endp - '0') * mult;
+                       mult /= 10;
+               } while (mult > 0);
+       }
 
-       case 0x07 ... SPI_STATIC_PPR:
-               str = ppr_to_ns[tp->period];
-               if(!str)
-                       str = "reserved";
+       for (j = 0; j <= SPI_STATIC_PPR; j++) {
+               if (ppr_to_ps[j] < picosec)
+                       continue;
+               period = j;
                break;
+       }
 
+       if (period == -1)
+               period = picosec / 4000;
 
-       case (SPI_STATIC_PPR+1) ... 0xff:
-               return sprintf(buf, "%d\n", tp->period * 4);
+       if (period > 0xff)
+               period = 0xff;
 
-       default:
-               str = "unknown";
-       }
-       return sprintf(buf, "%s\n", str);
+       *periodp = period;
+
+       return count;
+}
+
+static ssize_t
+show_spi_transport_period(struct class_device *cdev, char *buf)
+{
+       struct scsi_target *starget = transport_class_to_starget(cdev);
+       struct Scsi_Host *shost = dev_to_shost(starget->dev.parent);
+       struct spi_internal *i = to_spi_internal(shost->transportt);
+       struct spi_transport_attrs *tp =
+               (struct spi_transport_attrs *)&starget->starget_data;
+
+       if (i->f->get_period)
+               i->f->get_period(starget);
+
+       return show_spi_transport_period_helper(cdev, buf, tp->period);
 }
 
 static ssize_t
@@ -294,46 +449,51 @@ store_spi_transport_period(struct class_device *cdev, const char *buf,
        struct scsi_target *starget = transport_class_to_starget(cdev);
        struct Scsi_Host *shost = dev_to_shost(starget->dev.parent);
        struct spi_internal *i = to_spi_internal(shost->transportt);
-       int j, period = -1;
+       struct spi_transport_attrs *tp =
+               (struct spi_transport_attrs *)&starget->starget_data;
+       int period, retval;
 
-       for (j = 0; j < SPI_STATIC_PPR; j++) {
-               int len;
+       retval = store_spi_transport_period_helper(cdev, buf, count, &period);
 
-               if(ppr_to_ns[j] == NULL)
-                       continue;
+       if (period < tp->min_period)
+               period = tp->min_period;
 
-               len = strlen(ppr_to_ns[j]);
+       i->f->set_period(starget, period);
 
-               if(strncmp(ppr_to_ns[j], buf, len) != 0)
-                       continue;
+       return retval;
+}
 
-               if(buf[len] != '\n')
-                       continue;
-               
-               period = j;
-               break;
-       }
+static CLASS_DEVICE_ATTR(period, S_IRUGO | S_IWUSR, 
+                        show_spi_transport_period,
+                        store_spi_transport_period);
 
-       if (period == -1) {
-               int val = simple_strtoul(buf, NULL, 0);
+static ssize_t
+show_spi_transport_min_period(struct class_device *cdev, char *buf)
+{
+       struct scsi_target *starget = transport_class_to_starget(cdev);
+       struct spi_transport_attrs *tp =
+               (struct spi_transport_attrs *)&starget->starget_data;
 
+       return show_spi_transport_period_helper(cdev, buf, tp->min_period);
+}
 
-               /* Should probably check limits here, but this
-                * gets reasonably close to OK for most things */
-               period = val/4;
-       }
+static ssize_t
+store_spi_transport_min_period(struct class_device *cdev, const char *buf,
+                           size_t count)
+{
+       struct scsi_target *starget = transport_class_to_starget(cdev);
+       struct spi_transport_attrs *tp =
+               (struct spi_transport_attrs *)&starget->starget_data;
 
-       if (period > 0xff)
-               period = 0xff;
+       return store_spi_transport_period_helper(cdev, buf, count,
+                                                &tp->min_period);
+}
 
-       i->f->set_period(starget, period);
 
-       return count;
-}
-       
-static CLASS_DEVICE_ATTR(period, S_IRUGO | S_IWUSR, 
-                        show_spi_transport_period,
-                        store_spi_transport_period);
+static CLASS_DEVICE_ATTR(min_period, S_IRUGO | S_IWUSR, 
+                        show_spi_transport_min_period,
+                        store_spi_transport_min_period);
+
 
 static ssize_t show_spi_host_signalling(struct class_device *cdev, char *buf)
 {
@@ -365,11 +525,6 @@ static CLASS_DEVICE_ATTR(signalling, S_IRUGO | S_IWUSR,
        if(i->f->set_##x)               \
                i->f->set_##x(sdev->sdev_target, y)
 
-#define DV_LOOPS       3
-#define DV_TIMEOUT     (10*HZ)
-#define DV_RETRIES     3       /* should only need at most 
-                                * two cc/ua clears */
-
 enum spi_compare_returns {
        SPI_COMPARE_SUCCESS,
        SPI_COMPARE_FAILURE,
@@ -433,8 +588,7 @@ spi_dv_device_echo_buffer(struct scsi_request *sreq, u8 *buffer,
        for (r = 0; r < retries; r++) {
                sreq->sr_cmd_len = 0;   /* wait_req to fill in */
                sreq->sr_data_direction = DMA_TO_DEVICE;
-               scsi_wait_req(sreq, spi_write_buffer, buffer, len,
-                             DV_TIMEOUT, DV_RETRIES);
+               spi_wait_req(sreq, spi_write_buffer, buffer, len);
                if(sreq->sr_result || !scsi_device_online(sdev)) {
                        struct scsi_sense_hdr sshdr;
 
@@ -458,8 +612,7 @@ spi_dv_device_echo_buffer(struct scsi_request *sreq, u8 *buffer,
                memset(ptr, 0, len);
                sreq->sr_cmd_len = 0;   /* wait_req to fill in */
                sreq->sr_data_direction = DMA_FROM_DEVICE;
-               scsi_wait_req(sreq, spi_read_buffer, ptr, len,
-                             DV_TIMEOUT, DV_RETRIES);
+               spi_wait_req(sreq, spi_read_buffer, ptr, len);
                scsi_device_set_state(sdev, SDEV_QUIESCE);
 
                if (memcmp(buffer, ptr, len) != 0)
@@ -487,8 +640,7 @@ spi_dv_device_compare_inquiry(struct scsi_request *sreq, u8 *buffer,
 
                memset(ptr, 0, len);
 
-               scsi_wait_req(sreq, spi_inquiry, ptr, len,
-                             DV_TIMEOUT, DV_RETRIES);
+               spi_wait_req(sreq, spi_inquiry, ptr, len);
                
                if(sreq->sr_result || !scsi_device_online(sdev)) {
                        scsi_device_set_state(sdev, SDEV_QUIESCE);
@@ -580,8 +732,7 @@ spi_dv_device_get_echo_buffer(struct scsi_request *sreq, u8 *buffer)
         * (reservation conflict, device not ready, etc) just
         * skip the write tests */
        for (l = 0; ; l++) {
-               scsi_wait_req(sreq, spi_test_unit_ready, NULL, 0,
-                             DV_TIMEOUT, DV_RETRIES);
+               spi_wait_req(sreq, spi_test_unit_ready, NULL, 0);
 
                if(sreq->sr_result) {
                        if(l >= 3)
@@ -595,8 +746,7 @@ spi_dv_device_get_echo_buffer(struct scsi_request *sreq, u8 *buffer)
        sreq->sr_cmd_len = 0;
        sreq->sr_data_direction = DMA_FROM_DEVICE;
 
-       scsi_wait_req(sreq, spi_read_buffer_descriptor, buffer, 4,
-                     DV_TIMEOUT, DV_RETRIES);
+       spi_wait_req(sreq, spi_read_buffer_descriptor, buffer, 4);
 
        if (sreq->sr_result)
                /* Device has no echo buffer */
@@ -610,6 +760,7 @@ spi_dv_device_internal(struct scsi_request *sreq, u8 *buffer)
 {
        struct spi_internal *i = to_spi_internal(sreq->sr_host->transportt);
        struct scsi_device *sdev = sreq->sr_device;
+       struct scsi_target *starget = sdev->sdev_target;
        int len = sdev->inquiry_len;
        /* first set us up for narrow async */
        DV_SET(offset, 0);
@@ -623,9 +774,11 @@ spi_dv_device_internal(struct scsi_request *sreq, u8 *buffer)
        }
 
        /* test width */
-       if (i->f->set_width && sdev->wdtr) {
+       if (i->f->set_width && spi_max_width(starget) && sdev->wdtr) {
                i->f->set_width(sdev->sdev_target, 1);
 
+               printk("WIDTH IS %d\n", spi_max_width(starget));
+
                if (spi_dv_device_compare_inquiry(sreq, buffer,
                                                   buffer + len,
                                                   DV_LOOPS)
@@ -652,8 +805,8 @@ spi_dv_device_internal(struct scsi_request *sreq, u8 *buffer)
  retry:
 
        /* now set up to the maximum */
-       DV_SET(offset, 255);
-       DV_SET(period, 1);
+       DV_SET(offset, spi_max_offset(starget));
+       DV_SET(period, spi_min_period(starget));
 
        if (len == 0) {
                SPI_PRINTK(sdev->sdev_target, KERN_INFO, "Domain Validation skipping write tests\n");
@@ -795,6 +948,61 @@ spi_schedule_dv_device(struct scsi_device *sdev)
 }
 EXPORT_SYMBOL(spi_schedule_dv_device);
 
+/**
+ * spi_display_xfer_agreement - Print the current target transfer agreement
+ * @starget: The target for which to display the agreement
+ *
+ * Each SPI port is required to maintain a transfer agreement for each
+ * other port on the bus.  This function prints a one-line summary of
+ * the current agreement; more detailed information is available in sysfs.
+ */
+void spi_display_xfer_agreement(struct scsi_target *starget)
+{
+       struct spi_transport_attrs *tp;
+       tp = (struct spi_transport_attrs *)&starget->starget_data;
+
+       if (tp->offset > 0 && tp->period > 0) {
+               unsigned int picosec, kb100;
+               char *scsi = "FAST-?";
+               char tmp[8];
+
+               if (tp->period <= SPI_STATIC_PPR) {
+                       picosec = ppr_to_ps[tp->period];
+                       switch (tp->period) {
+                               case  7: scsi = "FAST-320"; break;
+                               case  8: scsi = "FAST-160"; break;
+                               case  9: scsi = "FAST-80"; break;
+                               case 10:
+                               case 11: scsi = "FAST-40"; break;
+                               case 12: scsi = "FAST-20"; break;
+                       }
+               } else {
+                       picosec = tp->period * 4000;
+                       if (tp->period < 25)
+                               scsi = "FAST-20";
+                       else if (tp->period < 50)
+                               scsi = "FAST-10";
+                       else
+                               scsi = "FAST-5";
+               }
+
+               kb100 = (10000000 + picosec / 2) / picosec;
+               if (tp->width)
+                       kb100 *= 2;
+               sprint_frac(tmp, picosec, 1000);
+
+               dev_info(&starget->dev,
+                       "%s %sSCSI %d.%d MB/s %s%s%s (%s ns, offset %d)\n",
+                       scsi, tp->width ? "WIDE " : "", kb100/10, kb100 % 10,
+                       tp->dt ? "DT" : "ST", tp->iu ? " IU" : "",
+                       tp->qas  ? " QAS" : "", tmp, tp->offset);
+       } else {
+               dev_info(&starget->dev, "%sasynchronous.\n",
+                               tp->width ? "wide " : "");
+       }
+}
+EXPORT_SYMBOL(spi_display_xfer_agreement);
+
 #define SETUP_ATTRIBUTE(field)                                         \
        i->private_attrs[count] = class_device_attr_##field;            \
        if (!i->f->set_##field) {                                       \
@@ -805,6 +1013,16 @@ EXPORT_SYMBOL(spi_schedule_dv_device);
        if (i->f->show_##field)                                         \
                count++
 
+#define SETUP_RELATED_ATTRIBUTE(field, rel_field)                      \
+       i->private_attrs[count] = class_device_attr_##field;            \
+       if (!i->f->set_##rel_field) {                                   \
+               i->private_attrs[count].attr.mode = S_IRUGO;            \
+               i->private_attrs[count].store = NULL;                   \
+       }                                                               \
+       i->attrs[count] = &i->private_attrs[count];                     \
+       if (i->f->show_##rel_field)                                     \
+               count++
+
 #define SETUP_HOST_ATTRIBUTE(field)                                    \
        i->private_host_attrs[count] = class_device_attr_##field;       \
        if (!i->f->set_##field) {                                       \
@@ -825,7 +1043,7 @@ static int spi_device_match(struct attribute_container *cont,
 
        sdev = to_scsi_device(dev);
        shost = sdev->host;
-       if (!shost->transportt  || shost->transportt->host_attrs.class
+       if (!shost->transportt  || shost->transportt->host_attrs.ac.class
            != &spi_host_class.class)
                return 0;
        /* Note: this class has no device attributes, so it has
@@ -844,13 +1062,13 @@ static int spi_target_match(struct attribute_container *cont,
                return 0;
 
        shost = dev_to_shost(dev->parent);
-       if (!shost->transportt  || shost->transportt->host_attrs.class
+       if (!shost->transportt  || shost->transportt->host_attrs.ac.class
            != &spi_host_class.class)
                return 0;
 
        i = to_spi_internal(shost->transportt);
        
-       return &i->t.target_attrs == cont;
+       return &i->t.target_attrs.ac == cont;
 }
 
 static DECLARE_TRANSPORT_CLASS(spi_transport_class,
@@ -875,21 +1093,24 @@ spi_attach_transport(struct spi_function_template *ft)
        memset(i, 0, sizeof(struct spi_internal));
 
 
-       i->t.target_attrs.class = &spi_transport_class.class;
-       i->t.target_attrs.attrs = &i->attrs[0];
-       i->t.target_attrs.match = spi_target_match;
-       attribute_container_register(&i->t.target_attrs);
+       i->t.target_attrs.ac.class = &spi_transport_class.class;
+       i->t.target_attrs.ac.attrs = &i->attrs[0];
+       i->t.target_attrs.ac.match = spi_target_match;
+       transport_container_register(&i->t.target_attrs);
        i->t.target_size = sizeof(struct spi_transport_attrs);
-       i->t.host_attrs.class = &spi_host_class.class;
-       i->t.host_attrs.attrs = &i->host_attrs[0];
-       i->t.host_attrs.match = spi_host_match;
-       attribute_container_register(&i->t.host_attrs);
+       i->t.host_attrs.ac.class = &spi_host_class.class;
+       i->t.host_attrs.ac.attrs = &i->host_attrs[0];
+       i->t.host_attrs.ac.match = spi_host_match;
+       transport_container_register(&i->t.host_attrs);
        i->t.host_size = sizeof(struct spi_host_attrs);
        i->f = ft;
 
        SETUP_ATTRIBUTE(period);
+       SETUP_RELATED_ATTRIBUTE(min_period, period);
        SETUP_ATTRIBUTE(offset);
+       SETUP_RELATED_ATTRIBUTE(max_offset, offset);
        SETUP_ATTRIBUTE(width);
+       SETUP_RELATED_ATTRIBUTE(max_width, width);
        SETUP_ATTRIBUTE(iu);
        SETUP_ATTRIBUTE(dt);
        SETUP_ATTRIBUTE(qas);
@@ -921,8 +1142,8 @@ void spi_release_transport(struct scsi_transport_template *t)
 {
        struct spi_internal *i = to_spi_internal(t);
 
-       attribute_container_unregister(&i->t.target_attrs);
-       attribute_container_unregister(&i->t.host_attrs);
+       transport_container_unregister(&i->t.target_attrs);
+       transport_container_unregister(&i->t.host_attrs);
 
        kfree(i);
 }