Fedora kernel-2.6.17-1.2142_FC4 patched with stable patch-2.6.17.4-vs2.0.2-rc26.diff
[linux-2.6.git] / drivers / usb / host / uhci-q.c
index 2a7c195..a06d84c 100644 (file)
  * (C) Copyright 2000 Yggdrasil Computing, Inc. (port of new PCI interface
  *               support from usb-ohci.c by Adam Richter, adam@yggdrasil.com).
  * (C) Copyright 1999 Gregory P. Smith (from usb-ohci.c)
- * (C) Copyright 2004 Alan Stern, stern@rowland.harvard.edu
+ * (C) Copyright 2004-2005 Alan Stern, stern@rowland.harvard.edu
  */
 
-static int uhci_urb_dequeue(struct usb_hcd *hcd, struct urb *urb);
-static void uhci_unlink_generic(struct uhci_hcd *uhci, struct urb *urb);
-static void uhci_remove_pending_urbps(struct uhci_hcd *uhci);
-static void uhci_free_pending_qhs(struct uhci_hcd *uhci);
 static void uhci_free_pending_tds(struct uhci_hcd *uhci);
 
 /*
@@ -30,8 +26,10 @@ static void uhci_free_pending_tds(struct uhci_hcd *uhci);
  * games with the FSBR code to make sure we get the correct order in all
  * the cases. I don't think it's worth the effort
  */
-static inline void uhci_set_next_interrupt(struct uhci_hcd *uhci)
+static void uhci_set_next_interrupt(struct uhci_hcd *uhci)
 {
+       if (uhci->is_stopped)
+               mod_timer(&uhci_to_hcd(uhci)->rh_timer, jiffies);
        uhci->term_td->status |= cpu_to_le32(TD_CTRL_IOC); 
 }
 
@@ -40,13 +38,7 @@ static inline void uhci_clear_next_interrupt(struct uhci_hcd *uhci)
        uhci->term_td->status &= ~cpu_to_le32(TD_CTRL_IOC);
 }
 
-static inline void uhci_moveto_complete(struct uhci_hcd *uhci, 
-                                       struct urb_priv *urbp)
-{
-       list_move_tail(&urbp->urb_list, &uhci->complete_list);
-}
-
-static struct uhci_td *uhci_alloc_td(struct uhci_hcd *uhci, struct usb_device *dev)
+static struct uhci_td *uhci_alloc_td(struct uhci_hcd *uhci)
 {
        dma_addr_t dma_handle;
        struct uhci_td *td;
@@ -56,22 +48,27 @@ static struct uhci_td *uhci_alloc_td(struct uhci_hcd *uhci, struct usb_device *d
                return NULL;
 
        td->dma_handle = dma_handle;
-
-       td->link = UHCI_PTR_TERM;
-       td->buffer = 0;
-
        td->frame = -1;
-       td->dev = dev;
 
        INIT_LIST_HEAD(&td->list);
        INIT_LIST_HEAD(&td->remove_list);
        INIT_LIST_HEAD(&td->fl_list);
 
-       usb_get_dev(dev);
-
        return td;
 }
 
+static void uhci_free_td(struct uhci_hcd *uhci, struct uhci_td *td)
+{
+       if (!list_empty(&td->list))
+               dev_warn(uhci_dev(uhci), "td %p still in list!\n", td);
+       if (!list_empty(&td->remove_list))
+               dev_warn(uhci_dev(uhci), "td %p still in remove_list!\n", td);
+       if (!list_empty(&td->fl_list))
+               dev_warn(uhci_dev(uhci), "td %p still in fl_list!\n", td);
+
+       dma_pool_free(uhci->td_pool, td, td->dma_handle);
+}
+
 static inline void uhci_fill_td(struct uhci_td *td, u32 status,
                u32 token, u32 buffer)
 {
@@ -81,19 +78,20 @@ static inline void uhci_fill_td(struct uhci_td *td, u32 status,
 }
 
 /*
- * We insert Isochronous URB's directly into the frame list at the beginning
+ * We insert Isochronous URBs directly into the frame list at the beginning
  */
-static void uhci_insert_td_frame_list(struct uhci_hcd *uhci, struct uhci_td *td, unsigned framenum)
+static inline void uhci_insert_td_in_frame_list(struct uhci_hcd *uhci,
+               struct uhci_td *td, unsigned framenum)
 {
        framenum &= (UHCI_NUMFRAMES - 1);
 
        td->frame = framenum;
 
        /* Is there a TD already mapped there? */
-       if (uhci->fl->frame_cpu[framenum]) {
+       if (uhci->frame_cpu[framenum]) {
                struct uhci_td *ftd, *ltd;
 
-               ftd = uhci->fl->frame_cpu[framenum];
+               ftd = uhci->frame_cpu[framenum];
                ltd = list_entry(ftd->fl_list.prev, struct uhci_td, fl_list);
 
                list_add_tail(&td->fl_list, &ftd->fl_list);
@@ -102,29 +100,32 @@ static void uhci_insert_td_frame_list(struct uhci_hcd *uhci, struct uhci_td *td,
                wmb();
                ltd->link = cpu_to_le32(td->dma_handle);
        } else {
-               td->link = uhci->fl->frame[framenum];
+               td->link = uhci->frame[framenum];
                wmb();
-               uhci->fl->frame[framenum] = cpu_to_le32(td->dma_handle);
-               uhci->fl->frame_cpu[framenum] = td;
+               uhci->frame[framenum] = cpu_to_le32(td->dma_handle);
+               uhci->frame_cpu[framenum] = td;
        }
 }
 
-static void uhci_remove_td(struct uhci_hcd *uhci, struct uhci_td *td)
+static inline void uhci_remove_td_from_frame_list(struct uhci_hcd *uhci,
+               struct uhci_td *td)
 {
        /* If it's not inserted, don't remove it */
-       if (td->frame == -1 && list_empty(&td->fl_list))
+       if (td->frame == -1) {
+               WARN_ON(!list_empty(&td->fl_list));
                return;
+       }
 
-       if (td->frame != -1 && uhci->fl->frame_cpu[td->frame] == td) {
+       if (uhci->frame_cpu[td->frame] == td) {
                if (list_empty(&td->fl_list)) {
-                       uhci->fl->frame[td->frame] = td->link;
-                       uhci->fl->frame_cpu[td->frame] = NULL;
+                       uhci->frame[td->frame] = td->link;
+                       uhci->frame_cpu[td->frame] = NULL;
                } else {
                        struct uhci_td *ntd;
 
                        ntd = list_entry(td->fl_list.next, struct uhci_td, fl_list);
-                       uhci->fl->frame[td->frame] = cpu_to_le32(ntd->dma_handle);
-                       uhci->fl->frame_cpu[td->frame] = ntd;
+                       uhci->frame[td->frame] = cpu_to_le32(ntd->dma_handle);
+                       uhci->frame_cpu[td->frame] = ntd;
                }
        } else {
                struct uhci_td *ptd;
@@ -133,48 +134,25 @@ static void uhci_remove_td(struct uhci_hcd *uhci, struct uhci_td *td)
                ptd->link = td->link;
        }
 
-       wmb();
-       td->link = UHCI_PTR_TERM;
-
        list_del_init(&td->fl_list);
        td->frame = -1;
 }
 
 /*
- * Inserts a td list into qh.
+ * Remove all the TDs for an Isochronous URB from the frame list
  */
-static void uhci_insert_tds_in_qh(struct uhci_qh *qh, struct urb *urb, __le32 breadth)
+static void uhci_unlink_isochronous_tds(struct uhci_hcd *uhci, struct urb *urb)
 {
-       struct urb_priv *urbp = (struct urb_priv *)urb->hcpriv;
+       struct urb_priv *urbp = (struct urb_priv *) urb->hcpriv;
        struct uhci_td *td;
-       __le32 *plink;
 
-       /* Ordering isn't important here yet since the QH hasn't been */
-       /* inserted into the schedule yet */
-       plink = &qh->element;
-       list_for_each_entry(td, &urbp->td_list, list) {
-               *plink = cpu_to_le32(td->dma_handle) | breadth;
-               plink = &td->link;
-       }
-       *plink = UHCI_PTR_TERM;
-}
-
-static void uhci_free_td(struct uhci_hcd *uhci, struct uhci_td *td)
-{
-       if (!list_empty(&td->list))
-               dev_warn(uhci_dev(uhci), "td %p still in list!\n", td);
-       if (!list_empty(&td->remove_list))
-               dev_warn(uhci_dev(uhci), "td %p still in remove_list!\n", td);
-       if (!list_empty(&td->fl_list))
-               dev_warn(uhci_dev(uhci), "td %p still in fl_list!\n", td);
-
-       if (td->dev)
-               usb_put_dev(td->dev);
-
-       dma_pool_free(uhci->td_pool, td, td->dma_handle);
+       list_for_each_entry(td, &urbp->td_list, list)
+               uhci_remove_td_from_frame_list(uhci, td);
+       wmb();
 }
 
-static struct uhci_qh *uhci_alloc_qh(struct uhci_hcd *uhci, struct usb_device *dev)
+static struct uhci_qh *uhci_alloc_qh(struct uhci_hcd *uhci,
+               struct usb_device *udev, struct usb_host_endpoint *hep)
 {
        dma_addr_t dma_handle;
        struct uhci_qh *qh;
@@ -188,262 +166,217 @@ static struct uhci_qh *uhci_alloc_qh(struct uhci_hcd *uhci, struct usb_device *d
        qh->element = UHCI_PTR_TERM;
        qh->link = UHCI_PTR_TERM;
 
-       qh->dev = dev;
-       qh->urbp = NULL;
-
-       INIT_LIST_HEAD(&qh->list);
-       INIT_LIST_HEAD(&qh->remove_list);
-
-       usb_get_dev(dev);
+       INIT_LIST_HEAD(&qh->queue);
+       INIT_LIST_HEAD(&qh->node);
 
+       if (udev) {             /* Normal QH */
+               qh->dummy_td = uhci_alloc_td(uhci);
+               if (!qh->dummy_td) {
+                       dma_pool_free(uhci->qh_pool, qh, dma_handle);
+                       return NULL;
+               }
+               qh->state = QH_STATE_IDLE;
+               qh->hep = hep;
+               qh->udev = udev;
+               hep->hcpriv = qh;
+
+       } else {                /* Skeleton QH */
+               qh->state = QH_STATE_ACTIVE;
+               qh->udev = NULL;
+       }
        return qh;
 }
 
 static void uhci_free_qh(struct uhci_hcd *uhci, struct uhci_qh *qh)
 {
-       if (!list_empty(&qh->list))
+       WARN_ON(qh->state != QH_STATE_IDLE && qh->udev);
+       if (!list_empty(&qh->queue))
                dev_warn(uhci_dev(uhci), "qh %p list not empty!\n", qh);
-       if (!list_empty(&qh->remove_list))
-               dev_warn(uhci_dev(uhci), "qh %p still in remove_list!\n", qh);
-
-       if (qh->dev)
-               usb_put_dev(qh->dev);
 
+       list_del(&qh->node);
+       if (qh->udev) {
+               qh->hep->hcpriv = NULL;
+               uhci_free_td(uhci, qh->dummy_td);
+       }
        dma_pool_free(uhci->qh_pool, qh, qh->dma_handle);
 }
 
 /*
- * Append this urb's qh after the last qh in skelqh->list
- *
- * Note that urb_priv.queue_list doesn't have a separate queue head;
- * it's a ring with every element "live".
+ * When the currently executing URB is dequeued, save its current toggle value
  */
-static void uhci_insert_qh(struct uhci_hcd *uhci, struct uhci_qh *skelqh, struct urb *urb)
+static void uhci_save_toggle(struct uhci_qh *qh, struct urb *urb)
 {
-       struct urb_priv *urbp = (struct urb_priv *)urb->hcpriv;
-       struct urb_priv *turbp;
-       struct uhci_qh *lqh;
+       struct urb_priv *urbp = (struct urb_priv *) urb->hcpriv;
+       struct uhci_td *td;
 
-       /* Grab the last QH */
-       lqh = list_entry(skelqh->list.prev, struct uhci_qh, list);
+       /* If the QH element pointer is UHCI_PTR_TERM then then currently
+        * executing URB has already been unlinked, so this one isn't it. */
+       if (qh_element(qh) == UHCI_PTR_TERM ||
+                               qh->queue.next != &urbp->node)
+               return;
+       qh->element = UHCI_PTR_TERM;
 
-       /* Point to the next skelqh */
-       urbp->qh->link = lqh->link;
-       wmb();                          /* Ordering is important */
+       /* Only bulk and interrupt pipes have to worry about toggles */
+       if (!(usb_pipetype(urb->pipe) == PIPE_BULK ||
+                       usb_pipetype(urb->pipe) == PIPE_INTERRUPT))
+               return;
 
-       /*
-        * Patch QHs for previous endpoint's queued URBs?  HC goes
-        * here next, not to the next skelqh it now points to.
-        *
-        *    lqh --> td ... --> qh ... --> td --> qh ... --> td
-        *     |                 |                 |
-        *     v                 v                 v
-        *     +<----------------+-----------------+
-        *     v
-        *    newqh --> td ... --> td
-        *     |
-        *     v
-        *    ...
-        *
-        * The HC could see (and use!) any of these as we write them.
-        */
-       lqh->link = cpu_to_le32(urbp->qh->dma_handle) | UHCI_PTR_QH;
-       if (lqh->urbp) {
-               list_for_each_entry(turbp, &lqh->urbp->queue_list, queue_list)
-                       turbp->qh->link = lqh->link;
+       /* Find the first active TD; that's the device's toggle state */
+       list_for_each_entry(td, &urbp->td_list, list) {
+               if (td_status(td) & TD_CTRL_ACTIVE) {
+                       qh->needs_fixup = 1;
+                       qh->initial_toggle = uhci_toggle(td_token(td));
+                       return;
+               }
        }
 
-       list_add_tail(&urbp->qh->list, &skelqh->list);
+       WARN_ON(1);
 }
 
 /*
- * Start removal of QH from schedule; it finishes next frame.
- * TDs should be unlinked before this is called.
+ * Fix up the data toggles for URBs in a queue, when one of them
+ * terminates early (short transfer, error, or dequeued).
  */
-static void uhci_remove_qh(struct uhci_hcd *uhci, struct uhci_qh *qh)
+static void uhci_fixup_toggles(struct uhci_qh *qh, int skip_first)
 {
-       struct uhci_qh *pqh;
-       __le32 newlink;
-
-       if (!qh)
-               return;
-
-       /*
-        * Only go through the hoops if it's actually linked in
-        */
-       if (!list_empty(&qh->list)) {
-
-               /* If our queue is nonempty, make the next URB the head */
-               if (!list_empty(&qh->urbp->queue_list)) {
-                       struct urb_priv *nurbp;
-
-                       nurbp = list_entry(qh->urbp->queue_list.next,
-                                       struct urb_priv, queue_list);
-                       nurbp->queued = 0;
-                       list_add(&nurbp->qh->list, &qh->list);
-                       newlink = cpu_to_le32(nurbp->qh->dma_handle) | UHCI_PTR_QH;
-               } else
-                       newlink = qh->link;
-
-               /* Fix up the previous QH's queue to link to either
-                * the new head of this queue or the start of the
-                * next endpoint's queue. */
-               pqh = list_entry(qh->list.prev, struct uhci_qh, list);
-               pqh->link = newlink;
-               if (pqh->urbp) {
-                       struct urb_priv *turbp;
-
-                       list_for_each_entry(turbp, &pqh->urbp->queue_list,
-                                       queue_list)
-                               turbp->qh->link = newlink;
+       struct urb_priv *urbp = NULL;
+       struct uhci_td *td;
+       unsigned int toggle = qh->initial_toggle;
+       unsigned int pipe;
+
+       /* Fixups for a short transfer start with the second URB in the
+        * queue (the short URB is the first). */
+       if (skip_first)
+               urbp = list_entry(qh->queue.next, struct urb_priv, node);
+
+       /* When starting with the first URB, if the QH element pointer is
+        * still valid then we know the URB's toggles are okay. */
+       else if (qh_element(qh) != UHCI_PTR_TERM)
+               toggle = 2;
+
+       /* Fix up the toggle for the URBs in the queue.  Normally this
+        * loop won't run more than once: When an error or short transfer
+        * occurs, the queue usually gets emptied. */
+       urbp = list_prepare_entry(urbp, &qh->queue, node);
+       list_for_each_entry_continue(urbp, &qh->queue, node) {
+
+               /* If the first TD has the right toggle value, we don't
+                * need to change any toggles in this URB */
+               td = list_entry(urbp->td_list.next, struct uhci_td, list);
+               if (toggle > 1 || uhci_toggle(td_token(td)) == toggle) {
+                       td = list_entry(urbp->td_list.next, struct uhci_td,
+                                       list);
+                       toggle = uhci_toggle(td_token(td)) ^ 1;
+
+               /* Otherwise all the toggles in the URB have to be switched */
+               } else {
+                       list_for_each_entry(td, &urbp->td_list, list) {
+                               td->token ^= __constant_cpu_to_le32(
+                                                       TD_TOKEN_TOGGLE);
+                               toggle ^= 1;
+                       }
                }
-               wmb();
-
-               /* Leave qh->link in case the HC is on the QH now, it will */
-               /* continue the rest of the schedule */
-               qh->element = UHCI_PTR_TERM;
-
-               list_del_init(&qh->list);
-       }
-
-       list_del_init(&qh->urbp->queue_list);
-       qh->urbp = NULL;
-
-       uhci_get_current_frame_number(uhci);
-       if (uhci->frame_number + uhci->is_stopped != uhci->qh_remove_age) {
-               uhci_free_pending_qhs(uhci);
-               uhci->qh_remove_age = uhci->frame_number;
        }
 
-       /* Check to see if the remove list is empty. Set the IOC bit */
-       /* to force an interrupt so we can remove the QH */
-       if (list_empty(&uhci->qh_remove_list))
-               uhci_set_next_interrupt(uhci);
-
-       list_add(&qh->remove_list, &uhci->qh_remove_list);
+       wmb();
+       pipe = list_entry(qh->queue.next, struct urb_priv, node)->urb->pipe;
+       usb_settoggle(qh->udev, usb_pipeendpoint(pipe),
+                       usb_pipeout(pipe), toggle);
+       qh->needs_fixup = 0;
 }
 
-static int uhci_fixup_toggle(struct urb *urb, unsigned int toggle)
+/*
+ * Put a QH on the schedule in both hardware and software
+ */
+static void uhci_activate_qh(struct uhci_hcd *uhci, struct uhci_qh *qh)
 {
-       struct urb_priv *urbp = (struct urb_priv *)urb->hcpriv;
-       struct uhci_td *td;
-
-       list_for_each_entry(td, &urbp->td_list, list) {
-               if (toggle)
-                       td->token |= cpu_to_le32(TD_TOKEN_TOGGLE);
-               else
-                       td->token &= ~cpu_to_le32(TD_TOKEN_TOGGLE);
-
-               toggle ^= 1;
-       }
-
-       return toggle;
-}
+       struct uhci_qh *pqh;
 
-/* This function will append one URB's QH to another URB's QH. This is for */
-/* queuing interrupt, control or bulk transfers */
-static void uhci_append_queued_urb(struct uhci_hcd *uhci, struct urb *eurb, struct urb *urb)
-{
-       struct urb_priv *eurbp, *urbp, *furbp, *lurbp;
-       struct uhci_td *lltd;
+       WARN_ON(list_empty(&qh->queue));
 
-       eurbp = eurb->hcpriv;
-       urbp = urb->hcpriv;
+       /* Set the element pointer if it isn't set already.
+        * This isn't needed for Isochronous queues, but it doesn't hurt. */
+       if (qh_element(qh) == UHCI_PTR_TERM) {
+               struct urb_priv *urbp = list_entry(qh->queue.next,
+                               struct urb_priv, node);
+               struct uhci_td *td = list_entry(urbp->td_list.next,
+                               struct uhci_td, list);
 
-       /* Find the first URB in the queue */
-       furbp = eurbp;
-       if (eurbp->queued) {
-               list_for_each_entry(furbp, &eurbp->queue_list, queue_list)
-                       if (!furbp->queued)
-                               break;
+               qh->element = cpu_to_le32(td->dma_handle);
        }
 
-       lurbp = list_entry(furbp->queue_list.prev, struct urb_priv, queue_list);
-
-       lltd = list_entry(lurbp->td_list.prev, struct uhci_td, list);
-
-       /* Control transfers always start with toggle 0 */
-       if (!usb_pipecontrol(urb->pipe))
-               usb_settoggle(urb->dev, usb_pipeendpoint(urb->pipe),
-                               usb_pipeout(urb->pipe),
-                               uhci_fixup_toggle(urb,
-                                       uhci_toggle(td_token(lltd)) ^ 1));
-
-       /* All qh's in the queue need to link to the next queue */
-       urbp->qh->link = eurbp->qh->link;
-
-       wmb();                  /* Make sure we flush everything */
-
-       lltd->link = cpu_to_le32(urbp->qh->dma_handle) | UHCI_PTR_QH;
-
-       list_add_tail(&urbp->queue_list, &furbp->queue_list);
-
-       urbp->queued = 1;
+       if (qh->state == QH_STATE_ACTIVE)
+               return;
+       qh->state = QH_STATE_ACTIVE;
+
+       /* Move the QH from its old list to the end of the appropriate
+        * skeleton's list */
+       if (qh == uhci->next_qh)
+               uhci->next_qh = list_entry(qh->node.next, struct uhci_qh,
+                               node);
+       list_move_tail(&qh->node, &qh->skel->node);
+
+       /* Link it into the schedule */
+       pqh = list_entry(qh->node.prev, struct uhci_qh, node);
+       qh->link = pqh->link;
+       wmb();
+       pqh->link = UHCI_PTR_QH | cpu_to_le32(qh->dma_handle);
 }
 
-static void uhci_delete_queued_urb(struct uhci_hcd *uhci, struct urb *urb)
+/*
+ * Take a QH off the hardware schedule
+ */
+static void uhci_unlink_qh(struct uhci_hcd *uhci, struct uhci_qh *qh)
 {
-       struct urb_priv *urbp, *nurbp, *purbp, *turbp;
-       struct uhci_td *pltd;
-       unsigned int toggle;
-
-       urbp = urb->hcpriv;
+       struct uhci_qh *pqh;
 
-       if (list_empty(&urbp->queue_list))
+       if (qh->state == QH_STATE_UNLINKING)
                return;
+       WARN_ON(qh->state != QH_STATE_ACTIVE || !qh->udev);
+       qh->state = QH_STATE_UNLINKING;
 
-       nurbp = list_entry(urbp->queue_list.next, struct urb_priv, queue_list);
+       /* Unlink the QH from the schedule and record when we did it */
+       pqh = list_entry(qh->node.prev, struct uhci_qh, node);
+       pqh->link = qh->link;
+       mb();
 
-       /*
-        * Fix up the toggle for the following URBs in the queue.
-        * Only needed for bulk and interrupt: control and isochronous
-        * endpoints don't propagate toggles between messages.
-        */
-       if (usb_pipebulk(urb->pipe) || usb_pipeint(urb->pipe)) {
-               if (!urbp->queued)
-                       /* We just set the toggle in uhci_unlink_generic */
-                       toggle = usb_gettoggle(urb->dev,
-                                       usb_pipeendpoint(urb->pipe),
-                                       usb_pipeout(urb->pipe));
-               else {
-                       /* If we're in the middle of the queue, grab the */
-                       /* toggle from the TD previous to us */
-                       purbp = list_entry(urbp->queue_list.prev,
-                                       struct urb_priv, queue_list);
-                       pltd = list_entry(purbp->td_list.prev,
-                                       struct uhci_td, list);
-                       toggle = uhci_toggle(td_token(pltd)) ^ 1;
-               }
+       uhci_get_current_frame_number(uhci);
+       qh->unlink_frame = uhci->frame_number;
 
-               list_for_each_entry(turbp, &urbp->queue_list, queue_list) {
-                       if (!turbp->queued)
-                               break;
-                       toggle = uhci_fixup_toggle(turbp->urb, toggle);
-               }
+       /* Force an interrupt so we know when the QH is fully unlinked */
+       if (list_empty(&uhci->skel_unlink_qh->node))
+               uhci_set_next_interrupt(uhci);
 
-               usb_settoggle(urb->dev, usb_pipeendpoint(urb->pipe),
-                               usb_pipeout(urb->pipe), toggle);
-       }
+       /* Move the QH from its old list to the end of the unlinking list */
+       if (qh == uhci->next_qh)
+               uhci->next_qh = list_entry(qh->node.next, struct uhci_qh,
+                               node);
+       list_move_tail(&qh->node, &uhci->skel_unlink_qh->node);
+}
 
-       if (urbp->queued) {
-               /* We're somewhere in the middle (or end).  The case where
-                * we're at the head is handled in uhci_remove_qh(). */
-               purbp = list_entry(urbp->queue_list.prev, struct urb_priv,
-                               queue_list);
+/*
+ * When we and the controller are through with a QH, it becomes IDLE.
+ * This happens when a QH has been off the schedule (on the unlinking
+ * list) for more than one frame, or when an error occurs while adding
+ * the first URB onto a new QH.
+ */
+static void uhci_make_qh_idle(struct uhci_hcd *uhci, struct uhci_qh *qh)
+{
+       WARN_ON(qh->state == QH_STATE_ACTIVE);
 
-               pltd = list_entry(purbp->td_list.prev, struct uhci_td, list);
-               if (nurbp->queued)
-                       pltd->link = cpu_to_le32(nurbp->qh->dma_handle) | UHCI_PTR_QH;
-               else
-                       /* The next URB happens to be the beginning, so */
-                       /*  we're the last, end the chain */
-                       pltd->link = UHCI_PTR_TERM;
-       }
+       if (qh == uhci->next_qh)
+               uhci->next_qh = list_entry(qh->node.next, struct uhci_qh,
+                               node);
+       list_move(&qh->node, &uhci->idle_qh_list);
+       qh->state = QH_STATE_IDLE;
 
-       /* urbp->queue_list is handled in uhci_remove_qh() */
+       /* If anyone is waiting for a QH to become idle, wake them up */
+       if (uhci->num_waiting)
+               wake_up_all(&uhci->waitqh);
 }
 
-static struct urb_priv *uhci_alloc_urb_priv(struct uhci_hcd *uhci, struct urb *urb)
+static inline struct urb_priv *uhci_alloc_urb_priv(struct uhci_hcd *uhci,
+               struct urb *urb)
 {
        struct urb_priv *urbp;
 
@@ -453,17 +386,11 @@ static struct urb_priv *uhci_alloc_urb_priv(struct uhci_hcd *uhci, struct urb *u
 
        memset((void *)urbp, 0, sizeof(*urbp));
 
-       urbp->inserttime = jiffies;
-       urbp->fsbrtime = jiffies;
        urbp->urb = urb;
+       urb->hcpriv = urbp;
        
+       INIT_LIST_HEAD(&urbp->node);
        INIT_LIST_HEAD(&urbp->td_list);
-       INIT_LIST_HEAD(&urbp->queue_list);
-       INIT_LIST_HEAD(&urbp->urb_list);
-
-       list_add_tail(&urbp->urb_list, &uhci->urb_list);
-
-       urb->hcpriv = urbp;
 
        return urbp;
 }
@@ -472,8 +399,6 @@ static void uhci_add_td_to_urb(struct urb *urb, struct uhci_td *td)
 {
        struct urb_priv *urbp = (struct urb_priv *)urb->hcpriv;
 
-       td->urb = urb;
-
        list_add_tail(&td->list, &urbp->td_list);
 }
 
@@ -483,22 +408,16 @@ static void uhci_remove_td_from_urb(struct uhci_td *td)
                return;
 
        list_del_init(&td->list);
-
-       td->urb = NULL;
 }
 
-static void uhci_destroy_urb_priv(struct uhci_hcd *uhci, struct urb *urb)
+static void uhci_free_urb_priv(struct uhci_hcd *uhci,
+               struct urb_priv *urbp)
 {
        struct uhci_td *td, *tmp;
-       struct urb_priv *urbp;
-
-       urbp = (struct urb_priv *)urb->hcpriv;
-       if (!urbp)
-               return;
 
-       if (!list_empty(&urbp->urb_list))
-               dev_warn(uhci_dev(uhci), "urb %p still on uhci->urb_list "
-                               "or uhci->remove_list!\n", urb);
+       if (!list_empty(&urbp->node))
+               dev_warn(uhci_dev(uhci), "urb %p still on QH's list!\n",
+                               urbp->urb);
 
        uhci_get_current_frame_number(uhci);
        if (uhci->frame_number + uhci->is_stopped != uhci->td_remove_age) {
@@ -507,17 +426,16 @@ static void uhci_destroy_urb_priv(struct uhci_hcd *uhci, struct urb *urb)
        }
 
        /* Check to see if the remove list is empty. Set the IOC bit */
-       /* to force an interrupt so we can remove the TD's*/
+       /* to force an interrupt so we can remove the TDs. */
        if (list_empty(&uhci->td_remove_list))
                uhci_set_next_interrupt(uhci);
 
        list_for_each_entry_safe(td, tmp, &urbp->td_list, list) {
                uhci_remove_td_from_urb(td);
-               uhci_remove_td(uhci, td);
                list_add(&td->remove_list, &uhci->td_remove_list);
        }
 
-       urb->hcpriv = NULL;
+       urbp->urb->hcpriv = NULL;
        kmem_cache_free(uhci_up_cachep, urbp);
 }
 
@@ -576,34 +494,33 @@ static int uhci_map_status(int status, int dir_out)
 /*
  * Control transfers
  */
-static int uhci_submit_control(struct uhci_hcd *uhci, struct urb *urb, struct urb *eurb)
+static int uhci_submit_control(struct uhci_hcd *uhci, struct urb *urb,
+               struct uhci_qh *qh)
 {
-       struct urb_priv *urbp = (struct urb_priv *)urb->hcpriv;
        struct uhci_td *td;
-       struct uhci_qh *qh, *skelqh;
        unsigned long destination, status;
-       int maxsze = usb_maxpacket(urb->dev, urb->pipe, usb_pipeout(urb->pipe));
+       int maxsze = le16_to_cpu(qh->hep->desc.wMaxPacketSize);
        int len = urb->transfer_buffer_length;
        dma_addr_t data = urb->transfer_dma;
+       __le32 *plink;
 
        /* The "pipe" thing contains the destination in bits 8--18 */
        destination = (urb->pipe & PIPE_DEVEP_MASK) | USB_PID_SETUP;
 
-       /* 3 errors */
-       status = TD_CTRL_ACTIVE | uhci_maxerr(3);
+       /* 3 errors, dummy TD remains inactive */
+       status = uhci_maxerr(3);
        if (urb->dev->speed == USB_SPEED_LOW)
                status |= TD_CTRL_LS;
 
        /*
         * Build the TD for the control request setup packet
         */
-       td = uhci_alloc_td(uhci, urb->dev);
-       if (!td)
-               return -ENOMEM;
-
+       td = qh->dummy_td;
        uhci_add_td_to_urb(urb, td);
-       uhci_fill_td(td, status, destination | uhci_explen(7),
-               urb->setup_dma);
+       uhci_fill_td(td, status, destination | uhci_explen(8),
+                       urb->setup_dma);
+       plink = &td->link;
+       status |= TD_CTRL_ACTIVE;
 
        /*
         * If direction is "send", change the packet ID from SETUP (0x2D)
@@ -618,24 +535,23 @@ static int uhci_submit_control(struct uhci_hcd *uhci, struct urb *urb, struct ur
        }
 
        /*
-        * Build the DATA TD's
+        * Build the DATA TDs
         */
        while (len > 0) {
-               int pktsze = len;
-
-               if (pktsze > maxsze)
-                       pktsze = maxsze;
+               int pktsze = min(len, maxsze);
 
-               td = uhci_alloc_td(uhci, urb->dev);
+               td = uhci_alloc_td(uhci);
                if (!td)
-                       return -ENOMEM;
+                       goto nomem;
+               *plink = cpu_to_le32(td->dma_handle);
 
                /* Alternate Data0/1 (start with Data1) */
                destination ^= TD_TOKEN_TOGGLE;
        
                uhci_add_td_to_urb(urb, td);
-               uhci_fill_td(td, status, destination | uhci_explen(pktsze - 1),
-                       data);
+               uhci_fill_td(td, status, destination | uhci_explen(pktsze),
+                               data);
+               plink = &td->link;
 
                data += pktsze;
                len -= pktsze;
@@ -644,9 +560,10 @@ static int uhci_submit_control(struct uhci_hcd *uhci, struct urb *urb, struct ur
        /*
         * Build the final TD for control status 
         */
-       td = uhci_alloc_td(uhci, urb->dev);
+       td = uhci_alloc_td(uhci);
        if (!td)
-               return -ENOMEM;
+               goto nomem;
+       *plink = cpu_to_le32(td->dma_handle);
 
        /*
         * It's IN if the pipe is an output pipe or we're not expecting
@@ -664,35 +581,39 @@ static int uhci_submit_control(struct uhci_hcd *uhci, struct urb *urb, struct ur
 
        uhci_add_td_to_urb(urb, td);
        uhci_fill_td(td, status | TD_CTRL_IOC,
-               destination | uhci_explen(UHCI_NULL_DATA_SIZE), 0);
-
-       qh = uhci_alloc_qh(uhci, urb->dev);
-       if (!qh)
-               return -ENOMEM;
+                       destination | uhci_explen(0), 0);
+       plink = &td->link;
 
-       urbp->qh = qh;
-       qh->urbp = urbp;
+       /*
+        * Build the new dummy TD and activate the old one
+        */
+       td = uhci_alloc_td(uhci);
+       if (!td)
+               goto nomem;
+       *plink = cpu_to_le32(td->dma_handle);
 
-       uhci_insert_tds_in_qh(qh, urb, UHCI_PTR_BREADTH);
+       uhci_fill_td(td, 0, USB_PID_OUT | uhci_explen(0), 0);
+       wmb();
+       qh->dummy_td->status |= __constant_cpu_to_le32(TD_CTRL_ACTIVE);
+       qh->dummy_td = td;
 
        /* Low-speed transfers get a different queue, and won't hog the bus.
         * Also, some devices enumerate better without FSBR; the easiest way
         * to do that is to put URBs on the low-speed queue while the device
-        * is in the DEFAULT state. */
+        * isn't in the CONFIGURED state. */
        if (urb->dev->speed == USB_SPEED_LOW ||
-                       urb->dev->state == USB_STATE_DEFAULT)
-               skelqh = uhci->skel_ls_control_qh;
+                       urb->dev->state != USB_STATE_CONFIGURED)
+               qh->skel = uhci->skel_ls_control_qh;
        else {
-               skelqh = uhci->skel_fs_control_qh;
+               qh->skel = uhci->skel_fs_control_qh;
                uhci_inc_fsbr(uhci, urb);
        }
+       return 0;
 
-       if (eurb)
-               uhci_append_queued_urb(uhci, eurb, urb);
-       else
-               uhci_insert_qh(uhci, skelqh, urb);
-
-       return -EINPROGRESS;
+nomem:
+       /* Remove the dummy TD from the td_list so it doesn't get freed */
+       uhci_remove_td_from_urb(qh->dummy_td);
+       return -ENOMEM;
 }
 
 /*
@@ -709,7 +630,7 @@ static int usb_control_retrigger_status(struct uhci_hcd *uhci, struct urb *urb)
        struct urb_priv *urbp = (struct urb_priv *)urb->hcpriv;
        struct uhci_td *td;
 
-       urbp->short_control_packet = 1;
+       urbp->short_transfer = 1;
 
        td = list_entry(urbp->td_list.prev, struct uhci_td, list);
        urbp->qh->element = cpu_to_le32(td->dma_handle);
@@ -726,16 +647,14 @@ static int uhci_result_control(struct uhci_hcd *uhci, struct urb *urb)
        unsigned int status;
        int ret = 0;
 
-       if (list_empty(&urbp->td_list))
-               return -EINVAL;
-
        head = &urbp->td_list;
-
-       if (urbp->short_control_packet) {
+       if (urbp->short_transfer) {
                tmp = head->prev;
                goto status_stage;
        }
 
+       urb->actual_length = 0;
+
        tmp = head->next;
        td = list_entry(tmp, struct uhci_td, list);
 
@@ -748,9 +667,7 @@ static int uhci_result_control(struct uhci_hcd *uhci, struct urb *urb)
        if (status)
                goto td_error;
 
-       urb->actual_length = 0;
-
-       /* The rest of the TD's (but the last) are data */
+       /* The rest of the TDs (but the last) are data */
        tmp = tmp->next;
        while (tmp != head && tmp->next != head) {
                unsigned int ctrlstat;
@@ -776,10 +693,7 @@ static int uhci_result_control(struct uhci_hcd *uhci, struct urb *urb)
                                goto err;
                        }
 
-                       if (uhci_packetid(td_token(td)) == USB_PID_IN)
-                               return usb_control_retrigger_status(uhci, urb);
-                       else
-                               return 0;
+                       return usb_control_retrigger_status(uhci, urb);
                }
        }
 
@@ -820,66 +734,76 @@ err:
                if (errbuf) {
                        /* Print the chain for debugging purposes */
                        uhci_show_qh(urbp->qh, errbuf, ERRBUF_LEN, 0);
-
                        lprintk(errbuf);
                }
        }
 
+       /* Note that the queue has stopped */
+       urbp->qh->element = UHCI_PTR_TERM;
+       urbp->qh->is_stopped = 1;
        return ret;
 }
 
 /*
  * Common submit for bulk and interrupt
  */
-static int uhci_submit_common(struct uhci_hcd *uhci, struct urb *urb, struct urb *eurb, struct uhci_qh *skelqh)
+static int uhci_submit_common(struct uhci_hcd *uhci, struct urb *urb,
+               struct uhci_qh *qh)
 {
        struct uhci_td *td;
-       struct uhci_qh *qh;
        unsigned long destination, status;
-       int maxsze = usb_maxpacket(urb->dev, urb->pipe, usb_pipeout(urb->pipe));
+       int maxsze = le16_to_cpu(qh->hep->desc.wMaxPacketSize);
        int len = urb->transfer_buffer_length;
-       struct urb_priv *urbp = (struct urb_priv *)urb->hcpriv;
        dma_addr_t data = urb->transfer_dma;
+       __le32 *plink;
+       unsigned int toggle;
 
        if (len < 0)
                return -EINVAL;
 
        /* The "pipe" thing contains the destination in bits 8--18 */
        destination = (urb->pipe & PIPE_DEVEP_MASK) | usb_packetid(urb->pipe);
+       toggle = usb_gettoggle(urb->dev, usb_pipeendpoint(urb->pipe),
+                        usb_pipeout(urb->pipe));
 
-       status = uhci_maxerr(3) | TD_CTRL_ACTIVE;
+       /* 3 errors, dummy TD remains inactive */
+       status = uhci_maxerr(3);
        if (urb->dev->speed == USB_SPEED_LOW)
                status |= TD_CTRL_LS;
        if (usb_pipein(urb->pipe))
                status |= TD_CTRL_SPD;
 
        /*
-        * Build the DATA TD's
+        * Build the DATA TDs
         */
+       plink = NULL;
+       td = qh->dummy_td;
        do {    /* Allow zero length packets */
                int pktsze = maxsze;
 
-               if (pktsze >= len) {
+               if (len <= pktsze) {            /* The last packet */
                        pktsze = len;
                        if (!(urb->transfer_flags & URB_SHORT_NOT_OK))
                                status &= ~TD_CTRL_SPD;
                }
 
-               td = uhci_alloc_td(uhci, urb->dev);
-               if (!td)
-                       return -ENOMEM;
-
+               if (plink) {
+                       td = uhci_alloc_td(uhci);
+                       if (!td)
+                               goto nomem;
+                       *plink = cpu_to_le32(td->dma_handle);
+               }
                uhci_add_td_to_urb(urb, td);
-               uhci_fill_td(td, status, destination | uhci_explen(pktsze - 1) |
-                       (usb_gettoggle(urb->dev, usb_pipeendpoint(urb->pipe),
-                        usb_pipeout(urb->pipe)) << TD_TOKEN_TOGGLE_SHIFT),
-                       data);
+               uhci_fill_td(td, status,
+                               destination | uhci_explen(pktsze) |
+                                       (toggle << TD_TOKEN_TOGGLE_SHIFT),
+                               data);
+               plink = &td->link;
+               status |= TD_CTRL_ACTIVE;
 
                data += pktsze;
                len -= maxsze;
-
-               usb_dotoggle(urb->dev, usb_pipeendpoint(urb->pipe),
-                       usb_pipeout(urb->pipe));
+               toggle ^= 1;
        } while (len > 0);
 
        /*
@@ -889,20 +813,22 @@ static int uhci_submit_common(struct uhci_hcd *uhci, struct urb *urb, struct urb
         * however, if transfer_length == 0, the zero packet was already
         * prepared above.
         */
-       if (usb_pipeout(urb->pipe) && (urb->transfer_flags & URB_ZERO_PACKET) &&
-           !len && urb->transfer_buffer_length) {
-               td = uhci_alloc_td(uhci, urb->dev);
+       if ((urb->transfer_flags & URB_ZERO_PACKET) &&
+                       usb_pipeout(urb->pipe) && len == 0 &&
+                       urb->transfer_buffer_length > 0) {
+               td = uhci_alloc_td(uhci);
                if (!td)
-                       return -ENOMEM;
+                       goto nomem;
+               *plink = cpu_to_le32(td->dma_handle);
 
                uhci_add_td_to_urb(urb, td);
-               uhci_fill_td(td, status, destination | uhci_explen(UHCI_NULL_DATA_SIZE) |
-                       (usb_gettoggle(urb->dev, usb_pipeendpoint(urb->pipe),
-                        usb_pipeout(urb->pipe)) << TD_TOKEN_TOGGLE_SHIFT),
-                       data);
+               uhci_fill_td(td, status,
+                               destination | uhci_explen(0) |
+                                       (toggle << TD_TOKEN_TOGGLE_SHIFT),
+                               data);
+               plink = &td->link;
 
-               usb_dotoggle(urb->dev, usb_pipeendpoint(urb->pipe),
-                       usb_pipeout(urb->pipe));
+               toggle ^= 1;
        }
 
        /* Set the interrupt-on-completion flag on the last packet.
@@ -911,24 +837,29 @@ static int uhci_submit_common(struct uhci_hcd *uhci, struct urb *urb, struct urb
         * fast side but not enough to justify delaying an interrupt
         * more than 2 or 3 URBs, so we will ignore the URB_NO_INTERRUPT
         * flag setting. */
-       td->status |= cpu_to_le32(TD_CTRL_IOC);
-
-       qh = uhci_alloc_qh(uhci, urb->dev);
-       if (!qh)
-               return -ENOMEM;
+       td->status |= __constant_cpu_to_le32(TD_CTRL_IOC);
 
-       urbp->qh = qh;
-       qh->urbp = urbp;
+       /*
+        * Build the new dummy TD and activate the old one
+        */
+       td = uhci_alloc_td(uhci);
+       if (!td)
+               goto nomem;
+       *plink = cpu_to_le32(td->dma_handle);
 
-       /* Always breadth first */
-       uhci_insert_tds_in_qh(qh, urb, UHCI_PTR_BREADTH);
+       uhci_fill_td(td, 0, USB_PID_OUT | uhci_explen(0), 0);
+       wmb();
+       qh->dummy_td->status |= __constant_cpu_to_le32(TD_CTRL_ACTIVE);
+       qh->dummy_td = td;
 
-       if (eurb)
-               uhci_append_queued_urb(uhci, eurb, urb);
-       else
-               uhci_insert_qh(uhci, skelqh, urb);
+       usb_settoggle(urb->dev, usb_pipeendpoint(urb->pipe),
+                       usb_pipeout(urb->pipe), toggle);
+       return 0;
 
-       return -EINPROGRESS;
+nomem:
+       /* Remove the dummy TD from the td_list so it doesn't get freed */
+       uhci_remove_td_from_urb(qh->dummy_td);
+       return -ENOMEM;
 }
 
 /*
@@ -960,8 +891,27 @@ static int uhci_result_common(struct uhci_hcd *uhci, struct urb *urb)
                        if (urb->transfer_flags & URB_SHORT_NOT_OK) {
                                ret = -EREMOTEIO;
                                goto err;
-                       } else
-                               return 0;
+                       }
+
+                       /*
+                        * This URB stopped short of its end.  We have to
+                        * fix up the toggles of the following URBs on the
+                        * queue and restart the queue.
+                        *
+                        * Do this only the first time we encounter the
+                        * short URB.
+                        */
+                       if (!urbp->short_transfer) {
+                               urbp->short_transfer = 1;
+                               urbp->qh->initial_toggle =
+                                               uhci_toggle(td_token(td)) ^ 1;
+                               uhci_fixup_toggles(urbp->qh, 1);
+
+                               td = list_entry(urbp->td_list.prev,
+                                               struct uhci_td, list);
+                               urbp->qh->element = td->link;
+                       }
+                       break;
                }
        }
 
@@ -970,31 +920,30 @@ static int uhci_result_common(struct uhci_hcd *uhci, struct urb *urb)
 td_error:
        ret = uhci_map_status(status, uhci_packetout(td_token(td)));
 
-err:
-       /* 
-        * Enable this chunk of code if you want to see some more debugging.
-        * But be careful, it has the tendancy to starve out khubd and prevent
-        * disconnects from happening successfully if you have a slow debug
-        * log interface (like a serial console.
-        */
-#if 0
        if ((debug == 1 && ret != -EPIPE) || debug > 1) {
                /* Some debugging code */
                dev_dbg(uhci_dev(uhci), "%s: failed with status %x\n",
                                __FUNCTION__, status);
 
-               if (errbuf) {
+               if (debug > 1 && errbuf) {
                        /* Print the chain for debugging purposes */
                        uhci_show_qh(urbp->qh, errbuf, ERRBUF_LEN, 0);
-
                        lprintk(errbuf);
                }
        }
-#endif
+err:
+
+       /* Note that the queue has stopped and save the next toggle value */
+       urbp->qh->element = UHCI_PTR_TERM;
+       urbp->qh->is_stopped = 1;
+       urbp->qh->needs_fixup = 1;
+       urbp->qh->initial_toggle = uhci_toggle(td_token(td)) ^
+                       (ret == -EREMOTEIO);
        return ret;
 }
 
-static inline int uhci_submit_bulk(struct uhci_hcd *uhci, struct urb *urb, struct urb *eurb)
+static inline int uhci_submit_bulk(struct uhci_hcd *uhci, struct urb *urb,
+               struct uhci_qh *qh)
 {
        int ret;
 
@@ -1002,115 +951,86 @@ static inline int uhci_submit_bulk(struct uhci_hcd *uhci, struct urb *urb, struc
        if (urb->dev->speed == USB_SPEED_LOW)
                return -EINVAL;
 
-       ret = uhci_submit_common(uhci, urb, eurb, uhci->skel_bulk_qh);
-       if (ret == -EINPROGRESS)
+       qh->skel = uhci->skel_bulk_qh;
+       ret = uhci_submit_common(uhci, urb, qh);
+       if (ret == 0)
                uhci_inc_fsbr(uhci, urb);
-
        return ret;
 }
 
-static inline int uhci_submit_interrupt(struct uhci_hcd *uhci, struct urb *urb, struct urb *eurb)
+static inline int uhci_submit_interrupt(struct uhci_hcd *uhci, struct urb *urb,
+               struct uhci_qh *qh)
 {
-       /* USB 1.1 interrupt transfers only involve one packet per interval;
-        * that's the uhci_submit_common() "breadth first" policy.  Drivers
-        * can submit urbs of any length, but longer ones might need many
-        * intervals to complete.
+       /* USB 1.1 interrupt transfers only involve one packet per interval.
+        * Drivers can submit URBs of any length, but longer ones will need
+        * multiple intervals to complete.
         */
-       return uhci_submit_common(uhci, urb, eurb, uhci->skelqh[__interval_to_skel(urb->interval)]);
+       qh->skel = uhci->skelqh[__interval_to_skel(urb->interval)];
+       return uhci_submit_common(uhci, urb, qh);
 }
 
 /*
  * Isochronous transfers
  */
-static int isochronous_find_limits(struct uhci_hcd *uhci, struct urb *urb, unsigned int *start, unsigned int *end)
+static int uhci_submit_isochronous(struct uhci_hcd *uhci, struct urb *urb,
+               struct uhci_qh *qh)
 {
-       struct urb *last_urb = NULL;
-       struct urb_priv *up;
-       int ret = 0;
-
-       list_for_each_entry(up, &uhci->urb_list, urb_list) {
-               struct urb *u = up->urb;
-
-               /* look for pending URB's with identical pipe handle */
-               if ((urb->pipe == u->pipe) && (urb->dev == u->dev) &&
-                   (u->status == -EINPROGRESS) && (u != urb)) {
-                       if (!last_urb)
-                               *start = u->start_frame;
-                       last_urb = u;
-               }
-       }
-
-       if (last_urb) {
-               *end = (last_urb->start_frame + last_urb->number_of_packets *
-                               last_urb->interval) & (UHCI_NUMFRAMES-1);
-               ret = 0;
-       } else
-               ret = -1;       /* no previous urb found */
-
-       return ret;
-}
-
-static int isochronous_find_start(struct uhci_hcd *uhci, struct urb *urb)
-{
-       int limits;
-       unsigned int start = 0, end = 0;
+       struct uhci_td *td = NULL;      /* Since urb->number_of_packets > 0 */
+       int i, frame;
+       unsigned long destination, status;
+       struct urb_priv *urbp = (struct urb_priv *) urb->hcpriv;
 
        if (urb->number_of_packets > 900)       /* 900? Why? */
                return -EFBIG;
 
-       limits = isochronous_find_limits(uhci, urb, &start, &end);
+       status = TD_CTRL_ACTIVE | TD_CTRL_IOS;
+       destination = (urb->pipe & PIPE_DEVEP_MASK) | usb_packetid(urb->pipe);
 
+       /* Figure out the starting frame number */
        if (urb->transfer_flags & URB_ISO_ASAP) {
-               if (limits) {
+               if (list_empty(&qh->queue)) {
                        uhci_get_current_frame_number(uhci);
-                       urb->start_frame = (uhci->frame_number + 10)
-                                       & (UHCI_NUMFRAMES - 1);
-               } else
-                       urb->start_frame = end;
+                       urb->start_frame = (uhci->frame_number + 10);
+
+               } else {                /* Go right after the last one */
+                       struct urb *last_urb;
+
+                       last_urb = list_entry(qh->queue.prev,
+                                       struct urb_priv, node)->urb;
+                       urb->start_frame = (last_urb->start_frame +
+                                       last_urb->number_of_packets *
+                                       last_urb->interval);
+               }
        } else {
-               urb->start_frame &= (UHCI_NUMFRAMES - 1);
                /* FIXME: Sanity check */
        }
+       urb->start_frame &= (UHCI_NUMFRAMES - 1);
 
-       return 0;
-}
-
-/*
- * Isochronous transfers
- */
-static int uhci_submit_isochronous(struct uhci_hcd *uhci, struct urb *urb)
-{
-       struct uhci_td *td;
-       int i, ret, frame;
-       int status, destination;
-
-       status = TD_CTRL_ACTIVE | TD_CTRL_IOS;
-       destination = (urb->pipe & PIPE_DEVEP_MASK) | usb_packetid(urb->pipe);
-
-       ret = isochronous_find_start(uhci, urb);
-       if (ret)
-               return ret;
-
-       frame = urb->start_frame;
-       for (i = 0; i < urb->number_of_packets; i++, frame += urb->interval) {
-               if (!urb->iso_frame_desc[i].length)
-                       continue;
-
-               td = uhci_alloc_td(uhci, urb->dev);
+       for (i = 0; i < urb->number_of_packets; i++) {
+               td = uhci_alloc_td(uhci);
                if (!td)
                        return -ENOMEM;
 
                uhci_add_td_to_urb(urb, td);
-               uhci_fill_td(td, status, destination | uhci_explen(urb->iso_frame_desc[i].length - 1),
-                       urb->transfer_dma + urb->iso_frame_desc[i].offset);
+               uhci_fill_td(td, status, destination |
+                               uhci_explen(urb->iso_frame_desc[i].length),
+                               urb->transfer_dma +
+                                       urb->iso_frame_desc[i].offset);
+       }
+
+       /* Set the interrupt-on-completion flag on the last packet. */
+       td->status |= __constant_cpu_to_le32(TD_CTRL_IOC);
 
-               if (i + 1 >= urb->number_of_packets)
-                       td->status |= cpu_to_le32(TD_CTRL_IOC);
+       qh->skel = uhci->skel_iso_qh;
 
-               uhci_insert_td_frame_list(uhci, td, frame);
+       /* Add the TDs to the frame list */
+       frame = urb->start_frame;
+       list_for_each_entry(td, &urbp->td_list, list) {
+               uhci_insert_td_in_frame_list(uhci, td, frame);
+               frame += urb->interval;
        }
 
-       return -EINPROGRESS;
+       return 0;
 }
 
 static int uhci_result_isochronous(struct uhci_hcd *uhci, struct urb *urb)
@@ -1120,7 +1040,7 @@ static int uhci_result_isochronous(struct uhci_hcd *uhci, struct urb *urb)
        int status;
        int i, ret = 0;
 
-       urb->actual_length = 0;
+       urb->actual_length = urb->error_count = 0;
 
        i = 0;
        list_for_each_entry(td, &urbp->td_list, list) {
@@ -1148,75 +1068,63 @@ static int uhci_result_isochronous(struct uhci_hcd *uhci, struct urb *urb)
        return ret;
 }
 
-static struct urb *uhci_find_urb_ep(struct uhci_hcd *uhci, struct urb *urb)
-{
-       struct urb_priv *up;
-
-       /* We don't match Isoc transfers since they are special */
-       if (usb_pipeisoc(urb->pipe))
-               return NULL;
-
-       list_for_each_entry(up, &uhci->urb_list, urb_list) {
-               struct urb *u = up->urb;
-
-               if (u->dev == urb->dev && u->status == -EINPROGRESS) {
-                       /* For control, ignore the direction */
-                       if (usb_pipecontrol(urb->pipe) &&
-                           (u->pipe & ~USB_DIR_IN) == (urb->pipe & ~USB_DIR_IN))
-                               return u;
-                       else if (u->pipe == urb->pipe)
-                               return u;
-               }
-       }
-
-       return NULL;
-}
-
 static int uhci_urb_enqueue(struct usb_hcd *hcd,
-               struct usb_host_endpoint *ep,
-               struct urb *urb, int mem_flags)
+               struct usb_host_endpoint *hep,
+               struct urb *urb, gfp_t mem_flags)
 {
        int ret;
        struct uhci_hcd *uhci = hcd_to_uhci(hcd);
        unsigned long flags;
-       struct urb *eurb;
+       struct urb_priv *urbp;
+       struct uhci_qh *qh;
        int bustime;
 
        spin_lock_irqsave(&uhci->lock, flags);
 
        ret = urb->status;
        if (ret != -EINPROGRESS)                /* URB already unlinked! */
-               goto out;
+               goto done;
 
-       eurb = uhci_find_urb_ep(uhci, urb);
+       ret = -ENOMEM;
+       urbp = uhci_alloc_urb_priv(uhci, urb);
+       if (!urbp)
+               goto done;
 
-       if (!uhci_alloc_urb_priv(uhci, urb)) {
-               ret = -ENOMEM;
-               goto out;
+       if (hep->hcpriv)
+               qh = (struct uhci_qh *) hep->hcpriv;
+       else {
+               qh = uhci_alloc_qh(uhci, urb->dev, hep);
+               if (!qh)
+                       goto err_no_qh;
        }
+       urbp->qh = qh;
 
        switch (usb_pipetype(urb->pipe)) {
        case PIPE_CONTROL:
-               ret = uhci_submit_control(uhci, urb, eurb);
+               ret = uhci_submit_control(uhci, urb, qh);
+               break;
+       case PIPE_BULK:
+               ret = uhci_submit_bulk(uhci, urb, qh);
                break;
        case PIPE_INTERRUPT:
-               if (!eurb) {
+               if (list_empty(&qh->queue)) {
                        bustime = usb_check_bandwidth(urb->dev, urb);
                        if (bustime < 0)
                                ret = bustime;
                        else {
-                               ret = uhci_submit_interrupt(uhci, urb, eurb);
-                               if (ret == -EINPROGRESS)
+                               ret = uhci_submit_interrupt(uhci, urb, qh);
+                               if (ret == 0)
                                        usb_claim_bandwidth(urb->dev, urb, bustime, 0);
                        }
                } else {        /* inherit from parent */
-                       urb->bandwidth = eurb->bandwidth;
-                       ret = uhci_submit_interrupt(uhci, urb, eurb);
+                       struct urb_priv *eurbp;
+
+                       eurbp = list_entry(qh->queue.prev, struct urb_priv,
+                                       node);
+                       urb->bandwidth = eurbp->urb->bandwidth;
+                       ret = uhci_submit_interrupt(uhci, urb, qh);
                }
                break;
-       case PIPE_BULK:
-               ret = uhci_submit_bulk(uhci, urb, eurb);
-               break;
        case PIPE_ISOCHRONOUS:
                bustime = usb_check_bandwidth(urb->dev, urb);
                if (bustime < 0) {
@@ -1224,219 +1132,208 @@ static int uhci_urb_enqueue(struct usb_hcd *hcd,
                        break;
                }
 
-               ret = uhci_submit_isochronous(uhci, urb);
-               if (ret == -EINPROGRESS)
+               ret = uhci_submit_isochronous(uhci, urb, qh);
+               if (ret == 0)
                        usb_claim_bandwidth(urb->dev, urb, bustime, 1);
                break;
        }
+       if (ret != 0)
+               goto err_submit_failed;
 
-       if (ret != -EINPROGRESS) {
-               /* Submit failed, so delete it from the urb_list */
-               struct urb_priv *urbp = urb->hcpriv;
+       /* Add this URB to the QH */
+       urbp->qh = qh;
+       list_add_tail(&urbp->node, &qh->queue);
+
+       /* If the new URB is the first and only one on this QH then either
+        * the QH is new and idle or else it's unlinked and waiting to
+        * become idle, so we can activate it right away. */
+       if (qh->queue.next == &urbp->node)
+               uhci_activate_qh(uhci, qh);
+       goto done;
+
+err_submit_failed:
+       if (qh->state == QH_STATE_IDLE)
+               uhci_make_qh_idle(uhci, qh);    /* Reclaim unused QH */
 
-               list_del_init(&urbp->urb_list);
-               uhci_destroy_urb_priv(uhci, urb);
-       } else
-               ret = 0;
+err_no_qh:
+       uhci_free_urb_priv(uhci, urbp);
 
-out:
+done:
        spin_unlock_irqrestore(&uhci->lock, flags);
        return ret;
 }
 
-/*
- * Return the result of a transfer
- */
-static void uhci_transfer_result(struct uhci_hcd *uhci, struct urb *urb)
+static int uhci_urb_dequeue(struct usb_hcd *hcd, struct urb *urb)
 {
-       int ret = -EINPROGRESS;
+       struct uhci_hcd *uhci = hcd_to_uhci(hcd);
+       unsigned long flags;
        struct urb_priv *urbp;
 
-       spin_lock(&urb->lock);
+       spin_lock_irqsave(&uhci->lock, flags);
+       urbp = urb->hcpriv;
+       if (!urbp)                      /* URB was never linked! */
+               goto done;
+
+       /* Remove Isochronous TDs from the frame list ASAP */
+       if (usb_pipetype(urb->pipe) == PIPE_ISOCHRONOUS)
+               uhci_unlink_isochronous_tds(uhci, urb);
+       uhci_unlink_qh(uhci, urbp->qh);
 
-       urbp = (struct urb_priv *)urb->hcpriv;
+done:
+       spin_unlock_irqrestore(&uhci->lock, flags);
+       return 0;
+}
 
-       if (urb->status != -EINPROGRESS)        /* URB already dequeued */
-               goto out;
+/*
+ * Finish unlinking an URB and give it back
+ */
+static void uhci_giveback_urb(struct uhci_hcd *uhci, struct uhci_qh *qh,
+               struct urb *urb, struct pt_regs *regs)
+__releases(uhci->lock)
+__acquires(uhci->lock)
+{
+       struct urb_priv *urbp = (struct urb_priv *) urb->hcpriv;
+
+       /* Isochronous TDs get unlinked directly from the frame list */
+       if (usb_pipetype(urb->pipe) == PIPE_ISOCHRONOUS)
+               uhci_unlink_isochronous_tds(uhci, urb);
+
+       /* If the URB isn't first on its queue, adjust the link pointer
+        * of the last TD in the previous URB. */
+       else if (qh->queue.next != &urbp->node) {
+               struct urb_priv *purbp;
+               struct uhci_td *ptd, *ltd;
+
+               purbp = list_entry(urbp->node.prev, struct urb_priv, node);
+               ptd = list_entry(purbp->td_list.prev, struct uhci_td,
+                               list);
+               ltd = list_entry(urbp->td_list.prev, struct uhci_td,
+                               list);
+               ptd->link = ltd->link;
+       }
 
-       switch (usb_pipetype(urb->pipe)) {
-       case PIPE_CONTROL:
-               ret = uhci_result_control(uhci, urb);
-               break;
-       case PIPE_BULK:
-       case PIPE_INTERRUPT:
-               ret = uhci_result_common(uhci, urb);
-               break;
-       case PIPE_ISOCHRONOUS:
-               ret = uhci_result_isochronous(uhci, urb);
-               break;
+       /* Take the URB off the QH's queue.  If the queue is now empty,
+        * this is a perfect time for a toggle fixup. */
+       list_del_init(&urbp->node);
+       if (list_empty(&qh->queue) && qh->needs_fixup) {
+               usb_settoggle(urb->dev, usb_pipeendpoint(urb->pipe),
+                               usb_pipeout(urb->pipe), qh->initial_toggle);
+               qh->needs_fixup = 0;
        }
 
-       if (ret == -EINPROGRESS)
-               goto out;
-       urb->status = ret;
+       uhci_dec_fsbr(uhci, urb);       /* Safe since it checks */
+       uhci_free_urb_priv(uhci, urbp);
 
        switch (usb_pipetype(urb->pipe)) {
-       case PIPE_CONTROL:
-       case PIPE_BULK:
        case PIPE_ISOCHRONOUS:
                /* Release bandwidth for Interrupt or Isoc. transfers */
                if (urb->bandwidth)
                        usb_release_bandwidth(urb->dev, urb, 1);
-               uhci_unlink_generic(uhci, urb);
                break;
        case PIPE_INTERRUPT:
                /* Release bandwidth for Interrupt or Isoc. transfers */
                /* Make sure we don't release if we have a queued URB */
-               if (list_empty(&urbp->queue_list) && urb->bandwidth)
+               if (list_empty(&qh->queue) && urb->bandwidth)
                        usb_release_bandwidth(urb->dev, urb, 0);
                else
                        /* bandwidth was passed on to queued URB, */
                        /* so don't let usb_unlink_urb() release it */
                        urb->bandwidth = 0;
-               uhci_unlink_generic(uhci, urb);
                break;
-       default:
-               dev_info(uhci_dev(uhci), "%s: unknown pipe type %d "
-                               "for urb %p\n",
-                               __FUNCTION__, usb_pipetype(urb->pipe), urb);
        }
 
-       /* Move it from uhci->urb_list to uhci->complete_list */
-       uhci_moveto_complete(uhci, urbp);
-
-out:
-       spin_unlock(&urb->lock);
-}
-
-static void uhci_unlink_generic(struct uhci_hcd *uhci, struct urb *urb)
-{
-       struct list_head *head;
-       struct uhci_td *td;
-       struct urb_priv *urbp = (struct urb_priv *)urb->hcpriv;
-       int prevactive = 0;
+       spin_unlock(&uhci->lock);
+       usb_hcd_giveback_urb(uhci_to_hcd(uhci), urb, regs);
+       spin_lock(&uhci->lock);
 
-       uhci_dec_fsbr(uhci, urb);       /* Safe since it checks */
+       /* If the queue is now empty, we can unlink the QH and give up its
+        * reserved bandwidth. */
+       if (list_empty(&qh->queue)) {
+               uhci_unlink_qh(uhci, qh);
 
-       /*
-        * Now we need to find out what the last successful toggle was
-        * so we can update the local data toggle for the next transfer
-        *
-        * There are 2 ways the last successful completed TD is found:
-        *
-        * 1) The TD is NOT active and the actual length < expected length
-        * 2) The TD is NOT active and it's the last TD in the chain
-        *
-        * and a third way the first uncompleted TD is found:
-        *
-        * 3) The TD is active and the previous TD is NOT active
-        *
-        * Control and Isochronous ignore the toggle, so this is safe
-        * for all types
-        *
-        * FIXME: The toggle fixups won't be 100% reliable until we
-        * change over to using a single queue for each endpoint and
-        * stop the queue before unlinking.
-        */
-       head = &urbp->td_list;
-       list_for_each_entry(td, head, list) {
-               unsigned int ctrlstat = td_status(td);
-
-               if (!(ctrlstat & TD_CTRL_ACTIVE) &&
-                               (uhci_actual_length(ctrlstat) <
-                                uhci_expected_length(td_token(td)) ||
-                               td->list.next == head))
-                       usb_settoggle(urb->dev, uhci_endpoint(td_token(td)),
-                               uhci_packetout(td_token(td)),
-                               uhci_toggle(td_token(td)) ^ 1);
-               else if ((ctrlstat & TD_CTRL_ACTIVE) && !prevactive)
-                       usb_settoggle(urb->dev, uhci_endpoint(td_token(td)),
-                               uhci_packetout(td_token(td)),
-                               uhci_toggle(td_token(td)));
-
-               prevactive = ctrlstat & TD_CTRL_ACTIVE;
+               /* Bandwidth stuff not yet implemented */
        }
-
-       uhci_delete_queued_urb(uhci, urb);
-
-       /* The interrupt loop will reclaim the QH's */
-       uhci_remove_qh(uhci, urbp->qh);
-       urbp->qh = NULL;
 }
 
-static int uhci_urb_dequeue(struct usb_hcd *hcd, struct urb *urb)
+/*
+ * Scan the URBs in a QH's queue
+ */
+#define QH_FINISHED_UNLINKING(qh)                      \
+               (qh->state == QH_STATE_UNLINKING &&     \
+               uhci->frame_number + uhci->is_stopped != qh->unlink_frame)
+
+static void uhci_scan_qh(struct uhci_hcd *uhci, struct uhci_qh *qh,
+               struct pt_regs *regs)
 {
-       struct uhci_hcd *uhci = hcd_to_uhci(hcd);
-       unsigned long flags;
        struct urb_priv *urbp;
+       struct urb *urb;
+       int status;
 
-       spin_lock_irqsave(&uhci->lock, flags);
-       urbp = urb->hcpriv;
-       if (!urbp)                      /* URB was never linked! */
-               goto done;
-       list_del_init(&urbp->urb_list);
-
-       uhci_unlink_generic(uhci, urb);
-
-       uhci_get_current_frame_number(uhci);
-       if (uhci->frame_number + uhci->is_stopped != uhci->urb_remove_age) {
-               uhci_remove_pending_urbps(uhci);
-               uhci->urb_remove_age = uhci->frame_number;
-       }
-
-       /* If we're the first, set the next interrupt bit */
-       if (list_empty(&uhci->urb_remove_list))
-               uhci_set_next_interrupt(uhci);
-       list_add_tail(&urbp->urb_list, &uhci->urb_remove_list);
-
-done:
-       spin_unlock_irqrestore(&uhci->lock, flags);
-       return 0;
-}
+       while (!list_empty(&qh->queue)) {
+               urbp = list_entry(qh->queue.next, struct urb_priv, node);
+               urb = urbp->urb;
 
-static int uhci_fsbr_timeout(struct uhci_hcd *uhci, struct urb *urb)
-{
-       struct urb_priv *urbp = (struct urb_priv *)urb->hcpriv;
-       struct list_head *head;
-       struct uhci_td *td;
-       int count = 0;
+               switch (usb_pipetype(urb->pipe)) {
+               case PIPE_CONTROL:
+                       status = uhci_result_control(uhci, urb);
+                       break;
+               case PIPE_ISOCHRONOUS:
+                       status = uhci_result_isochronous(uhci, urb);
+                       break;
+               default:        /* PIPE_BULK or PIPE_INTERRUPT */
+                       status = uhci_result_common(uhci, urb);
+                       break;
+               }
+               if (status == -EINPROGRESS)
+                       break;
 
-       uhci_dec_fsbr(uhci, urb);
+               spin_lock(&urb->lock);
+               if (urb->status == -EINPROGRESS)        /* Not dequeued */
+                       urb->status = status;
+               else
+                       status = -ECONNRESET;
+               spin_unlock(&urb->lock);
 
-       urbp->fsbr_timeout = 1;
+               /* Dequeued but completed URBs can't be given back unless
+                * the QH is stopped or has finished unlinking. */
+               if (status == -ECONNRESET &&
+                               !(qh->is_stopped || QH_FINISHED_UNLINKING(qh)))
+                       return;
 
-       /*
-        * Ideally we would want to fix qh->element as well, but it's
-        * read/write by the HC, so that can introduce a race. It's not
-        * really worth the hassle
-        */
-
-       head = &urbp->td_list;
-       list_for_each_entry(td, head, list) {
-               /*
-                * Make sure we don't do the last one (since it'll have the
-                * TERM bit set) as well as we skip every so many TD's to
-                * make sure it doesn't hog the bandwidth
-                */
-               if (td->list.next != head && (count % DEPTH_INTERVAL) ==
-                               (DEPTH_INTERVAL - 1))
-                       td->link |= UHCI_PTR_DEPTH;
-
-               count++;
+               uhci_giveback_urb(uhci, qh, urb, regs);
+               if (qh->is_stopped)
+                       break;
        }
 
-       return 0;
-}
-
-static void uhci_free_pending_qhs(struct uhci_hcd *uhci)
-{
-       struct uhci_qh *qh, *tmp;
-
-       list_for_each_entry_safe(qh, tmp, &uhci->qh_remove_list, remove_list) {
-               list_del_init(&qh->remove_list);
+       /* If the QH is neither stopped nor finished unlinking (normal case),
+        * our work here is done. */
+ restart:
+       if (!(qh->is_stopped || QH_FINISHED_UNLINKING(qh)))
+               return;
 
-               uhci_free_qh(uhci, qh);
+       /* Otherwise give back each of the dequeued URBs */
+       list_for_each_entry(urbp, &qh->queue, node) {
+               urb = urbp->urb;
+               if (urb->status != -EINPROGRESS) {
+                       uhci_save_toggle(qh, urb);
+                       uhci_giveback_urb(uhci, qh, urb, regs);
+                       goto restart;
+               }
+       }
+       qh->is_stopped = 0;
+
+       /* There are no more dequeued URBs.  If there are still URBs on the
+        * queue, the QH can now be re-activated. */
+       if (!list_empty(&qh->queue)) {
+               if (qh->needs_fixup)
+                       uhci_fixup_toggles(qh, 0);
+               uhci_activate_qh(uhci, qh);
        }
+
+       /* The queue is empty.  The QH can become idle if it is fully
+        * unlinked. */
+       else if (QH_FINISHED_UNLINKING(qh))
+               uhci_make_qh_idle(uhci, qh);
 }
 
 static void uhci_free_pending_tds(struct uhci_hcd *uhci)
@@ -1450,43 +1347,13 @@ static void uhci_free_pending_tds(struct uhci_hcd *uhci)
        }
 }
 
-static void
-uhci_finish_urb(struct usb_hcd *hcd, struct urb *urb, struct pt_regs *regs)
-__releases(uhci->lock)
-__acquires(uhci->lock)
-{
-       struct uhci_hcd *uhci = hcd_to_uhci(hcd);
-
-       uhci_destroy_urb_priv(uhci, urb);
-
-       spin_unlock(&uhci->lock);
-       usb_hcd_giveback_urb(hcd, urb, regs);
-       spin_lock(&uhci->lock);
-}
-
-static void uhci_finish_completion(struct uhci_hcd *uhci, struct pt_regs *regs)
-{
-       struct urb_priv *urbp, *tmp;
-
-       list_for_each_entry_safe(urbp, tmp, &uhci->complete_list, urb_list) {
-               struct urb *urb = urbp->urb;
-
-               list_del_init(&urbp->urb_list);
-               uhci_finish_urb(uhci_to_hcd(uhci), urb, regs);
-       }
-}
-
-static void uhci_remove_pending_urbps(struct uhci_hcd *uhci)
-{
-
-       /* Splice the urb_remove_list onto the end of the complete_list */
-       list_splice_init(&uhci->urb_remove_list, uhci->complete_list.prev);
-}
-
-/* Process events in the schedule, but only in one thread at a time */
+/*
+ * Process events in the schedule, but only in one thread at a time
+ */
 static void uhci_scan_schedule(struct uhci_hcd *uhci, struct pt_regs *regs)
 {
-       struct urb_priv *urbp, *tmp;
+       int i;
+       struct uhci_qh *qh;
 
        /* Don't allow re-entrant calls */
        if (uhci->scan_in_progress) {
@@ -1497,43 +1364,46 @@ static void uhci_scan_schedule(struct uhci_hcd *uhci, struct pt_regs *regs)
  rescan:
        uhci->need_rescan = 0;
 
+       uhci_clear_next_interrupt(uhci);
        uhci_get_current_frame_number(uhci);
 
-       if (uhci->frame_number + uhci->is_stopped != uhci->qh_remove_age)
-               uhci_free_pending_qhs(uhci);
        if (uhci->frame_number + uhci->is_stopped != uhci->td_remove_age)
                uhci_free_pending_tds(uhci);
-       if (uhci->frame_number + uhci->is_stopped != uhci->urb_remove_age)
-               uhci_remove_pending_urbps(uhci);
-
-       /* Walk the list of pending URBs to see which ones completed
-        * (must be _safe because uhci_transfer_result() dequeues URBs) */
-       list_for_each_entry_safe(urbp, tmp, &uhci->urb_list, urb_list) {
-               struct urb *urb = urbp->urb;
 
-               /* Checks the status and does all of the magic necessary */
-               uhci_transfer_result(uhci, urb);
-       }
-       uhci_finish_completion(uhci, regs);
-
-       /* If the controller is stopped, we can finish these off right now */
-       if (uhci->is_stopped) {
-               uhci_free_pending_qhs(uhci);
-               uhci_free_pending_tds(uhci);
-               uhci_remove_pending_urbps(uhci);
+       /* Go through all the QH queues and process the URBs in each one */
+       for (i = 0; i < UHCI_NUM_SKELQH - 1; ++i) {
+               uhci->next_qh = list_entry(uhci->skelqh[i]->node.next,
+                               struct uhci_qh, node);
+               while ((qh = uhci->next_qh) != uhci->skelqh[i]) {
+                       uhci->next_qh = list_entry(qh->node.next,
+                                       struct uhci_qh, node);
+                       uhci_scan_qh(uhci, qh, regs);
+               }
        }
 
        if (uhci->need_rescan)
                goto rescan;
        uhci->scan_in_progress = 0;
 
-       if (list_empty(&uhci->urb_remove_list) &&
-           list_empty(&uhci->td_remove_list) &&
-           list_empty(&uhci->qh_remove_list))
+       /* If the controller is stopped, we can finish these off right now */
+       if (uhci->is_stopped)
+               uhci_free_pending_tds(uhci);
+
+       if (list_empty(&uhci->td_remove_list) &&
+                       list_empty(&uhci->skel_unlink_qh->node))
                uhci_clear_next_interrupt(uhci);
        else
                uhci_set_next_interrupt(uhci);
+}
 
-       /* Wake up anyone waiting for an URB to complete */
-       wake_up_all(&uhci->waitqh);
+static void check_fsbr(struct uhci_hcd *uhci)
+{
+       /* For now, don't scan URBs for FSBR timeouts.
+        * Add it back in later... */
+
+       /* Really disable FSBR */
+       if (!uhci->fsbr && uhci->fsbrtimeout && time_after_eq(jiffies, uhci->fsbrtimeout)) {
+               uhci->fsbrtimeout = 0;
+               uhci->skel_term_qh->link = UHCI_PTR_TERM;
+       }
 }