vserver 1.9.3
[linux-2.6.git] / mm / shmem.c
index 57f8617..8951a2a 100644 (file)
@@ -6,8 +6,8 @@
  *              2000-2001 Christoph Rohland
  *              2000-2001 SAP AG
  *              2002 Red Hat Inc.
- * Copyright (C) 2002-2003 Hugh Dickins.
- * Copyright (C) 2002-2003 VERITAS Software Corporation.
+ * Copyright (C) 2002-2004 Hugh Dickins.
+ * Copyright (C) 2002-2004 VERITAS Software Corporation.
  * Copyright (C) 2004 Andi Kleen, SuSE Labs
  *
  * This file is released under the GPL.
@@ -178,16 +178,18 @@ static struct backing_dev_info shmem_backing_dev_info = {
        .unplug_io_fn = default_unplug_io_fn,
 };
 
-LIST_HEAD(shmem_inodes);
-static spinlock_t shmem_ilock = SPIN_LOCK_UNLOCKED;
+static LIST_HEAD(shmem_swaplist);
+static spinlock_t shmem_swaplist_lock = SPIN_LOCK_UNLOCKED;
 
 static void shmem_free_block(struct inode *inode)
 {
        struct shmem_sb_info *sbinfo = SHMEM_SB(inode->i_sb);
-       spin_lock(&sbinfo->stat_lock);
-       sbinfo->free_blocks++;
-       inode->i_blocks -= BLOCKS_PER_PAGE;
-       spin_unlock(&sbinfo->stat_lock);
+       if (sbinfo) {
+               spin_lock(&sbinfo->stat_lock);
+               sbinfo->free_blocks++;
+               inode->i_blocks -= BLOCKS_PER_PAGE;
+               spin_unlock(&sbinfo->stat_lock);
+       }
 }
 
 /*
@@ -212,11 +214,13 @@ static void shmem_recalc_inode(struct inode *inode)
        if (freed > 0) {
                struct shmem_sb_info *sbinfo = SHMEM_SB(inode->i_sb);
                info->alloced -= freed;
-               spin_lock(&sbinfo->stat_lock);
-               sbinfo->free_blocks += freed;
-               inode->i_blocks -= freed*BLOCKS_PER_PAGE;
-               spin_unlock(&sbinfo->stat_lock);
                shmem_unacct_blocks(info->flags, freed);
+               if (sbinfo) {
+                       spin_lock(&sbinfo->stat_lock);
+                       sbinfo->free_blocks += freed;
+                       inode->i_blocks -= freed*BLOCKS_PER_PAGE;
+                       spin_unlock(&sbinfo->stat_lock);
+               }
        }
 }
 
@@ -349,14 +353,16 @@ static swp_entry_t *shmem_swp_alloc(struct shmem_inode_info *info, unsigned long
                 * page (and perhaps indirect index pages) yet to allocate:
                 * a waste to allocate index if we cannot allocate data.
                 */
-               spin_lock(&sbinfo->stat_lock);
-               if (sbinfo->free_blocks <= 1) {
+               if (sbinfo) {
+                       spin_lock(&sbinfo->stat_lock);
+                       if (sbinfo->free_blocks <= 1) {
+                               spin_unlock(&sbinfo->stat_lock);
+                               return ERR_PTR(-ENOSPC);
+                       }
+                       sbinfo->free_blocks--;
+                       inode->i_blocks += BLOCKS_PER_PAGE;
                        spin_unlock(&sbinfo->stat_lock);
-                       return ERR_PTR(-ENOSPC);
                }
-               sbinfo->free_blocks--;
-               inode->i_blocks += BLOCKS_PER_PAGE;
-               spin_unlock(&sbinfo->stat_lock);
 
                spin_unlock(&info->lock);
                page = shmem_dir_alloc(mapping_gfp_mask(inode->i_mapping));
@@ -597,17 +603,21 @@ static void shmem_delete_inode(struct inode *inode)
        struct shmem_inode_info *info = SHMEM_I(inode);
 
        if (inode->i_op->truncate == shmem_truncate) {
-               spin_lock(&shmem_ilock);
-               list_del(&info->list);
-               spin_unlock(&shmem_ilock);
                shmem_unacct_size(info->flags, inode->i_size);
                inode->i_size = 0;
                shmem_truncate(inode);
+               if (!list_empty(&info->swaplist)) {
+                       spin_lock(&shmem_swaplist_lock);
+                       list_del_init(&info->swaplist);
+                       spin_unlock(&shmem_swaplist_lock);
+               }
+       }
+       if (sbinfo) {
+               BUG_ON(inode->i_blocks);
+               spin_lock(&sbinfo->stat_lock);
+               sbinfo->free_inodes++;
+               spin_unlock(&sbinfo->stat_lock);
        }
-       BUG_ON(inode->i_blocks);
-       spin_lock(&sbinfo->stat_lock);
-       sbinfo->free_inodes++;
-       spin_unlock(&sbinfo->stat_lock);
        clear_inode(inode);
 }
 
@@ -712,22 +722,23 @@ found:
  */
 int shmem_unuse(swp_entry_t entry, struct page *page)
 {
-       struct list_head *p;
+       struct list_head *p, *next;
        struct shmem_inode_info *info;
        int found = 0;
 
-       spin_lock(&shmem_ilock);
-       list_for_each(p, &shmem_inodes) {
-               info = list_entry(p, struct shmem_inode_info, list);
-
-               if (info->swapped && shmem_unuse_inode(info, entry, page)) {
+       spin_lock(&shmem_swaplist_lock);
+       list_for_each_safe(p, next, &shmem_swaplist) {
+               info = list_entry(p, struct shmem_inode_info, swaplist);
+               if (!info->swapped)
+                       list_del_init(&info->swaplist);
+               else if (shmem_unuse_inode(info, entry, page)) {
                        /* move head to start search for next from here */
-                       list_move_tail(&shmem_inodes, &info->list);
+                       list_move_tail(&shmem_swaplist, &info->swaplist);
                        found = 1;
                        break;
                }
        }
-       spin_unlock(&shmem_ilock);
+       spin_unlock(&shmem_swaplist_lock);
        return found;
 }
 
@@ -769,6 +780,12 @@ static int shmem_writepage(struct page *page, struct writeback_control *wbc)
                shmem_swp_set(info, entry, swap.val);
                shmem_swp_unmap(entry);
                spin_unlock(&info->lock);
+               if (list_empty(&info->swaplist)) {
+                       spin_lock(&shmem_swaplist_lock);
+                       /* move instead of add in case we're racing */
+                       list_move_tail(&info->swaplist, &shmem_swaplist);
+                       spin_unlock(&shmem_swaplist_lock);
+               }
                unlock_page(page);
                return 0;
        }
@@ -867,7 +884,7 @@ static int shmem_getpage(struct inode *inode, unsigned long idx,
        struct page *swappage;
        swp_entry_t *entry;
        swp_entry_t swap;
-       int error, majmin = VM_FAULT_MINOR;
+       int error;
 
        if (idx >= SHMEM_MAX_INDEX)
                return -EFBIG;
@@ -905,9 +922,10 @@ repeat:
                        shmem_swp_unmap(entry);
                        spin_unlock(&info->lock);
                        /* here we actually do the io */
-                       if (majmin == VM_FAULT_MINOR && type)
+                       if (type && *type == VM_FAULT_MINOR) {
                                inc_page_state(pgmajfault);
-                       majmin = VM_FAULT_MAJOR;
+                               *type = VM_FAULT_MAJOR;
+                       }
                        swappage = shmem_swapin(info, swap, idx);
                        if (!swappage) {
                                spin_lock(&info->lock);
@@ -1000,16 +1018,23 @@ repeat:
        } else {
                shmem_swp_unmap(entry);
                sbinfo = SHMEM_SB(inode->i_sb);
-               spin_lock(&sbinfo->stat_lock);
-               if (sbinfo->free_blocks == 0 || shmem_acct_block(info->flags)) {
+               if (sbinfo) {
+                       spin_lock(&sbinfo->stat_lock);
+                       if (sbinfo->free_blocks == 0 ||
+                           shmem_acct_block(info->flags)) {
+                               spin_unlock(&sbinfo->stat_lock);
+                               spin_unlock(&info->lock);
+                               error = -ENOSPC;
+                               goto failed;
+                       }
+                       sbinfo->free_blocks--;
+                       inode->i_blocks += BLOCKS_PER_PAGE;
                        spin_unlock(&sbinfo->stat_lock);
+               } else if (shmem_acct_block(info->flags)) {
                        spin_unlock(&info->lock);
                        error = -ENOSPC;
                        goto failed;
                }
-               sbinfo->free_blocks--;
-               inode->i_blocks += BLOCKS_PER_PAGE;
-               spin_unlock(&sbinfo->stat_lock);
 
                if (!filepage) {
                        spin_unlock(&info->lock);
@@ -1052,15 +1077,10 @@ repeat:
                SetPageUptodate(filepage);
        }
 done:
-       if (!*pagep) {
-               if (filepage) {
-                       unlock_page(filepage);
-                       *pagep = filepage;
-               } else
-                       *pagep = ZERO_PAGE(0);
+       if (*pagep != filepage) {
+               unlock_page(filepage);
+               *pagep = filepage;
        }
-       if (type)
-               *type = majmin;
        return 0;
 
 failed:
@@ -1150,17 +1170,26 @@ shmem_get_policy(struct vm_area_struct *vma, unsigned long addr)
 }
 #endif
 
-void shmem_lock(struct file *file, int lock)
+int shmem_lock(struct file *file, int lock, struct user_struct *user)
 {
        struct inode *inode = file->f_dentry->d_inode;
        struct shmem_inode_info *info = SHMEM_I(inode);
+       int retval = -ENOMEM;
 
        spin_lock(&info->lock);
-       if (lock)
+       if (lock && !(info->flags & VM_LOCKED)) {
+               if (!user_shm_lock(inode->i_size, user))
+                       goto out_nomem;
                info->flags |= VM_LOCKED;
-       else
+       }
+       if (!lock && (info->flags & VM_LOCKED) && user) {
+               user_shm_unlock(inode->i_size, user);
                info->flags &= ~VM_LOCKED;
+       }
+       retval = 0;
+out_nomem:
        spin_unlock(&info->lock);
+       return retval;
 }
 
 static int shmem_mmap(struct file *file, struct vm_area_struct *vma)
@@ -1177,13 +1206,15 @@ shmem_get_inode(struct super_block *sb, int mode, dev_t dev)
        struct shmem_inode_info *info;
        struct shmem_sb_info *sbinfo = SHMEM_SB(sb);
 
-       spin_lock(&sbinfo->stat_lock);
-       if (!sbinfo->free_inodes) {
+       if (sbinfo) {
+               spin_lock(&sbinfo->stat_lock);
+               if (!sbinfo->free_inodes) {
+                       spin_unlock(&sbinfo->stat_lock);
+                       return NULL;
+               }
+               sbinfo->free_inodes--;
                spin_unlock(&sbinfo->stat_lock);
-               return NULL;
        }
-       sbinfo->free_inodes--;
-       spin_unlock(&sbinfo->stat_lock);
 
        inode = new_inode(sb);
        if (inode) {
@@ -1199,6 +1230,8 @@ shmem_get_inode(struct super_block *sb, int mode, dev_t dev)
                memset(info, 0, (char *)inode - (char *)info);
                spin_lock_init(&info->lock);
                mpol_shared_policy_init(&info->policy);
+               INIT_LIST_HEAD(&info->swaplist);
+
                switch (mode & S_IFMT) {
                default:
                        init_special_inode(inode, mode, dev);
@@ -1206,9 +1239,6 @@ shmem_get_inode(struct super_block *sb, int mode, dev_t dev)
                case S_IFREG:
                        inode->i_op = &shmem_inode_operations;
                        inode->i_fop = &shmem_file_operations;
-                       spin_lock(&shmem_ilock);
-                       list_add_tail(&info->list, &shmem_inodes);
-                       spin_unlock(&shmem_ilock);
                        break;
                case S_IFDIR:
                        inode->i_nlink++;
@@ -1224,32 +1254,32 @@ shmem_get_inode(struct super_block *sb, int mode, dev_t dev)
        return inode;
 }
 
-static int shmem_set_size(struct shmem_sb_info *info,
+#ifdef CONFIG_TMPFS
+
+static int shmem_set_size(struct shmem_sb_info *sbinfo,
                          unsigned long max_blocks, unsigned long max_inodes)
 {
        int error;
        unsigned long blocks, inodes;
 
-       spin_lock(&info->stat_lock);
-       blocks = info->max_blocks - info->free_blocks;
-       inodes = info->max_inodes - info->free_inodes;
+       spin_lock(&sbinfo->stat_lock);
+       blocks = sbinfo->max_blocks - sbinfo->free_blocks;
+       inodes = sbinfo->max_inodes - sbinfo->free_inodes;
        error = -EINVAL;
        if (max_blocks < blocks)
                goto out;
        if (max_inodes < inodes)
                goto out;
        error = 0;
-       info->max_blocks  = max_blocks;
-       info->free_blocks = max_blocks - blocks;
-       info->max_inodes  = max_inodes;
-       info->free_inodes = max_inodes - inodes;
+       sbinfo->max_blocks  = max_blocks;
+       sbinfo->free_blocks = max_blocks - blocks;
+       sbinfo->max_inodes  = max_inodes;
+       sbinfo->free_inodes = max_inodes - inodes;
 out:
-       spin_unlock(&info->stat_lock);
+       spin_unlock(&sbinfo->stat_lock);
        return error;
 }
 
-#ifdef CONFIG_TMPFS
-
 static struct inode_operations shmem_symlink_inode_operations;
 static struct inode_operations shmem_symlink_inline_operations;
 
@@ -1270,7 +1300,7 @@ shmem_file_write(struct file *file, const char __user *buf, size_t count, loff_t
        struct inode    *inode = file->f_dentry->d_inode;
        loff_t          pos;
        unsigned long   written;
-       int             err;
+       ssize_t         err;
 
        if ((ssize_t) count < 0)
                return -EINVAL;
@@ -1322,7 +1352,8 @@ shmem_file_write(struct file *file, const char __user *buf, size_t count, loff_t
                        __get_user(dummy, buf + bytes - 1);
 
                        kaddr = kmap_atomic(page, KM_USER0);
-                       left = __copy_from_user(kaddr + offset, buf, bytes);
+                       left = __copy_from_user_inatomic(kaddr + offset,
+                                                       buf, bytes);
                        kunmap_atomic(kaddr, KM_USER0);
                }
                if (left) {
@@ -1406,13 +1437,14 @@ static void do_shmem_file_read(struct file *filp, loff_t *ppos, read_descriptor_
                if (index == end_index) {
                        nr = i_size & ~PAGE_CACHE_MASK;
                        if (nr <= offset) {
-                               page_cache_release(page);
+                               if (page)
+                                       page_cache_release(page);
                                break;
                        }
                }
                nr -= offset;
 
-               if (page != ZERO_PAGE(0)) {
+               if (page) {
                        /*
                         * If users can be writing to this page using arbitrary
                         * virtual addresses, take care about potential aliasing
@@ -1425,7 +1457,8 @@ static void do_shmem_file_read(struct file *filp, loff_t *ppos, read_descriptor_
                         */
                        if (!offset)
                                mark_page_accessed(page);
-               }
+               } else
+                       page = ZERO_PAGE(0);
 
                /*
                 * Ok, we have the page, and it's up-to-date, so
@@ -1500,13 +1533,16 @@ static int shmem_statfs(struct super_block *sb, struct kstatfs *buf)
 
        buf->f_type = TMPFS_SUPER_MAGIC;
        buf->f_bsize = PAGE_CACHE_SIZE;
-       spin_lock(&sbinfo->stat_lock);
-       buf->f_blocks = sbinfo->max_blocks;
-       buf->f_bavail = buf->f_bfree = sbinfo->free_blocks;
-       buf->f_files = sbinfo->max_inodes;
-       buf->f_ffree = sbinfo->free_inodes;
-       spin_unlock(&sbinfo->stat_lock);
        buf->f_namelen = NAME_MAX;
+       if (sbinfo) {
+               spin_lock(&sbinfo->stat_lock);
+               buf->f_blocks = sbinfo->max_blocks;
+               buf->f_bavail = buf->f_bfree = sbinfo->free_blocks;
+               buf->f_files = sbinfo->max_inodes;
+               buf->f_ffree = sbinfo->free_inodes;
+               spin_unlock(&sbinfo->stat_lock);
+       }
+       /* else leave those fields 0 like simple_statfs */
        return 0;
 }
 
@@ -1556,6 +1592,22 @@ static int shmem_create(struct inode *dir, struct dentry *dentry, int mode,
 static int shmem_link(struct dentry *old_dentry, struct inode *dir, struct dentry *dentry)
 {
        struct inode *inode = old_dentry->d_inode;
+       struct shmem_sb_info *sbinfo = SHMEM_SB(inode->i_sb);
+
+       /*
+        * No ordinary (disk based) filesystem counts links as inodes;
+        * but each new link needs a new dentry, pinning lowmem, and
+        * tmpfs dentries cannot be pruned until they are unlinked.
+        */
+       if (sbinfo) {
+               spin_lock(&sbinfo->stat_lock);
+               if (!sbinfo->free_inodes) {
+                       spin_unlock(&sbinfo->stat_lock);
+                       return -ENOSPC;
+               }
+               sbinfo->free_inodes--;
+               spin_unlock(&sbinfo->stat_lock);
+       }
 
        dir->i_size += BOGO_DIRENT_SIZE;
        inode->i_ctime = dir->i_ctime = dir->i_mtime = CURRENT_TIME;
@@ -1570,6 +1622,15 @@ static int shmem_unlink(struct inode *dir, struct dentry *dentry)
 {
        struct inode *inode = dentry->d_inode;
 
+       if (inode->i_nlink > 1 && !S_ISDIR(inode->i_mode)) {
+               struct shmem_sb_info *sbinfo = SHMEM_SB(inode->i_sb);
+               if (sbinfo) {
+                       spin_lock(&sbinfo->stat_lock);
+                       sbinfo->free_inodes++;
+                       spin_unlock(&sbinfo->stat_lock);
+               }
+       }
+
        dir->i_size -= BOGO_DIRENT_SIZE;
        inode->i_ctime = dir->i_ctime = dir->i_mtime = CURRENT_TIME;
        inode->i_nlink--;
@@ -1647,9 +1708,6 @@ static int shmem_symlink(struct inode *dir, struct dentry *dentry, const char *s
                        return error;
                }
                inode->i_op = &shmem_symlink_inode_operations;
-               spin_lock(&shmem_ilock);
-               list_add_tail(&info->list, &shmem_inodes);
-               spin_unlock(&shmem_ilock);
                kaddr = kmap_atomic(page, KM_USER0);
                memcpy(kaddr, symname, len);
                kunmap_atomic(kaddr, KM_USER0);
@@ -1778,53 +1836,75 @@ bad_val:
 static int shmem_remount_fs(struct super_block *sb, int *flags, char *data)
 {
        struct shmem_sb_info *sbinfo = SHMEM_SB(sb);
-       unsigned long max_blocks = sbinfo->max_blocks;
-       unsigned long max_inodes = sbinfo->max_inodes;
+       unsigned long max_blocks = 0;
+       unsigned long max_inodes = 0;
 
+       if (sbinfo) {
+               max_blocks = sbinfo->max_blocks;
+               max_inodes = sbinfo->max_inodes;
+       }
        if (shmem_parse_options(data, NULL, NULL, NULL, &max_blocks, &max_inodes))
                return -EINVAL;
+       /* Keep it simple: disallow limited <-> unlimited remount */
+       if ((max_blocks || max_inodes) == !sbinfo)
+               return -EINVAL;
+       /* But allow the pointless unlimited -> unlimited remount */
+       if (!sbinfo)
+               return 0;
        return shmem_set_size(sbinfo, max_blocks, max_inodes);
 }
 #endif
 
+static void shmem_put_super(struct super_block *sb)
+{
+       kfree(sb->s_fs_info);
+       sb->s_fs_info = NULL;
+}
+
 static int shmem_fill_super(struct super_block *sb,
                            void *data, int silent)
 {
        struct inode *inode;
        struct dentry *root;
-       unsigned long blocks, inodes;
        int mode   = S_IRWXUGO | S_ISVTX;
        uid_t uid = current->fsuid;
        gid_t gid = current->fsgid;
-       struct shmem_sb_info *sbinfo;
        int err = -ENOMEM;
 
-       sbinfo = kmalloc(sizeof(struct shmem_sb_info), GFP_KERNEL);
-       if (!sbinfo)
-               return -ENOMEM;
-       sb->s_fs_info = sbinfo;
-       memset(sbinfo, 0, sizeof(struct shmem_sb_info));
+#ifdef CONFIG_TMPFS
+       unsigned long blocks = 0;
+       unsigned long inodes = 0;
 
        /*
         * Per default we only allow half of the physical ram per
-        * tmpfs instance
+        * tmpfs instance, limiting inodes to one per page of lowmem;
+        * but the internal instance is left unlimited.
         */
-       blocks = inodes = totalram_pages / 2;
+       if (!(sb->s_flags & MS_NOUSER)) {
+               blocks = totalram_pages / 2;
+               inodes = totalram_pages - totalhigh_pages;
+               if (inodes > blocks)
+                       inodes = blocks;
+
+               if (shmem_parse_options(data, &mode,
+                                       &uid, &gid, &blocks, &inodes))
+                       return -EINVAL;
+       }
 
-#ifdef CONFIG_TMPFS
-       if (shmem_parse_options(data, &mode, &uid, &gid, &blocks, &inodes)) {
-               err = -EINVAL;
-               goto failed;
+       if (blocks || inodes) {
+               struct shmem_sb_info *sbinfo;
+               sbinfo = kmalloc(sizeof(struct shmem_sb_info), GFP_KERNEL);
+               if (!sbinfo)
+                       return -ENOMEM;
+               sb->s_fs_info = sbinfo;
+               spin_lock_init(&sbinfo->stat_lock);
+               sbinfo->max_blocks = blocks;
+               sbinfo->free_blocks = blocks;
+               sbinfo->max_inodes = inodes;
+               sbinfo->free_inodes = inodes;
        }
-#else
-       sb->s_flags |= MS_NOUSER;
 #endif
 
-       spin_lock_init(&sbinfo->stat_lock);
-       sbinfo->max_blocks = blocks;
-       sbinfo->free_blocks = blocks;
-       sbinfo->max_inodes = inodes;
-       sbinfo->free_inodes = inodes;
        sb->s_maxbytes = SHMEM_MAX_BYTES;
        sb->s_blocksize = PAGE_CACHE_SIZE;
        sb->s_blocksize_bits = PAGE_CACHE_SHIFT;
@@ -1844,17 +1924,10 @@ static int shmem_fill_super(struct super_block *sb,
 failed_iput:
        iput(inode);
 failed:
-       kfree(sbinfo);
-       sb->s_fs_info = NULL;
+       shmem_put_super(sb);
        return err;
 }
 
-static void shmem_put_super(struct super_block *sb)
-{
-       kfree(sb->s_fs_info);
-       sb->s_fs_info = NULL;
-}
-
 static kmem_cache_t *shmem_inode_cachep;
 
 static struct inode *shmem_alloc_inode(struct super_block *sb)
@@ -1886,8 +1959,7 @@ static int init_inodecache(void)
 {
        shmem_inode_cachep = kmem_cache_create("shmem_inode_cache",
                                sizeof(struct shmem_inode_info),
-                               0, SLAB_HWCACHE_ALIGN|SLAB_RECLAIM_ACCOUNT,
-                               init_once, NULL);
+                               0, 0, init_once, NULL);
        if (shmem_inode_cachep == NULL)
                return -ENOMEM;
        return 0;
@@ -1989,15 +2061,13 @@ static int __init init_tmpfs(void)
 #ifdef CONFIG_TMPFS
        devfs_mk_dir("shm");
 #endif
-       shm_mnt = kern_mount(&tmpfs_fs_type);
+       shm_mnt = do_kern_mount(tmpfs_fs_type.name, MS_NOUSER,
+                               tmpfs_fs_type.name, NULL);
        if (IS_ERR(shm_mnt)) {
                error = PTR_ERR(shm_mnt);
                printk(KERN_ERR "Could not kern_mount tmpfs\n");
                goto out1;
        }
-
-       /* The internal instance should not do size checking */
-       shmem_set_size(SHMEM_SB(shm_mnt->mnt_sb), ULONG_MAX, ULONG_MAX);
        return 0;
 
 out1:
@@ -2028,7 +2098,7 @@ struct file *shmem_file_setup(char *name, loff_t size, unsigned long flags)
        if (IS_ERR(shm_mnt))
                return (void *)shm_mnt;
 
-       if (size > SHMEM_MAX_BYTES)
+       if (size < 0 || size > SHMEM_MAX_BYTES)
                return ERR_PTR(-EINVAL);
 
        if (shmem_acct_size(flags, size))
@@ -2062,7 +2132,7 @@ struct file *shmem_file_setup(char *name, loff_t size, unsigned long flags)
        file->f_mapping = inode->i_mapping;
        file->f_op = &shmem_file_operations;
        file->f_mode = FMODE_WRITE | FMODE_READ;
-       return(file);
+       return file;
 
 close_file:
        put_filp(file);