This commit was manufactured by cvs2svn to create tag
[linux-2.6.git] / net / bluetooth / l2cap.c
index 612ac3c..1da6a95 100644 (file)
@@ -57,7 +57,7 @@
 #define BT_DBG(D...)
 #endif
 
-#define VERSION "2.6"
+#define VERSION "2.4"
 
 static struct proto_ops l2cap_sock_ops;
 
@@ -74,8 +74,8 @@ static void __l2cap_sock_close(struct sock *sk, int reason);
 static void l2cap_sock_close(struct sock *sk);
 static void l2cap_sock_kill(struct sock *sk);
 
-static struct sk_buff *l2cap_build_cmd(struct l2cap_conn *conn,
-                               u8 code, u8 ident, u16 dlen, void *data);
+static int l2cap_send_req(struct l2cap_conn *conn, u8 code, u16 len, void *data);
+static int l2cap_send_rsp(struct l2cap_conn *conn, u8 ident, u8 code, u16 len, void *data);
 
 /* ---- L2CAP timers ---- */
 static void l2cap_sock_timeout(unsigned long arg)
@@ -134,7 +134,7 @@ static struct l2cap_conn *l2cap_conn_add(struct hci_conn *hcon, u8 status)
        conn->dst = &hcon->dst;
 
        spin_lock_init(&conn->lock);
-       rwlock_init(&conn->chan_list.lock);
+       conn->chan_list.lock = RW_LOCK_UNLOCKED;
 
        BT_DBG("hcon %p conn %p", hcon, conn);
        return conn;
@@ -174,40 +174,6 @@ static inline void l2cap_chan_add(struct l2cap_conn *conn, struct sock *sk, stru
        write_unlock(&l->lock);
 }
 
-static inline u8 l2cap_get_ident(struct l2cap_conn *conn)
-{
-       u8 id;
-
-       /* Get next available identificator.
-        *    1 - 128 are used by kernel.
-        *  129 - 199 are reserved.
-        *  200 - 254 are used by utilities like l2ping, etc.
-        */
-
-       spin_lock(&conn->lock);
-
-       if (++conn->tx_ident > 128)
-               conn->tx_ident = 1;
-
-       id = conn->tx_ident;
-
-       spin_unlock(&conn->lock);
-
-       return id;
-}
-
-static inline int l2cap_send_cmd(struct l2cap_conn *conn, u8 ident, u8 code, u16 len, void *data)
-{
-       struct sk_buff *skb = l2cap_build_cmd(conn, code, ident, len, data);
-
-       BT_DBG("code 0x%2.2x", code);
-
-       if (!skb)
-               return -ENOMEM;
-
-       return hci_send_acl(conn->hcon, skb, 0);
-}
-
 /* ---- Socket interface ---- */
 static struct sock *__l2cap_get_sock_by_addr(u16 psm, bdaddr_t *src)
 {
@@ -320,8 +286,7 @@ static void __l2cap_sock_close(struct sock *sk, int reason)
 
                        req.dcid = __cpu_to_le16(l2cap_pi(sk)->dcid);
                        req.scid = __cpu_to_le16(l2cap_pi(sk)->scid);
-                       l2cap_send_cmd(conn, l2cap_get_ident(conn),
-                                       L2CAP_DISCONN_REQ, sizeof(req), &req);
+                       l2cap_send_req(conn, L2CAP_DISCONN_REQ, sizeof(req), &req);
                } else {
                        l2cap_chan_del(sk, reason);
                }
@@ -400,8 +365,7 @@ static int l2cap_sock_create(struct socket *sock, int protocol)
 
        sock->state = SS_UNCONNECTED;
 
-       if (sock->type != SOCK_SEQPACKET &&
-                       sock->type != SOCK_DGRAM && sock->type != SOCK_RAW)
+       if (sock->type != SOCK_SEQPACKET && sock->type != SOCK_DGRAM && sock->type != SOCK_RAW)
                return -ESOCKTNOSUPPORT;
 
        if (sock->type == SOCK_RAW && !capable(CAP_NET_RAW))
@@ -495,11 +459,9 @@ static int l2cap_do_connect(struct sock *sk)
        if (hcon->state == BT_CONNECTED) {
                if (sk->sk_type == SOCK_SEQPACKET) {
                        struct l2cap_conn_req req;
-                       l2cap_pi(sk)->ident = l2cap_get_ident(conn);
                        req.scid = __cpu_to_le16(l2cap_pi(sk)->scid);
                        req.psm  = l2cap_pi(sk)->psm;
-                       l2cap_send_cmd(conn, l2cap_pi(sk)->ident,
-                                       L2CAP_CONN_REQ, sizeof(req), &req);
+                       l2cap_send_req(conn, L2CAP_CONN_REQ, sizeof(req), &req);
                } else {
                        l2cap_sock_clear_timer(sk);
                        sk->sk_state = BT_CONNECTED;
@@ -949,26 +911,6 @@ static inline struct sock *l2cap_get_chan_by_scid(struct l2cap_chan_list *l, u16
        return s;
 }
 
-static struct sock *__l2cap_get_chan_by_ident(struct l2cap_chan_list *l, u8 ident)
-{
-       struct sock *s;
-       for (s = l->head; s; s = l2cap_pi(s)->next_c) {
-               if (l2cap_pi(s)->ident == ident)
-                       break;
-       }
-       return s;
-}
-
-static inline struct sock *l2cap_get_chan_by_ident(struct l2cap_chan_list *l, u8 ident)
-{
-       struct sock *s;
-       read_lock(&l->lock);
-       s = __l2cap_get_chan_by_ident(l, ident);
-       if (s) bh_lock_sock(s);
-       read_unlock(&l->lock);
-       return s;
-}
-
 static u16 l2cap_alloc_cid(struct l2cap_chan_list *l)
 {
        u16 cid = 0x0040;
@@ -1063,10 +1005,9 @@ static void l2cap_chan_del(struct sock *sk, int err)
        if (err)
                sk->sk_err = err;
 
-       if (parent) {
-               bt_accept_unlink(sk);
+       if (parent)
                parent->sk_data_ready(parent, 0);
-       else
+       else
                sk->sk_state_change(sk);
 }
 
@@ -1088,10 +1029,9 @@ static void l2cap_conn_ready(struct l2cap_conn *conn)
                        sk->sk_state_change(sk);
                } else if (sk->sk_state == BT_CONNECT) {
                        struct l2cap_conn_req req;
-                       l2cap_pi(sk)->ident = l2cap_get_ident(conn);
                        req.scid = __cpu_to_le16(l2cap_pi(sk)->scid);
                        req.psm  = l2cap_pi(sk)->psm;
-                       l2cap_send_cmd(conn, l2cap_pi(sk)->ident, L2CAP_CONN_REQ, sizeof(req), &req);
+                       l2cap_send_req(conn, L2CAP_CONN_REQ, sizeof(req), &req);
                }
 
                bh_unlock_sock(sk);
@@ -1100,22 +1040,6 @@ static void l2cap_conn_ready(struct l2cap_conn *conn)
        read_unlock(&l->lock);
 }
 
-/* Notify sockets that we cannot guaranty reliability anymore */
-static void l2cap_conn_unreliable(struct l2cap_conn *conn, int err)
-{
-       struct l2cap_chan_list *l = &conn->chan_list;
-       struct sock *sk;
-
-       BT_DBG("conn %p", conn);
-
-       read_lock(&l->lock);
-       for (sk = l->head; sk; sk = l2cap_pi(sk)->next_c) {
-               if (l2cap_pi(sk)->link_mode & L2CAP_LM_RELIABLE)
-                       sk->sk_err = err;
-       }
-       read_unlock(&l->lock);
-}
-
 static void l2cap_chan_ready(struct sock *sk)
 {
        struct sock *parent = bt_sk(sk)->parent;
@@ -1167,6 +1091,27 @@ static void l2cap_raw_recv(struct l2cap_conn *conn, struct sk_buff *skb)
 }
 
 /* ---- L2CAP signalling commands ---- */
+static inline u8 l2cap_get_ident(struct l2cap_conn *conn)
+{
+       u8 id;
+
+       /* Get next available identificator.
+        *    1 - 199 are used by kernel.
+        *  200 - 254 are used by utilities like l2ping, etc 
+        */
+
+       spin_lock(&conn->lock);
+
+       if (++conn->tx_ident > 199)
+               conn->tx_ident = 1;
+
+       id = conn->tx_ident;
+
+       spin_unlock(&conn->lock);
+
+       return id;
+}
+
 static struct sk_buff *l2cap_build_cmd(struct l2cap_conn *conn,
                                u8 code, u8 ident, u16 dlen, void *data)
 {
@@ -1225,6 +1170,29 @@ fail:
        return NULL;
 }
 
+static int l2cap_send_req(struct l2cap_conn *conn, u8 code, u16 len, void *data)
+{
+       u8 ident = l2cap_get_ident(conn);
+       struct sk_buff *skb = l2cap_build_cmd(conn, code, ident, len, data);
+
+       BT_DBG("code 0x%2.2x", code);
+
+       if (!skb)
+               return -ENOMEM;
+       return hci_send_acl(conn->hcon, skb, 0);
+}
+
+static int l2cap_send_rsp(struct l2cap_conn *conn, u8 ident, u8 code, u16 len, void *data)
+{
+       struct sk_buff *skb = l2cap_build_cmd(conn, code, ident, len, data);
+
+       BT_DBG("code 0x%2.2x", code);
+
+       if (!skb)
+               return -ENOMEM;
+       return hci_send_acl(conn->hcon, skb, 0);
+}
+
 static inline int l2cap_get_conf_opt(void **ptr, int *type, int *olen, unsigned long *val)
 {
        struct l2cap_conf_opt *opt = *ptr;
@@ -1335,7 +1303,7 @@ static int l2cap_build_conf_req(struct sock *sk, void *data)
        if (pi->imtu != L2CAP_DEFAULT_MTU)
                l2cap_add_conf_opt(&ptr, L2CAP_CONF_MTU, 2, pi->imtu);
 
-       /* FIXME: Need actual value of the flush timeout */
+       /* FIXME. Need actual value of the flush timeout */
        //if (flush_to != L2CAP_DEFAULT_FLUSH_TO)
        //   l2cap_add_conf_opt(&ptr, L2CAP_CONF_FLUSH_TO, 2, pi->flush_to);
 
@@ -1443,9 +1411,8 @@ static inline int l2cap_connect_req(struct l2cap_conn *conn, struct l2cap_cmd_hd
        status = L2CAP_CS_AUTHEN_PEND;
        sk->sk_state = BT_CONNECT2;
        l2cap_pi(sk)->ident = cmd->ident;
-
-       if ((l2cap_pi(sk)->link_mode & L2CAP_LM_ENCRYPT) ||
-                       (l2cap_pi(sk)->link_mode & L2CAP_LM_SECURE)) {
+       
+       if (l2cap_pi(sk)->link_mode & L2CAP_LM_ENCRYPT) {
                if (!hci_conn_encrypt(conn->hcon))
                        goto done;
        } else if (l2cap_pi(sk)->link_mode & L2CAP_LM_AUTH) {
@@ -1467,7 +1434,7 @@ sendresp:
        rsp.dcid   = __cpu_to_le16(dcid);
        rsp.result = __cpu_to_le16(result);
        rsp.status = __cpu_to_le16(status);
-       l2cap_send_cmd(conn, cmd->ident, L2CAP_CONN_RSP, sizeof(rsp), &rsp);
+       l2cap_send_rsp(conn, cmd->ident, L2CAP_CONN_RSP, sizeof(rsp), &rsp);
        return 0;
 }
 
@@ -1485,23 +1452,16 @@ static inline int l2cap_connect_rsp(struct l2cap_conn *conn, struct l2cap_cmd_hd
 
        BT_DBG("dcid 0x%4.4x scid 0x%4.4x result 0x%2.2x status 0x%2.2x", dcid, scid, result, status);
 
-       if (scid) {
-               if (!(sk = l2cap_get_chan_by_scid(&conn->chan_list, scid)))
-                       return 0;
-       } else {
-               if (!(sk = l2cap_get_chan_by_ident(&conn->chan_list, cmd->ident)))
-                       return 0;
-       }
+       if (!(sk = l2cap_get_chan_by_scid(&conn->chan_list, scid)))
+               return 0;
 
        switch (result) {
        case L2CAP_CR_SUCCESS:
                sk->sk_state = BT_CONFIG;
-               l2cap_pi(sk)->ident = 0;
                l2cap_pi(sk)->dcid = dcid;
                l2cap_pi(sk)->conf_state |= L2CAP_CONF_REQ_SENT;
 
-               l2cap_send_cmd(conn, l2cap_get_ident(conn), L2CAP_CONF_REQ,
-                                       l2cap_build_conf_req(sk, req), req);
+               l2cap_send_req(conn, L2CAP_CONF_REQ, l2cap_build_conf_req(sk, req), req);
                break;
 
        case L2CAP_CR_PEND:
@@ -1536,14 +1496,12 @@ static inline int l2cap_config_req(struct l2cap_conn *conn, struct l2cap_cmd_hdr
 
        if (flags & 0x0001) {
                /* Incomplete config. Send empty response. */
-               l2cap_send_cmd(conn, cmd->ident, L2CAP_CONF_RSP,
-                               l2cap_build_conf_rsp(sk, rsp, NULL), rsp);
+               l2cap_send_rsp(conn, cmd->ident, L2CAP_CONF_RSP, l2cap_build_conf_rsp(sk, rsp, NULL), rsp);
                goto unlock;
        }
 
        /* Complete config. */
-       l2cap_send_cmd(conn, cmd->ident, L2CAP_CONF_RSP,
-                       l2cap_build_conf_rsp(sk, rsp, &result), rsp);
+       l2cap_send_rsp(conn, cmd->ident, L2CAP_CONF_RSP, l2cap_build_conf_rsp(sk, rsp, &result), rsp);
 
        if (result)
                goto unlock;
@@ -1556,8 +1514,7 @@ static inline int l2cap_config_req(struct l2cap_conn *conn, struct l2cap_cmd_hdr
                l2cap_chan_ready(sk);
        } else if (!(l2cap_pi(sk)->conf_state & L2CAP_CONF_REQ_SENT)) {
                u8 req[64];
-               l2cap_send_cmd(conn, l2cap_get_ident(conn), L2CAP_CONF_REQ,
-                                       l2cap_build_conf_req(sk, req), req);
+               l2cap_send_req(conn, L2CAP_CONF_REQ, l2cap_build_conf_req(sk, req), req);
        }
 
 unlock:
@@ -1592,8 +1549,8 @@ static inline int l2cap_config_rsp(struct l2cap_conn *conn, struct l2cap_cmd_hdr
                         * resend config request that we sent earlier. It is
                         * stupid, but it helps qualification testing which
                         * expects at least some response from us. */
-                       l2cap_send_cmd(conn, l2cap_get_ident(conn), L2CAP_CONF_REQ,
-                                               l2cap_build_conf_req(sk, req), req);
+                       l2cap_send_req(conn, L2CAP_CONF_REQ,
+                               l2cap_build_conf_req(sk, req), req);
                        goto done;
                }
 
@@ -1605,8 +1562,7 @@ static inline int l2cap_config_rsp(struct l2cap_conn *conn, struct l2cap_cmd_hdr
                        struct l2cap_disconn_req req;
                        req.dcid = __cpu_to_le16(l2cap_pi(sk)->dcid);
                        req.scid = __cpu_to_le16(l2cap_pi(sk)->scid);
-                       l2cap_send_cmd(conn, l2cap_get_ident(conn),
-                                       L2CAP_DISCONN_REQ, sizeof(req), &req);
+                       l2cap_send_req(conn, L2CAP_DISCONN_REQ, sizeof(req), &req);
                }
                goto done;
        }
@@ -1644,7 +1600,7 @@ static inline int l2cap_disconnect_req(struct l2cap_conn *conn, struct l2cap_cmd
 
        rsp.dcid = __cpu_to_le16(l2cap_pi(sk)->scid);
        rsp.scid = __cpu_to_le16(l2cap_pi(sk)->dcid);
-       l2cap_send_cmd(conn, cmd->ident, L2CAP_DISCONN_RSP, sizeof(rsp), &rsp);
+       l2cap_send_rsp(conn, cmd->ident, L2CAP_DISCONN_RSP, sizeof(rsp), &rsp);
 
        sk->sk_shutdown = SHUTDOWN_MASK;
 
@@ -1688,7 +1644,7 @@ static inline int l2cap_information_req(struct l2cap_conn *conn, struct l2cap_cm
 
        rsp.type   = __cpu_to_le16(type);
        rsp.result = __cpu_to_le16(L2CAP_IR_NOTSUPP);
-       l2cap_send_cmd(conn, cmd->ident, L2CAP_INFO_RSP, sizeof(rsp), &rsp);
+       l2cap_send_rsp(conn, cmd->ident, L2CAP_INFO_RSP, sizeof(rsp), &rsp);
 
        return 0;
 }
@@ -1759,7 +1715,7 @@ static inline void l2cap_sig_channel(struct l2cap_conn *conn, struct sk_buff *sk
                        break;
 
                case L2CAP_ECHO_REQ:
-                       l2cap_send_cmd(conn, cmd.ident, L2CAP_ECHO_RSP, cmd.len, data);
+                       l2cap_send_rsp(conn, cmd.ident, L2CAP_ECHO_RSP, cmd.len, data);
                        break;
 
                case L2CAP_ECHO_RSP:
@@ -1785,7 +1741,7 @@ static inline void l2cap_sig_channel(struct l2cap_conn *conn, struct sk_buff *sk
 
                        /* FIXME: Map err to a valid reason */
                        rej.reason = __cpu_to_le16(0);
-                       l2cap_send_cmd(conn, cmd.ident, L2CAP_COMMAND_REJ, sizeof(rej), &rej);
+                       l2cap_send_rsp(conn, cmd.ident, L2CAP_COMMAND_REJ, sizeof(rej), &rej);
                }
 
                data += cmd.len;
@@ -1964,8 +1920,7 @@ static int l2cap_auth_cfm(struct hci_conn *hcon, u8 status)
                bh_lock_sock(sk);
 
                if (sk->sk_state != BT_CONNECT2 ||
-                               (l2cap_pi(sk)->link_mode & L2CAP_LM_ENCRYPT) ||
-                               (l2cap_pi(sk)->link_mode & L2CAP_LM_SECURE)) {
+                               (l2cap_pi(sk)->link_mode & L2CAP_LM_ENCRYPT)) {
                        bh_unlock_sock(sk);
                        continue;
                }
@@ -1983,8 +1938,7 @@ static int l2cap_auth_cfm(struct hci_conn *hcon, u8 status)
                rsp.dcid   = __cpu_to_le16(l2cap_pi(sk)->scid);
                rsp.result = __cpu_to_le16(result);
                rsp.status = __cpu_to_le16(0);
-               l2cap_send_cmd(conn, l2cap_pi(sk)->ident,
-                               L2CAP_CONN_RSP, sizeof(rsp), &rsp);
+               l2cap_send_rsp(conn, l2cap_pi(sk)->ident, L2CAP_CONN_RSP, sizeof(rsp), &rsp);
 
                bh_unlock_sock(sk);
        }
@@ -2030,11 +1984,7 @@ static int l2cap_encrypt_cfm(struct hci_conn *hcon, u8 status)
                rsp.dcid   = __cpu_to_le16(l2cap_pi(sk)->scid);
                rsp.result = __cpu_to_le16(result);
                rsp.status = __cpu_to_le16(0);
-               l2cap_send_cmd(conn, l2cap_pi(sk)->ident,
-                               L2CAP_CONN_RSP, sizeof(rsp), &rsp);
-
-               if (l2cap_pi(sk)->link_mode & L2CAP_LM_SECURE)
-                       hci_conn_change_link_key(hcon);
+               l2cap_send_rsp(conn, l2cap_pi(sk)->ident, L2CAP_CONN_RSP, sizeof(rsp), &rsp);
 
                bh_unlock_sock(sk);
        }
@@ -2061,12 +2011,10 @@ static int l2cap_recv_acldata(struct hci_conn *hcon, struct sk_buff *skb, u16 fl
                        kfree_skb(conn->rx_skb);
                        conn->rx_skb = NULL;
                        conn->rx_len = 0;
-                       l2cap_conn_unreliable(conn, ECOMM);
                }
 
                if (skb->len < 2) {
                        BT_ERR("Frame is too short (len %d)", skb->len);
-                       l2cap_conn_unreliable(conn, ECOMM);
                        goto drop;
                }
 
@@ -2084,7 +2032,6 @@ static int l2cap_recv_acldata(struct hci_conn *hcon, struct sk_buff *skb, u16 fl
                if (skb->len > len) {
                        BT_ERR("Frame is too long (len %d, expected len %d)",
                                skb->len, len);
-                       l2cap_conn_unreliable(conn, ECOMM);
                        goto drop;
                }
 
@@ -2099,7 +2046,6 @@ static int l2cap_recv_acldata(struct hci_conn *hcon, struct sk_buff *skb, u16 fl
 
                if (!conn->rx_len) {
                        BT_ERR("Unexpected continuation frame (len %d)", skb->len);
-                       l2cap_conn_unreliable(conn, ECOMM);
                        goto drop;
                }
 
@@ -2109,7 +2055,6 @@ static int l2cap_recv_acldata(struct hci_conn *hcon, struct sk_buff *skb, u16 fl
                        kfree_skb(conn->rx_skb);
                        conn->rx_skb = NULL;
                        conn->rx_len = 0;
-                       l2cap_conn_unreliable(conn, ECOMM);
                        goto drop;
                }
 
@@ -2291,7 +2236,7 @@ static void __exit l2cap_exit(void)
 void l2cap_load(void)
 {
        /* Dummy function to trigger automatic L2CAP module loading by
-        * other modules that use L2CAP sockets but don't use any other
+        * other modules that use L2CAP sockets but don not use any othe
         * symbols from it. */
        return;
 }