vserver 1.9.5.x5
[linux-2.6.git] / sound / pci / ac97 / ac97_codec.c
index b88a198..188dc95 100644 (file)
@@ -118,9 +118,12 @@ static const ac97_codec_id_t snd_ac97_codec_ids[] = {
 { 0x414c4770, 0xfffffff0, "ALC203",            NULL,           NULL },
 { 0x434d4941, 0xffffffff, "CMI9738",           patch_cm9738,   NULL },
 { 0x434d4961, 0xffffffff, "CMI9739",           patch_cm9739,   NULL },
+{ 0x434d4978, 0xffffffff, "CMI9761",           patch_cm9761,   NULL },
+{ 0x434d4982, 0xffffffff, "CMI9761",           patch_cm9761,   NULL },
+{ 0x434d4983, 0xffffffff, "CMI9761",           patch_cm9761,   NULL },
 { 0x43525900, 0xfffffff8, "CS4297",            NULL,           NULL },
 { 0x43525910, 0xfffffff8, "CS4297A",           patch_cirrus_spdif,     NULL },
-{ 0x43525920, 0xfffffff8, "CS4294/4298",       NULL,           NULL },
+{ 0x43525920, 0xfffffff8, "CS4298",            patch_cirrus_spdif,             NULL },
 { 0x43525928, 0xfffffff8, "CS4294",            NULL,           NULL },
 { 0x43525930, 0xfffffff8, "CS4299",            patch_cirrus_cs4299,    NULL },
 { 0x43525948, 0xfffffff8, "CS4201",            NULL,           NULL },
@@ -329,11 +332,11 @@ void snd_ac97_write_cache(ac97_t *ac97, unsigned short reg, unsigned short value
 {
        if (!snd_ac97_valid_reg(ac97, reg))
                return;
-       spin_lock(&ac97->reg_lock);
+       down(&ac97->reg_mutex);
        ac97->regs[reg] = value;
-       spin_unlock(&ac97->reg_lock);
        ac97->bus->ops->write(ac97, reg, value);
        set_bit(reg, ac97->reg_accessed);
+       up(&ac97->reg_mutex);
 }
 
 /**
@@ -354,14 +357,13 @@ int snd_ac97_update(ac97_t *ac97, unsigned short reg, unsigned short value)
 
        if (!snd_ac97_valid_reg(ac97, reg))
                return -EINVAL;
-       spin_lock(&ac97->reg_lock);
+       down(&ac97->reg_mutex);
        change = ac97->regs[reg] != value;
        if (change) {
                ac97->regs[reg] = value;
-               spin_unlock(&ac97->reg_lock);
                ac97->bus->ops->write(ac97, reg, value);
-       } else
-               spin_unlock(&ac97->reg_lock);
+       }
+       up(&ac97->reg_mutex);
        return change;
 }
 
@@ -381,20 +383,29 @@ int snd_ac97_update(ac97_t *ac97, unsigned short reg, unsigned short value)
 int snd_ac97_update_bits(ac97_t *ac97, unsigned short reg, unsigned short mask, unsigned short value)
 {
        int change;
-       unsigned short old, new;
 
        if (!snd_ac97_valid_reg(ac97, reg))
                return -EINVAL;
-       spin_lock(&ac97->reg_lock);
+       down(&ac97->reg_mutex);
+       change = snd_ac97_update_bits_nolock(ac97, reg, mask, value);
+       up(&ac97->reg_mutex);
+       return change;
+}
+
+/* no lock version - see snd_ac97_updat_bits() */
+int snd_ac97_update_bits_nolock(ac97_t *ac97, unsigned short reg,
+                               unsigned short mask, unsigned short value)
+{
+       int change;
+       unsigned short old, new;
+
        old = snd_ac97_read_cache(ac97, reg);
        new = (old & ~mask) | value;
        change = old != new;
        if (change) {
                ac97->regs[reg] = new;
-               spin_unlock(&ac97->reg_lock);
                ac97->bus->ops->write(ac97, reg, new);
-       } else
-               spin_unlock(&ac97->reg_lock);
+       }
        return change;
 }
 
@@ -403,15 +414,14 @@ static int snd_ac97_ad18xx_update_pcm_bits(ac97_t *ac97, int codec, unsigned sho
        int change;
        unsigned short old, new, cfg;
 
-       down(&ac97->mutex);
-       spin_lock(&ac97->reg_lock);
+       down(&ac97->page_mutex);
        old = ac97->spec.ad18xx.pcmreg[codec];
        new = (old & ~mask) | value;
-       cfg = snd_ac97_read_cache(ac97, AC97_AD_SERIAL_CFG);
        change = old != new;
        if (change) {
+               down(&ac97->reg_mutex);
+               cfg = snd_ac97_read_cache(ac97, AC97_AD_SERIAL_CFG);
                ac97->spec.ad18xx.pcmreg[codec] = new;
-               spin_unlock(&ac97->reg_lock);
                /* select single codec */
                ac97->bus->ops->write(ac97, AC97_AD_SERIAL_CFG,
                                 (cfg & ~0x7000) |
@@ -421,9 +431,9 @@ static int snd_ac97_ad18xx_update_pcm_bits(ac97_t *ac97, int codec, unsigned sho
                /* select all codecs */
                ac97->bus->ops->write(ac97, AC97_AD_SERIAL_CFG,
                                 cfg | 0x7000);
-       } else
-               spin_unlock(&ac97->reg_lock);
-       up(&ac97->mutex);
+               up(&ac97->reg_mutex);
+       }
+       up(&ac97->page_mutex);
        return change;
 }
 
@@ -533,104 +543,70 @@ static int snd_ac97_put_enum_double(snd_kcontrol_t * kcontrol, snd_ctl_elem_valu
        return snd_ac97_update_bits(ac97, reg, 1 << shift, val << shift);
 }
 
-int snd_ac97_info_single(snd_kcontrol_t *kcontrol, snd_ctl_elem_info_t * uinfo)
+int snd_ac97_info_volsw(snd_kcontrol_t *kcontrol, snd_ctl_elem_info_t * uinfo)
 {
        int mask = (kcontrol->private_value >> 16) & 0xff;
+       int shift = (kcontrol->private_value >> 8) & 0x0f;
+       int rshift = (kcontrol->private_value >> 12) & 0x0f;
 
        uinfo->type = mask == 1 ? SNDRV_CTL_ELEM_TYPE_BOOLEAN : SNDRV_CTL_ELEM_TYPE_INTEGER;
-       uinfo->count = 1;
+       uinfo->count = shift == rshift ? 1 : 2;
        uinfo->value.integer.min = 0;
        uinfo->value.integer.max = mask;
        return 0;
 }
 
-int snd_ac97_get_single(snd_kcontrol_t * kcontrol, snd_ctl_elem_value_t * ucontrol)
+int snd_ac97_get_volsw(snd_kcontrol_t * kcontrol, snd_ctl_elem_value_t * ucontrol)
 {
        ac97_t *ac97 = snd_kcontrol_chip(kcontrol);
        int reg = kcontrol->private_value & 0xff;
-       int shift = (kcontrol->private_value >> 8) & 0xff;
+       int shift = (kcontrol->private_value >> 8) & 0x0f;
+       int rshift = (kcontrol->private_value >> 12) & 0x0f;
        int mask = (kcontrol->private_value >> 16) & 0xff;
        int invert = (kcontrol->private_value >> 24) & 0x01;
        
        ucontrol->value.integer.value[0] = (snd_ac97_read_cache(ac97, reg) >> shift) & mask;
-       if (invert)
+       if (shift != rshift)
+               ucontrol->value.integer.value[1] = (snd_ac97_read_cache(ac97, reg) >> rshift) & mask;
+       if (invert) {
                ucontrol->value.integer.value[0] = mask - ucontrol->value.integer.value[0];
+               if (shift != rshift)
+                       ucontrol->value.integer.value[1] = mask - ucontrol->value.integer.value[1];
+       }
        return 0;
 }
 
-int snd_ac97_put_single(snd_kcontrol_t * kcontrol, snd_ctl_elem_value_t * ucontrol)
+int snd_ac97_put_volsw(snd_kcontrol_t * kcontrol, snd_ctl_elem_value_t * ucontrol)
 {
        ac97_t *ac97 = snd_kcontrol_chip(kcontrol);
        int reg = kcontrol->private_value & 0xff;
-       int shift = (kcontrol->private_value >> 8) & 0xff;
+       int shift = (kcontrol->private_value >> 8) & 0x0f;
+       int rshift = (kcontrol->private_value >> 12) & 0x0f;
        int mask = (kcontrol->private_value >> 16) & 0xff;
        int invert = (kcontrol->private_value >> 24) & 0x01;
-       unsigned short val;
+       unsigned short val, val2, val_mask;
        
        val = (ucontrol->value.integer.value[0] & mask);
        if (invert)
                val = mask - val;
-       return snd_ac97_update_bits(ac97, reg, mask << shift, val << shift);
+       val_mask = mask << shift;
+       val = val << shift;
+       if (shift != rshift) {
+               val2 = (ucontrol->value.integer.value[1] & mask);
+               if (invert)
+                       val2 = mask - val2;
+               val_mask |= mask << rshift;
+               val |= val2 << rshift;
+       }
+       return snd_ac97_update_bits(ac97, reg, val_mask, val);
 }
 
 #define AC97_DOUBLE(xname, reg, shift_left, shift_right, mask, invert) \
-{ .iface = SNDRV_CTL_ELEM_IFACE_MIXER, .name = (xname), .info = snd_ac97_info_double, \
-  .get = snd_ac97_get_double, .put = snd_ac97_put_double, \
+{ .iface = SNDRV_CTL_ELEM_IFACE_MIXER, .name = (xname), .info = snd_ac97_info_volsw, \
+  .get = snd_ac97_get_volsw, .put = snd_ac97_put_volsw, \
   .private_value = (reg) | ((shift_left) << 8) | ((shift_right) << 12) | ((mask) << 16) | ((invert) << 24) }
 
-static int snd_ac97_info_double(snd_kcontrol_t *kcontrol, snd_ctl_elem_info_t * uinfo)
-{
-       int mask = (kcontrol->private_value >> 16) & 0xff;
-
-       uinfo->type = mask == 1 ? SNDRV_CTL_ELEM_TYPE_BOOLEAN : SNDRV_CTL_ELEM_TYPE_INTEGER;
-       uinfo->count = 2;
-       uinfo->value.integer.min = 0;
-       uinfo->value.integer.max = mask;
-       return 0;
-}
-
-static int snd_ac97_get_double(snd_kcontrol_t * kcontrol, snd_ctl_elem_value_t * ucontrol)
-{
-       ac97_t *ac97 = snd_kcontrol_chip(kcontrol);
-       int reg = kcontrol->private_value & 0xff;
-       int shift_left = (kcontrol->private_value >> 8) & 0x0f;
-       int shift_right = (kcontrol->private_value >> 12) & 0x0f;
-       int mask = (kcontrol->private_value >> 16) & 0xff;
-       int invert = (kcontrol->private_value >> 24) & 0xff;
-       
-       spin_lock(&ac97->reg_lock);
-       ucontrol->value.integer.value[0] = (snd_ac97_read_cache(ac97, reg) >> shift_left) & mask;
-       ucontrol->value.integer.value[1] = (snd_ac97_read_cache(ac97, reg) >> shift_right) & mask;
-       spin_unlock(&ac97->reg_lock);
-       if (invert) {
-               ucontrol->value.integer.value[0] = mask - ucontrol->value.integer.value[0];
-               ucontrol->value.integer.value[1] = mask - ucontrol->value.integer.value[1];
-       }
-       return 0;
-}
-
-static int snd_ac97_put_double(snd_kcontrol_t * kcontrol, snd_ctl_elem_value_t * ucontrol)
-{
-       ac97_t *ac97 = snd_kcontrol_chip(kcontrol);
-       int reg = kcontrol->private_value & 0xff;
-       int shift_left = (kcontrol->private_value >> 8) & 0x0f;
-       int shift_right = (kcontrol->private_value >> 12) & 0x0f;
-       int mask = (kcontrol->private_value >> 16) & 0xff;
-       int invert = (kcontrol->private_value >> 24) & 0xff;
-       unsigned short val1, val2;
-       
-       val1 = ucontrol->value.integer.value[0] & mask;
-       val2 = ucontrol->value.integer.value[1] & mask;
-       if (invert) {
-               val1 = mask - val1;
-               val2 = mask - val2;
-       }
-       return snd_ac97_update_bits(ac97, reg, 
-                                   (mask << shift_left) | (mask << shift_right),
-                                   (val1 << shift_left) | (val2 << shift_right));
-}
-
-int snd_ac97_getput_page(snd_kcontrol_t *kcontrol, snd_ctl_elem_value_t *ucontrol,
+static int snd_ac97_getput_page(snd_kcontrol_t *kcontrol, snd_ctl_elem_value_t *ucontrol,
                         int (*func)(snd_kcontrol_t *, snd_ctl_elem_value_t *))
 {
        ac97_t *ac97 = snd_kcontrol_chip(kcontrol);
@@ -641,27 +617,27 @@ int snd_ac97_getput_page(snd_kcontrol_t *kcontrol, snd_ctl_elem_value_t *ucontro
            (reg >= 0x60 && reg < 0x70)) {
                unsigned short page_save;
                unsigned short page = (kcontrol->private_value >> 25) & 0x0f;
-               down(&ac97->mutex); /* lock paging */
+               down(&ac97->page_mutex); /* lock paging */
                page_save = snd_ac97_read(ac97, AC97_INT_PAGING) & AC97_PAGE_MASK;
                snd_ac97_update_bits(ac97, AC97_INT_PAGING, AC97_PAGE_MASK, page);
                err = func(kcontrol, ucontrol);
                snd_ac97_update_bits(ac97, AC97_INT_PAGING, AC97_PAGE_MASK, page_save);
-               up(&ac97->mutex); /* unlock paging */
+               up(&ac97->page_mutex); /* unlock paging */
        } else
                err = func(kcontrol, ucontrol);
        return err;
 }
 
 /* for rev2.3 paging */
-int snd_ac97_page_get_single(snd_kcontrol_t *kcontrol, snd_ctl_elem_value_t *ucontrol)
+int snd_ac97_page_get_volsw(snd_kcontrol_t *kcontrol, snd_ctl_elem_value_t *ucontrol)
 {
-       return snd_ac97_getput_page(kcontrol, ucontrol, snd_ac97_get_single);
+       return snd_ac97_getput_page(kcontrol, ucontrol, snd_ac97_get_volsw);
 }
 
 /* for rev2.3 paging */
-int snd_ac97_page_put_single(snd_kcontrol_t *kcontrol, snd_ctl_elem_value_t *ucontrol)
+int snd_ac97_page_put_volsw(snd_kcontrol_t *kcontrol, snd_ctl_elem_value_t *ucontrol)
 {
-       return snd_ac97_getput_page(kcontrol, ucontrol, snd_ac97_put_single);
+       return snd_ac97_getput_page(kcontrol, ucontrol, snd_ac97_put_volsw);
 }
 
 static const snd_kcontrol_new_t snd_ac97_controls_master_mono[2] = {
@@ -679,16 +655,9 @@ AC97_SINGLE("PC Speaker Playback Switch", AC97_PC_BEEP, 15, 1, 1),
 AC97_SINGLE("PC Speaker Playback Volume", AC97_PC_BEEP, 1, 15, 1)
 };
 
-static const snd_kcontrol_new_t snd_ac97_controls_phone[2] = {
-AC97_SINGLE("Phone Playback Switch", AC97_PHONE, 15, 1, 1),
-AC97_SINGLE("Phone Playback Volume", AC97_PHONE, 0, 15, 1)
-};
+static const snd_kcontrol_new_t snd_ac97_controls_mic_boost =
+       AC97_SINGLE("Mic Boost (+20dB)", AC97_MIC, 6, 1, 0);
 
-static const snd_kcontrol_new_t snd_ac97_controls_mic[3] = {
-AC97_SINGLE("Mic Playback Switch", AC97_MIC, 15, 1, 1),
-AC97_SINGLE("Mic Playback Volume", AC97_MIC, 0, 15, 1),
-AC97_SINGLE("Mic Boost (+20dB)", AC97_MIC, 6, 1, 0)
-};
 
 static const snd_kcontrol_new_t snd_ac97_control_capture_src = {
        .iface = SNDRV_CTL_ELEM_IFACE_MIXER,
@@ -749,6 +718,14 @@ AC97_DOUBLE("Surround Playback Volume", AC97_SURROUND_MASTER, 8, 0, 31, 1),
 static const snd_kcontrol_new_t snd_ac97_control_eapd =
 AC97_SINGLE("External Amplifier", AC97_POWERDOWN, 15, 1, 1);
 
+/* change the existing EAPD control as inverted */
+static void set_inv_eapd(ac97_t *ac97, snd_kcontrol_t *kctl)
+{
+       kctl->private_value = AC97_SINGLE_VALUE(AC97_POWERDOWN, 15, 1, 0);
+       snd_ac97_update_bits(ac97, AC97_POWERDOWN, (1<<15), (1<<15)); /* EAPD up */
+       ac97->scaps |= AC97_SCAP_INV_EAPD;
+}
+
 static int snd_ac97_spdif_mask_info(snd_kcontrol_t *kcontrol, snd_ctl_elem_info_t * uinfo)
 {
        uinfo->type = SNDRV_CTL_ELEM_TYPE_IEC958;
@@ -782,12 +759,12 @@ static int snd_ac97_spdif_default_get(snd_kcontrol_t *kcontrol, snd_ctl_elem_val
 {
        ac97_t *ac97 = snd_kcontrol_chip(kcontrol);
 
-       spin_lock(&ac97->reg_lock);
+       down(&ac97->reg_mutex);
        ucontrol->value.iec958.status[0] = ac97->spdif_status & 0xff;
        ucontrol->value.iec958.status[1] = (ac97->spdif_status >> 8) & 0xff;
        ucontrol->value.iec958.status[2] = (ac97->spdif_status >> 16) & 0xff;
        ucontrol->value.iec958.status[3] = (ac97->spdif_status >> 24) & 0xff;
-       spin_unlock(&ac97->reg_lock);
+       up(&ac97->reg_mutex);
        return 0;
 }
                         
@@ -798,7 +775,6 @@ static int snd_ac97_spdif_default_put(snd_kcontrol_t *kcontrol, snd_ctl_elem_val
        unsigned short val = 0;
        int change;
 
-       spin_lock(&ac97->reg_lock);
        new = val = ucontrol->value.iec958.status[0] & (IEC958_AES0_PROFESSIONAL|IEC958_AES0_NONAUDIO);
        if (ucontrol->value.iec958.status[0] & IEC958_AES0_PROFESSIONAL) {
                new |= ucontrol->value.iec958.status[0] & (IEC958_AES0_PRO_FS|IEC958_AES0_PRO_EMPHASIS_5015);
@@ -827,9 +803,9 @@ static int snd_ac97_spdif_default_put(snd_kcontrol_t *kcontrol, snd_ctl_elem_val
                }
        }
 
+       down(&ac97->reg_mutex);
        change = ac97->spdif_status != new;
        ac97->spdif_status = new;
-       spin_unlock(&ac97->reg_lock);
 
        if (ac97->flags & AC97_CS_SPDIF) {
                int x = (val >> 12) & 0x03;
@@ -838,23 +814,24 @@ static int snd_ac97_spdif_default_put(snd_kcontrol_t *kcontrol, snd_ctl_elem_val
                case 2: x = 0; break;  // 48.0
                default: x = 0; break; // illegal.
                }
-               change |= snd_ac97_update_bits(ac97, AC97_CSR_SPDIF, 0x3fff, ((val & 0xcfff) | (x << 12)));
+               change |= snd_ac97_update_bits_nolock(ac97, AC97_CSR_SPDIF, 0x3fff, ((val & 0xcfff) | (x << 12)));
        } else if (ac97->flags & AC97_CX_SPDIF) {
                int v;
                v = new & (IEC958_AES0_CON_EMPHASIS_5015|IEC958_AES0_CON_NOT_COPYRIGHT) ? 0 : AC97_CXR_COPYRGT;
                v |= new & IEC958_AES0_NONAUDIO ? AC97_CXR_SPDIF_AC3 : AC97_CXR_SPDIF_PCM;
-               change |= snd_ac97_update_bits(ac97, AC97_CXR_AUDIO_MISC, 
-                                              AC97_CXR_SPDIF_MASK | AC97_CXR_COPYRGT,
-                                              v);
+               change |= snd_ac97_update_bits_nolock(ac97, AC97_CXR_AUDIO_MISC, 
+                                                     AC97_CXR_SPDIF_MASK | AC97_CXR_COPYRGT,
+                                                     v);
        } else {
                unsigned short extst = snd_ac97_read_cache(ac97, AC97_EXTENDED_STATUS);
-               snd_ac97_update_bits(ac97, AC97_EXTENDED_STATUS, AC97_EA_SPDIF, 0); /* turn off */
+               snd_ac97_update_bits_nolock(ac97, AC97_EXTENDED_STATUS, AC97_EA_SPDIF, 0); /* turn off */
 
-               change |= snd_ac97_update_bits(ac97, AC97_SPDIF, 0x3fff, val);
+               change |= snd_ac97_update_bits_nolock(ac97, AC97_SPDIF, 0x3fff, val);
                if (extst & AC97_EA_SPDIF) {
-                       snd_ac97_update_bits(ac97, AC97_EXTENDED_STATUS, AC97_EA_SPDIF, AC97_EA_SPDIF); /* turn on again */
+                       snd_ac97_update_bits_nolock(ac97, AC97_EXTENDED_STATUS, AC97_EA_SPDIF, AC97_EA_SPDIF); /* turn on again */
                 }
        }
+       up(&ac97->reg_mutex);
 
        return change;
 }
@@ -867,26 +844,26 @@ static int snd_ac97_put_spsa(snd_kcontrol_t *kcontrol, snd_ctl_elem_value_t *uco
        int mask = (kcontrol->private_value >> 16) & 0xff;
        // int invert = (kcontrol->private_value >> 24) & 0xff;
        unsigned short value, old, new;
+       int change;
 
        value = (ucontrol->value.integer.value[0] & mask);
 
+       down(&ac97->reg_mutex);
        mask <<= shift;
        value <<= shift;
-       spin_lock(&ac97->reg_lock);
        old = snd_ac97_read_cache(ac97, reg);
        new = (old & ~mask) | value;
-       spin_unlock(&ac97->reg_lock);
+       change = old != new;
 
-       if (old != new) {
-               int change;
+       if (change) {
                unsigned short extst = snd_ac97_read_cache(ac97, AC97_EXTENDED_STATUS);
-               snd_ac97_update_bits(ac97, AC97_EXTENDED_STATUS, AC97_EA_SPDIF, 0); /* turn off */
-               change = snd_ac97_update_bits(ac97, reg, mask, value);
+               snd_ac97_update_bits_nolock(ac97, AC97_EXTENDED_STATUS, AC97_EA_SPDIF, 0); /* turn off */
+               change = snd_ac97_update_bits_nolock(ac97, reg, mask, value);
                if (extst & AC97_EA_SPDIF)
-                       snd_ac97_update_bits(ac97, AC97_EXTENDED_STATUS, AC97_EA_SPDIF, AC97_EA_SPDIF); /* turn on again */
-               return change;
+                       snd_ac97_update_bits_nolock(ac97, AC97_EXTENDED_STATUS, AC97_EA_SPDIF, AC97_EA_SPDIF); /* turn on again */
        }
-       return 0;
+       up(&ac97->reg_mutex);
+       return change;
 }
 
 const snd_kcontrol_new_t snd_ac97_controls_spdif[5] = {
@@ -916,8 +893,8 @@ const snd_kcontrol_new_t snd_ac97_controls_spdif[5] = {
        {
                .iface = SNDRV_CTL_ELEM_IFACE_MIXER,
                .name = SNDRV_CTL_NAME_IEC958("",PLAYBACK,NONE) "AC97-SPSA",
-               .info = snd_ac97_info_single,
-               .get = snd_ac97_get_single,
+               .info = snd_ac97_info_volsw,
+               .get = snd_ac97_get_volsw,
                .put = snd_ac97_put_spsa,
                .private_value = AC97_SINGLE_VALUE(AC97_EXTENDED_STATUS, 4, 3, 0)
        },
@@ -996,10 +973,10 @@ static int snd_ac97_ad18xx_pcm_get_volume(snd_kcontrol_t * kcontrol, snd_ctl_ele
        ac97_t *ac97 = snd_kcontrol_chip(kcontrol);
        int codec = kcontrol->private_value & 3;
        
-       spin_lock(&ac97->reg_lock);
+       down(&ac97->page_mutex);
        ucontrol->value.integer.value[0] = 31 - ((ac97->spec.ad18xx.pcmreg[codec] >> 0) & 31);
        ucontrol->value.integer.value[1] = 31 - ((ac97->spec.ad18xx.pcmreg[codec] >> 8) & 31);
-       spin_unlock(&ac97->reg_lock);
+       up(&ac97->page_mutex);
        return 0;
 }
 
@@ -1044,8 +1021,7 @@ static int snd_ac97_bus_free(ac97_bus_t *bus)
 {
        if (bus) {
                snd_ac97_bus_proc_done(bus);
-               if (bus->pcms)
-                       kfree(bus->pcms);
+               kfree(bus->pcms);
                if (bus->private_free)
                        bus->private_free(bus);
                kfree(bus);
@@ -1137,6 +1113,26 @@ static int snd_ac97_try_volume_mix(ac97_t * ac97, int reg)
        return 1;               /* success, useable */
 }
 
+static void check_volume_resolution(ac97_t *ac97, int reg, unsigned char *lo_max, unsigned char *hi_max)
+{
+       unsigned short cbit[3] = { 0x20, 0x10, 0x01 };
+       unsigned char max[3] = { 63, 31, 15 };
+       int i;
+
+       *lo_max = *hi_max = 0;
+       for (i = 0 ; i < ARRAY_SIZE(cbit); i++) {
+               unsigned short val;
+               snd_ac97_write(ac97, reg, 0x8080 | cbit[i] | (cbit[i] << 8));
+               val = snd_ac97_read(ac97, reg);
+               if (! *lo_max && (val & cbit[i]))
+                       *lo_max = max[i];
+               if (! *hi_max && (val & (cbit[i] << 8)))
+                       *hi_max = max[i];
+               if (*lo_max && *hi_max)
+                       break;
+       }
+}
+
 int snd_ac97_try_bit(ac97_t * ac97, int reg, int bit)
 {
        unsigned short mask, val, orig, res;
@@ -1150,21 +1146,6 @@ int snd_ac97_try_bit(ac97_t * ac97, int reg, int bit)
        return res == val;
 }
 
-static void snd_ac97_change_volume_params1(ac97_t * ac97, int reg, unsigned char *max)
-{
-       unsigned short val, val1;
-
-       *max = 63;
-       val = 0x8000 | 0x0020;
-       snd_ac97_write(ac97, reg, val);
-       val1 = snd_ac97_read(ac97, reg);
-       if (val != val1) {
-               *max = 31;
-       }
-       /* reset volume to zero */
-       snd_ac97_write_cache(ac97, reg, 0x8000);
-}
-
 /* check the volume resolution of center/lfe */
 static void snd_ac97_change_volume_params2(ac97_t * ac97, int reg, int shift, unsigned char *max)
 {
@@ -1181,34 +1162,6 @@ static void snd_ac97_change_volume_params2(ac97_t * ac97, int reg, int shift, un
        snd_ac97_write_cache(ac97, reg, 0x8080);
 }
 
-/* check whether the volume resolution is 4 or 5 bits */
-static void snd_ac97_change_volume_params3(ac97_t * ac97, int reg, unsigned char *max)
-{
-       unsigned short val, val1;
-
-       *max = 31;
-       val = 0x8000 | 0x0010;
-       snd_ac97_write(ac97, reg, val);
-       val1 = snd_ac97_read(ac97, reg);
-       if (val != val1) {
-               *max = 15;
-       }
-       /* reset volume to zero */
-       snd_ac97_write_cache(ac97, reg, 0x8000);
-}
-
-/* check whether the volume is mono or stereo */
-static int snd_ac97_is_stereo_vol(ac97_t *ac97, int reg)
-{
-       unsigned short val, val1, val2;
-       val = snd_ac97_read(ac97, reg);
-       val1 = val | 0x8000 | (0x01 << 8);
-       snd_ac97_write(ac97, reg, val1);
-       val2 = snd_ac97_read(ac97, reg);
-       snd_ac97_write(ac97, reg, val); /* restore */
-       return val1 == val2;
-}
-
 static inline int printable(unsigned int x)
 {
        x &= 0xff;
@@ -1232,25 +1185,25 @@ snd_kcontrol_t *snd_ac97_cnew(const snd_kcontrol_new_t *_template, ac97_t * ac97
 /*
  * create mute switch(es) for normal stereo controls
  */
-static int snd_ac97_cmute_new(snd_card_t *card, char *name, int reg, ac97_t *ac97)
+static int snd_ac97_cmute_new_stereo(snd_card_t *card, char *name, int reg, int check_stereo, ac97_t *ac97)
 {
        snd_kcontrol_t *kctl;
-       int stereo = 0;
+       int err;
+       unsigned short val, val1, mute_mask;
 
        if (! snd_ac97_valid_reg(ac97, reg))
                return 0;
 
-       if (ac97->flags & AC97_STEREO_MUTES) {
+       mute_mask = 0x8000;
+       val = snd_ac97_read(ac97, reg);
+       if (check_stereo || (ac97->flags & AC97_STEREO_MUTES)) {
                /* check whether both mute bits work */
-               unsigned short val, val1;
-               val = snd_ac97_read(ac97, reg);
                val1 = val | 0x8080;
                snd_ac97_write(ac97, reg, val1);
                if (val1 == snd_ac97_read(ac97, reg))
-                       stereo = 1;
-               snd_ac97_write(ac97, reg, val);
+                       mute_mask = 0x8080;
        }
-       if (stereo) {
+       if (mute_mask == 0x8080) {
                snd_kcontrol_new_t tmp = AC97_DOUBLE(name, reg, 15, 7, 1, 1);
                tmp.index = ac97->num;
                kctl = snd_ctl_new1(&tmp, ac97);
@@ -1259,53 +1212,73 @@ static int snd_ac97_cmute_new(snd_card_t *card, char *name, int reg, ac97_t *ac9
                tmp.index = ac97->num;
                kctl = snd_ctl_new1(&tmp, ac97);
        }
-       return snd_ctl_add(card, kctl);
+       err = snd_ctl_add(card, kctl);
+       if (err < 0)
+               return err;
+       /* mute as default */
+       snd_ac97_write_cache(ac97, reg, val | mute_mask);
+       return 0;
 }
 
 /*
- * create volumes for normal stereo controls
+ * create a volume for normal stereo/mono controls
  */
-static int snd_ac97_cvol_new(snd_card_t *card, char *name, int reg, unsigned int max, ac97_t *ac97)
+static int snd_ac97_cvol_new(snd_card_t *card, char *name, int reg, unsigned int lo_max,
+                            unsigned int hi_max, ac97_t *ac97)
 {
        int err;
-       snd_kcontrol_new_t tmp = AC97_DOUBLE(name, reg, 8, 0, (unsigned int)max, 1);
-       tmp.index = ac97->num;
+       snd_kcontrol_t *kctl;
 
        if (! snd_ac97_valid_reg(ac97, reg))
                return 0;
-       if ((err = snd_ctl_add(card, snd_ctl_new1(&tmp, ac97))) < 0)
+       if (hi_max) {
+               /* invert */
+               snd_kcontrol_new_t tmp = AC97_DOUBLE(name, reg, 8, 0, lo_max, 1);
+               tmp.index = ac97->num;
+               kctl = snd_ctl_new1(&tmp, ac97);
+       } else {
+               /* invert */
+               snd_kcontrol_new_t tmp = AC97_SINGLE(name, reg, 0, lo_max, 1);
+               tmp.index = ac97->num;
+               kctl = snd_ctl_new1(&tmp, ac97);
+       }
+       err = snd_ctl_add(card, kctl);
+       if (err < 0)
                return err;
        snd_ac97_write_cache(ac97, reg,
-                            ((ac97->flags & AC97_STEREO_MUTES) ? 0x8080 : 0x8000) |
-                            (unsigned short)max | ((unsigned short)max << 8));
+                            (snd_ac97_read(ac97, reg) & 0x8080) |
+                            lo_max | (hi_max << 8));
        return 0;
 }
 
 /*
- * create mute-switch and volumes for normal stereo controls
+ * create a mute-switch and a volume for normal stereo/mono controls
  */
-static int snd_ac97_cmix_new(snd_card_t *card, const char *pfx, int reg, int check_res, ac97_t *ac97)
+static int snd_ac97_cmix_new_stereo(snd_card_t *card, const char *pfx, int reg, int check_stereo, ac97_t *ac97)
 {
        int err;
        char name[44];
-       unsigned char max;
+       unsigned char lo_max, hi_max;
 
        if (! snd_ac97_valid_reg(ac97, reg))
                return 0;
 
-       sprintf(name, "%s Switch", pfx);
-       if ((err = snd_ac97_cmute_new(card, name, reg, ac97)) < 0)
-               return err;
-       sprintf(name, "%s Volume", pfx);
-       if (check_res)
-               snd_ac97_change_volume_params1(ac97, reg, &max);
-       else
-               max = 31; /* 5bit */
-       if ((err = snd_ac97_cvol_new(card, name, reg, max, ac97)) < 0)
-               return err;
+       if (snd_ac97_try_bit(ac97, reg, 15)) {
+               sprintf(name, "%s Switch", pfx);
+               if ((err = snd_ac97_cmute_new_stereo(card, name, reg, check_stereo, ac97)) < 0)
+                       return err;
+       }
+       check_volume_resolution(ac97, reg, &lo_max, &hi_max);
+       if (lo_max) {
+               sprintf(name, "%s Volume", pfx);
+               if ((err = snd_ac97_cvol_new(card, name, reg, lo_max, hi_max, ac97)) < 0)
+                       return err;
+       }
        return 0;
 }
 
+#define snd_ac97_cmix_new(card, pfx, reg, ac97)        snd_ac97_cmix_new_stereo(card, pfx, reg, 0, ac97)
+#define snd_ac97_cmute_new(card, name, reg, ac97)      snd_ac97_cmute_new_stereo(card, name, reg, 0, ac97)
 
 static unsigned int snd_ac97_determine_spdif_rates(ac97_t *ac97);
 
@@ -1320,7 +1293,11 @@ static int snd_ac97_mixer_build(ac97_t * ac97)
        /* build master controls */
        /* AD claims to remove this control from AD1887, although spec v2.2 does not allow this */
        if (snd_ac97_try_volume_mix(ac97, AC97_MASTER)) {
-               if ((err = snd_ac97_cmix_new(card, "Master Playback", AC97_MASTER, 1, ac97)) < 0)
+               if (ac97->flags & AC97_HAS_NO_MASTER_VOL)
+                       err = snd_ac97_cmute_new(card, "Master Playback Switch", AC97_MASTER, ac97);
+               else
+                       err = snd_ac97_cmix_new(card, "Master Playback", AC97_MASTER, ac97);
+               if (err < 0)
                        return err;
        }
 
@@ -1352,32 +1329,21 @@ static int snd_ac97_mixer_build(ac97_t * ac97)
 
        /* build surround controls */
        if (snd_ac97_try_volume_mix(ac97, AC97_SURROUND_MASTER)) {
-               if ((err = snd_ctl_add(card, snd_ac97_cnew(&snd_ac97_controls_surround[0], ac97))) < 0)
+               /* Surround Master (0x38) is with stereo mutes */
+               if ((err = snd_ac97_cmix_new_stereo(card, "Surround Playback", AC97_SURROUND_MASTER, 1, ac97)) < 0)
                        return err;
-               if ((err = snd_ctl_add(card, kctl = snd_ac97_cnew(&snd_ac97_controls_surround[1], ac97))) < 0)
-                       return err;
-               snd_ac97_change_volume_params2(ac97, AC97_SURROUND_MASTER, 0, &max);
-               kctl->private_value &= ~(0xff << 16);
-               kctl->private_value |= (int)max << 16;
-               snd_ac97_write_cache(ac97, AC97_SURROUND_MASTER, 0x8080 | max | (max << 8));
        }
 
        /* build headphone controls */
        if (snd_ac97_try_volume_mix(ac97, AC97_HEADPHONE)) {
-               if ((err = snd_ac97_cmix_new(card, "Headphone Playback", AC97_HEADPHONE, 1, ac97)) < 0)
+               if ((err = snd_ac97_cmix_new(card, "Headphone Playback", AC97_HEADPHONE, ac97)) < 0)
                        return err;
        }
        
        /* build master mono controls */
        if (snd_ac97_try_volume_mix(ac97, AC97_MASTER_MONO)) {
-               if ((err = snd_ctl_add(card, snd_ac97_cnew(&snd_ac97_controls_master_mono[0], ac97))) < 0)
+               if ((err = snd_ac97_cmix_new(card, "Master Mono Playback", AC97_MASTER_MONO, ac97)) < 0)
                        return err;
-               if ((err = snd_ctl_add(card, kctl = snd_ac97_cnew(&snd_ac97_controls_master_mono[1], ac97))) < 0)
-                       return err;
-               snd_ac97_change_volume_params1(ac97, AC97_MASTER_MONO, &max);
-               kctl->private_value &= ~(0xff << 16);
-               kctl->private_value |= (int)max << 16;
-               snd_ac97_write_cache(ac97, AC97_MASTER_MONO, 0x8000 | max);
        }
        
        /* build master tone controls */
@@ -1405,56 +1371,39 @@ static int snd_ac97_mixer_build(ac97_t * ac97)
        
        /* build Phone controls */
        if (snd_ac97_try_volume_mix(ac97, AC97_PHONE)) {
-               if ((err = snd_ctl_add(card, snd_ac97_cnew(&snd_ac97_controls_phone[0], ac97))) < 0)
-                       return err;
-               if ((err = snd_ctl_add(card, kctl = snd_ac97_cnew(&snd_ac97_controls_phone[1], ac97))) < 0)
+               if ((err = snd_ac97_cmix_new(card, "Phone Playback", AC97_PHONE, ac97)) < 0)
                        return err;
-               snd_ac97_change_volume_params3(ac97, AC97_PHONE, &max);
-               kctl->private_value &= ~(0xff << 16);
-               kctl->private_value |= (int)max << 16;
-               snd_ac97_write_cache(ac97, AC97_PHONE, 0x8000 | max);
        }
        
        /* build MIC controls */
-       snd_ac97_change_volume_params3(ac97, AC97_MIC, &max);
-       if (snd_ac97_is_stereo_vol(ac97, AC97_MIC)) {
-               /* build stereo mic */
-               if ((err = snd_ac97_cmute_new(card, "Mic Playback Switch", AC97_MIC, ac97)) < 0)
+       if (snd_ac97_try_volume_mix(ac97, AC97_MIC)) {
+               if ((err = snd_ac97_cmix_new(card, "Mic Playback", AC97_MIC, ac97)) < 0)
                        return err;
-               if ((err = snd_ac97_cvol_new(card, "Mic Playback Volume", AC97_MIC, max, ac97)) < 0)
+               if ((err = snd_ctl_add(card, snd_ac97_cnew(&snd_ac97_controls_mic_boost, ac97))) < 0)
                        return err;
-               if ((err = snd_ctl_add(card, snd_ac97_cnew(&snd_ac97_controls_mic[2], ac97))) < 0)
-                       return err;
-       } else {
-               /* build mono mic */
-               for (idx = 0; idx < 3; idx++) {
-                       if ((err = snd_ctl_add(card, kctl = snd_ac97_cnew(&snd_ac97_controls_mic[idx], ac97))) < 0)
-                               return err;
-                       if (idx == 1) {         // volume
-                               kctl->private_value &= ~(0xff << 16);
-                               kctl->private_value |= (int)max << 16;
-                       }
-               }
-               snd_ac97_write_cache(ac97, AC97_MIC, 0x8000 | max);
        }
 
        /* build Line controls */
-       if ((err = snd_ac97_cmix_new(card, "Line Playback", AC97_LINE, 0, ac97)) < 0)
-               return err;
+       if (snd_ac97_try_volume_mix(ac97, AC97_LINE)) {
+               if ((err = snd_ac97_cmix_new(card, "Line Playback", AC97_LINE, ac97)) < 0)
+                       return err;
+       }
        
        /* build CD controls */
-       if ((err = snd_ac97_cmix_new(card, "CD Playback", AC97_CD, 0, ac97)) < 0)
-               return err;
+       if (snd_ac97_try_volume_mix(ac97, AC97_CD)) {
+               if ((err = snd_ac97_cmix_new(card, "CD Playback", AC97_CD, ac97)) < 0)
+                       return err;
+       }
        
        /* build Video controls */
        if (snd_ac97_try_volume_mix(ac97, AC97_VIDEO)) {
-               if ((err = snd_ac97_cmix_new(card, "Video Playback", AC97_VIDEO, 0, ac97)) < 0)
+               if ((err = snd_ac97_cmix_new(card, "Video Playback", AC97_VIDEO, ac97)) < 0)
                        return err;
        }
 
        /* build Aux controls */
        if (snd_ac97_try_volume_mix(ac97, AC97_AUX)) {
-               if ((err = snd_ac97_cmix_new(card, "Aux Playback", AC97_AUX, 0, ac97)) < 0)
+               if ((err = snd_ac97_cmix_new(card, "Aux Playback", AC97_AUX, ac97)) < 0)
                        return err;
        }
 
@@ -1486,15 +1435,12 @@ static int snd_ac97_mixer_build(ac97_t * ac97)
                }
                snd_ac97_write_cache(ac97, AC97_PCM, init_val);
        } else {
-               if ((err = snd_ac97_cmute_new(card, "PCM Playback Switch", AC97_PCM, ac97)) < 0)
+               if (ac97->flags & AC97_HAS_NO_PCM_VOL)
+                       err = snd_ac97_cmute_new(card, "PCM Playback Switch", AC97_PCM, ac97);
+               else
+                       err = snd_ac97_cmix_new(card, "PCM Playback", AC97_PCM, ac97);
+               if (err < 0)
                        return err;
-               /* FIXME: C-Media chips have no PCM volume!! */
-               if (ac97->id == AC97_ID_CM9739)
-                       snd_ac97_write_cache(ac97, AC97_PCM, 0x9f1f);
-               else {
-                       if ((err = snd_ac97_cvol_new(card, "PCM Playback Volume", AC97_PCM, 31, ac97)) < 0)
-                               return err;
-               }
        }
 
        /* build Capture controls */
@@ -1559,10 +1505,10 @@ static int snd_ac97_mixer_build(ac97_t * ac97)
                        return err;
        }
 
-       snd_ac97_write_cache(ac97, AC97_GENERAL_PURPOSE, 0x0000);
+       snd_ac97_update_bits(ac97, AC97_GENERAL_PURPOSE, ~AC97_GP_DRSS_MASK, 0x0000);
 
        /* build 3D controls */
-       if (ac97->build_ops && ac97->build_ops->build_3d) {
+       if (ac97->build_ops->build_3d) {
                ac97->build_ops->build_3d(ac97);
        } else {
                if (snd_ac97_try_volume_mix(ac97, AC97_3D_CONTROL)) {
@@ -1585,14 +1531,14 @@ static int snd_ac97_mixer_build(ac97_t * ac97)
 
        /* build S/PDIF controls */
        if (ac97->ext_id & AC97_EI_SPDIF) {
-               if (ac97->build_ops && ac97->build_ops->build_spdif) {
+               if (ac97->build_ops->build_spdif) {
                        if ((err = ac97->build_ops->build_spdif(ac97)) < 0)
                                return err;
                } else {
                        for (idx = 0; idx < 5; idx++)
                                if ((err = snd_ctl_add(card, snd_ac97_cnew(&snd_ac97_controls_spdif[idx], ac97))) < 0)
                                        return err;
-                       if (ac97->build_ops && ac97->build_ops->build_post_spdif) {
+                       if (ac97->build_ops->build_post_spdif) {
                                if ((err = ac97->build_ops->build_post_spdif(ac97)) < 0)
                                        return err;
                        }
@@ -1605,12 +1551,17 @@ static int snd_ac97_mixer_build(ac97_t * ac97)
        }
        
        /* build chip specific controls */
-       if (ac97->build_ops && ac97->build_ops->build_specific)
+       if (ac97->build_ops->build_specific)
                if ((err = ac97->build_ops->build_specific(ac97)) < 0)
                        return err;
 
        if (snd_ac97_try_bit(ac97, AC97_POWERDOWN, 15)) {
-               if ((err = snd_ctl_add(card, snd_ac97_cnew(&snd_ac97_control_eapd, ac97))) < 0)
+               kctl = snd_ac97_cnew(&snd_ac97_control_eapd, ac97);
+               if (! kctl)
+                       return -ENOMEM;
+               if (ac97->scaps & AC97_SCAP_INV_EAPD)
+                       set_inv_eapd(ac97, kctl);
+               if ((err = snd_ctl_add(card, kctl)) < 0)
                        return err;
        }
 
@@ -1646,6 +1597,17 @@ static void snd_ac97_determine_rates(ac97_t *ac97, int reg, int shadow_reg, unsi
 {
        unsigned int result = 0;
 
+       if (ac97->bus->no_vra) {
+               *r_result = SNDRV_PCM_RATE_48000;
+               if ((ac97->flags & AC97_DOUBLE_RATE) &&
+                   reg == AC97_PCM_FRONT_DAC_RATE)
+                       *r_result |= SNDRV_PCM_RATE_96000;
+               return;
+       }
+
+       if ((ac97->ext_id & AC97_EI_DRA) && reg == AC97_PCM_FRONT_DAC_RATE)
+               snd_ac97_update_bits(ac97, AC97_EXTENDED_STATUS,
+                                    AC97_EA_DRA, 0);
        /* test a non-standard rate */
        if (snd_ac97_test_rate(ac97, reg, shadow_reg, 11000))
                result |= SNDRV_PCM_RATE_CONTINUOUS;
@@ -1664,6 +1626,23 @@ static void snd_ac97_determine_rates(ac97_t *ac97, int reg, int shadow_reg, unsi
                result |= SNDRV_PCM_RATE_44100;
        if (snd_ac97_test_rate(ac97, reg, shadow_reg, 48000))
                result |= SNDRV_PCM_RATE_48000;
+       if ((ac97->flags & AC97_DOUBLE_RATE) &&
+           reg == AC97_PCM_FRONT_DAC_RATE) {
+               /* test standard double rates */
+               snd_ac97_update_bits(ac97, AC97_EXTENDED_STATUS,
+                                    AC97_EA_DRA, AC97_EA_DRA);
+               if (snd_ac97_test_rate(ac97, reg, shadow_reg, 64000 / 2))
+                       result |= SNDRV_PCM_RATE_64000;
+               if (snd_ac97_test_rate(ac97, reg, shadow_reg, 88200 / 2))
+                       result |= SNDRV_PCM_RATE_88200;
+               if (snd_ac97_test_rate(ac97, reg, shadow_reg, 96000 / 2))
+                       result |= SNDRV_PCM_RATE_96000;
+               /* some codecs don't support variable double rates */
+               if (!snd_ac97_test_rate(ac97, reg, shadow_reg, 76100 / 2))
+                       result &= ~SNDRV_PCM_RATE_CONTINUOUS;
+               snd_ac97_update_bits(ac97, AC97_EXTENDED_STATUS,
+                                    AC97_EA_DRA, 0);
+       }
        *r_result = result;
 }
 
@@ -1726,6 +1705,22 @@ void snd_ac97_get_name(ac97_t *ac97, unsigned int id, char *name, int modem)
        sprintf(name + strlen(name), " id %x", id & 0xff);
 }
 
+/**
+ * snd_ac97_get_short_name - retrieve codec name
+ * @ac97: the codec instance
+ *
+ * Returns the short identifying name of the codec.
+ */
+const char *snd_ac97_get_short_name(ac97_t *ac97)
+{
+       const ac97_codec_id_t *pid;
+
+       for (pid = snd_ac97_codec_ids; pid->id; pid++)
+               if (pid->id == (ac97->id & pid->mask))
+                       return pid->name;
+       return "unknown codec";
+}
+
 
 /* wait for a while until registers are accessible after RESET
  * return 0 if ok, negative not ready
@@ -1733,9 +1728,10 @@ void snd_ac97_get_name(ac97_t *ac97, unsigned int id, char *name, int modem)
 static int ac97_reset_wait(ac97_t *ac97, int timeout, int with_modem)
 {
        unsigned long end_time;
+       unsigned short val;
+
        end_time = jiffies + timeout;
        do {
-               unsigned short ext_mid;
                
                /* use preliminary reads to settle the communication */
                snd_ac97_read(ac97, AC97_RESET);
@@ -1743,17 +1739,24 @@ static int ac97_reset_wait(ac97_t *ac97, int timeout, int with_modem)
                snd_ac97_read(ac97, AC97_VENDOR_ID2);
                /* modem? */
                if (with_modem) {
-                       ext_mid = snd_ac97_read(ac97, AC97_EXTENDED_MID);
-                       if (ext_mid != 0xffff && (ext_mid & 1) != 0)
+                       val = snd_ac97_read(ac97, AC97_EXTENDED_MID);
+                       if (val != 0xffff && (val & 1) != 0)
+                               return 0;
+               }
+               if (ac97->scaps & AC97_SCAP_DETECT_BY_VENDOR) {
+                       /* probably only Xbox issue - all registers are read as zero */
+                       val = snd_ac97_read(ac97, AC97_VENDOR_ID1);
+                       if (val != 0 && val != 0xffff)
+                               return 0;
+               } else {
+                       /* because the PCM or MASTER volume registers can be modified,
+                        * the REC_GAIN register is used for tests
+                        */
+                       /* test if we can write to the record gain volume register */
+                       snd_ac97_write_cache(ac97, AC97_REC_GAIN, 0x8a05);
+                       if ((snd_ac97_read(ac97, AC97_REC_GAIN) & 0x7fff) == 0x0a05)
                                return 0;
                }
-               /* because the PCM or MASTER volume registers can be modified,
-                * the REC_GAIN register is used for tests
-                */
-               /* test if we can write to the record gain volume register */
-               snd_ac97_write_cache(ac97, AC97_REC_GAIN, 0x8a05);
-               if ((snd_ac97_read(ac97, AC97_REC_GAIN) & 0x7fff) == 0x0a05)
-                       return 0;
                set_current_state(TASK_UNINTERRUPTIBLE);
                schedule_timeout(1);
        } while (time_after_eq(end_time, jiffies));
@@ -1803,7 +1806,7 @@ int snd_ac97_bus(snd_card_t *card, int num, ac97_bus_ops_t *ops,
        bus->clock = 48000;
        spin_lock_init(&bus->bus_lock);
        snd_ac97_bus_proc_init(bus);
-       if ((err = snd_device_new(card, SNDRV_DEV_LOWLEVEL, bus, &dev_ops)) < 0) {
+       if ((err = snd_device_new(card, SNDRV_DEV_BUS, bus, &dev_ops)) < 0) {
                snd_ac97_bus_free(bus);
                return err;
        }
@@ -1811,6 +1814,9 @@ int snd_ac97_bus(snd_card_t *card, int num, ac97_bus_ops_t *ops,
        return 0;
 }
 
+/* build_ops to do nothing */
+static struct snd_ac97_build_ops null_build_ops;
+
 /**
  * snd_ac97_mixer - create an Codec97 component
  * @bus: the AC97 bus which codec is attached to
@@ -1876,8 +1882,8 @@ int snd_ac97_mixer(ac97_bus_t *bus, ac97_template_t *template, ac97_t **rac97)
        ac97->limited_regs = template->limited_regs;
        memcpy(ac97->reg_accessed, template->reg_accessed, sizeof(ac97->reg_accessed));
        bus->codec[ac97->num] = ac97;
-       spin_lock_init(&ac97->reg_lock);
-       init_MUTEX(&ac97->mutex);
+       init_MUTEX(&ac97->reg_mutex);
+       init_MUTEX(&ac97->page_mutex);
 
        if (ac97->pci) {
                pci_read_config_word(ac97->pci, PCI_SUBSYSTEM_VENDOR_ID, &ac97->subsystem_vendor);
@@ -1908,7 +1914,8 @@ int snd_ac97_mixer(ac97_bus_t *bus, ac97_template_t *template, ac97_t **rac97)
       __access_ok:
        ac97->id = snd_ac97_read(ac97, AC97_VENDOR_ID1) << 16;
        ac97->id |= snd_ac97_read(ac97, AC97_VENDOR_ID2);
-       if (ac97->id == 0x00000000 || ac97->id == 0xffffffff) {
+       if (! (ac97->scaps & AC97_SCAP_DETECT_BY_VENDOR) &&
+           (ac97->id == 0x00000000 || ac97->id == 0xffffffff)) {
                snd_printk(KERN_ERR "AC'97 %d access is not valid [0x%x], removing mixer.\n", ac97->num, ac97->id);
                snd_ac97_free(ac97);
                return -EIO;
@@ -2004,13 +2011,27 @@ int snd_ac97_mixer(ac97_bus_t *bus, ac97_template_t *template, ac97_t **rac97)
                ac97->addr = (ac97->ext_id & AC97_EI_ADDR_MASK) >> AC97_EI_ADDR_SHIFT;
        else
                ac97->addr = (ac97->ext_mid & AC97_MEI_ADDR_MASK) >> AC97_MEI_ADDR_SHIFT;
-       if (ac97->ext_id & 0x0189)      /* L/R, MIC, SDAC, LDAC VRA support */
-               snd_ac97_write_cache(ac97, AC97_EXTENDED_STATUS, ac97->ext_id & 0x0189);
+       if (ac97->ext_id & 0x01c9) {    /* L/R, MIC, SDAC, LDAC VRA support */
+               reg = snd_ac97_read(ac97, AC97_EXTENDED_STATUS);
+               reg |= ac97->ext_id & 0x01c0; /* LDAC/SDAC/CDAC */
+               if (! bus->no_vra)
+                       reg |= ac97->ext_id & 0x0009; /* VRA/VRM */
+               snd_ac97_write_cache(ac97, AC97_EXTENDED_STATUS, reg);
+       }
+       if ((ac97->ext_id & AC97_EI_DRA) && bus->dra) {
+               /* Intel controllers require double rate data to be put in
+                * slots 7+8, so let's hope the codec supports it. */
+               snd_ac97_update_bits(ac97, AC97_GENERAL_PURPOSE, AC97_GP_DRSS_MASK, AC97_GP_DRSS_78);
+               if ((snd_ac97_read(ac97, AC97_GENERAL_PURPOSE) & AC97_GP_DRSS_MASK) == AC97_GP_DRSS_78)
+                       ac97->flags |= AC97_DOUBLE_RATE;
+       }
        if (ac97->ext_id & AC97_EI_VRA) {       /* VRA support */
                snd_ac97_determine_rates(ac97, AC97_PCM_FRONT_DAC_RATE, 0, &ac97->rates[AC97_RATES_FRONT_DAC]);
                snd_ac97_determine_rates(ac97, AC97_PCM_LR_ADC_RATE, 0, &ac97->rates[AC97_RATES_ADC]);
        } else {
                ac97->rates[AC97_RATES_FRONT_DAC] = SNDRV_PCM_RATE_48000;
+               if (ac97->flags & AC97_DOUBLE_RATE)
+                       ac97->rates[AC97_RATES_FRONT_DAC] |= SNDRV_PCM_RATE_96000;
                ac97->rates[AC97_RATES_ADC] = SNDRV_PCM_RATE_48000;
        }
        if (ac97->ext_id & AC97_EI_SPDIF) {
@@ -2035,7 +2056,11 @@ int snd_ac97_mixer(ac97_bus_t *bus, ac97_template_t *template, ac97_t **rac97)
                bus->ops->init(ac97);
        snd_ac97_get_name(ac97, ac97->id, name, !ac97_is_audio(ac97));
        snd_ac97_get_name(NULL, ac97->id, name, !ac97_is_audio(ac97));  // ac97->id might be changed in the special setup code
+       if (! ac97->build_ops)
+               ac97->build_ops = &null_build_ops;
+
        if (ac97_is_audio(ac97)) {
+               char comp[16];
                if (card->mixername[0] == '\0') {
                        strcpy(card->mixername, name);
                } else {
@@ -2044,7 +2069,8 @@ int snd_ac97_mixer(ac97_bus_t *bus, ac97_template_t *template, ac97_t **rac97)
                                strcat(card->mixername, name);
                        }
                }
-               if ((err = snd_component_add(card, "AC97a")) < 0) {
+               sprintf(comp, "AC97a:%08x", ac97->id);
+               if ((err = snd_component_add(card, comp)) < 0) {
                        snd_ac97_free(ac97);
                        return err;
                }
@@ -2054,6 +2080,7 @@ int snd_ac97_mixer(ac97_bus_t *bus, ac97_template_t *template, ac97_t **rac97)
                }
        }
        if (ac97_is_modem(ac97)) {
+               char comp[16];
                if (card->mixername[0] == '\0') {
                        strcpy(card->mixername, name);
                } else {
@@ -2062,7 +2089,8 @@ int snd_ac97_mixer(ac97_bus_t *bus, ac97_template_t *template, ac97_t **rac97)
                                strcat(card->mixername, name);
                        }
                }
-               if ((err = snd_component_add(card, "AC97m")) < 0) {
+               sprintf(comp, "AC97m:%08x", ac97->id);
+               if ((err = snd_component_add(card, comp)) < 0) {
                        snd_ac97_free(ac97);
                        return err;
                }
@@ -2081,7 +2109,7 @@ int snd_ac97_mixer(ac97_bus_t *bus, ac97_template_t *template, ac97_t **rac97)
                snd_ac97_write_cache(ac97, AC97_EXTENDED_STATUS, reg);
        }
        snd_ac97_proc_init(ac97);
-       if ((err = snd_device_new(card, SNDRV_DEV_LOWLEVEL, ac97, &ops)) < 0) {
+       if ((err = snd_device_new(card, SNDRV_DEV_CODEC, ac97, &ops)) < 0) {
                snd_ac97_free(ac97);
                return err;
        }
@@ -2138,9 +2166,51 @@ static void snd_ac97_powerdown(ac97_t *ac97)
  */
 void snd_ac97_suspend(ac97_t *ac97)
 {
+       if (ac97->build_ops->suspend)
+               ac97->build_ops->suspend(ac97);
        snd_ac97_powerdown(ac97);
 }
 
+/*
+ * restore ac97 status
+ */
+void snd_ac97_restore_status(ac97_t *ac97)
+{
+       int i;
+
+       for (i = 2; i < 0x7c ; i += 2) {
+               if (i == AC97_POWERDOWN || i == AC97_EXTENDED_ID)
+                       continue;
+               /* restore only accessible registers
+                * some chip (e.g. nm256) may hang up when unsupported registers
+                * are accessed..!
+                */
+               if (test_bit(i, ac97->reg_accessed)) {
+                       snd_ac97_write(ac97, i, ac97->regs[i]);
+                       snd_ac97_read(ac97, i);
+               }
+       }
+}
+
+/*
+ * restore IEC958 status
+ */
+void snd_ac97_restore_iec958(ac97_t *ac97)
+{
+       if (ac97->ext_id & AC97_EI_SPDIF) {
+               if (ac97->regs[AC97_EXTENDED_STATUS] & AC97_EA_SPDIF) {
+                       /* reset spdif status */
+                       snd_ac97_update_bits(ac97, AC97_EXTENDED_STATUS, AC97_EA_SPDIF, 0);
+                       snd_ac97_write(ac97, AC97_EXTENDED_STATUS, ac97->regs[AC97_EXTENDED_STATUS]);
+                       if (ac97->flags & AC97_CS_SPDIF)
+                               snd_ac97_write(ac97, AC97_CSR_SPDIF, ac97->regs[AC97_CSR_SPDIF]);
+                       else
+                               snd_ac97_write(ac97, AC97_SPDIF, ac97->regs[AC97_SPDIF]);
+                       snd_ac97_update_bits(ac97, AC97_EXTENDED_STATUS, AC97_EA_SPDIF, AC97_EA_SPDIF); /* turn on again */
+               }
+       }
+}
+
 /**
  * snd_ac97_resume - General resume function for AC97 codec
  * @ac97: the ac97 instance
@@ -2150,7 +2220,7 @@ void snd_ac97_suspend(ac97_t *ac97)
  */
 void snd_ac97_resume(ac97_t *ac97)
 {
-       int i, is_ad18xx, codec;
+       int i;
 
        if (ac97->bus->ops->reset) {
                ac97->bus->ops->reset(ac97);
@@ -2192,72 +2262,18 @@ __reset_ready:
        if (ac97->bus->ops->init)
                ac97->bus->ops->init(ac97);
 
-       is_ad18xx = (ac97->flags & AC97_AD_MULTI);
-       if (is_ad18xx) {
-               /* restore the AD18xx codec configurations */
-               for (codec = 0; codec < 3; codec++) {
-                       if (! ac97->spec.ad18xx.id[codec])
-                               continue;
-                       /* select single codec */
-                       snd_ac97_update_bits(ac97, AC97_AD_SERIAL_CFG, 0x7000,
-                                            ac97->spec.ad18xx.unchained[codec] | ac97->spec.ad18xx.chained[codec]);
-                       ac97->bus->ops->write(ac97, AC97_AD_CODEC_CFG, ac97->spec.ad18xx.codec_cfg[codec]);
-               }
-               /* select all codecs */
-               snd_ac97_update_bits(ac97, AC97_AD_SERIAL_CFG, 0x7000, 0x7000);
-       }
-
-       /* restore ac97 status */
-       for (i = 2; i < 0x7c ; i += 2) {
-               if (i == AC97_POWERDOWN || i == AC97_EXTENDED_ID)
-                       continue;
-               /* restore only accessible registers
-                * some chip (e.g. nm256) may hang up when unsupported registers
-                * are accessed..!
-                */
-               if (test_bit(i, ac97->reg_accessed)) {
-                       if (is_ad18xx) {
-                               /* handle multi codecs for AD18xx */
-                               if (i == AC97_PCM) {
-                                       for (codec = 0; codec < 3; codec++) {
-                                               if (! ac97->spec.ad18xx.id[codec])
-                                                       continue;
-                                               /* select single codec */
-                                               snd_ac97_update_bits(ac97, AC97_AD_SERIAL_CFG, 0x7000,
-                                                                    ac97->spec.ad18xx.unchained[codec] | ac97->spec.ad18xx.chained[codec]);
-                                               /* update PCM bits */
-                                               ac97->bus->ops->write(ac97, AC97_PCM, ac97->spec.ad18xx.pcmreg[codec]);
-                                       }
-                                       /* select all codecs */
-                                       snd_ac97_update_bits(ac97, AC97_AD_SERIAL_CFG, 0x7000, 0x7000);
-                                       continue;
-                               } else if (i == AC97_AD_TEST ||
-                                          i == AC97_AD_CODEC_CFG ||
-                                          i == AC97_AD_SERIAL_CFG)
-                                       continue; /* ignore */
-                       }
-                       snd_ac97_write(ac97, i, ac97->regs[i]);
-                       snd_ac97_read(ac97, i);
-               }
-       }
-
-       if (ac97->ext_id & AC97_EI_SPDIF) {
-               if (ac97->regs[AC97_EXTENDED_STATUS] & AC97_EA_SPDIF) {
-                       /* reset spdif status */
-                       snd_ac97_update_bits(ac97, AC97_EXTENDED_STATUS, AC97_EA_SPDIF, 0);
-                       snd_ac97_write(ac97, AC97_EXTENDED_STATUS, ac97->regs[AC97_EXTENDED_STATUS]);
-                       if (ac97->flags & AC97_CS_SPDIF)
-                               snd_ac97_write(ac97, AC97_CSR_SPDIF, ac97->regs[AC97_CSR_SPDIF]);
-                       else
-                               snd_ac97_write(ac97, AC97_SPDIF, ac97->regs[AC97_SPDIF]);
-                       snd_ac97_update_bits(ac97, AC97_EXTENDED_STATUS, AC97_EA_SPDIF, AC97_EA_SPDIF); /* turn on again */
-               }
+       if (ac97->build_ops->resume)
+               ac97->build_ops->resume(ac97);
+       else {
+               snd_ac97_restore_status(ac97);
+               snd_ac97_restore_iec958(ac97);
        }
 }
 #endif
 
 
 /*
+ * Hardware tuning
  */
 static void set_ctl_name(char *dst, const char *src, const char *suffix)
 {
@@ -2267,6 +2283,7 @@ static void set_ctl_name(char *dst, const char *src, const char *suffix)
                strcpy(dst, src);
 }      
 
+/* remove the control with the given name and optional suffix */
 int snd_ac97_remove_ctl(ac97_t *ac97, const char *name, const char *suffix)
 {
        snd_ctl_elem_id_t id;
@@ -2285,6 +2302,7 @@ static snd_kcontrol_t *ctl_find(ac97_t *ac97, const char *name, const char *suff
        return snd_ctl_find_id(ac97->bus->card, &sid);
 }
 
+/* rename the control with the given name and optional suffix */
 int snd_ac97_rename_ctl(ac97_t *ac97, const char *src, const char *dst, const char *suffix)
 {
        snd_kcontrol_t *kctl = ctl_find(ac97, src, suffix);
@@ -2302,6 +2320,7 @@ void snd_ac97_rename_vol_ctl(ac97_t *ac97, const char *src, const char *dst)
        snd_ac97_rename_ctl(ac97, src, dst, "Volume");
 }
 
+/* swap controls */
 int snd_ac97_swap_ctl(ac97_t *ac97, const char *s1, const char *s2, const char *suffix)
 {
        snd_kcontrol_t *kctl1, *kctl2;
@@ -2315,27 +2334,37 @@ int snd_ac97_swap_ctl(ac97_t *ac97, const char *s1, const char *s2, const char *
        return -ENOENT;
 }
 
-static int swap_headphone(ac97_t *ac97, int remove_master)
+/* ac97 tune: use Headphone control as master */
+static int tune_hp_only(ac97_t *ac97)
 {
-       if (remove_master) {
-               if (ctl_find(ac97, "Headphone Playback Switch", NULL) == NULL)
-                       return 0;
-               snd_ac97_remove_ctl(ac97, "Master Playback", "Switch");
-               snd_ac97_remove_ctl(ac97, "Master Playback", "Volume");
-       } else
-               snd_ac97_rename_vol_ctl(ac97, "Master Playback", "Line-Out Playback");
+       if (ctl_find(ac97, "Headphone Playback Switch", NULL) == NULL)
+               return -ENOENT;
+       snd_ac97_remove_ctl(ac97, "Master Playback", "Switch");
+       snd_ac97_remove_ctl(ac97, "Master Playback", "Volume");
        snd_ac97_rename_vol_ctl(ac97, "Headphone Playback", "Master Playback");
        return 0;
 }
 
-static int swap_surround(ac97_t *ac97)
+/* ac97 tune: swap Headphone and Master controls */
+static int tune_swap_hp(ac97_t *ac97)
 {
-       /* FIXME: error checks.. */
-       snd_ac97_swap_ctl(ac97, "Master Playback", "Surround Playback", "Switch");
-       snd_ac97_swap_ctl(ac97, "Master Playback", "Surround Playback", "Volume");
+       if (ctl_find(ac97, "Headphone Playback Switch", NULL) == NULL)
+               return -ENOENT;
+       snd_ac97_rename_vol_ctl(ac97, "Master Playback", "Line-Out Playback");
+       snd_ac97_rename_vol_ctl(ac97, "Headphone Playback", "Master Playback");
        return 0;
 }
 
+/* ac97 tune: swap Surround and Master controls */
+static int tune_swap_surround(ac97_t *ac97)
+{
+       if (snd_ac97_swap_ctl(ac97, "Master Playback", "Surround Playback", "Switch") ||
+           snd_ac97_swap_ctl(ac97, "Master Playback", "Surround Playback", "Volume"))
+               return -ENOENT;
+       return 0;
+}
+
+/* ac97 tune: set up mic sharing for AD codecs */
 static int tune_ad_sharing(ac97_t *ac97)
 {
        unsigned short scfg;
@@ -2352,6 +2381,7 @@ static int tune_ad_sharing(ac97_t *ac97)
 static const snd_kcontrol_new_t snd_ac97_alc_jack_detect = 
 AC97_SINGLE("Jack Detect", AC97_ALC650_CLOCK, 5, 1, 0);
 
+/* ac97 tune: set up ALC jack-select */
 static int tune_alc_jack(ac97_t *ac97)
 {
        if ((ac97->id & 0xffffff00) != 0x414c4700) {
@@ -2363,22 +2393,89 @@ static int tune_alc_jack(ac97_t *ac97)
        return snd_ctl_add(ac97->bus->card, snd_ac97_cnew(&snd_ac97_alc_jack_detect, ac97));
 }
 
-static int apply_quirk(ac97_t *ac97, int quirk)
+/* ac97 tune: inversed EAPD bit */
+static int tune_inv_eapd(ac97_t *ac97)
+{
+       snd_kcontrol_t *kctl = ctl_find(ac97, "External Amplifier", NULL);
+       if (! kctl)
+               return -ENOENT;
+       set_inv_eapd(ac97, kctl);
+       return 0;
+}
+
+static int master_mute_sw_put(snd_kcontrol_t *kcontrol, snd_ctl_elem_value_t *ucontrol)
+{
+       int err = snd_ac97_put_volsw(kcontrol, ucontrol);
+       if (err > 0) {
+               ac97_t *ac97 = snd_kcontrol_chip(kcontrol);
+               int shift = (kcontrol->private_value >> 8) & 0x0f;
+               int rshift = (kcontrol->private_value >> 12) & 0x0f;
+               unsigned short mask;
+               if (shift != rshift)
+                       mask = 0x8080;
+               else
+                       mask = 0x8000;
+               snd_ac97_update_bits(ac97, AC97_POWERDOWN, 0x8000,
+                                    (ac97->regs[AC97_MASTER] & mask) == mask ?
+                                    0x8000 : 0);
+       }
+       return err;
+}
+
+/* ac97 tune: EAPD controls mute LED bound with the master mute */
+static int tune_mute_led(ac97_t *ac97)
 {
-       switch (quirk) {
-       case AC97_TUNE_NONE:
+       snd_kcontrol_t *msw = ctl_find(ac97, "Master Playback Switch", NULL);
+       if (! msw)
+               return -ENOENT;
+       msw->put = master_mute_sw_put;
+       snd_ac97_remove_ctl(ac97, "External Amplifier", NULL);
+       snd_ac97_update_bits(ac97, AC97_POWERDOWN, 0x8000, 0x8000); /* mute LED on */
+       return 0;
+}
+
+struct quirk_table {
+       const char *name;
+       int (*func)(ac97_t *);
+};
+
+static struct quirk_table applicable_quirks[] = {
+       { "none", NULL },
+       { "hp_only", tune_hp_only },
+       { "swap_hp", tune_swap_hp },
+       { "swap_surround", tune_swap_surround },
+       { "ad_sharing", tune_ad_sharing },
+       { "alc_jack", tune_alc_jack },
+       { "inv_eapd", tune_inv_eapd },
+       { "mute_led", tune_mute_led },
+};
+
+/* apply the quirk with the given type */
+static int apply_quirk(ac97_t *ac97, int type)
+{
+       if (type <= 0)
                return 0;
-       case AC97_TUNE_HP_ONLY:
-               return swap_headphone(ac97, 1);
-       case AC97_TUNE_SWAP_HP:
-               return swap_headphone(ac97, 0);
-       case AC97_TUNE_SWAP_SURROUND:
-               return swap_surround(ac97);
-       case AC97_TUNE_AD_SHARING:
-               return tune_ad_sharing(ac97);
-       case AC97_TUNE_ALC_JACK:
-               return tune_alc_jack(ac97);
+       else if (type >= ARRAY_SIZE(applicable_quirks))
+               return -EINVAL;
+       if (applicable_quirks[type].func)
+               return applicable_quirks[type].func(ac97);
+       return 0;
+}
+
+/* apply the quirk with the given name */
+static int apply_quirk_str(ac97_t *ac97, const char *typestr)
+{
+       int i;
+       struct quirk_table *q;
+
+       for (i = 0; i < ARRAY_SIZE(applicable_quirks); i++) {
+               q = &applicable_quirks[i];
+               if (q->name && ! strcmp(typestr, q->name))
+                       return apply_quirk(ac97, i);
        }
+       /* for compatibility, accept the numbers, too */
+       if (*typestr >= '0' && *typestr <= '9')
+               return apply_quirk(ac97, (int)simple_strtol(typestr, NULL, 10));
        return -EINVAL;
 }
 
@@ -2386,7 +2483,7 @@ static int apply_quirk(ac97_t *ac97, int quirk)
  * snd_ac97_tune_hardware - tune up the hardware
  * @ac97: the ac97 instance
  * @quirk: quirk list
- * @override: explicit quirk value (overrides the list if not AC97_TUNE_DEFAULT)
+ * @override: explicit quirk value (overrides the list if non-NULL)
  *
  * Do some workaround for each pci device, such as renaming of the
  * headphone (true line-out) control as "Master".
@@ -2395,16 +2492,17 @@ static int apply_quirk(ac97_t *ac97, int quirk)
  * Returns zero if successful, or a negative error code on failure.
  */
 
-int snd_ac97_tune_hardware(ac97_t *ac97, struct ac97_quirk *quirk, int override)
+int snd_ac97_tune_hardware(ac97_t *ac97, struct ac97_quirk *quirk, const char *override)
 {
        int result;
 
        snd_assert(quirk, return -EINVAL);
 
-       if (override != AC97_TUNE_DEFAULT) {
-               result = apply_quirk(ac97, override);
+       /* quirk overriden? */
+       if (override && strcmp(override, "-1") && strcmp(override, "default")) {
+               result = apply_quirk_str(ac97, override);
                if (result < 0)
-                       snd_printk(KERN_ERR "applying quirk type %d failed (%d)\n", override, result);
+                       snd_printk(KERN_ERR "applying quirk type %s failed (%d)\n", override, result);
                return result;
        }
 
@@ -2413,6 +2511,8 @@ int snd_ac97_tune_hardware(ac97_t *ac97, struct ac97_quirk *quirk, int override)
                        continue;
                if ((! quirk->mask && quirk->device == ac97->subsystem_device) ||
                    quirk->device == (quirk->mask & ac97->subsystem_device)) {
+                       if (quirk->codec_id && quirk->codec_id != ac97->id)
+                               continue;
                        snd_printdd("ac97 quirk for %s (%04x:%04x)\n", quirk->name, ac97->subsystem_vendor, ac97->subsystem_device);
                        result = apply_quirk(ac97, quirk->type);
                        if (result < 0)
@@ -2433,11 +2533,13 @@ EXPORT_SYMBOL(snd_ac97_read);
 EXPORT_SYMBOL(snd_ac97_write_cache);
 EXPORT_SYMBOL(snd_ac97_update);
 EXPORT_SYMBOL(snd_ac97_update_bits);
+EXPORT_SYMBOL(snd_ac97_get_short_name);
 EXPORT_SYMBOL(snd_ac97_bus);
 EXPORT_SYMBOL(snd_ac97_mixer);
 EXPORT_SYMBOL(snd_ac97_pcm_assign);
 EXPORT_SYMBOL(snd_ac97_pcm_open);
 EXPORT_SYMBOL(snd_ac97_pcm_close);
+EXPORT_SYMBOL(snd_ac97_pcm_double_rate_rules);
 EXPORT_SYMBOL(snd_ac97_tune_hardware);
 EXPORT_SYMBOL(snd_ac97_set_rate);
 #ifdef CONFIG_PM