Policy.py includes updates to better handle PCUs
authorStephen Soltesz <soltesz@cs.princeton.edu>
Wed, 7 Nov 2007 21:22:38 +0000 (21:22 +0000)
committerStephen Soltesz <soltesz@cs.princeton.edu>
Wed, 7 Nov 2007 21:22:38 +0000 (21:22 +0000)
emailTxt includes new messages related to PCUs

automate_pl03.sh
diagnose.py
emailTxt.py
get_metasite_nodes.py
policy.py

index 8dec52a..4cf870d 100755 (executable)
@@ -15,7 +15,7 @@ scp pdb/production.findbad2.pkl soltesz@golf.cs.princeton.edu:monitor3/pdb/produ
 
 ########################
 # COPY Act_all records
-scp soltesz@golf.cs.princeton.edu:monitor3/pdb/production.act_all.pkl pdb/
+#scp soltesz@golf.cs.princeton.edu:monitor3/pdb/production.act_all.pkl pdb/
 
 ########################
 # badcsv.txt
@@ -27,4 +27,10 @@ cp badcsv.txt /plc/data/var/www/html/monitor/
 rm -f pdb/production.findbadpcus2.pkl
 ./findbadpcu.py --increment --refresh --debug=0 --dbname=findbadpcus2
 # convert pkl to php serialize format.
+cp pdb/production.findbadpcus2.pkl pdb/production.findbadpcus.pkl
 ./pkl2php.py -i findbadpcus2 -o findbadpcus
+
+
+for f in findbad act_all findbadpcus l_plcnodes; do 
+       cp pdb/production.$f.pkl archive-pdb/`date +%F`.production.$f.pkl
+done
index 7668e88..855f52d 100755 (executable)
@@ -66,7 +66,7 @@ POLSLEEP=10
 # list will be monitored.
 runningthreads = {}
 # Seconds between checking threads
-WATCHSLEEP = 10
+WATCHSLEEP = 5
  
 # Set up Logging
 logger = logging.getLogger("monitor")
index 49de223..62e652c 100644 (file)
@@ -193,7 +193,8 @@ Monitor restarted NM on the following machines:
        """)
        pcudown_one =("""Could not use PCU to reboot %(hostname)s""",
 
-"""As part of our machine monitoring and maintenance, we tried to use the PCU registered below, but could not for the following reason at the link below:
+"""As part of our machine monitoring and maintenance, we tried to use the PCU
+registered below, but could not for the following reason at the link below:
 
        https://pl-virtual-03.cs.princeton.edu/cgi-bin/printbadpcus.php#id%(pcu_id)s
 
@@ -216,7 +217,47 @@ If the above PCU is no longer in service, please delete it by visiting:
 
     https://www.planet-lab.org/db/sites/pcu.php?id=%(pcu_id)s
 
-and selecting 'Delete PCU'.
+and selecting 'Delete PCU'. You may then register a new PCU for your nodes.
+
+Thank you very much for your help,
+  -- PlanetLab Central (support@planet-lab.org)
+""")
+       pcutonodemapping_one =("""PCU to Node mapping is incorrect for %(hostname)s""",
+       """
+    As part of our machine monitoring and maintenance, we tried to use the PCU
+registered below, and though it appears to succeed, we do not subsequently
+observe the associated nodes rebooting:
+
+    https://pl-virtual-03.cs.princeton.edu/cgi-bin/printbadpcus.php#id%(pcu_id)s
+
+%(hostname_list)s
+
+We need your help resolving this issue in two ways:  
+
+* First, we need your help rebooting %(hostname)s.  Because the above PCU 
+  does not appear to actually control the above Nodes, we cannot use it to
+  reboot these machines. So, please manually reboot the machine and we can 
+  help you resolve any configuration errors with the PCU independently.
+
+* Second, please check the configuration of the above PCU.  Check that the 
+  PCU is physically connected to the servers that it should be able to
+  control.  A common mistake is that the PCU is registered for a machine, 
+  but not actually connected physically to the machine. 
+
+By enabling us to take administrative actions automatically from PlanetLab
+Central without local intervention, you can trade a small amount of time now
+for a time savings in the future. 
+    
+If the above PCU is no longer in service, please delete it by visiting:
+
+    https://www.planet-lab.org/db/sites/pcu.php?id=%(pcu_id)s
+
+and selecting 'Delete PCU'. You may then register a new PCU for your nodes.
+
+Alternately, if the machines listed above are no longer in service, please
+delete them by visiting your sites page at:
+
+    https://www.planet-lab.org/
 
 Thank you very much for your help,
   -- PlanetLab Central (support@planet-lab.org)
@@ -227,7 +268,8 @@ Thank you very much for your help,
        newbootcd=[newbootcd_one, newbootcd_two, newbootcd_three]
        newthankyou=[thankyou,thankyou,thankyou]
        NMReset=[nmreset,nmreset,nmreset]
-       PCUDown=[pcudown_one, pcudown_one, pcudown_one]
+       pcutonodemapping=[pcutonodemapping_one, pcutonodemapping_one, pcutonodemapping_one]
+       pcudown=[pcudown_one, pcudown_one, pcudown_one]
 
        down=("""PlanetLab node %(hostname)s down.""", """As part of PlanetLab node monitoring, we noticed %(hostname)s has been down for %(days)s days.
 
index 5d88377..e3b7959 100755 (executable)
@@ -5,7 +5,7 @@ import string
 import sys
 
 def main():
-       meta_sites = ['canarie', 'rnp', 'jgn2', 'i2', 'tp', 'princetondsl', 'plcolo', 'wide']
+       meta_sites = ['canarie', 'rnp', 'jgn2', 'i2', 'tp', 'princeton', 'princetondsl', 'plcolo', 'wide']
        l_blacklist = [ "grouse.hpl.hp.com", "planet1.att.nodes.planet-lab.org"]
        #l_blacklist = soltesz.dbLoad("l_blacklist")
        l_sitelist = []
index 82630e9..0bdf4bf 100644 (file)
--- a/policy.py
+++ b/policy.py
@@ -17,6 +17,7 @@ import pickle
 import Queue
 import plc
 import sys
+import os
 import reboot
 import soltesz
 import string
@@ -130,7 +131,14 @@ class Merge(Thread):
 
                        fb_record = {}
                        fb_record['nodename'] = nodename
-                       fb_record['category'] = values['category']
+                       try:
+                               fb_record['category'] = values['category']
+                       except:
+                               print values
+                               print nodename
+                               print self.findbad['nodes'][nodename]
+                               count -= 1
+                               continue
                        fb_record['state'] = values['state']
                        fb_record['comonstats'] = values['comonstats']
                        fb_record['plcnode'] = values['plcnode']
@@ -197,7 +205,7 @@ class Merge(Thread):
                                        self.mergedb[loginbase][nodename] = {} 
                                        self.mergedb[loginbase][nodename].update(x)
                                        self.mergedb[loginbase][nodename]['ticket_id'] = ""
-                                       self.mergedb[loginbase][nodename]['prev_category'] = None
+                                       self.mergedb[loginbase][nodename]['prev_category'] = "NORECORD" 
                                else: 
                                        if len(self.act_all[nodename]) == 0:
                                                print "len(act_all[%s]) == 0, skipping %s %s" % (nodename, loginbase, nodename)
@@ -205,14 +213,14 @@ class Merge(Thread):
 
                                        y = self.act_all[nodename][0]
 
-                                       # skip if end-stage
-                                       if 'stage' in y and "monitor-end-record" in y['stage']:
-                                               # 1) ok, b/c it's a new problem. set ticket_id to null
-                                               self.mergedb[loginbase][nodename] = {} 
-                                               self.mergedb[loginbase][nodename].update(x)
-                                               self.mergedb[loginbase][nodename]['ticket_id'] = ""
-                                               self.mergedb[loginbase][nodename]['prev_category'] = None
-                                               continue
+                                       ## skip if end-stage
+                                       #if 'stage' in y and "monitor-end-record" in y['stage']:
+                                       #       # 1) ok, b/c it's a new problem. set ticket_id to null
+                                       ##      self.mergedb[loginbase][nodename] = {} 
+                                       #       self.mergedb[loginbase][nodename].update(x)
+                                       #       self.mergedb[loginbase][nodename]['ticket_id'] = ""
+                                       #       self.mergedb[loginbase][nodename]['prev_category'] = None
+                                       #       continue
 
                                        ## for legacy actions
                                        #if 'bucket' in y and y['bucket'][0] == 'dbg':
@@ -241,7 +249,6 @@ class Merge(Thread):
                                        #if b_match: 
                                        #       # 2b) ok, b/c they agree that there's still a problem..
                                        #       # 2b) Comon & Monitor still agree; RT ticket?
-                                       #       y['prev_category'] = y['category']
                                        #else:
                                        #       # 2a) mismatch, need a policy for how to resolve
                                        #       #     resolution will be handled in __diagnoseNode()
@@ -251,7 +258,7 @@ class Merge(Thread):
                                        #       print "FINDBAD and MONITOR have a mismatch: %s vs %s" % \
                                        #                               (x['category'], y['bucket'])
 
-
+                                       y['prev_category'] = y['category']
                                        self.mergedb[loginbase][nodename] = {}
                                        self.mergedb[loginbase][nodename].update(y)
                                        self.mergedb[loginbase][nodename]['comonstats'] = x['comonstats']
@@ -484,6 +491,17 @@ class Diagnose(Thread):
                        diag_record['message'] = emailTxt.mailtxt.newdown
                        diag_record['args'] = {'nodename': nodename}
                        diag_record['info'] = (nodename, s_daysdown, "")
+
+                       if 'reboot_node_failed' in node_record:
+                               # there was a previous attempt to use the PCU.
+                               if node_record['reboot_node_failed'] == False:
+                                       # then the last attempt apparently, succeeded.
+                                       # But, the category is still 'ERROR'.  Therefore, the
+                                       # PCU-to-Node mapping is broken.
+                                       #print "Setting message for ERROR node to PCU2NodeMapping: %s" % nodename
+                                       diag_record['message'] = emailTxt.mailtxt.pcutonodemapping
+                                       diag_record['email_pcu'] = True
+
                        if diag_record['ticket_id'] == "":
                                diag_record['log'] = "DOWN: %20s : %-40s == %20s %s" % \
                                        (loginbase, nodename, diag_record['info'][1:], diag_record['found_rt_ticket'])
@@ -586,36 +604,44 @@ class Diagnose(Thread):
        def __diagnoseNode(self, loginbase, node_record):
                # TODO: change the format of the hostname in this 
                #               record to something more natural.
-               nodename          = node_record['nodename']
-               category          = node_record['category']
-               prev_category = node_record['prev_category']
-               state             = node_record['state']
-
-               val = cmpCategoryVal(category, prev_category)
-               if val == -1:
-                       # current category is worse than previous, carry on
-                       pass
-               elif val == 1:
-                       # current category is better than previous
-                       # TODO: too generous for now, but will be handled correctly
-                       # TODO: if stage is currently ticket_waitforever, 
-                       if 'ticket_id' not in node_record:
-                               print "ignoring: ", node_record['nodename']
-                               return None
-                       else:
-                               if node_record['ticket_id'] == "" or \
-                                  node_record['ticket_id'] == None:
-                                       print "closing: ", node_record['nodename']
+               nodename                = node_record['nodename']
+               category                = node_record['category']
+               prev_category   = node_record['prev_category']
+               state                   = node_record['state']
+               #if 'prev_category' in node_record:
+               #       prev_category = node_record['prev_category']
+               #else:
+               #       prev_category = "ERROR"
+               if node_record['prev_category'] != "NORECORD":
+               
+                       val = cmpCategoryVal(category, prev_category)
+                       print "%s went from %s -> %s" % (nodename, prev_category, category)
+                       if val == 1:
+                               # improved
+                               if node_record['ticket_id'] == "" or node_record['ticket_id'] == None:
+                                       print "closing record with no ticket: ", node_record['nodename']
                                        node_record['action'] = ['close_rt']
                                        node_record['message'] = None
                                        node_record['stage'] = 'monitor-end-record'
                                        return node_record
-                                       #return None
                                else:
                                        node_record['stage'] = 'improvement'
-               else:
-                       #values are equal, carry on.
-                       pass
+
+                               #if 'monitor-end-record' in node_record['stage']:
+                               #       # just ignore it if it's already ended.
+                               #       # otherwise, the status should be worse, and we won't get
+                               #       # here.
+                               #       print "monitor-end-record: ignoring ", node_record['nodename']
+                               #       return None
+#
+#                                      #return None
+                       elif val == -1:
+                               # current category is worse than previous, carry on
+                               pass
+                       else:
+                               #values are equal, carry on.
+                               #print "why are we here?"
+                               pass
                        
                #### COMPARE category and prev_category
                # if not_equal
@@ -624,6 +650,7 @@ class Diagnose(Thread):
                #       then check category for stats.
                diag_record = self.diagRecordByCategory(node_record)
                if diag_record == None:
+                       #print "diag_record == None"
                        return None
 
                #### found_RT_ticket
@@ -659,6 +686,12 @@ class Diagnose(Thread):
                        act_record['message'] = message[0]
                        act_record['stage']  = 'nmreset'
                        return None
+
+               elif 'reboot_node' in diag_record['stage']:
+                       act_record['email'] = TECH
+                       act_record['action'] = ['noop']
+                       act_record['message'] = message[0]
+                       act_record['stage'] = 'stage_actinoneweek'
                        
                elif 'improvement' in diag_record['stage']:
                        # - backoff previous squeeze actions (slice suspend, nocreate)
@@ -682,6 +715,7 @@ class Diagnose(Thread):
                        else:
                                act_record['message'] = None
                                act_record['action'] = ['waitforoneweekaction' ]
+                               print "ignoring this record for: %s" % act_record['nodename']
                                return None                     # don't send if there's no action
 
                elif 'actintwoweeks' in diag_record['stage']:
@@ -739,11 +773,12 @@ class Diagnose(Thread):
                        #       1. stage is unknown, or 
                        #       2. delta is not big enough to bump it to the next stage.
                        # TODO: figure out which. for now assume 2.
-                       print "UNKNOWN!?!? %s" % nodename
+                       print "UNKNOWN stage for %s; nothing done" % nodename
                        act_record['action'] = ['unknown']
                        act_record['message'] = message[0]
-                       print "Exiting..."
-                       sys.exit(1)
+                       #print "Exiting..."
+                       return None
+                       #sys.exit(1)
 
                print "%s" % act_record['log'],
                print "%15s" % act_record['action']
@@ -1071,6 +1106,7 @@ class Action(Thread):
                                        if act_record['email_pcu'] and \
                                                site_record['config']['email']:
 
+                                               email_args['hostname'] = act_record['nodename']
                                                ticket_id = self.__emailSite(loginbase, 
                                                                                        act_record['email'], 
                                                                                        emailTxt.mailtxt.pcudown[0],
@@ -1110,7 +1146,7 @@ class Action(Thread):
 
                #print "sleeping for 1 sec"
                #time.sleep(1)
-               #print "Hit enter to continue..."
+               print "Hit enter to continue..."
                sys.stdout.flush()
                line = sys.stdin.readline()
 
@@ -1124,33 +1160,57 @@ class Action(Thread):
                act_record.update(diag_record)
                act_record['nodename'] = nodename
                act_record['msg_format'] = self._format_diaginfo(diag_record)
+               print "act_record['stage'] == %s " % act_record['stage']
+
+               # avoid end records, and nmreset records                                        
+               # reboot_node_failed, is set below, so don't reboot repeatedly.
+
+               if 'monitor-end-record' not in act_record['stage'] and \
+                  'nmreset' not in act_record['stage'] and \
+                  'reboot_node_failed' not in act_record:
+
+                       if "DOWN" in act_record['log'] and \
+                                       'pcu_ids' in act_record['plcnode'] and \
+                                       len(act_record['plcnode']['pcu_ids']) > 0:
+
+                               print "%s" % act_record['log'],
+                               print "%15s" % (['reboot_node'],)
+                               # Set node to re-install
+                               plc.nodeBootState(act_record['nodename'], "rins")       
+                               try:
+                                       ret = reboot_node({'hostname': act_record['nodename']})
+                               except Exception, exc:
+                                       print "exception on reboot_node:"
+                                       import traceback
+                                       print traceback.print_exc()
+                                       ret = False
+
+                               if ret: # and ( 'reboot_node_failed' not in act_record or act_record['reboot_node_failed'] == False):
+                                       # Reboot Succeeded
+                                       print "reboot succeeded for %s" % act_record['nodename']
+                                       act_record2 = {}
+                                       act_record2.update(act_record)
+                                       act_record2['action'] = ['reboot_node']
+                                       act_record2['stage'] = "reboot_node"
+                                       act_record2['reboot_node_failed'] = False
+                                       act_record2['email_pcu'] = False
+
+                                       if nodename not in self.act_all: 
+                                               self.act_all[nodename] = []
+                                       print "inserting 'reboot_node' record into act_all"
+                                       self.act_all[nodename].insert(0,act_record2)
+
+                                       # return None to avoid further action
+                                       print "Taking no further action"
+                                       return None
+                               else:
+                                       print "reboot failed for %s" % act_record['nodename']
+                                       # set email_pcu to also send pcu notice for this record.
+                                       act_record['reboot_node_failed'] = True
+                                       act_record['email_pcu'] = True
 
-
-               if "DOWN" in act_record['log']:
                        print "%s" % act_record['log'],
-                       print "%15s" % (['reboot_node'],)
-                       ret = reboot_node(act_record['nodename'])
-                       if ret:
-                               # Reboot Succeeded
-                               act_record2 = {}
-                               act_record2.update(act_record)
-                               act_record2['action'] = ['reboot_node']
-                               act_record2['reboot_node_failed'] = False
-                               act_record2['email_pcu'] = False
-
-                               if nodename not in self.act_all: 
-                                       self.act_all[nodename] = []
-                               self.act_all[nodename].insert(0,act_record2)
-
-                               # return None to avoid further action
-                               return None
-                       else:
-                               # set email_pcu to also send pcu notice for this record.
-                               act_record['reboot_node_failed'] = True
-                               act_record['email_pcu'] = True
-
-               print "%s" % act_record['log'],
-               print "%15s" % act_record['action']
+                       print "%15s" % act_record['action']
 
                if act_record['stage'] is not 'monitor-end-record' and \
                   act_record['stage'] is not 'nmreset':