Fixing validation of error in the state query for ns3 application

[nepi.git] / src / nepi / resources / ns3 / ns3application.py

diff --git a/src/nepi/resources/ns3/ns3application.py b/src/nepi/resources/ns3/ns3application.py
index c30a00c..6e46e7f 100644 (file)
--- a/src/nepi/resources/ns3/ns3application.py
+++ b/src/nepi/resources/ns3/ns3application.py
@@ -17,24 +17,31 @@
 #
 # Author: Alina Quereilhac <alina.quereilhac@inria.fr>
 
-from nepi.execution.resource import clsinit_copy
+from nepi.execution.resource import clsinit_copy, ResourceState
 from nepi.resources.ns3.ns3base import NS3Base
 
 @clsinit_copy
 class NS3BaseApplication(NS3Base):
     _rtype = "abstract::ns3::Application"
 
+    def __init__(self, ec, guid):
+        super(NS3BaseApplication, self).__init__(ec, guid)
+        self._node = None
+ 
     @property
     def node(self):
-        from nepi.resources.ns3.ns3node import NS3BaseNode
-        nodes = self.get_connected(NS3BaseNode.get_rtype())
+        if not self._node:
+            from nepi.resources.ns3.ns3node import NS3BaseNode
+            nodes = self.get_connected(NS3BaseNode.get_rtype())
 
-        if not nodes: 
-            msg = "Application not connected to node"
-            self.error(msg)
-            raise RuntimeError, msg
+            if not nodes: 
+                msg = "Application not connected to node"
+                self.error(msg)
+                raise RuntimeError, msg
 
-        return nodes[0]
+            self._node = nodes[0]
+
+        return self._node
 
     @property
     def _rms_to_wait(self):
@@ -48,7 +55,6 @@ class NS3BaseApplication(NS3Base):
             self.simulation.invoke(node.uuid, "AddApplication", self.uuid)
             self._connected.add(node.uuid)
 
-
     def do_stop(self):
         if self.state == ResourceState.STARTED:
             # No need to do anything, simulation.Destroy() will stop every object
@@ -56,29 +62,30 @@ class NS3BaseApplication(NS3Base):
             self.simulation.invoke(self.uuid, "Stop")
             self.set_stopped()
 
+    def do_start(self):
+        if self.simulation.state < ResourceState.STARTED:
+            self.debug("---- RESCHEDULING START ----" )
+            self.ec.schedule(self.reschedule_delay, self.start)
+        else:
+            super(NS3BaseApplication, self).do_start()
+            self._start_time = self.simulation.start_time
+
     @property
     def state(self):
-        #if self._state == ResourceState.STARTED:
+        if self._state == ResourceState.STARTED:
+            try:
+                is_running = self.simulation.invoke(self.uuid, "isAppRunning")
+                
+                if not is_running:
+                    self.set_stopped()
+            except:
+                msg = "Application failed. Can not retrieve state"
+                out = ""
+
+                import traceback
+                err = traceback.format_exc()
+                self.error(msg, out, err)
+                self.do_fail()
 
         return self._state
-        """
-        now = testbed_instance.ns3.Simulator.Now()
-        if now.IsZero():
-            return STATUS_NOT_STARTED
-        app = testbed_instance.elements[guid]
-        parameters = testbed_instance._get_parameters(guid)
-        if "StartTime" in parameters and parameters["StartTime"]:
-            start_value = parameters["StartTime"]
-            start_time = testbed_instance.ns3.Time(start_value)
-            if now.Compare(start_time) < 0:
-                return STATUS_NOT_STARTED
-        if "StopTime" in parameters and parameters["StopTime"]:
-            stop_value = parameters["StopTime"]
-            stop_time = testbed_instance.ns3.Time(stop_value)
-            if now.Compare(stop_time) < 0:
-                return STATUS_RUNNING
-            else:
-                return STATUS_FINISHED
-        return STATUS_UNDETERMINED
-        """