Assume each slice has a network namespace already

[nodemanager-topo.git] / topo.py

diff --git a/topo.py b/topo.py
index c895741..7f96281 100755 (executable)
--- a/topo.py
+++ b/topo.py
@@ -135,13 +135,13 @@ def clean_up_old_virtual_links():
     for iface in old_ifaces:
         m = re.match(pattern1, iface)
         if m:
-            key = int(m.group(1))
-            node = int(m.group(2))
+            key = m.group(1)
+            node = m.group(2)
             teardown_virtual_link(key, node)
 
         m = re.match(pattern2, iface)
         if m:
-            key = int(m.group(1))
+            key = m.group(1)
             teardown_nat(key)
     return
 
@@ -181,9 +181,10 @@ def update_nat(slice, myid, key, netns):
 
 
 """
-Write /etc/vservers/<slicename>/spaces/net.  If the vserver is running and the spaces/net file is modified, we need to restart it.
+Write /etc/vservers/<slicename>/spaces/net.  
+Assumes that the vserver was started with a network namespace.
 """
-def write_conf_and_restart(slicename, value):
+def write_spaces_net(slicename, value):
     SLICEDIR="/etc/vservers/%s/" % slicename
     SPACESDIR="%s/spaces/" % SLICEDIR
     FILENAME="%s/net" % SPACESDIR
@@ -197,11 +198,7 @@ def write_conf_and_restart(slicename, value):
             
         if os.path.exists(FILENAME) != value:
             sliver = vserver.VServer(slicename)
-            restart = sliver.is_running()
             
-            if (restart):
-                sliver.stop()
-                
             if value:
                 STATUS="ON"
                 f = open(FILENAME, "w")
@@ -212,10 +209,6 @@ def write_conf_and_restart(slicename, value):
                 
             logger.log("%s: network namespace %s\n" % (slicename, STATUS))
 
-            if (restart):
-                logger.log("topo: restarting sliver %s\n" % slicename)
-                sliver.start()
-
 
 """
 Generate information for each interface in the sliver, in order to configure
@@ -392,7 +385,7 @@ an 'egre_key' attribute, and a 'topo_rspec' attribute.
 Creating the virtual link depends on the contents of 
 /etc/vservers/<slice>/spaces/net.  Update this first.
 """
-def GetSlivers(data):
+def GetSlivers(data, config = None, plc = None):
     global ifaces, old_ifaces
     ifaces = old_ifaces = sioc.gifconf()
 
@@ -405,11 +398,12 @@ def GetSlivers(data):
                 slicekeys[sliver['name']] = tag['value']
                 
 
-        if 'netns' in attrs:
-            netns = int(attrs['netns'])
-        else:
-            netns = 0
-        write_conf_and_restart(sliver['name'], netns)
+        if vserver.VServer(sliver['name']).is_running():
+            if 'netns' in attrs:
+                netns = int(attrs['netns'])
+            else:
+                netns = 0
+            write_spaces_net(sliver['name'], netns)
 
         if vserver.VServer(sliver['name']).is_running():
             if 'egre_key' in attrs: