Nitpicks: formatting, commented-out code

diff --git a/lib/phpxmlrpc.php b/lib/phpxmlrpc.php
index 8c3d34c..fa04f70 100644 (file)
--- a/lib/phpxmlrpc.php
+++ b/lib/phpxmlrpc.php
@@ -1,6 +1,7 @@
 <?php
 
-class Phpxmlrpc {
+class Phpxmlrpc
+{
 
     public $xmlrpcI4 = "i4";
     public $xmlrpcInt = "int";
@@ -45,12 +46,12 @@ class Phpxmlrpc {
     /// These will NOT be present in true ISO-8859-1, but will save the unwary
     /// windows user from sending junk (though no luck when reciving them...)
     /*
-    $GLOBALS['xml_cp1252_Entities']=array();
+    public $xml_cp1252_Entities'=array();
     for ($i = 128; $i < 160; $i++)
     {
         $GLOBALS['xml_cp1252_Entities']['in'][] = chr($i);
     }
-    $GLOBALS['xml_cp1252_Entities']['out'] = array(
+    public $xml_cp1252_Entities['out'] = array(
         '&#x20AC;', '?',        '&#x201A;', '&#x0192;',
         '&#x201E;', '&#x2026;', '&#x2020;', '&#x2021;',
         '&#x02C6;', '&#x2030;', '&#x0160;', '&#x2039;',

diff --git a/lib/xmlrpc_client.php b/lib/xmlrpc_client.php
index 0a75f4c..8885388 100644 (file)
--- a/lib/xmlrpc_client.php
+++ b/lib/xmlrpc_client.php
@@ -2,7 +2,7 @@
 
 class xmlrpc_client
 {
-    /// @todo: does these need to be public?
+    /// @todo: do these need to be public?
     public $path;
     public $server;
     public $port=0;

diff --git a/lib/xmlrpcmsg.php b/lib/xmlrpcmsg.php
index 569a549..1c26af0 100644 (file)
--- a/lib/xmlrpcmsg.php
+++ b/lib/xmlrpcmsg.php
@@ -1,7 +1,9 @@
 <?php
 
-class xmlrpcmsg {
-    /// @todo: does these need to be public?
+class xmlrpcmsg
+{
+
+    /// @todo: do these need to be public?
     public $payload;
     public $methodname;
     public $params=array();

diff --git a/lib/xmlrpcresp.php b/lib/xmlrpcresp.php
index 527b463..22c9909 100644 (file)
--- a/lib/xmlrpcresp.php
+++ b/lib/xmlrpcresp.php
@@ -1,7 +1,9 @@
 <?php
 
-class xmlrpcresp {
-    /// @todo: does these need to be public?
+class xmlrpcresp
+{
+
+    /// @todo: do these need to be public?
     public $val = 0;
     public $valtyp;
     public $errno = 0;

diff --git a/lib/xmlrpcval.php b/lib/xmlrpcval.php
index 56c7af3..7cfca96 100644 (file)
--- a/lib/xmlrpcval.php
+++ b/lib/xmlrpcval.php
@@ -1,6 +1,7 @@
 <?php
 
-class xmlrpcval {
+class xmlrpcval
+{
 
     /// @todo: does these need to be public?
     public $me=array();