create OSModelAdmin. Update some Admin definitions to subclass OSModelAdmin
authorTony Mack <tmack@paris.CS.Princeton.EDU>
Sat, 27 Apr 2013 17:02:33 +0000 (13:02 -0400)
committerTony Mack <tmack@paris.CS.Princeton.EDU>
Sat, 27 Apr 2013 17:02:33 +0000 (13:02 -0400)
plstackapi/core/admin.py
plstackapi/core/models/role.py
plstackapi/core/models/site.py
plstackapi/core/models/slice.py
plstackapi/core/models/sliver.py
plstackapi/core/models/subnet.py

index be9d76b..81736ac 100644 (file)
@@ -45,6 +45,19 @@ class NodeInline(admin.TabularInline):
 class PlanetStackBaseAdmin(admin.ModelAdmin):
     save_on_top = False
 
+class OSModelAdmin(PlanetStackBaseAdmin):
+    """Attach client connection to openstack on delete() and save()""" 
+    def save_model(self, request, obj, form, change):
+        client = OpenStackClient(tenant=request.user.site.login_base, **request.session.get('auth', {}))
+        obj.driver = OpenStackDriver(client=client)
+        obj.save()
+
+    def delete_model(self, request, obj):
+        client = OpenStackClient(tenant=request.user.site.login_base, **request.session.get('auth', {}))
+        obj.driver = OpenStackDriver(client=client)
+        obj.delete()
+    
+
 class DeploymentNetworkAdminForm(forms.ModelForm):
     sites = forms.ModelMultipleChoiceField(
         queryset=Site.objects.all(),
@@ -77,7 +90,7 @@ class DeploymentNetworkAdmin(PlanetStackBaseAdmin):
     form = DeploymentNetworkAdminForm
     inlines = [NodeInline,]
 
-class SiteAdmin(admin.ModelAdmin):
+class SiteAdmin(OSModelAdmin):
     fieldsets = [
         (None, {'fields': ['name', 'site_url', 'enabled', 'is_public', 'login_base']}),
         ('Location', {'fields': ['latitude', 'longitude']}),
@@ -88,40 +101,36 @@ class SiteAdmin(admin.ModelAdmin):
     inlines = [NodeInline,]
     search_fields = ['name']
 
-class KeyAdmin(admin.ModelAdmin):
+class KeyAdmin(OSModelAdmin):
     fieldsets = [
         ('Key', {'fields': ['name', 'key', 'type', 'blacklisted', 'user']})
     ]
     list_display = ['name', 'key', 'type', 'blacklisted', 'user']
 
-    def save_model(self, request, obj, form, change):
-        # attach the caller's openstack clien connection to the object 
-        client = OpenStackClient(tenant=request.user.site.login_base, **request.session.get('auth', {}))
-        obj.driver = OpenStackDriver(client=client)
-        obj.save()
-
-    def delete_model(self, request, obj):
-        # attach the caller's openstack clien connection to the object 
-        client = OpenStackClient(tenant=request.user.site.login_base, **request.session.get('auth', {}))
-        obj.driver = OpenStackDriver(client=client)
-        obj.delete()
-    
     def get_queryset(self, request):
         # get keys user is allowed to see
         qs = super(KeyAdmin, self).get_queryset(request)
         if request.user.is_superuser:
             return qs
+        # users can only see their own keys
         return qs.filter(user=request.user)  
         
 
-class SliceAdmin(PlanetStackBaseAdmin):
+class SliceAdmin(OSModelAdmin):
     fields = ['name', 'site', 'instantiation', 'description', 'slice_url']
     list_display = ('name', 'site','slice_url', 'instantiation')
     inlines = [SliverInline]
 
-class SubnetAdmin(admin.ModelAdmin):
+    def get_queryset(self, request):
+        qs = super(SliceAdmin, self).get_queryset(request)
+        if request.user.is_superuser:
+            return qs
+        # users can only see slices at their site
+        return qs.filter(site=request.user.site) 
+
+class SubnetAdmin(OSModelAdmin):
     fields = ['cidr', 'ip_version', 'start', 'end', 'slice']
-    list_display = ('slice','cidr', 'start', 'end', 'ip_version' )
+    list_display = ('slice','cidr', 'start', 'end', 'ip_version')
 
 class ImageAdmin(admin.ModelAdmin):
     fields = ['image_id', 'name', 'disk_format', 'container_format']
@@ -130,7 +139,7 @@ class NodeAdmin(admin.ModelAdmin):
     list_display = ('name', 'site', 'deploymentNetwork')
     list_filter = ('deploymentNetwork',)
 
-class RoleAdmin(admin.ModelAdmin):
+class RoleAdmin(OSModelAdmin):
     fieldsets = [
         ('Role', {'fields': ['role_type']})
     ]
@@ -148,12 +157,13 @@ class SliverForm(forms.ModelForm):
             'ip': PlainTextWidget(),
         }
 
-class SliverAdmin(admin.ModelAdmin):
+class SliverAdmin(OSModelAdmin):
     form = SliverForm
     fieldsets = [
         ('Sliver', {'fields': ['ip', 'name', 'slice', 'flavor', 'image', 'key', 'node', 'deploymentNetwork']})
     ]
     list_display = ['ip', 'name', 'slice', 'flavor', 'image', 'key', 'node', 'deploymentNetwork']
+     
 
 class UserCreationForm(forms.ModelForm):
     """A form for creating new users. Includes all the required
index 4b4b2e4..b9f3e2f 100644 (file)
@@ -2,9 +2,6 @@ import os
 import datetime
 from django.db import models
 from plstackapi.core.models import PlCoreBase
-from plstackapi.openstack.driver import OpenStackDriver
-
-# Create your models here.
 
 class Role(PlCoreBase):
 
@@ -16,17 +13,13 @@ class Role(PlCoreBase):
 
 
     def save(self, *args, **kwds):
-        driver = OpenStackDriver() 
         if not self.role_id:
-            keystone_role = driver.create_role(name=self.role_type)
+            keystone_role = self.driver.create_role(name=self.role_type)
             self.role_id = keystone_role.id
-
         super(Role, self).save(*args, **kwds)
     
     def delete(self, *args, **kwds):
-        driver = OpenStackDriver()
         if self.role_id:
-            driver.delete_role({'id': self.role_id})   
-
+            self.driver.delete_role({'id': self.role_id})   
         super(Role, self).delete(*args, **kwds)
             
index 1e1cbe4..67b3e52 100644 (file)
@@ -2,9 +2,6 @@ import os
 from django.db import models
 from plstackapi.core.models import PlCoreBase
 from plstackapi.core.models import DeploymentNetwork
-from plstackapi.openstack.driver import OpenStackDriver
-
-# Create your models here.
 
 
 class Site(PlCoreBase):
@@ -24,26 +21,24 @@ class Site(PlCoreBase):
     def __unicode__(self):  return u'%s' % (self.name)
 
     def save(self, *args, **kwds):
-        driver  = OpenStackDriver()
         if not self.tenant_id:
-            tenant = driver.create_tenant(tenant_name=self.login_base, 
-                                          description=self.name, 
-                                          enabled=self.enabled)
+            tenant = self.driver.create_tenant(tenant_name=self.login_base, 
+                                               description=self.name, 
+                                               enabled=self.enabled)
             self.tenant_id = tenant.id
         # update the record
         if self.id:
-            driver.update_tenant(self.tenant_id, 
-                                 name=self.login_base,
-                                 description=self.name,
-                                 enabled=self.enabled)
+            self.driver.update_tenant(self.tenant_id, 
+                                      name=self.login_base,
+                                      description=self.name,
+                                      enabled=self.enabled)
 
         super(Site, self).save(*args, **kwds)               
 
 
     def delete(self, *args, **kwds):
-        driver = OpenStackDriver()
         if self.tenant_id:
-            driver.delete_tenant(self.tenant_id)
+            self.driver.delete_tenant(self.tenant_id)
         super(Site, self).delete(*args, **kwds)         
         
 
index 27184dc..d174b2e 100644 (file)
@@ -5,7 +5,6 @@ from plstackapi.core.models import Site
 from plstackapi.core.models import PLUser
 from plstackapi.core.models import Role
 from plstackapi.core.models import DeploymentNetwork
-from plstackapi.openstack.driver import OpenStackDriver
 
 # Create your models here.
 
@@ -25,31 +24,28 @@ class Slice(PlCoreBase):
     def __unicode__(self):  return u'%s' % (self.name)
 
     def save(self, *args, **kwds):
-
-        driver = OpenStackDriver()
         if not self.tenant_id:
             nova_fields = {'tenant_name': self.name,
                    'description': self.description,
                    'enabled': self.enabled}
-            tenant = driver.create_tenant(**nova_fields)
+            tenant = self.driver.create_tenant(**nova_fields)
             self.tenant_id = tenant.id
 
             # create network
-            network = driver.create_network(self.name)
+            network = self.driver.create_network(self.name)
             self.network_id = network['id']
 
             # create router
-            router = driver.create_router(self.name)
+            router = self.driver.create_router(self.name)
             self.router_id = router['id']
 
         super(Slice, self).save(*args, **kwds)
 
     def delete(self, *args, **kwds):
-        driver = OpenStackDriver()
         if self.tenant_id:
-            driver.delete_router(self.router_id)
-            driver.delete_network(self.network_id)
-            driver.delete_tenant(self.tenant_id)
+            self.driver.delete_router(self.router_id)
+            self.driver.delete_network(self.network_id)
+            self.driver.delete_tenant(self.tenant_id)
 
         super(Slice, self).delete(*args, **kwds)    
 
index 27b9ab1..13f94b2 100644 (file)
@@ -9,7 +9,6 @@ from plstackapi.core.models import Slice
 from plstackapi.core.models import Node
 from plstackapi.core.models import Site
 from plstackapi.core.models import DeploymentNetwork
-from plstackapi.openstack.driver import OpenStackDriver
 
 # Create your models here.
 class Sliver(PlCoreBase):
@@ -30,8 +29,7 @@ class Sliver(PlCoreBase):
             raise exceptions.ValidationError, "Slice %s has no subnet" % self.slice.name
 
         if not self.instance_id:
-            driver = OpenStackDriver()
-            instance = driver.spawn_instance(name=self.name,
+            instance = self.driver.spawn_instance(name=self.name,
                                    key_name = self.key.name,
                                    flavor_id = self.flavor.flavor_id,
                                    image_id = self.image.image_id,
@@ -41,8 +39,7 @@ class Sliver(PlCoreBase):
         super(Sliver, self).save(*args, **kwds)
 
     def delete(self, *args, **kwds):
-        driver = OpenStackDriver()
         if self.instance_id:
-            driver.destroy_instance(self.instance_id)
+            self.driver.destroy_instance(self.instance_id)
 
         super(Sliver, self).delete(*args, **kwds)
index 2e10ae1..c9ea1ef 100644 (file)
@@ -3,7 +3,6 @@ import commands
 from django.db import models
 from plstackapi.core.models import PlCoreBase
 from plstackapi.core.models import Slice
-from plstackapi.openstack.driver import OpenStackDriver
 
 # Create your models here.
 
@@ -18,10 +17,8 @@ class Subnet(PlCoreBase):
     def __unicode__(self):  return u'%s' % (self.slice.name)
 
     def save(self, *args, **kwds):
-
-        driver = OpenStackDriver()
         if not self.subnet_id:
-            quantum_subnet = driver.create_subnet(name= self.slice.name,
+            quantum_subnet = self.driver.create_subnet(name= self.slice.name,
                                           network_id=self.slice.network_id,
                                           cidr_ip = self.cidr,
                                           ip_version=self.ip_version,
@@ -29,17 +26,16 @@ class Subnet(PlCoreBase):
                                           end = self.end)
             self.subnet_id = quantum_subnet['id']
             # add subnet as interface to slice's router
-            driver.add_router_interface(self.slice.router_id, self.subnet_id)
+            self.driver.add_router_interface(self.slice.router_id, self.subnet_id)
             #add_route = 'route add -net %s dev br-ex gw 10.100.0.5' % self.cidr
             #commands.getstatusoutput(add_route)
 
         super(Subnet, self).save(*args, **kwds)
 
     def delete(self, *args, **kwds):
-        driver = OpenStackDriver()
         if self.subnet_id:
-            driver.delete_router_interface(self.slice.router_id, self.subnet_id) 
-            driver.delete_subnet(self.subnet_id)
+            self.driver.delete_router_interface(self.slice.router_id, self.subnet_id) 
+            self.driver.delete_subnet(self.subnet_id)
             #del_route = 'route del -net %s' % self.cidr 
             #commands.getstatusoutput(del_route)
         super(Subnet, self).delete(*args, **kwds)