gateway = None
networks = data['networks']
failedToGetSettings = False
+
+ # NOTE: GetInterfaces/NodeNetworks does not necessarily order the interfaces
+ # returned. Because 'interface'is decremented as each interface is processed,
+ # by the time is_primary=True (primary) interface is reached, the device
+ # "eth%s" % interface, is not eth0. But, something like eth-4, or eth-12.
+ # This code sorts the interfaces, placing is_primary=True interfaces first.
+ # There is a lot of room for improvement to how this
+ # script handles interfaces and how it chooses the primary interface.
+ def compare_by (fieldname):
+ def compare_two_dicts (a, b):
+ return cmp(a[fieldname], b[fieldname])
+ return compare_two_dicts
+
+ # NOTE: by sorting on 'is_primary' and then reversing (since False is sorted
+ # before True) all 'is_primary' interfaces are at the beginning of the list.
+ networks.sort( compare_by('is_primary') )
+ networks.reverse()
+
for network in networks:
logger.verbose('net:InitInterfaces interface %d: %s'%(interface,network))
logger.verbose('net:InitInterfaces macs = %s' % macs)
for setting in settings:
# to explicitly set interface name
- settingname = setting['name'].upper()
+ name_key = "name"
+ if version == 4.3:
+ name_key = "tagname"
+
+ settingname = setting[name_key].upper()
if settingname in ('IFNAME','ALIAS','CFGOPTIONS','DRIVER'):
inter[settingname]=setting['value']
+ # wireless settings
+ elif settingname in \
+ [ "MODE", "ESSID", "NW", "FREQ", "CHANNEL", "SENS", "RATE",
+ "KEY", "KEY1", "KEY2", "KEY3", "KEY4", "SECURITYMODE",
+ "IWCONFIG", "IWPRIV" ] :
+ inter [settingname] = setting['value']
+ inter ['TYPE']='Wireless'
else:
- logger.log("net:InitInterfaces WARNING: ignored setting named %s"%setting['name'])
+ logger.log("net:InitInterfaces WARNING: ignored setting named %s"%setting[name_key])
# support aliases to interfaces either by name or HWADDR
if 'ALIAS' in inter:
(inter['IFNAME'],hwifname))
inter['IFNAME'] = hwifname
else:
- logger.log('net:InitInterfaces WARNING: mac addr %s for alias not found' %(hwaddr,alias))
+ logger.log('net:InitInterfaces WARNING: mac addr %s for alias not found' %(hwaddr))
if 'IFNAME' in inter:
# stupid RH /etc/sysconfig/network-scripts/ifup-aliases:new_interface()
m = modprobe.Modprobe()
try:
- m.input("%s/etc/modprobe.conf" % root, program)
+ m.input("%s/etc/modprobe.conf" % root)
except:
pass
for (dev, inter) in interfaces.iteritems():
options=" ".join(driver[1:])
if options <> '':
m.optionsset(dev,options)
- m.output("%s/etc/modprobe.conf" % root)
+ m.output("%s/etc/modprobe.conf" % root, program)
# clean up after any ifcfg-$dev script that's no longer listed as
# part of the NodeNetworks associated with this node