- fix writing sfatables rules

[sfa.git] / sfatables / commands / List.py

diff --git a/sfatables/commands/List.py b/sfatables/commands/List.py
index 3a0bb39..fcb1413 100644 (file)
--- a/sfatables/commands/List.py
+++ b/sfatables/commands/List.py
@@ -2,8 +2,8 @@ import os, time
 import libxml2
 import pdb
 
-from globals import *
-from pretty import Pretty
+from sfatables.globals import *
+from sfatables.pretty import Pretty
 from sfatables.command import Command
 
 class List(Command):
@@ -16,44 +16,64 @@ class List(Command):
     def __init__(self):
         return
 
-
-    def get_info(self, xmlextension_path):
+    def get_info(self, type, xmlextension_path):
         xmldoc = libxml2.parseFile(xmlextension_path)
         p = xmldoc.xpathNewContext()
         
-        ext_name_node = p.xpathEval("/match/@name")
+        ext_name_node = p.xpathEval("/%s/@name"%type)
         ext_name = ext_name_node[0].content
 
         name_nodes = p.xpathEval("//rule/argument[value!='']/name")
         value_nodes = p.xpathEval("//rule/argument[value!='']/value")
+        element_nodes = p.xpathEval("//argument[value!='']/parent::rule/@element")
+
+        print element_nodes, type, xmlextension_path
+        if (len(element_nodes)>1):
+            raise Exception("Invalid rule %s contains multiple elements."%xmlextension_path)
 
-        names = [n.content for n in name_nodes]
-        values = [v.content for v in value_nodes]
+        element = []
+        argument_str = ""
+        if element_nodes:
+            element = element_nodes[0].content
 
-        name_values = zip(names,values)
-        name_value_pairs = map(lambda (n,v):n+'='+v, name_values)
+            names = [n.content for n in name_nodes]
+            values = [v.content for v in value_nodes]
 
-        argument_str = ",".join(name_value_pairs)
+            name_values = zip(names,values)
+            name_value_pairs = map(lambda (n,v):n+'='+v, name_values)
+
+            argument_str = ",".join(name_value_pairs)
 
         p.xpathFreeContext()
         xmldoc.freeDoc()
 
-        return {'name':ext_name, 'arguments':'argument_str'}
+        return {'name':ext_name, 'arguments':argument_str, 'element':element}
+
+    def get_rule_list(self, chain_dir_path):
+        broken_semantics = os.walk(chain_dir_path)
+        rule_numbers = {}
 
-    def call(self, command_options, match_options, target_options):
-        chain = command_options.args[0]
-        chain_dir = sfatables_config + "/" + chain
-        rule_list = []
-        broken_semantics = os.walk(chain_dir)
         for (root, dirs, files) in broken_semantics:
             for file in files:
                 if (file.startswith('sfatables')):
                     (magic,number,type) = file.split('-')
-                    rule_list.append(int(number))
+                    rule_numbers[int(number)]=1
 
+        rule_list = rule_numbers.keys()
         rule_list.sort()
+        return rule_list
+
+    def call(self, command_options, match_options, target_options):
+        if (len(command_options.args) < 1):
+            print "Please specify the name of the chain you would like to list, e.g. sfatables -L INCOMING."
+            return
 
-        pretty = Pretty(['Rule','Match','Target','Arguments'])
+        chain = command_options.args[0]
+        chain_dir = os.path.join(sfatables_config, chain)
+
+        rule_list = self.get_rule_list(chain_dir)
+
+        pretty = Pretty(['Rule','Match','Arguments','Target','Element','Arguments'])
 
         for number in rule_list:
             match_file = "sfatables-%d-%s"%(number,'match')
@@ -61,16 +81,20 @@ class List(Command):
 
             match_path = sfatables_config + '/' + chain + '/' + match_file
             target_path = sfatables_config + '/' + chain + '/' + target_file
-            
-            match_info = self.get_info (match_path)
-            target_info = self.get_info (target_path)
 
-            pretty.push_row(["%d"%number,  match_info['name'], match_info['arguments'], target_info['arguments']])
-        
-        
+            match_info = self.get_info ('match',match_path)
+            target_info = self.get_info ('target',target_path)
+
+            pretty.push_row(["%d"%number,
+                             match_info['name'],
+                             match_info['arguments'],
+                             target_info['name'],
+                             target_info['element'],
+                             target_info['arguments']])
+
         pretty.pprint()
 
-            
+