fixed a bug when checking for invalid records
authorTony Mack <tmack@cs.princeton.edu>
Mon, 12 Apr 2010 18:36:04 +0000 (18:36 +0000)
committerTony Mack <tmack@cs.princeton.edu>
Mon, 12 Apr 2010 18:36:04 +0000 (18:36 +0000)
sfa/server/interface.py

index 7172ef9..d6dc5c4 100644 (file)
@@ -166,9 +166,9 @@ class Interfaces(dict):
             interfaces = [interfaces]
         for interface in interfaces:
             # make sure the required fields are present and not null
-            for key in required_fields:
-                if not interface.get(key):
-                    continue 
+            if not all([interface.get(key) for key in required_fields]):
+                continue
             hrn, address, port = interface['hrn'], interface['addr'], interface['port']
             url = 'http://%(address)s:%(port)s' % locals()
             # check which client we should use