-/* Copyright (c) 2011 Nicira Networks
+/* Copyright (c) 2011 Nicira, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
#include "ofpbuf.h"
#include "packets.h"
#include "poll-loop.h"
+#include "shash.h"
#include "timer.h"
#include "timeval.h"
#include "unixctl.h"
VLOG_DEFINE_THIS_MODULE(lacp);
+/* Masks for lacp_info state member. */
+#define LACP_STATE_ACT 0x01 /* Activity. Active or passive? */
+#define LACP_STATE_TIME 0x02 /* Timeout. Short or long timeout? */
+#define LACP_STATE_AGG 0x04 /* Aggregation. Is the link is bondable? */
+#define LACP_STATE_SYNC 0x08 /* Synchronization. Is the link in up to date? */
+#define LACP_STATE_COL 0x10 /* Collecting. Is the link receiving frames? */
+#define LACP_STATE_DIST 0x20 /* Distributing. Is the link sending frames? */
+#define LACP_STATE_DEF 0x40 /* Defaulted. Using default partner info? */
+#define LACP_STATE_EXP 0x80 /* Expired. Using expired partner info? */
+
+#define LACP_FAST_TIME_TX 1000 /* Fast transmission rate. */
+#define LACP_SLOW_TIME_TX 30000 /* Slow transmission rate. */
+#define LACP_RX_MULTIPLIER 3 /* Multiply by TX rate to get RX rate. */
+
+#define LACP_INFO_LEN 15
+struct lacp_info {
+ ovs_be16 sys_priority; /* System priority. */
+ uint8_t sys_id[ETH_ADDR_LEN]; /* System ID. */
+ ovs_be16 key; /* Operational key. */
+ ovs_be16 port_priority; /* Port priority. */
+ ovs_be16 port_id; /* Port ID. */
+ uint8_t state; /* State mask. See LACP_STATE macros. */
+} __attribute__((packed));
+BUILD_ASSERT_DECL(LACP_INFO_LEN == sizeof(struct lacp_info));
+
+#define LACP_PDU_LEN 110
+struct lacp_pdu {
+ uint8_t subtype; /* Always 1. */
+ uint8_t version; /* Always 1. */
+
+ uint8_t actor_type; /* Always 1. */
+ uint8_t actor_len; /* Always 20. */
+ struct lacp_info actor; /* LACP actor information. */
+ uint8_t z1[3]; /* Reserved. Always 0. */
+
+ uint8_t partner_type; /* Always 2. */
+ uint8_t partner_len; /* Always 20. */
+ struct lacp_info partner; /* LACP partner information. */
+ uint8_t z2[3]; /* Reserved. Always 0. */
+
+ uint8_t collector_type; /* Always 3. */
+ uint8_t collector_len; /* Always 16. */
+ ovs_be16 collector_delay; /* Maximum collector delay. Set to UINT16_MAX. */
+ uint8_t z3[64]; /* Combination of several fields. Always 0. */
+} __attribute__((packed));
+BUILD_ASSERT_DECL(LACP_PDU_LEN == sizeof(struct lacp_pdu));
+\f
+/* Implementation. */
+
enum slave_status {
LACP_CURRENT, /* Current State. Partner up to date. */
LACP_EXPIRED, /* Expired State. Partner out of date. */
struct hmap slaves; /* Slaves this LACP object controls. */
struct slave *key_slave; /* Slave whose ID will be the aggregation key. */
- bool fast; /* Fast or Slow LACP time. */
+ bool fast; /* True if using fast probe interval. */
bool negotiated; /* True if LACP negotiations were successful. */
bool update; /* True if lacp_update() needs to be called. */
};
struct lacp *lacp; /* LACP object containing this slave. */
uint16_t port_id; /* Port ID. */
uint16_t port_priority; /* Port Priority. */
+ uint16_t key; /* Aggregation Key. 0 if default. */
char *name; /* Name of this slave. */
enum slave_status status; /* Slave status. */
bool attached; /* Attached. Traffic may flow. */
- bool enabled; /* Enabled. Traffic is flowing. */
struct lacp_info partner; /* Partner information. */
struct lacp_info ntt_actor; /* Used to decide if we Need To Transmit. */
struct timer tx; /* Next message transmission timer. */
static struct slave *slave_lookup(const struct lacp *, const void *slave);
static bool info_tx_equal(struct lacp_info *, struct lacp_info *);
-static void lacp_unixctl_show(struct unixctl_conn *, const char *args,
- void *aux);
+static unixctl_cb_func lacp_unixctl_show;
+
+/* Populates 'pdu' with a LACP PDU comprised of 'actor' and 'partner'. */
+static void
+compose_lacp_pdu(const struct lacp_info *actor,
+ const struct lacp_info *partner, struct lacp_pdu *pdu)
+{
+ memset(pdu, 0, sizeof *pdu);
+
+ pdu->subtype = 1;
+ pdu->version = 1;
+
+ pdu->actor_type = 1;
+ pdu->actor_len = 20;
+ pdu->actor = *actor;
+
+ pdu->partner_type = 2;
+ pdu->partner_len = 20;
+ pdu->partner = *partner;
+
+ pdu->collector_type = 3;
+ pdu->collector_len = 16;
+ pdu->collector_delay = htons(0);
+}
+
+/* Parses 'b' which represents a packet containing a LACP PDU. This function
+ * returns NULL if 'b' is malformed, or does not represent a LACP PDU format
+ * supported by OVS. Otherwise, it returns a pointer to the lacp_pdu contained
+ * within 'b'. */
+static const struct lacp_pdu *
+parse_lacp_packet(const struct ofpbuf *b)
+{
+ const struct lacp_pdu *pdu;
+
+ pdu = ofpbuf_at(b, (uint8_t *)b->l3 - (uint8_t *)b->data, LACP_PDU_LEN);
+
+ if (pdu && pdu->subtype == 1
+ && pdu->actor_type == 1 && pdu->actor_len == 20
+ && pdu->partner_type == 2 && pdu->partner_len == 20) {
+ return pdu;
+ } else {
+ return NULL;
+ }
+}
+\f
+/* LACP Protocol Implementation. */
/* Initializes the lacp module. */
void
lacp_init(void)
{
- unixctl_command_register("lacp/show", lacp_unixctl_show, NULL);
+ unixctl_command_register("lacp/show", "[port]", 0, 1,
+ lacp_unixctl_show, NULL);
}
/* Creates a LACP object. */
void
lacp_configure(struct lacp *lacp, const struct lacp_settings *s)
{
+ assert(!eth_addr_is_zero(s->id));
+
if (!lacp->name || strcmp(s->name, lacp->name)) {
free(lacp->name);
lacp->name = xstrdup(s->name);
}
- memcpy(lacp->sys_id, s->id, ETH_ADDR_LEN);
- lacp->sys_priority = s->priority;
+ if (!eth_addr_equals(lacp->sys_id, s->id)
+ || lacp->sys_priority != s->priority) {
+ memcpy(lacp->sys_id, s->id, ETH_ADDR_LEN);
+ lacp->sys_priority = s->priority;
+ lacp->update = true;
+ }
+
lacp->active = s->active;
lacp->fast = s->fast;
}
return lacp->active;
}
-/* Processes 'pdu', a parsed LACP packet received on 'slave_'. This function
- * should be called on all packets received on 'slave_' with Ethernet Type
- * ETH_TYPE_LACP and parsable by parse_lacp_packet(). */
+/* Processes 'packet' which was received on 'slave_'. This function should be
+ * called on all packets received on 'slave_' with Ethernet Type ETH_TYPE_LACP.
+ */
void
-lacp_process_pdu(struct lacp *lacp, const void *slave_,
- const struct lacp_pdu *pdu)
+lacp_process_packet(struct lacp *lacp, const void *slave_,
+ const struct ofpbuf *packet)
{
+ static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(1, 5);
struct slave *slave = slave_lookup(lacp, slave_);
+ const struct lacp_pdu *pdu;
+ long long int tx_rate;
+
+ pdu = parse_lacp_packet(packet);
+ if (!pdu) {
+ VLOG_WARN_RL(&rl, "%s: received an unparsable LACP PDU.", lacp->name);
+ return;
+ }
slave->status = LACP_CURRENT;
- timer_set_duration(&slave->rx, (lacp->fast
- ? LACP_FAST_TIME_RX
- : LACP_SLOW_TIME_RX));
+ tx_rate = lacp->fast ? LACP_FAST_TIME_TX : LACP_SLOW_TIME_TX;
+ timer_set_duration(&slave->rx, LACP_RX_MULTIPLIER * tx_rate);
slave->ntt_actor = pdu->partner;
}
}
-/* Returns true if 'lacp' has successfully negotiated with its partner. False
- * if 'lacp' is NULL. */
-bool
-lacp_negotiated(const struct lacp *lacp)
+/* Returns the lacp_status of the given 'lacp' object (which may be NULL). */
+enum lacp_status
+lacp_status(const struct lacp *lacp)
{
- return lacp ? lacp->negotiated : false;
+ if (!lacp) {
+ return LACP_DISABLED;
+ } else if (lacp->negotiated) {
+ return LACP_NEGOTIATED;
+ } else {
+ return LACP_CONFIGURED;
+ }
}
/* Registers 'slave_' as subordinate to 'lacp'. This should be called at least
slave->name = xstrdup(s->name);
}
- if (slave->port_id != s->id || slave->port_priority != s->priority) {
+ if (slave->port_id != s->id
+ || slave->port_priority != s->priority
+ || slave->key != s->key) {
slave->port_id = s->id;
slave->port_priority = s->priority;
+ slave->key = s->key;
lacp->update = true;
if (slave) {
slave_destroy(slave);
+ lacp->update = true;
}
}
-/* Should be called regularly to indicate whether 'slave_' is enabled. An
- * enabled slave is allowed to send and receive traffic. Generally a slave
- * should not be enabled if its carrier is down, or lacp_slave_may_enable()
- * indicates it should not be enabled. */
-void
-lacp_slave_enable(struct lacp *lacp, void *slave_, bool enabled)
-{
- slave_lookup(lacp, slave_)->enabled = enabled;
-}
-
/* This function should be called whenever the carrier status of 'slave_' has
- * changed. */
+ * changed. If 'lacp' is null, this function has no effect.*/
void
lacp_slave_carrier_changed(const struct lacp *lacp, const void *slave_)
{
- struct slave *slave = slave_lookup(lacp, slave_);
+ if (lacp) {
+ struct slave *slave = slave_lookup(lacp, slave_);
- if (slave->status == LACP_CURRENT || slave->lacp->active) {
- slave_set_expired(slave);
+ if (slave->status == LACP_CURRENT || slave->lacp->active) {
+ slave_set_expired(slave);
+ }
}
}
struct slave *slave = slave_lookup(lacp, slave_);
/* The slave may be enabled if it's attached to an aggregator and its
- * partner is synchronized. The only exception is defaulted slaves.
- * They are not required to have synchronized partners because they
- * have no partners at all. They will only be attached if negotiations
- * failed on all slaves in the bond. */
- return slave->attached && (slave->partner.state & LACP_STATE_SYNC
- || slave->status == LACP_DEFAULTED);
+ * partner is synchronized.*/
+ return slave->attached && (slave->partner.state & LACP_STATE_SYNC);
} else {
return true;
}
}
+/* Returns the port ID used for 'slave_' in LACP communications. */
+uint16_t
+lacp_slave_get_port_id(const struct lacp *lacp, const void *slave_)
+{
+ struct slave *slave = slave_lookup(lacp, slave_);
+ return slave->port_id;
+}
+
+/* Returns true if partner information on 'slave_' is up to date. 'slave_'
+ * not being current, generally indicates a connectivity problem, or a
+ * misconfigured (or broken) partner. */
+bool
+lacp_slave_is_current(const struct lacp *lacp, const void *slave_)
+{
+ return slave_lookup(lacp, slave_)->status != LACP_DEFAULTED;
+}
+
/* This function should be called periodically to update 'lacp'. */
void
lacp_run(struct lacp *lacp, lacp_send_pdu *send_pdu)
}
HMAP_FOR_EACH (slave, node, &lacp->slaves) {
- struct lacp_pdu pdu;
struct lacp_info actor;
if (!slave_may_tx(slave)) {
if (timer_expired(&slave->tx)
|| !info_tx_equal(&actor, &slave->ntt_actor)) {
+ long long int duration;
+ struct lacp_pdu pdu;
slave->ntt_actor = actor;
compose_lacp_pdu(&actor, &slave->partner, &pdu);
- send_pdu(slave->aux, &pdu);
+ send_pdu(slave->aux, &pdu, sizeof pdu);
- timer_set_duration(&slave->tx,
- (slave->partner.state & LACP_STATE_TIME
- ? LACP_FAST_TIME_TX
- : LACP_SLOW_TIME_TX));
+ duration = (slave->partner.state & LACP_STATE_TIME
+ ? LACP_FAST_TIME_TX
+ : LACP_SLOW_TIME_TX);
+
+ timer_set_duration(&slave->tx, duration);
}
}
}
\f
/* Static Helpers. */
-/* Updates the attached status of all slaves controlled b 'lacp' and sets its
+/* Updates the attached status of all slaves controlled by 'lacp' and sets its
* negotiated parameter to true if any slaves are attachable. */
static void
lacp_update_attached(struct lacp *lacp)
HMAP_FOR_EACH (slave, node, &lacp->slaves) {
struct lacp_info pri;
- slave->attached = true;
+ slave->attached = false;
/* XXX: In the future allow users to configure the expected system ID.
* For now just special case loopback. */
if (eth_addr_equals(slave->partner.sys_id, slave->lacp->sys_id)) {
VLOG_WARN_RL(&rl, "slave %s: Loopback detected. Slave is "
"connected to its own bond", slave->name);
- slave->attached = false;
continue;
}
continue;
}
+ slave->attached = true;
slave_get_priority(slave, &pri);
if (!lead || memcmp(&pri, &lead_pri, sizeof pri) < 0) {
if (lead) {
HMAP_FOR_EACH (slave, node, &lacp->slaves) {
- if (slave->status == LACP_DEFAULTED
- || lead->partner.key != slave->partner.key
+ if (lead->partner.key != slave->partner.key
|| !eth_addr_equals(lead->partner.sys_id,
slave->partner.sys_id)) {
slave->attached = false;
slave->status = LACP_EXPIRED;
slave->partner.state |= LACP_STATE_TIME;
slave->partner.state &= ~LACP_STATE_SYNC;
- timer_set_duration(&slave->rx, LACP_FAST_TIME_RX);
+
+ timer_set_duration(&slave->rx, LACP_RX_MULTIPLIER * LACP_FAST_TIME_TX);
}
static void
slave_get_actor(struct slave *slave, struct lacp_info *actor)
{
+ struct lacp *lacp = slave->lacp;
+ uint16_t key;
uint8_t state = 0;
- if (slave->lacp->active) {
+ if (lacp->active) {
state |= LACP_STATE_ACT;
}
- if (slave->lacp->fast) {
+ if (lacp->fast) {
state |= LACP_STATE_TIME;
}
state |= LACP_STATE_EXP;
}
- if (hmap_count(&slave->lacp->slaves) > 1) {
+ if (hmap_count(&lacp->slaves) > 1) {
state |= LACP_STATE_AGG;
}
- if (slave->enabled) {
+ if (slave->attached || !lacp->negotiated) {
state |= LACP_STATE_COL | LACP_STATE_DIST;
}
+ key = lacp->key_slave->key;
+ if (!key) {
+ key = lacp->key_slave->port_id;
+ }
+
actor->state = state;
- actor->key = htons(slave->lacp->key_slave->port_id);
+ actor->key = htons(key);
actor->port_priority = htons(slave->port_priority);
actor->port_id = htons(slave->port_id);
- actor->sys_priority = htons(slave->lacp->sys_priority);
- memcpy(&actor->sys_id, slave->lacp->sys_id, ETH_ADDR_LEN);
+ actor->sys_priority = htons(lacp->sys_priority);
+ memcpy(&actor->sys_id, lacp->sys_id, ETH_ADDR_LEN);
}
/* Given 'slave', populates 'priority' with data representing its LACP link
ds_put_lacp_state(struct ds *ds, uint8_t state)
{
if (state & LACP_STATE_ACT) {
- ds_put_cstr(ds, "activity ");
+ ds_put_cstr(ds, " activity");
}
if (state & LACP_STATE_TIME) {
- ds_put_cstr(ds, "timeout ");
+ ds_put_cstr(ds, " timeout");
}
if (state & LACP_STATE_AGG) {
- ds_put_cstr(ds, "aggregation ");
+ ds_put_cstr(ds, " aggregation");
}
if (state & LACP_STATE_SYNC) {
- ds_put_cstr(ds, "synchronized ");
+ ds_put_cstr(ds, " synchronized");
}
if (state & LACP_STATE_COL) {
- ds_put_cstr(ds, "collecting ");
+ ds_put_cstr(ds, " collecting");
}
if (state & LACP_STATE_DIST) {
- ds_put_cstr(ds, "distributing ");
+ ds_put_cstr(ds, " distributing");
}
if (state & LACP_STATE_DEF) {
- ds_put_cstr(ds, "defaulted ");
+ ds_put_cstr(ds, " defaulted");
}
if (state & LACP_STATE_EXP) {
- ds_put_cstr(ds, "expired ");
+ ds_put_cstr(ds, " expired");
}
}
static void
-lacp_unixctl_show(struct unixctl_conn *conn,
- const char *args, void *aux OVS_UNUSED)
+lacp_print_details(struct ds *ds, struct lacp *lacp)
{
- struct ds ds = DS_EMPTY_INITIALIZER;
- struct lacp *lacp;
+ struct shash slave_shash = SHASH_INITIALIZER(&slave_shash);
+ const struct shash_node **sorted_slaves = NULL;
+
struct slave *slave;
+ int i;
- lacp = lacp_find(args);
- if (!lacp) {
- unixctl_command_reply(conn, 501, "no such lacp object");
- return;
+ ds_put_format(ds, "---- %s ----\n", lacp->name);
+ ds_put_format(ds, "\tstatus: %s", lacp->active ? "active" : "passive");
+ if (lacp->negotiated) {
+ ds_put_cstr(ds, " negotiated");
}
+ ds_put_cstr(ds, "\n");
- ds_put_format(&ds, "lacp: %s\n", lacp->name);
- ds_put_format(&ds, "\tstatus: %s %s\n",
- lacp->active ? "active" : "passive",
- lacp->negotiated ? "negotiated" : "");
- ds_put_format(&ds, "\tsys_id: " ETH_ADDR_FMT "\n", ETH_ADDR_ARGS(lacp->sys_id));
- ds_put_format(&ds, "\tsys_priority: %u\n", lacp->sys_priority);
- ds_put_cstr(&ds, "\taggregation key: ");
+ ds_put_format(ds, "\tsys_id: " ETH_ADDR_FMT "\n", ETH_ADDR_ARGS(lacp->sys_id));
+ ds_put_format(ds, "\tsys_priority: %u\n", lacp->sys_priority);
+ ds_put_cstr(ds, "\taggregation key: ");
if (lacp->key_slave) {
- ds_put_format(&ds, "%u", lacp->key_slave->port_id);
+ ds_put_format(ds, "%u", lacp->key_slave->port_id);
+ } else {
+ ds_put_cstr(ds, "none");
+ }
+ ds_put_cstr(ds, "\n");
+
+ ds_put_cstr(ds, "\tlacp_time: ");
+ if (lacp->fast) {
+ ds_put_cstr(ds, "fast\n");
} else {
- ds_put_cstr(&ds, "none");
+ ds_put_cstr(ds, "slow\n");
}
- ds_put_cstr(&ds, "\n");
HMAP_FOR_EACH (slave, node, &lacp->slaves) {
+ shash_add(&slave_shash, slave->name, slave);
+ }
+ sorted_slaves = shash_sort(&slave_shash);
+
+ for (i = 0; i < shash_count(&slave_shash); i++) {
char *status;
struct lacp_info actor;
+ slave = sorted_slaves[i]->data;
slave_get_actor(slave, &actor);
switch (slave->status) {
case LACP_CURRENT:
NOT_REACHED();
}
- ds_put_format(&ds, "\nslave: %s: %s %s %s\n", slave->name, status,
- slave->attached ? "attached" : "detached",
- slave->enabled ? "enabled" : "disabled");
- ds_put_format(&ds, "\tport_id: %u\n", slave->port_id);
- ds_put_format(&ds, "\tport_priority: %u\n", slave->port_priority);
+ ds_put_format(ds, "\nslave: %s: %s %s\n", slave->name, status,
+ slave->attached ? "attached" : "detached");
+ ds_put_format(ds, "\tport_id: %u\n", slave->port_id);
+ ds_put_format(ds, "\tport_priority: %u\n", slave->port_priority);
- ds_put_format(&ds, "\n\tactor sys_id: " ETH_ADDR_FMT "\n",
+ ds_put_format(ds, "\n\tactor sys_id: " ETH_ADDR_FMT "\n",
ETH_ADDR_ARGS(actor.sys_id));
- ds_put_format(&ds, "\tactor sys_priority: %u\n",
+ ds_put_format(ds, "\tactor sys_priority: %u\n",
ntohs(actor.sys_priority));
- ds_put_format(&ds, "\tactor port_id: %u\n",
+ ds_put_format(ds, "\tactor port_id: %u\n",
ntohs(actor.port_id));
- ds_put_format(&ds, "\tactor port_priority: %u\n",
+ ds_put_format(ds, "\tactor port_priority: %u\n",
ntohs(actor.port_priority));
- ds_put_format(&ds, "\tactor key: %u\n",
+ ds_put_format(ds, "\tactor key: %u\n",
ntohs(actor.key));
- ds_put_cstr(&ds, "\tactor state: ");
- ds_put_lacp_state(&ds, actor.state);
- ds_put_cstr(&ds, "\n\n");
+ ds_put_cstr(ds, "\tactor state:");
+ ds_put_lacp_state(ds, actor.state);
+ ds_put_cstr(ds, "\n\n");
- ds_put_format(&ds, "\tpartner sys_id: " ETH_ADDR_FMT "\n",
+ ds_put_format(ds, "\tpartner sys_id: " ETH_ADDR_FMT "\n",
ETH_ADDR_ARGS(slave->partner.sys_id));
- ds_put_format(&ds, "\tpartner sys_priority: %u\n",
+ ds_put_format(ds, "\tpartner sys_priority: %u\n",
ntohs(slave->partner.sys_priority));
- ds_put_format(&ds, "\tpartner port_id: %u\n",
+ ds_put_format(ds, "\tpartner port_id: %u\n",
ntohs(slave->partner.port_id));
- ds_put_format(&ds, "\tpartner port_priority: %u\n",
+ ds_put_format(ds, "\tpartner port_priority: %u\n",
ntohs(slave->partner.port_priority));
- ds_put_format(&ds, "\tpartner key: %u\n",
+ ds_put_format(ds, "\tpartner key: %u\n",
ntohs(slave->partner.key));
- ds_put_cstr(&ds, "\tpartner state: ");
- ds_put_lacp_state(&ds, slave->partner.state);
- ds_put_cstr(&ds, "\n");
+ ds_put_cstr(ds, "\tpartner state:");
+ ds_put_lacp_state(ds, slave->partner.state);
+ ds_put_cstr(ds, "\n");
+ }
+
+ shash_destroy(&slave_shash);
+ free(sorted_slaves);
+}
+
+static void
+lacp_unixctl_show(struct unixctl_conn *conn, int argc, const char *argv[],
+ void *aux OVS_UNUSED)
+{
+ struct ds ds = DS_EMPTY_INITIALIZER;
+ struct lacp *lacp;
+
+ if (argc > 1) {
+ lacp = lacp_find(argv[1]);
+ if (!lacp) {
+ unixctl_command_reply_error(conn, "no such lacp object");
+ return;
+ }
+ lacp_print_details(&ds, lacp);
+ } else {
+ LIST_FOR_EACH (lacp, node, &all_lacps) {
+ lacp_print_details(&ds, lacp);
+ }
}
- unixctl_command_reply(conn, 200, ds_cstr(&ds));
+ unixctl_command_reply(conn, ds_cstr(&ds));
ds_destroy(&ds);
}
git://git.onelab.eu / sliver-openvswitch.git / blobdiff