cfm: No longer keep track of bad CCMs.
authorEthan Jackson <ethan@nicira.com>
Thu, 12 May 2011 00:50:16 +0000 (17:50 -0700)
committerEthan Jackson <ethan@nicira.com>
Fri, 13 May 2011 20:09:27 +0000 (13:09 -0700)
commitaa7f11584301a81cbf89a7557bc0acc3c0e3b9ad
tree14c0c01a75d575434cc718e84b3d4ff6cb36b0a4
parent5e80932275419e688b3ad608d6371867953fe4b9
cfm: No longer keep track of bad CCMs.

According to the 802.1ag specification, reception of a CCM from an
unexpected source should trigger a fault. This patch causes the CFM
module to simply warn instead.  There are several reasons for this
change outlined below.

  - Faults can cause controllers to make potentially expensive
    changes to the network topology.
  - Faults can be maliciously triggered by crafting invalid CCMs.
  - With this patch, cfm->fault and rmp->fault are only updated in
    cfm_run() making the code easier to debug and reason about.
lib/cfm.c