dpif-linux: Use MAX_PORTS instead of hard-coded 65535.
authorBen Pfaff <blp@nicira.com>
Wed, 1 May 2013 23:54:18 +0000 (16:54 -0700)
committerBen Pfaff <blp@nicira.com>
Thu, 2 May 2013 17:06:35 +0000 (10:06 -0700)
MAX_PORTS is currently USHRT_MAX (also 65535).  I think that's a
coincidence; I don't remember MAX_PORTS being mentioned when the new
dpif_channel code was written.

Signed-off-by: Ben Pfaff <blp@nicira.com>
lib/dpif-linux.c

index b863a2e..39acc9a 100644 (file)
@@ -312,7 +312,7 @@ add_channel(struct dpif_linux *dpif, uint32_t port_no, struct nl_sock *sock)
         int new_size = port_no + 1;
         int i;
 
-        if (new_size > 65535) {
+        if (new_size > MAX_PORTS) {
             VLOG_WARN_RL(&error_rl, "%s: datapath port %"PRIu32" too big",
                          dpif_name(&dpif->dpif), port_no);
             return EFBIG;