datapath: Fix typo in flow validation logic.
authorJesse Gross <jesse@nicira.com>
Fri, 9 Aug 2013 22:27:27 +0000 (15:27 -0700)
committerJesse Gross <jesse@nicira.com>
Fri, 9 Aug 2013 22:54:42 +0000 (15:54 -0700)
A bit shift operation is using the value '11' instead of '1' as the
starting value. This only makes validation weaker than it should be
so unless userspace is trying to install an invalid flow there will
be no effect.

Signed-off-by: Jesse Gross <jesse@nicira.com>
Acked-by: Kyle Mestery <kmestery@cisco.com>
datapath/flow.c

index e610065..4075350 100644 (file)
@@ -138,7 +138,7 @@ static bool ovs_match_validate(const struct sw_flow_match *match,
        /* Always allowed mask fields. */
        mask_allowed |= ((1ULL << OVS_KEY_ATTR_TUNNEL)
                       | (1ULL << OVS_KEY_ATTR_IN_PORT)
-                      | (11ULL << OVS_KEY_ATTR_ETHERTYPE));
+                      | (1ULL << OVS_KEY_ATTR_ETHERTYPE));
 
        /* Check key attributes. */
        if (match->key->eth.type == htons(ETH_P_ARP)