ofproto-dpif: Reconfigure when netflow is enabled/disabled.
authorEthan Jackson <ethan@nicira.com>
Wed, 19 Jun 2013 01:03:32 +0000 (18:03 -0700)
committerEthan Jackson <ethan@nicira.com>
Wed, 19 Jun 2013 20:22:05 +0000 (13:22 -0700)
The presence or absence of netflow affects wildcarding, and
therefore need to cause a revalidation when changed.

Found by inspection.

Signed-off-by: Ethan Jackson <ethan@nicira.com>
Acked-by: Ben Pfaff <blp@nicira.com>
ofproto/ofproto-dpif.c

index 1b3b1e3..52d2277 100644 (file)
@@ -5614,13 +5614,16 @@ set_netflow(struct ofproto *ofproto_,
     if (netflow_options) {
         if (!ofproto->netflow) {
             ofproto->netflow = netflow_create();
+            ofproto->backer->need_revalidate = REV_RECONFIGURE;
         }
         return netflow_set_options(ofproto->netflow, netflow_options);
-    } else {
+    } else if (ofproto->netflow) {
+        ofproto->backer->need_revalidate = REV_RECONFIGURE;
         netflow_destroy(ofproto->netflow);
         ofproto->netflow = NULL;
-        return 0;
     }
+
+    return 0;
 }
 
 static void