git://git.onelab.eu
/
sliver-openvswitch.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
9092532
)
daemon: report error if daemon child process fails to start properly
author
Ben Pfaff
<blp@nicira.com>
Fri, 9 Jan 2009 01:00:06 +0000
(17:00 -0800)
committer
Ben Pfaff
<blp@nicira.com>
Tue, 13 Jan 2009 01:17:25 +0000
(17:17 -0800)
Found by Chris Eagle via Fortify.
lib/daemon.c
patch
|
blob
|
history
diff --git
a/lib/daemon.c
b/lib/daemon.c
index
b8fc5af
..
3163657
100644
(file)
--- a/
lib/daemon.c
+++ b/
lib/daemon.c
@@
-213,7
+213,9
@@
daemonize(void)
/* Parent process: wait for child to create pidfile, then exit. */
close(fds[1]);
fatal_signal_fork();
- read(fds[0], &c, 1);
+ if (read(fds[0], &c, 1) != 1) {
+ ofp_fatal(errno, "daemon child failed to signal startup");
+ }
exit(0);
case 0: