ovs.db.data: Make Datum.check_constraints() work.
authorBen Pfaff <blp@nicira.com>
Thu, 15 Sep 2011 19:59:31 +0000 (12:59 -0700)
committerBen Pfaff <blp@nicira.com>
Fri, 23 Sep 2011 16:10:44 +0000 (09:10 -0700)
This code never got tested and so didn't work.

This does not fix an actual bug because Datum.check_constraints() does not
have any existing users.

python/ovs/db/data.py

index f62a562..c07d8bf 100644 (file)
@@ -264,10 +264,10 @@ class Datum(object):
         This function is not commonly useful because the most ordinary way to
         obtain a datum is ultimately via Datum.from_json() or Atom.from_json(),
         which check constraints themselves."""
-        for keyAtom, valueAtom in self.values:
-            keyAtom.check_constraints()
+        for keyAtom, valueAtom in self.values.iteritems():
+            keyAtom.check_constraints(self.type.key)
             if valueAtom is not None:
-                valueAtom.check_constraints()
+                valueAtom.check_constraints(self.type.value)
 
     @staticmethod
     def from_json(type_, json, symtab=None):