ovsdb-server: Fix memory leak when manager table has no status column.
authorBen Pfaff <blp@nicira.com>
Wed, 26 Dec 2012 17:43:51 +0000 (09:43 -0800)
committerBen Pfaff <blp@nicira.com>
Wed, 9 Jan 2013 01:03:46 +0000 (17:03 -0800)
This is a corner case.  I doubt that it's triggered in practice outside the
unit tests.

Signed-off-by: Ben Pfaff <blp@nicira.com>
Acked-by: Ethan Jackson <ethan@nicira.com>
ovsdb/ovsdb-server.c

index 69548c2..6032d73 100644 (file)
@@ -523,6 +523,10 @@ write_string_string_column(struct ovsdb_row *row, const char *column_name,
     datum = get_datum(row, column_name, OVSDB_TYPE_STRING, OVSDB_TYPE_STRING,
                       UINT_MAX);
     if (!datum) {
+        for (i = 0; i < n; i++) {
+            free(keys[i]);
+            free(values[i]);
+        }
         return;
     }