ofp-util: Fix validation of OFPAT_SET_VLAN_PCP actions.
authorBen Pfaff <blp@nicira.com>
Wed, 4 May 2011 22:47:27 +0000 (15:47 -0700)
committerBen Pfaff <blp@nicira.com>
Mon, 23 May 2011 16:18:31 +0000 (09:18 -0700)
Found by sparse.

lib/ofp-util.c

index 5c95270..d39b0bc 100644 (file)
@@ -2053,7 +2053,7 @@ check_action(const union ofp_action *a, unsigned int len,
         if (error) {
             return error;
         }
-        if (a->vlan_vid.vlan_vid & ~7) {
+        if (a->vlan_pcp.vlan_pcp & ~7) {
             return ofp_mkerr(OFPET_BAD_ACTION, OFPBAC_BAD_ARGUMENT);
         }
         return 0;