git://git.onelab.eu
/
sliver-openvswitch.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
32ea83d
)
dpctl: Fix use-after-free in "probe" command.
author
Ben Pfaff
<blp@nicira.com>
Fri, 9 Jan 2009 01:13:30 +0000
(17:13 -0800)
committer
Ben Pfaff
<blp@nicira.com>
Tue, 13 Jan 2009 01:17:47 +0000
(17:17 -0800)
Found by Chris Eagle via Fortify.
utilities/dpctl.c
patch
|
blob
|
history
diff --git
a/utilities/dpctl.c
b/utilities/dpctl.c
index
8fa0da8
..
923e048
100644
(file)
--- a/
utilities/dpctl.c
+++ b/
utilities/dpctl.c
@@
-1124,7
+1124,7
@@
do_probe(const struct settings *s, int argc, char *argv[])
make_openflow(sizeof(struct ofp_header), OFPT_ECHO_REQUEST, &request);
open_vconn(argv[1], &vconn);
run(vconn_transact(vconn, request, &reply), "talking to %s", argv[1]);
- if (reply->size !=
request->size
) {
+ if (reply->size !=
sizeof(struct ofp_header)
) {
ofp_fatal(0, "reply does not match request");
}
ofpbuf_delete(reply);