os.tmpnam is unsafe.

[pyplnet.git] / plnet.py

diff --git a/plnet.py b/plnet.py
index 4b0dc76..dfb7fb6 100644 (file)
--- a/plnet.py
+++ b/plnet.py
@@ -3,6 +3,7 @@
 import os
 import socket
 import time
+import tempfile
 
 import sioc
 import modprobe
@@ -177,8 +178,8 @@ def InitInterfaces(logger, plc, data, root="", files_only=False):
     # Process ifcg-$dev changes / additions
     newdevs = []
     for (dev, inter) in interfaces.iteritems():
-        tmpnam = os.tmpnam()
-        f = file(tmpnam, "w")
+        (fd, tmpnam) = tempfile.mkstemp(dir=sysconfig)
+        f = os.fdopen(fd, "w")
         f.write("# Autogenerated by NodeManager/net.py.... do not edit!\n")
         if 'DRIVER' in inter:
             f.write("# using %s driver for device %s\n" % (inter['DRIVER'],dev))