Merge Master in geni-v3 conflict resolution
[sfa.git] / sfa / planetlab / plslices.py
1 from types import StringTypes
2 from collections import defaultdict
3
4 from sfa.util.sfatime import utcparse, datetime_to_epoch
5 from sfa.util.sfalogging import logger
6 from sfa.util.xrn import Xrn, get_leaf, get_authority, urn_to_hrn
7 from sfa.rspecs.rspec import RSpec
8 from sfa.planetlab.vlink import VLink
9 from sfa.planetlab.topology import Topology
10 from sfa.planetlab.plxrn import PlXrn, hrn_to_pl_slicename
11 from sfa.storage.model import SliverAllocation
12 from sfa.storage.alchemy import dbsession
13
14 MAXINT =  2L**31-1
15
16 class PlSlices:
17
18     rspec_to_slice_tag = {'max_rate':'net_max_rate'}
19
20     def __init__(self, driver):
21         self.driver = driver
22
23     def get_slivers(self, xrn, node=None):
24         hrn, type = urn_to_hrn(xrn)
25          
26         slice_name = hrn_to_pl_slicename(hrn)
27         # XX Should we just call PLCAPI.GetSliceTicket(slice_name) instead
28         # of doing all of this?
29         #return self.driver.shell.GetSliceTicket(self.auth, slice_name) 
30         
31         # from PLCAPI.GetSlivers.get_slivers()
32         slice_fields = ['slice_id', 'name', 'instantiation', 'expires', 'person_ids', 'slice_tag_ids']
33         slices = self.driver.shell.GetSlices(slice_name, slice_fields)
34         # Build up list of users and slice attributes
35         person_ids = set()
36         all_slice_tag_ids = set()
37         for slice in slices:
38             person_ids.update(slice['person_ids'])
39             all_slice_tag_ids.update(slice['slice_tag_ids'])
40         person_ids = list(person_ids)
41         all_slice_tag_ids = list(all_slice_tag_ids)
42         # Get user information
43         all_persons_list = self.driver.shell.GetPersons({'person_id':person_ids,'enabled':True}, ['person_id', 'enabled', 'key_ids'])
44         all_persons = {}
45         for person in all_persons_list:
46             all_persons[person['person_id']] = person        
47
48         # Build up list of keys
49         key_ids = set()
50         for person in all_persons.values():
51             key_ids.update(person['key_ids'])
52         key_ids = list(key_ids)
53         # Get user account keys
54         all_keys_list = self.driver.shell.GetKeys(key_ids, ['key_id', 'key', 'key_type'])
55         all_keys = {}
56         for key in all_keys_list:
57             all_keys[key['key_id']] = key
58         # Get slice attributes
59         all_slice_tags_list = self.driver.shell.GetSliceTags(all_slice_tag_ids)
60         all_slice_tags = {}
61         for slice_tag in all_slice_tags_list:
62             all_slice_tags[slice_tag['slice_tag_id']] = slice_tag
63            
64         slivers = []
65         for slice in slices:
66             keys = []
67             for person_id in slice['person_ids']:
68                 if person_id in all_persons:
69                     person = all_persons[person_id]
70                     if not person['enabled']:
71                         continue
72                     for key_id in person['key_ids']:
73                         if key_id in all_keys:
74                             key = all_keys[key_id]
75                             keys += [{'key_type': key['key_type'],
76                                     'key': key['key']}]
77             attributes = []
78             # All (per-node and global) attributes for this slice
79             slice_tags = []
80             for slice_tag_id in slice['slice_tag_ids']:
81                 if slice_tag_id in all_slice_tags:
82                     slice_tags.append(all_slice_tags[slice_tag_id]) 
83             # Per-node sliver attributes take precedence over global
84             # slice attributes, so set them first.
85             # Then comes nodegroup slice attributes
86             # Followed by global slice attributes
87             sliver_attributes = []
88
89             if node is not None:
90                 for sliver_attribute in filter(lambda a: a['node_id'] == node['node_id'], slice_tags):
91                     sliver_attributes.append(sliver_attribute['tagname'])
92                     attributes.append({'tagname': sliver_attribute['tagname'],
93                                     'value': sliver_attribute['value']})
94
95             # set nodegroup slice attributes
96             for slice_tag in filter(lambda a: a['nodegroup_id'] in node['nodegroup_ids'], slice_tags):
97                 # Do not set any nodegroup slice attributes for
98                 # which there is at least one sliver attribute
99                 # already set.
100                 if slice_tag not in slice_tags:
101                     attributes.append({'tagname': slice_tag['tagname'],
102                         'value': slice_tag['value']})
103
104             for slice_tag in filter(lambda a: a['node_id'] is None, slice_tags):
105                 # Do not set any global slice attributes for
106                 # which there is at least one sliver attribute
107                 # already set.
108                 if slice_tag['tagname'] not in sliver_attributes:
109                     attributes.append({'tagname': slice_tag['tagname'],
110                                    'value': slice_tag['value']})
111
112             # XXX Sanity check; though technically this should be a system invariant
113             # checked with an assertion
114             if slice['expires'] > MAXINT:  slice['expires']= MAXINT
115             
116             slivers.append({
117                 'hrn': hrn,
118                 'name': slice['name'],
119                 'slice_id': slice['slice_id'],
120                 'instantiation': slice['instantiation'],
121                 'expires': slice['expires'],
122                 'keys': keys,
123                 'attributes': attributes
124             })
125
126         return slivers
127  
128     def get_peer(self, xrn):
129         hrn, type = urn_to_hrn(xrn)
130         # Becaues of myplc federation,  we first need to determine if this
131         # slice belongs to out local plc or a myplc peer. We will assume it 
132         # is a local site, unless we find out otherwise  
133         peer = None
134
135         # get this slice's authority (site)
136         slice_authority = get_authority(hrn)
137
138         # get this site's authority (sfa root authority or sub authority)
139         site_authority = get_authority(slice_authority).lower()
140
141         # check if we are already peered with this site_authority, if so
142         peers = self.driver.shell.GetPeers({}, ['peer_id', 'peername', 'shortname', 'hrn_root'])
143         for peer_record in peers:
144             names = [name.lower() for name in peer_record.values() if isinstance(name, StringTypes)]
145             if site_authority in names:
146                 peer = peer_record
147
148         return peer
149
150     def get_sfa_peer(self, xrn):
151         hrn, type = urn_to_hrn(xrn)
152
153         # return the authority for this hrn or None if we are the authority
154         sfa_peer = None
155         slice_authority = get_authority(hrn)
156         site_authority = get_authority(slice_authority)
157
158         if site_authority != self.driver.hrn:
159             sfa_peer = site_authority
160
161         return sfa_peer
162
163     def verify_slice_leases(self, slice, rspec_requested_leases, peer):
164
165         leases = self.driver.shell.GetLeases({'name':slice['name'], 'clip':int(time.time())}, ['lease_id','name', 'hostname', 't_from', 't_until'])
166         grain = self.driver.shell.GetLeaseGranularity()
167
168         requested_leases = []
169         for lease in rspec_requested_leases:
170              requested_lease = {}
171              slice_name = hrn_to_pl_slicename(lease['slice_id'])
172              if slice_name != slice['name']:
173                  continue
174              elif Xrn(lease['component_id']).get_authority_urn().split(':')[0] != self.driver.hrn:
175                  continue
176
177              hostname = xrn_to_hostname(lease['component_id'])
178              # fill the requested node with nitos ids
179              requested_lease['name'] = slice['name']
180              requested_lease['hostname'] = hostname
181              requested_lease['t_from'] = int(lease['start_time'])
182              requested_lease['t_until'] = int(lease['duration']) * grain + int(lease['start_time'])
183              requested_leases.append(requested_lease)
184
185
186
187         # prepare actual slice leases by lease_id  
188         leases_by_id = {}
189         for lease in leases:
190              leases_by_id[lease['lease_id']] = {'name': lease['name'], 'hostname': lease['hostname'], \
191                                                 't_from': lease['t_from'], 't_until': lease['t_until']}
192         
193         added_leases = []
194         kept_leases_id = []
195         deleted_leases_id = []
196         for lease_id in leases_by_id:
197              if leases_by_id[lease_id] not in requested_leases:
198                  deleted_leases_id.append(lease_id)
199              else:
200                  kept_leases_id.append(lease_id)
201                  requested_leases.remove(leases_by_id[lease_id])
202         added_leases = requested_leases
203    
204
205         try:
206             if peer:
207                 self.driver.shell.UnBindObjectFromPeer('slice', slice['slice_id'], peer['shortname'])
208             self.driver.shell.DeleteLeases(deleted_leases_id)
209             for lease in added_leases:
210                 self.driver.shell.AddLeases(lease['hostname'], slice['name'], lease['t_from'], lease['t_until'])
211
212         except: 
213             logger.log_exc('Failed to add/remove slice leases')
214
215         return leases
216
217
218     def verify_slice_nodes(self, slice_urn, slice, rspec_nodes, peer):
219         
220         slivers = {}
221         for node in rspec_nodes:
222             hostname = node.get('component_name')
223             client_id = node.get('client_id')
224             component_id = node.get('component_id').strip()    
225             if hostname:
226                 hostname = hostname.strip()
227             elif component_id:
228                 hostname = xrn_to_hostname(component_id)
229             if hostname:
230                 slivers[hostname] = {'client_id': client_id, 'component_id': component_id}
231         
232         nodes = self.driver.shell.GetNodes(slice['node_ids'], ['node_id', 'hostname', 'interface_ids'])
233         current_slivers = [node['hostname'] for node in nodes]
234
235         requested_slivers = []
236         tags = []
237         for node in slivers:
238             hostname = None
239             if node.get('component_name'):
240                 hostname = node.get('component_name').strip()
241             elif node.get('component_id'):
242                 hostname = xrn_to_hostname(node.get('component_id').strip())
243             if node.get('client_id'):
244                 tags.append({'slicename': slice['name'], 
245                              'tagname': 'client_id',
246                              'value': node['client_id'],
247                              'node': hostname})
248             if hostname:
249                 requested_slivers.append(hostname)
250         
251         # remove nodes not in rspec
252         deleted_nodes = list(set(current_slivers).difference(slivers.keys()))
253
254         # add nodes from rspec
255         added_nodes = list(set(slivers.keys()).difference(current_slivers))        
256
257         try:
258             if peer:
259                 self.driver.shell.UnBindObjectFromPeer('slice', slice['slice_id'], peer['shortname'])
260             self.driver.shell.AddSliceToNodes(slice['name'], added_nodes)
261             self.driver.shell.DeleteSliceFromNodes(slice['name'], deleted_nodes)
262             
263         except: 
264             logger.log_exc('Failed to add/remove slice from nodes')
265
266         slices = self.driver.shell.GetSlices(slice['name'], ['node_ids']) 
267         resulting_nodes = self.driver.shell.GetNodes(slices[0]['node_ids'])
268
269         # update sliver allocations
270         for node in resulting_nodes:
271             client_id = slivers[node['hostname']]['client_id']
272             component_id = slivers[node['hostname']]['component_id']
273             sliver_hrn = '%s.%s-%s' % (self.driver.hrn, slice['slice_id'], node['node_id'])
274             sliver_id = Xrn(sliver_hrn, type='sliver').urn
275             record = SliverAllocation(sliver_id=sliver_id, client_id=client_id, 
276                                       component_id=component_id,
277                                       slice_urn = slice_urn, 
278                                       allocation_state='geni_allocated')      
279             record.sync()
280         return resulting_nodes
281
282     def free_egre_key(self):
283         used = set()
284         for tag in self.driver.shell.GetSliceTags({'tagname': 'egre_key'}):
285                 used.add(int(tag['value']))
286
287         for i in range(1, 256):
288             if i not in used:
289                 key = i
290                 break
291         else:
292             raise KeyError("No more EGRE keys available")
293
294         return str(key)
295
296     def verify_slice_links(self, slice, requested_links, nodes):
297          
298         if not requested_links:
299             return
300
301         # exit if links are not supported here
302         topology = Topology()
303         if not topology:
304             return 
305
306         # build dict of nodes 
307         nodes_dict = {}
308         interface_ids = []
309         for node in nodes:
310             nodes_dict[node['node_id']] = node
311             interface_ids.extend(node['interface_ids'])
312         # build dict of interfaces
313         interfaces = self.driver.shell.GetInterfaces(interface_ids)
314         interfaces_dict = {}
315         for interface in interfaces:
316             interfaces_dict[interface['interface_id']] = interface 
317
318         slice_tags = []
319         
320         # set egre key
321         slice_tags.append({'name': 'egre_key', 'value': self.free_egre_key()})
322     
323         # set netns
324         slice_tags.append({'name': 'netns', 'value': '1'})
325
326         # set cap_net_admin 
327         # need to update the attribute string?
328         slice_tags.append({'name': 'capabilities', 'value': 'CAP_NET_ADMIN'}) 
329         
330         for link in requested_links:
331             # get the ip address of the first node in the link
332             ifname1 = Xrn(link['interface1']['component_id']).get_leaf()
333             ifname_parts = ifname1.split(':')
334             node_raw = ifname_parts[0]
335             device = None
336             if len(ifname_parts) > 1:
337                 device = ifname_parts[1] 
338             node_id = int(node_raw.replace('node', ''))
339             node = nodes_dict[node_id]
340             if1 = interfaces_dict[node['interface_ids'][0]]
341             ipaddr = if1['ip']
342             topo_rspec = VLink.get_topo_rspec(link, ipaddr)
343             # set topo_rspec tag
344             slice_tags.append({'name': 'topo_rspec', 'value': str([topo_rspec]), 'node_id': node_id})
345             # set vini_topo tag
346             slice_tags.append({'name': 'vini_topo', 'value': 'manual', 'node_id': node_id})
347             #self.driver.shell.AddSliceTag(slice['name'], 'topo_rspec', str([topo_rspec]), node_id) 
348
349         self.verify_slice_attributes(slice, slice_tags, {'append': True}, admin=True)
350                         
351         
352
353     def handle_peer(self, site, slice, persons, peer):
354         if peer:
355             # bind site
356             try:
357                 if site:
358                     self.driver.shell.BindObjectToPeer('site', site['site_id'], peer['shortname'], slice['site_id'])
359             except Exception,e:
360                 self.driver.shell.DeleteSite(site['site_id'])
361                 raise e
362             
363             # bind slice
364             try:
365                 if slice:
366                     self.driver.shell.BindObjectToPeer('slice', slice['slice_id'], peer['shortname'], slice['slice_id'])
367             except Exception,e:
368                 self.driver.shell.DeleteSlice(slice['slice_id'])
369                 raise e 
370
371             # bind persons
372             for person in persons:
373                 try:
374                     self.driver.shell.BindObjectToPeer('person', 
375                                                      person['person_id'], peer['shortname'], person['peer_person_id'])
376
377                     for (key, remote_key_id) in zip(person['keys'], person['key_ids']):
378                         try:
379                             self.driver.shell.BindObjectToPeer( 'key', key['key_id'], peer['shortname'], remote_key_id)
380                         except:
381                             self.driver.shell.DeleteKey(key['key_id'])
382                             logger("failed to bind key: %s to peer: %s " % (key['key_id'], peer['shortname']))
383                 except Exception,e:
384                     self.driver.shell.DeletePerson(person['person_id'])
385                     raise e       
386
387         return slice
388
389     def verify_site(self, slice_xrn, slice_record={}, peer=None, sfa_peer=None, options={}):
390         (slice_hrn, type) = urn_to_hrn(slice_xrn)
391         site_hrn = get_authority(slice_hrn)
392         # login base can't be longer than 20 characters
393         slicename = hrn_to_pl_slicename(slice_hrn)
394         authority_name = slicename.split('_')[0]
395         login_base = authority_name[:20]
396         sites = self.driver.shell.GetSites(login_base)
397         if not sites:
398             # create new site record
399             site = {'name': 'geni.%s' % authority_name,
400                     'abbreviated_name': authority_name,
401                     'login_base': login_base,
402                     'max_slices': 100,
403                     'max_slivers': 1000,
404                     'enabled': True,
405                     'peer_site_id': None}
406             if peer:
407                 site['peer_site_id'] = slice_record.get('site_id', None)
408             site['site_id'] = self.driver.shell.AddSite(site)
409             # exempt federated sites from monitor policies
410             self.driver.shell.AddSiteTag(site['site_id'], 'exempt_site_until', "20200101")
411             
412 #            # is this still necessary?
413 #            # add record to the local registry 
414 #            if sfa_peer and slice_record:
415 #                peer_dict = {'type': 'authority', 'hrn': site_hrn, \
416 #                             'peer_authority': sfa_peer, 'pointer': site['site_id']}
417 #                self.registry.register_peer_object(self.credential, peer_dict)
418         else:
419             site =  sites[0]
420             if peer:
421                 # unbind from peer so we can modify if necessary. Will bind back later
422                 self.driver.shell.UnBindObjectFromPeer('site', site['site_id'], peer['shortname']) 
423         
424         return site        
425
426     def verify_slice(self, slice_hrn, slice_record, peer, sfa_peer, expiration, options={}):
427         slicename = hrn_to_pl_slicename(slice_hrn)
428         parts = slicename.split("_")
429         login_base = parts[0]
430         slices = self.driver.shell.GetSlices([slicename]) 
431         expires = int(datetime_to_epoch(utcparse(expiration)))
432         if not slices:
433             slice = {'name': slicename,
434                      'url': 'No Url', 
435                      'description': 'No Description'}
436             # add the slice                          
437             slice['slice_id'] = self.driver.shell.AddSlice(slice)
438             slice['node_ids'] = []
439             slice['person_ids'] = []
440             if peer and slice_record:
441                 slice['peer_slice_id'] = slice_record.get('slice_id', None)
442             # set the expiration
443             self.driver.shell.UpdateSlice(slice['slice_id'], {'expires': expires}) 
444         else:
445             slice = slices[0]
446             if peer and slice_record:
447                 slice['peer_slice_id'] = slice_record.get('slice_id', None)
448                 # unbind from peer so we can modify if necessary. Will bind back later
449                 self.driver.shell.UnBindObjectFromPeer('slice', slice['slice_id'], peer['shortname'])
450             
451                 #Update expiration if necessary
452             if slice['expires'] != expires:
453                 self.driver.shell.UpdateSlice( slice['slice_id'], {'expires' : expires})
454        
455         return slice
456
457     #def get_existing_persons(self, users):
458     def verify_persons(self, slice_hrn, slice_record, users, peer, sfa_peer, options={}):
459         users_by_email = {}
460         users_by_site = defaultdict(list)
461         users_dict = {} 
462         for user in users:
463             user['urn'] = user['urn'].lower()
464             hrn, type = urn_to_hrn(user['urn'])
465             username = get_leaf(hrn)
466             login_base = PlXrn(xrn=user['urn']).pl_login_base()
467             user['username'] = username
468             user['site'] = login_base
469
470             if 'email' in user:
471                 user['email'] = user['email'].lower() 
472                 users_by_email[user['email']] = user
473                 users_dict[user['email']] = user
474             else:
475                 users_by_site[user['site']].append(user)
476
477         # start building a list of existing users
478         existing_user_ids = []
479         existing_user_ids_filter = []
480         if users_by_email:
481             existing_user_ids_filter.extend(users_by_email.keys())
482         if users_by_site:
483             for login_base in users_by_site:
484                 users = users_by_site[login_base]
485                 for user in users:      
486                     existing_user_ids_filter.append(user['username']+'@geni.net')               
487         if existing_user_ids_filter:                    
488             # get existing users by email 
489             existing_users = self.driver.shell.GetPersons({'email': existing_user_ids_filter}, 
490                                                         ['person_id', 'key_ids', 'email'])
491             existing_user_ids.extend([user['email'] for user in existing_users])
492         
493         if users_by_site:
494             # get a list of user sites (based on requeste user urns
495             site_list = self.driver.shell.GetSites(users_by_site.keys(), \
496                 ['site_id', 'login_base', 'person_ids'])
497             # get all existing users at these sites
498             sites = {}
499             site_user_ids = []
500             for site in site_list:
501                 sites[site['site_id']] = site
502                 site_user_ids.extend(site['person_ids'])
503
504             existing_site_persons_list = self.driver.shell.GetPersons(site_user_ids,  
505                                                                     ['person_id', 'key_ids', 'email', 'site_ids'])
506
507             # all requested users are either existing users or new (added) users      
508             for login_base in users_by_site:
509                 requested_site_users = users_by_site[login_base]
510                 for requested_user in requested_site_users:
511                     user_found = False
512                     for existing_user in existing_site_persons_list:
513                         for site_id in existing_user['site_ids']:
514                             if site_id in sites:
515                                 site = sites[site_id]
516                                 if login_base == site['login_base'] and \
517                                    existing_user['email'].startswith(requested_user['username']+'@'):
518                                     existing_user_ids.append(existing_user['email'])
519                                     requested_user['email'] = existing_user['email']
520                                     users_dict[existing_user['email']] = requested_user
521                                     user_found = True
522                                     break
523                         if user_found:
524                             break
525       
526                     if user_found == False:
527                         fake_email = requested_user['username'] + '@geni.net'
528                         requested_user['email'] = fake_email
529                         users_dict[fake_email] = requested_user
530                 
531         # requested slice users        
532         requested_user_ids = users_dict.keys()
533         # existing slice users
534         existing_slice_users_filter = {'person_id': slice_record.get('person_ids', [])}
535         existing_slice_users = self.driver.shell.GetPersons(existing_slice_users_filter,
536                                                           ['person_id', 'key_ids', 'email'])
537         existing_slice_user_ids = [user['email'] for user in existing_slice_users]
538         
539         # users to be added, removed or updated
540         added_user_ids = set(requested_user_ids).difference(existing_user_ids)
541         added_slice_user_ids = set(requested_user_ids).difference(existing_slice_user_ids)
542         removed_user_ids = set(existing_slice_user_ids).difference(requested_user_ids)
543         updated_user_ids = set(existing_slice_user_ids).intersection(requested_user_ids)
544
545         # Remove stale users (only if we are not appending).
546         # Append by default.
547         append = options.get('append', True)
548         if append == False:
549             for removed_user_id in removed_user_ids:
550                 self.driver.shell.DeletePersonFromSlice(removed_user_id, slice_record['name'])
551         # update_existing users
552         updated_users_list = [user for user in users_dict.values() if user['email'] in \
553           updated_user_ids]
554         self.verify_keys(existing_slice_users, updated_users_list, peer, options)
555
556         added_persons = []
557         # add new users
558         for added_user_id in added_user_ids:
559             added_user = users_dict[added_user_id]
560             hrn, type = urn_to_hrn(added_user['urn'])  
561             person = {
562                 'first_name': added_user.get('first_name', hrn),
563                 'last_name': added_user.get('last_name', hrn),
564                 'email': added_user_id,
565                 'peer_person_id': None,
566                 'keys': [],
567                 'key_ids': added_user.get('key_ids', []),
568             }
569             person['person_id'] = self.driver.shell.AddPerson(person)
570             if peer:
571                 person['peer_person_id'] = added_user['person_id']
572             added_persons.append(person)
573            
574             # enable the account 
575             self.driver.shell.UpdatePerson(person['person_id'], {'enabled': True})
576             
577             # add person to site
578             self.driver.shell.AddPersonToSite(added_user_id, added_user['site'])
579
580             for key_string in added_user.get('keys', []):
581                 key = {'key':key_string, 'key_type':'ssh'}
582                 key['key_id'] = self.driver.shell.AddPersonKey(person['person_id'], key)
583                 person['keys'].append(key)
584
585             # add the registry record
586 #            if sfa_peer:
587 #                peer_dict = {'type': 'user', 'hrn': hrn, 'peer_authority': sfa_peer, \
588 #                    'pointer': person['person_id']}
589 #                self.registry.register_peer_object(self.credential, peer_dict)
590     
591         for added_slice_user_id in added_slice_user_ids.union(added_user_ids):
592             # add person to the slice 
593             self.driver.shell.AddPersonToSlice(added_slice_user_id, slice_record['name'])
594             # if this is a peer record then it should already be bound to a peer.
595             # no need to return worry about it getting bound later 
596
597         return added_persons
598             
599
600     def verify_keys(self, persons, users, peer, options={}):
601         # existing keys 
602         key_ids = []
603         for person in persons:
604             key_ids.extend(person['key_ids'])
605         keylist = self.driver.shell.GetKeys(key_ids, ['key_id', 'key'])
606         keydict = {}
607         for key in keylist:
608             keydict[key['key']] = key['key_id']     
609         existing_keys = keydict.keys()
610         persondict = {}
611         for person in persons:
612             persondict[person['email']] = person    
613     
614         # add new keys
615         requested_keys = []
616         updated_persons = []
617         for user in users:
618             user_keys = user.get('keys', [])
619             updated_persons.append(user)
620             for key_string in user_keys:
621                 requested_keys.append(key_string)
622                 if key_string not in existing_keys:
623                     key = {'key': key_string, 'key_type': 'ssh'}
624                     try:
625                         if peer:
626                             person = persondict[user['email']]
627                             self.driver.shell.UnBindObjectFromPeer('person', person['person_id'], peer['shortname'])
628                         key['key_id'] = self.driver.shell.AddPersonKey(user['email'], key)
629                         if peer:
630                             key_index = user_keys.index(key['key'])
631                             remote_key_id = user['key_ids'][key_index]
632                             self.driver.shell.BindObjectToPeer('key', key['key_id'], peer['shortname'], remote_key_id)
633                             
634                     finally:
635                         if peer:
636                             self.driver.shell.BindObjectToPeer('person', person['person_id'], peer['shortname'], user['person_id'])
637         
638         # remove old keys (only if we are not appending)
639         append = options.get('append', True)
640         if append == False: 
641             removed_keys = set(existing_keys).difference(requested_keys)
642             for existing_key_id in keydict:
643                 if keydict[existing_key_id] in removed_keys:
644                     try:
645                         if peer:
646                             self.driver.shell.UnBindObjectFromPeer('key', existing_key_id, peer['shortname'])
647                         self.driver.shell.DeleteKey(existing_key_id)
648                     except:
649                         pass   
650
651     def verify_slice_attributes(self, slice, requested_slice_attributes, options={}, admin=False):
652         append = options.get('append', True)
653         # get list of attributes users ar able to manage
654         filter = {'category': '*slice*'}
655         if not admin:
656             filter['|roles'] = ['user']
657         slice_attributes = self.driver.shell.GetTagTypes(filter)
658         valid_slice_attribute_names = [attribute['tagname'] for attribute in slice_attributes]
659
660         # get sliver attributes
661         added_slice_attributes = []
662         removed_slice_attributes = []
663         ignored_slice_attribute_names = []
664         existing_slice_attributes = self.driver.shell.GetSliceTags({'slice_id': slice['slice_id']})
665         
666         # get attributes that should be removed
667         for slice_tag in existing_slice_attributes:
668             if slice_tag['tagname'] in ignored_slice_attribute_names:
669                 # If a slice already has a admin only role it was probably given to them by an
670                 # admin, so we should ignore it.
671                 ignored_slice_attribute_names.append(slice_tag['tagname'])
672             else:
673                 # If an existing slice attribute was not found in the request it should
674                 # be removed
675                 attribute_found=False
676                 for requested_attribute in requested_slice_attributes:
677                     if requested_attribute['name'] == slice_tag['tagname'] and \
678                        requested_attribute['value'] == slice_tag['value']:
679                         attribute_found=True
680                         break
681
682             if not attribute_found and not append:
683                 removed_slice_attributes.append(slice_tag)
684         
685         # get attributes that should be added:
686         for requested_attribute in requested_slice_attributes:
687             # if the requested attribute wasn't found  we should add it
688             if requested_attribute['name'] in valid_slice_attribute_names:
689                 attribute_found = False
690                 for existing_attribute in existing_slice_attributes:
691                     if requested_attribute['name'] == existing_attribute['tagname'] and \
692                        requested_attribute['value'] == existing_attribute['value']:
693                         attribute_found=True
694                         break
695                 if not attribute_found:
696                     added_slice_attributes.append(requested_attribute)
697
698
699         # remove stale attributes
700         for attribute in removed_slice_attributes:
701             try:
702                 self.driver.shell.DeleteSliceTag(attribute['slice_tag_id'])
703             except Exception, e:
704                 logger.warn('Failed to remove sliver attribute. name: %s, value: %s, node_id: %s\nCause:%s'\
705                                 % (slice['name'], attribute['value'],  attribute.get('node_id'), str(e)))
706
707         # add requested_attributes
708         for attribute in added_slice_attributes:
709             try:
710                 self.driver.shell.AddSliceTag(slice['name'], attribute['name'], attribute['value'], attribute.get('node_id', None))
711             except Exception, e:
712                 logger.warn('Failed to add sliver attribute. name: %s, value: %s, node_id: %s\nCause:%s'\
713                                 % (slice['name'], attribute['value'],  attribute.get('node_id'), str(e)))
714