sfa/planetlab/plslices.py

   1 from types import StringTypes
   2 from collections import defaultdict
   3 import sys
   4
   5 from sfa.util.sfatime import utcparse, datetime_to_epoch
   6 from sfa.util.sfalogging import logger
   7 from sfa.util.xrn import Xrn, get_leaf, get_authority, urn_to_hrn
   8
   9 from sfa.rspecs.rspec import RSpec
  10
  11 from sfa.planetlab.vlink import VLink
  12 from sfa.planetlab.plxrn import PlXrn, hrn_to_pl_slicename
  13
  14 MAXINT =  2L**31-1
  15
  16 class PlSlices:
  17
  18     rspec_to_slice_tag = {'max_rate':'net_max_rate'}
  19
  20     def __init__(self, driver):
  21         self.driver = driver
  22
  23     def get_slivers(self, xrn, node=None):
  24         hrn, type = urn_to_hrn(xrn)
  25
  26         slice_name = hrn_to_pl_slicename(hrn)
  27         # XX Should we just call PLCAPI.GetSliceTicket(slice_name) instead
  28         # of doing all of this?
  29         #return self.driver.shell.GetSliceTicket(self.auth, slice_name)
  30
  31         # from PLCAPI.GetSlivers.get_slivers()
  32         slice_fields = ['slice_id', 'name', 'instantiation', 'expires', 'person_ids', 'slice_tag_ids']
  33         slices = self.driver.shell.GetSlices(slice_name, slice_fields)
  34         # Build up list of users and slice attributes
  35         person_ids = set()
  36         all_slice_tag_ids = set()
  37         for slice in slices:
  38             person_ids.update(slice['person_ids'])
  39             all_slice_tag_ids.update(slice['slice_tag_ids'])
  40         person_ids = list(person_ids)
  41         all_slice_tag_ids = list(all_slice_tag_ids)
  42         # Get user information
  43         all_persons_list = self.driver.shell.GetPersons({'person_id':person_ids,'enabled':True}, ['person_id', 'enabled', 'key_ids'])
  44         all_persons = {}
  45         for person in all_persons_list:
  46             all_persons[person['person_id']] = person
  47
  48         # Build up list of keys
  49         key_ids = set()
  50         for person in all_persons.values():
  51             key_ids.update(person['key_ids'])
  52         key_ids = list(key_ids)
  53         # Get user account keys
  54         all_keys_list = self.driver.shell.GetKeys(key_ids, ['key_id', 'key', 'key_type'])
  55         all_keys = {}
  56         for key in all_keys_list:
  57             all_keys[key['key_id']] = key
  58         # Get slice attributes
  59         all_slice_tags_list = self.driver.shell.GetSliceTags(all_slice_tag_ids)
  60         all_slice_tags = {}
  61         for slice_tag in all_slice_tags_list:
  62             all_slice_tags[slice_tag['slice_tag_id']] = slice_tag
  63
  64         slivers = []
  65         for slice in slices:
  66             keys = []
  67             for person_id in slice['person_ids']:
  68                 if person_id in all_persons:
  69                     person = all_persons[person_id]
  70                     if not person['enabled']:
  71                         continue
  72                     for key_id in person['key_ids']:
  73                         if key_id in all_keys:
  74                             key = all_keys[key_id]
  75                             keys += [{'key_type': key['key_type'],
  76                                     'key': key['key']}]
  77             attributes = []
  78             # All (per-node and global) attributes for this slice
  79             slice_tags = []
  80             for slice_tag_id in slice['slice_tag_ids']:
  81                 if slice_tag_id in all_slice_tags:
  82                     slice_tags.append(all_slice_tags[slice_tag_id])
  83             # Per-node sliver attributes take precedence over global
  84             # slice attributes, so set them first.
  85             # Then comes nodegroup slice attributes
  86             # Followed by global slice attributes
  87             sliver_attributes = []
  88
  89             if node is not None:
  90                 for sliver_attribute in filter(lambda a: a['node_id'] == node['node_id'], slice_tags):
  91                     sliver_attributes.append(sliver_attribute['tagname'])
  92                     attributes.append({'tagname': sliver_attribute['tagname'],
  93                                     'value': sliver_attribute['value']})
  94
  95             # set nodegroup slice attributes
  96             for slice_tag in filter(lambda a: a['nodegroup_id'] in node['nodegroup_ids'], slice_tags):
  97                 # Do not set any nodegroup slice attributes for
  98                 # which there is at least one sliver attribute
  99                 # already set.
 100                 if slice_tag not in slice_tags:
 101                     attributes.append({'tagname': slice_tag['tagname'],
 102                         'value': slice_tag['value']})
 103
 104             for slice_tag in filter(lambda a: a['node_id'] is None, slice_tags):
 105                 # Do not set any global slice attributes for
 106                 # which there is at least one sliver attribute
 107                 # already set.
 108                 if slice_tag['tagname'] not in sliver_attributes:
 109                     attributes.append({'tagname': slice_tag['tagname'],
 110                                    'value': slice_tag['value']})
 111
 112             # XXX Sanity check; though technically this should be a system invariant
 113             # checked with an assertion
 114             if slice['expires'] > MAXINT:  slice['expires']= MAXINT
 115
 116             slivers.append({
 117                 'hrn': hrn,
 118                 'name': slice['name'],
 119                 'slice_id': slice['slice_id'],
 120                 'instantiation': slice['instantiation'],
 121                 'expires': slice['expires'],
 122                 'keys': keys,
 123                 'attributes': attributes
 124             })
 125
 126         return slivers
 127
 128     def get_peer(self, xrn):
 129         hrn, type = urn_to_hrn(xrn)
 130         # Becaues of myplc federation,  we first need to determine if this
 131         # slice belongs to out local plc or a myplc peer. We will assume it
 132         # is a local site, unless we find out otherwise
 133         peer = None
 134         # get this slice's authority (site)
 135         slice_authority = get_authority(hrn)
 136
 137         # get this site's authority (sfa root authority or sub authority)
 138         site_authority = get_authority(slice_authority).lower()
 139         # check if we are already peered with this site_authority, if so
 140         peers = self.driver.shell.GetPeers({}, ['peer_id', 'peername', 'shortname', 'hrn_root'])
 141         for peer_record in peers:
 142             names = [name.lower() for name in peer_record.values() if isinstance(name, StringTypes)]
 143             if site_authority in names:
 144                 peer = peer_record
 145
 146         return peer
 147
 148     def get_sfa_peer(self, xrn):
 149         hrn, type = urn_to_hrn(xrn)
 150
 151         # return the authority for this hrn or None if we are the authority
 152         sfa_peer = None
 153         slice_authority = get_authority(hrn)
 154         site_authority = get_authority(slice_authority)
 155
 156         if site_authority != self.driver.hrn:
 157             sfa_peer = site_authority
 158
 159         return sfa_peer
 160
 161     def verify_slice_leases(self, slice, requested_leases, kept_leases, peer):
 162
 163         leases = self.driver.shell.GetLeases({'name':slice['name']}, ['lease_id'])
 164         current_leases = [lease['lease_id'] for lease in leases]
 165         deleted_leases = list(set(current_leases).difference(kept_leases))
 166
 167         try:
 168             if peer:
 169                 self.driver.shell.UnBindObjectFromPeer('slice', slice['slice_id'], peer['shortname'])
 170             deleted=self.driver.shell.DeleteLeases(deleted_leases)
 171             for lease in requested_leases:
 172                 added=self.driver.shell.AddLeases(lease['hostname'], slice['name'], int(lease['t_from']), int(lease['t_until']))
 173
 174         except:
 175             logger.log_exc('Failed to add/remove slice leases')
 176
 177         return leases
 178
 179
 180     def verify_slice_nodes(self, slice, requested_slivers, peer):
 181
 182         nodes = self.driver.shell.GetNodes(slice['node_ids'], ['node_id', 'hostname', 'interface_ids'])
 183         current_slivers = [node['hostname'] for node in nodes]
 184
 185         # remove nodes not in rspec
 186         deleted_nodes = list(set(current_slivers).difference(requested_slivers))
 187
 188         # add nodes from rspec
 189         added_nodes = list(set(requested_slivers).difference(current_slivers))
 190
 191         try:
 192             if peer:
 193                 self.driver.shell.UnBindObjectFromPeer('slice', slice['slice_id'], peer['shortname'])
 194             self.driver.shell.AddSliceToNodes(slice['name'], added_nodes)
 195             self.driver.shell.DeleteSliceFromNodes(slice['name'], deleted_nodes)
 196
 197         except:
 198             logger.log_exc('Failed to add/remove slice from nodes')
 199         return nodes
 200
 201     def free_egre_key(self):
 202         used = set()
 203         for tag in self.driver.shell.GetSliceTags({'tagname': 'egre_key'}):
 204                 used.add(int(tag['value']))
 205
 206         for i in range(1, 256):
 207             if i not in used:
 208                 key = i
 209                 break
 210         else:
 211             raise KeyError("No more EGRE keys available")
 212
 213         return str(key)
 214
 215     def verify_slice_links(self, slice, requested_links, nodes):
 216         # nodes is undefined here
 217         if not requested_links:
 218             return
 219
 220         # build dict of nodes
 221         nodes_dict = {}
 222         interface_ids = []
 223         for node in nodes:
 224             nodes_dict[node['node_id']] = node
 225             interface_ids.extend(node['interface_ids'])
 226         # build dict of interfaces
 227         interfaces = self.driver.shell.GetInterfaces(interface_ids)
 228         interfaces_dict = {}
 229         for interface in interfaces:
 230             interfaces_dict[interface['interface_id']] = interface
 231
 232         slice_tags = []
 233
 234         # set egre key
 235         slice_tags.append({'name': 'egre_key', 'value': self.free_egre_key()})
 236
 237         # set netns
 238         slice_tags.append({'name': 'netns', 'value': '1'})
 239
 240         # set cap_net_admin
 241         # need to update the attribute string?
 242         slice_tags.append({'name': 'capabilities', 'value': 'CAP_NET_ADMIN'})
 243
 244         for link in requested_links:
 245             # get the ip address of the first node in the link
 246             ifname1 = Xrn(link['interface1']['component_id']).get_leaf()
 247             (node_raw, device) = ifname1.split(':')
 248             node_id = int(node_raw.replace('node', ''))
 249             node = nodes_dict[node_id]
 250             if1 = interfaces_dict[node['interface_ids'][0]]
 251             ipaddr = if1['ip']
 252             topo_rspec = VLink.get_topo_rspec(link, ipaddr)
 253             # set topo_rspec tag
 254             slice_tags.append({'name': 'topo_rspec', 'value': str([topo_rspec]), 'node_id': node_id})
 255             # set vini_topo tag
 256             slice_tags.append({'name': 'vini_topo', 'value': 'manual', 'node_id': node_id})
 257             #self.driver.shell.AddSliceTag(slice['name'], 'topo_rspec', str([topo_rspec]), node_id)
 258
 259         self.verify_slice_attributes(slice, slice_tags, {'append': True}, admin=True)
 260
 261
 262
 263     def handle_peer(self, site, slice, persons, peer):
 264         if peer:
 265             # bind site
 266             try:
 267                 if site:
 268                     self.driver.shell.BindObjectToPeer('site', site['site_id'], peer['shortname'], slice['site_id'])
 269             except Exception,e:
 270                 self.driver.shell.DeleteSite(site['site_id'])
 271                 raise e
 272
 273             # bind slice
 274             try:
 275                 if slice:
 276                     self.driver.shell.BindObjectToPeer('slice', slice['slice_id'], peer['shortname'], slice['slice_id'])
 277             except Exception,e:
 278                 self.driver.shell.DeleteSlice(slice['slice_id'])
 279                 raise e
 280
 281             # bind persons
 282             for person in persons:
 283                 try:
 284                     self.driver.shell.BindObjectToPeer('person',
 285                                                      person['person_id'], peer['shortname'], person['peer_person_id'])
 286
 287                     for (key, remote_key_id) in zip(person['keys'], person['key_ids']):
 288                         try:
 289                             self.driver.shell.BindObjectToPeer( 'key', key['key_id'], peer['shortname'], remote_key_id)
 290                         except:
 291                             self.driver.shell.DeleteKey(key['key_id'])
 292                             logger("failed to bind key: %s to peer: %s " % (key['key_id'], peer['shortname']))
 293                 except Exception,e:
 294                     self.driver.shell.DeletePerson(person['person_id'])
 295                     raise e
 296
 297         return slice
 298
 299     def verify_site(self, slice_xrn, slice_record={}, peer=None, sfa_peer=None, options={}):
 300         (slice_hrn, type) = urn_to_hrn(slice_xrn)
 301         site_hrn = get_authority(slice_hrn)
 302         # login base can't be longer than 20 characters
 303         slicename = hrn_to_pl_slicename(slice_hrn)
 304         authority_name = slicename.split('_')[0]
 305         login_base = authority_name[:20]
 306         sites = self.driver.shell.GetSites(login_base)
 307         if not sites:
 308             # create new site record
 309             site = {'name': 'geni.%s' % authority_name,
 310                     'abbreviated_name': authority_name,
 311                     'login_base': login_base,
 312                     'max_slices': 100,
 313                     'max_slivers': 1000,
 314                     'enabled': True,
 315                     'peer_site_id': None}
 316             if peer:
 317                 site['peer_site_id'] = slice_record.get('site_id', None)
 318             site['site_id'] = self.driver.shell.AddSite(site)
 319             # exempt federated sites from monitor policies
 320             self.driver.shell.AddSiteTag(site['site_id'], 'exempt_site_until', "20200101")
 321
 322 #            # is this still necessary?
 323 #            # add record to the local registry
 324 #            if sfa_peer and slice_record:
 325 #                peer_dict = {'type': 'authority', 'hrn': site_hrn, \
 326 #                             'peer_authority': sfa_peer, 'pointer': site['site_id']}
 327 #                self.registry.register_peer_object(self.credential, peer_dict)
 328         else:
 329             site =  sites[0]
 330             if peer:
 331                 # unbind from peer so we can modify if necessary. Will bind back later
 332                 self.driver.shell.UnBindObjectFromPeer('site', site['site_id'], peer['shortname'])
 333
 334         return site
 335
 336     def verify_slice(self, slice_hrn, slice_record, peer, sfa_peer, options={}):
 337         slicename = hrn_to_pl_slicename(slice_hrn)
 338         parts = slicename.split("_")
 339         login_base = parts[0]
 340         slices = self.driver.shell.GetSlices([slicename])
 341         if not slices:
 342             slice = {'name': slicename,
 343                      'url': slice_record.get('url', slice_hrn),
 344                      'description': slice_record.get('description', slice_hrn)}
 345             # add the slice
 346             slice['slice_id'] = self.driver.shell.AddSlice(slice)
 347             slice['node_ids'] = []
 348             slice['person_ids'] = []
 349             if peer:
 350                 slice['peer_slice_id'] = slice_record.get('slice_id', None)
 351             # mark this slice as an sfa peer record
 352 #            if sfa_peer:
 353 #                peer_dict = {'type': 'slice', 'hrn': slice_hrn,
 354 #                             'peer_authority': sfa_peer, 'pointer': slice['slice_id']}
 355 #                self.registry.register_peer_object(self.credential, peer_dict)
 356         else:
 357             slice = slices[0]
 358             if peer:
 359                 slice['peer_slice_id'] = slice_record.get('slice_id', None)
 360                 # unbind from peer so we can modify if necessary. Will bind back later
 361                 self.driver.shell.UnBindObjectFromPeer('slice', slice['slice_id'], peer['shortname'])
 362                 #Update existing record (e.g. expires field) it with the latest info.
 363             if slice_record.get('expires'):
 364                 requested_expires = int(datetime_to_epoch(utcparse(slice_record['expires'])))
 365                 if requested_expires and slice['expires'] != requested_expires:
 366                     self.driver.shell.UpdateSlice( slice['slice_id'], {'expires' : requested_expires})
 367
 368         return slice
 369
 370     #def get_existing_persons(self, users):
 371     def verify_persons(self, slice_hrn, slice_record, users, peer, sfa_peer, options={}):
 372         users_by_email = {}
 373         users_by_site = defaultdict(list)
 374         users_dict = {}
 375         for user in users:
 376             user['urn'] = user['urn'].lower()
 377             hrn, type = urn_to_hrn(user['urn'])
 378             username = get_leaf(hrn)
 379             login_base = PlXrn(xrn=user['urn']).pl_login_base()
 380             user['username'] = username
 381             user['site'] = login_base
 382
 383             if 'email' in user:
 384                 user['email'] = user['email'].lower()
 385                 users_by_email[user['email']] = user
 386                 users_dict[user['email']] = user
 387             else:
 388                 users_by_site[user['site']].append(user)
 389
 390         # start building a list of existing users
 391         existing_user_ids = []
 392         existing_user_ids_filter = []
 393         if users_by_email:
 394             existing_user_ids_filter.extend(users_by_email.keys())
 395         if users_by_site:
 396             for login_base in users_by_site:
 397                 users = users_by_site[login_base]
 398                 for user in users:
 399                     existing_user_ids_filter.append(user['username']+'@geni.net')
 400         if existing_user_ids_filter:
 401             # get existing users by email
 402             existing_users = self.driver.shell.GetPersons({'email': existing_user_ids_filter},
 403                                                         ['person_id', 'key_ids', 'email'])
 404             existing_user_ids.extend([user['email'] for user in existing_users])
 405
 406         if users_by_site:
 407             # get a list of user sites (based on requeste user urns
 408             site_list = self.driver.shell.GetSites(users_by_site.keys(), \
 409                 ['site_id', 'login_base', 'person_ids'])
 410             # get all existing users at these sites
 411             sites = {}
 412             site_user_ids = []
 413             for site in site_list:
 414                 sites[site['site_id']] = site
 415                 site_user_ids.extend(site['person_ids'])
 416
 417             existing_site_persons_list = self.driver.shell.GetPersons(site_user_ids,
 418                                                                     ['person_id', 'key_ids', 'email', 'site_ids'])
 419
 420             # all requested users are either existing users or new (added) users
 421             for login_base in users_by_site:
 422                 requested_site_users = users_by_site[login_base]
 423                 for requested_user in requested_site_users:
 424                     user_found = False
 425                     for existing_user in existing_site_persons_list:
 426                         for site_id in existing_user['site_ids']:
 427                             if site_id in sites:
 428                                 site = sites[site_id]
 429                                 if login_base == site['login_base'] and \
 430                                    existing_user['email'].startswith(requested_user['username']+'@'):
 431                                     existing_user_ids.append(existing_user['email'])
 432                                     requested_user['email'] = existing_user['email']
 433                                     users_dict[existing_user['email']] = requested_user
 434                                     user_found = True
 435                                     break
 436                         if user_found:
 437                             break
 438
 439                     if user_found == False:
 440                         fake_email = requested_user['username'] + '@geni.net'
 441                         requested_user['email'] = fake_email
 442                         users_dict[fake_email] = requested_user
 443
 444         # requested slice users
 445         requested_user_ids = users_dict.keys()
 446         # existing slice users
 447         existing_slice_users_filter = {'person_id': slice_record.get('person_ids', [])}
 448         existing_slice_users = self.driver.shell.GetPersons(existing_slice_users_filter,
 449                                                           ['person_id', 'key_ids', 'email'])
 450         existing_slice_user_ids = [user['email'] for user in existing_slice_users]
 451
 452         # users to be added, removed or updated
 453         added_user_ids = set(requested_user_ids).difference(existing_user_ids)
 454         added_slice_user_ids = set(requested_user_ids).difference(existing_slice_user_ids)
 455         removed_user_ids = set(existing_slice_user_ids).difference(requested_user_ids)
 456         updated_user_ids = set(existing_slice_user_ids).intersection(requested_user_ids)
 457
 458         # Remove stale users (only if we are not appending).
 459         # Append by default.
 460         append = options.get('append', True)
 461         if append == False:
 462             for removed_user_id in removed_user_ids:
 463                 self.driver.shell.DeletePersonFromSlice(removed_user_id, slice_record['name'])
 464         # update_existing users
 465         updated_users_list = [user for user in users_dict.values() if user['email'] in \
 466           updated_user_ids]
 467         self.verify_keys(existing_slice_users, updated_users_list, peer, options)
 468
 469         added_persons = []
 470         # add new users
 471         for added_user_id in added_user_ids:
 472             added_user = users_dict[added_user_id]
 473             hrn, type = urn_to_hrn(added_user['urn'])
 474             person = {
 475                 'first_name': added_user.get('first_name', hrn),
 476                 'last_name': added_user.get('last_name', hrn),
 477                 'email': added_user_id,
 478                 'peer_person_id': None,
 479                 'keys': [],
 480                 'key_ids': added_user.get('key_ids', []),
 481             }
 482             person['person_id'] = self.driver.shell.AddPerson(person)
 483             if peer:
 484                 person['peer_person_id'] = added_user['person_id']
 485             added_persons.append(person)
 486
 487             # enable the account
 488             self.driver.shell.UpdatePerson(person['person_id'], {'enabled': True})
 489
 490             # add person to site
 491             self.driver.shell.AddPersonToSite(added_user_id, added_user['site'])
 492
 493             for key_string in added_user.get('keys', []):
 494                 key = {'key':key_string, 'key_type':'ssh'}
 495                 key['key_id'] = self.driver.shell.AddPersonKey(person['person_id'], key)
 496                 person['keys'].append(key)
 497
 498             # add the registry record
 499 #            if sfa_peer:
 500 #                peer_dict = {'type': 'user', 'hrn': hrn, 'peer_authority': sfa_peer, \
 501 #                    'pointer': person['person_id']}
 502 #                self.registry.register_peer_object(self.credential, peer_dict)
 503
 504         for added_slice_user_id in added_slice_user_ids.union(added_user_ids):
 505             # add person to the slice
 506             self.driver.shell.AddPersonToSlice(added_slice_user_id, slice_record['name'])
 507             # if this is a peer record then it should already be bound to a peer.
 508             # no need to return worry about it getting bound later
 509
 510         return added_persons
 511
 512
 513     def verify_keys(self, persons, users, peer, options={}):
 514         # existing keys
 515         key_ids = []
 516         for person in persons:
 517             key_ids.extend(person['key_ids'])
 518         keylist = self.driver.shell.GetKeys(key_ids, ['key_id', 'key'])
 519         keydict = {}
 520         for key in keylist:
 521             keydict[key['key']] = key['key_id']
 522         existing_keys = keydict.keys()
 523         persondict = {}
 524         for person in persons:
 525             persondict[person['email']] = person
 526
 527         # add new keys
 528         requested_keys = []
 529         updated_persons = []
 530         for user in users:
 531             user_keys = user.get('keys', [])
 532             updated_persons.append(user)
 533             for key_string in user_keys:
 534                 requested_keys.append(key_string)
 535                 if key_string not in existing_keys:
 536                     key = {'key': key_string, 'key_type': 'ssh'}
 537                     try:
 538                         if peer:
 539                             person = persondict[user['email']]
 540                             self.driver.shell.UnBindObjectFromPeer('person', person['person_id'], peer['shortname'])
 541                         key['key_id'] = self.driver.shell.AddPersonKey(user['email'], key)
 542                         if peer:
 543                             key_index = user_keys.index(key['key'])
 544                             remote_key_id = user['key_ids'][key_index]
 545                             self.driver.shell.BindObjectToPeer('key', key['key_id'], peer['shortname'], remote_key_id)
 546
 547                     finally:
 548                         if peer:
 549                             self.driver.shell.BindObjectToPeer('person', person['person_id'], peer['shortname'], user['person_id'])
 550
 551         # remove old keys (only if we are not appending)
 552         append = options.get('append', True)
 553         if append == False:
 554             removed_keys = set(existing_keys).difference(requested_keys)
 555             for existing_key_id in keydict:
 556                 if keydict[existing_key_id] in removed_keys:
 557                     try:
 558                         if peer:
 559                             self.driver.shell.UnBindObjectFromPeer('key', existing_key_id, peer['shortname'])
 560                         self.driver.shell.DeleteKey(existing_key_id)
 561                     except:
 562                         pass
 563
 564     def verify_slice_attributes(self, slice, requested_slice_attributes, options={}, admin=False):
 565         append = options.get('append', True)
 566         # get list of attributes users ar able to manage
 567         filter = {'category': '*slice*'}
 568         if not admin:
 569             filter['|roles'] = ['user']
 570         slice_attributes = self.driver.shell.GetTagTypes(filter)
 571         valid_slice_attribute_names = [attribute['tagname'] for attribute in slice_attributes]
 572
 573         # get sliver attributes
 574         added_slice_attributes = []
 575         removed_slice_attributes = []
 576         ignored_slice_attribute_names = []
 577         existing_slice_attributes = self.driver.shell.GetSliceTags({'slice_id': slice['slice_id']})
 578
 579         # get attributes that should be removed
 580         for slice_tag in existing_slice_attributes:
 581             if slice_tag['tagname'] in ignored_slice_attribute_names:
 582                 # If a slice already has a admin only role it was probably given to them by an
 583                 # admin, so we should ignore it.
 584                 ignored_slice_attribute_names.append(slice_tag['tagname'])
 585             else:
 586                 # If an existing slice attribute was not found in the request it should
 587                 # be removed
 588                 attribute_found=False
 589                 for requested_attribute in requested_slice_attributes:
 590                     if requested_attribute['name'] == slice_tag['tagname'] and \
 591                        requested_attribute['value'] == slice_tag['value']:
 592                         attribute_found=True
 593                         break
 594
 595             if not attribute_found and not append:
 596                 removed_slice_attributes.append(slice_tag)
 597
 598         # get attributes that should be added:
 599         for requested_attribute in requested_slice_attributes:
 600             # if the requested attribute wasn't found  we should add it
 601             if requested_attribute['name'] in valid_slice_attribute_names:
 602                 attribute_found = False
 603                 for existing_attribute in existing_slice_attributes:
 604                     if requested_attribute['name'] == existing_attribute['tagname'] and \
 605                        requested_attribute['value'] == existing_attribute['value']:
 606                         attribute_found=True
 607                         break
 608                 if not attribute_found:
 609                     added_slice_attributes.append(requested_attribute)
 610
 611
 612         # remove stale attributes
 613         for attribute in removed_slice_attributes:
 614             try:
 615                 self.driver.shell.DeleteSliceTag(attribute['slice_tag_id'])
 616             except Exception, e:
 617                 logger.warn('Failed to remove sliver attribute. name: %s, value: %s, node_id: %s\nCause:%s'\
 618                                 % (slice['name'], attribute['value'],  attribute.get('node_id'), str(e)))
 619
 620         # add requested_attributes
 621         for attribute in added_slice_attributes:
 622             try:
 623                 self.driver.shell.AddSliceTag(slice['name'], attribute['name'], attribute['value'], attribute.get('node_id', None))
 624             except Exception, e:
 625                 logger.warn('Failed to add sliver attribute. name: %s, value: %s, node_id: %s\nCause:%s'\
 626                                 % (slice['name'], attribute['value'],  attribute.get('node_id'), str(e)))
 627