plshell: explicitly cast to string PL Username and AuthString
[sfa.git] / sfa / planetlab / plslices.py
1 import time
2 from types import StringTypes
3 from collections import defaultdict
4
5 from sfa.util.sfatime import utcparse, datetime_to_epoch
6 from sfa.util.sfalogging import logger
7 from sfa.util.xrn import Xrn, get_leaf, get_authority, urn_to_hrn
8 from sfa.rspecs.rspec import RSpec
9 from sfa.planetlab.vlink import VLink
10 from sfa.planetlab.topology import Topology
11 from sfa.planetlab.plxrn import PlXrn, hrn_to_pl_slicename, xrn_to_hostname, top_auth, hash_loginbase
12 from sfa.storage.model import SliverAllocation
13 from sfa.storage.alchemy import dbsession
14
15 MAXINT =  2L**31-1
16
17 class PlSlices:
18
19     rspec_to_slice_tag = {'max_rate':'net_max_rate'}
20
21     def __init__(self, driver):
22         self.driver = driver
23
24     def get_slivers(self, xrn, node=None):
25         hrn, type = urn_to_hrn(xrn)
26          
27         slice_name = hrn_to_pl_slicename(hrn)
28         # XX Should we just call PLCAPI.GetSliceTicket(slice_name) instead
29         # of doing all of this?
30         #return self.driver.shell.GetSliceTicket(self.auth, slice_name) 
31         
32         # from PLCAPI.GetSlivers.get_slivers()
33         slice_fields = ['slice_id', 'name', 'instantiation', 'expires', 'person_ids', 'slice_tag_ids']
34         slices = self.driver.shell.GetSlices(slice_name, slice_fields)
35         # Build up list of users and slice attributes
36         person_ids = set()
37         all_slice_tag_ids = set()
38         for slice in slices:
39             person_ids.update(slice['person_ids'])
40             all_slice_tag_ids.update(slice['slice_tag_ids'])
41         person_ids = list(person_ids)
42         all_slice_tag_ids = list(all_slice_tag_ids)
43         # Get user information
44         all_persons_list = self.driver.shell.GetPersons({'person_id':person_ids,'enabled':True}, ['person_id', 'enabled', 'key_ids'])
45         all_persons = {}
46         for person in all_persons_list:
47             all_persons[person['person_id']] = person        
48
49         # Build up list of keys
50         key_ids = set()
51         for person in all_persons.values():
52             key_ids.update(person['key_ids'])
53         key_ids = list(key_ids)
54         # Get user account keys
55         all_keys_list = self.driver.shell.GetKeys(key_ids, ['key_id', 'key', 'key_type'])
56         all_keys = {}
57         for key in all_keys_list:
58             all_keys[key['key_id']] = key
59         # Get slice attributes
60         all_slice_tags_list = self.driver.shell.GetSliceTags(all_slice_tag_ids)
61         all_slice_tags = {}
62         for slice_tag in all_slice_tags_list:
63             all_slice_tags[slice_tag['slice_tag_id']] = slice_tag
64            
65         slivers = []
66         for slice in slices:
67             keys = []
68             for person_id in slice['person_ids']:
69                 if person_id in all_persons:
70                     person = all_persons[person_id]
71                     if not person['enabled']:
72                         continue
73                     for key_id in person['key_ids']:
74                         if key_id in all_keys:
75                             key = all_keys[key_id]
76                             keys += [{'key_type': key['key_type'],
77                                     'key': key['key']}]
78             attributes = []
79             # All (per-node and global) attributes for this slice
80             slice_tags = []
81             for slice_tag_id in slice['slice_tag_ids']:
82                 if slice_tag_id in all_slice_tags:
83                     slice_tags.append(all_slice_tags[slice_tag_id]) 
84             # Per-node sliver attributes take precedence over global
85             # slice attributes, so set them first.
86             # Then comes nodegroup slice attributes
87             # Followed by global slice attributes
88             sliver_attributes = []
89
90             if node is not None:
91                 for sliver_attribute in filter(lambda a: a['node_id'] == node['node_id'], slice_tags):
92                     sliver_attributes.append(sliver_attribute['tagname'])
93                     attributes.append({'tagname': sliver_attribute['tagname'],
94                                     'value': sliver_attribute['value']})
95
96             # set nodegroup slice attributes
97             for slice_tag in filter(lambda a: a['nodegroup_id'] in node['nodegroup_ids'], slice_tags):
98                 # Do not set any nodegroup slice attributes for
99                 # which there is at least one sliver attribute
100                 # already set.
101                 if slice_tag not in slice_tags:
102                     attributes.append({'tagname': slice_tag['tagname'],
103                         'value': slice_tag['value']})
104
105             for slice_tag in filter(lambda a: a['node_id'] is None, slice_tags):
106                 # Do not set any global slice attributes for
107                 # which there is at least one sliver attribute
108                 # already set.
109                 if slice_tag['tagname'] not in sliver_attributes:
110                     attributes.append({'tagname': slice_tag['tagname'],
111                                    'value': slice_tag['value']})
112
113             # XXX Sanity check; though technically this should be a system invariant
114             # checked with an assertion
115             if slice['expires'] > MAXINT:  slice['expires']= MAXINT
116             
117             slivers.append({
118                 'hrn': hrn,
119                 'name': slice['name'],
120                 'slice_id': slice['slice_id'],
121                 'instantiation': slice['instantiation'],
122                 'expires': slice['expires'],
123                 'keys': keys,
124                 'attributes': attributes
125             })
126
127         return slivers
128  
129     def get_peer(self, xrn):
130         hrn, type = urn_to_hrn(xrn)
131         # Becaues of myplc federation,  we first need to determine if this
132         # slice belongs to out local plc or a myplc peer. We will assume it 
133         # is a local site, unless we find out otherwise  
134         peer = None
135
136         # get this slice's authority (site)
137         slice_authority = get_authority(hrn)
138
139         # get this site's authority (sfa root authority or sub authority)
140         site_authority = get_authority(slice_authority).lower()
141
142         # check if we are already peered with this site_authority, if so
143         peers = self.driver.shell.GetPeers({}, ['peer_id', 'peername', 'shortname', 'hrn_root'])
144         for peer_record in peers:
145             names = [name.lower() for name in peer_record.values() if isinstance(name, StringTypes)]
146             if site_authority in names:
147                 peer = peer_record
148
149         return peer
150
151     def get_sfa_peer(self, xrn):
152         hrn, type = urn_to_hrn(xrn)
153
154         # return the authority for this hrn or None if we are the authority
155         sfa_peer = None
156         slice_authority = get_authority(hrn)
157         site_authority = get_authority(slice_authority)
158
159         if site_authority != self.driver.hrn:
160             sfa_peer = site_authority
161
162         return sfa_peer
163
164     def verify_slice_leases(self, slice, rspec_requested_leases, peer):
165
166         leases = self.driver.shell.GetLeases({'name':slice['name'], 'clip':int(time.time())}, ['lease_id','name', 'hostname', 't_from', 't_until'])
167         grain = self.driver.shell.GetLeaseGranularity()
168
169         requested_leases = []
170         for lease in rspec_requested_leases:
171              requested_lease = {}
172              slice_hrn, _ = urn_to_hrn(lease['slice_id'])
173
174              top_auth_hrn = top_auth(slice_hrn)
175              site_hrn = '.'.join(slice_hrn.split('.')[:-1])
176              slice_part = slice_hrn.split('.')[-1]
177              if top_auth_hrn == self.driver.hrn:
178                  login_base = slice_hrn.split('.')[-2][:12]
179              else:
180                  login_base = hash_loginbase(site_hrn)
181
182              slice_name = '_'.join([login_base, slice_part])
183
184              if slice_name != slice['name']:
185                  continue
186              elif Xrn(lease['component_id']).get_authority_urn().split(':')[0] != self.driver.hrn:
187                  continue
188
189              hostname = xrn_to_hostname(lease['component_id'])
190              # fill the requested node with nitos ids
191              requested_lease['name'] = slice['name']
192              requested_lease['hostname'] = hostname
193              requested_lease['t_from'] = int(lease['start_time'])
194              requested_lease['t_until'] = int(lease['duration']) * grain + int(lease['start_time'])
195              requested_leases.append(requested_lease)
196
197
198
199         # prepare actual slice leases by lease_id  
200         leases_by_id = {}
201         for lease in leases:
202              leases_by_id[lease['lease_id']] = {'name': lease['name'], 'hostname': lease['hostname'], \
203                                                 't_from': lease['t_from'], 't_until': lease['t_until']}
204         
205         added_leases = []
206         kept_leases_id = []
207         deleted_leases_id = []
208         for lease_id in leases_by_id:
209              if leases_by_id[lease_id] not in requested_leases:
210                  deleted_leases_id.append(lease_id)
211              else:
212                  kept_leases_id.append(lease_id)
213                  requested_leases.remove(leases_by_id[lease_id])
214         added_leases = requested_leases
215    
216
217         try:
218             if peer:
219                 self.driver.shell.UnBindObjectFromPeer('slice', slice['slice_id'], peer['shortname'])
220             self.driver.shell.DeleteLeases(deleted_leases_id)
221             for lease in added_leases:
222                 self.driver.shell.AddLeases(lease['hostname'], slice['name'], lease['t_from'], lease['t_until'])
223
224         except: 
225             logger.log_exc('Failed to add/remove slice leases')
226
227         return leases
228
229
230     def verify_slice_nodes(self, slice_urn, slice, rspec_nodes, peer):
231         
232         slivers = {}
233         for node in rspec_nodes:
234             hostname = node.get('component_name')
235             client_id = node.get('client_id')
236             component_id = node.get('component_id').strip()    
237             if hostname:
238                 hostname = hostname.strip()
239             elif component_id:
240                 hostname = xrn_to_hostname(component_id)
241             if hostname:
242                 slivers[hostname] = {'client_id': client_id, 'component_id': component_id}
243         
244         nodes = self.driver.shell.GetNodes(slice['node_ids'], ['node_id', 'hostname', 'interface_ids'])
245         current_slivers = [node['hostname'] for node in nodes]
246
247         # remove nodes not in rspec
248         deleted_nodes = list(set(current_slivers).difference(slivers.keys()))
249
250         # add nodes from rspec
251         added_nodes = list(set(slivers.keys()).difference(current_slivers))        
252
253         try:
254             if peer:
255                 self.driver.shell.UnBindObjectFromPeer('slice', slice['slice_id'], peer['shortname'])
256             self.driver.shell.AddSliceToNodes(slice['name'], added_nodes)
257             self.driver.shell.DeleteSliceFromNodes(slice['name'], deleted_nodes)
258             
259         except: 
260             logger.log_exc('Failed to add/remove slice from nodes')
261
262         slices = self.driver.shell.GetSlices(slice['name'], ['node_ids']) 
263         resulting_nodes = self.driver.shell.GetNodes(slices[0]['node_ids'])
264
265         # update sliver allocations
266         for node in resulting_nodes:
267             client_id = slivers[node['hostname']]['client_id']
268             component_id = slivers[node['hostname']]['component_id']
269             sliver_hrn = '%s.%s-%s' % (self.driver.hrn, slice['slice_id'], node['node_id'])
270             sliver_id = Xrn(sliver_hrn, type='sliver').urn
271             record = SliverAllocation(sliver_id=sliver_id, client_id=client_id, 
272                                       component_id=component_id,
273                                       slice_urn = slice_urn, 
274                                       allocation_state='geni_allocated')      
275             record.sync()
276         return resulting_nodes
277
278     def free_egre_key(self):
279         used = set()
280         for tag in self.driver.shell.GetSliceTags({'tagname': 'egre_key'}):
281                 used.add(int(tag['value']))
282
283         for i in range(1, 256):
284             if i not in used:
285                 key = i
286                 break
287         else:
288             raise KeyError("No more EGRE keys available")
289
290         return str(key)
291
292     def verify_slice_links(self, slice, requested_links, nodes):
293          
294         if not requested_links:
295             return
296
297         # exit if links are not supported here
298         topology = Topology()
299         if not topology:
300             return 
301
302         # build dict of nodes 
303         nodes_dict = {}
304         interface_ids = []
305         for node in nodes:
306             nodes_dict[node['node_id']] = node
307             interface_ids.extend(node['interface_ids'])
308         # build dict of interfaces
309         interfaces = self.driver.shell.GetInterfaces(interface_ids)
310         interfaces_dict = {}
311         for interface in interfaces:
312             interfaces_dict[interface['interface_id']] = interface 
313
314         slice_tags = []
315         
316         # set egre key
317         slice_tags.append({'name': 'egre_key', 'value': self.free_egre_key()})
318     
319         # set netns
320         slice_tags.append({'name': 'netns', 'value': '1'})
321
322         # set cap_net_admin 
323         # need to update the attribute string?
324         slice_tags.append({'name': 'capabilities', 'value': 'CAP_NET_ADMIN'}) 
325         
326         for link in requested_links:
327             # get the ip address of the first node in the link
328             ifname1 = Xrn(link['interface1']['component_id']).get_leaf()
329             ifname_parts = ifname1.split(':')
330             node_raw = ifname_parts[0]
331             device = None
332             if len(ifname_parts) > 1:
333                 device = ifname_parts[1] 
334             node_id = int(node_raw.replace('node', ''))
335             node = nodes_dict[node_id]
336             if1 = interfaces_dict[node['interface_ids'][0]]
337             ipaddr = if1['ip']
338             topo_rspec = VLink.get_topo_rspec(link, ipaddr)
339             # set topo_rspec tag
340             slice_tags.append({'name': 'topo_rspec', 'value': str([topo_rspec]), 'node_id': node_id})
341             # set vini_topo tag
342             slice_tags.append({'name': 'vini_topo', 'value': 'manual', 'node_id': node_id})
343             #self.driver.shell.AddSliceTag(slice['name'], 'topo_rspec', str([topo_rspec]), node_id) 
344
345         self.verify_slice_attributes(slice, slice_tags, {'append': True}, admin=True)
346                         
347         
348
349     def handle_peer(self, site, slice, persons, peer):
350         if peer:
351             # bind site
352             try:
353                 if site:
354                     self.driver.shell.BindObjectToPeer('site', site['site_id'], peer['shortname'], slice['site_id'])
355             except Exception,e:
356                 self.driver.shell.DeleteSite(site['site_id'])
357                 raise e
358             
359             # bind slice
360             try:
361                 if slice:
362                     self.driver.shell.BindObjectToPeer('slice', slice['slice_id'], peer['shortname'], slice['slice_id'])
363             except Exception,e:
364                 self.driver.shell.DeleteSlice(slice['slice_id'])
365                 raise e 
366
367             # bind persons
368             for person in persons:
369                 try:
370                     self.driver.shell.BindObjectToPeer('person', 
371                                                      person['person_id'], peer['shortname'], person['peer_person_id'])
372
373                     for (key, remote_key_id) in zip(person['keys'], person['key_ids']):
374                         try:
375                             self.driver.shell.BindObjectToPeer( 'key', key['key_id'], peer['shortname'], remote_key_id)
376                         except:
377                             self.driver.shell.DeleteKey(key['key_id'])
378                             logger("failed to bind key: %s to peer: %s " % (key['key_id'], peer['shortname']))
379                 except Exception,e:
380                     self.driver.shell.DeletePerson(person['person_id'])
381                     raise e       
382
383         return slice
384
385     def verify_site(self, slice_xrn, slice_record={}, peer=None, sfa_peer=None, options={}):
386         (slice_hrn, type) = urn_to_hrn(slice_xrn)
387         top_auth_hrn = top_auth(slice_hrn)
388         site_hrn = '.'.join(slice_hrn.split('.')[:-1])
389         if top_auth_hrn == self.driver.hrn:
390             login_base = slice_hrn.split('.')[-2][:12]
391         else:
392             login_base = hash_loginbase(site_hrn)
393
394         sites = self.driver.shell.GetSites({'peer_id': None},['site_id','name','abbreviated_name','login_base','hrn'])
395
396         # filter sites by hrn
397         site_exists = [site for site in sites if site['hrn'] == site_hrn]
398
399         if not site_exists:
400             # create new site record
401             site = {'name': 'sfa:%s' % site_hrn,
402                     'abbreviated_name': site_hrn,
403                     'login_base': login_base,
404                     'max_slices': 100,
405                     'max_slivers': 1000,
406                     'enabled': True,
407                     'peer_site_id': None}
408
409             site['site_id'] = self.driver.shell.AddSite(site)
410             # Set site HRN
411             self.driver.shell.SetSiteHrn(int(site['site_id']), site_hrn)
412             # Tag this as created through SFA
413             self.driver.shell.SetSiteSfaCreated(int(site['site_id']), 'True')
414             # exempt federated sites from monitor policies
415             self.driver.shell.AddSiteTag(int(site['site_id']), 'exempt_site_until', "20200101")
416
417         else:
418             site =  site_exists[0]
419
420         return site
421
422
423     def verify_slice(self, slice_hrn, slice_record, peer, sfa_peer, expiration, options={}):
424         top_auth_hrn = top_auth(slice_hrn)
425         site_hrn = '.'.join(slice_hrn.split('.')[:-1])
426         slice_part = slice_hrn.split('.')[-1]
427         if top_auth_hrn == self.driver.hrn:
428             login_base = slice_hrn.split('.')[-2][:12]
429         else:
430             login_base = hash_loginbase(site_hrn)
431
432
433         slice_name = '_'.join([login_base, slice_part])
434
435         slices = self.driver.shell.GetSlices({'peer_id': None},['slice_id','name','hrn'])
436         # Filter slices by HRN
437         slice_exists = [slice for slice in slices if slice['hrn'] == slice_hrn]
438         expires = int(datetime_to_epoch(utcparse(expiration)))
439         if not slice_exists:
440             slice = {'name': slice_name,
441                      'url': slice_record.get('url', slice_hrn),
442                      'description': slice_record.get('description', slice_hrn)}
443             # add the slice                          
444             slice['slice_id'] = self.driver.shell.AddSlice(slice)
445             # set the slice HRN
446             self.driver.shell.SetSliceHrn(int(slice['slice_id']), slice_hrn)       
447             # Tag this as created through SFA
448             self.driver.shell.SetSliceSfaCreated(int(slice['slice_id']), 'True')
449             # set the expiration
450             self.driver.shell.UpdateSlice(int(slice['slice_id']), {'expires': expires})
451
452         else:
453             slice = slice_exists[0]
454             #Update expiration if necessary
455             if slice.get('expires', None) != expires:
456                 self.driver.shell.UpdateSlice( int(slice['slice_id']), {'expires' : expires})
457
458         return self.driver.shell.GetSlices(int(slice['slice_id']))[0]
459
460
461     def verify_persons(self, slice_hrn, slice_record, users, peer, sfa_peer, options={}):
462         top_auth_hrn = top_auth(slice_hrn)
463         site_hrn = '.'.join(slice_hrn.split('.')[:-1])
464         slice_part = slice_hrn.split('.')[-1]
465         users_by_hrn = {}
466         for user in users:
467            user['hrn'], _ = urn_to_hrn(user['urn'])
468            users_by_hrn[user['hrn']] = user
469
470         if top_auth_hrn == self.driver.hrn:
471             login_base = slice_hrn.split('.')[-2][:12]
472         else:
473             login_base = hash_loginbase(site_hrn)
474
475         slice_name = '_'.join([login_base, slice_part])
476
477         persons = self.driver.shell.GetPersons({'peer_id': None},['person_id','email','hrn'])
478         site = self.driver.shell.GetSites({'peer_id': None, 'login_base': login_base})[0]
479         slice = self.driver.shell.GetSlices({'peer_id': None, 'name': slice_name})[0]
480         slice_persons = self.driver.shell.GetPersons({'peer_id': None, 'person_id': slice['person_ids']},['person_id','email','hrn'])
481
482         persons_by_hrn = {}
483         persons_by_email = {}
484         for person in persons:
485            persons_by_hrn[person['hrn']] = person
486            persons_by_email[person['email']] = person
487         slice_persons_by_hrn = {}
488         for slice_person in slice_persons:
489            slice_persons_by_hrn[slice_person['hrn']] = slice_person
490
491         # sort persons by HRN
492         persons_to_add = set(users_by_hrn.keys()).difference(slice_persons_by_hrn.keys())
493         persons_to_delete = set(slice_persons_by_hrn.keys()).difference(users_by_hrn.keys())
494         persons_to_keep = set(users_by_hrn.keys()).intersection(slice_persons_by_hrn.keys())
495
496
497         persons_to_verify_keys = {}
498
499         # Add persons or add persons to slice
500         for person_hrn in persons_to_add:
501              person_email = users_by_hrn[person_hrn].get('email', None)
502              if person_email and person_email in persons_by_email.keys():
503                  # check if the user already exist in PL
504                  person_id = persons_by_email[person_email]['person_id']
505                  self.driver.shell.AddPersonToSlice(person_id, slice['slice_id'])
506                  persons_to_verify_keys[person_id] = users_by_hrn[person_hrn]
507
508              else:
509                  person = {
510                            'first_name': person_hrn,
511                            'last_name': person_hrn,
512                            'email': users_by_hrn[person_hrn].get('email', "%s@geni.net"%person_hrn.split('.')[-1]),
513                           }
514
515                  person_id = self.driver.shell.AddPerson(person)
516                  self.driver.shell.AddRoleToPerson('user', int(person_id))
517                  # enable the account 
518                  self.driver.shell.UpdatePerson(int(person_id), {'enabled': True})
519                  self.driver.shell.SetPersonHrn(int(person_id), person_hrn)
520                  self.driver.shell.SetPersonSfaCreated(int(person_id), 'True')
521                  self.driver.shell.AddPersonToSite(int(person_id), site['site_id'])
522                  self.driver.shell.AddPersonToSlice(int(person_id), slice['slice_id'])
523
524                  # Add keys
525                  for key in users_by_hrn[person_hrn].get('keys', []):
526                       key = {'key':key, 'key_type':'ssh'}
527                       self.driver.shell.AddPersonKey(person_id, key)
528
529
530         # Delete persons from slice     
531         for person_hrn in persons_to_delete:
532              person_id = slice_persons_by_hrn[person_hrn].get('person_id')
533              slice_id = slice['slice_id']
534              self.driver.shell.DeletePersonFromSlice(person_id, slice_id)
535
536
537         # Update kept persons
538         for person_hrn in persons_to_keep:
539              person_id = slice_persons_by_hrn[person_hrn].get('person_id')
540              persons_to_verify_keys[person_id] = users_by_hrn[person_hrn]
541
542         self.verify_keys(persons_to_verify_keys, peer, options)
543
544         return persons_to_add
545
546
547     def verify_keys(self, persons_to_verify_keys, peer, options={}):
548         # we only add keys that comes from sfa to persons in PL
549         for person_id in persons_to_verify_keys:
550              person_sfa_keys = persons_to_verify_keys[person_id].get('keys', [])
551              person_pl_keys = self.driver.shell.GetKeys({'person_id': int(person_id)})
552              person_pl_keys_list = [key['key'] for key in person_pl_keys]
553
554              keys_to_add = set(person_sfa_keys).difference(person_pl_keys_list)
555
556              for key_string in keys_to_add:
557                   key = {'key': key_string, 'key_type': 'ssh'}
558                   self.driver.shell.AddPersonKey(int(person_id), key)
559
560
561     def verify_slice_attributes(self, slice, requested_slice_attributes, options={}, admin=False):
562         append = options.get('append', True)
563         # get list of attributes users ar able to manage
564         filter = {'category': '*slice*'}
565         if not admin:
566             filter['|roles'] = ['user']
567         slice_attributes = self.driver.shell.GetTagTypes(filter)
568         valid_slice_attribute_names = [attribute['tagname'] for attribute in slice_attributes]
569
570         # get sliver attributes
571         added_slice_attributes = []
572         removed_slice_attributes = []
573         # we need to keep the slice hrn anyway
574         ignored_slice_attribute_names = ['hrn']
575         existing_slice_attributes = self.driver.shell.GetSliceTags({'slice_id': slice['slice_id']})
576
577         # get attributes that should be removed
578         for slice_tag in existing_slice_attributes:
579             if slice_tag['tagname'] in ignored_slice_attribute_names:
580                 # If a slice already has a admin only role it was probably given to them by an
581                 # admin, so we should ignore it.
582                 ignored_slice_attribute_names.append(slice_tag['tagname'])
583                 attribute_found=True
584             else:
585                 # If an existing slice attribute was not found in the request it should
586                 # be removed
587                 attribute_found=False
588                 for requested_attribute in requested_slice_attributes:
589                     if requested_attribute['name'] == slice_tag['tagname'] and \
590                        requested_attribute['value'] == slice_tag['value']:
591                         attribute_found=True
592                         break
593
594             if not attribute_found and not append:
595                 removed_slice_attributes.append(slice_tag)
596
597         # get attributes that should be added:
598         for requested_attribute in requested_slice_attributes:
599             # if the requested attribute wasn't found  we should add it
600             if requested_attribute['name'] in valid_slice_attribute_names:
601                 attribute_found = False
602                 for existing_attribute in existing_slice_attributes:
603                     if requested_attribute['name'] == existing_attribute['tagname'] and \
604                        requested_attribute['value'] == existing_attribute['value']:
605                         attribute_found=True
606                         break
607                 if not attribute_found:
608                     added_slice_attributes.append(requested_attribute)
609
610
611         # remove stale attributes
612         for attribute in removed_slice_attributes:
613             try:
614                 self.driver.shell.DeleteSliceTag(attribute['slice_tag_id'])
615             except Exception, e:
616                 logger.warn('Failed to remove sliver attribute. name: %s, value: %s, node_id: %s\nCause:%s'\
617                                 % (slice['name'], attribute['value'],  attribute.get('node_id'), str(e)))
618
619         # add requested_attributes
620         for attribute in added_slice_attributes:
621             try:
622                 self.driver.shell.AddSliceTag(slice['name'], attribute['name'], attribute['value'], attribute.get('node_id', None))
623             except Exception, e:
624                 logger.warn('Failed to add sliver attribute. name: %s, value: %s, node_id: %s\nCause:%s'\
625                                 % (slice['name'], attribute['value'],  attribute.get('node_id'), str(e)))
626