lib/ofp-actions.c

   1 /*
   2  * Copyright (c) 2008, 2009, 2010, 2011, 2012, 2013 Nicira, Inc.
   3  *
   4  * Licensed under the Apache License, Version 2.0 (the "License");
   5  * you may not use this file except in compliance with the License.
   6  * You may obtain a copy of the License at:
   7  *
   8  *     http://www.apache.org/licenses/LICENSE-2.0
   9  *
  10  * Unless required by applicable law or agreed to in writing, software
  11  * distributed under the License is distributed on an "AS IS" BASIS,
  12  * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  13  * See the License for the specific language governing permissions and
  14  * limitations under the License.
  15  */
  16
  17 #include <config.h>
  18 #include "ofp-actions.h"
  19 #include "bundle.h"
  20 #include "byte-order.h"
  21 #include "compiler.h"
  22 #include "dynamic-string.h"
  23 #include "learn.h"
  24 #include "meta-flow.h"
  25 #include "multipath.h"
  26 #include "nx-match.h"
  27 #include "ofp-util.h"
  28 #include "ofpbuf.h"
  29 #include "util.h"
  30 #include "vlog.h"
  31
  32 VLOG_DEFINE_THIS_MODULE(ofp_actions);
  33
  34 static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(1, 5);
  35 \f
  36 /* Converting OpenFlow 1.0 to ofpacts. */
  37
  38 static enum ofperr
  39 output_from_openflow10(const struct ofp10_action_output *oao,
  40                        struct ofpbuf *out)
  41 {
  42     struct ofpact_output *output;
  43
  44     output = ofpact_put_OUTPUT(out);
  45     output->port = u16_to_ofp(ntohs(oao->port));
  46     output->max_len = ntohs(oao->max_len);
  47
  48     return ofputil_check_output_port(output->port, OFPP_MAX);
  49 }
  50
  51 static enum ofperr
  52 enqueue_from_openflow10(const struct ofp10_action_enqueue *oae,
  53                         struct ofpbuf *out)
  54 {
  55     struct ofpact_enqueue *enqueue;
  56
  57     enqueue = ofpact_put_ENQUEUE(out);
  58     enqueue->port = u16_to_ofp(ntohs(oae->port));
  59     enqueue->queue = ntohl(oae->queue_id);
  60     if (ofp_to_u16(enqueue->port) >= ofp_to_u16(OFPP_MAX)
  61         && enqueue->port != OFPP_IN_PORT
  62         && enqueue->port != OFPP_LOCAL) {
  63         return OFPERR_OFPBAC_BAD_OUT_PORT;
  64     }
  65     return 0;
  66 }
  67
  68 static void
  69 resubmit_from_openflow(const struct nx_action_resubmit *nar,
  70                        struct ofpbuf *out)
  71 {
  72     struct ofpact_resubmit *resubmit;
  73
  74     resubmit = ofpact_put_RESUBMIT(out);
  75     resubmit->ofpact.compat = OFPUTIL_NXAST_RESUBMIT;
  76     resubmit->in_port = u16_to_ofp(ntohs(nar->in_port));
  77     resubmit->table_id = 0xff;
  78 }
  79
  80 static enum ofperr
  81 resubmit_table_from_openflow(const struct nx_action_resubmit *nar,
  82                              struct ofpbuf *out)
  83 {
  84     struct ofpact_resubmit *resubmit;
  85
  86     if (nar->pad[0] || nar->pad[1] || nar->pad[2]) {
  87         return OFPERR_OFPBAC_BAD_ARGUMENT;
  88     }
  89
  90     resubmit = ofpact_put_RESUBMIT(out);
  91     resubmit->ofpact.compat = OFPUTIL_NXAST_RESUBMIT_TABLE;
  92     resubmit->in_port = u16_to_ofp(ntohs(nar->in_port));
  93     resubmit->table_id = nar->table;
  94     return 0;
  95 }
  96
  97 static enum ofperr
  98 output_reg_from_openflow(const struct nx_action_output_reg *naor,
  99                          struct ofpbuf *out)
 100 {
 101     struct ofpact_output_reg *output_reg;
 102
 103     if (!is_all_zeros(naor->zero, sizeof naor->zero)) {
 104         return OFPERR_OFPBAC_BAD_ARGUMENT;
 105     }
 106
 107     output_reg = ofpact_put_OUTPUT_REG(out);
 108     output_reg->src.field = mf_from_nxm_header(ntohl(naor->src));
 109     output_reg->src.ofs = nxm_decode_ofs(naor->ofs_nbits);
 110     output_reg->src.n_bits = nxm_decode_n_bits(naor->ofs_nbits);
 111     output_reg->max_len = ntohs(naor->max_len);
 112
 113     return mf_check_src(&output_reg->src, NULL);
 114 }
 115
 116 static void
 117 fin_timeout_from_openflow(const struct nx_action_fin_timeout *naft,
 118                           struct ofpbuf *out)
 119 {
 120     struct ofpact_fin_timeout *oft;
 121
 122     oft = ofpact_put_FIN_TIMEOUT(out);
 123     oft->fin_idle_timeout = ntohs(naft->fin_idle_timeout);
 124     oft->fin_hard_timeout = ntohs(naft->fin_hard_timeout);
 125 }
 126
 127 static void
 128 controller_from_openflow(const struct nx_action_controller *nac,
 129                          struct ofpbuf *out)
 130 {
 131     struct ofpact_controller *oc;
 132
 133     oc = ofpact_put_CONTROLLER(out);
 134     oc->max_len = ntohs(nac->max_len);
 135     oc->controller_id = ntohs(nac->controller_id);
 136     oc->reason = nac->reason;
 137 }
 138
 139 static enum ofperr
 140 metadata_from_nxast(const struct nx_action_write_metadata *nawm,
 141                     struct ofpbuf *out)
 142 {
 143     struct ofpact_metadata *om;
 144
 145     if (!is_all_zeros(nawm->zeros, sizeof nawm->zeros)) {
 146         return OFPERR_NXBRC_MUST_BE_ZERO;
 147     }
 148
 149     om = ofpact_put_WRITE_METADATA(out);
 150     om->metadata = nawm->metadata;
 151     om->mask = nawm->mask;
 152
 153     return 0;
 154 }
 155
 156 static void
 157 note_from_openflow(const struct nx_action_note *nan, struct ofpbuf *out)
 158 {
 159     struct ofpact_note *note;
 160     unsigned int length;
 161
 162     length = ntohs(nan->len) - offsetof(struct nx_action_note, note);
 163     note = ofpact_put(out, OFPACT_NOTE,
 164                       offsetof(struct ofpact_note, data) + length);
 165     note->length = length;
 166     memcpy(note->data, nan->note, length);
 167 }
 168
 169 static enum ofperr
 170 dec_ttl_from_openflow(struct ofpbuf *out, enum ofputil_action_code compat)
 171 {
 172     uint16_t id = 0;
 173     struct ofpact_cnt_ids *ids;
 174     enum ofperr error = 0;
 175
 176     ids = ofpact_put_DEC_TTL(out);
 177     ids->ofpact.compat = compat;
 178     ids->n_controllers = 1;
 179     ofpbuf_put(out, &id, sizeof id);
 180     ids = out->l2;
 181     ofpact_update_len(out, &ids->ofpact);
 182     return error;
 183 }
 184
 185 static enum ofperr
 186 dec_ttl_cnt_ids_from_openflow(const struct nx_action_cnt_ids *nac_ids,
 187                       struct ofpbuf *out)
 188 {
 189     struct ofpact_cnt_ids *ids;
 190     size_t ids_size;
 191     int i;
 192
 193     ids = ofpact_put_DEC_TTL(out);
 194     ids->ofpact.compat = OFPUTIL_NXAST_DEC_TTL_CNT_IDS;
 195     ids->n_controllers = ntohs(nac_ids->n_controllers);
 196     ids_size = ntohs(nac_ids->len) - sizeof *nac_ids;
 197
 198     if (!is_all_zeros(nac_ids->zeros, sizeof nac_ids->zeros)) {
 199         return OFPERR_NXBRC_MUST_BE_ZERO;
 200     }
 201
 202     if (ids_size < ids->n_controllers * sizeof(ovs_be16)) {
 203         VLOG_WARN_RL(&rl, "Nicira action dec_ttl_cnt_ids only has %zu bytes "
 204                      "allocated for controller ids.  %zu bytes are required for "
 205                      "%"PRIu16" controllers.", ids_size,
 206                      ids->n_controllers * sizeof(ovs_be16), ids->n_controllers);
 207         return OFPERR_OFPBAC_BAD_LEN;
 208     }
 209
 210     for (i = 0; i < ids->n_controllers; i++) {
 211         uint16_t id = ntohs(((ovs_be16 *)(nac_ids + 1))[i]);
 212         ofpbuf_put(out, &id, sizeof id);
 213         ids = out->l2;
 214     }
 215
 216     ofpact_update_len(out, &ids->ofpact);
 217
 218     return 0;
 219 }
 220
 221 static enum ofperr
 222 sample_from_openflow(const struct nx_action_sample *nas,
 223                      struct ofpbuf *out)
 224 {
 225     struct ofpact_sample *sample;
 226
 227     sample = ofpact_put_SAMPLE(out);
 228     sample->probability = ntohs(nas->probability);
 229     sample->collector_set_id = ntohl(nas->collector_set_id);
 230     sample->obs_domain_id = ntohl(nas->obs_domain_id);
 231     sample->obs_point_id = ntohl(nas->obs_point_id);
 232
 233     if (sample->probability == 0) {
 234         return OFPERR_OFPBAC_BAD_ARGUMENT;
 235     }
 236
 237     return 0;
 238 }
 239
 240 static enum ofperr
 241 decode_nxast_action(const union ofp_action *a, enum ofputil_action_code *code)
 242 {
 243     const struct nx_action_header *nah = (const struct nx_action_header *) a;
 244     uint16_t len = ntohs(a->header.len);
 245
 246     if (len < sizeof(struct nx_action_header)) {
 247         return OFPERR_OFPBAC_BAD_LEN;
 248     } else if (a->vendor.vendor != CONSTANT_HTONL(NX_VENDOR_ID)) {
 249         return OFPERR_OFPBAC_BAD_VENDOR;
 250     }
 251
 252     switch (nah->subtype) {
 253 #define NXAST_ACTION(ENUM, STRUCT, EXTENSIBLE, NAME)    \
 254         case CONSTANT_HTONS(ENUM):                      \
 255             if (EXTENSIBLE                              \
 256                 ? len >= sizeof(struct STRUCT)          \
 257                 : len == sizeof(struct STRUCT)) {       \
 258                 *code = OFPUTIL_##ENUM;                 \
 259                 return 0;                               \
 260             } else {                                    \
 261                 return OFPERR_OFPBAC_BAD_LEN;           \
 262             }                                           \
 263             NOT_REACHED();
 264 #include "ofp-util.def"
 265
 266     case CONSTANT_HTONS(NXAST_SNAT__OBSOLETE):
 267     case CONSTANT_HTONS(NXAST_DROP_SPOOFED_ARP__OBSOLETE):
 268     default:
 269         return OFPERR_OFPBAC_BAD_TYPE;
 270     }
 271 }
 272
 273 /* Parses 'a' to determine its type.  On success stores the correct type into
 274  * '*code' and returns 0.  On failure returns an OFPERR_* error code and
 275  * '*code' is indeterminate.
 276  *
 277  * The caller must have already verified that 'a''s length is potentially
 278  * correct (that is, a->header.len is nonzero and a multiple of sizeof(union
 279  * ofp_action) and no longer than the amount of space allocated to 'a').
 280  *
 281  * This function verifies that 'a''s length is correct for the type of action
 282  * that it represents. */
 283 static enum ofperr
 284 decode_openflow10_action(const union ofp_action *a,
 285                          enum ofputil_action_code *code)
 286 {
 287     switch (a->type) {
 288     case CONSTANT_HTONS(OFPAT10_VENDOR):
 289         return decode_nxast_action(a, code);
 290
 291 #define OFPAT10_ACTION(ENUM, STRUCT, NAME)                          \
 292         case CONSTANT_HTONS(ENUM):                                  \
 293             if (a->header.len == htons(sizeof(struct STRUCT))) {    \
 294                 *code = OFPUTIL_##ENUM;                             \
 295                 return 0;                                           \
 296             } else {                                                \
 297                 return OFPERR_OFPBAC_BAD_LEN;                       \
 298             }                                                       \
 299             break;
 300 #include "ofp-util.def"
 301
 302     default:
 303         return OFPERR_OFPBAC_BAD_TYPE;
 304     }
 305 }
 306
 307 static enum ofperr
 308 ofpact_from_nxast(const union ofp_action *a, enum ofputil_action_code code,
 309                   struct ofpbuf *out)
 310 {
 311     const struct nx_action_resubmit *nar;
 312     const struct nx_action_set_tunnel *nast;
 313     const struct nx_action_set_queue *nasq;
 314     const struct nx_action_note *nan;
 315     const struct nx_action_set_tunnel64 *nast64;
 316     const struct nx_action_write_metadata *nawm;
 317     struct ofpact_tunnel *tunnel;
 318     enum ofperr error = 0;
 319
 320     switch (code) {
 321     case OFPUTIL_ACTION_INVALID:
 322 #define OFPAT10_ACTION(ENUM, STRUCT, NAME) case OFPUTIL_##ENUM:
 323 #define OFPAT11_ACTION(ENUM, STRUCT, EXTENSIBLE, NAME) case OFPUTIL_##ENUM:
 324 #include "ofp-util.def"
 325         NOT_REACHED();
 326
 327     case OFPUTIL_NXAST_RESUBMIT:
 328         resubmit_from_openflow((const struct nx_action_resubmit *) a, out);
 329         break;
 330
 331     case OFPUTIL_NXAST_SET_TUNNEL:
 332         nast = (const struct nx_action_set_tunnel *) a;
 333         tunnel = ofpact_put_SET_TUNNEL(out);
 334         tunnel->ofpact.compat = code;
 335         tunnel->tun_id = ntohl(nast->tun_id);
 336         break;
 337
 338     case OFPUTIL_NXAST_WRITE_METADATA:
 339         nawm = (const struct nx_action_write_metadata *) a;
 340         error = metadata_from_nxast(nawm, out);
 341         break;
 342
 343     case OFPUTIL_NXAST_SET_QUEUE:
 344         nasq = (const struct nx_action_set_queue *) a;
 345         ofpact_put_SET_QUEUE(out)->queue_id = ntohl(nasq->queue_id);
 346         break;
 347
 348     case OFPUTIL_NXAST_POP_QUEUE:
 349         ofpact_put_POP_QUEUE(out);
 350         break;
 351
 352     case OFPUTIL_NXAST_REG_MOVE:
 353         error = nxm_reg_move_from_openflow(
 354             (const struct nx_action_reg_move *) a, out);
 355         break;
 356
 357     case OFPUTIL_NXAST_REG_LOAD:
 358         error = nxm_reg_load_from_openflow(
 359             (const struct nx_action_reg_load *) a, out);
 360         break;
 361
 362     case OFPUTIL_NXAST_STACK_PUSH:
 363         error = nxm_stack_push_from_openflow(
 364             (const struct nx_action_stack *) a, out);
 365         break;
 366
 367     case OFPUTIL_NXAST_STACK_POP:
 368         error = nxm_stack_pop_from_openflow(
 369             (const struct nx_action_stack *) a, out);
 370         break;
 371
 372     case OFPUTIL_NXAST_NOTE:
 373         nan = (const struct nx_action_note *) a;
 374         note_from_openflow(nan, out);
 375         break;
 376
 377     case OFPUTIL_NXAST_SET_TUNNEL64:
 378         nast64 = (const struct nx_action_set_tunnel64 *) a;
 379         tunnel = ofpact_put_SET_TUNNEL(out);
 380         tunnel->ofpact.compat = code;
 381         tunnel->tun_id = ntohll(nast64->tun_id);
 382         break;
 383
 384     case OFPUTIL_NXAST_MULTIPATH:
 385         error = multipath_from_openflow((const struct nx_action_multipath *) a,
 386                                         ofpact_put_MULTIPATH(out));
 387         break;
 388
 389     case OFPUTIL_NXAST_BUNDLE:
 390     case OFPUTIL_NXAST_BUNDLE_LOAD:
 391         error = bundle_from_openflow((const struct nx_action_bundle *) a, out);
 392         break;
 393
 394     case OFPUTIL_NXAST_OUTPUT_REG:
 395         error = output_reg_from_openflow(
 396             (const struct nx_action_output_reg *) a, out);
 397         break;
 398
 399     case OFPUTIL_NXAST_RESUBMIT_TABLE:
 400         nar = (const struct nx_action_resubmit *) a;
 401         error = resubmit_table_from_openflow(nar, out);
 402         break;
 403
 404     case OFPUTIL_NXAST_LEARN:
 405         error = learn_from_openflow((const struct nx_action_learn *) a, out);
 406         break;
 407
 408     case OFPUTIL_NXAST_EXIT:
 409         ofpact_put_EXIT(out);
 410         break;
 411
 412     case OFPUTIL_NXAST_DEC_TTL:
 413         error = dec_ttl_from_openflow(out, code);
 414         break;
 415
 416     case OFPUTIL_NXAST_DEC_TTL_CNT_IDS:
 417         error = dec_ttl_cnt_ids_from_openflow(
 418                     (const struct nx_action_cnt_ids *) a, out);
 419         break;
 420
 421     case OFPUTIL_NXAST_FIN_TIMEOUT:
 422         fin_timeout_from_openflow(
 423             (const struct nx_action_fin_timeout *) a, out);
 424         break;
 425
 426     case OFPUTIL_NXAST_CONTROLLER:
 427         controller_from_openflow((const struct nx_action_controller *) a, out);
 428         break;
 429
 430     case OFPUTIL_NXAST_PUSH_MPLS: {
 431         struct nx_action_push_mpls *nxapm = (struct nx_action_push_mpls *)a;
 432         if (!eth_type_mpls(nxapm->ethertype)) {
 433             return OFPERR_OFPBAC_BAD_ARGUMENT;
 434         }
 435         ofpact_put_PUSH_MPLS(out)->ethertype = nxapm->ethertype;
 436         break;
 437     }
 438
 439     case OFPUTIL_NXAST_SET_MPLS_TTL: {
 440         struct nx_action_mpls_ttl *nxamt = (struct nx_action_mpls_ttl *)a;
 441         ofpact_put_SET_MPLS_TTL(out)->ttl = nxamt->ttl;
 442         break;
 443     }
 444
 445     case OFPUTIL_NXAST_DEC_MPLS_TTL:
 446         ofpact_put_DEC_MPLS_TTL(out);
 447         break;
 448
 449     case OFPUTIL_NXAST_POP_MPLS: {
 450         struct nx_action_pop_mpls *nxapm = (struct nx_action_pop_mpls *)a;
 451         if (eth_type_mpls(nxapm->ethertype)) {
 452             return OFPERR_OFPBAC_BAD_ARGUMENT;
 453         }
 454         ofpact_put_POP_MPLS(out)->ethertype = nxapm->ethertype;
 455         break;
 456     }
 457
 458     case OFPUTIL_NXAST_SAMPLE:
 459         error = sample_from_openflow(
 460             (const struct nx_action_sample *) a, out);
 461         break;
 462     }
 463
 464     return error;
 465 }
 466
 467 static enum ofperr
 468 ofpact_from_openflow10(const union ofp_action *a, struct ofpbuf *out)
 469 {
 470     enum ofputil_action_code code;
 471     enum ofperr error;
 472
 473     error = decode_openflow10_action(a, &code);
 474     if (error) {
 475         return error;
 476     }
 477
 478     switch (code) {
 479     case OFPUTIL_ACTION_INVALID:
 480 #define OFPAT11_ACTION(ENUM, STRUCT, EXTENSIBLE, NAME) case OFPUTIL_##ENUM:
 481 #include "ofp-util.def"
 482         NOT_REACHED();
 483
 484     case OFPUTIL_OFPAT10_OUTPUT:
 485         return output_from_openflow10(&a->output10, out);
 486
 487     case OFPUTIL_OFPAT10_SET_VLAN_VID:
 488         if (a->vlan_vid.vlan_vid & ~htons(0xfff)) {
 489             return OFPERR_OFPBAC_BAD_ARGUMENT;
 490         }
 491         ofpact_put_SET_VLAN_VID(out)->vlan_vid = ntohs(a->vlan_vid.vlan_vid);
 492         break;
 493
 494     case OFPUTIL_OFPAT10_SET_VLAN_PCP:
 495         if (a->vlan_pcp.vlan_pcp & ~7) {
 496             return OFPERR_OFPBAC_BAD_ARGUMENT;
 497         }
 498         ofpact_put_SET_VLAN_PCP(out)->vlan_pcp = a->vlan_pcp.vlan_pcp;
 499         break;
 500
 501     case OFPUTIL_OFPAT10_STRIP_VLAN:
 502         ofpact_put_STRIP_VLAN(out);
 503         break;
 504
 505     case OFPUTIL_OFPAT10_SET_DL_SRC:
 506         memcpy(ofpact_put_SET_ETH_SRC(out)->mac,
 507                ((const struct ofp_action_dl_addr *) a)->dl_addr, ETH_ADDR_LEN);
 508         break;
 509
 510     case OFPUTIL_OFPAT10_SET_DL_DST:
 511         memcpy(ofpact_put_SET_ETH_DST(out)->mac,
 512                ((const struct ofp_action_dl_addr *) a)->dl_addr, ETH_ADDR_LEN);
 513         break;
 514
 515     case OFPUTIL_OFPAT10_SET_NW_SRC:
 516         ofpact_put_SET_IPV4_SRC(out)->ipv4 = a->nw_addr.nw_addr;
 517         break;
 518
 519     case OFPUTIL_OFPAT10_SET_NW_DST:
 520         ofpact_put_SET_IPV4_DST(out)->ipv4 = a->nw_addr.nw_addr;
 521         break;
 522
 523     case OFPUTIL_OFPAT10_SET_NW_TOS:
 524         if (a->nw_tos.nw_tos & ~IP_DSCP_MASK) {
 525             return OFPERR_OFPBAC_BAD_ARGUMENT;
 526         }
 527         ofpact_put_SET_IPV4_DSCP(out)->dscp = a->nw_tos.nw_tos;
 528         break;
 529
 530     case OFPUTIL_OFPAT10_SET_TP_SRC:
 531         ofpact_put_SET_L4_SRC_PORT(out)->port = ntohs(a->tp_port.tp_port);
 532         break;
 533
 534     case OFPUTIL_OFPAT10_SET_TP_DST:
 535         ofpact_put_SET_L4_DST_PORT(out)->port = ntohs(a->tp_port.tp_port);
 536
 537         break;
 538
 539     case OFPUTIL_OFPAT10_ENQUEUE:
 540         error = enqueue_from_openflow10((const struct ofp10_action_enqueue *) a,
 541                                         out);
 542         break;
 543
 544 #define NXAST_ACTION(ENUM, STRUCT, EXTENSIBLE, NAME) case OFPUTIL_##ENUM:
 545 #include "ofp-util.def"
 546         return ofpact_from_nxast(a, code, out);
 547     }
 548
 549     return error;
 550 }
 551
 552 static inline union ofp_action *
 553 action_next(const union ofp_action *a)
 554 {
 555     return ((union ofp_action *) (void *)
 556             ((uint8_t *) a + ntohs(a->header.len)));
 557 }
 558
 559 static inline bool
 560 action_is_valid(const union ofp_action *a, size_t n_actions)
 561 {
 562     uint16_t len = ntohs(a->header.len);
 563     return (!(len % OFP_ACTION_ALIGN)
 564             && len >= sizeof *a
 565             && len / sizeof *a <= n_actions);
 566 }
 567
 568 /* This macro is careful to check for actions with bad lengths. */
 569 #define ACTION_FOR_EACH(ITER, LEFT, ACTIONS, N_ACTIONS)                 \
 570     for ((ITER) = (ACTIONS), (LEFT) = (N_ACTIONS);                      \
 571          (LEFT) > 0 && action_is_valid(ITER, LEFT);                     \
 572          ((LEFT) -= ntohs((ITER)->header.len) / sizeof(union ofp_action), \
 573           (ITER) = action_next(ITER)))
 574
 575 static void
 576 log_bad_action(const union ofp_action *actions, size_t n_actions, size_t ofs,
 577                enum ofperr error)
 578 {
 579     if (!VLOG_DROP_WARN(&rl)) {
 580         struct ds s;
 581
 582         ds_init(&s);
 583         ds_put_hex_dump(&s, actions, n_actions * sizeof *actions, 0, false);
 584         VLOG_WARN("bad action at offset %#zx (%s):\n%s",
 585                   ofs * sizeof *actions, ofperr_get_name(error), ds_cstr(&s));
 586         ds_destroy(&s);
 587     }
 588 }
 589
 590 static enum ofperr
 591 ofpacts_from_openflow(const union ofp_action *in, size_t n_in,
 592                       struct ofpbuf *out,
 593                       enum ofperr (*ofpact_from_openflow)(
 594                           const union ofp_action *a, struct ofpbuf *out))
 595 {
 596     const union ofp_action *a;
 597     size_t left;
 598
 599     ACTION_FOR_EACH (a, left, in, n_in) {
 600         enum ofperr error = ofpact_from_openflow(a, out);
 601         if (error) {
 602             log_bad_action(in, n_in, a - in, error);
 603             return error;
 604         }
 605     }
 606     if (left) {
 607         enum ofperr error = OFPERR_OFPBAC_BAD_LEN;
 608         log_bad_action(in, n_in, n_in - left, error);
 609         return error;
 610     }
 611
 612     ofpact_pad(out);
 613     return 0;
 614 }
 615
 616 static enum ofperr
 617 ofpacts_from_openflow10(const union ofp_action *in, size_t n_in,
 618                         struct ofpbuf *out)
 619 {
 620     return ofpacts_from_openflow(in, n_in, out, ofpact_from_openflow10);
 621 }
 622
 623 static enum ofperr
 624 ofpacts_pull_actions(struct ofpbuf *openflow, unsigned int actions_len,
 625                      struct ofpbuf *ofpacts,
 626                      enum ofperr (*translate)(const union ofp_action *actions,
 627                                               size_t n_actions,
 628                                               struct ofpbuf *ofpacts))
 629 {
 630     static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(1, 5);
 631     const union ofp_action *actions;
 632     enum ofperr error;
 633
 634     ofpbuf_clear(ofpacts);
 635
 636     if (actions_len % OFP_ACTION_ALIGN != 0) {
 637         VLOG_WARN_RL(&rl, "OpenFlow message actions length %u is not a "
 638                      "multiple of %d", actions_len, OFP_ACTION_ALIGN);
 639         return OFPERR_OFPBRC_BAD_LEN;
 640     }
 641
 642     actions = ofpbuf_try_pull(openflow, actions_len);
 643     if (actions == NULL) {
 644         VLOG_WARN_RL(&rl, "OpenFlow message actions length %u exceeds "
 645                      "remaining message length (%zu)",
 646                      actions_len, openflow->size);
 647         return OFPERR_OFPBRC_BAD_LEN;
 648     }
 649
 650     error = translate(actions, actions_len / OFP_ACTION_ALIGN, ofpacts);
 651     if (error) {
 652         ofpbuf_clear(ofpacts);
 653         return error;
 654     }
 655
 656     error = ofpacts_verify(ofpacts->data, ofpacts->size);
 657     if (error) {
 658         ofpbuf_clear(ofpacts);
 659     }
 660     return error;
 661 }
 662
 663 /* Attempts to convert 'actions_len' bytes of OpenFlow 1.0 actions from the
 664  * front of 'openflow' into ofpacts.  On success, replaces any existing content
 665  * in 'ofpacts' by the converted ofpacts; on failure, clears 'ofpacts'.
 666  * Returns 0 if successful, otherwise an OpenFlow error.
 667  *
 668  * The parsed actions are valid generically, but they may not be valid in a
 669  * specific context.  For example, port numbers up to OFPP_MAX are valid
 670  * generically, but specific datapaths may only support port numbers in a
 671  * smaller range.  Use ofpacts_check() to additional check whether actions are
 672  * valid in a specific context. */
 673 enum ofperr
 674 ofpacts_pull_openflow10(struct ofpbuf *openflow, unsigned int actions_len,
 675                         struct ofpbuf *ofpacts)
 676 {
 677     return ofpacts_pull_actions(openflow, actions_len, ofpacts,
 678                                 ofpacts_from_openflow10);
 679 }
 680 \f
 681 /* OpenFlow 1.1 actions. */
 682
 683 /* Parses 'a' to determine its type.  On success stores the correct type into
 684  * '*code' and returns 0.  On failure returns an OFPERR_* error code and
 685  * '*code' is indeterminate.
 686  *
 687  * The caller must have already verified that 'a''s length is potentially
 688  * correct (that is, a->header.len is nonzero and a multiple of sizeof(union
 689  * ofp_action) and no longer than the amount of space allocated to 'a').
 690  *
 691  * This function verifies that 'a''s length is correct for the type of action
 692  * that it represents. */
 693 static enum ofperr
 694 decode_openflow11_action(const union ofp_action *a,
 695                          enum ofputil_action_code *code)
 696 {
 697     uint16_t len;
 698
 699     switch (a->type) {
 700     case CONSTANT_HTONS(OFPAT11_EXPERIMENTER):
 701         return decode_nxast_action(a, code);
 702
 703 #define OFPAT11_ACTION(ENUM, STRUCT, EXTENSIBLE, NAME)  \
 704         case CONSTANT_HTONS(ENUM):                      \
 705             len = ntohs(a->header.len);                 \
 706             if (EXTENSIBLE                              \
 707                 ? len >= sizeof(struct STRUCT)          \
 708                 : len == sizeof(struct STRUCT)) {       \
 709                 *code = OFPUTIL_##ENUM;                 \
 710                 return 0;                               \
 711             } else {                                    \
 712                 return OFPERR_OFPBAC_BAD_LEN;           \
 713             }                                           \
 714             NOT_REACHED();
 715 #include "ofp-util.def"
 716
 717     default:
 718         return OFPERR_OFPBAC_BAD_TYPE;
 719     }
 720 }
 721
 722 static enum ofperr
 723 output_from_openflow11(const struct ofp11_action_output *oao,
 724                        struct ofpbuf *out)
 725 {
 726     struct ofpact_output *output;
 727     enum ofperr error;
 728
 729     output = ofpact_put_OUTPUT(out);
 730     output->max_len = ntohs(oao->max_len);
 731
 732     error = ofputil_port_from_ofp11(oao->port, &output->port);
 733     if (error) {
 734         return error;
 735     }
 736
 737     return ofputil_check_output_port(output->port, OFPP_MAX);
 738 }
 739
 740 static enum ofperr
 741 ofpact_from_openflow11(const union ofp_action *a, struct ofpbuf *out)
 742 {
 743     enum ofputil_action_code code;
 744     enum ofperr error;
 745
 746     error = decode_openflow11_action(a, &code);
 747     if (error) {
 748         return error;
 749     }
 750
 751     switch (code) {
 752     case OFPUTIL_ACTION_INVALID:
 753 #define OFPAT10_ACTION(ENUM, STRUCT, NAME) case OFPUTIL_##ENUM:
 754 #include "ofp-util.def"
 755         NOT_REACHED();
 756
 757     case OFPUTIL_OFPAT11_OUTPUT:
 758         return output_from_openflow11((const struct ofp11_action_output *) a,
 759                                       out);
 760
 761     case OFPUTIL_OFPAT11_SET_VLAN_VID:
 762         if (a->vlan_vid.vlan_vid & ~htons(0xfff)) {
 763             return OFPERR_OFPBAC_BAD_ARGUMENT;
 764         }
 765         ofpact_put_SET_VLAN_VID(out)->vlan_vid = ntohs(a->vlan_vid.vlan_vid);
 766         break;
 767
 768     case OFPUTIL_OFPAT11_SET_VLAN_PCP:
 769         if (a->vlan_pcp.vlan_pcp & ~7) {
 770             return OFPERR_OFPBAC_BAD_ARGUMENT;
 771         }
 772         ofpact_put_SET_VLAN_PCP(out)->vlan_pcp = a->vlan_pcp.vlan_pcp;
 773         break;
 774
 775     case OFPUTIL_OFPAT11_PUSH_VLAN:
 776         if (((const struct ofp11_action_push *)a)->ethertype !=
 777             htons(ETH_TYPE_VLAN_8021Q)) {
 778             /* XXX 802.1AD(QinQ) isn't supported at the moment */
 779             return OFPERR_OFPBAC_BAD_ARGUMENT;
 780         }
 781         ofpact_put_PUSH_VLAN(out);
 782         break;
 783
 784     case OFPUTIL_OFPAT11_POP_VLAN:
 785         ofpact_put_STRIP_VLAN(out);
 786         break;
 787
 788     case OFPUTIL_OFPAT11_SET_QUEUE:
 789         ofpact_put_SET_QUEUE(out)->queue_id =
 790             ntohl(((const struct ofp11_action_set_queue *)a)->queue_id);
 791         break;
 792
 793     case OFPUTIL_OFPAT11_SET_DL_SRC:
 794         memcpy(ofpact_put_SET_ETH_SRC(out)->mac,
 795                ((const struct ofp_action_dl_addr *) a)->dl_addr, ETH_ADDR_LEN);
 796         break;
 797
 798     case OFPUTIL_OFPAT11_SET_DL_DST:
 799         memcpy(ofpact_put_SET_ETH_DST(out)->mac,
 800                ((const struct ofp_action_dl_addr *) a)->dl_addr, ETH_ADDR_LEN);
 801         break;
 802
 803     case OFPUTIL_OFPAT11_DEC_NW_TTL:
 804         dec_ttl_from_openflow(out, code);
 805         break;
 806
 807     case OFPUTIL_OFPAT11_SET_NW_SRC:
 808         ofpact_put_SET_IPV4_SRC(out)->ipv4 = a->nw_addr.nw_addr;
 809         break;
 810
 811     case OFPUTIL_OFPAT11_SET_NW_DST:
 812         ofpact_put_SET_IPV4_DST(out)->ipv4 = a->nw_addr.nw_addr;
 813         break;
 814
 815     case OFPUTIL_OFPAT11_SET_NW_TOS:
 816         if (a->nw_tos.nw_tos & ~IP_DSCP_MASK) {
 817             return OFPERR_OFPBAC_BAD_ARGUMENT;
 818         }
 819         ofpact_put_SET_IPV4_DSCP(out)->dscp = a->nw_tos.nw_tos;
 820         break;
 821
 822     case OFPUTIL_OFPAT11_SET_TP_SRC:
 823         ofpact_put_SET_L4_SRC_PORT(out)->port = ntohs(a->tp_port.tp_port);
 824         break;
 825
 826     case OFPUTIL_OFPAT11_SET_TP_DST:
 827         ofpact_put_SET_L4_DST_PORT(out)->port = ntohs(a->tp_port.tp_port);
 828         break;
 829
 830     case OFPUTIL_OFPAT12_SET_FIELD:
 831         return nxm_reg_load_from_openflow12_set_field(
 832             (const struct ofp12_action_set_field *)a, out);
 833
 834     case OFPUTIL_OFPAT11_SET_MPLS_TTL: {
 835         struct ofp11_action_mpls_ttl *oamt = (struct ofp11_action_mpls_ttl *)a;
 836         ofpact_put_SET_MPLS_TTL(out)->ttl = oamt->mpls_ttl;
 837         break;
 838     }
 839
 840     case OFPUTIL_OFPAT11_DEC_MPLS_TTL:
 841         ofpact_put_DEC_MPLS_TTL(out);
 842         break;
 843
 844     case OFPUTIL_OFPAT11_PUSH_MPLS: {
 845         struct ofp11_action_push *oap = (struct ofp11_action_push *)a;
 846         if (!eth_type_mpls(oap->ethertype)) {
 847             return OFPERR_OFPBAC_BAD_ARGUMENT;
 848         }
 849         ofpact_put_PUSH_MPLS(out)->ethertype = oap->ethertype;
 850         break;
 851     }
 852
 853     case OFPUTIL_OFPAT11_POP_MPLS: {
 854         struct ofp11_action_pop_mpls *oapm = (struct ofp11_action_pop_mpls *)a;
 855         if (eth_type_mpls(oapm->ethertype)) {
 856             return OFPERR_OFPBAC_BAD_ARGUMENT;
 857         }
 858         ofpact_put_POP_MPLS(out)->ethertype = oapm->ethertype;
 859         break;
 860     }
 861
 862 #define NXAST_ACTION(ENUM, STRUCT, EXTENSIBLE, NAME) case OFPUTIL_##ENUM:
 863 #include "ofp-util.def"
 864         return ofpact_from_nxast(a, code, out);
 865     }
 866
 867     return error;
 868 }
 869
 870 static enum ofperr
 871 ofpacts_from_openflow11(const union ofp_action *in, size_t n_in,
 872                         struct ofpbuf *out)
 873 {
 874     return ofpacts_from_openflow(in, n_in, out, ofpact_from_openflow11);
 875 }
 876 \f
 877 /* OpenFlow 1.1 instructions. */
 878
 879 #define DEFINE_INST(ENUM, STRUCT, EXTENSIBLE, NAME)             \
 880     static inline const struct STRUCT *                         \
 881     instruction_get_##ENUM(const struct ofp11_instruction *inst)\
 882     {                                                           \
 883         ovs_assert(inst->type == htons(ENUM));                  \
 884         return (struct STRUCT *)inst;                           \
 885     }                                                           \
 886                                                                 \
 887     static inline void                                          \
 888     instruction_init_##ENUM(struct STRUCT *s)                   \
 889     {                                                           \
 890         memset(s, 0, sizeof *s);                                \
 891         s->type = htons(ENUM);                                  \
 892         s->len = htons(sizeof *s);                              \
 893     }                                                           \
 894                                                                 \
 895     static inline struct STRUCT *                               \
 896     instruction_put_##ENUM(struct ofpbuf *buf)                  \
 897     {                                                           \
 898         struct STRUCT *s = ofpbuf_put_uninit(buf, sizeof *s);   \
 899         instruction_init_##ENUM(s);                             \
 900         return s;                                               \
 901     }
 902 OVS_INSTRUCTIONS
 903 #undef DEFINE_INST
 904
 905 struct instruction_type_info {
 906     enum ovs_instruction_type type;
 907     const char *name;
 908 };
 909
 910 static const struct instruction_type_info inst_info[] = {
 911 #define DEFINE_INST(ENUM, STRUCT, EXTENSIBLE, NAME)    {OVSINST_##ENUM, NAME},
 912 OVS_INSTRUCTIONS
 913 #undef DEFINE_INST
 914 };
 915
 916 const char *
 917 ovs_instruction_name_from_type(enum ovs_instruction_type type)
 918 {
 919     return inst_info[type].name;
 920 }
 921
 922 int
 923 ovs_instruction_type_from_name(const char *name)
 924 {
 925     const struct instruction_type_info *p;
 926     for (p = inst_info; p < &inst_info[ARRAY_SIZE(inst_info)]; p++) {
 927         if (!strcasecmp(name, p->name)) {
 928             return p->type;
 929         }
 930     }
 931     return -1;
 932 }
 933
 934 enum ovs_instruction_type
 935 ovs_instruction_type_from_ofpact_type(enum ofpact_type type)
 936 {
 937     switch (type) {
 938     case OFPACT_METER:
 939         return OVSINST_OFPIT13_METER;
 940     case OFPACT_CLEAR_ACTIONS:
 941         return OVSINST_OFPIT11_CLEAR_ACTIONS;
 942     case OFPACT_WRITE_METADATA:
 943         return OVSINST_OFPIT11_WRITE_METADATA;
 944     case OFPACT_GOTO_TABLE:
 945         return OVSINST_OFPIT11_GOTO_TABLE;
 946     case OFPACT_OUTPUT:
 947     case OFPACT_CONTROLLER:
 948     case OFPACT_ENQUEUE:
 949     case OFPACT_OUTPUT_REG:
 950     case OFPACT_BUNDLE:
 951     case OFPACT_SET_VLAN_VID:
 952     case OFPACT_SET_VLAN_PCP:
 953     case OFPACT_STRIP_VLAN:
 954     case OFPACT_PUSH_VLAN:
 955     case OFPACT_SET_ETH_SRC:
 956     case OFPACT_SET_ETH_DST:
 957     case OFPACT_SET_IPV4_SRC:
 958     case OFPACT_SET_IPV4_DST:
 959     case OFPACT_SET_IPV4_DSCP:
 960     case OFPACT_SET_L4_SRC_PORT:
 961     case OFPACT_SET_L4_DST_PORT:
 962     case OFPACT_REG_MOVE:
 963     case OFPACT_REG_LOAD:
 964     case OFPACT_STACK_PUSH:
 965     case OFPACT_STACK_POP:
 966     case OFPACT_DEC_TTL:
 967     case OFPACT_SET_MPLS_TTL:
 968     case OFPACT_DEC_MPLS_TTL:
 969     case OFPACT_PUSH_MPLS:
 970     case OFPACT_POP_MPLS:
 971     case OFPACT_SET_TUNNEL:
 972     case OFPACT_SET_QUEUE:
 973     case OFPACT_POP_QUEUE:
 974     case OFPACT_FIN_TIMEOUT:
 975     case OFPACT_RESUBMIT:
 976     case OFPACT_LEARN:
 977     case OFPACT_MULTIPATH:
 978     case OFPACT_NOTE:
 979     case OFPACT_EXIT:
 980     case OFPACT_SAMPLE:
 981     default:
 982         return OVSINST_OFPIT11_APPLY_ACTIONS;
 983     }
 984 }
 985
 986 static inline struct ofp11_instruction *
 987 instruction_next(const struct ofp11_instruction *inst)
 988 {
 989     return ((struct ofp11_instruction *) (void *)
 990             ((uint8_t *) inst + ntohs(inst->len)));
 991 }
 992
 993 static inline bool
 994 instruction_is_valid(const struct ofp11_instruction *inst,
 995                      size_t n_instructions)
 996 {
 997     uint16_t len = ntohs(inst->len);
 998     return (!(len % OFP11_INSTRUCTION_ALIGN)
 999             && len >= sizeof *inst
1000             && len / sizeof *inst <= n_instructions);
1001 }
1002
1003 /* This macro is careful to check for instructions with bad lengths. */
1004 #define INSTRUCTION_FOR_EACH(ITER, LEFT, INSTRUCTIONS, N_INSTRUCTIONS)  \
1005     for ((ITER) = (INSTRUCTIONS), (LEFT) = (N_INSTRUCTIONS);            \
1006          (LEFT) > 0 && instruction_is_valid(ITER, LEFT);                \
1007          ((LEFT) -= (ntohs((ITER)->len)                                 \
1008                      / sizeof(struct ofp11_instruction)),               \
1009           (ITER) = instruction_next(ITER)))
1010
1011 static enum ofperr
1012 decode_openflow11_instruction(const struct ofp11_instruction *inst,
1013                               enum ovs_instruction_type *type)
1014 {
1015     uint16_t len = ntohs(inst->len);
1016
1017     switch (inst->type) {
1018     case CONSTANT_HTONS(OFPIT11_EXPERIMENTER):
1019         return OFPERR_OFPBIC_BAD_EXPERIMENTER;
1020
1021 #define DEFINE_INST(ENUM, STRUCT, EXTENSIBLE, NAME)     \
1022         case CONSTANT_HTONS(ENUM):                      \
1023             if (EXTENSIBLE                              \
1024                 ? len >= sizeof(struct STRUCT)          \
1025                 : len == sizeof(struct STRUCT)) {       \
1026                 *type = OVSINST_##ENUM;                 \
1027                 return 0;                               \
1028             } else {                                    \
1029                 return OFPERR_OFPBIC_BAD_LEN;           \
1030             }
1031 OVS_INSTRUCTIONS
1032 #undef DEFINE_INST
1033
1034     default:
1035         return OFPERR_OFPBIC_UNKNOWN_INST;
1036     }
1037 }
1038
1039 static enum ofperr
1040 decode_openflow11_instructions(const struct ofp11_instruction insts[],
1041                                size_t n_insts,
1042                                const struct ofp11_instruction *out[])
1043 {
1044     const struct ofp11_instruction *inst;
1045     size_t left;
1046
1047     memset(out, 0, N_OVS_INSTRUCTIONS * sizeof *out);
1048     INSTRUCTION_FOR_EACH (inst, left, insts, n_insts) {
1049         enum ovs_instruction_type type;
1050         enum ofperr error;
1051
1052         error = decode_openflow11_instruction(inst, &type);
1053         if (error) {
1054             return error;
1055         }
1056
1057         if (out[type]) {
1058             return OFPERR_ONFBIC_DUP_INSTRUCTION;
1059         }
1060         out[type] = inst;
1061     }
1062
1063     if (left) {
1064         VLOG_WARN_RL(&rl, "bad instruction format at offset %zu",
1065                      (n_insts - left) * sizeof *inst);
1066         return OFPERR_OFPBIC_BAD_LEN;
1067     }
1068     return 0;
1069 }
1070
1071 static void
1072 get_actions_from_instruction(const struct ofp11_instruction *inst,
1073                          const union ofp_action **actions,
1074                          size_t *n_actions)
1075 {
1076     *actions = (const union ofp_action *) (inst + 1);
1077     *n_actions = (ntohs(inst->len) - sizeof *inst) / OFP11_INSTRUCTION_ALIGN;
1078 }
1079
1080 /* Attempts to convert 'actions_len' bytes of OpenFlow 1.1 actions from the
1081  * front of 'openflow' into ofpacts.  On success, replaces any existing content
1082  * in 'ofpacts' by the converted ofpacts; on failure, clears 'ofpacts'.
1083  * Returns 0 if successful, otherwise an OpenFlow error.
1084  *
1085  * In most places in OpenFlow 1.1 and 1.2, actions appear encapsulated in
1086  * instructions, so you should call ofpacts_pull_openflow11_instructions()
1087  * instead of this function.
1088  *
1089  * The parsed actions are valid generically, but they may not be valid in a
1090  * specific context.  For example, port numbers up to OFPP_MAX are valid
1091  * generically, but specific datapaths may only support port numbers in a
1092  * smaller range.  Use ofpacts_check() to additional check whether actions are
1093  * valid in a specific context. */
1094 enum ofperr
1095 ofpacts_pull_openflow11_actions(struct ofpbuf *openflow,
1096                                 unsigned int actions_len,
1097                                 struct ofpbuf *ofpacts)
1098 {
1099     return ofpacts_pull_actions(openflow, actions_len, ofpacts,
1100                                 ofpacts_from_openflow11);
1101 }
1102
1103 enum ofperr
1104 ofpacts_pull_openflow11_instructions(struct ofpbuf *openflow,
1105                                      unsigned int instructions_len,
1106                                      struct ofpbuf *ofpacts)
1107 {
1108     static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(1, 5);
1109     const struct ofp11_instruction *instructions;
1110     const struct ofp11_instruction *insts[N_OVS_INSTRUCTIONS];
1111     enum ofperr error;
1112
1113     ofpbuf_clear(ofpacts);
1114
1115     if (instructions_len % OFP11_INSTRUCTION_ALIGN != 0) {
1116         VLOG_WARN_RL(&rl, "OpenFlow message instructions length %u is not a "
1117                      "multiple of %d",
1118                      instructions_len, OFP11_INSTRUCTION_ALIGN);
1119         error = OFPERR_OFPBIC_BAD_LEN;
1120         goto exit;
1121     }
1122
1123     instructions = ofpbuf_try_pull(openflow, instructions_len);
1124     if (instructions == NULL) {
1125         VLOG_WARN_RL(&rl, "OpenFlow message instructions length %u exceeds "
1126                      "remaining message length (%zu)",
1127                      instructions_len, openflow->size);
1128         error = OFPERR_OFPBIC_BAD_LEN;
1129         goto exit;
1130     }
1131
1132     error = decode_openflow11_instructions(
1133         instructions, instructions_len / OFP11_INSTRUCTION_ALIGN,
1134         insts);
1135     if (error) {
1136         goto exit;
1137     }
1138
1139     if (insts[OVSINST_OFPIT13_METER]) {
1140         const struct ofp13_instruction_meter *oim;
1141         struct ofpact_meter *om;
1142
1143         oim = (const struct ofp13_instruction_meter *)
1144             insts[OVSINST_OFPIT13_METER];
1145
1146         om = ofpact_put_METER(ofpacts);
1147         om->meter_id = ntohl(oim->meter_id);
1148     }
1149     if (insts[OVSINST_OFPIT11_APPLY_ACTIONS]) {
1150         const union ofp_action *actions;
1151         size_t n_actions;
1152
1153         get_actions_from_instruction(insts[OVSINST_OFPIT11_APPLY_ACTIONS],
1154                                      &actions, &n_actions);
1155         error = ofpacts_from_openflow11(actions, n_actions, ofpacts);
1156         if (error) {
1157             goto exit;
1158         }
1159     }
1160     if (insts[OVSINST_OFPIT11_CLEAR_ACTIONS]) {
1161         instruction_get_OFPIT11_CLEAR_ACTIONS(
1162             insts[OVSINST_OFPIT11_CLEAR_ACTIONS]);
1163         ofpact_put_CLEAR_ACTIONS(ofpacts);
1164     }
1165     /* XXX Write-Actions */
1166     if (insts[OVSINST_OFPIT11_WRITE_METADATA]) {
1167         const struct ofp11_instruction_write_metadata *oiwm;
1168         struct ofpact_metadata *om;
1169
1170         oiwm = (const struct ofp11_instruction_write_metadata *)
1171             insts[OVSINST_OFPIT11_WRITE_METADATA];
1172
1173         om = ofpact_put_WRITE_METADATA(ofpacts);
1174         om->metadata = oiwm->metadata;
1175         om->mask = oiwm->metadata_mask;
1176     }
1177     if (insts[OVSINST_OFPIT11_GOTO_TABLE]) {
1178         const struct ofp11_instruction_goto_table *oigt;
1179         struct ofpact_goto_table *ogt;
1180
1181         oigt = instruction_get_OFPIT11_GOTO_TABLE(
1182             insts[OVSINST_OFPIT11_GOTO_TABLE]);
1183         ogt = ofpact_put_GOTO_TABLE(ofpacts);
1184         ogt->table_id = oigt->table_id;
1185     }
1186
1187     if (insts[OVSINST_OFPIT11_WRITE_ACTIONS]) {
1188         error = OFPERR_OFPBIC_UNSUP_INST;
1189         goto exit;
1190     }
1191
1192     error = ofpacts_verify(ofpacts->data, ofpacts->size);
1193 exit:
1194     if (error) {
1195         ofpbuf_clear(ofpacts);
1196     }
1197     return error;
1198 }
1199 \f
1200 /* May modify flow->dl_type, caller must restore it. */
1201 static enum ofperr
1202 ofpact_check__(const struct ofpact *a, struct flow *flow, ofp_port_t max_ports,
1203                uint8_t table_id)
1204 {
1205     const struct ofpact_enqueue *enqueue;
1206
1207     switch (a->type) {
1208     case OFPACT_OUTPUT:
1209         return ofputil_check_output_port(ofpact_get_OUTPUT(a)->port,
1210                                          max_ports);
1211
1212     case OFPACT_CONTROLLER:
1213         return 0;
1214
1215     case OFPACT_ENQUEUE:
1216         enqueue = ofpact_get_ENQUEUE(a);
1217         if (ofp_to_u16(enqueue->port) >= ofp_to_u16(max_ports)
1218             && enqueue->port != OFPP_IN_PORT
1219             && enqueue->port != OFPP_LOCAL) {
1220             return OFPERR_OFPBAC_BAD_OUT_PORT;
1221         }
1222         return 0;
1223
1224     case OFPACT_OUTPUT_REG:
1225         return mf_check_src(&ofpact_get_OUTPUT_REG(a)->src, flow);
1226
1227     case OFPACT_BUNDLE:
1228         return bundle_check(ofpact_get_BUNDLE(a), max_ports, flow);
1229
1230     case OFPACT_SET_VLAN_VID:
1231     case OFPACT_SET_VLAN_PCP:
1232     case OFPACT_STRIP_VLAN:
1233     case OFPACT_PUSH_VLAN:
1234     case OFPACT_SET_ETH_SRC:
1235     case OFPACT_SET_ETH_DST:
1236     case OFPACT_SET_IPV4_SRC:
1237     case OFPACT_SET_IPV4_DST:
1238     case OFPACT_SET_IPV4_DSCP:
1239     case OFPACT_SET_L4_SRC_PORT:
1240     case OFPACT_SET_L4_DST_PORT:
1241         return 0;
1242
1243     case OFPACT_REG_MOVE:
1244         return nxm_reg_move_check(ofpact_get_REG_MOVE(a), flow);
1245
1246     case OFPACT_REG_LOAD:
1247         return nxm_reg_load_check(ofpact_get_REG_LOAD(a), flow);
1248
1249     case OFPACT_STACK_PUSH:
1250         return nxm_stack_push_check(ofpact_get_STACK_PUSH(a), flow);
1251
1252     case OFPACT_STACK_POP:
1253         return nxm_stack_pop_check(ofpact_get_STACK_POP(a), flow);
1254
1255     case OFPACT_DEC_TTL:
1256     case OFPACT_SET_MPLS_TTL:
1257     case OFPACT_DEC_MPLS_TTL:
1258     case OFPACT_SET_TUNNEL:
1259     case OFPACT_SET_QUEUE:
1260     case OFPACT_POP_QUEUE:
1261     case OFPACT_FIN_TIMEOUT:
1262     case OFPACT_RESUBMIT:
1263         return 0;
1264
1265     case OFPACT_LEARN:
1266         return learn_check(ofpact_get_LEARN(a), flow);
1267
1268     case OFPACT_MULTIPATH:
1269         return multipath_check(ofpact_get_MULTIPATH(a), flow);
1270
1271     case OFPACT_NOTE:
1272     case OFPACT_EXIT:
1273         return 0;
1274
1275     case OFPACT_PUSH_MPLS:
1276         flow->dl_type = ofpact_get_PUSH_MPLS(a)->ethertype;
1277         return 0;
1278
1279     case OFPACT_POP_MPLS:
1280         flow->dl_type = ofpact_get_POP_MPLS(a)->ethertype;
1281         return 0;
1282
1283     case OFPACT_SAMPLE:
1284         return 0;
1285
1286     case OFPACT_CLEAR_ACTIONS:
1287     case OFPACT_WRITE_METADATA:
1288         return 0;
1289
1290     case OFPACT_METER: {
1291         uint32_t mid = ofpact_get_METER(a)->meter_id;
1292         if (mid == 0 || mid > OFPM13_MAX) {
1293             return OFPERR_OFPMMFC_INVALID_METER;
1294         }
1295         return 0;
1296     }
1297
1298     case OFPACT_GOTO_TABLE:
1299         if (ofpact_get_GOTO_TABLE(a)->table_id <= table_id) {
1300             return OFPERR_OFPBRC_BAD_TABLE_ID;
1301         }
1302         return 0;
1303
1304     default:
1305         NOT_REACHED();
1306     }
1307 }
1308
1309 /* Checks that the 'ofpacts_len' bytes of actions in 'ofpacts' are
1310  * appropriate for a packet with the prerequisites satisfied by 'flow' in a
1311  * switch with no more than 'max_ports' ports.
1312  *
1313  * May temporarily modify 'flow', but restores the changes before returning. */
1314 enum ofperr
1315 ofpacts_check(const struct ofpact ofpacts[], size_t ofpacts_len,
1316               struct flow *flow, ofp_port_t max_ports, uint8_t table_id)
1317 {
1318     const struct ofpact *a;
1319     ovs_be16 dl_type = flow->dl_type;
1320     enum ofperr error = 0;
1321
1322     OFPACT_FOR_EACH (a, ofpacts, ofpacts_len) {
1323         error = ofpact_check__(a, flow, max_ports, table_id);
1324         if (error) {
1325             break;
1326         }
1327     }
1328     flow->dl_type = dl_type; /* Restore. */
1329     return error;
1330 }
1331
1332 /* Verifies that the 'ofpacts_len' bytes of actions in 'ofpacts' are
1333  * in the appropriate order as defined by the OpenFlow spec. */
1334 enum ofperr
1335 ofpacts_verify(const struct ofpact ofpacts[], size_t ofpacts_len)
1336 {
1337     const struct ofpact *a;
1338     enum ovs_instruction_type inst;
1339
1340     inst = OVSINST_OFPIT11_APPLY_ACTIONS;
1341     OFPACT_FOR_EACH (a, ofpacts, ofpacts_len) {
1342         enum ovs_instruction_type next;
1343
1344         next = ovs_instruction_type_from_ofpact_type(a->type);
1345         if (inst != OVSINST_OFPIT11_APPLY_ACTIONS && next <= inst) {
1346             const char *name = ovs_instruction_name_from_type(inst);
1347             const char *next_name = ovs_instruction_name_from_type(next);
1348
1349             if (next == inst) {
1350                 VLOG_WARN("duplicate %s instruction not allowed, for OpenFlow "
1351                           "1.1+ compatibility", name);
1352             } else {
1353                 VLOG_WARN("invalid instruction ordering: %s must appear "
1354                           "before %s, for OpenFlow 1.1+ compatibility",
1355                           next_name, name);
1356             }
1357             return OFPERR_OFPBAC_UNSUPPORTED_ORDER;
1358         }
1359
1360         inst = next;
1361     }
1362
1363     return 0;
1364 }
1365 \f
1366 /* Converting ofpacts to Nicira OpenFlow extensions. */
1367
1368 static void
1369 ofpact_output_reg_to_nxast(const struct ofpact_output_reg *output_reg,
1370                                 struct ofpbuf *out)
1371 {
1372     struct nx_action_output_reg *naor = ofputil_put_NXAST_OUTPUT_REG(out);
1373
1374     naor->ofs_nbits = nxm_encode_ofs_nbits(output_reg->src.ofs,
1375                                            output_reg->src.n_bits);
1376     naor->src = htonl(output_reg->src.field->nxm_header);
1377     naor->max_len = htons(output_reg->max_len);
1378 }
1379
1380 static void
1381 ofpact_resubmit_to_nxast(const struct ofpact_resubmit *resubmit,
1382                          struct ofpbuf *out)
1383 {
1384     struct nx_action_resubmit *nar;
1385
1386     if (resubmit->table_id == 0xff
1387         && resubmit->ofpact.compat != OFPUTIL_NXAST_RESUBMIT_TABLE) {
1388         nar = ofputil_put_NXAST_RESUBMIT(out);
1389     } else {
1390         nar = ofputil_put_NXAST_RESUBMIT_TABLE(out);
1391         nar->table = resubmit->table_id;
1392     }
1393     nar->in_port = htons(ofp_to_u16(resubmit->in_port));
1394 }
1395
1396 static void
1397 ofpact_set_tunnel_to_nxast(const struct ofpact_tunnel *tunnel,
1398                            struct ofpbuf *out)
1399 {
1400     uint64_t tun_id = tunnel->tun_id;
1401
1402     if (tun_id <= UINT32_MAX
1403         && tunnel->ofpact.compat != OFPUTIL_NXAST_SET_TUNNEL64) {
1404         ofputil_put_NXAST_SET_TUNNEL(out)->tun_id = htonl(tun_id);
1405     } else {
1406         ofputil_put_NXAST_SET_TUNNEL64(out)->tun_id = htonll(tun_id);
1407     }
1408 }
1409
1410 static void
1411 ofpact_write_metadata_to_nxast(const struct ofpact_metadata *om,
1412                                struct ofpbuf *out)
1413 {
1414     struct nx_action_write_metadata *nawm;
1415
1416     nawm = ofputil_put_NXAST_WRITE_METADATA(out);
1417     nawm->metadata = om->metadata;
1418     nawm->mask = om->mask;
1419 }
1420
1421 static void
1422 ofpact_note_to_nxast(const struct ofpact_note *note, struct ofpbuf *out)
1423 {
1424     size_t start_ofs = out->size;
1425     struct nx_action_note *nan;
1426     unsigned int remainder;
1427     unsigned int len;
1428
1429     nan = ofputil_put_NXAST_NOTE(out);
1430     out->size -= sizeof nan->note;
1431
1432     ofpbuf_put(out, note->data, note->length);
1433
1434     len = out->size - start_ofs;
1435     remainder = len % OFP_ACTION_ALIGN;
1436     if (remainder) {
1437         ofpbuf_put_zeros(out, OFP_ACTION_ALIGN - remainder);
1438     }
1439     nan = (struct nx_action_note *)((char *)out->data + start_ofs);
1440     nan->len = htons(out->size - start_ofs);
1441 }
1442
1443 static void
1444 ofpact_controller_to_nxast(const struct ofpact_controller *oc,
1445                            struct ofpbuf *out)
1446 {
1447     struct nx_action_controller *nac;
1448
1449     nac = ofputil_put_NXAST_CONTROLLER(out);
1450     nac->max_len = htons(oc->max_len);
1451     nac->controller_id = htons(oc->controller_id);
1452     nac->reason = oc->reason;
1453 }
1454
1455 static void
1456 ofpact_dec_ttl_to_nxast(const struct ofpact_cnt_ids *oc_ids,
1457                         struct ofpbuf *out)
1458 {
1459     if (oc_ids->ofpact.compat == OFPUTIL_NXAST_DEC_TTL) {
1460         ofputil_put_NXAST_DEC_TTL(out);
1461     } else {
1462         struct nx_action_cnt_ids *nac_ids =
1463             ofputil_put_NXAST_DEC_TTL_CNT_IDS(out);
1464         int ids_len = ROUND_UP(2 * oc_ids->n_controllers, OFP_ACTION_ALIGN);
1465         ovs_be16 *ids;
1466         size_t i;
1467
1468         nac_ids->len = htons(ntohs(nac_ids->len) + ids_len);
1469         nac_ids->n_controllers = htons(oc_ids->n_controllers);
1470
1471         ids = ofpbuf_put_zeros(out, ids_len);
1472         for (i = 0; i < oc_ids->n_controllers; i++) {
1473             ids[i] = htons(oc_ids->cnt_ids[i]);
1474         }
1475     }
1476 }
1477
1478 static void
1479 ofpact_fin_timeout_to_nxast(const struct ofpact_fin_timeout *fin_timeout,
1480                             struct ofpbuf *out)
1481 {
1482     struct nx_action_fin_timeout *naft = ofputil_put_NXAST_FIN_TIMEOUT(out);
1483     naft->fin_idle_timeout = htons(fin_timeout->fin_idle_timeout);
1484     naft->fin_hard_timeout = htons(fin_timeout->fin_hard_timeout);
1485 }
1486
1487 static void
1488 ofpact_sample_to_nxast(const struct ofpact_sample *os,
1489                        struct ofpbuf *out)
1490 {
1491     struct nx_action_sample *nas;
1492
1493     nas = ofputil_put_NXAST_SAMPLE(out);
1494     nas->probability = htons(os->probability);
1495     nas->collector_set_id = htonl(os->collector_set_id);
1496     nas->obs_domain_id = htonl(os->obs_domain_id);
1497     nas->obs_point_id = htonl(os->obs_point_id);
1498 }
1499
1500 static void
1501 ofpact_to_nxast(const struct ofpact *a, struct ofpbuf *out)
1502 {
1503     switch (a->type) {
1504     case OFPACT_CONTROLLER:
1505         ofpact_controller_to_nxast(ofpact_get_CONTROLLER(a), out);
1506         break;
1507
1508     case OFPACT_OUTPUT_REG:
1509         ofpact_output_reg_to_nxast(ofpact_get_OUTPUT_REG(a), out);
1510         break;
1511
1512     case OFPACT_BUNDLE:
1513         bundle_to_nxast(ofpact_get_BUNDLE(a), out);
1514         break;
1515
1516     case OFPACT_REG_MOVE:
1517         nxm_reg_move_to_nxast(ofpact_get_REG_MOVE(a), out);
1518         break;
1519
1520     case OFPACT_REG_LOAD:
1521         nxm_reg_load_to_nxast(ofpact_get_REG_LOAD(a), out);
1522         break;
1523
1524     case OFPACT_STACK_PUSH:
1525         nxm_stack_push_to_nxast(ofpact_get_STACK_PUSH(a), out);
1526         break;
1527
1528     case OFPACT_STACK_POP:
1529         nxm_stack_pop_to_nxast(ofpact_get_STACK_POP(a), out);
1530         break;
1531
1532     case OFPACT_DEC_TTL:
1533         ofpact_dec_ttl_to_nxast(ofpact_get_DEC_TTL(a), out);
1534         break;
1535
1536     case OFPACT_SET_MPLS_TTL:
1537         ofputil_put_NXAST_SET_MPLS_TTL(out)->ttl
1538             = ofpact_get_SET_MPLS_TTL(a)->ttl;
1539         break;
1540
1541     case OFPACT_DEC_MPLS_TTL:
1542         ofputil_put_NXAST_DEC_MPLS_TTL(out);
1543         break;
1544
1545     case OFPACT_SET_TUNNEL:
1546         ofpact_set_tunnel_to_nxast(ofpact_get_SET_TUNNEL(a), out);
1547         break;
1548
1549     case OFPACT_WRITE_METADATA:
1550         ofpact_write_metadata_to_nxast(ofpact_get_WRITE_METADATA(a), out);
1551         break;
1552
1553     case OFPACT_SET_QUEUE:
1554         ofputil_put_NXAST_SET_QUEUE(out)->queue_id
1555             = htonl(ofpact_get_SET_QUEUE(a)->queue_id);
1556         break;
1557
1558     case OFPACT_POP_QUEUE:
1559         ofputil_put_NXAST_POP_QUEUE(out);
1560         break;
1561
1562     case OFPACT_FIN_TIMEOUT:
1563         ofpact_fin_timeout_to_nxast(ofpact_get_FIN_TIMEOUT(a), out);
1564         break;
1565
1566     case OFPACT_RESUBMIT:
1567         ofpact_resubmit_to_nxast(ofpact_get_RESUBMIT(a), out);
1568         break;
1569
1570     case OFPACT_LEARN:
1571         learn_to_nxast(ofpact_get_LEARN(a), out);
1572         break;
1573
1574     case OFPACT_MULTIPATH:
1575         multipath_to_nxast(ofpact_get_MULTIPATH(a), out);
1576         break;
1577
1578     case OFPACT_NOTE:
1579         ofpact_note_to_nxast(ofpact_get_NOTE(a), out);
1580         break;
1581
1582     case OFPACT_EXIT:
1583         ofputil_put_NXAST_EXIT(out);
1584         break;
1585
1586     case OFPACT_PUSH_MPLS:
1587         ofputil_put_NXAST_PUSH_MPLS(out)->ethertype =
1588             ofpact_get_PUSH_MPLS(a)->ethertype;
1589         break;
1590
1591     case OFPACT_POP_MPLS:
1592         ofputil_put_NXAST_POP_MPLS(out)->ethertype =
1593             ofpact_get_POP_MPLS(a)->ethertype;
1594         break;
1595
1596     case OFPACT_SAMPLE:
1597         ofpact_sample_to_nxast(ofpact_get_SAMPLE(a), out);
1598         break;
1599
1600     case OFPACT_OUTPUT:
1601     case OFPACT_ENQUEUE:
1602     case OFPACT_SET_VLAN_VID:
1603     case OFPACT_SET_VLAN_PCP:
1604     case OFPACT_STRIP_VLAN:
1605     case OFPACT_PUSH_VLAN:
1606     case OFPACT_SET_ETH_SRC:
1607     case OFPACT_SET_ETH_DST:
1608     case OFPACT_SET_IPV4_SRC:
1609     case OFPACT_SET_IPV4_DST:
1610     case OFPACT_SET_IPV4_DSCP:
1611     case OFPACT_SET_L4_SRC_PORT:
1612     case OFPACT_SET_L4_DST_PORT:
1613     case OFPACT_CLEAR_ACTIONS:
1614     case OFPACT_GOTO_TABLE:
1615     case OFPACT_METER:
1616         NOT_REACHED();
1617     }
1618 }
1619 \f
1620 /* Converting ofpacts to OpenFlow 1.0. */
1621
1622 static void
1623 ofpact_output_to_openflow10(const struct ofpact_output *output,
1624                             struct ofpbuf *out)
1625 {
1626     struct ofp10_action_output *oao;
1627
1628     oao = ofputil_put_OFPAT10_OUTPUT(out);
1629     oao->port = htons(ofp_to_u16(output->port));
1630     oao->max_len = htons(output->max_len);
1631 }
1632
1633 static void
1634 ofpact_enqueue_to_openflow10(const struct ofpact_enqueue *enqueue,
1635                              struct ofpbuf *out)
1636 {
1637     struct ofp10_action_enqueue *oae;
1638
1639     oae = ofputil_put_OFPAT10_ENQUEUE(out);
1640     oae->port = htons(ofp_to_u16(enqueue->port));
1641     oae->queue_id = htonl(enqueue->queue);
1642 }
1643
1644 static void
1645 ofpact_to_openflow10(const struct ofpact *a, struct ofpbuf *out)
1646 {
1647     switch (a->type) {
1648     case OFPACT_OUTPUT:
1649         ofpact_output_to_openflow10(ofpact_get_OUTPUT(a), out);
1650         break;
1651
1652     case OFPACT_ENQUEUE:
1653         ofpact_enqueue_to_openflow10(ofpact_get_ENQUEUE(a), out);
1654         break;
1655
1656     case OFPACT_SET_VLAN_VID:
1657         ofputil_put_OFPAT10_SET_VLAN_VID(out)->vlan_vid
1658             = htons(ofpact_get_SET_VLAN_VID(a)->vlan_vid);
1659         break;
1660
1661     case OFPACT_SET_VLAN_PCP:
1662         ofputil_put_OFPAT10_SET_VLAN_PCP(out)->vlan_pcp
1663             = ofpact_get_SET_VLAN_PCP(a)->vlan_pcp;
1664         break;
1665
1666     case OFPACT_STRIP_VLAN:
1667         ofputil_put_OFPAT10_STRIP_VLAN(out);
1668         break;
1669
1670     case OFPACT_SET_ETH_SRC:
1671         memcpy(ofputil_put_OFPAT10_SET_DL_SRC(out)->dl_addr,
1672                ofpact_get_SET_ETH_SRC(a)->mac, ETH_ADDR_LEN);
1673         break;
1674
1675     case OFPACT_SET_ETH_DST:
1676         memcpy(ofputil_put_OFPAT10_SET_DL_DST(out)->dl_addr,
1677                ofpact_get_SET_ETH_DST(a)->mac, ETH_ADDR_LEN);
1678         break;
1679
1680     case OFPACT_SET_IPV4_SRC:
1681         ofputil_put_OFPAT10_SET_NW_SRC(out)->nw_addr
1682             = ofpact_get_SET_IPV4_SRC(a)->ipv4;
1683         break;
1684
1685     case OFPACT_SET_IPV4_DST:
1686         ofputil_put_OFPAT10_SET_NW_DST(out)->nw_addr
1687             = ofpact_get_SET_IPV4_DST(a)->ipv4;
1688         break;
1689
1690     case OFPACT_SET_IPV4_DSCP:
1691         ofputil_put_OFPAT10_SET_NW_TOS(out)->nw_tos
1692             = ofpact_get_SET_IPV4_DSCP(a)->dscp;
1693         break;
1694
1695     case OFPACT_SET_L4_SRC_PORT:
1696         ofputil_put_OFPAT10_SET_TP_SRC(out)->tp_port
1697             = htons(ofpact_get_SET_L4_SRC_PORT(a)->port);
1698         break;
1699
1700     case OFPACT_SET_L4_DST_PORT:
1701         ofputil_put_OFPAT10_SET_TP_DST(out)->tp_port
1702             = htons(ofpact_get_SET_L4_DST_PORT(a)->port);
1703         break;
1704
1705     case OFPACT_PUSH_VLAN:
1706     case OFPACT_CLEAR_ACTIONS:
1707     case OFPACT_GOTO_TABLE:
1708     case OFPACT_METER:
1709         /* XXX */
1710         break;
1711
1712     case OFPACT_CONTROLLER:
1713     case OFPACT_OUTPUT_REG:
1714     case OFPACT_BUNDLE:
1715     case OFPACT_REG_MOVE:
1716     case OFPACT_REG_LOAD:
1717     case OFPACT_STACK_PUSH:
1718     case OFPACT_STACK_POP:
1719     case OFPACT_DEC_TTL:
1720     case OFPACT_SET_MPLS_TTL:
1721     case OFPACT_DEC_MPLS_TTL:
1722     case OFPACT_SET_TUNNEL:
1723     case OFPACT_WRITE_METADATA:
1724     case OFPACT_SET_QUEUE:
1725     case OFPACT_POP_QUEUE:
1726     case OFPACT_FIN_TIMEOUT:
1727     case OFPACT_RESUBMIT:
1728     case OFPACT_LEARN:
1729     case OFPACT_MULTIPATH:
1730     case OFPACT_NOTE:
1731     case OFPACT_EXIT:
1732     case OFPACT_PUSH_MPLS:
1733     case OFPACT_POP_MPLS:
1734     case OFPACT_SAMPLE:
1735         ofpact_to_nxast(a, out);
1736         break;
1737     }
1738 }
1739
1740 /* Converts the 'ofpacts_len' bytes of ofpacts in 'ofpacts' into OpenFlow 1.0
1741  * actions in 'openflow', appending the actions to any existing data in
1742  * 'openflow'. */
1743 void
1744 ofpacts_put_openflow10(const struct ofpact ofpacts[], size_t ofpacts_len,
1745                        struct ofpbuf *openflow)
1746 {
1747     const struct ofpact *a;
1748
1749     OFPACT_FOR_EACH (a, ofpacts, ofpacts_len) {
1750         ofpact_to_openflow10(a, openflow);
1751     }
1752 }
1753 \f
1754 /* Converting ofpacts to OpenFlow 1.1. */
1755
1756 static void
1757 ofpact_output_to_openflow11(const struct ofpact_output *output,
1758                             struct ofpbuf *out)
1759 {
1760     struct ofp11_action_output *oao;
1761
1762     oao = ofputil_put_OFPAT11_OUTPUT(out);
1763     oao->port = ofputil_port_to_ofp11(output->port);
1764     oao->max_len = htons(output->max_len);
1765 }
1766
1767 static void
1768 ofpact_dec_ttl_to_openflow11(const struct ofpact_cnt_ids *dec_ttl,
1769                              struct ofpbuf *out)
1770 {
1771     if (dec_ttl->n_controllers == 1 && dec_ttl->cnt_ids[0] == 0
1772         && (!dec_ttl->ofpact.compat ||
1773             dec_ttl->ofpact.compat == OFPUTIL_OFPAT11_DEC_NW_TTL)) {
1774         ofputil_put_OFPAT11_DEC_NW_TTL(out);
1775     } else {
1776         ofpact_dec_ttl_to_nxast(dec_ttl, out);
1777     }
1778 }
1779
1780 static void
1781 ofpact_to_openflow11(const struct ofpact *a, struct ofpbuf *out)
1782 {
1783     switch (a->type) {
1784     case OFPACT_OUTPUT:
1785         return ofpact_output_to_openflow11(ofpact_get_OUTPUT(a), out);
1786
1787     case OFPACT_ENQUEUE:
1788         /* XXX */
1789         break;
1790
1791     case OFPACT_SET_VLAN_VID:
1792         ofputil_put_OFPAT11_SET_VLAN_VID(out)->vlan_vid
1793             = htons(ofpact_get_SET_VLAN_VID(a)->vlan_vid);
1794         break;
1795
1796     case OFPACT_SET_VLAN_PCP:
1797         ofputil_put_OFPAT11_SET_VLAN_PCP(out)->vlan_pcp
1798             = ofpact_get_SET_VLAN_PCP(a)->vlan_pcp;
1799         break;
1800
1801     case OFPACT_STRIP_VLAN:
1802         ofputil_put_OFPAT11_POP_VLAN(out);
1803         break;
1804
1805     case OFPACT_PUSH_VLAN:
1806         /* XXX ETH_TYPE_VLAN_8021AD case */
1807         ofputil_put_OFPAT11_PUSH_VLAN(out)->ethertype =
1808             htons(ETH_TYPE_VLAN_8021Q);
1809         break;
1810
1811     case OFPACT_SET_QUEUE:
1812         ofputil_put_OFPAT11_SET_QUEUE(out)->queue_id
1813             = htonl(ofpact_get_SET_QUEUE(a)->queue_id);
1814         break;
1815
1816     case OFPACT_SET_ETH_SRC:
1817         memcpy(ofputil_put_OFPAT11_SET_DL_SRC(out)->dl_addr,
1818                ofpact_get_SET_ETH_SRC(a)->mac, ETH_ADDR_LEN);
1819         break;
1820
1821     case OFPACT_SET_ETH_DST:
1822         memcpy(ofputil_put_OFPAT11_SET_DL_DST(out)->dl_addr,
1823                ofpact_get_SET_ETH_DST(a)->mac, ETH_ADDR_LEN);
1824         break;
1825
1826     case OFPACT_SET_IPV4_SRC:
1827         ofputil_put_OFPAT11_SET_NW_SRC(out)->nw_addr
1828             = ofpact_get_SET_IPV4_SRC(a)->ipv4;
1829         break;
1830
1831     case OFPACT_SET_IPV4_DST:
1832         ofputil_put_OFPAT11_SET_NW_DST(out)->nw_addr
1833             = ofpact_get_SET_IPV4_DST(a)->ipv4;
1834         break;
1835
1836     case OFPACT_SET_IPV4_DSCP:
1837         ofputil_put_OFPAT11_SET_NW_TOS(out)->nw_tos
1838             = ofpact_get_SET_IPV4_DSCP(a)->dscp;
1839         break;
1840
1841     case OFPACT_SET_L4_SRC_PORT:
1842         ofputil_put_OFPAT11_SET_TP_SRC(out)->tp_port
1843             = htons(ofpact_get_SET_L4_SRC_PORT(a)->port);
1844         break;
1845
1846     case OFPACT_SET_L4_DST_PORT:
1847         ofputil_put_OFPAT11_SET_TP_DST(out)->tp_port
1848             = htons(ofpact_get_SET_L4_DST_PORT(a)->port);
1849         break;
1850
1851     case OFPACT_DEC_TTL:
1852         ofpact_dec_ttl_to_openflow11(ofpact_get_DEC_TTL(a), out);
1853         break;
1854
1855     case OFPACT_SET_MPLS_TTL:
1856         ofputil_put_OFPAT11_SET_MPLS_TTL(out)->mpls_ttl
1857             = ofpact_get_SET_MPLS_TTL(a)->ttl;
1858         break;
1859
1860     case OFPACT_DEC_MPLS_TTL:
1861         ofputil_put_OFPAT11_DEC_MPLS_TTL(out);
1862         break;
1863
1864     case OFPACT_WRITE_METADATA:
1865         /* OpenFlow 1.1 uses OFPIT_WRITE_METADATA to express this action. */
1866         break;
1867
1868     case OFPACT_PUSH_MPLS:
1869         ofputil_put_OFPAT11_PUSH_MPLS(out)->ethertype =
1870             ofpact_get_PUSH_MPLS(a)->ethertype;
1871         break;
1872
1873     case OFPACT_POP_MPLS:
1874         ofputil_put_OFPAT11_POP_MPLS(out)->ethertype =
1875             ofpact_get_POP_MPLS(a)->ethertype;
1876
1877         break;
1878
1879     case OFPACT_CLEAR_ACTIONS:
1880     case OFPACT_GOTO_TABLE:
1881     case OFPACT_METER:
1882         NOT_REACHED();
1883
1884     case OFPACT_CONTROLLER:
1885     case OFPACT_OUTPUT_REG:
1886     case OFPACT_BUNDLE:
1887     case OFPACT_REG_MOVE:
1888     case OFPACT_REG_LOAD:
1889     case OFPACT_STACK_PUSH:
1890     case OFPACT_STACK_POP:
1891     case OFPACT_SET_TUNNEL:
1892     case OFPACT_POP_QUEUE:
1893     case OFPACT_FIN_TIMEOUT:
1894     case OFPACT_RESUBMIT:
1895     case OFPACT_LEARN:
1896     case OFPACT_MULTIPATH:
1897     case OFPACT_NOTE:
1898     case OFPACT_EXIT:
1899     case OFPACT_SAMPLE:
1900         ofpact_to_nxast(a, out);
1901         break;
1902     }
1903 }
1904
1905 /* Converts the ofpacts in 'ofpacts' (terminated by OFPACT_END) into OpenFlow
1906  * 1.1 actions in 'openflow', appending the actions to any existing data in
1907  * 'openflow'. */
1908 size_t
1909 ofpacts_put_openflow11_actions(const struct ofpact ofpacts[],
1910                                size_t ofpacts_len, struct ofpbuf *openflow)
1911 {
1912     const struct ofpact *a;
1913     size_t start_size = openflow->size;
1914
1915     OFPACT_FOR_EACH (a, ofpacts, ofpacts_len) {
1916         ofpact_to_openflow11(a, openflow);
1917     }
1918
1919     return openflow->size - start_size;
1920 }
1921
1922 static void
1923 ofpacts_update_instruction_actions(struct ofpbuf *openflow, size_t ofs)
1924 {
1925     struct ofp11_instruction_actions *oia;
1926
1927     /* Update the instruction's length (or, if it's empty, delete it). */
1928     oia = ofpbuf_at_assert(openflow, ofs, sizeof *oia);
1929     if (openflow->size > ofs + sizeof *oia) {
1930         oia->len = htons(openflow->size - ofs);
1931     } else {
1932         openflow->size = ofs;
1933     }
1934 }
1935
1936 void
1937 ofpacts_put_openflow11_instructions(const struct ofpact ofpacts[],
1938                                     size_t ofpacts_len,
1939                                     struct ofpbuf *openflow)
1940 {
1941     const struct ofpact *a;
1942
1943     OFPACT_FOR_EACH (a, ofpacts, ofpacts_len) {
1944         switch (ovs_instruction_type_from_ofpact_type(a->type)) {
1945         case OVSINST_OFPIT11_CLEAR_ACTIONS:
1946             instruction_put_OFPIT11_CLEAR_ACTIONS(openflow);
1947             break;
1948
1949         case OVSINST_OFPIT11_GOTO_TABLE: {
1950             struct ofp11_instruction_goto_table *oigt;
1951             oigt = instruction_put_OFPIT11_GOTO_TABLE(openflow);
1952             oigt->table_id = ofpact_get_GOTO_TABLE(a)->table_id;
1953             memset(oigt->pad, 0, sizeof oigt->pad);
1954             break;
1955         }
1956
1957         case OVSINST_OFPIT11_WRITE_METADATA: {
1958             const struct ofpact_metadata *om;
1959             struct ofp11_instruction_write_metadata *oiwm;
1960
1961             om = ofpact_get_WRITE_METADATA(a);
1962             oiwm = instruction_put_OFPIT11_WRITE_METADATA(openflow);
1963             oiwm->metadata = om->metadata;
1964             oiwm->metadata_mask = om->mask;
1965             break;
1966         }
1967
1968         case OVSINST_OFPIT13_METER: {
1969             const struct ofpact_meter *om;
1970             struct ofp13_instruction_meter *oim;
1971
1972             om = ofpact_get_METER(a);
1973             oim = instruction_put_OFPIT13_METER(openflow);
1974             oim->meter_id = htonl(om->meter_id);
1975             break;
1976         }
1977
1978         case OVSINST_OFPIT11_APPLY_ACTIONS: {
1979             const size_t ofs = openflow->size;
1980             const size_t ofpacts_len_left =
1981                 (uint8_t*)ofpact_end(ofpacts, ofpacts_len) - (uint8_t*)a;
1982             const struct ofpact *action;
1983             const struct ofpact *processed = a;
1984
1985             instruction_put_OFPIT11_APPLY_ACTIONS(openflow);
1986             OFPACT_FOR_EACH(action, a, ofpacts_len_left) {
1987                 if (ovs_instruction_type_from_ofpact_type(action->type)
1988                     != OVSINST_OFPIT11_APPLY_ACTIONS) {
1989                     break;
1990                 }
1991                 ofpact_to_openflow11(action, openflow);
1992                 processed = action;
1993             }
1994             ofpacts_update_instruction_actions(openflow, ofs);
1995             a = processed;
1996             break;
1997         }
1998
1999         case OVSINST_OFPIT11_WRITE_ACTIONS:
2000             NOT_REACHED();
2001         }
2002     }
2003 }
2004 \f
2005 /* Returns true if 'action' outputs to 'port', false otherwise. */
2006 static bool
2007 ofpact_outputs_to_port(const struct ofpact *ofpact, ofp_port_t port)
2008 {
2009     switch (ofpact->type) {
2010     case OFPACT_OUTPUT:
2011         return ofpact_get_OUTPUT(ofpact)->port == port;
2012     case OFPACT_ENQUEUE:
2013         return ofpact_get_ENQUEUE(ofpact)->port == port;
2014     case OFPACT_CONTROLLER:
2015         return port == OFPP_CONTROLLER;
2016
2017     case OFPACT_OUTPUT_REG:
2018     case OFPACT_BUNDLE:
2019     case OFPACT_SET_VLAN_VID:
2020     case OFPACT_SET_VLAN_PCP:
2021     case OFPACT_STRIP_VLAN:
2022     case OFPACT_PUSH_VLAN:
2023     case OFPACT_SET_ETH_SRC:
2024     case OFPACT_SET_ETH_DST:
2025     case OFPACT_SET_IPV4_SRC:
2026     case OFPACT_SET_IPV4_DST:
2027     case OFPACT_SET_IPV4_DSCP:
2028     case OFPACT_SET_L4_SRC_PORT:
2029     case OFPACT_SET_L4_DST_PORT:
2030     case OFPACT_REG_MOVE:
2031     case OFPACT_REG_LOAD:
2032     case OFPACT_STACK_PUSH:
2033     case OFPACT_STACK_POP:
2034     case OFPACT_DEC_TTL:
2035     case OFPACT_SET_MPLS_TTL:
2036     case OFPACT_DEC_MPLS_TTL:
2037     case OFPACT_SET_TUNNEL:
2038     case OFPACT_WRITE_METADATA:
2039     case OFPACT_SET_QUEUE:
2040     case OFPACT_POP_QUEUE:
2041     case OFPACT_FIN_TIMEOUT:
2042     case OFPACT_RESUBMIT:
2043     case OFPACT_LEARN:
2044     case OFPACT_MULTIPATH:
2045     case OFPACT_NOTE:
2046     case OFPACT_EXIT:
2047     case OFPACT_PUSH_MPLS:
2048     case OFPACT_POP_MPLS:
2049     case OFPACT_SAMPLE:
2050     case OFPACT_CLEAR_ACTIONS:
2051     case OFPACT_GOTO_TABLE:
2052     case OFPACT_METER:
2053     default:
2054         return false;
2055     }
2056 }
2057
2058 /* Returns true if any action in the 'ofpacts_len' bytes of 'ofpacts' outputs
2059  * to 'port', false otherwise. */
2060 bool
2061 ofpacts_output_to_port(const struct ofpact *ofpacts, size_t ofpacts_len,
2062                        ofp_port_t port)
2063 {
2064     const struct ofpact *a;
2065
2066     OFPACT_FOR_EACH (a, ofpacts, ofpacts_len) {
2067         if (ofpact_outputs_to_port(a, port)) {
2068             return true;
2069         }
2070     }
2071
2072     return false;
2073 }
2074
2075 bool
2076 ofpacts_equal(const struct ofpact *a, size_t a_len,
2077               const struct ofpact *b, size_t b_len)
2078 {
2079     return a_len == b_len && !memcmp(a, b, a_len);
2080 }
2081 \f
2082 /* Formatting ofpacts. */
2083
2084 static void
2085 print_note(const struct ofpact_note *note, struct ds *string)
2086 {
2087     size_t i;
2088
2089     ds_put_cstr(string, "note:");
2090     for (i = 0; i < note->length; i++) {
2091         if (i) {
2092             ds_put_char(string, '.');
2093         }
2094         ds_put_format(string, "%02"PRIx8, note->data[i]);
2095     }
2096 }
2097
2098 static void
2099 print_dec_ttl(const struct ofpact_cnt_ids *ids,
2100               struct ds *s)
2101 {
2102     size_t i;
2103
2104     ds_put_cstr(s, "dec_ttl");
2105     if (ids->ofpact.compat == OFPUTIL_NXAST_DEC_TTL_CNT_IDS) {
2106         ds_put_cstr(s, "(");
2107         for (i = 0; i < ids->n_controllers; i++) {
2108             if (i) {
2109                 ds_put_cstr(s, ",");
2110             }
2111             ds_put_format(s, "%"PRIu16, ids->cnt_ids[i]);
2112         }
2113         ds_put_cstr(s, ")");
2114     }
2115 }
2116
2117 static void
2118 print_fin_timeout(const struct ofpact_fin_timeout *fin_timeout,
2119                   struct ds *s)
2120 {
2121     ds_put_cstr(s, "fin_timeout(");
2122     if (fin_timeout->fin_idle_timeout) {
2123         ds_put_format(s, "idle_timeout=%"PRIu16",",
2124                       fin_timeout->fin_idle_timeout);
2125     }
2126     if (fin_timeout->fin_hard_timeout) {
2127         ds_put_format(s, "hard_timeout=%"PRIu16",",
2128                       fin_timeout->fin_hard_timeout);
2129     }
2130     ds_chomp(s, ',');
2131     ds_put_char(s, ')');
2132 }
2133
2134 static void
2135 ofpact_format(const struct ofpact *a, struct ds *s)
2136 {
2137     const struct ofpact_enqueue *enqueue;
2138     const struct ofpact_resubmit *resubmit;
2139     const struct ofpact_controller *controller;
2140     const struct ofpact_metadata *metadata;
2141     const struct ofpact_tunnel *tunnel;
2142     const struct ofpact_sample *sample;
2143     ofp_port_t port;
2144
2145     switch (a->type) {
2146     case OFPACT_OUTPUT:
2147         port = ofpact_get_OUTPUT(a)->port;
2148         if (ofp_to_u16(port) < ofp_to_u16(OFPP_MAX)) {
2149             ds_put_format(s, "output:%"PRIu16, port);
2150         } else {
2151             ofputil_format_port(port, s);
2152             if (port == OFPP_CONTROLLER) {
2153                 ds_put_format(s, ":%"PRIu16, ofpact_get_OUTPUT(a)->max_len);
2154             }
2155         }
2156         break;
2157
2158     case OFPACT_CONTROLLER:
2159         controller = ofpact_get_CONTROLLER(a);
2160         if (controller->reason == OFPR_ACTION &&
2161             controller->controller_id == 0) {
2162             ds_put_format(s, "CONTROLLER:%"PRIu16,
2163                           ofpact_get_CONTROLLER(a)->max_len);
2164         } else {
2165             enum ofp_packet_in_reason reason = controller->reason;
2166
2167             ds_put_cstr(s, "controller(");
2168             if (reason != OFPR_ACTION) {
2169                 char reasonbuf[OFPUTIL_PACKET_IN_REASON_BUFSIZE];
2170
2171                 ds_put_format(s, "reason=%s,",
2172                               ofputil_packet_in_reason_to_string(
2173                                   reason, reasonbuf, sizeof reasonbuf));
2174             }
2175             if (controller->max_len != UINT16_MAX) {
2176                 ds_put_format(s, "max_len=%"PRIu16",", controller->max_len);
2177             }
2178             if (controller->controller_id != 0) {
2179                 ds_put_format(s, "id=%"PRIu16",", controller->controller_id);
2180             }
2181             ds_chomp(s, ',');
2182             ds_put_char(s, ')');
2183         }
2184         break;
2185
2186     case OFPACT_ENQUEUE:
2187         enqueue = ofpact_get_ENQUEUE(a);
2188         ds_put_format(s, "enqueue:");
2189         ofputil_format_port(enqueue->port, s);
2190         ds_put_format(s, "q%"PRIu32, enqueue->queue);
2191         break;
2192
2193     case OFPACT_OUTPUT_REG:
2194         ds_put_cstr(s, "output:");
2195         mf_format_subfield(&ofpact_get_OUTPUT_REG(a)->src, s);
2196         break;
2197
2198     case OFPACT_BUNDLE:
2199         bundle_format(ofpact_get_BUNDLE(a), s);
2200         break;
2201
2202     case OFPACT_SET_VLAN_VID:
2203         ds_put_format(s, "mod_vlan_vid:%"PRIu16,
2204                       ofpact_get_SET_VLAN_VID(a)->vlan_vid);
2205         break;
2206
2207     case OFPACT_SET_VLAN_PCP:
2208         ds_put_format(s, "mod_vlan_pcp:%"PRIu8,
2209                       ofpact_get_SET_VLAN_PCP(a)->vlan_pcp);
2210         break;
2211
2212     case OFPACT_STRIP_VLAN:
2213         ds_put_cstr(s, "strip_vlan");
2214         break;
2215
2216     case OFPACT_PUSH_VLAN:
2217         /* XXX 802.1AD case*/
2218         ds_put_format(s, "push_vlan:%#"PRIx16, ETH_TYPE_VLAN_8021Q);
2219         break;
2220
2221     case OFPACT_SET_ETH_SRC:
2222         ds_put_format(s, "mod_dl_src:"ETH_ADDR_FMT,
2223                       ETH_ADDR_ARGS(ofpact_get_SET_ETH_SRC(a)->mac));
2224         break;
2225
2226     case OFPACT_SET_ETH_DST:
2227         ds_put_format(s, "mod_dl_dst:"ETH_ADDR_FMT,
2228                       ETH_ADDR_ARGS(ofpact_get_SET_ETH_DST(a)->mac));
2229         break;
2230
2231     case OFPACT_SET_IPV4_SRC:
2232         ds_put_format(s, "mod_nw_src:"IP_FMT,
2233                       IP_ARGS(ofpact_get_SET_IPV4_SRC(a)->ipv4));
2234         break;
2235
2236     case OFPACT_SET_IPV4_DST:
2237         ds_put_format(s, "mod_nw_dst:"IP_FMT,
2238                       IP_ARGS(ofpact_get_SET_IPV4_DST(a)->ipv4));
2239         break;
2240
2241     case OFPACT_SET_IPV4_DSCP:
2242         ds_put_format(s, "mod_nw_tos:%d", ofpact_get_SET_IPV4_DSCP(a)->dscp);
2243         break;
2244
2245     case OFPACT_SET_L4_SRC_PORT:
2246         ds_put_format(s, "mod_tp_src:%d", ofpact_get_SET_L4_SRC_PORT(a)->port);
2247         break;
2248
2249     case OFPACT_SET_L4_DST_PORT:
2250         ds_put_format(s, "mod_tp_dst:%d", ofpact_get_SET_L4_DST_PORT(a)->port);
2251         break;
2252
2253     case OFPACT_REG_MOVE:
2254         nxm_format_reg_move(ofpact_get_REG_MOVE(a), s);
2255         break;
2256
2257     case OFPACT_REG_LOAD:
2258         nxm_format_reg_load(ofpact_get_REG_LOAD(a), s);
2259         break;
2260
2261     case OFPACT_STACK_PUSH:
2262         nxm_format_stack_push(ofpact_get_STACK_PUSH(a), s);
2263         break;
2264
2265     case OFPACT_STACK_POP:
2266         nxm_format_stack_pop(ofpact_get_STACK_POP(a), s);
2267         break;
2268
2269     case OFPACT_DEC_TTL:
2270         print_dec_ttl(ofpact_get_DEC_TTL(a), s);
2271         break;
2272
2273     case OFPACT_SET_MPLS_TTL:
2274         ds_put_format(s, "set_mpls_ttl(%"PRIu8")",
2275                       ofpact_get_SET_MPLS_TTL(a)->ttl);
2276         break;
2277
2278     case OFPACT_DEC_MPLS_TTL:
2279         ds_put_cstr(s, "dec_mpls_ttl");
2280         break;
2281
2282     case OFPACT_SET_TUNNEL:
2283         tunnel = ofpact_get_SET_TUNNEL(a);
2284         ds_put_format(s, "set_tunnel%s:%#"PRIx64,
2285                       (tunnel->tun_id > UINT32_MAX
2286                        || a->compat == OFPUTIL_NXAST_SET_TUNNEL64 ? "64" : ""),
2287                       tunnel->tun_id);
2288         break;
2289
2290     case OFPACT_SET_QUEUE:
2291         ds_put_format(s, "set_queue:%"PRIu32,
2292                       ofpact_get_SET_QUEUE(a)->queue_id);
2293         break;
2294
2295     case OFPACT_POP_QUEUE:
2296         ds_put_cstr(s, "pop_queue");
2297         break;
2298
2299     case OFPACT_FIN_TIMEOUT:
2300         print_fin_timeout(ofpact_get_FIN_TIMEOUT(a), s);
2301         break;
2302
2303     case OFPACT_RESUBMIT:
2304         resubmit = ofpact_get_RESUBMIT(a);
2305         if (resubmit->in_port != OFPP_IN_PORT && resubmit->table_id == 255) {
2306             ds_put_cstr(s, "resubmit:");
2307             ofputil_format_port(resubmit->in_port, s);
2308         } else {
2309             ds_put_format(s, "resubmit(");
2310             if (resubmit->in_port != OFPP_IN_PORT) {
2311                 ofputil_format_port(resubmit->in_port, s);
2312             }
2313             ds_put_char(s, ',');
2314             if (resubmit->table_id != 255) {
2315                 ds_put_format(s, "%"PRIu8, resubmit->table_id);
2316             }
2317             ds_put_char(s, ')');
2318         }
2319         break;
2320
2321     case OFPACT_LEARN:
2322         learn_format(ofpact_get_LEARN(a), s);
2323         break;
2324
2325     case OFPACT_MULTIPATH:
2326         multipath_format(ofpact_get_MULTIPATH(a), s);
2327         break;
2328
2329     case OFPACT_NOTE:
2330         print_note(ofpact_get_NOTE(a), s);
2331         break;
2332
2333     case OFPACT_PUSH_MPLS:
2334         ds_put_format(s, "push_mpls:0x%04"PRIx16,
2335                       ntohs(ofpact_get_PUSH_MPLS(a)->ethertype));
2336         break;
2337
2338     case OFPACT_POP_MPLS:
2339         ds_put_format(s, "pop_mpls:0x%04"PRIx16,
2340                       ntohs(ofpact_get_POP_MPLS(a)->ethertype));
2341         break;
2342
2343     case OFPACT_EXIT:
2344         ds_put_cstr(s, "exit");
2345         break;
2346
2347     case OFPACT_SAMPLE:
2348         sample = ofpact_get_SAMPLE(a);
2349         ds_put_format(
2350             s, "sample(probability=%"PRIu16",collector_set_id=%"PRIu32
2351             ",obs_domain_id=%"PRIu32",obs_point_id=%"PRIu32")",
2352             sample->probability, sample->collector_set_id,
2353             sample->obs_domain_id, sample->obs_point_id);
2354         break;
2355
2356     case OFPACT_CLEAR_ACTIONS:
2357         ds_put_format(s, "%s",
2358                       ovs_instruction_name_from_type(
2359                           OVSINST_OFPIT11_CLEAR_ACTIONS));
2360         break;
2361
2362     case OFPACT_WRITE_METADATA:
2363         metadata = ofpact_get_WRITE_METADATA(a);
2364         ds_put_format(s, "%s:%#"PRIx64,
2365                       ovs_instruction_name_from_type(
2366                           OVSINST_OFPIT11_WRITE_METADATA),
2367                       ntohll(metadata->metadata));
2368         if (metadata->mask != htonll(UINT64_MAX)) {
2369             ds_put_format(s, "/%#"PRIx64, ntohll(metadata->mask));
2370         }
2371         break;
2372
2373     case OFPACT_GOTO_TABLE:
2374         ds_put_format(s, "%s:%"PRIu8,
2375                       ovs_instruction_name_from_type(
2376                           OVSINST_OFPIT11_GOTO_TABLE),
2377                       ofpact_get_GOTO_TABLE(a)->table_id);
2378         break;
2379
2380     case OFPACT_METER:
2381         ds_put_format(s, "%s:%"PRIu32,
2382                       ovs_instruction_name_from_type(OVSINST_OFPIT13_METER),
2383                       ofpact_get_METER(a)->meter_id);
2384         break;
2385     }
2386 }
2387
2388 /* Appends a string representing the 'ofpacts_len' bytes of ofpacts in
2389  * 'ofpacts' to 'string'. */
2390 void
2391 ofpacts_format(const struct ofpact *ofpacts, size_t ofpacts_len,
2392                struct ds *string)
2393 {
2394     ds_put_cstr(string, "actions=");
2395     if (!ofpacts_len) {
2396         ds_put_cstr(string, "drop");
2397     } else {
2398         const struct ofpact *a;
2399
2400         OFPACT_FOR_EACH (a, ofpacts, ofpacts_len) {
2401             if (a != ofpacts) {
2402                 ds_put_cstr(string, ",");
2403             }
2404
2405             /* XXX write-actions */
2406             ofpact_format(a, string);
2407         }
2408     }
2409 }
2410 \f
2411 /* Internal use by helpers. */
2412
2413 void *
2414 ofpact_put(struct ofpbuf *ofpacts, enum ofpact_type type, size_t len)
2415 {
2416     struct ofpact *ofpact;
2417
2418     ofpact_pad(ofpacts);
2419     ofpact = ofpacts->l2 = ofpbuf_put_uninit(ofpacts, len);
2420     ofpact_init(ofpact, type, len);
2421     return ofpact;
2422 }
2423
2424 void
2425 ofpact_init(struct ofpact *ofpact, enum ofpact_type type, size_t len)
2426 {
2427     memset(ofpact, 0, len);
2428     ofpact->type = type;
2429     ofpact->compat = OFPUTIL_ACTION_INVALID;
2430     ofpact->len = len;
2431 }
2432 \f
2433 /* Updates 'ofpact->len' to the number of bytes in the tail of 'ofpacts'
2434  * starting at 'ofpact'.
2435  *
2436  * This is the correct way to update a variable-length ofpact's length after
2437  * adding the variable-length part of the payload.  (See the large comment
2438  * near the end of ofp-actions.h for more information.) */
2439 void
2440 ofpact_update_len(struct ofpbuf *ofpacts, struct ofpact *ofpact)
2441 {
2442     ovs_assert(ofpact == ofpacts->l2);
2443     ofpact->len = (char *) ofpbuf_tail(ofpacts) - (char *) ofpact;
2444 }
2445
2446 /* Pads out 'ofpacts' to a multiple of OFPACT_ALIGNTO bytes in length.  Each
2447  * ofpact_put_<ENUM>() calls this function automatically beforehand, but the
2448  * client must call this itself after adding the final ofpact to an array of
2449  * them.
2450  *
2451  * (The consequences of failing to call this function are probably not dire.
2452  * OFPACT_FOR_EACH will calculate a pointer beyond the end of the ofpacts, but
2453  * not dereference it.  That's undefined behavior, technically, but it will not
2454  * cause a real problem on common systems.  Still, it seems better to call
2455  * it.) */
2456 void
2457 ofpact_pad(struct ofpbuf *ofpacts)
2458 {
2459     unsigned int rem = ofpacts->size % OFPACT_ALIGNTO;
2460     if (rem) {
2461         ofpbuf_put_zeros(ofpacts, OFPACT_ALIGNTO - rem);
2462     }
2463 }
2464
2465 void
2466 ofpact_set_field_init(struct ofpact_reg_load *load, const struct mf_field *mf,
2467                       const void *src)
2468 {
2469     load->ofpact.compat = OFPUTIL_OFPAT12_SET_FIELD;
2470     load->dst.field = mf;
2471     load->dst.ofs = 0;
2472     load->dst.n_bits = mf->n_bits;
2473     bitwise_copy(src, mf->n_bytes, load->dst.ofs,
2474                  &load->subvalue, sizeof load->subvalue, 0, mf->n_bits);
2475 }