lib/ofp-actions.c

   1 /*
   2  * Copyright (c) 2008, 2009, 2010, 2011, 2012, 2013 Nicira, Inc.
   3  *
   4  * Licensed under the Apache License, Version 2.0 (the "License");
   5  * you may not use this file except in compliance with the License.
   6  * You may obtain a copy of the License at:
   7  *
   8  *     http://www.apache.org/licenses/LICENSE-2.0
   9  *
  10  * Unless required by applicable law or agreed to in writing, software
  11  * distributed under the License is distributed on an "AS IS" BASIS,
  12  * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  13  * See the License for the specific language governing permissions and
  14  * limitations under the License.
  15  */
  16
  17 #include <config.h>
  18 #include "ofp-actions.h"
  19 #include "bundle.h"
  20 #include "byte-order.h"
  21 #include "compiler.h"
  22 #include "dynamic-string.h"
  23 #include "learn.h"
  24 #include "meta-flow.h"
  25 #include "multipath.h"
  26 #include "nx-match.h"
  27 #include "ofp-util.h"
  28 #include "ofpbuf.h"
  29 #include "util.h"
  30 #include "vlog.h"
  31
  32 VLOG_DEFINE_THIS_MODULE(ofp_actions);
  33
  34 static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(1, 5);
  35 \f
  36 /* Converting OpenFlow 1.0 to ofpacts. */
  37
  38 static enum ofperr
  39 output_from_openflow10(const struct ofp10_action_output *oao,
  40                        struct ofpbuf *out)
  41 {
  42     struct ofpact_output *output;
  43
  44     output = ofpact_put_OUTPUT(out);
  45     output->port = u16_to_ofp(ntohs(oao->port));
  46     output->max_len = ntohs(oao->max_len);
  47
  48     return ofputil_check_output_port(output->port, OFPP_MAX);
  49 }
  50
  51 static enum ofperr
  52 enqueue_from_openflow10(const struct ofp10_action_enqueue *oae,
  53                         struct ofpbuf *out)
  54 {
  55     struct ofpact_enqueue *enqueue;
  56
  57     enqueue = ofpact_put_ENQUEUE(out);
  58     enqueue->port = u16_to_ofp(ntohs(oae->port));
  59     enqueue->queue = ntohl(oae->queue_id);
  60     if (ofp_to_u16(enqueue->port) >= ofp_to_u16(OFPP_MAX)
  61         && enqueue->port != OFPP_IN_PORT
  62         && enqueue->port != OFPP_LOCAL) {
  63         return OFPERR_OFPBAC_BAD_OUT_PORT;
  64     }
  65     return 0;
  66 }
  67
  68 static void
  69 resubmit_from_openflow(const struct nx_action_resubmit *nar,
  70                        struct ofpbuf *out)
  71 {
  72     struct ofpact_resubmit *resubmit;
  73
  74     resubmit = ofpact_put_RESUBMIT(out);
  75     resubmit->ofpact.compat = OFPUTIL_NXAST_RESUBMIT;
  76     resubmit->in_port = u16_to_ofp(ntohs(nar->in_port));
  77     resubmit->table_id = 0xff;
  78 }
  79
  80 static enum ofperr
  81 resubmit_table_from_openflow(const struct nx_action_resubmit *nar,
  82                              struct ofpbuf *out)
  83 {
  84     struct ofpact_resubmit *resubmit;
  85
  86     if (nar->pad[0] || nar->pad[1] || nar->pad[2]) {
  87         return OFPERR_OFPBAC_BAD_ARGUMENT;
  88     }
  89
  90     resubmit = ofpact_put_RESUBMIT(out);
  91     resubmit->ofpact.compat = OFPUTIL_NXAST_RESUBMIT_TABLE;
  92     resubmit->in_port = u16_to_ofp(ntohs(nar->in_port));
  93     resubmit->table_id = nar->table;
  94     return 0;
  95 }
  96
  97 static enum ofperr
  98 output_reg_from_openflow(const struct nx_action_output_reg *naor,
  99                          struct ofpbuf *out)
 100 {
 101     struct ofpact_output_reg *output_reg;
 102
 103     if (!is_all_zeros(naor->zero, sizeof naor->zero)) {
 104         return OFPERR_OFPBAC_BAD_ARGUMENT;
 105     }
 106
 107     output_reg = ofpact_put_OUTPUT_REG(out);
 108     output_reg->src.field = mf_from_nxm_header(ntohl(naor->src));
 109     output_reg->src.ofs = nxm_decode_ofs(naor->ofs_nbits);
 110     output_reg->src.n_bits = nxm_decode_n_bits(naor->ofs_nbits);
 111     output_reg->max_len = ntohs(naor->max_len);
 112
 113     return mf_check_src(&output_reg->src, NULL);
 114 }
 115
 116 static void
 117 fin_timeout_from_openflow(const struct nx_action_fin_timeout *naft,
 118                           struct ofpbuf *out)
 119 {
 120     struct ofpact_fin_timeout *oft;
 121
 122     oft = ofpact_put_FIN_TIMEOUT(out);
 123     oft->fin_idle_timeout = ntohs(naft->fin_idle_timeout);
 124     oft->fin_hard_timeout = ntohs(naft->fin_hard_timeout);
 125 }
 126
 127 static void
 128 controller_from_openflow(const struct nx_action_controller *nac,
 129                          struct ofpbuf *out)
 130 {
 131     struct ofpact_controller *oc;
 132
 133     oc = ofpact_put_CONTROLLER(out);
 134     oc->max_len = ntohs(nac->max_len);
 135     oc->controller_id = ntohs(nac->controller_id);
 136     oc->reason = nac->reason;
 137 }
 138
 139 static enum ofperr
 140 metadata_from_nxast(const struct nx_action_write_metadata *nawm,
 141                     struct ofpbuf *out)
 142 {
 143     struct ofpact_metadata *om;
 144
 145     if (!is_all_zeros(nawm->zeros, sizeof nawm->zeros)) {
 146         return OFPERR_NXBRC_MUST_BE_ZERO;
 147     }
 148
 149     om = ofpact_put_WRITE_METADATA(out);
 150     om->metadata = nawm->metadata;
 151     om->mask = nawm->mask;
 152
 153     return 0;
 154 }
 155
 156 static void
 157 note_from_openflow(const struct nx_action_note *nan, struct ofpbuf *out)
 158 {
 159     struct ofpact_note *note;
 160     unsigned int length;
 161
 162     length = ntohs(nan->len) - offsetof(struct nx_action_note, note);
 163     note = ofpact_put(out, OFPACT_NOTE,
 164                       offsetof(struct ofpact_note, data) + length);
 165     note->length = length;
 166     memcpy(note->data, nan->note, length);
 167 }
 168
 169 static enum ofperr
 170 dec_ttl_from_openflow(struct ofpbuf *out, enum ofputil_action_code compat)
 171 {
 172     uint16_t id = 0;
 173     struct ofpact_cnt_ids *ids;
 174     enum ofperr error = 0;
 175
 176     ids = ofpact_put_DEC_TTL(out);
 177     ids->ofpact.compat = compat;
 178     ids->n_controllers = 1;
 179     ofpbuf_put(out, &id, sizeof id);
 180     ids = out->l2;
 181     ofpact_update_len(out, &ids->ofpact);
 182     return error;
 183 }
 184
 185 static enum ofperr
 186 dec_ttl_cnt_ids_from_openflow(const struct nx_action_cnt_ids *nac_ids,
 187                       struct ofpbuf *out)
 188 {
 189     struct ofpact_cnt_ids *ids;
 190     size_t ids_size;
 191     int i;
 192
 193     ids = ofpact_put_DEC_TTL(out);
 194     ids->ofpact.compat = OFPUTIL_NXAST_DEC_TTL_CNT_IDS;
 195     ids->n_controllers = ntohs(nac_ids->n_controllers);
 196     ids_size = ntohs(nac_ids->len) - sizeof *nac_ids;
 197
 198     if (!is_all_zeros(nac_ids->zeros, sizeof nac_ids->zeros)) {
 199         return OFPERR_NXBRC_MUST_BE_ZERO;
 200     }
 201
 202     if (ids_size < ids->n_controllers * sizeof(ovs_be16)) {
 203         VLOG_WARN_RL(&rl, "Nicira action dec_ttl_cnt_ids only has %zu bytes "
 204                      "allocated for controller ids.  %zu bytes are required for "
 205                      "%"PRIu16" controllers.", ids_size,
 206                      ids->n_controllers * sizeof(ovs_be16), ids->n_controllers);
 207         return OFPERR_OFPBAC_BAD_LEN;
 208     }
 209
 210     for (i = 0; i < ids->n_controllers; i++) {
 211         uint16_t id = ntohs(((ovs_be16 *)(nac_ids + 1))[i]);
 212         ofpbuf_put(out, &id, sizeof id);
 213         ids = out->l2;
 214     }
 215
 216     ofpact_update_len(out, &ids->ofpact);
 217
 218     return 0;
 219 }
 220
 221 static enum ofperr
 222 sample_from_openflow(const struct nx_action_sample *nas,
 223                      struct ofpbuf *out)
 224 {
 225     struct ofpact_sample *sample;
 226
 227     sample = ofpact_put_SAMPLE(out);
 228     sample->probability = ntohs(nas->probability);
 229     sample->collector_set_id = ntohl(nas->collector_set_id);
 230     sample->obs_domain_id = ntohl(nas->obs_domain_id);
 231     sample->obs_point_id = ntohl(nas->obs_point_id);
 232
 233     if (sample->probability == 0) {
 234         return OFPERR_OFPBAC_BAD_ARGUMENT;
 235     }
 236
 237     return 0;
 238 }
 239
 240 static enum ofperr
 241 decode_nxast_action(const union ofp_action *a, enum ofputil_action_code *code)
 242 {
 243     const struct nx_action_header *nah = (const struct nx_action_header *) a;
 244     uint16_t len = ntohs(a->header.len);
 245
 246     if (len < sizeof(struct nx_action_header)) {
 247         return OFPERR_OFPBAC_BAD_LEN;
 248     } else if (a->vendor.vendor != CONSTANT_HTONL(NX_VENDOR_ID)) {
 249         return OFPERR_OFPBAC_BAD_VENDOR;
 250     }
 251
 252     switch (nah->subtype) {
 253 #define NXAST_ACTION(ENUM, STRUCT, EXTENSIBLE, NAME)    \
 254         case CONSTANT_HTONS(ENUM):                      \
 255             if (EXTENSIBLE                              \
 256                 ? len >= sizeof(struct STRUCT)          \
 257                 : len == sizeof(struct STRUCT)) {       \
 258                 *code = OFPUTIL_##ENUM;                 \
 259                 return 0;                               \
 260             } else {                                    \
 261                 return OFPERR_OFPBAC_BAD_LEN;           \
 262             }                                           \
 263             NOT_REACHED();
 264 #include "ofp-util.def"
 265
 266     case CONSTANT_HTONS(NXAST_SNAT__OBSOLETE):
 267     case CONSTANT_HTONS(NXAST_DROP_SPOOFED_ARP__OBSOLETE):
 268     default:
 269         return OFPERR_OFPBAC_BAD_TYPE;
 270     }
 271 }
 272
 273 /* Parses 'a' to determine its type.  On success stores the correct type into
 274  * '*code' and returns 0.  On failure returns an OFPERR_* error code and
 275  * '*code' is indeterminate.
 276  *
 277  * The caller must have already verified that 'a''s length is potentially
 278  * correct (that is, a->header.len is nonzero and a multiple of sizeof(union
 279  * ofp_action) and no longer than the amount of space allocated to 'a').
 280  *
 281  * This function verifies that 'a''s length is correct for the type of action
 282  * that it represents. */
 283 static enum ofperr
 284 decode_openflow10_action(const union ofp_action *a,
 285                          enum ofputil_action_code *code)
 286 {
 287     switch (a->type) {
 288     case CONSTANT_HTONS(OFPAT10_VENDOR):
 289         return decode_nxast_action(a, code);
 290
 291 #define OFPAT10_ACTION(ENUM, STRUCT, NAME)                          \
 292         case CONSTANT_HTONS(ENUM):                                  \
 293             if (a->header.len == htons(sizeof(struct STRUCT))) {    \
 294                 *code = OFPUTIL_##ENUM;                             \
 295                 return 0;                                           \
 296             } else {                                                \
 297                 return OFPERR_OFPBAC_BAD_LEN;                       \
 298             }                                                       \
 299             break;
 300 #include "ofp-util.def"
 301
 302     default:
 303         return OFPERR_OFPBAC_BAD_TYPE;
 304     }
 305 }
 306
 307 static enum ofperr
 308 ofpact_from_nxast(const union ofp_action *a, enum ofputil_action_code code,
 309                   struct ofpbuf *out)
 310 {
 311     const struct nx_action_resubmit *nar;
 312     const struct nx_action_set_tunnel *nast;
 313     const struct nx_action_set_queue *nasq;
 314     const struct nx_action_note *nan;
 315     const struct nx_action_set_tunnel64 *nast64;
 316     const struct nx_action_write_metadata *nawm;
 317     struct ofpact_tunnel *tunnel;
 318     enum ofperr error = 0;
 319
 320     switch (code) {
 321     case OFPUTIL_ACTION_INVALID:
 322 #define OFPAT10_ACTION(ENUM, STRUCT, NAME) case OFPUTIL_##ENUM:
 323 #define OFPAT11_ACTION(ENUM, STRUCT, EXTENSIBLE, NAME) case OFPUTIL_##ENUM:
 324 #include "ofp-util.def"
 325         NOT_REACHED();
 326
 327     case OFPUTIL_NXAST_RESUBMIT:
 328         resubmit_from_openflow((const struct nx_action_resubmit *) a, out);
 329         break;
 330
 331     case OFPUTIL_NXAST_SET_TUNNEL:
 332         nast = (const struct nx_action_set_tunnel *) a;
 333         tunnel = ofpact_put_SET_TUNNEL(out);
 334         tunnel->ofpact.compat = code;
 335         tunnel->tun_id = ntohl(nast->tun_id);
 336         break;
 337
 338     case OFPUTIL_NXAST_WRITE_METADATA:
 339         nawm = (const struct nx_action_write_metadata *) a;
 340         error = metadata_from_nxast(nawm, out);
 341         break;
 342
 343     case OFPUTIL_NXAST_SET_QUEUE:
 344         nasq = (const struct nx_action_set_queue *) a;
 345         ofpact_put_SET_QUEUE(out)->queue_id = ntohl(nasq->queue_id);
 346         break;
 347
 348     case OFPUTIL_NXAST_POP_QUEUE:
 349         ofpact_put_POP_QUEUE(out);
 350         break;
 351
 352     case OFPUTIL_NXAST_REG_MOVE:
 353         error = nxm_reg_move_from_openflow(
 354             (const struct nx_action_reg_move *) a, out);
 355         break;
 356
 357     case OFPUTIL_NXAST_REG_LOAD:
 358         error = nxm_reg_load_from_openflow(
 359             (const struct nx_action_reg_load *) a, out);
 360         break;
 361
 362     case OFPUTIL_NXAST_STACK_PUSH:
 363         error = nxm_stack_push_from_openflow(
 364             (const struct nx_action_stack *) a, out);
 365         break;
 366
 367     case OFPUTIL_NXAST_STACK_POP:
 368         error = nxm_stack_pop_from_openflow(
 369             (const struct nx_action_stack *) a, out);
 370         break;
 371
 372     case OFPUTIL_NXAST_NOTE:
 373         nan = (const struct nx_action_note *) a;
 374         note_from_openflow(nan, out);
 375         break;
 376
 377     case OFPUTIL_NXAST_SET_TUNNEL64:
 378         nast64 = (const struct nx_action_set_tunnel64 *) a;
 379         tunnel = ofpact_put_SET_TUNNEL(out);
 380         tunnel->ofpact.compat = code;
 381         tunnel->tun_id = ntohll(nast64->tun_id);
 382         break;
 383
 384     case OFPUTIL_NXAST_MULTIPATH:
 385         error = multipath_from_openflow((const struct nx_action_multipath *) a,
 386                                         ofpact_put_MULTIPATH(out));
 387         break;
 388
 389     case OFPUTIL_NXAST_BUNDLE:
 390     case OFPUTIL_NXAST_BUNDLE_LOAD:
 391         error = bundle_from_openflow((const struct nx_action_bundle *) a, out);
 392         break;
 393
 394     case OFPUTIL_NXAST_OUTPUT_REG:
 395         error = output_reg_from_openflow(
 396             (const struct nx_action_output_reg *) a, out);
 397         break;
 398
 399     case OFPUTIL_NXAST_RESUBMIT_TABLE:
 400         nar = (const struct nx_action_resubmit *) a;
 401         error = resubmit_table_from_openflow(nar, out);
 402         break;
 403
 404     case OFPUTIL_NXAST_LEARN:
 405         error = learn_from_openflow((const struct nx_action_learn *) a, out);
 406         break;
 407
 408     case OFPUTIL_NXAST_EXIT:
 409         ofpact_put_EXIT(out);
 410         break;
 411
 412     case OFPUTIL_NXAST_DEC_TTL:
 413         error = dec_ttl_from_openflow(out, code);
 414         break;
 415
 416     case OFPUTIL_NXAST_DEC_TTL_CNT_IDS:
 417         error = dec_ttl_cnt_ids_from_openflow(
 418                     (const struct nx_action_cnt_ids *) a, out);
 419         break;
 420
 421     case OFPUTIL_NXAST_FIN_TIMEOUT:
 422         fin_timeout_from_openflow(
 423             (const struct nx_action_fin_timeout *) a, out);
 424         break;
 425
 426     case OFPUTIL_NXAST_CONTROLLER:
 427         controller_from_openflow((const struct nx_action_controller *) a, out);
 428         break;
 429
 430     case OFPUTIL_NXAST_PUSH_MPLS: {
 431         struct nx_action_push_mpls *nxapm = (struct nx_action_push_mpls *)a;
 432         if (!eth_type_mpls(nxapm->ethertype)) {
 433             return OFPERR_OFPBAC_BAD_ARGUMENT;
 434         }
 435         ofpact_put_PUSH_MPLS(out)->ethertype = nxapm->ethertype;
 436         break;
 437     }
 438
 439     case OFPUTIL_NXAST_SET_MPLS_TTL: {
 440         struct nx_action_mpls_ttl *nxamt = (struct nx_action_mpls_ttl *)a;
 441         ofpact_put_SET_MPLS_TTL(out)->ttl = nxamt->ttl;
 442         break;
 443     }
 444
 445     case OFPUTIL_NXAST_DEC_MPLS_TTL:
 446         ofpact_put_DEC_MPLS_TTL(out);
 447         break;
 448
 449     case OFPUTIL_NXAST_POP_MPLS: {
 450         struct nx_action_pop_mpls *nxapm = (struct nx_action_pop_mpls *)a;
 451         if (eth_type_mpls(nxapm->ethertype)) {
 452             return OFPERR_OFPBAC_BAD_ARGUMENT;
 453         }
 454         ofpact_put_POP_MPLS(out)->ethertype = nxapm->ethertype;
 455         break;
 456     }
 457
 458     case OFPUTIL_NXAST_SAMPLE:
 459         error = sample_from_openflow(
 460             (const struct nx_action_sample *) a, out);
 461         break;
 462     }
 463
 464     return error;
 465 }
 466
 467 static enum ofperr
 468 ofpact_from_openflow10(const union ofp_action *a, struct ofpbuf *out)
 469 {
 470     enum ofputil_action_code code;
 471     enum ofperr error;
 472
 473     error = decode_openflow10_action(a, &code);
 474     if (error) {
 475         return error;
 476     }
 477
 478     switch (code) {
 479     case OFPUTIL_ACTION_INVALID:
 480 #define OFPAT11_ACTION(ENUM, STRUCT, EXTENSIBLE, NAME) case OFPUTIL_##ENUM:
 481 #include "ofp-util.def"
 482         NOT_REACHED();
 483
 484     case OFPUTIL_OFPAT10_OUTPUT:
 485         return output_from_openflow10(&a->output10, out);
 486
 487     case OFPUTIL_OFPAT10_SET_VLAN_VID:
 488         if (a->vlan_vid.vlan_vid & ~htons(0xfff)) {
 489             return OFPERR_OFPBAC_BAD_ARGUMENT;
 490         }
 491         ofpact_put_SET_VLAN_VID(out)->vlan_vid = ntohs(a->vlan_vid.vlan_vid);
 492         break;
 493
 494     case OFPUTIL_OFPAT10_SET_VLAN_PCP:
 495         if (a->vlan_pcp.vlan_pcp & ~7) {
 496             return OFPERR_OFPBAC_BAD_ARGUMENT;
 497         }
 498         ofpact_put_SET_VLAN_PCP(out)->vlan_pcp = a->vlan_pcp.vlan_pcp;
 499         break;
 500
 501     case OFPUTIL_OFPAT10_STRIP_VLAN:
 502         ofpact_put_STRIP_VLAN(out);
 503         break;
 504
 505     case OFPUTIL_OFPAT10_SET_DL_SRC:
 506         memcpy(ofpact_put_SET_ETH_SRC(out)->mac,
 507                ((const struct ofp_action_dl_addr *) a)->dl_addr, ETH_ADDR_LEN);
 508         break;
 509
 510     case OFPUTIL_OFPAT10_SET_DL_DST:
 511         memcpy(ofpact_put_SET_ETH_DST(out)->mac,
 512                ((const struct ofp_action_dl_addr *) a)->dl_addr, ETH_ADDR_LEN);
 513         break;
 514
 515     case OFPUTIL_OFPAT10_SET_NW_SRC:
 516         ofpact_put_SET_IPV4_SRC(out)->ipv4 = a->nw_addr.nw_addr;
 517         break;
 518
 519     case OFPUTIL_OFPAT10_SET_NW_DST:
 520         ofpact_put_SET_IPV4_DST(out)->ipv4 = a->nw_addr.nw_addr;
 521         break;
 522
 523     case OFPUTIL_OFPAT10_SET_NW_TOS:
 524         if (a->nw_tos.nw_tos & ~IP_DSCP_MASK) {
 525             return OFPERR_OFPBAC_BAD_ARGUMENT;
 526         }
 527         ofpact_put_SET_IPV4_DSCP(out)->dscp = a->nw_tos.nw_tos;
 528         break;
 529
 530     case OFPUTIL_OFPAT10_SET_TP_SRC:
 531         ofpact_put_SET_L4_SRC_PORT(out)->port = ntohs(a->tp_port.tp_port);
 532         break;
 533
 534     case OFPUTIL_OFPAT10_SET_TP_DST:
 535         ofpact_put_SET_L4_DST_PORT(out)->port = ntohs(a->tp_port.tp_port);
 536
 537         break;
 538
 539     case OFPUTIL_OFPAT10_ENQUEUE:
 540         error = enqueue_from_openflow10((const struct ofp10_action_enqueue *) a,
 541                                         out);
 542         break;
 543
 544 #define NXAST_ACTION(ENUM, STRUCT, EXTENSIBLE, NAME) case OFPUTIL_##ENUM:
 545 #include "ofp-util.def"
 546         return ofpact_from_nxast(a, code, out);
 547     }
 548
 549     return error;
 550 }
 551
 552 static inline union ofp_action *
 553 action_next(const union ofp_action *a)
 554 {
 555     return ((union ofp_action *) (void *)
 556             ((uint8_t *) a + ntohs(a->header.len)));
 557 }
 558
 559 static inline bool
 560 action_is_valid(const union ofp_action *a, size_t n_actions)
 561 {
 562     uint16_t len = ntohs(a->header.len);
 563     return (!(len % OFP_ACTION_ALIGN)
 564             && len >= sizeof *a
 565             && len / sizeof *a <= n_actions);
 566 }
 567
 568 /* This macro is careful to check for actions with bad lengths. */
 569 #define ACTION_FOR_EACH(ITER, LEFT, ACTIONS, N_ACTIONS)                 \
 570     for ((ITER) = (ACTIONS), (LEFT) = (N_ACTIONS);                      \
 571          (LEFT) > 0 && action_is_valid(ITER, LEFT);                     \
 572          ((LEFT) -= ntohs((ITER)->header.len) / sizeof(union ofp_action), \
 573           (ITER) = action_next(ITER)))
 574
 575 static void
 576 log_bad_action(const union ofp_action *actions, size_t n_actions, size_t ofs,
 577                enum ofperr error)
 578 {
 579     if (!VLOG_DROP_WARN(&rl)) {
 580         struct ds s;
 581
 582         ds_init(&s);
 583         ds_put_hex_dump(&s, actions, n_actions * sizeof *actions, 0, false);
 584         VLOG_WARN("bad action at offset %#zx (%s):\n%s",
 585                   ofs * sizeof *actions, ofperr_get_name(error), ds_cstr(&s));
 586         ds_destroy(&s);
 587     }
 588 }
 589
 590 static enum ofperr
 591 ofpacts_from_openflow(const union ofp_action *in, size_t n_in,
 592                       struct ofpbuf *out,
 593                       enum ofperr (*ofpact_from_openflow)(
 594                           const union ofp_action *a, struct ofpbuf *out))
 595 {
 596     const union ofp_action *a;
 597     size_t left;
 598
 599     ACTION_FOR_EACH (a, left, in, n_in) {
 600         enum ofperr error = ofpact_from_openflow(a, out);
 601         if (error) {
 602             log_bad_action(in, n_in, a - in, error);
 603             return error;
 604         }
 605     }
 606     if (left) {
 607         enum ofperr error = OFPERR_OFPBAC_BAD_LEN;
 608         log_bad_action(in, n_in, n_in - left, error);
 609         return error;
 610     }
 611
 612     ofpact_pad(out);
 613     return 0;
 614 }
 615
 616 static enum ofperr
 617 ofpacts_from_openflow10(const union ofp_action *in, size_t n_in,
 618                         struct ofpbuf *out)
 619 {
 620     return ofpacts_from_openflow(in, n_in, out, ofpact_from_openflow10);
 621 }
 622
 623 static enum ofperr
 624 ofpacts_pull_actions(struct ofpbuf *openflow, unsigned int actions_len,
 625                      struct ofpbuf *ofpacts,
 626                      enum ofperr (*translate)(const union ofp_action *actions,
 627                                               size_t n_actions,
 628                                               struct ofpbuf *ofpacts))
 629 {
 630     static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(1, 5);
 631     const union ofp_action *actions;
 632     enum ofperr error;
 633
 634     ofpbuf_clear(ofpacts);
 635
 636     if (actions_len % OFP_ACTION_ALIGN != 0) {
 637         VLOG_WARN_RL(&rl, "OpenFlow message actions length %u is not a "
 638                      "multiple of %d", actions_len, OFP_ACTION_ALIGN);
 639         return OFPERR_OFPBRC_BAD_LEN;
 640     }
 641
 642     actions = ofpbuf_try_pull(openflow, actions_len);
 643     if (actions == NULL) {
 644         VLOG_WARN_RL(&rl, "OpenFlow message actions length %u exceeds "
 645                      "remaining message length (%zu)",
 646                      actions_len, openflow->size);
 647         return OFPERR_OFPBRC_BAD_LEN;
 648     }
 649
 650     error = translate(actions, actions_len / OFP_ACTION_ALIGN, ofpacts);
 651     if (error) {
 652         ofpbuf_clear(ofpacts);
 653         return error;
 654     }
 655
 656     error = ofpacts_verify(ofpacts->data, ofpacts->size);
 657     if (error) {
 658         ofpbuf_clear(ofpacts);
 659     }
 660     return error;
 661 }
 662
 663 /* Attempts to convert 'actions_len' bytes of OpenFlow 1.0 actions from the
 664  * front of 'openflow' into ofpacts.  On success, replaces any existing content
 665  * in 'ofpacts' by the converted ofpacts; on failure, clears 'ofpacts'.
 666  * Returns 0 if successful, otherwise an OpenFlow error.
 667  *
 668  * The parsed actions are valid generically, but they may not be valid in a
 669  * specific context.  For example, port numbers up to OFPP_MAX are valid
 670  * generically, but specific datapaths may only support port numbers in a
 671  * smaller range.  Use ofpacts_check() to additional check whether actions are
 672  * valid in a specific context. */
 673 enum ofperr
 674 ofpacts_pull_openflow10(struct ofpbuf *openflow, unsigned int actions_len,
 675                         struct ofpbuf *ofpacts)
 676 {
 677     return ofpacts_pull_actions(openflow, actions_len, ofpacts,
 678                                 ofpacts_from_openflow10);
 679 }
 680 \f
 681 /* OpenFlow 1.1 actions. */
 682
 683 /* Parses 'a' to determine its type.  On success stores the correct type into
 684  * '*code' and returns 0.  On failure returns an OFPERR_* error code and
 685  * '*code' is indeterminate.
 686  *
 687  * The caller must have already verified that 'a''s length is potentially
 688  * correct (that is, a->header.len is nonzero and a multiple of sizeof(union
 689  * ofp_action) and no longer than the amount of space allocated to 'a').
 690  *
 691  * This function verifies that 'a''s length is correct for the type of action
 692  * that it represents. */
 693 static enum ofperr
 694 decode_openflow11_action(const union ofp_action *a,
 695                          enum ofputil_action_code *code)
 696 {
 697     uint16_t len;
 698
 699     switch (a->type) {
 700     case CONSTANT_HTONS(OFPAT11_EXPERIMENTER):
 701         return decode_nxast_action(a, code);
 702
 703 #define OFPAT11_ACTION(ENUM, STRUCT, EXTENSIBLE, NAME)  \
 704         case CONSTANT_HTONS(ENUM):                      \
 705             len = ntohs(a->header.len);                 \
 706             if (EXTENSIBLE                              \
 707                 ? len >= sizeof(struct STRUCT)          \
 708                 : len == sizeof(struct STRUCT)) {       \
 709                 *code = OFPUTIL_##ENUM;                 \
 710                 return 0;                               \
 711             } else {                                    \
 712                 return OFPERR_OFPBAC_BAD_LEN;           \
 713             }                                           \
 714             NOT_REACHED();
 715 #include "ofp-util.def"
 716
 717     default:
 718         return OFPERR_OFPBAC_BAD_TYPE;
 719     }
 720 }
 721
 722 static enum ofperr
 723 output_from_openflow11(const struct ofp11_action_output *oao,
 724                        struct ofpbuf *out)
 725 {
 726     struct ofpact_output *output;
 727     enum ofperr error;
 728
 729     output = ofpact_put_OUTPUT(out);
 730     output->max_len = ntohs(oao->max_len);
 731
 732     error = ofputil_port_from_ofp11(oao->port, &output->port);
 733     if (error) {
 734         return error;
 735     }
 736
 737     return ofputil_check_output_port(output->port, OFPP_MAX);
 738 }
 739
 740 static enum ofperr
 741 ofpact_from_openflow11(const union ofp_action *a, struct ofpbuf *out)
 742 {
 743     enum ofputil_action_code code;
 744     enum ofperr error;
 745
 746     error = decode_openflow11_action(a, &code);
 747     if (error) {
 748         return error;
 749     }
 750
 751     switch (code) {
 752     case OFPUTIL_ACTION_INVALID:
 753 #define OFPAT10_ACTION(ENUM, STRUCT, NAME) case OFPUTIL_##ENUM:
 754 #include "ofp-util.def"
 755         NOT_REACHED();
 756
 757     case OFPUTIL_OFPAT11_OUTPUT:
 758         return output_from_openflow11((const struct ofp11_action_output *) a,
 759                                       out);
 760
 761     case OFPUTIL_OFPAT11_SET_VLAN_VID:
 762         if (a->vlan_vid.vlan_vid & ~htons(0xfff)) {
 763             return OFPERR_OFPBAC_BAD_ARGUMENT;
 764         }
 765         ofpact_put_SET_VLAN_VID(out)->vlan_vid = ntohs(a->vlan_vid.vlan_vid);
 766         break;
 767
 768     case OFPUTIL_OFPAT11_SET_VLAN_PCP:
 769         if (a->vlan_pcp.vlan_pcp & ~7) {
 770             return OFPERR_OFPBAC_BAD_ARGUMENT;
 771         }
 772         ofpact_put_SET_VLAN_PCP(out)->vlan_pcp = a->vlan_pcp.vlan_pcp;
 773         break;
 774
 775     case OFPUTIL_OFPAT11_PUSH_VLAN:
 776         if (((const struct ofp11_action_push *)a)->ethertype !=
 777             htons(ETH_TYPE_VLAN_8021Q)) {
 778             /* XXX 802.1AD(QinQ) isn't supported at the moment */
 779             return OFPERR_OFPBAC_BAD_ARGUMENT;
 780         }
 781         ofpact_put_PUSH_VLAN(out);
 782         break;
 783
 784     case OFPUTIL_OFPAT11_POP_VLAN:
 785         ofpact_put_STRIP_VLAN(out);
 786         break;
 787
 788     case OFPUTIL_OFPAT11_SET_QUEUE:
 789         ofpact_put_SET_QUEUE(out)->queue_id =
 790             ntohl(((const struct ofp11_action_set_queue *)a)->queue_id);
 791         break;
 792
 793     case OFPUTIL_OFPAT11_SET_DL_SRC:
 794         memcpy(ofpact_put_SET_ETH_SRC(out)->mac,
 795                ((const struct ofp_action_dl_addr *) a)->dl_addr, ETH_ADDR_LEN);
 796         break;
 797
 798     case OFPUTIL_OFPAT11_SET_DL_DST:
 799         memcpy(ofpact_put_SET_ETH_DST(out)->mac,
 800                ((const struct ofp_action_dl_addr *) a)->dl_addr, ETH_ADDR_LEN);
 801         break;
 802
 803     case OFPUTIL_OFPAT11_DEC_NW_TTL:
 804         dec_ttl_from_openflow(out, code);
 805         break;
 806
 807     case OFPUTIL_OFPAT11_SET_NW_SRC:
 808         ofpact_put_SET_IPV4_SRC(out)->ipv4 = a->nw_addr.nw_addr;
 809         break;
 810
 811     case OFPUTIL_OFPAT11_SET_NW_DST:
 812         ofpact_put_SET_IPV4_DST(out)->ipv4 = a->nw_addr.nw_addr;
 813         break;
 814
 815     case OFPUTIL_OFPAT11_SET_NW_TOS:
 816         if (a->nw_tos.nw_tos & ~IP_DSCP_MASK) {
 817             return OFPERR_OFPBAC_BAD_ARGUMENT;
 818         }
 819         ofpact_put_SET_IPV4_DSCP(out)->dscp = a->nw_tos.nw_tos;
 820         break;
 821
 822     case OFPUTIL_OFPAT11_SET_TP_SRC:
 823         ofpact_put_SET_L4_SRC_PORT(out)->port = ntohs(a->tp_port.tp_port);
 824         break;
 825
 826     case OFPUTIL_OFPAT11_SET_TP_DST:
 827         ofpact_put_SET_L4_DST_PORT(out)->port = ntohs(a->tp_port.tp_port);
 828         break;
 829
 830     case OFPUTIL_OFPAT12_SET_FIELD:
 831         return nxm_reg_load_from_openflow12_set_field(
 832             (const struct ofp12_action_set_field *)a, out);
 833
 834     case OFPUTIL_OFPAT11_SET_MPLS_TTL: {
 835         struct ofp11_action_mpls_ttl *oamt = (struct ofp11_action_mpls_ttl *)a;
 836         ofpact_put_SET_MPLS_TTL(out)->ttl = oamt->mpls_ttl;
 837         break;
 838     }
 839
 840     case OFPUTIL_OFPAT11_DEC_MPLS_TTL:
 841         ofpact_put_DEC_MPLS_TTL(out);
 842         break;
 843
 844     case OFPUTIL_OFPAT11_PUSH_MPLS: {
 845         struct ofp11_action_push *oap = (struct ofp11_action_push *)a;
 846         if (!eth_type_mpls(oap->ethertype)) {
 847             return OFPERR_OFPBAC_BAD_ARGUMENT;
 848         }
 849         ofpact_put_PUSH_MPLS(out)->ethertype = oap->ethertype;
 850         break;
 851     }
 852
 853     case OFPUTIL_OFPAT11_POP_MPLS: {
 854         struct ofp11_action_pop_mpls *oapm = (struct ofp11_action_pop_mpls *)a;
 855         if (eth_type_mpls(oapm->ethertype)) {
 856             return OFPERR_OFPBAC_BAD_ARGUMENT;
 857         }
 858         ofpact_put_POP_MPLS(out)->ethertype = oapm->ethertype;
 859         break;
 860     }
 861
 862 #define NXAST_ACTION(ENUM, STRUCT, EXTENSIBLE, NAME) case OFPUTIL_##ENUM:
 863 #include "ofp-util.def"
 864         return ofpact_from_nxast(a, code, out);
 865     }
 866
 867     return error;
 868 }
 869
 870 static enum ofperr
 871 ofpacts_from_openflow11(const union ofp_action *in, size_t n_in,
 872                         struct ofpbuf *out)
 873 {
 874     return ofpacts_from_openflow(in, n_in, out, ofpact_from_openflow11);
 875 }
 876 \f
 877 /* OpenFlow 1.1 instructions. */
 878
 879 #define DEFINE_INST(ENUM, STRUCT, EXTENSIBLE, NAME)             \
 880     static inline const struct STRUCT *                         \
 881     instruction_get_##ENUM(const struct ofp11_instruction *inst)\
 882     {                                                           \
 883         ovs_assert(inst->type == htons(ENUM));                  \
 884         return (struct STRUCT *)inst;                           \
 885     }                                                           \
 886                                                                 \
 887     static inline void                                          \
 888     instruction_init_##ENUM(struct STRUCT *s)                   \
 889     {                                                           \
 890         memset(s, 0, sizeof *s);                                \
 891         s->type = htons(ENUM);                                  \
 892         s->len = htons(sizeof *s);                              \
 893     }                                                           \
 894                                                                 \
 895     static inline struct STRUCT *                               \
 896     instruction_put_##ENUM(struct ofpbuf *buf)                  \
 897     {                                                           \
 898         struct STRUCT *s = ofpbuf_put_uninit(buf, sizeof *s);   \
 899         instruction_init_##ENUM(s);                             \
 900         return s;                                               \
 901     }
 902 OVS_INSTRUCTIONS
 903 #undef DEFINE_INST
 904
 905 struct instruction_type_info {
 906     enum ovs_instruction_type type;
 907     const char *name;
 908 };
 909
 910 static const struct instruction_type_info inst_info[] = {
 911 #define DEFINE_INST(ENUM, STRUCT, EXTENSIBLE, NAME)    {OVSINST_##ENUM, NAME},
 912 OVS_INSTRUCTIONS
 913 #undef DEFINE_INST
 914 };
 915
 916 const char *
 917 ovs_instruction_name_from_type(enum ovs_instruction_type type)
 918 {
 919     return inst_info[type].name;
 920 }
 921
 922 int
 923 ovs_instruction_type_from_name(const char *name)
 924 {
 925     const struct instruction_type_info *p;
 926     for (p = inst_info; p < &inst_info[ARRAY_SIZE(inst_info)]; p++) {
 927         if (!strcasecmp(name, p->name)) {
 928             return p->type;
 929         }
 930     }
 931     return -1;
 932 }
 933
 934 enum ovs_instruction_type
 935 ovs_instruction_type_from_ofpact_type(enum ofpact_type type)
 936 {
 937     switch (type) {
 938     case OFPACT_METER:
 939         return OVSINST_OFPIT13_METER;
 940     case OFPACT_CLEAR_ACTIONS:
 941         return OVSINST_OFPIT11_CLEAR_ACTIONS;
 942     case OFPACT_WRITE_METADATA:
 943         return OVSINST_OFPIT11_WRITE_METADATA;
 944     case OFPACT_GOTO_TABLE:
 945         return OVSINST_OFPIT11_GOTO_TABLE;
 946     case OFPACT_OUTPUT:
 947     case OFPACT_CONTROLLER:
 948     case OFPACT_ENQUEUE:
 949     case OFPACT_OUTPUT_REG:
 950     case OFPACT_BUNDLE:
 951     case OFPACT_SET_VLAN_VID:
 952     case OFPACT_SET_VLAN_PCP:
 953     case OFPACT_STRIP_VLAN:
 954     case OFPACT_PUSH_VLAN:
 955     case OFPACT_SET_ETH_SRC:
 956     case OFPACT_SET_ETH_DST:
 957     case OFPACT_SET_IPV4_SRC:
 958     case OFPACT_SET_IPV4_DST:
 959     case OFPACT_SET_IPV4_DSCP:
 960     case OFPACT_SET_L4_SRC_PORT:
 961     case OFPACT_SET_L4_DST_PORT:
 962     case OFPACT_REG_MOVE:
 963     case OFPACT_REG_LOAD:
 964     case OFPACT_STACK_PUSH:
 965     case OFPACT_STACK_POP:
 966     case OFPACT_DEC_TTL:
 967     case OFPACT_SET_MPLS_TTL:
 968     case OFPACT_DEC_MPLS_TTL:
 969     case OFPACT_PUSH_MPLS:
 970     case OFPACT_POP_MPLS:
 971     case OFPACT_SET_TUNNEL:
 972     case OFPACT_SET_QUEUE:
 973     case OFPACT_POP_QUEUE:
 974     case OFPACT_FIN_TIMEOUT:
 975     case OFPACT_RESUBMIT:
 976     case OFPACT_LEARN:
 977     case OFPACT_MULTIPATH:
 978     case OFPACT_NOTE:
 979     case OFPACT_EXIT:
 980     case OFPACT_SAMPLE:
 981     default:
 982         return OVSINST_OFPIT11_APPLY_ACTIONS;
 983     }
 984 }
 985
 986 static inline struct ofp11_instruction *
 987 instruction_next(const struct ofp11_instruction *inst)
 988 {
 989     return ((struct ofp11_instruction *) (void *)
 990             ((uint8_t *) inst + ntohs(inst->len)));
 991 }
 992
 993 static inline bool
 994 instruction_is_valid(const struct ofp11_instruction *inst,
 995                      size_t n_instructions)
 996 {
 997     uint16_t len = ntohs(inst->len);
 998     return (!(len % OFP11_INSTRUCTION_ALIGN)
 999             && len >= sizeof *inst
1000             && len / sizeof *inst <= n_instructions);
1001 }
1002
1003 /* This macro is careful to check for instructions with bad lengths. */
1004 #define INSTRUCTION_FOR_EACH(ITER, LEFT, INSTRUCTIONS, N_INSTRUCTIONS)  \
1005     for ((ITER) = (INSTRUCTIONS), (LEFT) = (N_INSTRUCTIONS);            \
1006          (LEFT) > 0 && instruction_is_valid(ITER, LEFT);                \
1007          ((LEFT) -= (ntohs((ITER)->len)                                 \
1008                      / sizeof(struct ofp11_instruction)),               \
1009           (ITER) = instruction_next(ITER)))
1010
1011 static enum ofperr
1012 decode_openflow11_instruction(const struct ofp11_instruction *inst,
1013                               enum ovs_instruction_type *type)
1014 {
1015     uint16_t len = ntohs(inst->len);
1016
1017     switch (inst->type) {
1018     case CONSTANT_HTONS(OFPIT11_EXPERIMENTER):
1019         return OFPERR_OFPBIC_BAD_EXPERIMENTER;
1020
1021 #define DEFINE_INST(ENUM, STRUCT, EXTENSIBLE, NAME)     \
1022         case CONSTANT_HTONS(ENUM):                      \
1023             if (EXTENSIBLE                              \
1024                 ? len >= sizeof(struct STRUCT)          \
1025                 : len == sizeof(struct STRUCT)) {       \
1026                 *type = OVSINST_##ENUM;                 \
1027                 return 0;                               \
1028             } else {                                    \
1029                 return OFPERR_OFPBIC_BAD_LEN;           \
1030             }
1031 OVS_INSTRUCTIONS
1032 #undef DEFINE_INST
1033
1034     default:
1035         return OFPERR_OFPBIC_UNKNOWN_INST;
1036     }
1037 }
1038
1039 static enum ofperr
1040 decode_openflow11_instructions(const struct ofp11_instruction insts[],
1041                                size_t n_insts,
1042                                const struct ofp11_instruction *out[])
1043 {
1044     const struct ofp11_instruction *inst;
1045     size_t left;
1046
1047     memset(out, 0, N_OVS_INSTRUCTIONS * sizeof *out);
1048     INSTRUCTION_FOR_EACH (inst, left, insts, n_insts) {
1049         enum ovs_instruction_type type;
1050         enum ofperr error;
1051
1052         error = decode_openflow11_instruction(inst, &type);
1053         if (error) {
1054             return error;
1055         }
1056
1057         if (out[type]) {
1058             return OFPERR_ONFBIC_DUP_INSTRUCTION;
1059         }
1060         out[type] = inst;
1061     }
1062
1063     if (left) {
1064         VLOG_WARN_RL(&rl, "bad instruction format at offset %zu",
1065                      (n_insts - left) * sizeof *inst);
1066         return OFPERR_OFPBIC_BAD_LEN;
1067     }
1068     return 0;
1069 }
1070
1071 static void
1072 get_actions_from_instruction(const struct ofp11_instruction *inst,
1073                          const union ofp_action **actions,
1074                          size_t *n_actions)
1075 {
1076     *actions = (const union ofp_action *) (inst + 1);
1077     *n_actions = (ntohs(inst->len) - sizeof *inst) / OFP11_INSTRUCTION_ALIGN;
1078 }
1079
1080 /* Attempts to convert 'actions_len' bytes of OpenFlow 1.1 actions from the
1081  * front of 'openflow' into ofpacts.  On success, replaces any existing content
1082  * in 'ofpacts' by the converted ofpacts; on failure, clears 'ofpacts'.
1083  * Returns 0 if successful, otherwise an OpenFlow error.
1084  *
1085  * In most places in OpenFlow 1.1 and 1.2, actions appear encapsulated in
1086  * instructions, so you should call ofpacts_pull_openflow11_instructions()
1087  * instead of this function.
1088  *
1089  * The parsed actions are valid generically, but they may not be valid in a
1090  * specific context.  For example, port numbers up to OFPP_MAX are valid
1091  * generically, but specific datapaths may only support port numbers in a
1092  * smaller range.  Use ofpacts_check() to additional check whether actions are
1093  * valid in a specific context. */
1094 enum ofperr
1095 ofpacts_pull_openflow11_actions(struct ofpbuf *openflow,
1096                                 unsigned int actions_len,
1097                                 struct ofpbuf *ofpacts)
1098 {
1099     return ofpacts_pull_actions(openflow, actions_len, ofpacts,
1100                                 ofpacts_from_openflow11);
1101 }
1102
1103 enum ofperr
1104 ofpacts_pull_openflow11_instructions(struct ofpbuf *openflow,
1105                                      unsigned int instructions_len,
1106                                      uint8_t table_id,
1107                                      struct ofpbuf *ofpacts)
1108 {
1109     static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(1, 5);
1110     const struct ofp11_instruction *instructions;
1111     const struct ofp11_instruction *insts[N_OVS_INSTRUCTIONS];
1112     enum ofperr error;
1113
1114     ofpbuf_clear(ofpacts);
1115
1116     if (instructions_len % OFP11_INSTRUCTION_ALIGN != 0) {
1117         VLOG_WARN_RL(&rl, "OpenFlow message instructions length %u is not a "
1118                      "multiple of %d",
1119                      instructions_len, OFP11_INSTRUCTION_ALIGN);
1120         error = OFPERR_OFPBIC_BAD_LEN;
1121         goto exit;
1122     }
1123
1124     instructions = ofpbuf_try_pull(openflow, instructions_len);
1125     if (instructions == NULL) {
1126         VLOG_WARN_RL(&rl, "OpenFlow message instructions length %u exceeds "
1127                      "remaining message length (%zu)",
1128                      instructions_len, openflow->size);
1129         error = OFPERR_OFPBIC_BAD_LEN;
1130         goto exit;
1131     }
1132
1133     error = decode_openflow11_instructions(
1134         instructions, instructions_len / OFP11_INSTRUCTION_ALIGN,
1135         insts);
1136     if (error) {
1137         goto exit;
1138     }
1139
1140     if (insts[OVSINST_OFPIT13_METER]) {
1141         const struct ofp13_instruction_meter *oim;
1142         struct ofpact_meter *om;
1143
1144         oim = (const struct ofp13_instruction_meter *)
1145             insts[OVSINST_OFPIT13_METER];
1146
1147         om = ofpact_put_METER(ofpacts);
1148         om->meter_id = ntohl(oim->meter_id);
1149     }
1150     if (insts[OVSINST_OFPIT11_APPLY_ACTIONS]) {
1151         const union ofp_action *actions;
1152         size_t n_actions;
1153
1154         get_actions_from_instruction(insts[OVSINST_OFPIT11_APPLY_ACTIONS],
1155                                      &actions, &n_actions);
1156         error = ofpacts_from_openflow11(actions, n_actions, ofpacts);
1157         if (error) {
1158             goto exit;
1159         }
1160     }
1161     if (insts[OVSINST_OFPIT11_CLEAR_ACTIONS]) {
1162         instruction_get_OFPIT11_CLEAR_ACTIONS(
1163             insts[OVSINST_OFPIT11_CLEAR_ACTIONS]);
1164         ofpact_put_CLEAR_ACTIONS(ofpacts);
1165     }
1166     /* XXX Write-Actions */
1167     if (insts[OVSINST_OFPIT11_WRITE_METADATA]) {
1168         const struct ofp11_instruction_write_metadata *oiwm;
1169         struct ofpact_metadata *om;
1170
1171         oiwm = (const struct ofp11_instruction_write_metadata *)
1172             insts[OVSINST_OFPIT11_WRITE_METADATA];
1173
1174         om = ofpact_put_WRITE_METADATA(ofpacts);
1175         om->metadata = oiwm->metadata;
1176         om->mask = oiwm->metadata_mask;
1177     }
1178     if (insts[OVSINST_OFPIT11_GOTO_TABLE]) {
1179         const struct ofp11_instruction_goto_table *oigt;
1180         struct ofpact_goto_table *ogt;
1181
1182         oigt = instruction_get_OFPIT11_GOTO_TABLE(
1183             insts[OVSINST_OFPIT11_GOTO_TABLE]);
1184         if (table_id >= oigt->table_id) {
1185             error = OFPERR_OFPBRC_BAD_TABLE_ID;
1186             goto exit;
1187         }
1188         ogt = ofpact_put_GOTO_TABLE(ofpacts);
1189         ogt->table_id = oigt->table_id;
1190     }
1191
1192     if (insts[OVSINST_OFPIT11_WRITE_ACTIONS]) {
1193         error = OFPERR_OFPBIC_UNSUP_INST;
1194         goto exit;
1195     }
1196
1197     error = ofpacts_verify(ofpacts->data, ofpacts->size);
1198 exit:
1199     if (error) {
1200         ofpbuf_clear(ofpacts);
1201     }
1202     return error;
1203 }
1204 \f
1205 /* May modify flow->dl_type, caller must restore it. */
1206 static enum ofperr
1207 ofpact_check__(const struct ofpact *a, struct flow *flow, ofp_port_t max_ports)
1208 {
1209     const struct ofpact_enqueue *enqueue;
1210
1211     switch (a->type) {
1212     case OFPACT_OUTPUT:
1213         return ofputil_check_output_port(ofpact_get_OUTPUT(a)->port,
1214                                          max_ports);
1215
1216     case OFPACT_CONTROLLER:
1217         return 0;
1218
1219     case OFPACT_ENQUEUE:
1220         enqueue = ofpact_get_ENQUEUE(a);
1221         if (ofp_to_u16(enqueue->port) >= ofp_to_u16(max_ports)
1222             && enqueue->port != OFPP_IN_PORT
1223             && enqueue->port != OFPP_LOCAL) {
1224             return OFPERR_OFPBAC_BAD_OUT_PORT;
1225         }
1226         return 0;
1227
1228     case OFPACT_OUTPUT_REG:
1229         return mf_check_src(&ofpact_get_OUTPUT_REG(a)->src, flow);
1230
1231     case OFPACT_BUNDLE:
1232         return bundle_check(ofpact_get_BUNDLE(a), max_ports, flow);
1233
1234     case OFPACT_SET_VLAN_VID:
1235     case OFPACT_SET_VLAN_PCP:
1236     case OFPACT_STRIP_VLAN:
1237     case OFPACT_PUSH_VLAN:
1238     case OFPACT_SET_ETH_SRC:
1239     case OFPACT_SET_ETH_DST:
1240     case OFPACT_SET_IPV4_SRC:
1241     case OFPACT_SET_IPV4_DST:
1242     case OFPACT_SET_IPV4_DSCP:
1243     case OFPACT_SET_L4_SRC_PORT:
1244     case OFPACT_SET_L4_DST_PORT:
1245         return 0;
1246
1247     case OFPACT_REG_MOVE:
1248         return nxm_reg_move_check(ofpact_get_REG_MOVE(a), flow);
1249
1250     case OFPACT_REG_LOAD:
1251         return nxm_reg_load_check(ofpact_get_REG_LOAD(a), flow);
1252
1253     case OFPACT_STACK_PUSH:
1254         return nxm_stack_push_check(ofpact_get_STACK_PUSH(a), flow);
1255
1256     case OFPACT_STACK_POP:
1257         return nxm_stack_pop_check(ofpact_get_STACK_POP(a), flow);
1258
1259     case OFPACT_DEC_TTL:
1260     case OFPACT_SET_MPLS_TTL:
1261     case OFPACT_DEC_MPLS_TTL:
1262     case OFPACT_SET_TUNNEL:
1263     case OFPACT_SET_QUEUE:
1264     case OFPACT_POP_QUEUE:
1265     case OFPACT_FIN_TIMEOUT:
1266     case OFPACT_RESUBMIT:
1267         return 0;
1268
1269     case OFPACT_LEARN:
1270         return learn_check(ofpact_get_LEARN(a), flow);
1271
1272     case OFPACT_MULTIPATH:
1273         return multipath_check(ofpact_get_MULTIPATH(a), flow);
1274
1275     case OFPACT_NOTE:
1276     case OFPACT_EXIT:
1277         return 0;
1278
1279     case OFPACT_PUSH_MPLS:
1280         flow->dl_type = ofpact_get_PUSH_MPLS(a)->ethertype;
1281         return 0;
1282
1283     case OFPACT_POP_MPLS:
1284         flow->dl_type = ofpact_get_POP_MPLS(a)->ethertype;
1285         return 0;
1286
1287     case OFPACT_SAMPLE:
1288         return 0;
1289
1290     case OFPACT_CLEAR_ACTIONS:
1291     case OFPACT_WRITE_METADATA:
1292     case OFPACT_GOTO_TABLE:
1293         return 0;
1294
1295     case OFPACT_METER: {
1296         uint32_t mid = ofpact_get_METER(a)->meter_id;
1297         if (mid == 0 || mid > OFPM13_MAX) {
1298             return OFPERR_OFPMMFC_INVALID_METER;
1299         }
1300         return 0;
1301     }
1302     default:
1303         NOT_REACHED();
1304     }
1305 }
1306
1307 /* Checks that the 'ofpacts_len' bytes of actions in 'ofpacts' are
1308  * appropriate for a packet with the prerequisites satisfied by 'flow' in a
1309  * switch with no more than 'max_ports' ports.
1310  *
1311  * May temporarily modify 'flow', but restores the changes before returning. */
1312 enum ofperr
1313 ofpacts_check(const struct ofpact ofpacts[], size_t ofpacts_len,
1314               struct flow *flow, ofp_port_t max_ports)
1315 {
1316     const struct ofpact *a;
1317     ovs_be16 dl_type = flow->dl_type;
1318     enum ofperr error = 0;
1319
1320     OFPACT_FOR_EACH (a, ofpacts, ofpacts_len) {
1321         error = ofpact_check__(a, flow, max_ports);
1322         if (error) {
1323             break;
1324         }
1325     }
1326     flow->dl_type = dl_type; /* Restore. */
1327     return error;
1328 }
1329
1330 /* Verifies that the 'ofpacts_len' bytes of actions in 'ofpacts' are
1331  * in the appropriate order as defined by the OpenFlow spec. */
1332 enum ofperr
1333 ofpacts_verify(const struct ofpact ofpacts[], size_t ofpacts_len)
1334 {
1335     const struct ofpact *a;
1336     enum ovs_instruction_type inst;
1337
1338     inst = OVSINST_OFPIT11_APPLY_ACTIONS;
1339     OFPACT_FOR_EACH (a, ofpacts, ofpacts_len) {
1340         enum ovs_instruction_type next;
1341
1342         next = ovs_instruction_type_from_ofpact_type(a->type);
1343         if (inst != OVSINST_OFPIT11_APPLY_ACTIONS && next <= inst) {
1344             const char *name = ovs_instruction_name_from_type(inst);
1345             const char *next_name = ovs_instruction_name_from_type(next);
1346
1347             if (next == inst) {
1348                 VLOG_WARN("duplicate %s instruction not allowed, for OpenFlow "
1349                           "1.1+ compatibility", name);
1350             } else {
1351                 VLOG_WARN("invalid instruction ordering: %s must appear "
1352                           "before %s, for OpenFlow 1.1+ compatibility",
1353                           next_name, name);
1354             }
1355             return OFPERR_OFPBAC_UNSUPPORTED_ORDER;
1356         }
1357
1358         inst = next;
1359     }
1360
1361     return 0;
1362 }
1363 \f
1364 /* Converting ofpacts to Nicira OpenFlow extensions. */
1365
1366 static void
1367 ofpact_output_reg_to_nxast(const struct ofpact_output_reg *output_reg,
1368                                 struct ofpbuf *out)
1369 {
1370     struct nx_action_output_reg *naor = ofputil_put_NXAST_OUTPUT_REG(out);
1371
1372     naor->ofs_nbits = nxm_encode_ofs_nbits(output_reg->src.ofs,
1373                                            output_reg->src.n_bits);
1374     naor->src = htonl(output_reg->src.field->nxm_header);
1375     naor->max_len = htons(output_reg->max_len);
1376 }
1377
1378 static void
1379 ofpact_resubmit_to_nxast(const struct ofpact_resubmit *resubmit,
1380                          struct ofpbuf *out)
1381 {
1382     struct nx_action_resubmit *nar;
1383
1384     if (resubmit->table_id == 0xff
1385         && resubmit->ofpact.compat != OFPUTIL_NXAST_RESUBMIT_TABLE) {
1386         nar = ofputil_put_NXAST_RESUBMIT(out);
1387     } else {
1388         nar = ofputil_put_NXAST_RESUBMIT_TABLE(out);
1389         nar->table = resubmit->table_id;
1390     }
1391     nar->in_port = htons(ofp_to_u16(resubmit->in_port));
1392 }
1393
1394 static void
1395 ofpact_set_tunnel_to_nxast(const struct ofpact_tunnel *tunnel,
1396                            struct ofpbuf *out)
1397 {
1398     uint64_t tun_id = tunnel->tun_id;
1399
1400     if (tun_id <= UINT32_MAX
1401         && tunnel->ofpact.compat != OFPUTIL_NXAST_SET_TUNNEL64) {
1402         ofputil_put_NXAST_SET_TUNNEL(out)->tun_id = htonl(tun_id);
1403     } else {
1404         ofputil_put_NXAST_SET_TUNNEL64(out)->tun_id = htonll(tun_id);
1405     }
1406 }
1407
1408 static void
1409 ofpact_write_metadata_to_nxast(const struct ofpact_metadata *om,
1410                                struct ofpbuf *out)
1411 {
1412     struct nx_action_write_metadata *nawm;
1413
1414     nawm = ofputil_put_NXAST_WRITE_METADATA(out);
1415     nawm->metadata = om->metadata;
1416     nawm->mask = om->mask;
1417 }
1418
1419 static void
1420 ofpact_note_to_nxast(const struct ofpact_note *note, struct ofpbuf *out)
1421 {
1422     size_t start_ofs = out->size;
1423     struct nx_action_note *nan;
1424     unsigned int remainder;
1425     unsigned int len;
1426
1427     nan = ofputil_put_NXAST_NOTE(out);
1428     out->size -= sizeof nan->note;
1429
1430     ofpbuf_put(out, note->data, note->length);
1431
1432     len = out->size - start_ofs;
1433     remainder = len % OFP_ACTION_ALIGN;
1434     if (remainder) {
1435         ofpbuf_put_zeros(out, OFP_ACTION_ALIGN - remainder);
1436     }
1437     nan = (struct nx_action_note *)((char *)out->data + start_ofs);
1438     nan->len = htons(out->size - start_ofs);
1439 }
1440
1441 static void
1442 ofpact_controller_to_nxast(const struct ofpact_controller *oc,
1443                            struct ofpbuf *out)
1444 {
1445     struct nx_action_controller *nac;
1446
1447     nac = ofputil_put_NXAST_CONTROLLER(out);
1448     nac->max_len = htons(oc->max_len);
1449     nac->controller_id = htons(oc->controller_id);
1450     nac->reason = oc->reason;
1451 }
1452
1453 static void
1454 ofpact_dec_ttl_to_nxast(const struct ofpact_cnt_ids *oc_ids,
1455                         struct ofpbuf *out)
1456 {
1457     if (oc_ids->ofpact.compat == OFPUTIL_NXAST_DEC_TTL) {
1458         ofputil_put_NXAST_DEC_TTL(out);
1459     } else {
1460         struct nx_action_cnt_ids *nac_ids =
1461             ofputil_put_NXAST_DEC_TTL_CNT_IDS(out);
1462         int ids_len = ROUND_UP(2 * oc_ids->n_controllers, OFP_ACTION_ALIGN);
1463         ovs_be16 *ids;
1464         size_t i;
1465
1466         nac_ids->len = htons(ntohs(nac_ids->len) + ids_len);
1467         nac_ids->n_controllers = htons(oc_ids->n_controllers);
1468
1469         ids = ofpbuf_put_zeros(out, ids_len);
1470         for (i = 0; i < oc_ids->n_controllers; i++) {
1471             ids[i] = htons(oc_ids->cnt_ids[i]);
1472         }
1473     }
1474 }
1475
1476 static void
1477 ofpact_fin_timeout_to_nxast(const struct ofpact_fin_timeout *fin_timeout,
1478                             struct ofpbuf *out)
1479 {
1480     struct nx_action_fin_timeout *naft = ofputil_put_NXAST_FIN_TIMEOUT(out);
1481     naft->fin_idle_timeout = htons(fin_timeout->fin_idle_timeout);
1482     naft->fin_hard_timeout = htons(fin_timeout->fin_hard_timeout);
1483 }
1484
1485 static void
1486 ofpact_sample_to_nxast(const struct ofpact_sample *os,
1487                        struct ofpbuf *out)
1488 {
1489     struct nx_action_sample *nas;
1490
1491     nas = ofputil_put_NXAST_SAMPLE(out);
1492     nas->probability = htons(os->probability);
1493     nas->collector_set_id = htonl(os->collector_set_id);
1494     nas->obs_domain_id = htonl(os->obs_domain_id);
1495     nas->obs_point_id = htonl(os->obs_point_id);
1496 }
1497
1498 static void
1499 ofpact_to_nxast(const struct ofpact *a, struct ofpbuf *out)
1500 {
1501     switch (a->type) {
1502     case OFPACT_CONTROLLER:
1503         ofpact_controller_to_nxast(ofpact_get_CONTROLLER(a), out);
1504         break;
1505
1506     case OFPACT_OUTPUT_REG:
1507         ofpact_output_reg_to_nxast(ofpact_get_OUTPUT_REG(a), out);
1508         break;
1509
1510     case OFPACT_BUNDLE:
1511         bundle_to_nxast(ofpact_get_BUNDLE(a), out);
1512         break;
1513
1514     case OFPACT_REG_MOVE:
1515         nxm_reg_move_to_nxast(ofpact_get_REG_MOVE(a), out);
1516         break;
1517
1518     case OFPACT_REG_LOAD:
1519         nxm_reg_load_to_nxast(ofpact_get_REG_LOAD(a), out);
1520         break;
1521
1522     case OFPACT_STACK_PUSH:
1523         nxm_stack_push_to_nxast(ofpact_get_STACK_PUSH(a), out);
1524         break;
1525
1526     case OFPACT_STACK_POP:
1527         nxm_stack_pop_to_nxast(ofpact_get_STACK_POP(a), out);
1528         break;
1529
1530     case OFPACT_DEC_TTL:
1531         ofpact_dec_ttl_to_nxast(ofpact_get_DEC_TTL(a), out);
1532         break;
1533
1534     case OFPACT_SET_MPLS_TTL:
1535         ofputil_put_NXAST_SET_MPLS_TTL(out)->ttl
1536             = ofpact_get_SET_MPLS_TTL(a)->ttl;
1537         break;
1538
1539     case OFPACT_DEC_MPLS_TTL:
1540         ofputil_put_NXAST_DEC_MPLS_TTL(out);
1541         break;
1542
1543     case OFPACT_SET_TUNNEL:
1544         ofpact_set_tunnel_to_nxast(ofpact_get_SET_TUNNEL(a), out);
1545         break;
1546
1547     case OFPACT_WRITE_METADATA:
1548         ofpact_write_metadata_to_nxast(ofpact_get_WRITE_METADATA(a), out);
1549         break;
1550
1551     case OFPACT_SET_QUEUE:
1552         ofputil_put_NXAST_SET_QUEUE(out)->queue_id
1553             = htonl(ofpact_get_SET_QUEUE(a)->queue_id);
1554         break;
1555
1556     case OFPACT_POP_QUEUE:
1557         ofputil_put_NXAST_POP_QUEUE(out);
1558         break;
1559
1560     case OFPACT_FIN_TIMEOUT:
1561         ofpact_fin_timeout_to_nxast(ofpact_get_FIN_TIMEOUT(a), out);
1562         break;
1563
1564     case OFPACT_RESUBMIT:
1565         ofpact_resubmit_to_nxast(ofpact_get_RESUBMIT(a), out);
1566         break;
1567
1568     case OFPACT_LEARN:
1569         learn_to_nxast(ofpact_get_LEARN(a), out);
1570         break;
1571
1572     case OFPACT_MULTIPATH:
1573         multipath_to_nxast(ofpact_get_MULTIPATH(a), out);
1574         break;
1575
1576     case OFPACT_NOTE:
1577         ofpact_note_to_nxast(ofpact_get_NOTE(a), out);
1578         break;
1579
1580     case OFPACT_EXIT:
1581         ofputil_put_NXAST_EXIT(out);
1582         break;
1583
1584     case OFPACT_PUSH_MPLS:
1585         ofputil_put_NXAST_PUSH_MPLS(out)->ethertype =
1586             ofpact_get_PUSH_MPLS(a)->ethertype;
1587         break;
1588
1589     case OFPACT_POP_MPLS:
1590         ofputil_put_NXAST_POP_MPLS(out)->ethertype =
1591             ofpact_get_POP_MPLS(a)->ethertype;
1592         break;
1593
1594     case OFPACT_SAMPLE:
1595         ofpact_sample_to_nxast(ofpact_get_SAMPLE(a), out);
1596         break;
1597
1598     case OFPACT_OUTPUT:
1599     case OFPACT_ENQUEUE:
1600     case OFPACT_SET_VLAN_VID:
1601     case OFPACT_SET_VLAN_PCP:
1602     case OFPACT_STRIP_VLAN:
1603     case OFPACT_PUSH_VLAN:
1604     case OFPACT_SET_ETH_SRC:
1605     case OFPACT_SET_ETH_DST:
1606     case OFPACT_SET_IPV4_SRC:
1607     case OFPACT_SET_IPV4_DST:
1608     case OFPACT_SET_IPV4_DSCP:
1609     case OFPACT_SET_L4_SRC_PORT:
1610     case OFPACT_SET_L4_DST_PORT:
1611     case OFPACT_CLEAR_ACTIONS:
1612     case OFPACT_GOTO_TABLE:
1613     case OFPACT_METER:
1614         NOT_REACHED();
1615     }
1616 }
1617 \f
1618 /* Converting ofpacts to OpenFlow 1.0. */
1619
1620 static void
1621 ofpact_output_to_openflow10(const struct ofpact_output *output,
1622                             struct ofpbuf *out)
1623 {
1624     struct ofp10_action_output *oao;
1625
1626     oao = ofputil_put_OFPAT10_OUTPUT(out);
1627     oao->port = htons(ofp_to_u16(output->port));
1628     oao->max_len = htons(output->max_len);
1629 }
1630
1631 static void
1632 ofpact_enqueue_to_openflow10(const struct ofpact_enqueue *enqueue,
1633                              struct ofpbuf *out)
1634 {
1635     struct ofp10_action_enqueue *oae;
1636
1637     oae = ofputil_put_OFPAT10_ENQUEUE(out);
1638     oae->port = htons(ofp_to_u16(enqueue->port));
1639     oae->queue_id = htonl(enqueue->queue);
1640 }
1641
1642 static void
1643 ofpact_to_openflow10(const struct ofpact *a, struct ofpbuf *out)
1644 {
1645     switch (a->type) {
1646     case OFPACT_OUTPUT:
1647         ofpact_output_to_openflow10(ofpact_get_OUTPUT(a), out);
1648         break;
1649
1650     case OFPACT_ENQUEUE:
1651         ofpact_enqueue_to_openflow10(ofpact_get_ENQUEUE(a), out);
1652         break;
1653
1654     case OFPACT_SET_VLAN_VID:
1655         ofputil_put_OFPAT10_SET_VLAN_VID(out)->vlan_vid
1656             = htons(ofpact_get_SET_VLAN_VID(a)->vlan_vid);
1657         break;
1658
1659     case OFPACT_SET_VLAN_PCP:
1660         ofputil_put_OFPAT10_SET_VLAN_PCP(out)->vlan_pcp
1661             = ofpact_get_SET_VLAN_PCP(a)->vlan_pcp;
1662         break;
1663
1664     case OFPACT_STRIP_VLAN:
1665         ofputil_put_OFPAT10_STRIP_VLAN(out);
1666         break;
1667
1668     case OFPACT_SET_ETH_SRC:
1669         memcpy(ofputil_put_OFPAT10_SET_DL_SRC(out)->dl_addr,
1670                ofpact_get_SET_ETH_SRC(a)->mac, ETH_ADDR_LEN);
1671         break;
1672
1673     case OFPACT_SET_ETH_DST:
1674         memcpy(ofputil_put_OFPAT10_SET_DL_DST(out)->dl_addr,
1675                ofpact_get_SET_ETH_DST(a)->mac, ETH_ADDR_LEN);
1676         break;
1677
1678     case OFPACT_SET_IPV4_SRC:
1679         ofputil_put_OFPAT10_SET_NW_SRC(out)->nw_addr
1680             = ofpact_get_SET_IPV4_SRC(a)->ipv4;
1681         break;
1682
1683     case OFPACT_SET_IPV4_DST:
1684         ofputil_put_OFPAT10_SET_NW_DST(out)->nw_addr
1685             = ofpact_get_SET_IPV4_DST(a)->ipv4;
1686         break;
1687
1688     case OFPACT_SET_IPV4_DSCP:
1689         ofputil_put_OFPAT10_SET_NW_TOS(out)->nw_tos
1690             = ofpact_get_SET_IPV4_DSCP(a)->dscp;
1691         break;
1692
1693     case OFPACT_SET_L4_SRC_PORT:
1694         ofputil_put_OFPAT10_SET_TP_SRC(out)->tp_port
1695             = htons(ofpact_get_SET_L4_SRC_PORT(a)->port);
1696         break;
1697
1698     case OFPACT_SET_L4_DST_PORT:
1699         ofputil_put_OFPAT10_SET_TP_DST(out)->tp_port
1700             = htons(ofpact_get_SET_L4_DST_PORT(a)->port);
1701         break;
1702
1703     case OFPACT_PUSH_VLAN:
1704     case OFPACT_CLEAR_ACTIONS:
1705     case OFPACT_GOTO_TABLE:
1706     case OFPACT_METER:
1707         /* XXX */
1708         break;
1709
1710     case OFPACT_CONTROLLER:
1711     case OFPACT_OUTPUT_REG:
1712     case OFPACT_BUNDLE:
1713     case OFPACT_REG_MOVE:
1714     case OFPACT_REG_LOAD:
1715     case OFPACT_STACK_PUSH:
1716     case OFPACT_STACK_POP:
1717     case OFPACT_DEC_TTL:
1718     case OFPACT_SET_MPLS_TTL:
1719     case OFPACT_DEC_MPLS_TTL:
1720     case OFPACT_SET_TUNNEL:
1721     case OFPACT_WRITE_METADATA:
1722     case OFPACT_SET_QUEUE:
1723     case OFPACT_POP_QUEUE:
1724     case OFPACT_FIN_TIMEOUT:
1725     case OFPACT_RESUBMIT:
1726     case OFPACT_LEARN:
1727     case OFPACT_MULTIPATH:
1728     case OFPACT_NOTE:
1729     case OFPACT_EXIT:
1730     case OFPACT_PUSH_MPLS:
1731     case OFPACT_POP_MPLS:
1732     case OFPACT_SAMPLE:
1733         ofpact_to_nxast(a, out);
1734         break;
1735     }
1736 }
1737
1738 /* Converts the 'ofpacts_len' bytes of ofpacts in 'ofpacts' into OpenFlow 1.0
1739  * actions in 'openflow', appending the actions to any existing data in
1740  * 'openflow'. */
1741 void
1742 ofpacts_put_openflow10(const struct ofpact ofpacts[], size_t ofpacts_len,
1743                        struct ofpbuf *openflow)
1744 {
1745     const struct ofpact *a;
1746
1747     OFPACT_FOR_EACH (a, ofpacts, ofpacts_len) {
1748         ofpact_to_openflow10(a, openflow);
1749     }
1750 }
1751 \f
1752 /* Converting ofpacts to OpenFlow 1.1. */
1753
1754 static void
1755 ofpact_output_to_openflow11(const struct ofpact_output *output,
1756                             struct ofpbuf *out)
1757 {
1758     struct ofp11_action_output *oao;
1759
1760     oao = ofputil_put_OFPAT11_OUTPUT(out);
1761     oao->port = ofputil_port_to_ofp11(output->port);
1762     oao->max_len = htons(output->max_len);
1763 }
1764
1765 static void
1766 ofpact_dec_ttl_to_openflow11(const struct ofpact_cnt_ids *dec_ttl,
1767                              struct ofpbuf *out)
1768 {
1769     if (dec_ttl->n_controllers == 1 && dec_ttl->cnt_ids[0] == 0
1770         && (!dec_ttl->ofpact.compat ||
1771             dec_ttl->ofpact.compat == OFPUTIL_OFPAT11_DEC_NW_TTL)) {
1772         ofputil_put_OFPAT11_DEC_NW_TTL(out);
1773     } else {
1774         ofpact_dec_ttl_to_nxast(dec_ttl, out);
1775     }
1776 }
1777
1778 static void
1779 ofpact_to_openflow11(const struct ofpact *a, struct ofpbuf *out)
1780 {
1781     switch (a->type) {
1782     case OFPACT_OUTPUT:
1783         return ofpact_output_to_openflow11(ofpact_get_OUTPUT(a), out);
1784
1785     case OFPACT_ENQUEUE:
1786         /* XXX */
1787         break;
1788
1789     case OFPACT_SET_VLAN_VID:
1790         ofputil_put_OFPAT11_SET_VLAN_VID(out)->vlan_vid
1791             = htons(ofpact_get_SET_VLAN_VID(a)->vlan_vid);
1792         break;
1793
1794     case OFPACT_SET_VLAN_PCP:
1795         ofputil_put_OFPAT11_SET_VLAN_PCP(out)->vlan_pcp
1796             = ofpact_get_SET_VLAN_PCP(a)->vlan_pcp;
1797         break;
1798
1799     case OFPACT_STRIP_VLAN:
1800         ofputil_put_OFPAT11_POP_VLAN(out);
1801         break;
1802
1803     case OFPACT_PUSH_VLAN:
1804         /* XXX ETH_TYPE_VLAN_8021AD case */
1805         ofputil_put_OFPAT11_PUSH_VLAN(out)->ethertype =
1806             htons(ETH_TYPE_VLAN_8021Q);
1807         break;
1808
1809     case OFPACT_SET_QUEUE:
1810         ofputil_put_OFPAT11_SET_QUEUE(out)->queue_id
1811             = htonl(ofpact_get_SET_QUEUE(a)->queue_id);
1812         break;
1813
1814     case OFPACT_SET_ETH_SRC:
1815         memcpy(ofputil_put_OFPAT11_SET_DL_SRC(out)->dl_addr,
1816                ofpact_get_SET_ETH_SRC(a)->mac, ETH_ADDR_LEN);
1817         break;
1818
1819     case OFPACT_SET_ETH_DST:
1820         memcpy(ofputil_put_OFPAT11_SET_DL_DST(out)->dl_addr,
1821                ofpact_get_SET_ETH_DST(a)->mac, ETH_ADDR_LEN);
1822         break;
1823
1824     case OFPACT_SET_IPV4_SRC:
1825         ofputil_put_OFPAT11_SET_NW_SRC(out)->nw_addr
1826             = ofpact_get_SET_IPV4_SRC(a)->ipv4;
1827         break;
1828
1829     case OFPACT_SET_IPV4_DST:
1830         ofputil_put_OFPAT11_SET_NW_DST(out)->nw_addr
1831             = ofpact_get_SET_IPV4_DST(a)->ipv4;
1832         break;
1833
1834     case OFPACT_SET_IPV4_DSCP:
1835         ofputil_put_OFPAT11_SET_NW_TOS(out)->nw_tos
1836             = ofpact_get_SET_IPV4_DSCP(a)->dscp;
1837         break;
1838
1839     case OFPACT_SET_L4_SRC_PORT:
1840         ofputil_put_OFPAT11_SET_TP_SRC(out)->tp_port
1841             = htons(ofpact_get_SET_L4_SRC_PORT(a)->port);
1842         break;
1843
1844     case OFPACT_SET_L4_DST_PORT:
1845         ofputil_put_OFPAT11_SET_TP_DST(out)->tp_port
1846             = htons(ofpact_get_SET_L4_DST_PORT(a)->port);
1847         break;
1848
1849     case OFPACT_DEC_TTL:
1850         ofpact_dec_ttl_to_openflow11(ofpact_get_DEC_TTL(a), out);
1851         break;
1852
1853     case OFPACT_SET_MPLS_TTL:
1854         ofputil_put_OFPAT11_SET_MPLS_TTL(out)->mpls_ttl
1855             = ofpact_get_SET_MPLS_TTL(a)->ttl;
1856         break;
1857
1858     case OFPACT_DEC_MPLS_TTL:
1859         ofputil_put_OFPAT11_DEC_MPLS_TTL(out);
1860         break;
1861
1862     case OFPACT_WRITE_METADATA:
1863         /* OpenFlow 1.1 uses OFPIT_WRITE_METADATA to express this action. */
1864         break;
1865
1866     case OFPACT_PUSH_MPLS:
1867         ofputil_put_OFPAT11_PUSH_MPLS(out)->ethertype =
1868             ofpact_get_PUSH_MPLS(a)->ethertype;
1869         break;
1870
1871     case OFPACT_POP_MPLS:
1872         ofputil_put_OFPAT11_POP_MPLS(out)->ethertype =
1873             ofpact_get_POP_MPLS(a)->ethertype;
1874
1875         break;
1876
1877     case OFPACT_CLEAR_ACTIONS:
1878     case OFPACT_GOTO_TABLE:
1879     case OFPACT_METER:
1880         NOT_REACHED();
1881
1882     case OFPACT_CONTROLLER:
1883     case OFPACT_OUTPUT_REG:
1884     case OFPACT_BUNDLE:
1885     case OFPACT_REG_MOVE:
1886     case OFPACT_REG_LOAD:
1887     case OFPACT_STACK_PUSH:
1888     case OFPACT_STACK_POP:
1889     case OFPACT_SET_TUNNEL:
1890     case OFPACT_POP_QUEUE:
1891     case OFPACT_FIN_TIMEOUT:
1892     case OFPACT_RESUBMIT:
1893     case OFPACT_LEARN:
1894     case OFPACT_MULTIPATH:
1895     case OFPACT_NOTE:
1896     case OFPACT_EXIT:
1897     case OFPACT_SAMPLE:
1898         ofpact_to_nxast(a, out);
1899         break;
1900     }
1901 }
1902
1903 /* Converts the ofpacts in 'ofpacts' (terminated by OFPACT_END) into OpenFlow
1904  * 1.1 actions in 'openflow', appending the actions to any existing data in
1905  * 'openflow'. */
1906 size_t
1907 ofpacts_put_openflow11_actions(const struct ofpact ofpacts[],
1908                                size_t ofpacts_len, struct ofpbuf *openflow)
1909 {
1910     const struct ofpact *a;
1911     size_t start_size = openflow->size;
1912
1913     OFPACT_FOR_EACH (a, ofpacts, ofpacts_len) {
1914         ofpact_to_openflow11(a, openflow);
1915     }
1916
1917     return openflow->size - start_size;
1918 }
1919
1920 static void
1921 ofpacts_update_instruction_actions(struct ofpbuf *openflow, size_t ofs)
1922 {
1923     struct ofp11_instruction_actions *oia;
1924
1925     /* Update the instruction's length (or, if it's empty, delete it). */
1926     oia = ofpbuf_at_assert(openflow, ofs, sizeof *oia);
1927     if (openflow->size > ofs + sizeof *oia) {
1928         oia->len = htons(openflow->size - ofs);
1929     } else {
1930         openflow->size = ofs;
1931     }
1932 }
1933
1934 void
1935 ofpacts_put_openflow11_instructions(const struct ofpact ofpacts[],
1936                                     size_t ofpacts_len,
1937                                     struct ofpbuf *openflow)
1938 {
1939     const struct ofpact *a;
1940
1941     OFPACT_FOR_EACH (a, ofpacts, ofpacts_len) {
1942         switch (ovs_instruction_type_from_ofpact_type(a->type)) {
1943         case OVSINST_OFPIT11_CLEAR_ACTIONS:
1944             instruction_put_OFPIT11_CLEAR_ACTIONS(openflow);
1945             break;
1946
1947         case OVSINST_OFPIT11_GOTO_TABLE: {
1948             struct ofp11_instruction_goto_table *oigt;
1949             oigt = instruction_put_OFPIT11_GOTO_TABLE(openflow);
1950             oigt->table_id = ofpact_get_GOTO_TABLE(a)->table_id;
1951             memset(oigt->pad, 0, sizeof oigt->pad);
1952             break;
1953         }
1954
1955         case OVSINST_OFPIT11_WRITE_METADATA: {
1956             const struct ofpact_metadata *om;
1957             struct ofp11_instruction_write_metadata *oiwm;
1958
1959             om = ofpact_get_WRITE_METADATA(a);
1960             oiwm = instruction_put_OFPIT11_WRITE_METADATA(openflow);
1961             oiwm->metadata = om->metadata;
1962             oiwm->metadata_mask = om->mask;
1963             break;
1964         }
1965
1966         case OVSINST_OFPIT13_METER: {
1967             const struct ofpact_meter *om;
1968             struct ofp13_instruction_meter *oim;
1969
1970             om = ofpact_get_METER(a);
1971             oim = instruction_put_OFPIT13_METER(openflow);
1972             oim->meter_id = htonl(om->meter_id);
1973             break;
1974         }
1975
1976         case OVSINST_OFPIT11_APPLY_ACTIONS: {
1977             const size_t ofs = openflow->size;
1978             const size_t ofpacts_len_left =
1979                 (uint8_t*)ofpact_end(ofpacts, ofpacts_len) - (uint8_t*)a;
1980             const struct ofpact *action;
1981             const struct ofpact *processed = a;
1982
1983             instruction_put_OFPIT11_APPLY_ACTIONS(openflow);
1984             OFPACT_FOR_EACH(action, a, ofpacts_len_left) {
1985                 if (ovs_instruction_type_from_ofpact_type(action->type)
1986                     != OVSINST_OFPIT11_APPLY_ACTIONS) {
1987                     break;
1988                 }
1989                 ofpact_to_openflow11(action, openflow);
1990                 processed = action;
1991             }
1992             ofpacts_update_instruction_actions(openflow, ofs);
1993             a = processed;
1994             break;
1995         }
1996
1997         case OVSINST_OFPIT11_WRITE_ACTIONS:
1998             NOT_REACHED();
1999         }
2000     }
2001 }
2002 \f
2003 /* Returns true if 'action' outputs to 'port', false otherwise. */
2004 static bool
2005 ofpact_outputs_to_port(const struct ofpact *ofpact, ofp_port_t port)
2006 {
2007     switch (ofpact->type) {
2008     case OFPACT_OUTPUT:
2009         return ofpact_get_OUTPUT(ofpact)->port == port;
2010     case OFPACT_ENQUEUE:
2011         return ofpact_get_ENQUEUE(ofpact)->port == port;
2012     case OFPACT_CONTROLLER:
2013         return port == OFPP_CONTROLLER;
2014
2015     case OFPACT_OUTPUT_REG:
2016     case OFPACT_BUNDLE:
2017     case OFPACT_SET_VLAN_VID:
2018     case OFPACT_SET_VLAN_PCP:
2019     case OFPACT_STRIP_VLAN:
2020     case OFPACT_PUSH_VLAN:
2021     case OFPACT_SET_ETH_SRC:
2022     case OFPACT_SET_ETH_DST:
2023     case OFPACT_SET_IPV4_SRC:
2024     case OFPACT_SET_IPV4_DST:
2025     case OFPACT_SET_IPV4_DSCP:
2026     case OFPACT_SET_L4_SRC_PORT:
2027     case OFPACT_SET_L4_DST_PORT:
2028     case OFPACT_REG_MOVE:
2029     case OFPACT_REG_LOAD:
2030     case OFPACT_STACK_PUSH:
2031     case OFPACT_STACK_POP:
2032     case OFPACT_DEC_TTL:
2033     case OFPACT_SET_MPLS_TTL:
2034     case OFPACT_DEC_MPLS_TTL:
2035     case OFPACT_SET_TUNNEL:
2036     case OFPACT_WRITE_METADATA:
2037     case OFPACT_SET_QUEUE:
2038     case OFPACT_POP_QUEUE:
2039     case OFPACT_FIN_TIMEOUT:
2040     case OFPACT_RESUBMIT:
2041     case OFPACT_LEARN:
2042     case OFPACT_MULTIPATH:
2043     case OFPACT_NOTE:
2044     case OFPACT_EXIT:
2045     case OFPACT_PUSH_MPLS:
2046     case OFPACT_POP_MPLS:
2047     case OFPACT_SAMPLE:
2048     case OFPACT_CLEAR_ACTIONS:
2049     case OFPACT_GOTO_TABLE:
2050     case OFPACT_METER:
2051     default:
2052         return false;
2053     }
2054 }
2055
2056 /* Returns true if any action in the 'ofpacts_len' bytes of 'ofpacts' outputs
2057  * to 'port', false otherwise. */
2058 bool
2059 ofpacts_output_to_port(const struct ofpact *ofpacts, size_t ofpacts_len,
2060                        ofp_port_t port)
2061 {
2062     const struct ofpact *a;
2063
2064     OFPACT_FOR_EACH (a, ofpacts, ofpacts_len) {
2065         if (ofpact_outputs_to_port(a, port)) {
2066             return true;
2067         }
2068     }
2069
2070     return false;
2071 }
2072
2073 bool
2074 ofpacts_equal(const struct ofpact *a, size_t a_len,
2075               const struct ofpact *b, size_t b_len)
2076 {
2077     return a_len == b_len && !memcmp(a, b, a_len);
2078 }
2079 \f
2080 /* Formatting ofpacts. */
2081
2082 static void
2083 print_note(const struct ofpact_note *note, struct ds *string)
2084 {
2085     size_t i;
2086
2087     ds_put_cstr(string, "note:");
2088     for (i = 0; i < note->length; i++) {
2089         if (i) {
2090             ds_put_char(string, '.');
2091         }
2092         ds_put_format(string, "%02"PRIx8, note->data[i]);
2093     }
2094 }
2095
2096 static void
2097 print_dec_ttl(const struct ofpact_cnt_ids *ids,
2098               struct ds *s)
2099 {
2100     size_t i;
2101
2102     ds_put_cstr(s, "dec_ttl");
2103     if (ids->ofpact.compat == OFPUTIL_NXAST_DEC_TTL_CNT_IDS) {
2104         ds_put_cstr(s, "(");
2105         for (i = 0; i < ids->n_controllers; i++) {
2106             if (i) {
2107                 ds_put_cstr(s, ",");
2108             }
2109             ds_put_format(s, "%"PRIu16, ids->cnt_ids[i]);
2110         }
2111         ds_put_cstr(s, ")");
2112     }
2113 }
2114
2115 static void
2116 print_fin_timeout(const struct ofpact_fin_timeout *fin_timeout,
2117                   struct ds *s)
2118 {
2119     ds_put_cstr(s, "fin_timeout(");
2120     if (fin_timeout->fin_idle_timeout) {
2121         ds_put_format(s, "idle_timeout=%"PRIu16",",
2122                       fin_timeout->fin_idle_timeout);
2123     }
2124     if (fin_timeout->fin_hard_timeout) {
2125         ds_put_format(s, "hard_timeout=%"PRIu16",",
2126                       fin_timeout->fin_hard_timeout);
2127     }
2128     ds_chomp(s, ',');
2129     ds_put_char(s, ')');
2130 }
2131
2132 static void
2133 ofpact_format(const struct ofpact *a, struct ds *s)
2134 {
2135     const struct ofpact_enqueue *enqueue;
2136     const struct ofpact_resubmit *resubmit;
2137     const struct ofpact_controller *controller;
2138     const struct ofpact_metadata *metadata;
2139     const struct ofpact_tunnel *tunnel;
2140     const struct ofpact_sample *sample;
2141     ofp_port_t port;
2142
2143     switch (a->type) {
2144     case OFPACT_OUTPUT:
2145         port = ofpact_get_OUTPUT(a)->port;
2146         if (ofp_to_u16(port) < ofp_to_u16(OFPP_MAX)) {
2147             ds_put_format(s, "output:%"PRIu16, port);
2148         } else {
2149             ofputil_format_port(port, s);
2150             if (port == OFPP_CONTROLLER) {
2151                 ds_put_format(s, ":%"PRIu16, ofpact_get_OUTPUT(a)->max_len);
2152             }
2153         }
2154         break;
2155
2156     case OFPACT_CONTROLLER:
2157         controller = ofpact_get_CONTROLLER(a);
2158         if (controller->reason == OFPR_ACTION &&
2159             controller->controller_id == 0) {
2160             ds_put_format(s, "CONTROLLER:%"PRIu16,
2161                           ofpact_get_CONTROLLER(a)->max_len);
2162         } else {
2163             enum ofp_packet_in_reason reason = controller->reason;
2164
2165             ds_put_cstr(s, "controller(");
2166             if (reason != OFPR_ACTION) {
2167                 char reasonbuf[OFPUTIL_PACKET_IN_REASON_BUFSIZE];
2168
2169                 ds_put_format(s, "reason=%s,",
2170                               ofputil_packet_in_reason_to_string(
2171                                   reason, reasonbuf, sizeof reasonbuf));
2172             }
2173             if (controller->max_len != UINT16_MAX) {
2174                 ds_put_format(s, "max_len=%"PRIu16",", controller->max_len);
2175             }
2176             if (controller->controller_id != 0) {
2177                 ds_put_format(s, "id=%"PRIu16",", controller->controller_id);
2178             }
2179             ds_chomp(s, ',');
2180             ds_put_char(s, ')');
2181         }
2182         break;
2183
2184     case OFPACT_ENQUEUE:
2185         enqueue = ofpact_get_ENQUEUE(a);
2186         ds_put_format(s, "enqueue:");
2187         ofputil_format_port(enqueue->port, s);
2188         ds_put_format(s, "q%"PRIu32, enqueue->queue);
2189         break;
2190
2191     case OFPACT_OUTPUT_REG:
2192         ds_put_cstr(s, "output:");
2193         mf_format_subfield(&ofpact_get_OUTPUT_REG(a)->src, s);
2194         break;
2195
2196     case OFPACT_BUNDLE:
2197         bundle_format(ofpact_get_BUNDLE(a), s);
2198         break;
2199
2200     case OFPACT_SET_VLAN_VID:
2201         ds_put_format(s, "mod_vlan_vid:%"PRIu16,
2202                       ofpact_get_SET_VLAN_VID(a)->vlan_vid);
2203         break;
2204
2205     case OFPACT_SET_VLAN_PCP:
2206         ds_put_format(s, "mod_vlan_pcp:%"PRIu8,
2207                       ofpact_get_SET_VLAN_PCP(a)->vlan_pcp);
2208         break;
2209
2210     case OFPACT_STRIP_VLAN:
2211         ds_put_cstr(s, "strip_vlan");
2212         break;
2213
2214     case OFPACT_PUSH_VLAN:
2215         /* XXX 802.1AD case*/
2216         ds_put_format(s, "push_vlan:%#"PRIx16, ETH_TYPE_VLAN_8021Q);
2217         break;
2218
2219     case OFPACT_SET_ETH_SRC:
2220         ds_put_format(s, "mod_dl_src:"ETH_ADDR_FMT,
2221                       ETH_ADDR_ARGS(ofpact_get_SET_ETH_SRC(a)->mac));
2222         break;
2223
2224     case OFPACT_SET_ETH_DST:
2225         ds_put_format(s, "mod_dl_dst:"ETH_ADDR_FMT,
2226                       ETH_ADDR_ARGS(ofpact_get_SET_ETH_DST(a)->mac));
2227         break;
2228
2229     case OFPACT_SET_IPV4_SRC:
2230         ds_put_format(s, "mod_nw_src:"IP_FMT,
2231                       IP_ARGS(ofpact_get_SET_IPV4_SRC(a)->ipv4));
2232         break;
2233
2234     case OFPACT_SET_IPV4_DST:
2235         ds_put_format(s, "mod_nw_dst:"IP_FMT,
2236                       IP_ARGS(ofpact_get_SET_IPV4_DST(a)->ipv4));
2237         break;
2238
2239     case OFPACT_SET_IPV4_DSCP:
2240         ds_put_format(s, "mod_nw_tos:%d", ofpact_get_SET_IPV4_DSCP(a)->dscp);
2241         break;
2242
2243     case OFPACT_SET_L4_SRC_PORT:
2244         ds_put_format(s, "mod_tp_src:%d", ofpact_get_SET_L4_SRC_PORT(a)->port);
2245         break;
2246
2247     case OFPACT_SET_L4_DST_PORT:
2248         ds_put_format(s, "mod_tp_dst:%d", ofpact_get_SET_L4_DST_PORT(a)->port);
2249         break;
2250
2251     case OFPACT_REG_MOVE:
2252         nxm_format_reg_move(ofpact_get_REG_MOVE(a), s);
2253         break;
2254
2255     case OFPACT_REG_LOAD:
2256         nxm_format_reg_load(ofpact_get_REG_LOAD(a), s);
2257         break;
2258
2259     case OFPACT_STACK_PUSH:
2260         nxm_format_stack_push(ofpact_get_STACK_PUSH(a), s);
2261         break;
2262
2263     case OFPACT_STACK_POP:
2264         nxm_format_stack_pop(ofpact_get_STACK_POP(a), s);
2265         break;
2266
2267     case OFPACT_DEC_TTL:
2268         print_dec_ttl(ofpact_get_DEC_TTL(a), s);
2269         break;
2270
2271     case OFPACT_SET_MPLS_TTL:
2272         ds_put_format(s, "set_mpls_ttl(%"PRIu8")",
2273                       ofpact_get_SET_MPLS_TTL(a)->ttl);
2274         break;
2275
2276     case OFPACT_DEC_MPLS_TTL:
2277         ds_put_cstr(s, "dec_mpls_ttl");
2278         break;
2279
2280     case OFPACT_SET_TUNNEL:
2281         tunnel = ofpact_get_SET_TUNNEL(a);
2282         ds_put_format(s, "set_tunnel%s:%#"PRIx64,
2283                       (tunnel->tun_id > UINT32_MAX
2284                        || a->compat == OFPUTIL_NXAST_SET_TUNNEL64 ? "64" : ""),
2285                       tunnel->tun_id);
2286         break;
2287
2288     case OFPACT_SET_QUEUE:
2289         ds_put_format(s, "set_queue:%"PRIu32,
2290                       ofpact_get_SET_QUEUE(a)->queue_id);
2291         break;
2292
2293     case OFPACT_POP_QUEUE:
2294         ds_put_cstr(s, "pop_queue");
2295         break;
2296
2297     case OFPACT_FIN_TIMEOUT:
2298         print_fin_timeout(ofpact_get_FIN_TIMEOUT(a), s);
2299         break;
2300
2301     case OFPACT_RESUBMIT:
2302         resubmit = ofpact_get_RESUBMIT(a);
2303         if (resubmit->in_port != OFPP_IN_PORT && resubmit->table_id == 255) {
2304             ds_put_cstr(s, "resubmit:");
2305             ofputil_format_port(resubmit->in_port, s);
2306         } else {
2307             ds_put_format(s, "resubmit(");
2308             if (resubmit->in_port != OFPP_IN_PORT) {
2309                 ofputil_format_port(resubmit->in_port, s);
2310             }
2311             ds_put_char(s, ',');
2312             if (resubmit->table_id != 255) {
2313                 ds_put_format(s, "%"PRIu8, resubmit->table_id);
2314             }
2315             ds_put_char(s, ')');
2316         }
2317         break;
2318
2319     case OFPACT_LEARN:
2320         learn_format(ofpact_get_LEARN(a), s);
2321         break;
2322
2323     case OFPACT_MULTIPATH:
2324         multipath_format(ofpact_get_MULTIPATH(a), s);
2325         break;
2326
2327     case OFPACT_NOTE:
2328         print_note(ofpact_get_NOTE(a), s);
2329         break;
2330
2331     case OFPACT_PUSH_MPLS:
2332         ds_put_format(s, "push_mpls:0x%04"PRIx16,
2333                       ntohs(ofpact_get_PUSH_MPLS(a)->ethertype));
2334         break;
2335
2336     case OFPACT_POP_MPLS:
2337         ds_put_format(s, "pop_mpls:0x%04"PRIx16,
2338                       ntohs(ofpact_get_POP_MPLS(a)->ethertype));
2339         break;
2340
2341     case OFPACT_EXIT:
2342         ds_put_cstr(s, "exit");
2343         break;
2344
2345     case OFPACT_SAMPLE:
2346         sample = ofpact_get_SAMPLE(a);
2347         ds_put_format(
2348             s, "sample(probability=%"PRIu16",collector_set_id=%"PRIu32
2349             ",obs_domain_id=%"PRIu32",obs_point_id=%"PRIu32")",
2350             sample->probability, sample->collector_set_id,
2351             sample->obs_domain_id, sample->obs_point_id);
2352         break;
2353
2354     case OFPACT_CLEAR_ACTIONS:
2355         ds_put_format(s, "%s",
2356                       ovs_instruction_name_from_type(
2357                           OVSINST_OFPIT11_CLEAR_ACTIONS));
2358         break;
2359
2360     case OFPACT_WRITE_METADATA:
2361         metadata = ofpact_get_WRITE_METADATA(a);
2362         ds_put_format(s, "%s:%#"PRIx64,
2363                       ovs_instruction_name_from_type(
2364                           OVSINST_OFPIT11_WRITE_METADATA),
2365                       ntohll(metadata->metadata));
2366         if (metadata->mask != htonll(UINT64_MAX)) {
2367             ds_put_format(s, "/%#"PRIx64, ntohll(metadata->mask));
2368         }
2369         break;
2370
2371     case OFPACT_GOTO_TABLE:
2372         ds_put_format(s, "%s:%"PRIu8,
2373                       ovs_instruction_name_from_type(
2374                           OVSINST_OFPIT11_GOTO_TABLE),
2375                       ofpact_get_GOTO_TABLE(a)->table_id);
2376         break;
2377
2378     case OFPACT_METER:
2379         ds_put_format(s, "%s:%"PRIu32,
2380                       ovs_instruction_name_from_type(OVSINST_OFPIT13_METER),
2381                       ofpact_get_METER(a)->meter_id);
2382         break;
2383     }
2384 }
2385
2386 /* Appends a string representing the 'ofpacts_len' bytes of ofpacts in
2387  * 'ofpacts' to 'string'. */
2388 void
2389 ofpacts_format(const struct ofpact *ofpacts, size_t ofpacts_len,
2390                struct ds *string)
2391 {
2392     ds_put_cstr(string, "actions=");
2393     if (!ofpacts_len) {
2394         ds_put_cstr(string, "drop");
2395     } else {
2396         const struct ofpact *a;
2397
2398         OFPACT_FOR_EACH (a, ofpacts, ofpacts_len) {
2399             if (a != ofpacts) {
2400                 ds_put_cstr(string, ",");
2401             }
2402
2403             /* XXX write-actions */
2404             ofpact_format(a, string);
2405         }
2406     }
2407 }
2408 \f
2409 /* Internal use by helpers. */
2410
2411 void *
2412 ofpact_put(struct ofpbuf *ofpacts, enum ofpact_type type, size_t len)
2413 {
2414     struct ofpact *ofpact;
2415
2416     ofpact_pad(ofpacts);
2417     ofpact = ofpacts->l2 = ofpbuf_put_uninit(ofpacts, len);
2418     ofpact_init(ofpact, type, len);
2419     return ofpact;
2420 }
2421
2422 void
2423 ofpact_init(struct ofpact *ofpact, enum ofpact_type type, size_t len)
2424 {
2425     memset(ofpact, 0, len);
2426     ofpact->type = type;
2427     ofpact->compat = OFPUTIL_ACTION_INVALID;
2428     ofpact->len = len;
2429 }
2430 \f
2431 /* Updates 'ofpact->len' to the number of bytes in the tail of 'ofpacts'
2432  * starting at 'ofpact'.
2433  *
2434  * This is the correct way to update a variable-length ofpact's length after
2435  * adding the variable-length part of the payload.  (See the large comment
2436  * near the end of ofp-actions.h for more information.) */
2437 void
2438 ofpact_update_len(struct ofpbuf *ofpacts, struct ofpact *ofpact)
2439 {
2440     ovs_assert(ofpact == ofpacts->l2);
2441     ofpact->len = (char *) ofpbuf_tail(ofpacts) - (char *) ofpact;
2442 }
2443
2444 /* Pads out 'ofpacts' to a multiple of OFPACT_ALIGNTO bytes in length.  Each
2445  * ofpact_put_<ENUM>() calls this function automatically beforehand, but the
2446  * client must call this itself after adding the final ofpact to an array of
2447  * them.
2448  *
2449  * (The consequences of failing to call this function are probably not dire.
2450  * OFPACT_FOR_EACH will calculate a pointer beyond the end of the ofpacts, but
2451  * not dereference it.  That's undefined behavior, technically, but it will not
2452  * cause a real problem on common systems.  Still, it seems better to call
2453  * it.) */
2454 void
2455 ofpact_pad(struct ofpbuf *ofpacts)
2456 {
2457     unsigned int rem = ofpacts->size % OFPACT_ALIGNTO;
2458     if (rem) {
2459         ofpbuf_put_zeros(ofpacts, OFPACT_ALIGNTO - rem);
2460     }
2461 }
2462
2463 void
2464 ofpact_set_field_init(struct ofpact_reg_load *load, const struct mf_field *mf,
2465                       const void *src)
2466 {
2467     load->ofpact.compat = OFPUTIL_OFPAT12_SET_FIELD;
2468     load->dst.field = mf;
2469     load->dst.ofs = 0;
2470     load->dst.n_bits = mf->n_bits;
2471     bitwise_copy(src, mf->n_bytes, load->dst.ofs,
2472                  &load->subvalue, sizeof load->subvalue, 0, mf->n_bits);
2473 }