1 /* Copyright (c) 2009, 2010, 2011, 2012, 2013 Nicira, Inc.
3 * Licensed under the Apache License, Version 2.0 (the "License");
4 * you may not use this file except in compliance with the License.
5 * You may obtain a copy of the License at:
7 * http://www.apache.org/licenses/LICENSE-2.0
9 * Unless required by applicable law or agreed to in writing, software
10 * distributed under the License is distributed on an "AS IS" BASIS,
11 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12 * See the License for the specific language governing permissions and
13 * limitations under the License. */
16 #include "ofproto-dpif-upcall.h"
23 #include "dynamic-string.h"
25 #include "fail-open.h"
26 #include "guarded-list.h"
32 #include "ofproto-dpif.h"
34 #include "poll-loop.h"
37 #define MAX_QUEUE_LENGTH 512
39 VLOG_DEFINE_THIS_MODULE(ofproto_dpif_upcall);
41 COVERAGE_DEFINE(upcall_queue_overflow);
42 COVERAGE_DEFINE(drop_queue_overflow);
43 COVERAGE_DEFINE(miss_queue_overflow);
44 COVERAGE_DEFINE(fmb_queue_overflow);
45 COVERAGE_DEFINE(fmb_queue_revalidated);
47 /* A thread that processes each upcall handed to it by the dispatcher thread,
48 * forwards the upcall's packet, and then queues it to the main ofproto_dpif
49 * to possibly set up a kernel flow as a cache. */
51 struct udpif *udpif; /* Parent udpif. */
52 pthread_t thread; /* Thread ID. */
54 struct ovs_mutex mutex; /* Mutex guarding the following. */
56 /* Atomic queue of unprocessed miss upcalls. */
57 struct list upcalls OVS_GUARDED;
58 size_t n_upcalls OVS_GUARDED;
60 size_t n_new_upcalls; /* Only changed by the dispatcher. */
62 pthread_cond_t wake_cond; /* Wakes 'thread' while holding
66 /* An upcall handler for ofproto_dpif.
68 * udpif is implemented as a "dispatcher" thread that reads upcalls from the
69 * kernel. It processes each upcall just enough to figure out its next
70 * destination. For a "miss" upcall (MISS_UPCALL), this is one of several
71 * "handler" threads (see struct handler). Other upcalls are queued to the
72 * main ofproto_dpif. */
74 struct dpif *dpif; /* Datapath handle. */
75 struct dpif_backer *backer; /* Opaque dpif_backer pointer. */
77 uint32_t secret; /* Random seed for upcall hash. */
79 pthread_t dispatcher; /* Dispatcher thread ID. */
81 struct handler *handlers; /* Miss handlers. */
84 /* Queues to pass up to ofproto-dpif. */
85 struct guarded_list drop_keys; /* "struct drop key"s. */
86 struct guarded_list upcalls; /* "struct upcall"s. */
87 struct guarded_list fmbs; /* "struct flow_miss_batch"es. */
89 /* Number of times udpif_revalidate() has been called. */
90 atomic_uint reval_seq;
94 struct latch exit_latch; /* Tells child threads to exit. */
97 static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(1, 5);
99 static void recv_upcalls(struct udpif *);
100 static void handle_miss_upcalls(struct udpif *, struct list *upcalls);
101 static void miss_destroy(struct flow_miss *);
102 static void *udpif_dispatcher(void *);
103 static void *udpif_miss_handler(void *);
106 udpif_create(struct dpif_backer *backer, struct dpif *dpif)
108 struct udpif *udpif = xzalloc(sizeof *udpif);
111 udpif->backer = backer;
112 udpif->secret = random_uint32();
113 udpif->wait_seq = seq_create();
114 latch_init(&udpif->exit_latch);
115 guarded_list_init(&udpif->drop_keys);
116 guarded_list_init(&udpif->upcalls);
117 guarded_list_init(&udpif->fmbs);
118 atomic_init(&udpif->reval_seq, 0);
124 udpif_destroy(struct udpif *udpif)
126 struct flow_miss_batch *fmb;
127 struct drop_key *drop_key;
128 struct upcall *upcall;
130 udpif_recv_set(udpif, 0, false);
132 while ((drop_key = drop_key_next(udpif))) {
133 drop_key_destroy(drop_key);
136 while ((upcall = upcall_next(udpif))) {
137 upcall_destroy(upcall);
140 while ((fmb = flow_miss_batch_next(udpif))) {
141 flow_miss_batch_destroy(fmb);
144 guarded_list_destroy(&udpif->drop_keys);
145 guarded_list_destroy(&udpif->upcalls);
146 guarded_list_destroy(&udpif->fmbs);
147 latch_destroy(&udpif->exit_latch);
148 seq_destroy(udpif->wait_seq);
152 /* Tells 'udpif' to begin or stop handling flow misses depending on the value
153 * of 'enable'. 'n_handlers' is the number of miss_handler threads to create.
154 * Passing 'n_handlers' as zero is equivalent to passing 'enable' as false. */
156 udpif_recv_set(struct udpif *udpif, size_t n_handlers, bool enable)
158 n_handlers = enable ? n_handlers : 0;
159 n_handlers = MIN(n_handlers, 64);
161 /* Stop the old threads (if any). */
162 if (udpif->handlers && udpif->n_handlers != n_handlers) {
165 latch_set(&udpif->exit_latch);
167 /* Wake the handlers so they can exit. */
168 for (i = 0; i < udpif->n_handlers; i++) {
169 struct handler *handler = &udpif->handlers[i];
171 ovs_mutex_lock(&handler->mutex);
172 xpthread_cond_signal(&handler->wake_cond);
173 ovs_mutex_unlock(&handler->mutex);
176 xpthread_join(udpif->dispatcher, NULL);
177 for (i = 0; i < udpif->n_handlers; i++) {
178 struct handler *handler = &udpif->handlers[i];
179 struct upcall *miss, *next;
181 xpthread_join(handler->thread, NULL);
183 ovs_mutex_lock(&handler->mutex);
184 LIST_FOR_EACH_SAFE (miss, next, list_node, &handler->upcalls) {
185 list_remove(&miss->list_node);
186 upcall_destroy(miss);
188 ovs_mutex_unlock(&handler->mutex);
189 ovs_mutex_destroy(&handler->mutex);
191 xpthread_cond_destroy(&handler->wake_cond);
193 latch_poll(&udpif->exit_latch);
195 free(udpif->handlers);
196 udpif->handlers = NULL;
197 udpif->n_handlers = 0;
200 /* Start new threads (if necessary). */
201 if (!udpif->handlers && n_handlers) {
204 udpif->n_handlers = n_handlers;
205 udpif->handlers = xzalloc(udpif->n_handlers * sizeof *udpif->handlers);
206 for (i = 0; i < udpif->n_handlers; i++) {
207 struct handler *handler = &udpif->handlers[i];
209 handler->udpif = udpif;
210 list_init(&handler->upcalls);
211 xpthread_cond_init(&handler->wake_cond, NULL);
212 ovs_mutex_init(&handler->mutex);
213 xpthread_create(&handler->thread, NULL, udpif_miss_handler, handler);
215 xpthread_create(&udpif->dispatcher, NULL, udpif_dispatcher, udpif);
220 udpif_wait(struct udpif *udpif)
222 uint64_t seq = seq_read(udpif->wait_seq);
223 if (!guarded_list_is_empty(&udpif->drop_keys) ||
224 !guarded_list_is_empty(&udpif->upcalls) ||
225 !guarded_list_is_empty(&udpif->fmbs)) {
226 poll_immediate_wake();
228 seq_wait(udpif->wait_seq, seq);
232 /* Notifies 'udpif' that something changed which may render previous
233 * xlate_actions() results invalid. */
235 udpif_revalidate(struct udpif *udpif)
237 struct flow_miss_batch *fmb, *next_fmb;
241 /* Since we remove each miss on revalidation, their statistics won't be
242 * accounted to the appropriate 'facet's in the upper layer. In most
243 * cases, this is alright because we've already pushed the stats to the
244 * relevant rules. However, NetFlow requires absolute packet counts on
245 * 'facet's which could now be incorrect. */
246 atomic_add(&udpif->reval_seq, 1, &junk);
248 guarded_list_pop_all(&udpif->fmbs, &fmbs);
249 LIST_FOR_EACH_SAFE (fmb, next_fmb, list_node, &fmbs) {
250 list_remove(&fmb->list_node);
251 flow_miss_batch_destroy(fmb);
254 udpif_drop_key_clear(udpif);
257 /* Retreives the next upcall which ofproto-dpif is responsible for handling.
258 * The caller is responsible for destroying the returned upcall with
259 * upcall_destroy(). */
261 upcall_next(struct udpif *udpif)
263 struct list *next = guarded_list_pop_front(&udpif->upcalls);
264 return next ? CONTAINER_OF(next, struct upcall, list_node) : NULL;
267 /* Destroys and deallocates 'upcall'. */
269 upcall_destroy(struct upcall *upcall)
272 ofpbuf_uninit(&upcall->upcall_buf);
277 /* Retreives the next batch of processed flow misses for 'udpif' to install.
278 * The caller is responsible for destroying it with flow_miss_batch_destroy().
280 struct flow_miss_batch *
281 flow_miss_batch_next(struct udpif *udpif)
285 for (i = 0; i < 50; i++) {
286 struct flow_miss_batch *next;
287 unsigned int reval_seq;
288 struct list *next_node;
290 next_node = guarded_list_pop_front(&udpif->fmbs);
295 next = CONTAINER_OF(next_node, struct flow_miss_batch, list_node);
296 atomic_read(&udpif->reval_seq, &reval_seq);
297 if (next->reval_seq == reval_seq) {
301 flow_miss_batch_destroy(next);
307 /* Destroys and deallocates 'fmb'. */
309 flow_miss_batch_destroy(struct flow_miss_batch *fmb)
311 struct flow_miss *miss, *next;
317 HMAP_FOR_EACH_SAFE (miss, next, hmap_node, &fmb->misses) {
318 hmap_remove(&fmb->misses, &miss->hmap_node);
322 hmap_destroy(&fmb->misses);
326 /* Retreives the next drop key which ofproto-dpif needs to process. The caller
327 * is responsible for destroying it with drop_key_destroy(). */
329 drop_key_next(struct udpif *udpif)
331 struct list *next = guarded_list_pop_front(&udpif->drop_keys);
332 return next ? CONTAINER_OF(next, struct drop_key, list_node) : NULL;
335 /* Destorys and deallocates 'drop_key'. */
337 drop_key_destroy(struct drop_key *drop_key)
345 /* Clears all drop keys waiting to be processed by drop_key_next(). */
347 udpif_drop_key_clear(struct udpif *udpif)
349 struct drop_key *drop_key, *next;
352 guarded_list_pop_all(&udpif->drop_keys, &list);
353 LIST_FOR_EACH_SAFE (drop_key, next, list_node, &list) {
354 list_remove(&drop_key->list_node);
355 drop_key_destroy(drop_key);
359 /* The dispatcher thread is responsible for receving upcalls from the kernel,
360 * assigning the miss upcalls to a miss_handler thread, and assigning the more
361 * complex ones to ofproto-dpif directly. */
363 udpif_dispatcher(void *arg)
365 struct udpif *udpif = arg;
367 set_subprogram_name("dispatcher");
368 while (!latch_is_set(&udpif->exit_latch)) {
370 dpif_recv_wait(udpif->dpif);
371 latch_wait(&udpif->exit_latch);
378 /* The miss handler thread is responsible for processing miss upcalls retreived
379 * by the dispatcher thread. Once finished it passes the processed miss
380 * upcalls to ofproto-dpif where they're installed in the datapath. */
382 udpif_miss_handler(void *arg)
384 struct list misses = LIST_INITIALIZER(&misses);
385 struct handler *handler = arg;
387 set_subprogram_name("miss_handler");
391 ovs_mutex_lock(&handler->mutex);
393 if (latch_is_set(&handler->udpif->exit_latch)) {
394 ovs_mutex_unlock(&handler->mutex);
398 if (!handler->n_upcalls) {
399 ovs_mutex_cond_wait(&handler->wake_cond, &handler->mutex);
402 for (i = 0; i < FLOW_MISS_MAX_BATCH; i++) {
403 if (handler->n_upcalls) {
404 handler->n_upcalls--;
405 list_push_back(&misses, list_pop_front(&handler->upcalls));
410 ovs_mutex_unlock(&handler->mutex);
412 handle_miss_upcalls(handler->udpif, &misses);
417 miss_destroy(struct flow_miss *miss)
419 struct upcall *upcall, *next;
421 LIST_FOR_EACH_SAFE (upcall, next, list_node, &miss->upcalls) {
422 list_remove(&upcall->list_node);
423 upcall_destroy(upcall);
425 xlate_out_uninit(&miss->xout);
428 static enum upcall_type
429 classify_upcall(const struct upcall *upcall)
431 const struct dpif_upcall *dpif_upcall = &upcall->dpif_upcall;
432 union user_action_cookie cookie;
435 /* First look at the upcall type. */
436 switch (dpif_upcall->type) {
443 case DPIF_N_UC_TYPES:
445 VLOG_WARN_RL(&rl, "upcall has unexpected type %"PRIu32,
450 /* "action" upcalls need a closer look. */
451 if (!dpif_upcall->userdata) {
452 VLOG_WARN_RL(&rl, "action upcall missing cookie");
455 userdata_len = nl_attr_get_size(dpif_upcall->userdata);
456 if (userdata_len < sizeof cookie.type
457 || userdata_len > sizeof cookie) {
458 VLOG_WARN_RL(&rl, "action upcall cookie has unexpected size %zu",
462 memset(&cookie, 0, sizeof cookie);
463 memcpy(&cookie, nl_attr_get(dpif_upcall->userdata), userdata_len);
464 if (userdata_len == sizeof cookie.sflow
465 && cookie.type == USER_ACTION_COOKIE_SFLOW) {
467 } else if (userdata_len == sizeof cookie.slow_path
468 && cookie.type == USER_ACTION_COOKIE_SLOW_PATH) {
470 } else if (userdata_len == sizeof cookie.flow_sample
471 && cookie.type == USER_ACTION_COOKIE_FLOW_SAMPLE) {
472 return FLOW_SAMPLE_UPCALL;
473 } else if (userdata_len == sizeof cookie.ipfix
474 && cookie.type == USER_ACTION_COOKIE_IPFIX) {
477 VLOG_WARN_RL(&rl, "invalid user cookie of type %"PRIu16
478 " and size %zu", cookie.type, userdata_len);
484 recv_upcalls(struct udpif *udpif)
486 static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(60, 60);
487 size_t n_udpif_new_upcalls = 0;
488 struct handler *handler;
492 struct upcall *upcall;
495 upcall = xmalloc(sizeof *upcall);
496 ofpbuf_use_stub(&upcall->upcall_buf, upcall->upcall_stub,
497 sizeof upcall->upcall_stub);
498 error = dpif_recv(udpif->dpif, &upcall->dpif_upcall,
499 &upcall->upcall_buf);
501 upcall_destroy(upcall);
505 upcall->type = classify_upcall(upcall);
506 if (upcall->type == BAD_UPCALL) {
507 upcall_destroy(upcall);
508 } else if (upcall->type == MISS_UPCALL) {
509 struct dpif_upcall *dupcall = &upcall->dpif_upcall;
510 uint32_t hash = udpif->secret;
512 size_t n_bytes, left;
515 NL_ATTR_FOR_EACH (nla, left, dupcall->key, dupcall->key_len) {
516 enum ovs_key_attr type = nl_attr_type(nla);
517 if (type == OVS_KEY_ATTR_IN_PORT
518 || type == OVS_KEY_ATTR_TCP
519 || type == OVS_KEY_ATTR_UDP) {
520 if (nl_attr_get_size(nla) == 4) {
521 ovs_be32 attr = nl_attr_get_be32(nla);
522 hash = mhash_add(hash, (OVS_FORCE uint32_t) attr);
525 VLOG_WARN("Netlink attribute with incorrect size.");
529 hash = mhash_finish(hash, n_bytes);
531 handler = &udpif->handlers[hash % udpif->n_handlers];
533 ovs_mutex_lock(&handler->mutex);
534 if (handler->n_upcalls < MAX_QUEUE_LENGTH) {
535 list_push_back(&handler->upcalls, &upcall->list_node);
536 handler->n_new_upcalls = ++handler->n_upcalls;
538 if (handler->n_new_upcalls >= FLOW_MISS_MAX_BATCH) {
539 xpthread_cond_signal(&handler->wake_cond);
541 ovs_mutex_unlock(&handler->mutex);
542 if (!VLOG_DROP_DBG(&rl)) {
543 struct ds ds = DS_EMPTY_INITIALIZER;
545 odp_flow_key_format(upcall->dpif_upcall.key,
546 upcall->dpif_upcall.key_len,
548 VLOG_DBG("dispatcher: miss enqueue (%s)", ds_cstr(&ds));
552 ovs_mutex_unlock(&handler->mutex);
553 COVERAGE_INC(miss_queue_overflow);
554 upcall_destroy(upcall);
559 len = guarded_list_push_back(&udpif->upcalls, &upcall->list_node,
562 n_udpif_new_upcalls = len;
563 if (n_udpif_new_upcalls >= FLOW_MISS_MAX_BATCH) {
564 seq_change(udpif->wait_seq);
567 COVERAGE_INC(upcall_queue_overflow);
568 upcall_destroy(upcall);
572 for (n = 0; n < udpif->n_handlers; ++n) {
573 handler = &udpif->handlers[n];
574 if (handler->n_new_upcalls) {
575 handler->n_new_upcalls = 0;
576 ovs_mutex_lock(&handler->mutex);
577 xpthread_cond_signal(&handler->wake_cond);
578 ovs_mutex_unlock(&handler->mutex);
581 if (n_udpif_new_upcalls) {
582 seq_change(udpif->wait_seq);
586 static struct flow_miss *
587 flow_miss_find(struct hmap *todo, const struct ofproto_dpif *ofproto,
588 const struct flow *flow, uint32_t hash)
590 struct flow_miss *miss;
592 HMAP_FOR_EACH_WITH_HASH (miss, hmap_node, hash, todo) {
593 if (miss->ofproto == ofproto && flow_equal(&miss->flow, flow)) {
601 /* Executes flow miss 'miss'. May add any required datapath operations
602 * to 'ops', incrementing '*n_ops' for each new op. */
604 execute_flow_miss(struct flow_miss *miss, struct dpif_op *ops, size_t *n_ops)
606 struct ofproto_dpif *ofproto = miss->ofproto;
607 struct upcall *upcall;
608 struct flow_wildcards wc;
609 struct rule_dpif *rule;
612 memset(&miss->stats, 0, sizeof miss->stats);
613 miss->stats.used = time_msec();
614 LIST_FOR_EACH (upcall, list_node, &miss->upcalls) {
615 struct ofpbuf *packet = upcall->dpif_upcall.packet;
617 miss->stats.tcp_flags |= packet_get_tcp_flags(packet, &miss->flow);
618 miss->stats.n_bytes += packet->size;
619 miss->stats.n_packets++;
622 flow_wildcards_init_catchall(&wc);
623 rule_dpif_lookup(ofproto, &miss->flow, &wc, &rule);
624 rule_dpif_credit_stats(rule, &miss->stats);
625 xlate_in_init(&xin, ofproto, &miss->flow, rule, miss->stats.tcp_flags,
627 xin.may_learn = true;
628 xin.resubmit_stats = &miss->stats;
629 xlate_actions(&xin, &miss->xout);
630 flow_wildcards_or(&miss->xout.wc, &miss->xout.wc, &wc);
632 if (rule_dpif_fail_open(rule)) {
633 LIST_FOR_EACH (upcall, list_node, &miss->upcalls) {
634 struct ofpbuf *packet = upcall->dpif_upcall.packet;
635 struct ofputil_packet_in *pin;
637 /* Extra-special case for fail-open mode.
639 * We are in fail-open mode and the packet matched the fail-open
640 * rule, but we are connected to a controller too. We should send
641 * the packet up to the controller in the hope that it will try to
642 * set up a flow and thereby allow us to exit fail-open.
644 * See the top-level comment in fail-open.c for more information. */
645 pin = xmalloc(sizeof(*pin));
646 pin->packet = xmemdup(packet->data, packet->size);
647 pin->packet_len = packet->size;
648 pin->reason = OFPR_NO_MATCH;
649 pin->controller_id = 0;
652 pin->send_len = 0; /* Not used for flow table misses. */
653 flow_get_metadata(&miss->flow, &pin->fmd);
654 ofproto_dpif_send_packet_in(ofproto, pin);
658 if (miss->xout.slow) {
659 LIST_FOR_EACH (upcall, list_node, &miss->upcalls) {
660 struct ofpbuf *packet = upcall->dpif_upcall.packet;
663 xlate_in_init(&xin, miss->ofproto, &miss->flow, rule, 0, packet);
664 xlate_actions_for_side_effects(&xin);
667 rule_dpif_unref(rule);
669 if (miss->xout.odp_actions.size) {
670 LIST_FOR_EACH (upcall, list_node, &miss->upcalls) {
671 struct ofpbuf *packet = upcall->dpif_upcall.packet;
672 struct dpif_op *op = &ops[*n_ops];
673 struct dpif_execute *execute = &op->u.execute;
675 if (miss->flow.in_port.ofp_port
676 != vsp_realdev_to_vlandev(miss->ofproto,
677 miss->flow.in_port.ofp_port,
678 miss->flow.vlan_tci)) {
679 /* This packet was received on a VLAN splinter port. We
680 * added a VLAN to the packet to make the packet resemble
681 * the flow, but the actions were composed assuming that
682 * the packet contained no VLAN. So, we must remove the
683 * VLAN header from the packet before trying to execute the
685 eth_pop_vlan(packet);
688 op->type = DPIF_OP_EXECUTE;
689 execute->key = miss->key;
690 execute->key_len = miss->key_len;
691 execute->packet = packet;
692 execute->actions = miss->xout.odp_actions.data;
693 execute->actions_len = miss->xout.odp_actions.size;
701 handle_miss_upcalls(struct udpif *udpif, struct list *upcalls)
703 struct dpif_op *opsp[FLOW_MISS_MAX_BATCH];
704 struct dpif_op ops[FLOW_MISS_MAX_BATCH];
705 struct upcall *upcall, *next;
706 struct flow_miss_batch *fmb;
707 size_t n_upcalls, n_ops, i;
708 struct flow_miss *miss;
709 unsigned int reval_seq;
711 /* Construct the to-do list.
713 * This just amounts to extracting the flow from each packet and sticking
714 * the packets that have the same flow in the same "flow_miss" structure so
715 * that we can process them together. */
716 fmb = xmalloc(sizeof *fmb);
717 atomic_read(&udpif->reval_seq, &fmb->reval_seq);
718 hmap_init(&fmb->misses);
720 LIST_FOR_EACH_SAFE (upcall, next, list_node, upcalls) {
721 struct dpif_upcall *dupcall = &upcall->dpif_upcall;
722 struct flow_miss *miss = &fmb->miss_buf[n_upcalls];
723 struct flow_miss *existing_miss;
724 struct ofproto_dpif *ofproto;
725 odp_port_t odp_in_port;
730 error = xlate_receive(udpif->backer, dupcall->packet, dupcall->key,
731 dupcall->key_len, &flow, &miss->key_fitness,
732 &ofproto, &odp_in_port);
734 if (error == ENODEV) {
735 struct drop_key *drop_key;
737 /* Received packet on datapath port for which we couldn't
738 * associate an ofproto. This can happen if a port is removed
739 * while traffic is being received. Print a rate-limited message
740 * in case it happens frequently. Install a drop flow so
741 * that future packets of the flow are inexpensively dropped
743 VLOG_INFO_RL(&rl, "received packet on unassociated datapath port "
744 "%"PRIu32, odp_in_port);
746 drop_key = xmalloc(sizeof *drop_key);
747 drop_key->key = xmemdup(dupcall->key, dupcall->key_len);
748 drop_key->key_len = dupcall->key_len;
750 if (guarded_list_push_back(&udpif->drop_keys, &drop_key->list_node,
752 seq_change(udpif->wait_seq);
754 COVERAGE_INC(drop_queue_overflow);
755 drop_key_destroy(drop_key);
762 flow_extract(dupcall->packet, flow.skb_priority, flow.pkt_mark,
763 &flow.tunnel, &flow.in_port, &miss->flow);
765 /* Add other packets to a to-do list. */
766 hash = flow_hash(&miss->flow, 0);
767 existing_miss = flow_miss_find(&fmb->misses, ofproto, &miss->flow, hash);
768 if (!existing_miss) {
769 hmap_insert(&fmb->misses, &miss->hmap_node, hash);
770 miss->ofproto = ofproto;
771 miss->key = dupcall->key;
772 miss->key_len = dupcall->key_len;
773 miss->upcall_type = dupcall->type;
774 list_init(&miss->upcalls);
778 miss = existing_miss;
780 list_remove(&upcall->list_node);
781 list_push_back(&miss->upcalls, &upcall->list_node);
784 LIST_FOR_EACH_SAFE (upcall, next, list_node, upcalls) {
785 list_remove(&upcall->list_node);
786 upcall_destroy(upcall);
789 /* Process each element in the to-do list, constructing the set of
790 * operations to batch. */
792 HMAP_FOR_EACH (miss, hmap_node, &fmb->misses) {
793 execute_flow_miss(miss, ops, &n_ops);
795 ovs_assert(n_ops <= ARRAY_SIZE(ops));
798 for (i = 0; i < n_ops; i++) {
801 dpif_operate(udpif->dpif, opsp, n_ops);
803 atomic_read(&udpif->reval_seq, &reval_seq);
804 if (reval_seq != fmb->reval_seq) {
805 COVERAGE_INC(fmb_queue_revalidated);
806 flow_miss_batch_destroy(fmb);
807 } else if (!guarded_list_push_back(&udpif->fmbs, &fmb->list_node,
809 COVERAGE_INC(fmb_queue_overflow);
810 flow_miss_batch_destroy(fmb);
812 seq_change(udpif->wait_seq);