1 /* Copyright (c) 2008, 2009, 2010, 2011, 2012 Nicira, Inc.
3 * Licensed under the Apache License, Version 2.0 (the "License");
4 * you may not use this file except in compliance with the License.
5 * You may obtain a copy of the License at:
7 * http://www.apache.org/licenses/LICENSE-2.0
9 * Unless required by applicable law or agreed to in writing, software
10 * distributed under the License is distributed on an "AS IS" BASIS,
11 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12 * See the License for the specific language governing permissions and
13 * limitations under the License.
28 #include "dynamic-string.h"
35 #include "mac-learning.h"
36 #include "meta-flow.h"
38 #include "ofp-print.h"
40 #include "ofproto/ofproto.h"
41 #include "poll-loop.h"
45 #include "socket-util.h"
47 #include "stream-ssl.h"
49 #include "system-stats.h"
54 #include "lib/vswitch-idl.h"
55 #include "xenserver.h"
57 #include "sflow_api.h"
58 #include "vlan-bitmap.h"
60 VLOG_DEFINE_THIS_MODULE(bridge);
62 COVERAGE_DEFINE(bridge_reconfigure);
64 /* Configuration of an uninstantiated iface. */
66 struct hmap_node hmap_node; /* Node in bridge's if_cfg_todo. */
67 const struct ovsrec_interface *cfg; /* Interface record. */
68 const struct ovsrec_port *parent; /* Parent port record. */
69 int64_t ofport; /* Requested OpenFlow port number. */
72 /* OpenFlow port slated for removal from ofproto. */
74 struct list list_node; /* Node in bridge's ofpp_garbage. */
75 uint16_t ofp_port; /* Port to be deleted. */
79 /* These members are always valid. */
80 struct list port_elem; /* Element in struct port's "ifaces" list. */
81 struct hmap_node name_node; /* In struct bridge's "iface_by_name" hmap. */
82 struct port *port; /* Containing port. */
83 char *name; /* Host network device name. */
85 /* These members are valid only after bridge_reconfigure() causes them to
87 struct hmap_node ofp_port_node; /* In struct bridge's "ifaces" hmap. */
88 int ofp_port; /* OpenFlow port number, -1 if unknown. */
89 struct netdev *netdev; /* Network device. */
90 const char *type; /* Usually same as cfg->type. */
91 const struct ovsrec_interface *cfg;
95 struct uuid uuid; /* UUID of this "mirror" record in database. */
96 struct hmap_node hmap_node; /* In struct bridge's "mirrors" hmap. */
97 struct bridge *bridge;
99 const struct ovsrec_mirror *cfg;
103 struct hmap_node hmap_node; /* Element in struct bridge's "ports" hmap. */
104 struct bridge *bridge;
107 const struct ovsrec_port *cfg;
109 /* An ordinary bridge port has 1 interface.
110 * A bridge port for bonding has at least 2 interfaces. */
111 struct list ifaces; /* List of "struct iface"s. */
115 struct hmap_node node; /* In 'all_bridges'. */
116 char *name; /* User-specified arbitrary name. */
117 char *type; /* Datapath type. */
118 uint8_t ea[ETH_ADDR_LEN]; /* Bridge Ethernet Address. */
119 uint8_t default_ea[ETH_ADDR_LEN]; /* Default MAC. */
120 const struct ovsrec_bridge *cfg;
122 /* OpenFlow switch processing. */
123 struct ofproto *ofproto; /* OpenFlow switch. */
126 struct hmap ports; /* "struct port"s indexed by name. */
127 struct hmap ifaces; /* "struct iface"s indexed by ofp_port. */
128 struct hmap iface_by_name; /* "struct iface"s indexed by name. */
130 struct list ofpp_garbage; /* "struct ofpp_garbage" slated for removal. */
131 struct hmap if_cfg_todo; /* "struct if_cfg"s slated for creation.
132 Indexed on 'cfg->name'. */
134 /* Port mirroring. */
135 struct hmap mirrors; /* "struct mirror" indexed by UUID. */
137 /* Synthetic local port if necessary. */
138 struct ovsrec_port synth_local_port;
139 struct ovsrec_interface synth_local_iface;
140 struct ovsrec_interface *synth_local_ifacep;
143 /* All bridges, indexed by name. */
144 static struct hmap all_bridges = HMAP_INITIALIZER(&all_bridges);
146 /* OVSDB IDL used to obtain configuration. */
147 static struct ovsdb_idl *idl;
149 /* Most recently processed IDL sequence number. */
150 static unsigned int idl_seqno;
152 /* Each time this timer expires, the bridge fetches interface and mirror
153 * statistics and pushes them into the database. */
154 #define IFACE_STATS_INTERVAL (5 * 1000) /* In milliseconds. */
155 static long long int iface_stats_timer = LLONG_MIN;
157 /* In some datapaths, creating and destroying OpenFlow ports can be extremely
158 * expensive. This can cause bridge_reconfigure() to take a long time during
159 * which no other work can be done. To deal with this problem, we limit port
160 * adds and deletions to a window of OFP_PORT_ACTION_WINDOW milliseconds per
161 * call to bridge_reconfigure(). If there is more work to do after the limit
162 * is reached, 'need_reconfigure', is flagged and it's done on the next loop.
163 * This allows the rest of the code to catch up on important things like
164 * forwarding packets. */
165 #define OFP_PORT_ACTION_WINDOW 10
166 static bool reconfiguring = false;
168 static void add_del_bridges(const struct ovsrec_open_vswitch *);
169 static void bridge_update_ofprotos(void);
170 static void bridge_create(const struct ovsrec_bridge *);
171 static void bridge_destroy(struct bridge *);
172 static struct bridge *bridge_lookup(const char *name);
173 static unixctl_cb_func bridge_unixctl_dump_flows;
174 static unixctl_cb_func bridge_unixctl_reconnect;
175 static size_t bridge_get_controllers(const struct bridge *br,
176 struct ovsrec_controller ***controllersp);
177 static void bridge_add_del_ports(struct bridge *,
178 const unsigned long int *splinter_vlans);
179 static void bridge_refresh_ofp_port(struct bridge *);
180 static void bridge_configure_datapath_id(struct bridge *);
181 static void bridge_configure_flow_eviction_threshold(struct bridge *);
182 static void bridge_configure_netflow(struct bridge *);
183 static void bridge_configure_forward_bpdu(struct bridge *);
184 static void bridge_configure_mac_idle_time(struct bridge *);
185 static void bridge_configure_sflow(struct bridge *, int *sflow_bridge_number);
186 static void bridge_configure_stp(struct bridge *);
187 static void bridge_configure_tables(struct bridge *);
188 static void bridge_configure_remotes(struct bridge *,
189 const struct sockaddr_in *managers,
191 static void bridge_pick_local_hw_addr(struct bridge *,
192 uint8_t ea[ETH_ADDR_LEN],
193 struct iface **hw_addr_iface);
194 static uint64_t bridge_pick_datapath_id(struct bridge *,
195 const uint8_t bridge_ea[ETH_ADDR_LEN],
196 struct iface *hw_addr_iface);
197 static void bridge_queue_if_cfg(struct bridge *,
198 const struct ovsrec_interface *,
199 const struct ovsrec_port *);
200 static uint64_t dpid_from_hash(const void *, size_t nbytes);
201 static bool bridge_has_bond_fake_iface(const struct bridge *,
203 static bool port_is_bond_fake_iface(const struct port *);
205 static unixctl_cb_func qos_unixctl_show;
207 static struct port *port_create(struct bridge *, const struct ovsrec_port *);
208 static void port_del_ifaces(struct port *);
209 static void port_destroy(struct port *);
210 static struct port *port_lookup(const struct bridge *, const char *name);
211 static void port_configure(struct port *);
212 static struct lacp_settings *port_configure_lacp(struct port *,
213 struct lacp_settings *);
214 static void port_configure_bond(struct port *, struct bond_settings *,
215 uint32_t *bond_stable_ids);
216 static bool port_is_synthetic(const struct port *);
218 static void reconfigure_system_stats(const struct ovsrec_open_vswitch *);
219 static void run_system_stats(void);
221 static void bridge_configure_mirrors(struct bridge *);
222 static struct mirror *mirror_create(struct bridge *,
223 const struct ovsrec_mirror *);
224 static void mirror_destroy(struct mirror *);
225 static bool mirror_configure(struct mirror *);
226 static void mirror_refresh_stats(struct mirror *);
228 static void iface_configure_lacp(struct iface *, struct lacp_slave_settings *);
229 static bool iface_create(struct bridge *, struct if_cfg *, int ofp_port);
230 static bool iface_is_internal(const struct ovsrec_interface *iface,
231 const struct ovsrec_bridge *br);
232 static const char *iface_get_type(const struct ovsrec_interface *,
233 const struct ovsrec_bridge *);
234 static void iface_destroy(struct iface *);
235 static struct iface *iface_lookup(const struct bridge *, const char *name);
236 static struct iface *iface_find(const char *name);
237 static struct if_cfg *if_cfg_lookup(const struct bridge *, const char *name);
238 static struct iface *iface_from_ofp_port(const struct bridge *,
240 static void iface_set_mac(struct iface *);
241 static void iface_set_ofport(const struct ovsrec_interface *, int64_t ofport);
242 static void iface_clear_db_record(const struct ovsrec_interface *if_cfg);
243 static void iface_configure_qos(struct iface *, const struct ovsrec_qos *);
244 static void iface_configure_cfm(struct iface *);
245 static void iface_refresh_cfm_stats(struct iface *);
246 static void iface_refresh_stats(struct iface *);
247 static void iface_refresh_status(struct iface *);
248 static bool iface_is_synthetic(const struct iface *);
250 /* Linux VLAN device support (e.g. "eth0.10" for VLAN 10.)
252 * This is deprecated. It is only for compatibility with broken device drivers
253 * in old versions of Linux that do not properly support VLANs when VLAN
254 * devices are not used. When broken device drivers are no longer in
255 * widespread use, we will delete these interfaces. */
257 /* True if VLAN splinters are enabled on any interface, false otherwise.*/
258 static bool vlan_splinters_enabled_anywhere;
260 static bool vlan_splinters_is_enabled(const struct ovsrec_interface *);
261 static unsigned long int *collect_splinter_vlans(
262 const struct ovsrec_open_vswitch *);
263 static void configure_splinter_port(struct port *);
264 static void add_vlan_splinter_ports(struct bridge *,
265 const unsigned long int *splinter_vlans,
266 struct shash *ports);
269 bridge_init_ofproto(const struct ovsrec_open_vswitch *cfg)
271 struct shash iface_hints;
272 static bool initialized = false;
279 shash_init(&iface_hints);
282 for (i = 0; i < cfg->n_bridges; i++) {
283 const struct ovsrec_bridge *br_cfg = cfg->bridges[i];
286 for (j = 0; j < br_cfg->n_ports; j++) {
287 struct ovsrec_port *port_cfg = br_cfg->ports[j];
290 for (k = 0; k < port_cfg->n_interfaces; k++) {
291 struct ovsrec_interface *if_cfg = port_cfg->interfaces[k];
292 struct iface_hint *iface_hint;
294 iface_hint = xmalloc(sizeof *iface_hint);
295 iface_hint->br_name = br_cfg->name;
296 iface_hint->br_type = br_cfg->datapath_type;
297 iface_hint->ofp_port = if_cfg->n_ofport_request ?
298 *if_cfg->ofport_request : OFPP_NONE;
300 shash_add(&iface_hints, if_cfg->name, iface_hint);
306 ofproto_init(&iface_hints);
308 shash_destroy_free_data(&iface_hints);
312 /* Public functions. */
314 /* Initializes the bridge module, configuring it to obtain its configuration
315 * from an OVSDB server accessed over 'remote', which should be a string in a
316 * form acceptable to ovsdb_idl_create(). */
318 bridge_init(const char *remote)
320 /* Create connection to database. */
321 idl = ovsdb_idl_create(remote, &ovsrec_idl_class, true);
322 idl_seqno = ovsdb_idl_get_seqno(idl);
323 ovsdb_idl_set_lock(idl, "ovs_vswitchd");
324 ovsdb_idl_verify_write_only(idl);
326 ovsdb_idl_omit_alert(idl, &ovsrec_open_vswitch_col_cur_cfg);
327 ovsdb_idl_omit_alert(idl, &ovsrec_open_vswitch_col_statistics);
328 ovsdb_idl_omit(idl, &ovsrec_open_vswitch_col_external_ids);
329 ovsdb_idl_omit(idl, &ovsrec_open_vswitch_col_ovs_version);
330 ovsdb_idl_omit(idl, &ovsrec_open_vswitch_col_db_version);
331 ovsdb_idl_omit(idl, &ovsrec_open_vswitch_col_system_type);
332 ovsdb_idl_omit(idl, &ovsrec_open_vswitch_col_system_version);
334 ovsdb_idl_omit_alert(idl, &ovsrec_bridge_col_datapath_id);
335 ovsdb_idl_omit_alert(idl, &ovsrec_bridge_col_status);
336 ovsdb_idl_omit(idl, &ovsrec_bridge_col_external_ids);
338 ovsdb_idl_omit_alert(idl, &ovsrec_port_col_status);
339 ovsdb_idl_omit_alert(idl, &ovsrec_port_col_statistics);
340 ovsdb_idl_omit(idl, &ovsrec_port_col_external_ids);
341 ovsdb_idl_omit(idl, &ovsrec_port_col_fake_bridge);
343 ovsdb_idl_omit_alert(idl, &ovsrec_interface_col_admin_state);
344 ovsdb_idl_omit_alert(idl, &ovsrec_interface_col_duplex);
345 ovsdb_idl_omit_alert(idl, &ovsrec_interface_col_link_speed);
346 ovsdb_idl_omit_alert(idl, &ovsrec_interface_col_link_state);
347 ovsdb_idl_omit_alert(idl, &ovsrec_interface_col_link_resets);
348 ovsdb_idl_omit_alert(idl, &ovsrec_interface_col_mtu);
349 ovsdb_idl_omit_alert(idl, &ovsrec_interface_col_ofport);
350 ovsdb_idl_omit_alert(idl, &ovsrec_interface_col_statistics);
351 ovsdb_idl_omit_alert(idl, &ovsrec_interface_col_status);
352 ovsdb_idl_omit_alert(idl, &ovsrec_interface_col_cfm_fault);
353 ovsdb_idl_omit_alert(idl, &ovsrec_interface_col_cfm_fault_status);
354 ovsdb_idl_omit_alert(idl, &ovsrec_interface_col_cfm_remote_mpids);
355 ovsdb_idl_omit_alert(idl, &ovsrec_interface_col_cfm_health);
356 ovsdb_idl_omit_alert(idl, &ovsrec_interface_col_cfm_remote_opstate);
357 ovsdb_idl_omit_alert(idl, &ovsrec_interface_col_lacp_current);
358 ovsdb_idl_omit(idl, &ovsrec_interface_col_external_ids);
360 ovsdb_idl_omit_alert(idl, &ovsrec_controller_col_is_connected);
361 ovsdb_idl_omit_alert(idl, &ovsrec_controller_col_role);
362 ovsdb_idl_omit_alert(idl, &ovsrec_controller_col_status);
363 ovsdb_idl_omit(idl, &ovsrec_controller_col_external_ids);
365 ovsdb_idl_omit(idl, &ovsrec_qos_col_external_ids);
367 ovsdb_idl_omit(idl, &ovsrec_queue_col_external_ids);
369 ovsdb_idl_omit(idl, &ovsrec_mirror_col_external_ids);
370 ovsdb_idl_omit_alert(idl, &ovsrec_mirror_col_statistics);
372 ovsdb_idl_omit(idl, &ovsrec_netflow_col_external_ids);
374 ovsdb_idl_omit(idl, &ovsrec_sflow_col_external_ids);
376 ovsdb_idl_omit(idl, &ovsrec_manager_col_external_ids);
377 ovsdb_idl_omit(idl, &ovsrec_manager_col_inactivity_probe);
378 ovsdb_idl_omit(idl, &ovsrec_manager_col_is_connected);
379 ovsdb_idl_omit(idl, &ovsrec_manager_col_max_backoff);
380 ovsdb_idl_omit(idl, &ovsrec_manager_col_status);
382 ovsdb_idl_omit(idl, &ovsrec_ssl_col_external_ids);
384 /* Register unixctl commands. */
385 unixctl_command_register("qos/show", "interface", 1, 1,
386 qos_unixctl_show, NULL);
387 unixctl_command_register("bridge/dump-flows", "bridge", 1, 1,
388 bridge_unixctl_dump_flows, NULL);
389 unixctl_command_register("bridge/reconnect", "[bridge]", 0, 1,
390 bridge_unixctl_reconnect, NULL);
400 struct bridge *br, *next_br;
402 HMAP_FOR_EACH_SAFE (br, next_br, node, &all_bridges) {
405 ovsdb_idl_destroy(idl);
408 /* Looks at the list of managers in 'ovs_cfg' and extracts their remote IP
409 * addresses and ports into '*managersp' and '*n_managersp'. The caller is
410 * responsible for freeing '*managersp' (with free()).
412 * You may be asking yourself "why does ovs-vswitchd care?", because
413 * ovsdb-server is responsible for connecting to the managers, and ovs-vswitchd
414 * should not be and in fact is not directly involved in that. But
415 * ovs-vswitchd needs to make sure that ovsdb-server can reach the managers, so
416 * it has to tell in-band control where the managers are to enable that.
417 * (Thus, only managers connected in-band are collected.)
420 collect_in_band_managers(const struct ovsrec_open_vswitch *ovs_cfg,
421 struct sockaddr_in **managersp, size_t *n_managersp)
423 struct sockaddr_in *managers = NULL;
424 size_t n_managers = 0;
428 /* Collect all of the potential targets from the "targets" columns of the
429 * rows pointed to by "manager_options", excluding any that are
432 for (i = 0; i < ovs_cfg->n_manager_options; i++) {
433 struct ovsrec_manager *m = ovs_cfg->manager_options[i];
435 if (m->connection_mode && !strcmp(m->connection_mode, "out-of-band")) {
436 sset_find_and_delete(&targets, m->target);
438 sset_add(&targets, m->target);
442 /* Now extract the targets' IP addresses. */
443 if (!sset_is_empty(&targets)) {
446 managers = xmalloc(sset_count(&targets) * sizeof *managers);
447 SSET_FOR_EACH (target, &targets) {
448 struct sockaddr_in *sin = &managers[n_managers];
450 if (stream_parse_target_with_default_ports(target,
458 sset_destroy(&targets);
460 *managersp = managers;
461 *n_managersp = n_managers;
465 bridge_reconfigure(const struct ovsrec_open_vswitch *ovs_cfg)
467 unsigned long int *splinter_vlans;
470 COVERAGE_INC(bridge_reconfigure);
472 assert(!reconfiguring);
473 reconfiguring = true;
475 /* Destroy "struct bridge"s, "struct port"s, and "struct iface"s according
476 * to 'ovs_cfg' while update the "if_cfg_queue", with only very minimal
477 * configuration otherwise.
479 * This is mostly an update to bridge data structures. Nothing is pushed
480 * down to ofproto or lower layers. */
481 add_del_bridges(ovs_cfg);
482 splinter_vlans = collect_splinter_vlans(ovs_cfg);
483 HMAP_FOR_EACH (br, node, &all_bridges) {
484 bridge_add_del_ports(br, splinter_vlans);
486 free(splinter_vlans);
488 /* Delete datapaths that are no longer configured, and create ones which
489 * don't exist but should. */
490 bridge_update_ofprotos();
492 /* Make sure each "struct iface" has a correct ofp_port in its ofproto. */
493 HMAP_FOR_EACH (br, node, &all_bridges) {
494 bridge_refresh_ofp_port(br);
497 /* Clear database records for "if_cfg"s which haven't been instantiated. */
498 HMAP_FOR_EACH (br, node, &all_bridges) {
499 struct if_cfg *if_cfg;
501 HMAP_FOR_EACH (if_cfg, hmap_node, &br->if_cfg_todo) {
502 iface_clear_db_record(if_cfg->cfg);
506 reconfigure_system_stats(ovs_cfg);
510 bridge_reconfigure_ofp(void)
512 long long int deadline;
516 deadline = time_msec() + OFP_PORT_ACTION_WINDOW;
518 /* The kernel will reject any attempt to add a given port to a datapath if
519 * that port already belongs to a different datapath, so we must do all
520 * port deletions before any port additions. */
521 HMAP_FOR_EACH (br, node, &all_bridges) {
522 struct ofpp_garbage *garbage, *next;
524 LIST_FOR_EACH_SAFE (garbage, next, list_node, &br->ofpp_garbage) {
525 /* It's a bit dangerous to call bridge_run_fast() here as ofproto's
526 * internal datastructures may not be consistent. Eventually, when
527 * port additions and deletions are cheaper, these calls should be
530 ofproto_port_del(br->ofproto, garbage->ofp_port);
531 list_remove(&garbage->list_node);
535 if (time_msec() >= deadline) {
542 HMAP_FOR_EACH (br, node, &all_bridges) {
543 struct if_cfg *if_cfg, *next;
545 HMAP_FOR_EACH_SAFE (if_cfg, next, hmap_node, &br->if_cfg_todo) {
546 iface_create(br, if_cfg, -1);
548 if (time_msec() >= deadline) {
558 bridge_reconfigure_continue(const struct ovsrec_open_vswitch *ovs_cfg)
560 struct sockaddr_in *managers;
561 int sflow_bridge_number;
566 assert(reconfiguring);
567 done = bridge_reconfigure_ofp();
569 /* Complete the configuration. */
570 sflow_bridge_number = 0;
571 collect_in_band_managers(ovs_cfg, &managers, &n_managers);
572 HMAP_FOR_EACH (br, node, &all_bridges) {
575 /* We need the datapath ID early to allow LACP ports to use it as the
576 * default system ID. */
577 bridge_configure_datapath_id(br);
579 HMAP_FOR_EACH (port, hmap_node, &br->ports) {
582 port_configure(port);
584 LIST_FOR_EACH (iface, port_elem, &port->ifaces) {
585 iface_configure_cfm(iface);
586 iface_configure_qos(iface, port->cfg->qos);
587 iface_set_mac(iface);
590 bridge_configure_mirrors(br);
591 bridge_configure_flow_eviction_threshold(br);
592 bridge_configure_forward_bpdu(br);
593 bridge_configure_mac_idle_time(br);
594 bridge_configure_remotes(br, managers, n_managers);
595 bridge_configure_netflow(br);
596 bridge_configure_sflow(br, &sflow_bridge_number);
597 bridge_configure_stp(br);
598 bridge_configure_tables(br);
603 /* ovs-vswitchd has completed initialization, so allow the process that
604 * forked us to exit successfully. */
605 daemonize_complete();
606 reconfiguring = false;
608 VLOG_INFO("%s (Open vSwitch) %s", program_name, VERSION);
614 /* Delete ofprotos which aren't configured or have the wrong type. Create
615 * ofprotos which don't exist but need to. */
617 bridge_update_ofprotos(void)
619 struct bridge *br, *next;
624 /* Delete ofprotos with no bridge or with the wrong type. */
627 ofproto_enumerate_types(&types);
628 SSET_FOR_EACH (type, &types) {
631 ofproto_enumerate_names(type, &names);
632 SSET_FOR_EACH (name, &names) {
633 br = bridge_lookup(name);
634 if (!br || strcmp(type, br->type)) {
635 ofproto_delete(name, type);
639 sset_destroy(&names);
640 sset_destroy(&types);
642 /* Add ofprotos for bridges which don't have one yet. */
643 HMAP_FOR_EACH_SAFE (br, next, node, &all_bridges) {
651 /* Remove ports from any datapath with the same name as 'br'. If we
652 * don't do this, creating 'br''s ofproto will fail because a port with
653 * the same name as its local port already exists. */
654 HMAP_FOR_EACH (br2, node, &all_bridges) {
655 struct ofproto_port ofproto_port;
661 if (!ofproto_port_query_by_name(br2->ofproto, br->name,
663 error = ofproto_port_del(br2->ofproto, ofproto_port.ofp_port);
665 VLOG_ERR("failed to delete port %s: %s", ofproto_port.name,
668 ofproto_port_destroy(&ofproto_port);
672 error = ofproto_create(br->name, br->type, &br->ofproto);
674 VLOG_ERR("failed to create bridge %s: %s", br->name,
682 port_configure(struct port *port)
684 const struct ovsrec_port *cfg = port->cfg;
685 struct bond_settings bond_settings;
686 struct lacp_settings lacp_settings;
687 struct ofproto_bundle_settings s;
690 if (cfg->vlan_mode && !strcmp(cfg->vlan_mode, "splinter")) {
691 configure_splinter_port(port);
700 s.slaves = xmalloc(list_size(&port->ifaces) * sizeof *s.slaves);
701 LIST_FOR_EACH (iface, port_elem, &port->ifaces) {
702 s.slaves[s.n_slaves++] = iface->ofp_port;
707 if (cfg->tag && *cfg->tag >= 0 && *cfg->tag <= 4095) {
711 /* Get VLAN trunks. */
714 s.trunks = vlan_bitmap_from_array(cfg->trunks, cfg->n_trunks);
718 if (cfg->vlan_mode) {
719 if (!strcmp(cfg->vlan_mode, "access")) {
720 s.vlan_mode = PORT_VLAN_ACCESS;
721 } else if (!strcmp(cfg->vlan_mode, "trunk")) {
722 s.vlan_mode = PORT_VLAN_TRUNK;
723 } else if (!strcmp(cfg->vlan_mode, "native-tagged")) {
724 s.vlan_mode = PORT_VLAN_NATIVE_TAGGED;
725 } else if (!strcmp(cfg->vlan_mode, "native-untagged")) {
726 s.vlan_mode = PORT_VLAN_NATIVE_UNTAGGED;
728 /* This "can't happen" because ovsdb-server should prevent it. */
729 VLOG_ERR("unknown VLAN mode %s", cfg->vlan_mode);
730 s.vlan_mode = PORT_VLAN_TRUNK;
734 s.vlan_mode = PORT_VLAN_ACCESS;
736 VLOG_ERR("port %s: ignoring trunks in favor of implicit vlan",
740 s.vlan_mode = PORT_VLAN_TRUNK;
743 s.use_priority_tags = smap_get_bool(&cfg->other_config, "priority-tags",
746 /* Get LACP settings. */
747 s.lacp = port_configure_lacp(port, &lacp_settings);
751 s.lacp_slaves = xmalloc(s.n_slaves * sizeof *s.lacp_slaves);
752 LIST_FOR_EACH (iface, port_elem, &port->ifaces) {
753 iface_configure_lacp(iface, &s.lacp_slaves[i++]);
756 s.lacp_slaves = NULL;
759 /* Get bond settings. */
760 if (s.n_slaves > 1) {
761 s.bond = &bond_settings;
762 s.bond_stable_ids = xmalloc(s.n_slaves * sizeof *s.bond_stable_ids);
763 port_configure_bond(port, &bond_settings, s.bond_stable_ids);
766 s.bond_stable_ids = NULL;
768 LIST_FOR_EACH (iface, port_elem, &port->ifaces) {
769 netdev_set_miimon_interval(iface->netdev, 0);
774 ofproto_bundle_register(port->bridge->ofproto, port, &s);
780 free(s.bond_stable_ids);
783 /* Pick local port hardware address and datapath ID for 'br'. */
785 bridge_configure_datapath_id(struct bridge *br)
787 uint8_t ea[ETH_ADDR_LEN];
789 struct iface *local_iface;
790 struct iface *hw_addr_iface;
793 bridge_pick_local_hw_addr(br, ea, &hw_addr_iface);
794 local_iface = iface_from_ofp_port(br, OFPP_LOCAL);
796 int error = netdev_set_etheraddr(local_iface->netdev, ea);
798 static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(1, 5);
799 VLOG_ERR_RL(&rl, "bridge %s: failed to set bridge "
800 "Ethernet address: %s",
801 br->name, strerror(error));
804 memcpy(br->ea, ea, ETH_ADDR_LEN);
806 dpid = bridge_pick_datapath_id(br, ea, hw_addr_iface);
807 if (dpid != ofproto_get_datapath_id(br->ofproto)) {
808 VLOG_INFO("bridge %s: using datapath ID %016"PRIx64, br->name, dpid);
809 ofproto_set_datapath_id(br->ofproto, dpid);
812 dpid_string = xasprintf("%016"PRIx64, dpid);
813 ovsrec_bridge_set_datapath_id(br->cfg, dpid_string);
817 /* Set NetFlow configuration on 'br'. */
819 bridge_configure_netflow(struct bridge *br)
821 struct ovsrec_netflow *cfg = br->cfg->netflow;
822 struct netflow_options opts;
825 ofproto_set_netflow(br->ofproto, NULL);
829 memset(&opts, 0, sizeof opts);
831 /* Get default NetFlow configuration from datapath.
832 * Apply overrides from 'cfg'. */
833 ofproto_get_netflow_ids(br->ofproto, &opts.engine_type, &opts.engine_id);
834 if (cfg->engine_type) {
835 opts.engine_type = *cfg->engine_type;
837 if (cfg->engine_id) {
838 opts.engine_id = *cfg->engine_id;
841 /* Configure active timeout interval. */
842 opts.active_timeout = cfg->active_timeout;
843 if (!opts.active_timeout) {
844 opts.active_timeout = -1;
845 } else if (opts.active_timeout < 0) {
846 VLOG_WARN("bridge %s: active timeout interval set to negative "
847 "value, using default instead (%d seconds)", br->name,
848 NF_ACTIVE_TIMEOUT_DEFAULT);
849 opts.active_timeout = -1;
852 /* Add engine ID to interface number to disambiguate bridgs? */
853 opts.add_id_to_iface = cfg->add_id_to_interface;
854 if (opts.add_id_to_iface) {
855 if (opts.engine_id > 0x7f) {
856 VLOG_WARN("bridge %s: NetFlow port mangling may conflict with "
857 "another vswitch, choose an engine id less than 128",
860 if (hmap_count(&br->ports) > 508) {
861 VLOG_WARN("bridge %s: NetFlow port mangling will conflict with "
862 "another port when more than 508 ports are used",
868 sset_init(&opts.collectors);
869 sset_add_array(&opts.collectors, cfg->targets, cfg->n_targets);
872 if (ofproto_set_netflow(br->ofproto, &opts)) {
873 VLOG_ERR("bridge %s: problem setting netflow collectors", br->name);
875 sset_destroy(&opts.collectors);
878 /* Set sFlow configuration on 'br'. */
880 bridge_configure_sflow(struct bridge *br, int *sflow_bridge_number)
882 const struct ovsrec_sflow *cfg = br->cfg->sflow;
883 struct ovsrec_controller **controllers;
884 struct ofproto_sflow_options oso;
885 size_t n_controllers;
889 ofproto_set_sflow(br->ofproto, NULL);
893 memset(&oso, 0, sizeof oso);
895 sset_init(&oso.targets);
896 sset_add_array(&oso.targets, cfg->targets, cfg->n_targets);
898 oso.sampling_rate = SFL_DEFAULT_SAMPLING_RATE;
900 oso.sampling_rate = *cfg->sampling;
903 oso.polling_interval = SFL_DEFAULT_POLLING_INTERVAL;
905 oso.polling_interval = *cfg->polling;
908 oso.header_len = SFL_DEFAULT_HEADER_SIZE;
910 oso.header_len = *cfg->header;
913 oso.sub_id = (*sflow_bridge_number)++;
914 oso.agent_device = cfg->agent;
916 oso.control_ip = NULL;
917 n_controllers = bridge_get_controllers(br, &controllers);
918 for (i = 0; i < n_controllers; i++) {
919 if (controllers[i]->local_ip) {
920 oso.control_ip = controllers[i]->local_ip;
924 ofproto_set_sflow(br->ofproto, &oso);
926 sset_destroy(&oso.targets);
930 port_configure_stp(const struct ofproto *ofproto, struct port *port,
931 struct ofproto_port_stp_settings *port_s,
932 int *port_num_counter, unsigned long *port_num_bitmap)
934 const char *config_str;
937 if (!smap_get_bool(&port->cfg->other_config, "stp-enable", true)) {
938 port_s->enable = false;
941 port_s->enable = true;
944 /* STP over bonds is not supported. */
945 if (!list_is_singleton(&port->ifaces)) {
946 VLOG_ERR("port %s: cannot enable STP on bonds, disabling",
948 port_s->enable = false;
952 iface = CONTAINER_OF(list_front(&port->ifaces), struct iface, port_elem);
954 /* Internal ports shouldn't participate in spanning tree, so
956 if (!strcmp(iface->type, "internal")) {
957 VLOG_DBG("port %s: disable STP on internal ports", port->name);
958 port_s->enable = false;
962 /* STP on mirror output ports is not supported. */
963 if (ofproto_is_mirror_output_bundle(ofproto, port)) {
964 VLOG_DBG("port %s: disable STP on mirror ports", port->name);
965 port_s->enable = false;
969 config_str = smap_get(&port->cfg->other_config, "stp-port-num");
971 unsigned long int port_num = strtoul(config_str, NULL, 0);
972 int port_idx = port_num - 1;
974 if (port_num < 1 || port_num > STP_MAX_PORTS) {
975 VLOG_ERR("port %s: invalid stp-port-num", port->name);
976 port_s->enable = false;
980 if (bitmap_is_set(port_num_bitmap, port_idx)) {
981 VLOG_ERR("port %s: duplicate stp-port-num %lu, disabling",
982 port->name, port_num);
983 port_s->enable = false;
986 bitmap_set1(port_num_bitmap, port_idx);
987 port_s->port_num = port_idx;
989 if (*port_num_counter >= STP_MAX_PORTS) {
990 VLOG_ERR("port %s: too many STP ports, disabling", port->name);
991 port_s->enable = false;
995 port_s->port_num = (*port_num_counter)++;
998 config_str = smap_get(&port->cfg->other_config, "stp-path-cost");
1000 port_s->path_cost = strtoul(config_str, NULL, 10);
1002 enum netdev_features current;
1005 netdev_get_features(iface->netdev, ¤t, NULL, NULL, NULL);
1006 mbps = netdev_features_to_bps(current, 100 * 1000 * 1000) / 1000000;
1007 port_s->path_cost = stp_convert_speed_to_cost(mbps);
1010 config_str = smap_get(&port->cfg->other_config, "stp-port-priority");
1012 port_s->priority = strtoul(config_str, NULL, 0);
1014 port_s->priority = STP_DEFAULT_PORT_PRIORITY;
1018 /* Set spanning tree configuration on 'br'. */
1020 bridge_configure_stp(struct bridge *br)
1022 if (!br->cfg->stp_enable) {
1023 ofproto_set_stp(br->ofproto, NULL);
1025 struct ofproto_stp_settings br_s;
1026 const char *config_str;
1028 int port_num_counter;
1029 unsigned long *port_num_bitmap;
1031 config_str = smap_get(&br->cfg->other_config, "stp-system-id");
1033 uint8_t ea[ETH_ADDR_LEN];
1035 if (eth_addr_from_string(config_str, ea)) {
1036 br_s.system_id = eth_addr_to_uint64(ea);
1038 br_s.system_id = eth_addr_to_uint64(br->ea);
1039 VLOG_ERR("bridge %s: invalid stp-system-id, defaulting "
1040 "to "ETH_ADDR_FMT, br->name, ETH_ADDR_ARGS(br->ea));
1043 br_s.system_id = eth_addr_to_uint64(br->ea);
1046 config_str = smap_get(&br->cfg->other_config, "stp-priority");
1048 br_s.priority = strtoul(config_str, NULL, 0);
1050 br_s.priority = STP_DEFAULT_BRIDGE_PRIORITY;
1053 config_str = smap_get(&br->cfg->other_config, "stp-hello-time");
1055 br_s.hello_time = strtoul(config_str, NULL, 10) * 1000;
1057 br_s.hello_time = STP_DEFAULT_HELLO_TIME;
1060 config_str = smap_get(&br->cfg->other_config, "stp-max-age");
1062 br_s.max_age = strtoul(config_str, NULL, 10) * 1000;
1064 br_s.max_age = STP_DEFAULT_MAX_AGE;
1067 config_str = smap_get(&br->cfg->other_config, "stp-forward-delay");
1069 br_s.fwd_delay = strtoul(config_str, NULL, 10) * 1000;
1071 br_s.fwd_delay = STP_DEFAULT_FWD_DELAY;
1074 /* Configure STP on the bridge. */
1075 if (ofproto_set_stp(br->ofproto, &br_s)) {
1076 VLOG_ERR("bridge %s: could not enable STP", br->name);
1080 /* Users must either set the port number with the "stp-port-num"
1081 * configuration on all ports or none. If manual configuration
1082 * is not done, then we allocate them sequentially. */
1083 port_num_counter = 0;
1084 port_num_bitmap = bitmap_allocate(STP_MAX_PORTS);
1085 HMAP_FOR_EACH (port, hmap_node, &br->ports) {
1086 struct ofproto_port_stp_settings port_s;
1087 struct iface *iface;
1089 port_configure_stp(br->ofproto, port, &port_s,
1090 &port_num_counter, port_num_bitmap);
1092 /* As bonds are not supported, just apply configuration to
1093 * all interfaces. */
1094 LIST_FOR_EACH (iface, port_elem, &port->ifaces) {
1095 if (ofproto_port_set_stp(br->ofproto, iface->ofp_port,
1097 VLOG_ERR("port %s: could not enable STP", port->name);
1103 if (bitmap_scan(port_num_bitmap, 0, STP_MAX_PORTS) != STP_MAX_PORTS
1104 && port_num_counter) {
1105 VLOG_ERR("bridge %s: must manually configure all STP port "
1106 "IDs or none, disabling", br->name);
1107 ofproto_set_stp(br->ofproto, NULL);
1109 bitmap_free(port_num_bitmap);
1114 bridge_has_bond_fake_iface(const struct bridge *br, const char *name)
1116 const struct port *port = port_lookup(br, name);
1117 return port && port_is_bond_fake_iface(port);
1121 port_is_bond_fake_iface(const struct port *port)
1123 return port->cfg->bond_fake_iface && !list_is_short(&port->ifaces);
1127 add_del_bridges(const struct ovsrec_open_vswitch *cfg)
1129 struct bridge *br, *next;
1130 struct shash new_br;
1133 /* Collect new bridges' names and types. */
1134 shash_init(&new_br);
1135 for (i = 0; i < cfg->n_bridges; i++) {
1136 static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(1, 5);
1137 const struct ovsrec_bridge *br_cfg = cfg->bridges[i];
1139 if (strchr(br_cfg->name, '/')) {
1140 /* Prevent remote ovsdb-server users from accessing arbitrary
1141 * directories, e.g. consider a bridge named "../../../etc/". */
1142 VLOG_WARN_RL(&rl, "ignoring bridge with invalid name \"%s\"",
1144 } else if (!shash_add_once(&new_br, br_cfg->name, br_cfg)) {
1145 VLOG_WARN_RL(&rl, "bridge %s specified twice", br_cfg->name);
1149 /* Get rid of deleted bridges or those whose types have changed.
1150 * Update 'cfg' of bridges that still exist. */
1151 HMAP_FOR_EACH_SAFE (br, next, node, &all_bridges) {
1152 br->cfg = shash_find_data(&new_br, br->name);
1153 if (!br->cfg || strcmp(br->type, ofproto_normalize_type(
1154 br->cfg->datapath_type))) {
1159 /* Add new bridges. */
1160 for (i = 0; i < cfg->n_bridges; i++) {
1161 const struct ovsrec_bridge *br_cfg = cfg->bridges[i];
1162 struct bridge *br = bridge_lookup(br_cfg->name);
1164 bridge_create(br_cfg);
1168 shash_destroy(&new_br);
1172 iface_set_ofp_port(struct iface *iface, int ofp_port)
1174 struct bridge *br = iface->port->bridge;
1176 assert(iface->ofp_port < 0 && ofp_port >= 0);
1177 iface->ofp_port = ofp_port;
1178 hmap_insert(&br->ifaces, &iface->ofp_port_node, hash_int(ofp_port, 0));
1179 iface_set_ofport(iface->cfg, ofp_port);
1182 /* Configures 'netdev' based on the "options" column in 'iface_cfg'.
1183 * Returns 0 if successful, otherwise a positive errno value. */
1185 iface_set_netdev_config(const struct ovsrec_interface *iface_cfg,
1186 struct netdev *netdev)
1190 error = netdev_set_config(netdev, &iface_cfg->options);
1192 VLOG_WARN("could not configure network device %s (%s)",
1193 iface_cfg->name, strerror(error));
1198 /* This function determines whether 'ofproto_port', which is attached to
1199 * br->ofproto's datapath, is one that we want in 'br'.
1201 * If it is, it returns true, after creating an iface (if necessary),
1202 * configuring the iface's netdev according to the iface's options, and setting
1203 * iface's ofp_port member to 'ofproto_port->ofp_port'.
1205 * If, on the other hand, 'port' should be removed, it returns false. The
1206 * caller should later detach the port from br->ofproto. */
1208 bridge_refresh_one_ofp_port(struct bridge *br,
1209 const struct ofproto_port *ofproto_port)
1211 const char *name = ofproto_port->name;
1212 const char *type = ofproto_port->type;
1213 uint16_t ofp_port = ofproto_port->ofp_port;
1215 struct iface *iface = iface_lookup(br, name);
1217 /* Check that the name-to-number mapping is one-to-one. */
1218 if (iface->ofp_port >= 0) {
1219 VLOG_WARN("bridge %s: interface %s reported twice",
1222 } else if (iface_from_ofp_port(br, ofp_port)) {
1223 VLOG_WARN("bridge %s: interface %"PRIu16" reported twice",
1224 br->name, ofp_port);
1228 /* There's a configured interface named 'name'. */
1229 if (strcmp(type, iface->type)
1230 || iface_set_netdev_config(iface->cfg, iface->netdev)) {
1231 /* It's the wrong type, or it's the right type but can't be
1232 * configured as the user requested, so we must destroy it. */
1235 /* It's the right type and configured correctly. keep it. */
1236 iface_set_ofp_port(iface, ofp_port);
1239 } else if (bridge_has_bond_fake_iface(br, name)
1240 && !strcmp(type, "internal")) {
1241 /* It's a bond fake iface. Keep it. */
1244 /* There's no configured interface named 'name', but there might be an
1245 * interface of that name queued to be created.
1247 * If there is, and it has the correct type, then try to configure it
1248 * and add it. If that's successful, we'll keep it. Otherwise, we'll
1249 * delete it and later try to re-add it. */
1250 struct if_cfg *if_cfg = if_cfg_lookup(br, name);
1252 && !strcmp(type, iface_get_type(if_cfg->cfg, br->cfg))
1253 && iface_create(br, if_cfg, ofp_port));
1257 /* Update bridges "if_cfg"s, "struct port"s, and "struct iface"s to be
1258 * consistent with the ofp_ports in "br->ofproto". */
1260 bridge_refresh_ofp_port(struct bridge *br)
1262 struct ofproto_port_dump dump;
1263 struct ofproto_port ofproto_port;
1264 struct port *port, *port_next;
1266 /* Clear each "struct iface"s ofp_port so we can get its correct value. */
1267 hmap_clear(&br->ifaces);
1268 HMAP_FOR_EACH (port, hmap_node, &br->ports) {
1269 struct iface *iface;
1271 LIST_FOR_EACH (iface, port_elem, &port->ifaces) {
1272 iface->ofp_port = -1;
1276 /* Obtain the correct "ofp_port"s from ofproto. Find any if_cfg's which
1277 * already exist in the datapath and promote them to full fledged "struct
1278 * iface"s. Mark ports in the datapath which don't belong as garbage. */
1279 OFPROTO_PORT_FOR_EACH (&ofproto_port, &dump, br->ofproto) {
1280 if (!bridge_refresh_one_ofp_port(br, &ofproto_port)) {
1281 struct ofpp_garbage *garbage = xmalloc(sizeof *garbage);
1282 garbage->ofp_port = ofproto_port.ofp_port;
1283 list_push_front(&br->ofpp_garbage, &garbage->list_node);
1287 /* Some ifaces may not have "ofp_port"s in ofproto and therefore don't
1288 * deserve to have "struct iface"s. Demote these to "if_cfg"s so that
1289 * later they can be added to ofproto. */
1290 HMAP_FOR_EACH_SAFE (port, port_next, hmap_node, &br->ports) {
1291 struct iface *iface, *iface_next;
1293 LIST_FOR_EACH_SAFE (iface, iface_next, port_elem, &port->ifaces) {
1294 if (iface->ofp_port < 0) {
1295 bridge_queue_if_cfg(br, iface->cfg, port->cfg);
1296 iface_destroy(iface);
1300 if (list_is_empty(&port->ifaces)) {
1306 /* Opens a network device for 'if_cfg' and configures it. If '*ofp_portp'
1307 * is negative, adds the network device to br->ofproto and stores the OpenFlow
1308 * port number in '*ofp_portp'; otherwise leaves br->ofproto and '*ofp_portp'
1311 * If successful, returns 0 and stores the network device in '*netdevp'. On
1312 * failure, returns a positive errno value and stores NULL in '*netdevp'. */
1314 iface_do_create(const struct bridge *br,
1315 const struct if_cfg *if_cfg,
1316 int *ofp_portp, struct netdev **netdevp)
1318 const struct ovsrec_interface *iface_cfg = if_cfg->cfg;
1319 const struct ovsrec_port *port_cfg = if_cfg->parent;
1320 struct netdev *netdev;
1323 error = netdev_open(iface_cfg->name,
1324 iface_get_type(iface_cfg, br->cfg), &netdev);
1326 VLOG_WARN("could not open network device %s (%s)",
1327 iface_cfg->name, strerror(error));
1331 error = iface_set_netdev_config(iface_cfg, netdev);
1336 if (*ofp_portp < 0) {
1337 uint16_t ofp_port = if_cfg->ofport;
1339 error = ofproto_port_add(br->ofproto, netdev, &ofp_port);
1343 *ofp_portp = ofp_port;
1345 VLOG_INFO("bridge %s: added interface %s on port %d",
1346 br->name, iface_cfg->name, *ofp_portp);
1348 VLOG_DBG("bridge %s: interface %s is on port %d",
1349 br->name, iface_cfg->name, *ofp_portp);
1352 if (port_cfg->vlan_mode && !strcmp(port_cfg->vlan_mode, "splinter")) {
1353 netdev_turn_flags_on(netdev, NETDEV_UP, true);
1361 netdev_close(netdev);
1365 /* Creates a new iface on 'br' based on 'if_cfg'. The new iface has OpenFlow
1366 * port number 'ofp_port'. If ofp_port is negative, an OpenFlow port is
1367 * automatically allocated for the iface. Takes ownership of and
1368 * deallocates 'if_cfg'.
1370 * Return true if an iface is successfully created, false otherwise. */
1372 iface_create(struct bridge *br, struct if_cfg *if_cfg, int ofp_port)
1374 const struct ovsrec_interface *iface_cfg = if_cfg->cfg;
1375 const struct ovsrec_port *port_cfg = if_cfg->parent;
1377 struct netdev *netdev;
1378 struct iface *iface;
1383 /* Do the bits that can fail up front.
1385 * It's a bit dangerous to call bridge_run_fast() here as ofproto's
1386 * internal datastructures may not be consistent. Eventually, when port
1387 * additions and deletions are cheaper, these calls should be removed. */
1389 assert(!iface_lookup(br, iface_cfg->name));
1390 error = iface_do_create(br, if_cfg, &ofp_port, &netdev);
1393 iface_clear_db_record(iface_cfg);
1398 /* Get or create the port structure. */
1399 port = port_lookup(br, port_cfg->name);
1401 port = port_create(br, port_cfg);
1404 /* Create the iface structure. */
1405 iface = xzalloc(sizeof *iface);
1406 list_push_back(&port->ifaces, &iface->port_elem);
1407 hmap_insert(&br->iface_by_name, &iface->name_node,
1408 hash_string(iface_cfg->name, 0));
1410 iface->name = xstrdup(iface_cfg->name);
1411 iface->ofp_port = -1;
1412 iface->netdev = netdev;
1413 iface->type = iface_get_type(iface_cfg, br->cfg);
1414 iface->cfg = iface_cfg;
1416 iface_set_ofp_port(iface, ofp_port);
1418 /* Populate initial status in database. */
1419 iface_refresh_stats(iface);
1420 iface_refresh_status(iface);
1422 /* Add bond fake iface if necessary. */
1423 if (port_is_bond_fake_iface(port)) {
1424 struct ofproto_port ofproto_port;
1426 if (ofproto_port_query_by_name(br->ofproto, port->name,
1428 struct netdev *netdev;
1431 error = netdev_open(port->name, "internal", &netdev);
1433 uint16_t ofp_port = if_cfg->ofport;
1435 ofproto_port_add(br->ofproto, netdev, &ofp_port);
1436 netdev_close(netdev);
1438 VLOG_WARN("could not open network device %s (%s)",
1439 port->name, strerror(error));
1442 /* Already exists, nothing to do. */
1443 ofproto_port_destroy(&ofproto_port);
1448 hmap_remove(&br->if_cfg_todo, &if_cfg->hmap_node);
1454 /* Set Flow eviction threshold */
1456 bridge_configure_flow_eviction_threshold(struct bridge *br)
1458 const char *threshold_str;
1461 threshold_str = smap_get(&br->cfg->other_config,
1462 "flow-eviction-threshold");
1463 if (threshold_str) {
1464 threshold = strtoul(threshold_str, NULL, 10);
1466 threshold = OFPROTO_FLOW_EVICTION_THRESHOLD_DEFAULT;
1468 ofproto_set_flow_eviction_threshold(br->ofproto, threshold);
1471 /* Set forward BPDU option. */
1473 bridge_configure_forward_bpdu(struct bridge *br)
1475 ofproto_set_forward_bpdu(br->ofproto,
1476 smap_get_bool(&br->cfg->other_config,
1481 /* Set MAC aging time for 'br'. */
1483 bridge_configure_mac_idle_time(struct bridge *br)
1485 const char *idle_time_str;
1488 idle_time_str = smap_get(&br->cfg->other_config, "mac-aging-time");
1489 idle_time = (idle_time_str && atoi(idle_time_str)
1490 ? atoi(idle_time_str)
1491 : MAC_ENTRY_DEFAULT_IDLE_TIME);
1492 ofproto_set_mac_idle_time(br->ofproto, idle_time);
1496 bridge_pick_local_hw_addr(struct bridge *br, uint8_t ea[ETH_ADDR_LEN],
1497 struct iface **hw_addr_iface)
1499 struct hmapx mirror_output_ports;
1502 bool found_addr = false;
1506 *hw_addr_iface = NULL;
1508 /* Did the user request a particular MAC? */
1509 hwaddr = smap_get(&br->cfg->other_config, "hwaddr");
1510 if (hwaddr && eth_addr_from_string(hwaddr, ea)) {
1511 if (eth_addr_is_multicast(ea)) {
1512 VLOG_ERR("bridge %s: cannot set MAC address to multicast "
1513 "address "ETH_ADDR_FMT, br->name, ETH_ADDR_ARGS(ea));
1514 } else if (eth_addr_is_zero(ea)) {
1515 VLOG_ERR("bridge %s: cannot set MAC address to zero", br->name);
1521 /* Mirror output ports don't participate in picking the local hardware
1522 * address. ofproto can't help us find out whether a given port is a
1523 * mirror output because we haven't configured mirrors yet, so we need to
1524 * accumulate them ourselves. */
1525 hmapx_init(&mirror_output_ports);
1526 for (i = 0; i < br->cfg->n_mirrors; i++) {
1527 struct ovsrec_mirror *m = br->cfg->mirrors[i];
1528 if (m->output_port) {
1529 hmapx_add(&mirror_output_ports, m->output_port);
1533 /* Otherwise choose the minimum non-local MAC address among all of the
1535 HMAP_FOR_EACH (port, hmap_node, &br->ports) {
1536 uint8_t iface_ea[ETH_ADDR_LEN];
1537 struct iface *candidate;
1538 struct iface *iface;
1540 /* Mirror output ports don't participate. */
1541 if (hmapx_contains(&mirror_output_ports, port->cfg)) {
1545 /* Choose the MAC address to represent the port. */
1547 if (port->cfg->mac && eth_addr_from_string(port->cfg->mac, iface_ea)) {
1548 /* Find the interface with this Ethernet address (if any) so that
1549 * we can provide the correct devname to the caller. */
1550 LIST_FOR_EACH (candidate, port_elem, &port->ifaces) {
1551 uint8_t candidate_ea[ETH_ADDR_LEN];
1552 if (!netdev_get_etheraddr(candidate->netdev, candidate_ea)
1553 && eth_addr_equals(iface_ea, candidate_ea)) {
1558 /* Choose the interface whose MAC address will represent the port.
1559 * The Linux kernel bonding code always chooses the MAC address of
1560 * the first slave added to a bond, and the Fedora networking
1561 * scripts always add slaves to a bond in alphabetical order, so
1562 * for compatibility we choose the interface with the name that is
1563 * first in alphabetical order. */
1564 LIST_FOR_EACH (candidate, port_elem, &port->ifaces) {
1565 if (!iface || strcmp(candidate->name, iface->name) < 0) {
1570 /* The local port doesn't count (since we're trying to choose its
1571 * MAC address anyway). */
1572 if (iface->ofp_port == OFPP_LOCAL) {
1577 error = netdev_get_etheraddr(iface->netdev, iface_ea);
1583 /* Compare against our current choice. */
1584 if (!eth_addr_is_multicast(iface_ea) &&
1585 !eth_addr_is_local(iface_ea) &&
1586 !eth_addr_is_reserved(iface_ea) &&
1587 !eth_addr_is_zero(iface_ea) &&
1588 (!found_addr || eth_addr_compare_3way(iface_ea, ea) < 0))
1590 memcpy(ea, iface_ea, ETH_ADDR_LEN);
1591 *hw_addr_iface = iface;
1596 VLOG_DBG("bridge %s: using bridge Ethernet address "ETH_ADDR_FMT,
1597 br->name, ETH_ADDR_ARGS(ea));
1599 static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(1, 10);
1600 memcpy(ea, br->default_ea, ETH_ADDR_LEN);
1601 *hw_addr_iface = NULL;
1602 VLOG_WARN_RL(&rl, "bridge %s: using default bridge Ethernet "
1603 "address "ETH_ADDR_FMT, br->name, ETH_ADDR_ARGS(ea));
1606 hmapx_destroy(&mirror_output_ports);
1609 /* Choose and returns the datapath ID for bridge 'br' given that the bridge
1610 * Ethernet address is 'bridge_ea'. If 'bridge_ea' is the Ethernet address of
1611 * an interface on 'br', then that interface must be passed in as
1612 * 'hw_addr_iface'; if 'bridge_ea' was derived some other way, then
1613 * 'hw_addr_iface' must be passed in as a null pointer. */
1615 bridge_pick_datapath_id(struct bridge *br,
1616 const uint8_t bridge_ea[ETH_ADDR_LEN],
1617 struct iface *hw_addr_iface)
1620 * The procedure for choosing a bridge MAC address will, in the most
1621 * ordinary case, also choose a unique MAC that we can use as a datapath
1622 * ID. In some special cases, though, multiple bridges will end up with
1623 * the same MAC address. This is OK for the bridges, but it will confuse
1624 * the OpenFlow controller, because each datapath needs a unique datapath
1627 * Datapath IDs must be unique. It is also very desirable that they be
1628 * stable from one run to the next, so that policy set on a datapath
1631 const char *datapath_id;
1634 datapath_id = smap_get(&br->cfg->other_config, "datapath-id");
1635 if (datapath_id && dpid_from_string(datapath_id, &dpid)) {
1639 if (!hw_addr_iface) {
1641 * A purely internal bridge, that is, one that has no non-virtual
1642 * network devices on it at all, is difficult because it has no
1643 * natural unique identifier at all.
1645 * When the host is a XenServer, we handle this case by hashing the
1646 * host's UUID with the name of the bridge. Names of bridges are
1647 * persistent across XenServer reboots, although they can be reused if
1648 * an internal network is destroyed and then a new one is later
1649 * created, so this is fairly effective.
1651 * When the host is not a XenServer, we punt by using a random MAC
1652 * address on each run.
1654 const char *host_uuid = xenserver_get_host_uuid();
1656 char *combined = xasprintf("%s,%s", host_uuid, br->name);
1657 dpid = dpid_from_hash(combined, strlen(combined));
1663 return eth_addr_to_uint64(bridge_ea);
1667 dpid_from_hash(const void *data, size_t n)
1669 uint8_t hash[SHA1_DIGEST_SIZE];
1671 BUILD_ASSERT_DECL(sizeof hash >= ETH_ADDR_LEN);
1672 sha1_bytes(data, n, hash);
1673 eth_addr_mark_random(hash);
1674 return eth_addr_to_uint64(hash);
1678 iface_refresh_status(struct iface *iface)
1682 enum netdev_features current;
1688 if (iface_is_synthetic(iface)) {
1694 if (!netdev_get_drv_info(iface->netdev, &smap)) {
1695 ovsrec_interface_set_status(iface->cfg, &smap);
1697 ovsrec_interface_set_status(iface->cfg, NULL);
1700 smap_destroy(&smap);
1702 error = netdev_get_features(iface->netdev, ¤t, NULL, NULL, NULL);
1703 bps = !error ? netdev_features_to_bps(current, 0) : 0;
1705 ovsrec_interface_set_duplex(iface->cfg,
1706 netdev_features_is_full_duplex(current)
1708 ovsrec_interface_set_link_speed(iface->cfg, &bps, 1);
1711 ovsrec_interface_set_duplex(iface->cfg, NULL);
1712 ovsrec_interface_set_link_speed(iface->cfg, NULL, 0);
1715 error = netdev_get_mtu(iface->netdev, &mtu);
1718 ovsrec_interface_set_mtu(iface->cfg, &mtu_64, 1);
1721 ovsrec_interface_set_mtu(iface->cfg, NULL, 0);
1725 /* Writes 'iface''s CFM statistics to the database. 'iface' must not be
1728 iface_refresh_cfm_stats(struct iface *iface)
1730 const struct ovsrec_interface *cfg = iface->cfg;
1731 int fault, opup, error;
1732 const uint64_t *rmps;
1736 fault = ofproto_port_get_cfm_fault(iface->port->bridge->ofproto,
1739 const char *reasons[CFM_FAULT_N_REASONS];
1740 bool fault_bool = fault;
1744 for (i = 0; i < CFM_FAULT_N_REASONS; i++) {
1745 int reason = 1 << i;
1746 if (fault & reason) {
1747 reasons[j++] = cfm_fault_reason_to_str(reason);
1751 ovsrec_interface_set_cfm_fault(cfg, &fault_bool, 1);
1752 ovsrec_interface_set_cfm_fault_status(cfg, (char **) reasons, j);
1754 ovsrec_interface_set_cfm_fault(cfg, NULL, 0);
1755 ovsrec_interface_set_cfm_fault_status(cfg, NULL, 0);
1758 opup = ofproto_port_get_cfm_opup(iface->port->bridge->ofproto,
1761 ovsrec_interface_set_cfm_remote_opstate(cfg, opup ? "up" : "down");
1763 ovsrec_interface_set_cfm_remote_opstate(cfg, NULL);
1766 error = ofproto_port_get_cfm_remote_mpids(iface->port->bridge->ofproto,
1767 iface->ofp_port, &rmps, &n_rmps);
1769 ovsrec_interface_set_cfm_remote_mpids(cfg, (const int64_t *)rmps,
1772 ovsrec_interface_set_cfm_remote_mpids(cfg, NULL, 0);
1775 health = ofproto_port_get_cfm_health(iface->port->bridge->ofproto,
1778 int64_t cfm_health = health;
1779 ovsrec_interface_set_cfm_health(cfg, &cfm_health, 1);
1781 ovsrec_interface_set_cfm_health(cfg, NULL, 0);
1786 iface_refresh_stats(struct iface *iface)
1788 #define IFACE_STATS \
1789 IFACE_STAT(rx_packets, "rx_packets") \
1790 IFACE_STAT(tx_packets, "tx_packets") \
1791 IFACE_STAT(rx_bytes, "rx_bytes") \
1792 IFACE_STAT(tx_bytes, "tx_bytes") \
1793 IFACE_STAT(rx_dropped, "rx_dropped") \
1794 IFACE_STAT(tx_dropped, "tx_dropped") \
1795 IFACE_STAT(rx_errors, "rx_errors") \
1796 IFACE_STAT(tx_errors, "tx_errors") \
1797 IFACE_STAT(rx_frame_errors, "rx_frame_err") \
1798 IFACE_STAT(rx_over_errors, "rx_over_err") \
1799 IFACE_STAT(rx_crc_errors, "rx_crc_err") \
1800 IFACE_STAT(collisions, "collisions")
1802 #define IFACE_STAT(MEMBER, NAME) NAME,
1803 static char *keys[] = { IFACE_STATS };
1805 int64_t values[ARRAY_SIZE(keys)];
1808 struct netdev_stats stats;
1810 if (iface_is_synthetic(iface)) {
1814 /* Intentionally ignore return value, since errors will set 'stats' to
1815 * all-1s, and we will deal with that correctly below. */
1816 netdev_get_stats(iface->netdev, &stats);
1818 /* Copy statistics into values[] array. */
1820 #define IFACE_STAT(MEMBER, NAME) values[i++] = stats.MEMBER;
1823 assert(i == ARRAY_SIZE(keys));
1825 ovsrec_interface_set_statistics(iface->cfg, keys, values,
1831 br_refresh_stp_status(struct bridge *br)
1833 struct smap smap = SMAP_INITIALIZER(&smap);
1834 struct ofproto *ofproto = br->ofproto;
1835 struct ofproto_stp_status status;
1837 if (ofproto_get_stp_status(ofproto, &status)) {
1841 if (!status.enabled) {
1842 ovsrec_bridge_set_status(br->cfg, NULL);
1846 smap_add_format(&smap, "stp_bridge_id", STP_ID_FMT,
1847 STP_ID_ARGS(status.bridge_id));
1848 smap_add_format(&smap, "stp_designated_root", STP_ID_FMT,
1849 STP_ID_ARGS(status.designated_root));
1850 smap_add_format(&smap, "stp_root_path_cost", "%d", status.root_path_cost);
1852 ovsrec_bridge_set_status(br->cfg, &smap);
1853 smap_destroy(&smap);
1857 port_refresh_stp_status(struct port *port)
1859 struct ofproto *ofproto = port->bridge->ofproto;
1860 struct iface *iface;
1861 struct ofproto_port_stp_status status;
1863 int64_t int_values[3];
1866 if (port_is_synthetic(port)) {
1870 /* STP doesn't currently support bonds. */
1871 if (!list_is_singleton(&port->ifaces)) {
1872 ovsrec_port_set_status(port->cfg, NULL);
1876 iface = CONTAINER_OF(list_front(&port->ifaces), struct iface, port_elem);
1878 if (ofproto_port_get_stp_status(ofproto, iface->ofp_port, &status)) {
1882 if (!status.enabled) {
1883 ovsrec_port_set_status(port->cfg, NULL);
1884 ovsrec_port_set_statistics(port->cfg, NULL, NULL, 0);
1888 /* Set Status column. */
1890 smap_add_format(&smap, "stp_port_id", STP_PORT_ID_FMT, status.port_id);
1891 smap_add(&smap, "stp_state", stp_state_name(status.state));
1892 smap_add_format(&smap, "stp_sec_in_state", "%u", status.sec_in_state);
1893 smap_add(&smap, "stp_role", stp_role_name(status.role));
1894 ovsrec_port_set_status(port->cfg, &smap);
1895 smap_destroy(&smap);
1897 /* Set Statistics column. */
1898 keys[0] = "stp_tx_count";
1899 int_values[0] = status.tx_count;
1900 keys[1] = "stp_rx_count";
1901 int_values[1] = status.rx_count;
1902 keys[2] = "stp_error_count";
1903 int_values[2] = status.error_count;
1905 ovsrec_port_set_statistics(port->cfg, keys, int_values,
1906 ARRAY_SIZE(int_values));
1910 enable_system_stats(const struct ovsrec_open_vswitch *cfg)
1912 return smap_get_bool(&cfg->other_config, "enable-statistics", false);
1916 reconfigure_system_stats(const struct ovsrec_open_vswitch *cfg)
1918 bool enable = enable_system_stats(cfg);
1920 system_stats_enable(enable);
1922 ovsrec_open_vswitch_set_statistics(cfg, NULL);
1927 run_system_stats(void)
1929 const struct ovsrec_open_vswitch *cfg = ovsrec_open_vswitch_first(idl);
1932 stats = system_stats_run();
1934 struct ovsdb_idl_txn *txn;
1935 struct ovsdb_datum datum;
1937 txn = ovsdb_idl_txn_create(idl);
1938 ovsdb_datum_from_smap(&datum, stats);
1939 ovsdb_idl_txn_write(&cfg->header_, &ovsrec_open_vswitch_col_statistics,
1941 ovsdb_idl_txn_commit(txn);
1942 ovsdb_idl_txn_destroy(txn);
1948 static inline const char *
1949 nx_role_to_str(enum nx_role role)
1954 case NX_ROLE_MASTER:
1959 return "*** INVALID ROLE ***";
1964 refresh_controller_status(void)
1968 const struct ovsrec_controller *cfg;
1972 /* Accumulate status for controllers on all bridges. */
1973 HMAP_FOR_EACH (br, node, &all_bridges) {
1974 ofproto_get_ofproto_controller_info(br->ofproto, &info);
1977 /* Update each controller in the database with current status. */
1978 OVSREC_CONTROLLER_FOR_EACH(cfg, idl) {
1979 struct ofproto_controller_info *cinfo =
1980 shash_find_data(&info, cfg->target);
1983 struct smap smap = SMAP_INITIALIZER(&smap);
1984 const char **values = cinfo->pairs.values;
1985 const char **keys = cinfo->pairs.keys;
1988 for (i = 0; i < cinfo->pairs.n; i++) {
1989 smap_add(&smap, keys[i], values[i]);
1992 ovsrec_controller_set_is_connected(cfg, cinfo->is_connected);
1993 ovsrec_controller_set_role(cfg, nx_role_to_str(cinfo->role));
1994 ovsrec_controller_set_status(cfg, &smap);
1995 smap_destroy(&smap);
1997 ovsrec_controller_set_is_connected(cfg, false);
1998 ovsrec_controller_set_role(cfg, NULL);
1999 ovsrec_controller_set_status(cfg, NULL);
2003 ofproto_free_ofproto_controller_info(&info);
2007 refresh_instant_stats(void)
2009 static struct ovsdb_idl_txn *txn = NULL;
2014 txn = ovsdb_idl_txn_create(idl);
2016 HMAP_FOR_EACH (br, node, &all_bridges) {
2017 struct iface *iface;
2020 br_refresh_stp_status(br);
2022 HMAP_FOR_EACH (port, hmap_node, &br->ports) {
2023 port_refresh_stp_status(port);
2026 HMAP_FOR_EACH (iface, name_node, &br->iface_by_name) {
2027 enum netdev_flags flags;
2028 const char *link_state;
2029 int64_t link_resets;
2032 if (iface_is_synthetic(iface)) {
2036 current = ofproto_port_is_lacp_current(br->ofproto,
2040 ovsrec_interface_set_lacp_current(iface->cfg, &bl, 1);
2042 ovsrec_interface_set_lacp_current(iface->cfg, NULL, 0);
2045 error = netdev_get_flags(iface->netdev, &flags);
2047 const char *state = flags & NETDEV_UP ? "up" : "down";
2048 ovsrec_interface_set_admin_state(iface->cfg, state);
2050 ovsrec_interface_set_admin_state(iface->cfg, NULL);
2053 link_state = netdev_get_carrier(iface->netdev) ? "up" : "down";
2054 ovsrec_interface_set_link_state(iface->cfg, link_state);
2056 link_resets = netdev_get_carrier_resets(iface->netdev);
2057 ovsrec_interface_set_link_resets(iface->cfg, &link_resets, 1);
2059 iface_refresh_cfm_stats(iface);
2064 if (ovsdb_idl_txn_commit(txn) != TXN_INCOMPLETE) {
2065 ovsdb_idl_txn_destroy(txn);
2070 /* Performs periodic activity required by bridges that needs to be done with
2071 * the least possible latency.
2073 * It makes sense to call this function a couple of times per poll loop, to
2074 * provide a significant performance boost on some benchmarks with ofprotos
2075 * that use the ofproto-dpif implementation. */
2077 bridge_run_fast(void)
2084 ofproto_enumerate_types(&types);
2085 SSET_FOR_EACH (type, &types) {
2086 ofproto_type_run_fast(type);
2088 sset_destroy(&types);
2090 HMAP_FOR_EACH (br, node, &all_bridges) {
2091 ofproto_run_fast(br->ofproto);
2098 static const struct ovsrec_open_vswitch null_cfg;
2099 const struct ovsrec_open_vswitch *cfg;
2100 struct ovsdb_idl_txn *reconf_txn = NULL;
2104 bool vlan_splinters_changed;
2107 ovsrec_open_vswitch_init((struct ovsrec_open_vswitch *) &null_cfg);
2109 /* (Re)configure if necessary. */
2110 if (!reconfiguring) {
2113 if (ovsdb_idl_is_lock_contended(idl)) {
2114 static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(1, 1);
2115 struct bridge *br, *next_br;
2117 VLOG_ERR_RL(&rl, "another ovs-vswitchd process is running, "
2118 "disabling this process until it goes away");
2120 HMAP_FOR_EACH_SAFE (br, next_br, node, &all_bridges) {
2124 } else if (!ovsdb_idl_has_lock(idl)) {
2128 cfg = ovsrec_open_vswitch_first(idl);
2130 /* Initialize the ofproto library. This only needs to run once, but
2131 * it must be done after the configuration is set. If the
2132 * initialization has already occurred, bridge_init_ofproto()
2133 * returns immediately. */
2134 bridge_init_ofproto(cfg);
2136 /* Let each datapath type do the work that it needs to do. */
2138 ofproto_enumerate_types(&types);
2139 SSET_FOR_EACH (type, &types) {
2140 ofproto_type_run(type);
2142 sset_destroy(&types);
2144 /* Let each bridge do the work that it needs to do. */
2145 HMAP_FOR_EACH (br, node, &all_bridges) {
2146 ofproto_run(br->ofproto);
2149 /* Re-configure SSL. We do this on every trip through the main loop,
2150 * instead of just when the database changes, because the contents of the
2151 * key and certificate files can change without the database changing.
2153 * We do this before bridge_reconfigure() because that function might
2154 * initiate SSL connections and thus requires SSL to be configured. */
2155 if (cfg && cfg->ssl) {
2156 const struct ovsrec_ssl *ssl = cfg->ssl;
2158 stream_ssl_set_key_and_cert(ssl->private_key, ssl->certificate);
2159 stream_ssl_set_ca_cert_file(ssl->ca_cert, ssl->bootstrap_ca_cert);
2162 if (!reconfiguring) {
2163 /* If VLAN splinters are in use, then we need to reconfigure if VLAN
2164 * usage has changed. */
2165 vlan_splinters_changed = false;
2166 if (vlan_splinters_enabled_anywhere) {
2167 HMAP_FOR_EACH (br, node, &all_bridges) {
2168 if (ofproto_has_vlan_usage_changed(br->ofproto)) {
2169 vlan_splinters_changed = true;
2175 if (ovsdb_idl_get_seqno(idl) != idl_seqno || vlan_splinters_changed) {
2176 idl_seqno = ovsdb_idl_get_seqno(idl);
2178 reconf_txn = ovsdb_idl_txn_create(idl);
2179 bridge_reconfigure(cfg);
2181 /* We still need to reconfigure to avoid dangling pointers to
2182 * now-destroyed ovsrec structures inside bridge data. */
2183 bridge_reconfigure(&null_cfg);
2188 if (reconfiguring) {
2191 reconf_txn = ovsdb_idl_txn_create(idl);
2193 if (bridge_reconfigure_continue(cfg)) {
2194 ovsrec_open_vswitch_set_cur_cfg(cfg, cfg->next_cfg);
2197 bridge_reconfigure_continue(&null_cfg);
2202 ovsdb_idl_txn_commit(reconf_txn);
2203 ovsdb_idl_txn_destroy(reconf_txn);
2207 /* Refresh interface and mirror stats if necessary. */
2208 if (time_msec() >= iface_stats_timer) {
2210 struct ovsdb_idl_txn *txn;
2212 txn = ovsdb_idl_txn_create(idl);
2213 HMAP_FOR_EACH (br, node, &all_bridges) {
2217 HMAP_FOR_EACH (port, hmap_node, &br->ports) {
2218 struct iface *iface;
2220 LIST_FOR_EACH (iface, port_elem, &port->ifaces) {
2221 iface_refresh_stats(iface);
2222 iface_refresh_status(iface);
2226 HMAP_FOR_EACH (m, hmap_node, &br->mirrors) {
2227 mirror_refresh_stats(m);
2231 refresh_controller_status();
2232 ovsdb_idl_txn_commit(txn);
2233 ovsdb_idl_txn_destroy(txn); /* XXX */
2236 iface_stats_timer = time_msec() + IFACE_STATS_INTERVAL;
2240 refresh_instant_stats();
2249 ovsdb_idl_wait(idl);
2251 if (reconfiguring) {
2252 poll_immediate_wake();
2256 ofproto_enumerate_types(&types);
2257 SSET_FOR_EACH (type, &types) {
2258 ofproto_type_wait(type);
2260 sset_destroy(&types);
2262 if (!hmap_is_empty(&all_bridges)) {
2265 HMAP_FOR_EACH (br, node, &all_bridges) {
2266 ofproto_wait(br->ofproto);
2268 poll_timer_wait_until(iface_stats_timer);
2271 system_stats_wait();
2274 /* Adds some memory usage statistics for bridges into 'usage', for use with
2275 * memory_report(). */
2277 bridge_get_memory_usage(struct simap *usage)
2281 HMAP_FOR_EACH (br, node, &all_bridges) {
2282 ofproto_get_memory_usage(br->ofproto, usage);
2286 /* QoS unixctl user interface functions. */
2288 struct qos_unixctl_show_cbdata {
2290 struct iface *iface;
2294 qos_unixctl_show_cb(unsigned int queue_id,
2295 const struct smap *details,
2298 struct qos_unixctl_show_cbdata *data = aux;
2299 struct ds *ds = data->ds;
2300 struct iface *iface = data->iface;
2301 struct netdev_queue_stats stats;
2302 struct smap_node *node;
2305 ds_put_cstr(ds, "\n");
2307 ds_put_format(ds, "Queue %u:\n", queue_id);
2309 ds_put_cstr(ds, "Default:\n");
2312 SMAP_FOR_EACH (node, details) {
2313 ds_put_format(ds, "\t%s: %s\n", node->key, node->value);
2316 error = netdev_get_queue_stats(iface->netdev, queue_id, &stats);
2318 if (stats.tx_packets != UINT64_MAX) {
2319 ds_put_format(ds, "\ttx_packets: %"PRIu64"\n", stats.tx_packets);
2322 if (stats.tx_bytes != UINT64_MAX) {
2323 ds_put_format(ds, "\ttx_bytes: %"PRIu64"\n", stats.tx_bytes);
2326 if (stats.tx_errors != UINT64_MAX) {
2327 ds_put_format(ds, "\ttx_errors: %"PRIu64"\n", stats.tx_errors);
2330 ds_put_format(ds, "\tFailed to get statistics for queue %u: %s",
2331 queue_id, strerror(error));
2336 qos_unixctl_show(struct unixctl_conn *conn, int argc OVS_UNUSED,
2337 const char *argv[], void *aux OVS_UNUSED)
2339 struct ds ds = DS_EMPTY_INITIALIZER;
2340 struct smap smap = SMAP_INITIALIZER(&smap);
2341 struct iface *iface;
2343 struct smap_node *node;
2344 struct qos_unixctl_show_cbdata data;
2347 iface = iface_find(argv[1]);
2349 unixctl_command_reply_error(conn, "no such interface");
2353 netdev_get_qos(iface->netdev, &type, &smap);
2355 if (*type != '\0') {
2356 ds_put_format(&ds, "QoS: %s %s\n", iface->name, type);
2358 SMAP_FOR_EACH (node, &smap) {
2359 ds_put_format(&ds, "%s: %s\n", node->key, node->value);
2364 error = netdev_dump_queues(iface->netdev, qos_unixctl_show_cb, &data);
2367 ds_put_format(&ds, "failed to dump queues: %s", strerror(error));
2369 unixctl_command_reply(conn, ds_cstr(&ds));
2371 ds_put_format(&ds, "QoS not configured on %s\n", iface->name);
2372 unixctl_command_reply_error(conn, ds_cstr(&ds));
2375 smap_destroy(&smap);
2379 /* Bridge reconfiguration functions. */
2381 bridge_create(const struct ovsrec_bridge *br_cfg)
2385 assert(!bridge_lookup(br_cfg->name));
2386 br = xzalloc(sizeof *br);
2388 br->name = xstrdup(br_cfg->name);
2389 br->type = xstrdup(ofproto_normalize_type(br_cfg->datapath_type));
2392 /* Derive the default Ethernet address from the bridge's UUID. This should
2393 * be unique and it will be stable between ovs-vswitchd runs. */
2394 memcpy(br->default_ea, &br_cfg->header_.uuid, ETH_ADDR_LEN);
2395 eth_addr_mark_random(br->default_ea);
2397 hmap_init(&br->ports);
2398 hmap_init(&br->ifaces);
2399 hmap_init(&br->iface_by_name);
2400 hmap_init(&br->mirrors);
2402 hmap_init(&br->if_cfg_todo);
2403 list_init(&br->ofpp_garbage);
2405 hmap_insert(&all_bridges, &br->node, hash_string(br->name, 0));
2409 bridge_destroy(struct bridge *br)
2412 struct mirror *mirror, *next_mirror;
2413 struct port *port, *next_port;
2414 struct if_cfg *if_cfg, *next_if_cfg;
2415 struct ofpp_garbage *garbage, *next_garbage;
2417 HMAP_FOR_EACH_SAFE (port, next_port, hmap_node, &br->ports) {
2420 HMAP_FOR_EACH_SAFE (mirror, next_mirror, hmap_node, &br->mirrors) {
2421 mirror_destroy(mirror);
2423 HMAP_FOR_EACH_SAFE (if_cfg, next_if_cfg, hmap_node, &br->if_cfg_todo) {
2424 hmap_remove(&br->if_cfg_todo, &if_cfg->hmap_node);
2427 LIST_FOR_EACH_SAFE (garbage, next_garbage, list_node,
2428 &br->ofpp_garbage) {
2429 list_remove(&garbage->list_node);
2433 hmap_remove(&all_bridges, &br->node);
2434 ofproto_destroy(br->ofproto);
2435 hmap_destroy(&br->ifaces);
2436 hmap_destroy(&br->ports);
2437 hmap_destroy(&br->iface_by_name);
2438 hmap_destroy(&br->mirrors);
2439 hmap_destroy(&br->if_cfg_todo);
2446 static struct bridge *
2447 bridge_lookup(const char *name)
2451 HMAP_FOR_EACH_WITH_HASH (br, node, hash_string(name, 0), &all_bridges) {
2452 if (!strcmp(br->name, name)) {
2459 /* Handle requests for a listing of all flows known by the OpenFlow
2460 * stack, including those normally hidden. */
2462 bridge_unixctl_dump_flows(struct unixctl_conn *conn, int argc OVS_UNUSED,
2463 const char *argv[], void *aux OVS_UNUSED)
2468 br = bridge_lookup(argv[1]);
2470 unixctl_command_reply_error(conn, "Unknown bridge");
2475 ofproto_get_all_flows(br->ofproto, &results);
2477 unixctl_command_reply(conn, ds_cstr(&results));
2478 ds_destroy(&results);
2481 /* "bridge/reconnect [BRIDGE]": makes BRIDGE drop all of its controller
2482 * connections and reconnect. If BRIDGE is not specified, then all bridges
2483 * drop their controller connections and reconnect. */
2485 bridge_unixctl_reconnect(struct unixctl_conn *conn, int argc,
2486 const char *argv[], void *aux OVS_UNUSED)
2490 br = bridge_lookup(argv[1]);
2492 unixctl_command_reply_error(conn, "Unknown bridge");
2495 ofproto_reconnect_controllers(br->ofproto);
2497 HMAP_FOR_EACH (br, node, &all_bridges) {
2498 ofproto_reconnect_controllers(br->ofproto);
2501 unixctl_command_reply(conn, NULL);
2505 bridge_get_controllers(const struct bridge *br,
2506 struct ovsrec_controller ***controllersp)
2508 struct ovsrec_controller **controllers;
2509 size_t n_controllers;
2511 controllers = br->cfg->controller;
2512 n_controllers = br->cfg->n_controller;
2514 if (n_controllers == 1 && !strcmp(controllers[0]->target, "none")) {
2520 *controllersp = controllers;
2522 return n_controllers;
2526 bridge_queue_if_cfg(struct bridge *br,
2527 const struct ovsrec_interface *cfg,
2528 const struct ovsrec_port *parent)
2530 struct if_cfg *if_cfg = xmalloc(sizeof *if_cfg);
2533 if_cfg->parent = parent;
2534 if_cfg->ofport = cfg->n_ofport_request ? *cfg->ofport_request : OFPP_NONE;
2535 hmap_insert(&br->if_cfg_todo, &if_cfg->hmap_node,
2536 hash_string(if_cfg->cfg->name, 0));
2539 /* Deletes "struct port"s and "struct iface"s under 'br' which aren't
2540 * consistent with 'br->cfg'. Updates 'br->if_cfg_queue' with interfaces which
2541 * 'br' needs to complete its configuration. */
2543 bridge_add_del_ports(struct bridge *br,
2544 const unsigned long int *splinter_vlans)
2546 struct shash_node *port_node;
2547 struct port *port, *next;
2548 struct shash new_ports;
2551 assert(hmap_is_empty(&br->if_cfg_todo));
2553 /* Collect new ports. */
2554 shash_init(&new_ports);
2555 for (i = 0; i < br->cfg->n_ports; i++) {
2556 const char *name = br->cfg->ports[i]->name;
2557 if (!shash_add_once(&new_ports, name, br->cfg->ports[i])) {
2558 VLOG_WARN("bridge %s: %s specified twice as bridge port",
2562 if (bridge_get_controllers(br, NULL)
2563 && !shash_find(&new_ports, br->name)) {
2564 VLOG_WARN("bridge %s: no port named %s, synthesizing one",
2565 br->name, br->name);
2567 ovsrec_interface_init(&br->synth_local_iface);
2568 ovsrec_port_init(&br->synth_local_port);
2570 br->synth_local_port.interfaces = &br->synth_local_ifacep;
2571 br->synth_local_port.n_interfaces = 1;
2572 br->synth_local_port.name = br->name;
2574 br->synth_local_iface.name = br->name;
2575 br->synth_local_iface.type = "internal";
2577 br->synth_local_ifacep = &br->synth_local_iface;
2579 shash_add(&new_ports, br->name, &br->synth_local_port);
2582 if (splinter_vlans) {
2583 add_vlan_splinter_ports(br, splinter_vlans, &new_ports);
2586 /* Get rid of deleted ports.
2587 * Get rid of deleted interfaces on ports that still exist. */
2588 HMAP_FOR_EACH_SAFE (port, next, hmap_node, &br->ports) {
2589 port->cfg = shash_find_data(&new_ports, port->name);
2593 port_del_ifaces(port);
2597 /* Update iface->cfg and iface->type in interfaces that still exist.
2598 * Add new interfaces to creation queue. */
2599 SHASH_FOR_EACH (port_node, &new_ports) {
2600 const struct ovsrec_port *port = port_node->data;
2603 for (i = 0; i < port->n_interfaces; i++) {
2604 const struct ovsrec_interface *cfg = port->interfaces[i];
2605 struct iface *iface = iface_lookup(br, cfg->name);
2606 const char *type = iface_get_type(cfg, br->cfg);
2611 } else if (!strcmp(type, "null")) {
2612 VLOG_WARN_ONCE("%s: The null interface type is deprecated and"
2613 " may be removed in February 2013. Please email"
2614 " dev@openvswitch.org with concerns.",
2617 bridge_queue_if_cfg(br, cfg, port);
2622 shash_destroy(&new_ports);
2625 /* Initializes 'oc' appropriately as a management service controller for
2628 * The caller must free oc->target when it is no longer needed. */
2630 bridge_ofproto_controller_for_mgmt(const struct bridge *br,
2631 struct ofproto_controller *oc)
2633 oc->target = xasprintf("punix:%s/%s.mgmt", ovs_rundir(), br->name);
2634 oc->max_backoff = 0;
2635 oc->probe_interval = 60;
2636 oc->band = OFPROTO_OUT_OF_BAND;
2638 oc->burst_limit = 0;
2639 oc->enable_async_msgs = true;
2642 /* Converts ovsrec_controller 'c' into an ofproto_controller in 'oc'. */
2644 bridge_ofproto_controller_from_ovsrec(const struct ovsrec_controller *c,
2645 struct ofproto_controller *oc)
2649 oc->target = c->target;
2650 oc->max_backoff = c->max_backoff ? *c->max_backoff / 1000 : 8;
2651 oc->probe_interval = c->inactivity_probe ? *c->inactivity_probe / 1000 : 5;
2652 oc->band = (!c->connection_mode || !strcmp(c->connection_mode, "in-band")
2653 ? OFPROTO_IN_BAND : OFPROTO_OUT_OF_BAND);
2654 oc->rate_limit = c->controller_rate_limit ? *c->controller_rate_limit : 0;
2655 oc->burst_limit = (c->controller_burst_limit
2656 ? *c->controller_burst_limit : 0);
2657 oc->enable_async_msgs = (!c->enable_async_messages
2658 || *c->enable_async_messages);
2659 dscp = smap_get_int(&c->other_config, "dscp", DSCP_DEFAULT);
2660 if (dscp < 0 || dscp > 63) {
2661 dscp = DSCP_DEFAULT;
2666 /* Configures the IP stack for 'br''s local interface properly according to the
2667 * configuration in 'c'. */
2669 bridge_configure_local_iface_netdev(struct bridge *br,
2670 struct ovsrec_controller *c)
2672 struct netdev *netdev;
2673 struct in_addr mask, gateway;
2675 struct iface *local_iface;
2678 /* If there's no local interface or no IP address, give up. */
2679 local_iface = iface_from_ofp_port(br, OFPP_LOCAL);
2680 if (!local_iface || !c->local_ip || !inet_aton(c->local_ip, &ip)) {
2684 /* Bring up the local interface. */
2685 netdev = local_iface->netdev;
2686 netdev_turn_flags_on(netdev, NETDEV_UP, true);
2688 /* Configure the IP address and netmask. */
2689 if (!c->local_netmask
2690 || !inet_aton(c->local_netmask, &mask)
2692 mask.s_addr = guess_netmask(ip.s_addr);
2694 if (!netdev_set_in4(netdev, ip, mask)) {
2695 VLOG_INFO("bridge %s: configured IP address "IP_FMT", netmask "IP_FMT,
2696 br->name, IP_ARGS(&ip.s_addr), IP_ARGS(&mask.s_addr));
2699 /* Configure the default gateway. */
2700 if (c->local_gateway
2701 && inet_aton(c->local_gateway, &gateway)
2702 && gateway.s_addr) {
2703 if (!netdev_add_router(netdev, gateway)) {
2704 VLOG_INFO("bridge %s: configured gateway "IP_FMT,
2705 br->name, IP_ARGS(&gateway.s_addr));
2710 /* Returns true if 'a' and 'b' are the same except that any number of slashes
2711 * in either string are treated as equal to any number of slashes in the other,
2712 * e.g. "x///y" is equal to "x/y". */
2714 equal_pathnames(const char *a, const char *b)
2718 a += strspn(a, "/");
2719 b += strspn(b, "/");
2720 } else if (*a == '\0') {
2731 bridge_configure_remotes(struct bridge *br,
2732 const struct sockaddr_in *managers, size_t n_managers)
2734 bool disable_in_band;
2736 struct ovsrec_controller **controllers;
2737 size_t n_controllers;
2739 enum ofproto_fail_mode fail_mode;
2741 struct ofproto_controller *ocs;
2745 /* Check if we should disable in-band control on this bridge. */
2746 disable_in_band = smap_get_bool(&br->cfg->other_config, "disable-in-band",
2749 /* Set OpenFlow queue ID for in-band control. */
2750 ofproto_set_in_band_queue(br->ofproto,
2751 smap_get_int(&br->cfg->other_config,
2752 "in-band-queue", -1));
2754 if (disable_in_band) {
2755 ofproto_set_extra_in_band_remotes(br->ofproto, NULL, 0);
2757 ofproto_set_extra_in_band_remotes(br->ofproto, managers, n_managers);
2760 n_controllers = bridge_get_controllers(br, &controllers);
2762 ocs = xmalloc((n_controllers + 1) * sizeof *ocs);
2765 bridge_ofproto_controller_for_mgmt(br, &ocs[n_ocs++]);
2766 for (i = 0; i < n_controllers; i++) {
2767 struct ovsrec_controller *c = controllers[i];
2769 if (!strncmp(c->target, "punix:", 6)
2770 || !strncmp(c->target, "unix:", 5)) {
2771 static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(1, 5);
2774 whitelist = xasprintf("unix:%s/%s.controller",
2775 ovs_rundir(), br->name);
2776 if (!equal_pathnames(c->target, whitelist)) {
2777 /* Prevent remote ovsdb-server users from accessing arbitrary
2778 * Unix domain sockets and overwriting arbitrary local
2780 VLOG_ERR_RL(&rl, "bridge %s: Not adding Unix domain socket "
2781 "controller \"%s\" due to possibility for remote "
2782 "exploit. Instead, specify whitelisted \"%s\" or "
2783 "connect to \"unix:%s/%s.mgmt\" (which is always "
2784 "available without special configuration).",
2785 br->name, c->target, whitelist,
2786 ovs_rundir(), br->name);
2794 bridge_configure_local_iface_netdev(br, c);
2795 bridge_ofproto_controller_from_ovsrec(c, &ocs[n_ocs]);
2796 if (disable_in_band) {
2797 ocs[n_ocs].band = OFPROTO_OUT_OF_BAND;
2802 ofproto_set_controllers(br->ofproto, ocs, n_ocs, 0);
2803 free(ocs[0].target); /* From bridge_ofproto_controller_for_mgmt(). */
2806 /* Set the fail-mode. */
2807 fail_mode = !br->cfg->fail_mode
2808 || !strcmp(br->cfg->fail_mode, "standalone")
2809 ? OFPROTO_FAIL_STANDALONE
2810 : OFPROTO_FAIL_SECURE;
2811 ofproto_set_fail_mode(br->ofproto, fail_mode);
2813 /* Configure OpenFlow controller connection snooping. */
2814 if (!ofproto_has_snoops(br->ofproto)) {
2818 sset_add_and_free(&snoops, xasprintf("punix:%s/%s.snoop",
2819 ovs_rundir(), br->name));
2820 ofproto_set_snoops(br->ofproto, &snoops);
2821 sset_destroy(&snoops);
2826 bridge_configure_tables(struct bridge *br)
2828 static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(1, 5);
2832 n_tables = ofproto_get_n_tables(br->ofproto);
2834 for (i = 0; i < n_tables; i++) {
2835 struct ofproto_table_settings s;
2838 s.max_flows = UINT_MAX;
2842 if (j < br->cfg->n_flow_tables && i == br->cfg->key_flow_tables[j]) {
2843 struct ovsrec_flow_table *cfg = br->cfg->value_flow_tables[j++];
2846 if (cfg->n_flow_limit && *cfg->flow_limit < UINT_MAX) {
2847 s.max_flows = *cfg->flow_limit;
2849 if (cfg->overflow_policy
2850 && !strcmp(cfg->overflow_policy, "evict")) {
2853 s.groups = xmalloc(cfg->n_groups * sizeof *s.groups);
2854 for (k = 0; k < cfg->n_groups; k++) {
2855 const char *string = cfg->groups[k];
2858 msg = mf_parse_subfield__(&s.groups[k], &string);
2860 VLOG_WARN_RL(&rl, "bridge %s table %d: error parsing "
2861 "'groups' (%s)", br->name, i, msg);
2863 } else if (*string) {
2864 VLOG_WARN_RL(&rl, "bridge %s table %d: 'groups' "
2865 "element '%s' contains trailing garbage",
2866 br->name, i, cfg->groups[k]);
2874 ofproto_configure_table(br->ofproto, i, &s);
2878 for (; j < br->cfg->n_flow_tables; j++) {
2879 VLOG_WARN_RL(&rl, "bridge %s: ignoring configuration for flow table "
2880 "%"PRId64" not supported by this datapath", br->name,
2881 br->cfg->key_flow_tables[j]);
2885 /* Port functions. */
2887 static struct port *
2888 port_create(struct bridge *br, const struct ovsrec_port *cfg)
2892 port = xzalloc(sizeof *port);
2894 port->name = xstrdup(cfg->name);
2896 list_init(&port->ifaces);
2898 hmap_insert(&br->ports, &port->hmap_node, hash_string(port->name, 0));
2902 /* Deletes interfaces from 'port' that are no longer configured for it. */
2904 port_del_ifaces(struct port *port)
2906 struct iface *iface, *next;
2907 struct sset new_ifaces;
2910 /* Collect list of new interfaces. */
2911 sset_init(&new_ifaces);
2912 for (i = 0; i < port->cfg->n_interfaces; i++) {
2913 const char *name = port->cfg->interfaces[i]->name;
2914 const char *type = port->cfg->interfaces[i]->type;
2915 if (strcmp(type, "null")) {
2916 sset_add(&new_ifaces, name);
2920 /* Get rid of deleted interfaces. */
2921 LIST_FOR_EACH_SAFE (iface, next, port_elem, &port->ifaces) {
2922 if (!sset_contains(&new_ifaces, iface->name)) {
2923 iface_destroy(iface);
2927 sset_destroy(&new_ifaces);
2931 port_destroy(struct port *port)
2934 struct bridge *br = port->bridge;
2935 struct iface *iface, *next;
2938 ofproto_bundle_unregister(br->ofproto, port);
2941 LIST_FOR_EACH_SAFE (iface, next, port_elem, &port->ifaces) {
2942 iface_destroy(iface);
2945 hmap_remove(&br->ports, &port->hmap_node);
2951 static struct port *
2952 port_lookup(const struct bridge *br, const char *name)
2956 HMAP_FOR_EACH_WITH_HASH (port, hmap_node, hash_string(name, 0),
2958 if (!strcmp(port->name, name)) {
2966 enable_lacp(struct port *port, bool *activep)
2968 if (!port->cfg->lacp) {
2969 /* XXX when LACP implementation has been sufficiently tested, enable by
2970 * default and make active on bonded ports. */
2972 } else if (!strcmp(port->cfg->lacp, "off")) {
2974 } else if (!strcmp(port->cfg->lacp, "active")) {
2977 } else if (!strcmp(port->cfg->lacp, "passive")) {
2981 VLOG_WARN("port %s: unknown LACP mode %s",
2982 port->name, port->cfg->lacp);
2987 static struct lacp_settings *
2988 port_configure_lacp(struct port *port, struct lacp_settings *s)
2990 const char *lacp_time, *system_id;
2993 if (!enable_lacp(port, &s->active)) {
2997 s->name = port->name;
2999 system_id = smap_get(&port->cfg->other_config, "lacp-system-id");
3001 if (sscanf(system_id, ETH_ADDR_SCAN_FMT,
3002 ETH_ADDR_SCAN_ARGS(s->id)) != ETH_ADDR_SCAN_COUNT) {
3003 VLOG_WARN("port %s: LACP system ID (%s) must be an Ethernet"
3004 " address.", port->name, system_id);
3008 memcpy(s->id, port->bridge->ea, ETH_ADDR_LEN);
3011 if (eth_addr_is_zero(s->id)) {
3012 VLOG_WARN("port %s: Invalid zero LACP system ID.", port->name);
3016 /* Prefer bondable links if unspecified. */
3017 priority = smap_get_int(&port->cfg->other_config, "lacp-system-priority",
3019 s->priority = (priority > 0 && priority <= UINT16_MAX
3021 : UINT16_MAX - !list_is_short(&port->ifaces));
3023 lacp_time = smap_get(&port->cfg->other_config, "lacp-time");
3024 s->fast = lacp_time && !strcasecmp(lacp_time, "fast");
3029 iface_configure_lacp(struct iface *iface, struct lacp_slave_settings *s)
3031 int priority, portid, key;
3033 portid = smap_get_int(&iface->cfg->other_config, "lacp-port-id", 0);
3034 priority = smap_get_int(&iface->cfg->other_config, "lacp-port-priority",
3036 key = smap_get_int(&iface->cfg->other_config, "lacp-aggregation-key", 0);
3038 if (portid <= 0 || portid > UINT16_MAX) {
3039 portid = iface->ofp_port;
3042 if (priority <= 0 || priority > UINT16_MAX) {
3043 priority = UINT16_MAX;
3046 if (key < 0 || key > UINT16_MAX) {
3050 s->name = iface->name;
3052 s->priority = priority;
3057 port_configure_bond(struct port *port, struct bond_settings *s,
3058 uint32_t *bond_stable_ids)
3060 const char *detect_s;
3061 struct iface *iface;
3062 int miimon_interval;
3065 s->name = port->name;
3067 if (port->cfg->bond_mode) {
3068 if (!bond_mode_from_string(&s->balance, port->cfg->bond_mode)) {
3069 VLOG_WARN("port %s: unknown bond_mode %s, defaulting to %s",
3070 port->name, port->cfg->bond_mode,
3071 bond_mode_to_string(s->balance));
3074 static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(1, 1);
3076 /* XXX: Post version 1.5.*, the default bond_mode changed from SLB to
3077 * active-backup. At some point we should remove this warning. */
3078 VLOG_WARN_RL(&rl, "port %s: Using the default bond_mode %s. Note that"
3079 " in previous versions, the default bond_mode was"
3080 " balance-slb", port->name,
3081 bond_mode_to_string(s->balance));
3083 if (s->balance == BM_SLB && port->bridge->cfg->n_flood_vlans) {
3084 VLOG_WARN("port %s: SLB bonds are incompatible with flood_vlans, "
3085 "please use another bond type or disable flood_vlans",
3089 miimon_interval = smap_get_int(&port->cfg->other_config,
3090 "bond-miimon-interval", 0);
3091 if (miimon_interval <= 0) {
3092 miimon_interval = 200;
3095 detect_s = smap_get(&port->cfg->other_config, "bond-detect-mode");
3096 if (!detect_s || !strcmp(detect_s, "carrier")) {
3097 miimon_interval = 0;
3098 } else if (strcmp(detect_s, "miimon")) {
3099 VLOG_WARN("port %s: unsupported bond-detect-mode %s, "
3100 "defaulting to carrier", port->name, detect_s);
3101 miimon_interval = 0;
3104 s->up_delay = MAX(0, port->cfg->bond_updelay);
3105 s->down_delay = MAX(0, port->cfg->bond_downdelay);
3106 s->basis = smap_get_int(&port->cfg->other_config, "bond-hash-basis", 0);
3107 s->rebalance_interval = smap_get_int(&port->cfg->other_config,
3108 "bond-rebalance-interval", 10000);
3109 if (s->rebalance_interval && s->rebalance_interval < 1000) {
3110 s->rebalance_interval = 1000;
3113 s->fake_iface = port->cfg->bond_fake_iface;
3116 LIST_FOR_EACH (iface, port_elem, &port->ifaces) {
3117 long long stable_id;
3119 stable_id = smap_get_int(&iface->cfg->other_config, "bond-stable-id",
3121 if (stable_id <= 0 || stable_id >= UINT32_MAX) {
3122 stable_id = iface->ofp_port;
3124 bond_stable_ids[i++] = stable_id;
3126 netdev_set_miimon_interval(iface->netdev, miimon_interval);
3130 /* Returns true if 'port' is synthetic, that is, if we constructed it locally
3131 * instead of obtaining it from the database. */
3133 port_is_synthetic(const struct port *port)
3135 return ovsdb_idl_row_is_synthetic(&port->cfg->header_);
3138 /* Interface functions. */
3141 iface_is_internal(const struct ovsrec_interface *iface,
3142 const struct ovsrec_bridge *br)
3144 /* The local port and "internal" ports are always "internal". */
3145 return !strcmp(iface->type, "internal") || !strcmp(iface->name, br->name);
3148 /* Returns the correct network device type for interface 'iface' in bridge
3151 iface_get_type(const struct ovsrec_interface *iface,
3152 const struct ovsrec_bridge *br)
3156 /* The local port always has type "internal". Other ports take
3157 * their type from the database and default to "system" if none is
3159 if (iface_is_internal(iface, br)) {
3162 type = iface->type[0] ? iface->type : "system";
3165 return ofproto_port_open_type(br->datapath_type, type);
3169 iface_destroy(struct iface *iface)
3172 struct port *port = iface->port;
3173 struct bridge *br = port->bridge;
3175 if (br->ofproto && iface->ofp_port >= 0) {
3176 ofproto_port_unregister(br->ofproto, iface->ofp_port);
3179 if (iface->ofp_port >= 0) {
3180 hmap_remove(&br->ifaces, &iface->ofp_port_node);
3183 list_remove(&iface->port_elem);
3184 hmap_remove(&br->iface_by_name, &iface->name_node);
3186 netdev_close(iface->netdev);
3193 static struct iface *
3194 iface_lookup(const struct bridge *br, const char *name)
3196 struct iface *iface;
3198 HMAP_FOR_EACH_WITH_HASH (iface, name_node, hash_string(name, 0),
3199 &br->iface_by_name) {
3200 if (!strcmp(iface->name, name)) {
3208 static struct iface *
3209 iface_find(const char *name)
3211 const struct bridge *br;
3213 HMAP_FOR_EACH (br, node, &all_bridges) {
3214 struct iface *iface = iface_lookup(br, name);
3223 static struct if_cfg *
3224 if_cfg_lookup(const struct bridge *br, const char *name)
3226 struct if_cfg *if_cfg;
3228 HMAP_FOR_EACH_WITH_HASH (if_cfg, hmap_node, hash_string(name, 0),
3230 if (!strcmp(if_cfg->cfg->name, name)) {
3238 static struct iface *
3239 iface_from_ofp_port(const struct bridge *br, uint16_t ofp_port)
3241 struct iface *iface;
3243 HMAP_FOR_EACH_IN_BUCKET (iface, ofp_port_node,
3244 hash_int(ofp_port, 0), &br->ifaces) {
3245 if (iface->ofp_port == ofp_port) {
3252 /* Set Ethernet address of 'iface', if one is specified in the configuration
3255 iface_set_mac(struct iface *iface)
3257 uint8_t ea[ETH_ADDR_LEN];
3259 if (!strcmp(iface->type, "internal")
3260 && iface->cfg->mac && eth_addr_from_string(iface->cfg->mac, ea)) {
3261 if (iface->ofp_port == OFPP_LOCAL) {
3262 VLOG_ERR("interface %s: ignoring mac in Interface record "
3263 "(use Bridge record to set local port's mac)",
3265 } else if (eth_addr_is_multicast(ea)) {
3266 VLOG_ERR("interface %s: cannot set MAC to multicast address",
3269 int error = netdev_set_etheraddr(iface->netdev, ea);
3271 VLOG_ERR("interface %s: setting MAC failed (%s)",
3272 iface->name, strerror(error));
3278 /* Sets the ofport column of 'if_cfg' to 'ofport'. */
3280 iface_set_ofport(const struct ovsrec_interface *if_cfg, int64_t ofport)
3282 if (if_cfg && !ovsdb_idl_row_is_synthetic(&if_cfg->header_)) {
3283 ovsrec_interface_set_ofport(if_cfg, &ofport, 1);
3287 /* Clears all of the fields in 'if_cfg' that indicate interface status, and
3288 * sets the "ofport" field to -1.
3290 * This is appropriate when 'if_cfg''s interface cannot be created or is
3291 * otherwise invalid. */
3293 iface_clear_db_record(const struct ovsrec_interface *if_cfg)
3295 if (!ovsdb_idl_row_is_synthetic(&if_cfg->header_)) {
3296 iface_set_ofport(if_cfg, -1);
3297 ovsrec_interface_set_status(if_cfg, NULL);
3298 ovsrec_interface_set_admin_state(if_cfg, NULL);
3299 ovsrec_interface_set_duplex(if_cfg, NULL);
3300 ovsrec_interface_set_link_speed(if_cfg, NULL, 0);
3301 ovsrec_interface_set_link_state(if_cfg, NULL);
3302 ovsrec_interface_set_mtu(if_cfg, NULL, 0);
3303 ovsrec_interface_set_cfm_fault(if_cfg, NULL, 0);
3304 ovsrec_interface_set_cfm_fault_status(if_cfg, NULL, 0);
3305 ovsrec_interface_set_cfm_remote_mpids(if_cfg, NULL, 0);
3306 ovsrec_interface_set_lacp_current(if_cfg, NULL, 0);
3307 ovsrec_interface_set_statistics(if_cfg, NULL, NULL, 0);
3311 struct iface_delete_queues_cbdata {
3312 struct netdev *netdev;
3313 const struct ovsdb_datum *queues;
3317 queue_ids_include(const struct ovsdb_datum *queues, int64_t target)
3319 union ovsdb_atom atom;
3321 atom.integer = target;
3322 return ovsdb_datum_find_key(queues, &atom, OVSDB_TYPE_INTEGER) != UINT_MAX;
3326 iface_delete_queues(unsigned int queue_id,
3327 const struct smap *details OVS_UNUSED, void *cbdata_)
3329 struct iface_delete_queues_cbdata *cbdata = cbdata_;
3331 if (!queue_ids_include(cbdata->queues, queue_id)) {
3332 netdev_delete_queue(cbdata->netdev, queue_id);
3337 iface_configure_qos(struct iface *iface, const struct ovsrec_qos *qos)
3339 struct ofpbuf queues_buf;
3341 ofpbuf_init(&queues_buf, 0);
3343 if (!qos || qos->type[0] == '\0' || qos->n_queues < 1) {
3344 netdev_set_qos(iface->netdev, NULL, NULL);
3346 struct iface_delete_queues_cbdata cbdata;
3350 /* Configure top-level Qos for 'iface'. */
3351 netdev_set_qos(iface->netdev, qos->type, &qos->other_config);
3353 /* Deconfigure queues that were deleted. */
3354 cbdata.netdev = iface->netdev;
3355 cbdata.queues = ovsrec_qos_get_queues(qos, OVSDB_TYPE_INTEGER,
3357 netdev_dump_queues(iface->netdev, iface_delete_queues, &cbdata);
3359 /* Configure queues for 'iface'. */
3361 for (i = 0; i < qos->n_queues; i++) {
3362 const struct ovsrec_queue *queue = qos->value_queues[i];
3363 unsigned int queue_id = qos->key_queues[i];
3365 if (queue_id == 0) {
3369 if (queue->n_dscp == 1) {
3370 struct ofproto_port_queue *port_queue;
3372 port_queue = ofpbuf_put_uninit(&queues_buf,
3373 sizeof *port_queue);
3374 port_queue->queue = queue_id;
3375 port_queue->dscp = queue->dscp[0];
3378 netdev_set_queue(iface->netdev, queue_id, &queue->other_config);
3381 struct smap details;
3383 smap_init(&details);
3384 netdev_set_queue(iface->netdev, 0, &details);
3385 smap_destroy(&details);
3389 if (iface->ofp_port >= 0) {
3390 const struct ofproto_port_queue *port_queues = queues_buf.data;
3391 size_t n_queues = queues_buf.size / sizeof *port_queues;
3393 ofproto_port_set_queues(iface->port->bridge->ofproto, iface->ofp_port,
3394 port_queues, n_queues);
3397 netdev_set_policing(iface->netdev,
3398 iface->cfg->ingress_policing_rate,
3399 iface->cfg->ingress_policing_burst);
3401 ofpbuf_uninit(&queues_buf);
3405 iface_configure_cfm(struct iface *iface)
3407 const struct ovsrec_interface *cfg = iface->cfg;
3408 const char *opstate_str;
3409 const char *cfm_ccm_vlan;
3410 struct cfm_settings s;
3411 struct smap netdev_args;
3413 if (!cfg->n_cfm_mpid) {
3414 ofproto_port_clear_cfm(iface->port->bridge->ofproto, iface->ofp_port);
3418 s.check_tnl_key = false;
3419 smap_init(&netdev_args);
3420 if (!netdev_get_config(iface->netdev, &netdev_args)) {
3421 const char *key = smap_get(&netdev_args, "key");
3422 const char *in_key = smap_get(&netdev_args, "in_key");
3424 s.check_tnl_key = (key && !strcmp(key, "flow"))
3425 || (in_key && !strcmp(in_key, "flow"));
3427 smap_destroy(&netdev_args);
3429 s.mpid = *cfg->cfm_mpid;
3430 s.interval = smap_get_int(&iface->cfg->other_config, "cfm_interval", 0);
3431 cfm_ccm_vlan = smap_get(&iface->cfg->other_config, "cfm_ccm_vlan");
3432 s.ccm_pcp = smap_get_int(&iface->cfg->other_config, "cfm_ccm_pcp", 0);
3434 if (s.interval <= 0) {
3438 if (!cfm_ccm_vlan) {
3440 } else if (!strcasecmp("random", cfm_ccm_vlan)) {
3441 s.ccm_vlan = CFM_RANDOM_VLAN;
3443 s.ccm_vlan = atoi(cfm_ccm_vlan);
3444 if (s.ccm_vlan == CFM_RANDOM_VLAN) {
3449 s.extended = smap_get_bool(&iface->cfg->other_config, "cfm_extended",
3452 opstate_str = smap_get(&iface->cfg->other_config, "cfm_opstate");
3453 s.opup = !opstate_str || !strcasecmp("up", opstate_str);
3455 ofproto_port_set_cfm(iface->port->bridge->ofproto, iface->ofp_port, &s);
3458 /* Returns true if 'iface' is synthetic, that is, if we constructed it locally
3459 * instead of obtaining it from the database. */
3461 iface_is_synthetic(const struct iface *iface)
3463 return ovsdb_idl_row_is_synthetic(&iface->cfg->header_);
3467 /* Port mirroring. */
3469 static struct mirror *
3470 mirror_find_by_uuid(struct bridge *br, const struct uuid *uuid)
3474 HMAP_FOR_EACH_IN_BUCKET (m, hmap_node, uuid_hash(uuid), &br->mirrors) {
3475 if (uuid_equals(uuid, &m->uuid)) {
3483 bridge_configure_mirrors(struct bridge *br)
3485 const struct ovsdb_datum *mc;
3486 unsigned long *flood_vlans;
3487 struct mirror *m, *next;
3490 /* Get rid of deleted mirrors. */
3491 mc = ovsrec_bridge_get_mirrors(br->cfg, OVSDB_TYPE_UUID);
3492 HMAP_FOR_EACH_SAFE (m, next, hmap_node, &br->mirrors) {
3493 union ovsdb_atom atom;
3495 atom.uuid = m->uuid;
3496 if (ovsdb_datum_find_key(mc, &atom, OVSDB_TYPE_UUID) == UINT_MAX) {
3501 /* Add new mirrors and reconfigure existing ones. */
3502 for (i = 0; i < br->cfg->n_mirrors; i++) {
3503 const struct ovsrec_mirror *cfg = br->cfg->mirrors[i];
3504 struct mirror *m = mirror_find_by_uuid(br, &cfg->header_.uuid);
3506 m = mirror_create(br, cfg);
3509 if (!mirror_configure(m)) {
3514 /* Update flooded vlans (for RSPAN). */
3515 flood_vlans = vlan_bitmap_from_array(br->cfg->flood_vlans,
3516 br->cfg->n_flood_vlans);
3517 ofproto_set_flood_vlans(br->ofproto, flood_vlans);
3518 bitmap_free(flood_vlans);
3521 static struct mirror *
3522 mirror_create(struct bridge *br, const struct ovsrec_mirror *cfg)
3526 m = xzalloc(sizeof *m);
3527 m->uuid = cfg->header_.uuid;
3528 hmap_insert(&br->mirrors, &m->hmap_node, uuid_hash(&m->uuid));
3530 m->name = xstrdup(cfg->name);
3536 mirror_destroy(struct mirror *m)
3539 struct bridge *br = m->bridge;
3542 ofproto_mirror_unregister(br->ofproto, m);
3545 hmap_remove(&br->mirrors, &m->hmap_node);
3552 mirror_collect_ports(struct mirror *m,
3553 struct ovsrec_port **in_ports, int n_in_ports,
3554 void ***out_portsp, size_t *n_out_portsp)
3556 void **out_ports = xmalloc(n_in_ports * sizeof *out_ports);
3557 size_t n_out_ports = 0;
3560 for (i = 0; i < n_in_ports; i++) {
3561 const char *name = in_ports[i]->name;
3562 struct port *port = port_lookup(m->bridge, name);
3564 out_ports[n_out_ports++] = port;
3566 VLOG_WARN("bridge %s: mirror %s cannot match on nonexistent "
3567 "port %s", m->bridge->name, m->name, name);
3570 *out_portsp = out_ports;
3571 *n_out_portsp = n_out_ports;
3575 mirror_configure(struct mirror *m)
3577 const struct ovsrec_mirror *cfg = m->cfg;
3578 struct ofproto_mirror_settings s;
3581 if (strcmp(cfg->name, m->name)) {
3583 m->name = xstrdup(cfg->name);
3587 /* Get output port or VLAN. */
3588 if (cfg->output_port) {
3589 s.out_bundle = port_lookup(m->bridge, cfg->output_port->name);
3590 if (!s.out_bundle) {
3591 VLOG_ERR("bridge %s: mirror %s outputs to port not on bridge",
3592 m->bridge->name, m->name);
3595 s.out_vlan = UINT16_MAX;
3597 if (cfg->output_vlan) {
3598 VLOG_ERR("bridge %s: mirror %s specifies both output port and "
3599 "output vlan; ignoring output vlan",
3600 m->bridge->name, m->name);
3602 } else if (cfg->output_vlan) {
3603 /* The database should prevent invalid VLAN values. */
3604 s.out_bundle = NULL;
3605 s.out_vlan = *cfg->output_vlan;
3607 VLOG_ERR("bridge %s: mirror %s does not specify output; ignoring",
3608 m->bridge->name, m->name);
3612 /* Get port selection. */
3613 if (cfg->select_all) {
3614 size_t n_ports = hmap_count(&m->bridge->ports);
3615 void **ports = xmalloc(n_ports * sizeof *ports);
3620 HMAP_FOR_EACH (port, hmap_node, &m->bridge->ports) {
3630 /* Get ports, dropping ports that don't exist.
3631 * The IDL ensures that there are no duplicates. */
3632 mirror_collect_ports(m, cfg->select_src_port, cfg->n_select_src_port,
3633 &s.srcs, &s.n_srcs);
3634 mirror_collect_ports(m, cfg->select_dst_port, cfg->n_select_dst_port,
3635 &s.dsts, &s.n_dsts);
3638 /* Get VLAN selection. */
3639 s.src_vlans = vlan_bitmap_from_array(cfg->select_vlan, cfg->n_select_vlan);
3642 ofproto_mirror_register(m->bridge->ofproto, m, &s);
3645 if (s.srcs != s.dsts) {
3654 /* Linux VLAN device support (e.g. "eth0.10" for VLAN 10.)
3656 * This is deprecated. It is only for compatibility with broken device drivers
3657 * in old versions of Linux that do not properly support VLANs when VLAN
3658 * devices are not used. When broken device drivers are no longer in
3659 * widespread use, we will delete these interfaces. */
3661 static struct ovsrec_port **recs;
3662 static size_t n_recs, allocated_recs;
3664 /* Adds 'rec' to a list of recs that have to be destroyed when the VLAN
3665 * splinters are reconfigured. */
3667 register_rec(struct ovsrec_port *rec)
3669 if (n_recs >= allocated_recs) {
3670 recs = x2nrealloc(recs, &allocated_recs, sizeof *recs);
3672 recs[n_recs++] = rec;
3675 /* Frees all of the ports registered with register_reg(). */
3677 free_registered_recs(void)
3681 for (i = 0; i < n_recs; i++) {
3682 struct ovsrec_port *port = recs[i];
3685 for (j = 0; j < port->n_interfaces; j++) {
3686 struct ovsrec_interface *iface = port->interfaces[j];
3691 smap_destroy(&port->other_config);
3692 free(port->interfaces);
3700 /* Returns true if VLAN splinters are enabled on 'iface_cfg', false
3703 vlan_splinters_is_enabled(const struct ovsrec_interface *iface_cfg)
3705 return smap_get_bool(&iface_cfg->other_config, "enable-vlan-splinters",
3709 /* Figures out the set of VLANs that are in use for the purpose of VLAN
3712 * If VLAN splinters are enabled on at least one interface and any VLANs are in
3713 * use, returns a 4096-bit bitmap with a 1-bit for each in-use VLAN (bits 0 and
3714 * 4095 will not be set). The caller is responsible for freeing the bitmap,
3717 * If VLANs splinters are not enabled on any interface or if no VLANs are in
3718 * use, returns NULL.
3720 * Updates 'vlan_splinters_enabled_anywhere'. */
3721 static unsigned long int *
3722 collect_splinter_vlans(const struct ovsrec_open_vswitch *ovs_cfg)
3724 unsigned long int *splinter_vlans;
3725 struct sset splinter_ifaces;
3726 const char *real_dev_name;
3727 struct shash *real_devs;
3728 struct shash_node *node;
3732 /* Free space allocated for synthesized ports and interfaces, since we're
3733 * in the process of reconstructing all of them. */
3734 free_registered_recs();
3736 splinter_vlans = bitmap_allocate(4096);
3737 sset_init(&splinter_ifaces);
3738 vlan_splinters_enabled_anywhere = false;
3739 for (i = 0; i < ovs_cfg->n_bridges; i++) {
3740 struct ovsrec_bridge *br_cfg = ovs_cfg->bridges[i];
3743 for (j = 0; j < br_cfg->n_ports; j++) {
3744 struct ovsrec_port *port_cfg = br_cfg->ports[j];
3747 for (k = 0; k < port_cfg->n_interfaces; k++) {
3748 struct ovsrec_interface *iface_cfg = port_cfg->interfaces[k];
3750 if (vlan_splinters_is_enabled(iface_cfg)) {
3751 vlan_splinters_enabled_anywhere = true;
3752 sset_add(&splinter_ifaces, iface_cfg->name);
3753 vlan_bitmap_from_array__(port_cfg->trunks,
3759 if (port_cfg->tag && *port_cfg->tag > 0 && *port_cfg->tag < 4095) {
3760 bitmap_set1(splinter_vlans, *port_cfg->tag);
3765 if (!vlan_splinters_enabled_anywhere) {
3766 free(splinter_vlans);
3767 sset_destroy(&splinter_ifaces);
3771 HMAP_FOR_EACH (br, node, &all_bridges) {
3773 ofproto_get_vlan_usage(br->ofproto, splinter_vlans);
3777 /* Don't allow VLANs 0 or 4095 to be splintered. VLAN 0 should appear on
3778 * the real device. VLAN 4095 is reserved and Linux doesn't allow a VLAN
3779 * device to be created for it. */
3780 bitmap_set0(splinter_vlans, 0);
3781 bitmap_set0(splinter_vlans, 4095);
3783 /* Delete all VLAN devices that we don't need. */
3785 real_devs = vlandev_get_real_devs();
3786 SHASH_FOR_EACH (node, real_devs) {
3787 const struct vlan_real_dev *real_dev = node->data;
3788 const struct vlan_dev *vlan_dev;
3789 bool real_dev_has_splinters;
3791 real_dev_has_splinters = sset_contains(&splinter_ifaces,
3793 HMAP_FOR_EACH (vlan_dev, hmap_node, &real_dev->vlan_devs) {
3794 if (!real_dev_has_splinters
3795 || !bitmap_is_set(splinter_vlans, vlan_dev->vid)) {
3796 struct netdev *netdev;
3798 if (!netdev_open(vlan_dev->name, "system", &netdev)) {
3799 if (!netdev_get_in4(netdev, NULL, NULL) ||
3800 !netdev_get_in6(netdev, NULL)) {
3801 vlandev_del(vlan_dev->name);
3803 /* It has an IP address configured, so we don't own
3804 * it. Don't delete it. */
3806 netdev_close(netdev);
3813 /* Add all VLAN devices that we need. */
3814 SSET_FOR_EACH (real_dev_name, &splinter_ifaces) {
3817 BITMAP_FOR_EACH_1 (vid, 4096, splinter_vlans) {
3818 if (!vlandev_get_name(real_dev_name, vid)) {
3819 vlandev_add(real_dev_name, vid);
3826 sset_destroy(&splinter_ifaces);
3828 if (bitmap_scan(splinter_vlans, 0, 4096) >= 4096) {
3829 free(splinter_vlans);
3832 return splinter_vlans;
3835 /* Pushes the configure of VLAN splinter port 'port' (e.g. eth0.9) down to
3838 configure_splinter_port(struct port *port)
3840 struct ofproto *ofproto = port->bridge->ofproto;
3841 uint16_t realdev_ofp_port;
3842 const char *realdev_name;
3843 struct iface *vlandev, *realdev;
3845 ofproto_bundle_unregister(port->bridge->ofproto, port);
3847 vlandev = CONTAINER_OF(list_front(&port->ifaces), struct iface,
3850 realdev_name = smap_get(&port->cfg->other_config, "realdev");
3851 realdev = iface_lookup(port->bridge, realdev_name);
3852 realdev_ofp_port = realdev ? realdev->ofp_port : 0;
3854 ofproto_port_set_realdev(ofproto, vlandev->ofp_port, realdev_ofp_port,
3858 static struct ovsrec_port *
3859 synthesize_splinter_port(const char *real_dev_name,
3860 const char *vlan_dev_name, int vid)
3862 struct ovsrec_interface *iface;
3863 struct ovsrec_port *port;
3865 iface = xmalloc(sizeof *iface);
3866 ovsrec_interface_init(iface);
3867 iface->name = xstrdup(vlan_dev_name);
3868 iface->type = "system";
3870 port = xmalloc(sizeof *port);
3871 ovsrec_port_init(port);
3872 port->interfaces = xmemdup(&iface, sizeof iface);
3873 port->n_interfaces = 1;
3874 port->name = xstrdup(vlan_dev_name);
3875 port->vlan_mode = "splinter";
3876 port->tag = xmalloc(sizeof *port->tag);
3879 smap_add(&port->other_config, "realdev", real_dev_name);
3885 /* For each interface with 'br' that has VLAN splinters enabled, adds a
3886 * corresponding ovsrec_port to 'ports' for each splinter VLAN marked with a
3887 * 1-bit in the 'splinter_vlans' bitmap. */
3889 add_vlan_splinter_ports(struct bridge *br,
3890 const unsigned long int *splinter_vlans,
3891 struct shash *ports)
3895 /* We iterate through 'br->cfg->ports' instead of 'ports' here because
3896 * we're modifying 'ports'. */
3897 for (i = 0; i < br->cfg->n_ports; i++) {
3898 const char *name = br->cfg->ports[i]->name;
3899 struct ovsrec_port *port_cfg = shash_find_data(ports, name);
3902 for (j = 0; j < port_cfg->n_interfaces; j++) {
3903 struct ovsrec_interface *iface_cfg = port_cfg->interfaces[j];
3905 if (vlan_splinters_is_enabled(iface_cfg)) {
3906 const char *real_dev_name;
3909 real_dev_name = iface_cfg->name;
3910 BITMAP_FOR_EACH_1 (vid, 4096, splinter_vlans) {
3911 const char *vlan_dev_name;
3913 vlan_dev_name = vlandev_get_name(real_dev_name, vid);
3915 && !shash_find(ports, vlan_dev_name)) {
3916 shash_add(ports, vlan_dev_name,
3917 synthesize_splinter_port(
3918 real_dev_name, vlan_dev_name, vid));
3927 mirror_refresh_stats(struct mirror *m)
3929 struct ofproto *ofproto = m->bridge->ofproto;
3930 uint64_t tx_packets, tx_bytes;
3933 size_t stat_cnt = 0;
3935 if (ofproto_mirror_get_stats(ofproto, m, &tx_packets, &tx_bytes)) {
3936 ovsrec_mirror_set_statistics(m->cfg, NULL, NULL, 0);
3940 if (tx_packets != UINT64_MAX) {
3941 keys[stat_cnt] = "tx_packets";
3942 values[stat_cnt] = tx_packets;
3945 if (tx_bytes != UINT64_MAX) {
3946 keys[stat_cnt] = "tx_bytes";
3947 values[stat_cnt] = tx_bytes;
3951 ovsrec_mirror_set_statistics(m->cfg, keys, values, stat_cnt);