datapath: Fix inconsistency in upstream and out of tree ovs module.
authorPravin B Shelar <pshelar@nicira.com>
Thu, 18 Apr 2013 23:00:48 +0000 (16:00 -0700)
committerPravin B Shelar <pshelar@nicira.com>
Fri, 19 Apr 2013 16:35:10 +0000 (09:35 -0700)
There is a inconsistent ordering in function ovs_vport_cmd_set()
between upstream and out of tree ovs module. Following patch
fixes it by releasing lock before calling ovs_notify.

Signed-off-by: Pravin B Shelar <pshelar@nicira.com>
Acked-by: Jesse Gross <jesse@nicira.com>
datapath/datapath.c

index a8bb5b8..3cb58b0 100644 (file)
@@ -2130,9 +2130,8 @@ static int ovs_vport_cmd_set(struct sk_buff *skb, struct genl_info *info)
                                      info->snd_seq, 0, OVS_VPORT_CMD_NEW);
        BUG_ON(err < 0);
 
-       ovs_notify(reply, info, &ovs_dp_vport_multicast_group);
-
        ovs_unlock();
+       ovs_notify(reply, info, &ovs_dp_vport_multicast_group);
        return 0;
 
 exit_free: